Times are UTC Toggle Colours
00:52:19 *** Smedles has quit IRC 00:55:39 *** Smedles has joined #openttd 01:01:56 *** snail_UES_ is now known as Guest12549 01:01:56 *** snail_UES__ has joined #openttd 01:01:57 *** snail_UES__ is now known as snail_UES_ 01:07:12 *** sla_ro|master has quit IRC 01:37:57 *** Progman has quit IRC 01:47:37 *** snail_UES_ has quit IRC 02:41:16 *** APTX has quit IRC 02:41:22 *** APTX has joined #openttd 03:08:55 *** debdog has joined #openttd 03:12:12 *** D-HUND has quit IRC 03:39:32 *** HerzogDeXtEr has joined #openttd 04:14:30 *** Wormnest has joined #openttd 04:24:09 *** glx has quit IRC 04:24:37 *** Zorix has joined #openttd 04:25:35 <Zorix> So I am checking out OpenTTD, and I have an interesting issue. The copy of TTD I had since I was a kid does not seem to have the GRF files listed in the readme 04:27:17 <Zorix> these are the files from the installation: https://pastebin.com/raw/bedVA44v 04:37:17 <Pikka> that looks like the original TT to me, not TTD 04:38:10 <Zorix> interesting, yes, I started the game and it does not say deluxe, however the CD itself does say Deluxe 04:38:46 <Zorix> the game also has a tile set that looks like another planet, craters and red water 04:39:45 <Pikka> that's the mars tile set that came with the TTO scenario editor addon 04:40:05 <Zorix> oh 04:40:24 <Pikka> I do vaguely remember hearing about that before, an edition which was TTO + WE labeled as "Deluxe" 04:40:37 <Zorix> very interesting, the jewel case documentation has a date of 10/97 04:41:04 <Zorix> yea I think maybe this was not original, it says it was distributed by GT ValueProducts Division 04:41:25 <Zorix> I did buy this in the store in the late 90s I think, so it was not pirated 04:41:51 <Zorix> what is WE? 04:41:59 <Pikka> world editor 04:42:16 <Zorix> oh, I should have seen that. haha 04:42:33 <Zorix> It does have readme files that mention the world editor too 04:43:14 <Zorix> I wonder if this is an uncommon/rare release? 04:46:03 <Pikka> https://www.tt-forums.net/viewtopic.php?f=12&t=73268 there's one old thread about it, I did remember :) 04:47:04 <Zorix> Turns out there's an ebay listing for the exact same disc I have: https://www.ebay.com/itm/Play-in-Windows-XP-10-Transport-Tycoon-Deluxe-by-Microprose/164003603347?hash=item262f606393:g:k10AAOSwE-pdszIf 04:48:11 <Zorix> Oh neat 04:48:30 <Zorix> Would be cool to support the tile set for this game though 04:49:05 <Pikka> I think there's a newgrf which brings the mars graphics over 04:50:12 <Zorix> Nice! 04:50:46 <Zorix> I appreciate the help with the confusion on this, it definitely helps 05:26:08 *** Andrew350 has joined #openttd 05:32:30 *** Wormnest has quit IRC 06:28:31 *** Smedles has quit IRC 06:29:47 *** Smedles has joined #openttd 06:47:17 *** tokai|noir has joined #openttd 06:47:17 *** ChanServ sets mode: +v tokai|noir 06:54:08 *** tokai has quit IRC 06:54:51 *** Wormnest has joined #openttd 07:39:25 *** Smedles has quit IRC 07:40:44 *** Smedles has joined #openttd 07:47:30 *** Wormnest has quit IRC 08:19:39 *** Smedles has quit IRC 08:20:31 *** Smedles has joined #openttd 08:29:41 *** andythenorth has joined #openttd 08:29:49 <andythenorth> bring back V453000 I say 08:31:08 *** sla_ro|master has joined #openttd 08:42:17 <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth commented on pull request #7852: Feature: Show the name of the NewGRF in the build vehicle window. https://git.io/JeNnP 08:43:23 <LordAro> @seen V453000 08:43:24 <DorpsGek> LordAro: V453000 was last seen in #openttd 10 weeks, 4 days, 14 hours, 10 minutes, and 48 seconds ago: <V453000> yeah, our art director had some good time with flash too 08:46:05 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #7852: Feature: Show the name of the NewGRF in the build vehicle window. https://git.io/JeNnD 08:55:56 <andythenorth> maybe I should buy a bigger laptop 08:56:01 <andythenorth> then I could fit more openttd in 08:57:23 <andythenorth> ideally I'd use 4x UI zoom with 2x font zoom :D 09:06:24 <LordAro> :p 09:13:08 *** nielsm has joined #openttd 09:16:23 *** lpx has quit IRC 09:19:21 <nielsm> did anyone have nmlc binaries for windows? https://www.tt-forums.net/viewtopic.php?p=1227960#p1227960 09:21:30 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #7880: Fix: Fixing the slopes was being done twice on heightmaps when one suffices https://git.io/JeNcI 09:21:53 <andythenorth> https://github.com/OpenTTD/nml/issues/42 09:21:57 <LordAro> need to do an nml release 09:21:58 <andythenorth> nielsm: ^ 09:22:35 <andythenorth> I would really like to see this merged to nml master at least https://github.com/OpenTTD/nml/pull/66 09:22:41 <andythenorth> I have 2 brances in Horse currently 09:23:00 <andythenorth> can't make commits to master that don't build with master nmlc 09:23:15 <andythenorth> and can't stick non-procedure related commits in my procedures branch :P 09:23:42 <andythenorth> due to mistakes switching branches, there has been a lot of rebase -i :P 09:23:52 <andythenorth> and stash and conflict unpicking 09:24:28 <DorpsGek_III> [OpenTTD/nml] LordAro approved pull request #66: Add: allow use of switches and random switches as procedures https://git.io/JeNcL 09:25:17 <andythenorth> huzzah :) 09:25:32 <LordAro> i'm not going to merge it, i can only do code reviews with nml 09:25:38 <LordAro> i don't understand what it's doing :p 09:27:23 <andythenorth> thanks :) 09:29:12 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #7880: Fix: Fixing the slopes was being done twice on heightmaps when one suffices https://git.io/JeNcm 09:29:49 *** lpx has joined #openttd 09:31:38 <DorpsGek_III> [OpenTTD/nml] LordAro dismissed a review for pull request #75: Fix ottd_display_speed to reflect changes done in OpenTTD https://git.io/JedUN 09:40:39 <DorpsGek_III> [OpenTTD/nml] LordAro requested changes for pull request #78: Add: optimise switches https://git.io/JeNcG 09:41:18 <DorpsGek_III> [OpenTTD/nml] LordAro approved pull request #70: Binop cleanup https://git.io/JeNcZ 09:51:21 <andythenorth> oof 09:51:37 <andythenorth> cdist was working great with 'refit any available' 09:52:15 <andythenorth> but there's one cargo that goes A-D 09:52:28 <andythenorth> and it's decided to load it A-B-C-B-A 09:52:41 <andythenorth> because A is a valid hop to D :P 09:56:05 <andythenorth> 'no-loading' at C should break the connection 09:56:08 * andythenorth waits 10:00:28 <TrueBrain> right .. 'cdk deploy Live-*', here we go \o/ :) Time to test out this AWS stuff everyone is talking about :P 10:01:41 <TrueBrain> hmm .. the DigitalOcean kubernetes cluster is acting up .. well, guess that is a sign :P 10:03:16 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro updated pull request #7550: Add: Screenshot window (& simplify the about/help DropDown) https://git.io/fjGP1 10:03:27 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #7550: Add: Screenshot window (& simplify the about/help DropDown) https://git.io/JeNcz 10:03:47 <LordAro> TrueBrain: hype! 10:04:47 <andythenorth> Pikka: no deltics? 10:04:49 <andythenorth> right? 10:13:44 <TrueBrain> owh DNS, why are you always this difficult to deal with ... 10:13:55 <TrueBrain> I wish someone would find a better way tbh 10:14:40 <TrueBrain> negative results are cached for 15 minutes .. damn .. 10:16:58 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro updated pull request #7550: Add: Screenshot window (& simplify the about/help DropDown) https://git.io/fjGP1 10:17:13 <LordAro> apparently sdl2 files were not added to the project files properly 10:17:46 <TrueBrain> switch to CMake and be done with it :P 10:17:57 <LordAro> :< 10:18:39 <TrueBrain> as the more likely case is that the SDL2 PR person didn't run the script :P So easily forgotten .. 10:18:42 <TrueBrain> we could add a CI hook for it 10:18:50 <TrueBrain> but having multiple systems is just a PITA 10:18:58 <LordAro> aye 10:23:03 <TrueBrain> awh, the CI doesn't like your changes :( 10:24:03 <LordAro> :( 10:26:31 <FLHerne> LordAro: there are a few more changes I'd like to make to #70, so please don't merge it ;-) 10:27:05 <LordAro> FLHerne: please comment as such :) 10:27:11 <LordAro> i had no intention of merging it 10:27:23 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #7880: Fix: Fixing the slopes was being done twice on heightmaps when one suffices https://git.io/JeNcM 10:28:06 <DorpsGek_III> [OpenTTD/nml] FLHerne commented on pull request #70: Binop cleanup https://git.io/JeNcD 10:31:22 *** Progman has joined #openttd 10:32:15 *** WormnestAndroid has quit IRC 10:32:27 *** WormnestAndroid has joined #openttd 10:33:24 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro updated pull request #7550: Add: Screenshot window (& simplify the about/help DropDown) https://git.io/fjGP1 10:33:25 <LordAro> TrueBrain: didn't realise i had to add the #include myself :) 10:33:39 <LordAro> (and then didn't try compiling after running the script) 10:33:42 <LordAro> (bad LordAro) 10:34:07 <TrueBrain> :D 10:34:52 *** Samu has joined #openttd 10:35:29 <TrueBrain> annoying that the k8s cluster is unreachable .. owh well, I know what should be running on it, so I should be fine, I guess :D 10:39:09 <Samu> can't reach this page https://www.openttd.org/ 10:39:33 <TrueBrain> try stretching? 10:49:15 <andythenorth> oof 10:49:30 * andythenorth wonders if cdist needs a 'break the link' option for specific cargos at specific stations :P 10:49:51 <andythenorth> https://www.youtube.com/watch?v=KiESiO6tLM8 10:50:06 <nielsm> oh yeah anyone want to merge this one? https://github.com/OpenTTD/OpenTTD/pull/7747 10:50:21 <Samu> FlatEmptyWorld does require FixSlopes apparently, gonna check 10:50:22 <nielsm> it's the anniversary of the commit that removed the "ending year" setting back in 2008 :D 10:50:53 <LordAro> nielsm: :D 10:52:00 <LordAro> nielsm: as a future enhancement, the OGFX/TTD sprites should be altered to exclude the date/have it in a fixed position that the game can fill in 10:53:51 <LordAro> nielsm: i don't quite follow why _old_ending_year_slv_105 is necessary 10:54:06 <LordAro> certainly doesn't seem like it should be in date.cpp 10:56:33 *** snail_UES_ has joined #openttd 11:00:34 <andythenorth> BBL 11:00:36 *** andythenorth has quit IRC 11:03:22 <Samu> looks like FixSlopes isn't required for Original generator 11:03:31 <Samu> still making sure... 11:05:30 <LordAro> Samu: think it was only added for TGP, so wouldn't surprise me 11:05:33 <Samu> FixSlopes is run, but nothing was fixed 11:06:33 *** Wolf01 has joined #openttd 11:07:25 <nielsm> LordAro: I'm really not sure if it's okay to have two setting definitions on the same variable, with disjoint revisions 11:08:10 <nielsm> honestly I didn't even test what happens if I try to do it, it just seems like the settings gui wouldn't be able to handle it 11:08:15 <nielsm> at the very least 11:13:01 <Samu> FlatEmptyWorld requires FixSlopes if freeform_edges is off 11:13:06 <Samu> if it's on, it doesn't 11:13:36 <Samu> more precisely, if freeform_edges is off and the height is not 0 11:16:25 <Samu> original landscape generator doesn't have much documentation :( 11:18:08 <nielsm> because it's just lifted straight from TTD disassembly and barely touched since 11:19:09 *** andythenorth has joined #openttd 11:19:14 <Wolf01> o/ 11:20:22 <Samu> these loops from line 911 to 920 and the 3 others below seems to set straight the tile heights 11:21:09 <Pikka> andythenorth, deltics possibly? 11:21:26 <andythenorth> I am sticking with 'no' 11:21:31 <andythenorth> and no garratt :P 11:22:13 <Samu> GB(*p, 0, 4) so this is how the height 15 is set 11:22:17 <Samu> lel 11:22:54 <andythenorth> oh this is interesting Pikka :) 11:23:19 <Pikka> hmm? 11:23:20 <andythenorth> https://dev.openttdcoop.org/attachments/download/9565/civil-wind.png 11:23:29 <andythenorth> it has accidentally built the correct pax coaches 11:23:33 <andythenorth> probably due to matching speed 11:23:53 <andythenorth> each 'helm wind middle' adds 1700hp to the engine 11:24:12 <andythenorth> although the lack of high speed mail vans is a bit of a nerf :P 11:24:34 <andythenorth> should be 140mph :D 11:25:35 <TrueBrain> I hate DNS .. why does it never do what I want it to do :( 11:25:40 <Pikka> interesting 11:26:54 <Pikka> losing some serious money though ;) 11:28:43 <andythenorth> one station doesn't supply enough pax 11:29:12 <andythenorth> I think it's scrapping these trains 11:30:14 <andythenorth> generally it's doing pretty well 11:30:19 <Pikka> :) 11:30:22 <andythenorth> oh it's built a narrow gauge container train :) 11:30:36 <Pikka> odd? :) 11:30:40 <andythenorth> nah fine 11:30:50 <andythenorth> cheap 11:31:25 <andythenorth> does the pruple name associate with the pruple CC? o_O 11:31:42 <Pikka> yes 11:33:49 <Pikka> doing some newgrf stuff first but I think the next thing I want to work on with the AI is some pathfinder preprocessing... try and get the road/rail construction happening a lot faster and more reliably. 11:34:07 <TrueBrain> https://www.staging.openttd.org/ <- this should now work, both IPv4 and IPv6 11:34:13 <TrueBrain> now lets see if auto-deploy also works .. 11:35:43 <TrueBrain> 20191218 version is running on it now .. hopefully it should soon be updated to the latest .. pampam pammmmmm 11:37:23 <TrueBrain> https://github.com/TrueBrain/OpenTTD-website/commit/b6c602ceae07cf18763f3bf2f167d1577ef51b72/checks?check_suite_id=376719310 11:37:29 <TrueBrain> at least that looks better than Azure Pipelines :) 11:39:51 <TrueBrain> hmm .. it didn't publish :( Booooo 11:39:59 <TrueBrain> well, first lunch I guess 11:41:27 <milek7_> does it should look like this? https://imgur.com/MwpscUP.png 11:45:00 <LordAro> milek7_: i've noticed that as well 11:45:13 <LordAro> something's adding padding that it shouldn't be 11:45:23 <LordAro> or text sizes are slightly different 11:45:36 <LordAro> basically, the menu needs redoing so it's not quite so hardcoded 11:47:23 <milek7_> it doesn't fit in width 11:47:50 <milek7_> removing one button moves it back into place 11:49:25 <LordAro> yeah 11:49:42 *** andythenorth has quit IRC 11:50:42 <Samu> ConvertGroundTilesIntoWaterTiles could also be tweaked 11:50:54 <Samu> it doesn't need to run on a flat map 11:51:01 *** Speedy` has quit IRC 11:51:01 <Samu> when the height is not 0 11:51:10 <Samu> gonna experiment 11:53:07 <nielsm> probably not worth the time to test for 11:57:18 <LordAro> nielsm: when has that ever stopped Samu? 11:57:34 <Samu> haha 11:58:08 *** snail_UES_ has quit IRC 11:58:46 <Samu> if some speed could be gained, I guess it's worth it 12:00:58 <Wolf01> <milek7_> removing one button moves it back into place <- remove manual, nobody reads that anyway :P 12:03:08 <LordAro> Samu: https://xkcd.com/1205/ 12:05:34 *** andythenorth has joined #openttd 12:06:32 <Samu> as I suspected, no conversion to water tiles when a flat map is of heigt 1 12:06:37 <Samu> confirmed 12:07:00 <Samu> takes about 2.5 seconds to iterate a 4096/4096 flat map 12:13:49 <Samu> hmm what happens before _GenerateWorld is kinda slow 12:18:50 <Samu> InitializeLandScape is slow, namely MakeClear 12:18:57 <Samu> well, screw it 12:20:38 <Samu> wondering why call SetTileOwner instead of setting directly the owner 12:20:54 <Samu> it would avoid checking those asserts 12:21:05 <LordAro> Samu: release builds don't check asserts anyway 12:21:15 <LordAro> and a boolean check is unlikely to be relevant 12:21:30 <LordAro> besides, why would you want to avoid those asserts? they're there for a reason 12:22:02 <Samu> because it has just set the tiletype to 0 12:22:23 <Samu> doesn't need to assert 12:22:35 <Samu> if the tile type is valid for an owner 12:23:05 <Samu> it's on MakeClear 12:23:55 <Samu> okay, nevermind 12:24:04 <Samu> guess asserts are there to stay 12:26:57 <LordAro> Samu: doesn't need to, but code reuse means that sometimes redundant things are done 12:27:17 <LordAro> you try to keep things to a minimum, but sometimes it's necessary 12:28:14 <Samu> I have 3 fixes ready, but im not sure i add them to the same PR 12:28:15 *** andythenorth has joined #openttd 12:28:41 <Samu> - FixSlopes not needed for original landscape 12:29:27 <Samu> - FixSlopes on FlatEmptyWorld only needed when height is > 1 and freeform_edges is off 12:30:24 <Samu> - ConvertGroundTilesIntoWater on FlatEmptyWorld only needed when freeform_edges is off or if it's on, when height is != 0 12:30:58 <Samu> i mean == 0 12:36:18 *** andythenorth has quit IRC 12:44:55 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7786: Add: Help and manuals window https://git.io/JeBQt 12:52:03 <TrueBrain> so in docker world it is "image:tag" or "image@sha256:hash" 12:52:06 <TrueBrain> ... whyyyy :( 12:52:38 <LordAro> is that unreasonable? 12:53:27 <TrueBrain> maybe not, but ECS doesn't allow me to do that :) 12:53:32 <TrueBrain> so I now have to pick either one 12:54:16 <TrueBrain> this AWS venture has been a constant pileup of these kind of small things :P 12:55:02 <nielsm> more hacking on the textfile viewer https://0x0.st/zD0j.png 12:56:36 <TrueBrain> no markdown support? :D 12:56:53 <nielsm> I'm thinking of doing some hacky limited support for clickable links 12:56:57 <nielsm> max 1 link per line 12:57:04 <nielsm> (physical line in original file) 13:14:06 <TrueBrain> lol .. I now get 500 errors from Docker Hub 13:14:08 <TrueBrain> jolly :) 13:16:42 <TrueBrain> the sha256 changes after pushing .. how annoying .. 13:21:14 <TrueBrain> and requesting unknown sha256s, returns a 500 13:21:23 <TrueBrain> sounds like some good programming in their backend :P (we know for a while there isn't) 13:22:05 <LordAro> deary me 13:22:13 <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick updated pull request #7880: Fix: Fixing the slopes was being done twice on heightmaps when one suffices https://git.io/JeNLr 13:29:14 <Andrew350> I've done a few things: https://newgrf-specs.tt-wiki.net/index.php?title=Special:RecentChanges&limit=100 13:29:32 <Andrew350> This page is looking more 'done' now: https://wiki.openttd.org/NewGRF_Specification_Status 13:33:58 <nielsm> oops, broke it. https://0x0.st/zD0V.mp4 13:36:51 <Samu> I feel I need to fix commit description 13:38:44 <TrueBrain> https://www.staging.openttd.org/ <- w00p! It updated automagically :D https://github.com/TrueBrain/OpenTTD-website/runs/366047074 did that, which also shows https://github.com/TrueBrain/OpenTTD-website/deployments here what it did :) Okay, this is pretty nifty :) (and yes, I did not rebase, so there is no beta2 post) 13:49:22 <LordAro> TrueBrain: nice 13:50:43 <TrueBrain> updated it to master, just to be nice :) 13:52:08 *** glx has joined #openttd 13:52:08 *** ChanServ sets mode: +v glx 13:52:25 <TrueBrain> now I have to figure out how to trigger a rebuild every time there is a new binary release :D 13:55:30 <Samu> there is a small terrain generation error with original generator when freeform_edges is on, at the top left and right borders 13:55:38 <Samu> it closes water passage 13:56:01 <Samu> and everything towards that border feels 1 tile closer 13:56:49 <Samu> them borders* 14:01:01 <peter1138> I mean, that's technically what freeform_edges does, but... 14:01:23 <peter1138> Or was that another option. Hm. 14:01:58 <Samu> NE and NW borders 14:04:44 <LordAro> certainly that's originally how it worked, afaik 14:04:54 <LordAro> MP_VOID, or some such 14:08:19 *** Flygon has quit IRC 14:09:19 <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #113: Change: semantic HTML-elements for the pages main sections https://git.io/JeNWj 14:14:54 <milek7_> TrueBrain: #screenshot { text-align: center; } 14:15:29 <TrueBrain> milek7_: don't tell me! PR it :) 14:15:57 *** Speedy` has joined #openttd 14:16:21 <Samu> gotta understand what's happening inside GenerateTerrain 14:16:26 <Samu> will take a while 14:25:05 <Samu> okay, i managed to open water passage towards NE and NW, but now the bottom side borders have enlarged by 1 tile 14:25:26 <Samu> minimum 2 tile wide water passage there :( 14:25:42 <Samu> feels like the whole terrain was shifted (-1, -1) 14:26:09 <Samu> maybe not 14:26:19 <Samu> it shrinked 14:35:05 <DorpsGek_III> [OpenTTD/website] Milek7 opened pull request #121: Fix screenshot align https://git.io/JeNlE 14:41:14 <DorpsGek_III> [OpenTTD/website] TrueBrain approved pull request #121: Fix screenshot align https://git.io/JeNla 14:42:02 <DorpsGek_III> [OpenTTD/website] TrueBrain merged pull request #121: Fix screenshot align https://git.io/JeNlE 14:42:08 <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #121: Fix screenshot align https://git.io/JeNlw 14:45:38 *** HerzogDeXtEr has quit IRC 14:47:21 *** andythenorth has joined #openttd 14:47:22 *** frosch123 has joined #openttd 14:48:23 <andythenorth> Pikka: well https://en.wikipedia.org/wiki/British_Rail_HS4000 14:48:27 <andythenorth> it's not a deltic :P 14:48:43 <LordAro> i'll see if i can backport my menu changes without any of the other layout changes 14:48:55 <LordAro> should hopefully fix the overrun that's currently there 14:51:13 <DorpsGek_III> [OpenTTD/website] Milek7 opened pull request #122: Widen nav to 825px https://git.io/JeNlX 14:51:32 <LordAro> or i guess that would work as well 14:53:54 <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #122: Widen nav to 825px https://git.io/JeNlS 14:54:57 <andythenorth> website needs a rebuild 14:55:03 * andythenorth not doing that right now though 14:55:20 <andythenorth> also I made suggestions, but they got consens-ed 14:55:24 <DorpsGek_III> [OpenTTD/website] Milek7 commented on pull request #122: Widen nav to 825px https://git.io/JeNlH 14:55:31 <TrueBrain> sounds like the easy solution: REBUILD! As if that fixes anything ;) 14:55:37 <TrueBrain> still waiting on ... any of the rebuilds I was promised :P 14:55:40 <andythenorth> for websites it does 14:55:50 <TrueBrain> rebuilding for rebuilding is never a good idea 14:56:03 <andythenorth> we already rebuilt it to jekyll 14:56:18 <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #122: Widen nav to 825px https://git.io/JeNlQ 14:56:21 <andythenorth> this obviously concludes on the axe parable 14:56:27 <andythenorth> head, handle, axe 14:57:11 <TrueBrain> guess 'website' needs an issue and pull-request template too ... 14:57:27 <andythenorth> possibly 14:57:37 <andythenorth> it seems to attract drive-by PRs, which is good 14:57:49 <andythenorth> but then they are hard to review + approve, because lack of goals 14:57:56 <andythenorth> which is bad :) 14:58:03 <TrueBrain> "lack of goals", yet another non-statement 14:58:08 <TrueBrain> it is xmas, please don't be like this :) 14:58:20 <DorpsGek_III> [OpenTTD/website] TrueBrain updated pull request #116: Various of fixes in preparation of running this Docker on AWS https://git.io/Jed5i 14:58:36 <TrueBrain> LordAro: if you have some idle cycles, I would love for you to give the above PR another look :) 14:58:40 *** andythenorth has left #openttd 15:00:00 <DorpsGek_III> [OpenTTD/website] Milek7 commented on pull request #122: Widen nav to 825px https://git.io/JeNld 15:01:10 <DorpsGek_III> [OpenTTD/website] LordAro commented on pull request #122: Widen nav to 825px https://git.io/JeNlN 15:01:34 <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #122: Widen nav to 825px https://git.io/JeNlA 15:05:03 <nielsm> https://0x0.st/zDGP.png 15:05:10 <TrueBrain> nielsm: pretty! 15:05:13 <nielsm> so much hacking 15:05:24 <TrueBrain> and the links work too? 15:05:28 <Samu> before I submit a PR... https://github.com/OpenTTD/OpenTTD/compare/master...SamuXarick:original-generator-vs-freeform-edges?expand=1 15:05:35 <nielsm> web links do, internal links not yet 15:05:36 <Samu> I'm always nervous about PR'ing nowadays 15:05:37 <frosch123> TrueBrain: what did you tell orudge about renewing the servers? now they are only renewed for a single months every time, so that we have to panik every month whether someone reads the notifcation mails 15:06:12 <TrueBrain> frosch123: orudge told me 2 weeks ago he was going to renew it for another 3 months 15:07:42 *** Progman has quit IRC 15:07:47 <DorpsGek_III> [OpenTTD/website] Milek7 updated pull request #122: Widen nav to 825px https://git.io/JeNlX 15:08:35 <TrueBrain> milek7_: adding screenshots of the end-result helps a lot btw :) Now it is just CSS to me :P 15:09:01 <LordAro> Samu: mildly makes sense at a glance, but you *must* accurately explain what the issue is, *why* it's an issur, and how this fixes it 15:09:06 <LordAro> issue* 15:10:21 <Samu> ok, won't PR yet 15:11:30 <milek7_> TrueBrain: original PR: https://i.imgur.com/gCwIHz5.png 15:11:36 <milek7_> second approach: https://i.imgur.com/XMu0JKn.png 15:11:42 <milek7_> (screenshots badly cropped) 15:11:44 <TrueBrain> into the PR pretty please :D 15:13:57 <Samu> lol im getting a crash, fail fix 15:16:20 <nielsm> hmm what's the rule for converting headings in github-flavour markdown into anchor names? 15:16:45 <nielsm> e.g. heading "## 1.3) Supported platforms" becomes #13-supported-platforms 15:17:40 <nielsm> seems to be lowercase, remove leading hashmarks and spaces, remove trailing spaces, remove non-alphanumerics, replace remaining spaces with dashes 15:17:49 <TrueBrain> I would guess it is a "slug" 15:18:14 <nielsm> I have to implement the same algorithm to make internal links clickable and work 15:18:19 <TrueBrain> which normally is: lowercase everything, replace all non[a-z] with '-', and replace any '-+' to '-' 15:19:57 <TrueBrain> nielsm: https://gist.github.com/asabaylus/3071099 15:20:31 <TrueBrain> seems I am wrong :) It is even easier :P 15:23:43 <DorpsGek_III> [OpenTTD/website] Milek7 updated pull request #122: Widen nav to 825px https://git.io/JeNlX 15:24:21 <DorpsGek_III> [OpenTTD/website] Milek7 commented on pull request #122: Widen nav to 825px https://git.io/JeN8s 15:24:38 <peter1138> Mmm, when one fixed width is the wrong size, make it another fixed width... 15:25:12 <TrueBrain> tnx milek7_ :) LordAro, I leave it up to you if this is okay .. I have the idea your judgement here is a lot better than mine :) 15:25:29 <TrueBrain> peter1138: yeah .. he changed that already ;) 15:28:15 <DorpsGek_III> [OpenTTD/website] Milek7 opened pull request #123: Remove width from body https://git.io/JeN8B 15:30:44 <TrueBrain> milek7_: please do look at our commit message rules a bit :) I fix that now during squashing ;) 15:31:56 <DorpsGek_III> [OpenTTD/website] TrueBrain approved pull request #123: Remove width from body https://git.io/JeN8a 15:33:06 <DorpsGek_III> [OpenTTD/website] TrueBrain merged pull request #123: Remove width from body https://git.io/JeN8B 15:35:03 *** Pikka has quit IRC 15:47:08 <TrueBrain> hmm .. that moment you need to login to an account, of which you cannot remember where the password is stored .. 15:47:09 <TrueBrain> annoying 15:47:43 <Samu> i don't understand one thing 15:47:47 <Samu> if (x + w >= MapMaxX() - _settings_game.construction.freeform_edges ? 0 : 1) 15:48:07 <Samu> is there anything wrong with this expression? because, apparently, there is 15:48:43 <Samu> if (x + w >= MapMaxX() - 0) works 15:48:47 <Samu> if (x + w >= MapMaxX() - 1) works 15:48:54 <Samu> but when it's like that, it doesn't 15:49:54 <Samu> maybe it's _settings_newgame what I want? 15:49:59 <Samu> confused 15:51:51 <Samu> parenthesis? 15:51:58 <frosch123> usually info@ drafts folder 15:54:10 <TrueBrain> Azure login system I never understood .. 15:54:19 <TrueBrain> when you login with a second account 15:54:24 <TrueBrain> things start to go weird 15:57:21 <Samu> 141 + 24 >= 255 - _settings_game.construction.freeform_edges ? 0 : 1 this returned true for some reason, I don't understand what kind of operations happened 15:58:37 <Samu> do i need to cast 0 and 1 uint? 16:02:41 <_dp_> Samu, https://en.cppreference.com/w/cpp/language/operator_precedence 16:03:40 <_dp_> ?: has a very low precedence 16:06:13 <nielsm> use more parentheses 16:06:24 <nielsm> many more 16:06:27 <nielsm> ALL the parentheses 16:08:02 <Samu> uint mapmaxx = MapMaxX() - _settings_game.construction.freeform_edges ? (uint)0 : (uint)1; 16:08:04 <nielsm> the same thing I've been asking you for in PRs so many times, use parentheses to make your intended order of evaluation obvious to anyone, and make sure you aren't misremembering or misunderstanding the language's operator precedence rules 16:08:36 <Samu> MapMaxX() is 63, but mapmaxx became = 0 16:08:41 <nielsm> that line you just pasted 16:08:45 <nielsm> means the same as 16:09:02 <nielsm> uint mapmaxx = (MapMaxX() - _settings_game.construction.freeform_edges) ? 0 : 1; 16:09:20 <Samu> ahhhh, now I see the problem :p 16:09:24 <nielsm> yes 16:09:29 <nielsm> USE MORE PARENTHESES 16:09:37 <nielsm> (or use fewer ternaries) 16:11:36 *** snail_UES_ has joined #openttd 16:11:37 <Samu> testing if (x + w >= MapMaxX() - (_settings_game.construction.freeform_edges ? 0 : 1)) return; 16:12:37 <Samu> aha, no crash, finally! that was it 16:14:14 <_dp_> brute force coding ftw :p 16:14:51 <Samu> it's leaving 1 tile-wide on the Southern borders, this is what I wanted! 16:15:39 <nielsm> oh, the readme does have lines with more than one link in them... https://0x0.st/zDGk.png 16:15:47 <nielsm> not sure I want to bother handling that 16:16:51 <nielsm> since right now I just test which line number was clicked, and whether that line contains a link or not 16:16:59 <nielsm> testing which part of the line... ouch 16:19:37 <Samu> https://github.com/OpenTTD/OpenTTD/compare/master...SamuXarick:original-generator-vs-freeform-edges?expand=1 16:19:51 <Samu> i figured part of the code, so I added bonus comments there 16:20:39 <Samu> when that code is run, it is ensuring it's at the cardinal part of the map 16:21:01 <Samu> for making alps for example 16:21:04 <Samu> or rainforest 16:21:36 <TrueBrain> so change README.md nielsm :) 16:21:53 <nielsm> yeah :D 16:22:41 <Samu> explaining the issue requires screenshots 16:24:31 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7786: Add: Help and manuals window https://git.io/JeBQt 16:24:41 <nielsm> look at my hackery and fear 16:25:44 <TrueBrain> all I see is pure epicness 16:29:26 <nielsm> I should probably also make inter-file links work? and add a back button? 16:29:29 *** Wormnest has joined #openttd 16:30:28 <TrueBrain> yes to both! 16:30:36 <TrueBrain> while at it, implement a browser please 16:30:37 <TrueBrain> :D 16:32:16 <LordAro> :D 16:32:31 <LordAro> i think it's a good approximation 16:32:47 <TrueBrain> okay, Azure DevOps can now poke the GitHub Actions to rebuild the website after an OpenTTD release .. w00p :D 16:33:00 <LordAro> i suspect anything more complicated would require a full markdown renderer 16:33:31 <TrueBrain> now I only have to make some proper GitHub Actions out of the ones I made for 'website', so it can be reused by other repositories :D 16:33:56 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #7786: Add: Help and manuals window https://git.io/JeN4w 16:34:12 <LordAro> glx started on GH actions for OTTD, iirc 16:34:34 <TrueBrain> good; I wasn't planning on touching that for now :) 16:36:30 <Samu> there was a bug with bottom borders after all :p 16:37:34 <Samu> so they're both - 0 16:37:42 <Samu> doesn't even need to check for freeforms at the bottom 16:37:57 <Samu> makes more sense to my head too 16:38:27 <Samu> unless, of course leaving a 2 wide gap is the intention 16:38:38 <Samu> does anyone here have original TTD that could check this for me? 16:39:34 <TrueBrain> so .. all that is left now is merging that PR, I think ... oooeeeehhhh :D 16:39:45 <TrueBrain> I don't want to ... IT IS SCARY 16:39:57 <TrueBrain> first dinner, I guess 16:40:56 <Samu> can someone check with original TTD if https://imgur.com/3DfHXgZ is also a 1-wide water 16:41:07 <Samu> or is it 2? 16:41:16 <Samu> the minimum u can spot 16:47:46 <nielsm> it's possible to raise out to one tile before the edge https://0x0.st/zDDZ.jpg 16:48:06 <nielsm> but the coast tiles don't flood then, they become plain grass slopes 16:49:38 <nielsm> it can generate up to the edge on top edges of the map: https://0x0.st/zDDb.jpg 16:49:46 <nielsm> not sure about the bottom edge 16:51:20 *** snail_UES_ has quit IRC 16:52:25 <nielsm> I don't see less than two water tiles along the bottom edges of the map in the few tests I just did, but that's still no proof 16:58:40 <Samu> did you also check the northern borders? 16:58:44 <Samu> is it also 2-wide 16:59:06 <nielsm> see 3 lines above 16:59:34 <Samu> oh nvm im blind :p 17:01:13 <Samu> 1 on the north borders, 2 on the south borders, that's quite what openttd does too 17:01:25 <Samu> except when freeform is on 17:01:36 <Samu> it's then 0 on the north, 2 on the south 17:02:50 <nielsm> https://github.com/OpenTTD/OpenTTD/blob/master/src/table/control_codes.h#L158-L174 <-- where is the left arrow... 17:03:55 *** Progman has joined #openttd 17:05:30 <DorpsGek_III> [OpenTTD/website] LordAro approved pull request #122: Fix overflowing nav https://git.io/JeNB8 17:05:38 <DorpsGek_III> [OpenTTD/website] LordAro merged pull request #122: Fix overflowing nav https://git.io/JeNlX 17:06:55 <DorpsGek_III> [OpenTTD/website] LordAro approved pull request #120: Add HTML lang attribute https://git.io/JeNBu 17:07:05 <DorpsGek_III> [OpenTTD/website] LordAro merged pull request #120: Add HTML lang attribute https://git.io/Jebhw 17:12:21 <frosch123> nielsm: ttd only had one arrow in the short order list (in vehicle list). though i thought the other arrow was added when adding rtl 17:12:26 <frosch123> but maybe icu handled the mirroring 17:13:42 <DorpsGek_III> [OpenTTD/website] LordAro approved pull request #116: Various of fixes in preparation of running this Docker on AWS https://git.io/JeNBr 17:15:32 <nielsm> frosch123 ah... and I just discovered there is a special widget for arrow buttons 17:15:36 <nielsm> which will probably work 17:16:14 <frosch123> yes, the speical widget mirrors the sprite for RTL or something 17:16:36 <nielsm> there's "increase/decrease" and "left/right" 17:16:46 <nielsm> with the former pair mirroring and the latter not 17:17:26 <frosch123> ok, no idea where left/right is used :) 17:22:20 <Samu> unsure what to do at this point 17:22:58 <Samu> 2 tile wide gap for every border? 17:23:17 <Samu> or 1? and what about freeform 17:24:03 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on issue #7862: Out of memory error in AI's ::Save() corrupts the emergency save. https://git.io/Je7Q9 17:24:03 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro closed issue #7862: Out of memory error in AI's ::Save() corrupts the emergency save. https://git.io/Je7Q9 17:25:59 <Samu> help me decide whats best for the game 17:26:42 <Samu> i know you like to mimic TTD, but what if it's a bug there? 17:32:09 <LordAro> https://i.imgur.com/2L51UoU.png this is fine 17:32:17 <LordAro> Samu: "depends" 17:35:53 <milek7_> i broke something? 17:35:59 <peter1138> Confusing, Spintires, which was dead, has been receiving updates. 17:36:24 <peter1138> So now we have Spintires and Mudrunner (which dropped the Spintires from its name) by different developers/publishers... 17:36:25 <LordAro> milek7_: probably 17:40:33 <nielsm> I wonder if this is the correct way to iterate over all instances of a character in a std::string... 17:40:39 <nielsm> for (size_t pos = 0; (pos = newfn.find('/', pos)) != std::string::npos;) ... 17:40:40 <milek7_> what browser? looks fine in my firefox and chromium 17:41:57 <frosch123> nielsm: looks like an infinite loop 17:42:14 <nielsm> maybe this is a better expression: for (pos = newfn.find('/'); pos != std::string::npos; pos = newfn.find('/', pos)) 17:42:28 <frosch123> you need some "+1" 17:42:33 <nielsm> yeah 17:42:39 <_dp_> why not just use while loop? 17:43:10 <nielsm> well except that I modify the string inside the loop replacing the found forward slashes with PATHSEPCHAR which is tested to not be / 17:43:25 <LordAro> https://i.imgur.com/xHnO3je.png looks a bit better 17:43:43 <LordAro> agree with _dp_ - it's generally better just to use a while loop in these cases :) 17:47:58 <Samu> unsure if I PR this, but it's ready https://github.com/SamuXarick/OpenTTD/commit/dbb41b2f457861f006280c5a554daf0df359843a 17:48:25 <Samu> probably not, feels like I'm making too many of them, and ppl don't like 17:49:08 *** Wormnest_ has joined #openttd 17:52:22 *** andythenorth has joined #openttd 17:54:27 <LordAro> https://i.imgur.com/7vgTGrz.png that's better 17:55:50 *** Wormnest has quit IRC 18:05:35 <DorpsGek_III> [OpenTTD/website] TrueBrain merged pull request #116: Various of fixes in preparation of running this Docker on AWS https://git.io/Jed5i 18:05:38 <TrueBrain> oh-oh :D I DID IT 18:05:39 <TrueBrain> OMG 18:05:39 <TrueBrain> RUN 18:06:07 <TrueBrain> let's see how broken it is :) 18:06:19 *** snail_UES_ has joined #openttd 18:06:37 <TrueBrain> tnx btw LordAro :) 18:13:17 <LordAro> :D 18:14:34 <TrueBrain> I guess it should now also be relative easy to create stuff like PR-previews of the website ... something to investigate another day :) 18:19:32 <milek7_> how often staging.openttd.org is updated? 18:20:43 *** Wormnest has joined #openttd 18:22:35 *** WormnestAndroid has quit IRC 18:22:41 <DorpsGek_III> [OpenTTD/website] LordAro opened pull request #124: Use modern CSS for styling instead of background images https://git.io/JeN0a 18:23:01 *** WormnestAndroid has joined #openttd 18:23:35 <LordAro> milek7_: whenever something is merged to master 18:23:45 <LordAro> (but TB was breaking things today, so it was a bit slow) 18:23:48 <TrueBrain> LordAro: why is the banner bigger? (in width) on your screenshot that is 18:23:54 <TrueBrain> yeah, it is running again 18:24:03 <TrueBrain> well, it is deploying as we speak :P 18:24:09 <LordAro> TrueBrain: not really sure, tbh :) 18:24:22 <LordAro> let me clear my caches... 18:24:54 <TrueBrain> and I guess we should add commit-message-checker here too :P :D 18:25:08 <LordAro> depends how much we care :p 18:25:16 <TrueBrain> clearly I do enough to mention it :D 18:25:20 <TrueBrain> too bad that the lines are now gone 18:25:22 <TrueBrain> they were pretty 18:25:30 <TrueBrain> this smooth surface ticks me off :P 18:25:45 *** Wormnest_ has quit IRC 18:25:47 <TrueBrain> guess that is the price to pay :) 18:26:18 <TrueBrain> https://github.com/OpenTTD/website/deployments <- there you can see staging deployments now :) 18:26:23 <LordAro> TrueBrain: ah, because the 15px of the side images is no longer applied, so it's the full 800px 18:26:38 <TrueBrain> ah :) 18:26:50 <LordAro> i could expand the body to match... (or decrease the width of the header) 18:26:59 <LordAro> i'll see if i can replicate the background in css... 18:27:05 <LordAro> i feel like it should be possible 18:27:10 *** Wormnest has quit IRC 18:27:39 <andythenorth> css stripes 18:27:42 <andythenorth> there are generators for them 18:27:49 <andythenorth> overlapping gradients 18:27:55 <LordAro> indeed there are 18:28:01 *** Wormnest has joined #openttd 18:28:02 <TrueBrain> wuth?! This world is doomed :D 18:32:59 *** Wormnest_ has joined #openttd 18:33:03 *** WormnestAndroid has quit IRC 18:33:43 *** WormnestAndroid has joined #openttd 18:33:47 <nielsm> ough this history thing is hard 18:34:38 <LordAro> TrueBrain: andythenorth: https://i.imgur.com/FPqYAb9.png ? 18:34:51 <andythenorth> stripes! 18:35:36 <TrueBrain> epic :D 18:37:15 *** Wormnest has quit IRC 18:37:58 <DorpsGek_III> [OpenTTD/website] LordAro updated pull request #124: Use modern CSS for styling instead of background images https://git.io/JeN0a 18:38:29 <DorpsGek_III> [OpenTTD/website] LordAro commented on pull request #124: Use modern CSS for styling instead of background images https://git.io/JeN0A 18:38:54 <LordAro> TrueBrain: fixed the commit messages too ;) 18:39:27 <TrueBrain> <3 18:39:59 <TrueBrain> what is this _config.yml change? 18:40:39 <LordAro> probably specific to my ruby set up, but i don't think it's *entirely* unreasonable 18:41:34 <TrueBrain> but the commit message doesn't help in understanding what you tried to solve :D 18:41:45 *** WormnestAndroid has quit IRC 18:41:53 <TrueBrain> Codechange: Exclude vendor from build, if that's where bundler has put its stuff 18:41:53 <TrueBrain> Also because jekyll can't compile its own examples for some reason 18:41:55 <TrueBrain> I mean .. what? 18:42:21 <milek7_> chrome is silly 18:42:22 <milek7_> https://i.imgur.com/O36BBZh.png 18:42:23 <TrueBrain> "own examples", what? :) 18:42:30 *** WormnestAndroid has joined #openttd 18:43:29 <LordAro> TrueBrain: i have bundler put gems in ./vendor/bundle. Since this directory is not excluded, jekyll tries to compile things in it, which results in https://github.com/jekyll/jekyll/issues/5267 18:43:41 <milek7_> (for some reason it strips www. from display on addressbar) 18:44:12 <LordAro> milek7_: because the chrome devs in their infinite wisdom decided it was "noise" 18:44:29 <LordAro> it should still be there if you copy & paste the (full) address 18:44:37 <LordAro> TrueBrain: would you like me to put this in the commit message? :) 18:45:25 <TrueBrain> LordAro: hell yes! :) 18:45:50 <DorpsGek_III> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/JeNEJ 18:45:50 <DorpsGek_III> - Update: Translations from eints (by translators) 18:46:17 <TrueBrain> that are what commit messages are for .. when someone in 1 year goes: why is this vender folder excluded .. he can see why :P 18:46:26 <TrueBrain> instead of references to "own examples" nobody is going to understand :D 18:47:27 <DorpsGek_III> [OpenTTD/website] LordAro updated pull request #124: Use modern CSS for styling instead of background images https://git.io/JeN0a 18:48:38 <LordAro> happy? :) 18:49:39 *** WormnestAndroid has quit IRC 18:50:00 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7786: Add: Help and manuals window https://git.io/JeBQt 18:50:19 <LordAro> looked at updating to jekyll4, but seems that paginate plugin is a bit dead 18:50:24 <TrueBrain> LordAro: YES! Hell yes even :) 18:50:29 *** WormnestAndroid has joined #openttd 18:50:47 <TrueBrain> paginate was already an issue for this version .. "use a plugin" / "use the core functionality" 18:50:49 <TrueBrain> it was a bit of a mess 18:51:03 <TrueBrain> but from what I remember it was now part of their core, not? 18:51:19 <LordAro> from what i can tell it was removed from core in v3 18:51:21 <DorpsGek_III> [OpenTTD/website] TrueBrain approved pull request #124: Use modern CSS for styling instead of background images https://git.io/JeNEL 18:51:25 <LordAro> and the plugin doesn't work with v4 18:51:32 <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #124: Use modern CSS for styling instead of background images https://git.io/JeNEt 18:51:57 <frosch123> TrueBrain: do those "[OpenTTD/website] Run failed: Deployment - master" mails matter to you? 18:52:22 <TrueBrain> to me it does, but it should only go to me 18:52:25 <TrueBrain> why are you getting them? :D 18:52:31 <frosch123> they go to info 18:52:45 <TrueBrain> well, that is annoying 18:53:00 <TrueBrain> (I don't read info@ btw, so anything in there that is noise, let me know) 18:53:10 <TrueBrain> let me disable notification on that account, I guess 18:53:17 <TrueBrain> owh, I get it, it is because DorpsGek triggers the builds 18:53:38 <frosch123> yes, "DorpsGek" is the sender 18:53:56 <TrueBrain> disabled 18:54:22 <TrueBrain> at least, I hope :D 19:03:29 <LordAro> TrueBrain: jekyll v4 appears to work with pagination if i use some random person's fork of it, but no other changes necessary as far as i can tell 19:03:50 <LordAro> though there's no particular advantage to having it either as yet, so won't bother with it for now 19:04:06 <TrueBrain> k, tnx :) 19:08:53 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7786: Add: Help and manuals window https://git.io/JeBQt 19:09:51 <nielsm> maybe I should really just have placed all that history logic in the base TextfileWindow 19:12:54 *** snail_UES_ has quit IRC 19:16:42 <DorpsGek_III> [OpenTTD/website] TrueBrain opened pull request #125: Fix: replace the Azure Pipeline badges with GitHub badges https://git.io/JeNEH 19:16:49 <TrueBrain> and this had to be done :D 19:17:39 <LordAro> :D 19:18:33 <TrueBrain> https://github.com/badges/shields/issues/4477 <- because those I am currently missing :D 19:19:07 <TrueBrain> okay, OpenTTD release also triggered the new infrastructure to rebuild the website; that is looking good too :) 19:21:48 <DorpsGek_III> [OpenTTD/website] LordAro approved pull request #125: Fix: replace the Azure Pipeline badges with GitHub badges https://git.io/JeNEd 19:21:53 <TrueBrain> :o Deployment callback didn't work .. wuth? 19:21:55 <DorpsGek_III> [OpenTTD/website] LordAro merged pull request #125: Fix: replace the Azure Pipeline badges with GitHub badges https://git.io/JeNEH 19:22:23 <LordAro> TrueBrain: want me to hold off merging #124 so we have something to test? 19:22:34 <TrueBrain> nah 19:22:37 <TrueBrain> deployments for staging work 19:22:43 <LordAro> k 19:22:43 <TrueBrain> but the production one ... it created the deployment 19:22:48 <TrueBrain> but it never triggered the event 19:23:07 <TrueBrain> ah 19:23:10 <DorpsGek_III> [OpenTTD/website] LordAro merged pull request #124: Use modern CSS for styling instead of background images https://git.io/JeN0a 19:23:10 <TrueBrain> it tried to do it inside the tag 19:23:14 <TrueBrain> yeah, that is not going to work 19:23:30 <TrueBrain> okay, this will be fun ... I think deployment of your commit is going to fail :D 19:23:40 <LordAro> yay! 19:23:49 <TrueBrain> (while deploying, it cannot initiate another deploy, basically) 19:24:51 <TrueBrain> okay, so on the next tag, production will work fine too 19:24:57 <TrueBrain> that somewhat makes sense :) 19:25:43 <LordAro> could arbitrarily bump to 1.2.0, just because some of the site templates have changed :) 19:25:59 <TrueBrain> after we validated your changes, we can :) 19:26:12 <TrueBrain> I wonder when I should switch https://www.openttd.org to the new site 19:26:13 <LordAro> ;) 19:26:15 <TrueBrain> do I dare ... 19:26:29 <LordAro> doit 19:26:47 <TrueBrain> the badges broke :o 19:26:48 <TrueBrain> wuth 19:27:04 <TrueBrain> ah, "in progress" is "no status" 19:27:05 <TrueBrain> fine 19:27:35 <TrueBrain> "An error occurred (ValidationError) when calling the UpdateStack operation: Stack:arn:aws:cloudformation:***:747608230739:stack/Live-Staging-Website/50e593c0-2965-11ea-8568-0a0ddac78b4a is in UPDATE_IN_PROGRESS state and can not be updated." 19:27:38 <TrueBrain> as expected :) 19:27:54 <LordAro> woo 19:28:01 <TrueBrain> it is just a matter of waiting for th eother to finish, than hitting re-run btw 19:28:08 <TrueBrain> https://github.com/OpenTTD/website/actions?query=workflow%3ADeployment 19:28:13 <TrueBrain> so when the second finishes (~3 minutes) 19:28:16 <TrueBrain> click the first, hit rerun 19:29:23 <TrueBrain> I leave that up to you to do LordAro, mostly as I want to know if it works :) 19:31:56 <TrueBrain> weird, deployment reports the wrong commit as being deployed :o 19:32:39 <TrueBrain> ah, yes .. that is wrong .. lol 19:39:05 <DorpsGek_III> [OpenTTD/website] TrueBrain opened pull request #126: Fix: use a sha instead of 'refs/heads/master' as ref for deployments https://git.io/JeNu3 19:39:21 *** HerzogDeXtEr has joined #openttd 19:39:53 <DorpsGek_III> [OpenTTD/website] TrueBrain updated pull request #126: Fix: use a sha instead of 'refs/heads/master' as ref for deployments https://git.io/JeNu3 19:43:19 <DorpsGek_III> [OpenTTD/website] LordAro approved pull request #126: Fix: use a sha instead of 'refs/heads/master' as ref for deployments https://git.io/JeNuc 19:44:23 <TrueBrain> I wonder if I should fix that two commits can be pending to be deployed .. 19:44:38 <TrueBrain> I guess I can first check if there is any current deployment, before it starts its own 19:44:45 <TrueBrain> but that just means that it breaks with 3 commits :P 19:45:39 <milek7_> it can't just work like while (isbusy()) usleep(5000)? 19:45:48 <milek7_> 'cloud' is too complicated ;P 19:46:23 <TrueBrain> that is my point: that doesn't solve anything really :) 19:46:26 <TrueBrain> I need a mutex :P 19:50:34 <DorpsGek_III> [OpenTTD/website] TrueBrain merged pull request #126: Fix: use a sha instead of 'refs/heads/master' as ref for deployments https://git.io/JeNu3 19:55:18 <TrueBrain> looks good LordAro, the header like this. Too bad of the width, but it is not that annoying tbh 20:04:14 <TrueBrain> do we want to put this to production? Or to you want to tinker a bit more with it LordAro? 20:05:00 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #7786: Add: Help and manuals window https://git.io/JeNuy 20:08:06 <LordAro> TrueBrain: i'm happy to. i can equalise the width if you really want to though 20:12:47 <TrueBrain> I don't really care :p I will create a new tag in a bit, let's see if the deployment works :D 20:14:57 <LordAro> hype 20:18:19 <TrueBrain> build is running 20:18:38 <TrueBrain> main website is still on the old infrastructure, but at least I can now validate the new infrastructure before bringing it live :) 20:22:52 <TrueBrain> working like a charm :) 20:22:59 <TrueBrain> well .. time to switch this to live I guess ... 20:24:40 <TrueBrain> DNS change inserted 20:24:48 *** nielsm has quit IRC 20:25:00 <TrueBrain> TTL of 60, so ... not long now :) 20:27:06 <TrueBrain> so https://www.openttd.org/ should now serve from AWS .. it should show the nightly of today (20191228) 20:27:16 <TrueBrain> let me know if there are any issues what-so-ever related to the stability :) 20:27:24 <TrueBrain> IPv4 and IPv6 should work without any issues 20:28:10 *** nielsm has joined #openttd 20:28:30 *** WormnestAndroid has quit IRC 20:28:34 *** WormnestAndroid has joined #openttd 20:28:56 <TrueBrain> owh, right, 404 hits on " /apple-touch-icon-120x120-precomposed.png" 20:28:59 <TrueBrain> I forgot about that shit 20:34:45 <frosch123> oh, someone fixed the bulletpoints 20:36:23 <TrueBrain> not for me :( 20:36:33 <TrueBrain> https://www.openttd.org/downloads/openttd-nightlies/latest.html <- still there :( 20:36:41 <TrueBrain> at least the linebreak is gone now 20:36:43 <TrueBrain> which makes it a bit better 20:39:47 <Samu> https://github.com/OpenTTD/OpenTTD/issues/7872#issuecomment-569348611 this requires a new setting :( 20:40:32 <Samu> i also like the idea of choice, but it's more work to do :( 20:41:10 <Samu> and savegame bump 20:41:14 <Samu> oh well 20:41:33 <nielsm> no why does that require a new setting? 20:41:59 <nielsm> just define that if snow line height is set to 0 during worldgen, it's an automatic setting, and otherwise it uses the user's value 20:42:13 <nielsm> I don't think height zero is valid anyway 20:43:24 <frosch123> both lists have bulletpoints for me now 20:43:43 <frosch123> though, wasn't there a os filter dropdown before? or was that the old website? 20:44:34 <nielsm> hm I wonder if enabling wrapping by default would be reasonable for the manuals? 20:44:48 <nielsm> most seem to rely on it for proper viewing 20:44:53 <frosch123> haha, ok, firefox and chrome looks completely different now :) 20:45:18 <Samu> snow line minimum value is 2 20:45:21 <frosch123> ff has bulletpoints, chrome as filter dropdown 20:45:36 <Samu> can't make a 0 here :( 20:46:53 <LordAro> frosch123: lolwut 20:49:46 <frosch123> i have no idea about this stuff, so i can't give any better reports :) 20:53:28 <nielsm> more thougts about this help and manuals window: I think the "report a bug" button should ideally go to the github issues tab, instead of the code browser, but there isn't any short-url for that afaik 20:53:54 <nielsm> would it make sense to move Flyspray to a different subdomain and repurpose bugs.openttd.org as a redirect to github issues? 20:56:23 <nielsm> :( and the viewer breaks massively on RTL languages 20:58:25 <nielsm> would it be bad to assume all text files it views are LTR and force a text direction in the text viewer? 20:59:10 <frosch123> in theory bananas tars can contain language-specific readmes and changelogs 20:59:19 <frosch123> not sure whether anyone ever used that 20:59:43 <nielsm> great 21:00:13 <frosch123> i would not be suprised if xussr set has a russian readme, but russian is also ltr 21:00:43 <DorpsGek_III> [OpenTTD/website] Milek7 opened pull request #127: Change: Do not limit section header to 500px https://git.io/JeNzK 21:01:13 <frosch123> hmm, i guess the "correct" way would be to force ltr if the readme is the english - non language specific - one 21:01:50 <frosch123> so, GetTextfile() could return a LTR/RTL value? 21:02:16 <frosch123> depending on which filename was matched 21:05:10 *** WormnestAndroid has quit IRC 21:05:47 *** WormnestAndroid has joined #openttd 21:07:46 <nielsm> https://0x0.st/zDda.png 21:07:49 <nielsm> kinda bad 21:14:17 <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #127: Change: Do not limit section header to 500px https://git.io/JeNzd 21:16:17 <TrueBrain> cool, response times of new infrastructure are < 1ms on the LoadBalancer for 99% of the traffic :) 21:18:36 <LordAro> nice 21:18:56 <TrueBrain> in general everything seems to be working fine from what I can tell 21:19:02 <TrueBrain> we will see if there are any reports :) 21:19:08 <LordAro> including ipv6? ;) 21:19:14 <TrueBrain> yes 21:19:16 <TrueBrain> native 21:19:17 <TrueBrain> no tricks 21:19:47 <LordAro> :) 21:20:42 <TrueBrain> pretty happy with the result like this :) Tomorrow I will see if I can migrate DorpsGek; means your latest changes will become live too :) 21:21:12 <nielsm> lol okay that's MORE wrong https://0x0.st/zDde.png 21:21:20 <TrueBrain> lol @ nielsm :) 21:22:45 <DorpsGek_III> [OpenTTD/nml] FLHerne commented on pull request #78: Add: optimise switches https://git.io/JeNzp 21:23:20 <DorpsGek_III> [OpenTTD/website] James103 commented on issue #117: There's a couple of layouting/responsiveness issues in the OpenTTD website. https://git.io/Jed55 21:24:29 *** andythenorth has quit IRC 21:27:34 <nielsm> hax https://0x0.st/zDd2.png 21:28:01 *** andythenorth has joined #openttd 21:28:03 <TrueBrain> so when are we going to translate README.md? :D 21:29:24 <DorpsGek_III> [OpenTTD/website] Milek7 commented on pull request #127: Change: Do not limit section header to 500px https://git.io/JeNgq 21:30:40 <nielsm> making GetTextfile functions return a reading direction for the file's language will be annoying I think 21:32:44 <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #127: Change: Do not limit section header to 500px https://git.io/JeNgC 21:32:44 <DorpsGek_III> [OpenTTD/OpenTTD] sheepo99 commented on issue #7872: Default openttd.cfg world gen settings don't allow Forests in Sub-Arctic https://git.io/JeFfG 21:32:55 <frosch123> it's essentially "force_ltr", so it's a "if" around whatever you just added 21:34:46 <DorpsGek_III> [OpenTTD/website] Milek7 commented on pull request #127: Change: Do not limit section header to 500px https://git.io/JeNgB 21:34:59 <DorpsGek_III> [OpenTTD/OpenTTD] jkjkjkjkjk opened issue #7881: Cannot insert new order https://git.io/JeNg0 21:36:12 <glx> [21:43:44] <frosch123> though, wasn't there a os filter dropdown before? or was that the old website? <-- bulletpoints for all for me too, and indeed the drop down disappeared 21:36:43 <frosch123> firefox? 21:36:51 <glx> yup 21:37:07 <frosch123> i am so glad i am no web developer :) 21:40:02 <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #127: Change: Do not limit section header to 500px https://git.io/JeNg6 21:40:43 <glx> edge works 21:41:27 <frosch123> you mean, both bullet points and filter? 21:41:57 <glx> filter on top, bullet points for dev files, like before 21:42:08 <TrueBrain> there should not be bullet points! :P 21:42:20 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on issue #7881: Cannot insert new order https://git.io/JeNg0 21:42:20 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh closed issue #7881: Cannot insert new order https://git.io/JeNg0 21:42:22 <glx> so for a weird reason the filter disappear on firefox 21:43:09 <glx> ok ua-parser is blocked 21:43:39 <TrueBrain> yeah, the code is written that it falls back gracefully if javascript cannot be loaded 21:43:41 <glx> if I disable ublock it works in firefox 21:43:46 <TrueBrain> so even without javascript, you have a functional website 21:44:42 <TrueBrain> and I guess the javascript also eats the bullets? :D 21:44:47 <frosch123> ah, yes, without ublock the filter reappears, and half of the bullets vanish :) 21:45:03 <TrueBrain> so there is the correlation :) Nice 21:45:29 <glx> Last modified: 26 Dec 2019 15:07 UTC <-- seems the block filter update is recent 21:45:47 <TrueBrain> why do they block ua-parser? That is silly 21:45:53 <TrueBrain> it is just a library to detect browsers .. 21:45:53 <glx> privacy 21:45:57 <frosch123> they did not a few days ago 21:46:10 <TrueBrain> privacy ... what has privacy to do with it 21:46:16 <glx> but it's silly nothing is transmiteed 21:46:21 <TrueBrain> if you want privacy, don't send your user-agent 21:46:30 <TrueBrain> I mean .. this can be done server-side too 21:46:47 <TrueBrain> but happy to see that fallback still works fine :) 21:48:02 <Samu> I can't believe there is no string saying {Black}Auto 21:48:09 <Samu> there's an Autofill 21:48:33 <Samu> close enough 21:53:24 <Samu> {BLACK}Auto 21:54:04 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7786: Add: Help and manuals window https://git.io/JeBQt 21:54:19 <nielsm> some of those things should probably be pulled out to one or more separate PRs 21:54:36 <nielsm> and all those commits need some serious cleanup 21:54:44 <nielsm> but definitely not tonight 21:55:40 <Samu> [img]https://i.imgur.com/LCEhLJa.png 21:56:02 <Samu> im treating values 2 and 252 as auto 21:56:24 <Samu> erm 253* my bad 21:58:19 <Samu> maybe I should increase the ranges? 21:58:24 <Samu> 1 and 254? 21:58:27 <Samu> as auto 22:03:51 <DorpsGek_III> [OpenTTD/website] Milek7 commented on pull request #127: Change: Do not limit section header to 500px https://git.io/JeN2V 22:04:51 <milek7_> that's funny 22:05:29 <milek7_> i cropped this png to 64x38, but size increased by 5KB ;P 22:14:31 *** andythenorth has quit IRC 22:17:08 <LordAro> milek7_: alpha channel? 22:18:13 <milek7_> nope 22:24:07 <TrueBrain> We stripped all PNGs from fluff 22:24:36 <TrueBrain> Often there are a few extra palettes, and metadata 22:25:00 <TrueBrain> Those palettes make it look ugly on OSX for example :p 22:27:08 *** snail_UES_ has joined #openttd 22:27:59 *** frosch123 has quit IRC 22:29:37 <DorpsGek_III> [OpenTTD/nml] glx22 updated pull request #78: Add: optimise switches https://git.io/Jed1S 22:30:01 <DorpsGek_III> [OpenTTD/nml] glx22 commented on pull request #78: Add: optimise switches https://git.io/JeNam 22:34:21 *** nielsm has quit IRC 22:40:06 <Samu> if 1 is auto, it only means auto for this time 22:40:12 <Samu> next time, it's no longer 1 22:40:35 <Samu> it's whatever the auto has set, and no longer auto 22:40:45 <Samu> what to do 22:40:52 <Samu> new settings? 22:41:55 <Samu> I'm more inclined towards adding a new setting to do what James103 requests 22:43:20 <Samu> or leave it as is, as sheepo99 says 22:43:28 <Samu> https://github.com/OpenTTD/OpenTTD/issues/7872 22:44:42 <glx> oh I see why grfcodec produce smaller grfs, nmlc is very bad at cropping 22:46:24 <glx> let's try to improve that 22:54:47 <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick updated pull request #7880: Fix: Fixing the slopes was being done twice on heightmaps when one suffices https://git.io/JeNLr 23:02:51 <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick commented on issue #7872: Default openttd.cfg world gen settings don't allow Forests in Sub-Arctic https://git.io/JeFfG 23:03:23 <Samu> i'm off to bed, cyas 23:03:45 *** Samu has quit IRC 23:19:42 <DorpsGek_III> [OpenTTD/website] LordAro approved pull request #127: Change: Do not limit section header to 500px https://git.io/JeNad 23:20:05 <DorpsGek_III> [OpenTTD/website] LordAro merged pull request #127: Change: Do not limit section header to 500px https://git.io/JeNzK 23:24:44 <DorpsGek_III> [OpenTTD/nml] LordAro commented on pull request #78: Add: optimise switches https://git.io/JeNVf 23:28:18 *** Flygon has joined #openttd 23:43:06 <DorpsGek_III> [OpenTTD/nml] glx22 commented on pull request #78: Add: optimise switches https://git.io/JeNVw