Log for #openttd on 4th February 2020:
Times are UTC Toggle Colours
00:33:27  *** gnu_jj has quit IRC
00:46:35  *** gnu_jj has joined #openttd
01:17:15  *** snail_UES_ has joined #openttd
01:22:28  *** Flygon has joined #openttd
02:18:01  *** kelostone has joined #openttd
02:26:57  *** debdog has quit IRC
02:44:33  <DorpsGek_III> [OpenTTD/OpenTTD] James103 commented on issue #5213: Cloning vehicle with impossible orders silently fails to copy orders
03:03:25  *** glx has quit IRC
03:58:46  *** tokai has joined #openttd
03:58:46  *** ChanServ sets mode: +v tokai
04:37:30  *** kelostone has quit IRC
04:57:47  *** WormnestAndroid has quit IRC
04:59:22  *** WormnestAndroid has joined #openttd
05:04:55  *** supermop_Home has quit IRC
05:35:24  *** WormnestAndroid has quit IRC
05:35:37  *** WormnestAndroid has joined #openttd
05:45:11  *** tokai|noir has joined #openttd
05:45:11  *** ChanServ sets mode: +v tokai|noir
05:52:07  *** tokai has quit IRC
07:07:06  *** andythenorth has joined #openttd
07:12:27  *** snail_UES_ has quit IRC
07:15:29  *** el3ktr4 has joined #openttd
07:34:14  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on issue #5213: Cloning vehicle with impossible orders silently fails to copy orders
08:04:32  *** el3ktr4 has quit IRC
08:36:45  *** el3ktr4 has joined #openttd
08:41:17  *** andythenorth has quit IRC
08:41:46  *** andythenorth has joined #openttd
08:41:53  *** debdog has joined #openttd
08:50:43  *** el3ktr4 has quit IRC
08:59:42  *** el3ktr4 has joined #openttd
11:06:04  *** Samu has joined #openttd
12:55:48  *** lpx has quit IRC
13:02:40  *** WormnestAndroid has quit IRC
13:02:52  *** WormnestAndroid has joined #openttd
13:14:27  <DorpsGek_III> [OpenTTD/OpenTTD] James103 opened issue #7972: Impossible orders silently fail to be copied and have their sharing settings fully protected.
13:19:23  *** el3ktr4 has quit IRC
13:32:28  *** tycoondemon2 has quit IRC
13:33:15  *** tycoondemon has joined #openttd
13:54:55  *** Flygon has quit IRC
13:56:37  *** snail_UES_ has joined #openttd
14:21:46  *** el3ktr4 has joined #openttd
14:25:08  *** snail_UES_ has quit IRC
14:29:09  *** el3ktr4 has joined #openttd
14:37:41  *** nielsm has joined #openttd
14:55:53  *** Etua has joined #openttd
15:11:14  *** WormnestAndroid has quit IRC
15:12:59  *** WormnestAndroid has joined #openttd
15:13:30  *** stefino has joined #openttd
15:13:48  *** WormnestAndroid has quit IRC
15:16:57  <stefino> hi guys, I have a small problem with NML install on WIN. I need to install libraries but it seems I don't know how. I have started CMD, gone to NML folder where I have unziped NML master and then I'm writing pip3 install pillow or ply but nothing happen. "pip3"is not internal or external command
15:17:38  *** WormnestAndroid has joined #openttd
15:18:02  <stefino> ...operable program or batch file
15:19:15  <stefino> install works but in the end it writes that it needs to install the libraries first
15:20:01  <stefino> (I installed python 3.7.4 on WIN)
15:32:52  <planetmaker> stefino, pip3 is part of the python install, iirc
15:33:11  <planetmaker> maybe it's just called pip instead of pip3
15:33:24  <planetmaker> does calling python work for you?
15:34:04  <planetmaker> has instructions
15:34:25  <planetmaker> though it says for py >3.4 it's included
15:35:28  <LordAro> python -m pip <pip command> should Just Work(tm)
15:38:00  <planetmaker> he :) yeah. maybe better than asusming a pip being a primary command
15:40:00  <stefino> tried it with no result :/
15:40:12  <planetmaker> can you start python at all from cmd?
15:40:22  <planetmaker> "no result" is rather... non-descriptive :|
15:40:37  <planetmaker> python3 -m pip install ply
15:40:37  <planetmaker> Collecting ply
15:40:37  <planetmaker>   Downloading (49kB)
15:40:37  <planetmaker>     100% |████████████████████████████████| 51kB 875kB/s
15:40:37  *** planetmaker has quit IRC
15:40:37  *** ^Spike^ has quit IRC
15:40:37  *** Ammler has quit IRC
15:40:37  *** tneo has quit IRC
15:40:37  *** XeryusTC has quit IRC
15:40:37  *** Osai has quit IRC
15:40:37  *** fonsinchen has quit IRC
15:40:37  *** avdg has quit IRC
15:40:37  *** Yexo has quit IRC
15:40:37  *** Hirundo has quit IRC
15:40:37  *** Terkhen has quit IRC
15:40:37  *** SmatZ has quit IRC
15:40:37  *** Hazzard has quit IRC
15:40:37  *** V453000 has quit IRC
15:41:50  <SpComb> openttdcoop banhammer?
15:42:17  <SpComb> blame planetmaker
15:43:12  <Sacro> Hah
15:43:36  *** Guest15453 has joined #openttd
15:46:11  <Guest15453> maybe
15:46:25  *** Guest15453 is now known as pm
15:47:03  *** pm is now known as Guest15454
15:47:17  <stefino> I think that the problem is in python. In case of if I write python install, nothing happen. If I write only install, it works (but with the libraries erorr)
15:48:08  *** spnda has joined #openttd
15:48:45  *** Guest15454 is now known as planetm-
15:57:38  <stefino> planetm-: I think that the problem is in python. In case of if I write python install, nothing happen. If I write only install, it works (but with the libraries erorr)
15:58:20  *** stefino has quit IRC
15:58:25  <planetm-> did you first install the libraries? If they are not installed, no point in trying anything nml
16:14:56  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 opened pull request #7973: Fix #7969: limit recursion during alias execution
16:25:37  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh approved pull request #7973: Fix #7969: limit recursion during alias execution
16:31:15  *** planetm- is now known as planetmaker
16:35:34  *** WormnestAndroid has quit IRC
16:39:41  *** WormnestAndroid has joined #openttd
16:41:17  *** WormnestAndroid has quit IRC
16:41:30  *** WormnestAndroid has joined #openttd
16:41:43  *** Terkhen has joined #openttd
16:41:43  *** ChanServ sets mode: +o Terkhen
16:42:13  *** XeryusTC has joined #openttd
16:42:13  *** V453000 has joined #openttd
16:42:43  *** planetma- has joined #openttd
16:42:43  *** tneo has joined #openttd
16:43:13  *** avdg has joined #openttd
16:43:13  *** Yexo has joined #openttd
16:43:43  *** fonsinchen has joined #openttd
16:43:53  *** Hazzard has joined #openttd
16:44:13  *** Hirundo has joined #openttd
16:44:20  *** planetmaker is now known as Guest15459
16:44:20  *** planetma- is now known as planetmaker
16:45:13  *** Ammler has joined #openttd
16:45:43  *** SmatZ has joined #openttd
16:45:43  *** Osai has joined #openttd
16:45:59  *** ^Spike^ has joined #openttd
17:09:07  *** y2kboy23 has quit IRC
17:11:28  *** y2kboy23 has joined #openttd
17:12:56  *** glx has joined #openttd
17:12:57  *** ChanServ sets mode: +v glx
17:14:58  *** Progman has joined #openttd
17:27:34  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 dismissed a review for pull request #7973: Fix #7969: limit recursion during alias execution
17:27:34  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 updated pull request #7973: Fix #7969: limit recursion during alias execution
17:28:24  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on pull request #7973: Fix #7969: limit recursion during alias execution
17:37:32  *** gelignite has joined #openttd
17:37:53  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh approved pull request #7973: Fix #7969: limit recursion during alias execution
17:41:42  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 merged pull request #7973: Fix #7969: limit recursion during alias execution
17:41:43  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 closed issue #7969: Console command "alias" can stack overflow and crash (bypassing crash handler)
18:02:03  *** Maarten has joined #openttd
18:06:25  *** Wolf01 has joined #openttd
18:17:23  *** spnda has quit IRC
18:29:19  * andythenorth learning to draw trains
18:35:54  *** supermop_work has quit IRC
18:35:55  *** frosch123 has joined #openttd
19:21:51  *** sla_ro|master has joined #openttd
19:55:46  *** Etua has quit IRC
20:10:00  <TrueBrain> frosch123: the bot was now missing permissions
20:10:07  <TrueBrain> I created a Team to compensate
20:10:23  <frosch123> what failed?
20:12:04  <TrueBrain> GitHub Actions triggers failed for sure
20:12:13  <TrueBrain> not sure if eints failed; I never know if there was anything to do
20:12:23  <TrueBrain> but for sure DorpsGek had no write permission to anything, so it shouldn't have worked :D
20:12:58  <Samu> more than 10 seconds to advance a frame
20:13:42  <frosch123> ok, for eints we have two options
20:13:49  <frosch123> 1) set the group as "maintainer"
20:14:05  <frosch123> 2) add a push-exception for the group to
20:14:15  <frosch123> what do you prefer?
20:14:25  <TrueBrain> sorry, what problem are you trying to solve?
20:14:51  <frosch123> the repository is currently configured so that noone can push
20:14:55  <frosch123> but eints needs to push
20:14:58  <TrueBrain> ah, yes, that too
20:15:08  <TrueBrain> so the first problem we had was that it couldn't even write to the repo
20:15:12  <TrueBrain> next indeed would be branch protection :D
20:15:25  <TrueBrain> I am in favour of branch protection
20:15:30  <TrueBrain> minimize the amount of rights the bot has
20:15:44  <TrueBrain> so setting him with maintainer access so it can only push, feels icky
20:16:44  <frosch123> ok, i added the team as exception
20:16:51  <frosch123> still not sure whether it will work
20:17:11  <frosch123> push may still get rejected because commit was not approved by anyone
20:17:16  <TrueBrain> we will find out tomorrow :P
20:18:12  <glx> only admin can push without approve if approve is required
20:18:49  <frosch123> it only mentions "status checks"
20:19:07  <frosch123> but the wording is all fishy
20:19:10  <TrueBrain> pretty sure that is not true glx; have you tested that?
20:19:14  <TrueBrain> well, I can test that right now honestly :)
20:20:05  <glx> for PRs I'm quite sure all checks must pass for a non admin to merge it
20:20:21  <TrueBrain> we are not talking about PRs :)
20:20:37  <glx> ah protected branches
20:22:07  <TrueBrain> <- lets find out :)
20:22:58  <TrueBrain> okay, as admin it is irrelevant what the checks are .. funny
20:23:14  <frosch123> there is a "include admins" setting
20:23:34  <frosch123> i checked it for all repos, but openttd, just for dorpsgek
20:23:45  <TrueBrain> remote: error: GH006: Protected branch update failed for refs/heads/master.
20:23:52  <TrueBrain> with that on, under my user
20:24:17  <TrueBrain> and I cannot overrule it now
20:24:40  <frosch123> not even with the "restrict who can push"?
20:24:44  <TrueBrain> nope
20:24:53  <TrueBrain> but let me try it with DorpsGek token, that is a bit more fair
20:24:55  <frosch123> ok, so dorpsgek must be openttd repository admin
20:25:00  <frosch123> not organisation admin
20:25:06  <TrueBrain> that is too early to tell :)
20:25:18  <TrueBrain> let me do testing before we jump to conclusion based on some partials :)
20:25:22  <frosch123> sure :)
20:25:47  <TrueBrain> that is, if I can remember how to push as someone else
20:28:23  <TrueBrain> nope, it still requires approval :)
20:28:37  <TrueBrain> so you are right glx. Just not sure you knew already, or that it was a guess :P
20:29:09  <glx> well it was partially a guess :)
20:29:18  <TrueBrain> frosch123: only as "admin" role I can overrule that
20:30:02  <glx> but it makes sense that a protected branch is really untouchable except by admins
20:30:04  <frosch123> yeah, but repo admin should be enough, no org admin needed
20:30:57  <TrueBrain> glx: it would be nice that if for bots they would allow exceptions tbh
20:31:01  <TrueBrain> frosch123: indeed, it is
20:31:58  <TrueBrain> but "Restrict who can push to matching branches" makes very little sense in this case tbh .. well, only if you ignore the approval part, I guess
20:32:02  <TrueBrain> they are a bit mutual exclusive of some sorts
20:33:23  <glx> I don't see anyone sane wanting to even think about using the two last rules
20:33:34  <TrueBrain> okay, the proper solution seems to be to make DorpsGek push to a branch, make a PR, and have an auto-merge-if-green action enabled
20:34:00  *** el3ktr4 has quit IRC
20:35:14  <frosch123> glx: "force pushes" are enabled for one eints branch :)
20:35:51  <glx> special case I guess, with limited access
20:35:55  <TrueBrain> <- at least the rest now works again, as today's nightly got published :)
20:35:57  <frosch123> the "eints with openttd interface" branch is always rebased onto the "pure eints" :)
20:36:27  <frosch123> TrueBrain: so, bots become repo admin for openttd?
20:36:37  <frosch123> done with testing alternatives?
20:36:54  <TrueBrain> yeah ... can't find another way
20:37:15  <TrueBrain> installing an auto-merge bot might be a bit too much hassle for now
20:37:29  <frosch123> the PR spam would be a bigger hassle
20:37:32  <glx> and DorpsGek is not a random bot from unknown source
20:37:57  <TrueBrain> glx: it is not about if DorpsGek should be allowed or not, it is about least privileges. We now have a bot with admin access. That is .. less optimal
20:38:09  <glx> I know
20:38:19  <TrueBrain> always assume PATs get lost :)
20:38:29  <glx> but the PR option seems worse
20:38:44  <TrueBrain> it is what the rest of GitHub seems to be doing for these kind of jobs
20:38:55  <TrueBrain> so I would tend to say we are missing something :)
20:39:43  <TrueBrain> and there is a case to be made .. what if a language push made the CI fail. I guess that is a bit the idea behind forcing that flow
20:40:08  <glx> well CI can't fail if a language fails IIRC
20:40:29  <glx> it will warn but won't fail
20:41:03  <TrueBrain> nevertheless, that is I guess the idea of such workflow; force everything through the CI, don't allow things to sidestep it
20:41:09  <TrueBrain> unless you are really really high up in your permissions
20:41:20  <TrueBrain> that we completely abuse it ... well ..
20:41:34  *** Laedek has quit IRC
20:42:08  <andythenorth> oh I looked away, now there is loads of chat :P
20:44:29  <TrueBrain> hmm, reading some more, "Restrict who can push to matching branches" might not do what we think it does .. I wonder if any non-admin can now merge PRs :D
20:44:54  *** Laedek has joined #openttd
20:45:04  <frosch123> someone will complain :)
20:45:58  <frosch123> but there is also the "only owner can approve" or something
20:46:21  <frosch123> hmm, approve is not merge
20:46:44  <frosch123> why didn't gh just do a spreadsheet with checkboxes for each team
20:46:55  <TrueBrain>
20:46:59  <TrueBrain> hahaha, well, that is one solution :D
20:47:02  <frosch123> instead of prosa rules which add/revoke each other
20:48:46  <TrueBrain> "Restrict who can push to this branch is intended to exclude users or teams from pushing to important branches using any method, including merging their own pull requests onto the target branch. As we already saw in this article, merging a pull request is effectively the same as pushing commits to a branch. By enabling this setting you can prevent
20:48:46  <TrueBrain> a user from pushing commits to a branch while still allowing them to open pull requests."
20:48:54  <TrueBrain> okay, so that option is not doing what I expect it would do :D
20:49:08  <TrueBrain> but it literally doesn't allow anyone outside of that list to merge pull-requests :D
20:49:08  *** WormnestAndroid has quit IRC
20:49:12  <frosch123> interesting project... if gh does not have a public issue tracker, let's create one inside gh
20:49:16  *** sla_ro|master has quit IRC
20:50:03  *** WormnestAndroid has joined #openttd
20:50:41  <TrueBrain> so I think we want to disable that entry, as we already do this with Teams .. I *think* that should be enough :P
20:51:17  <michi_cc> nielsm: If you've not stuffed your Mac back into the closet, could you try reverting src/video/cocoa/ to the version before 74b7f0a9aa7658857714db365853db8f6c8512bd?
20:51:40  <TrueBrain> frosch123: or possibly give Core Developers the "maintain" role
20:52:14  <TrueBrain> not sure .. very confusing entry, this "restrict push" button :D
20:52:26  <TrueBrain> but as you mentioned, someone will complain :)
20:52:35  <frosch123> TrueBrain: disable the setting sound better than "maintainer"
20:53:38  <TrueBrain> anyway, I am off for tonight .. this GitHub permissions is messing with my head :P
20:54:23  <nielsm> michi_cc: that one's before 1.8 isn't it?
20:54:32  <nielsm> I don't think anyone reported the issues for 1.8
20:55:00  <michi_cc> The commit was merged on 10.4.2018, i.e. after 1.8 release.
20:55:09  <nielsm> ah
20:56:11  <michi_cc> It looks totally inconsequential, but it uses a different call for mouse cursor warping which might affect more in the event handling.
20:57:09  <nielsm> building now
20:57:37  <nielsm> but I should try to do a proper bisect tomorrow
20:58:25  *** el3ktr4 has joined #openttd
20:59:51  <michi_cc> The amount of other commits affecting src\video\cocoa since 1.8 is almost zero if you subtract the color space changes, which were done in response to the slowdown problem, so clearly not the cause.
21:01:02  <andythenorth> do these 3 trains look the same?
21:01:37  <michi_cc> The one other difference is the compiler environment, or more exactly the SDK and target versions used in the build. There are things OSX will do differently depending on the version the app was compiled for, which makes it a definite possibility as well.
21:02:22  <frosch123> andythenorth: all CC trains look the same. other than that, they are different
21:02:39  <andythenorth> it's very hard to draw steam trains :P
21:02:55  <andythenorth> they all have same CC kettle, tender, black chassis
21:02:57  <nielsm> oh right, 1.8 doesn't have fps window
21:03:04  <nielsm> :D
21:03:56  <michi_cc> 74b7f0a9aa7658857714db365853db8f6c8512bd? is a one line add/remove change for, forward-porting should be hard :)
21:04:13  <michi_cc> *shouldn't* :( :)
21:05:37  <DorpsGek_III> [OpenTTD/OpenTTD] LeandroSImmich opened issue #7974: Crash when CTRL+click to show a vehicle group that is collapsed
21:05:50  <nielsm> but I'm not feeling any performance difference between 1.8.0, 1.9.3, and 1.10.0-beta2
21:06:10  <nielsm> so maybe I'm not fully equipped to test it anyway
21:08:35  <michi_cc> Same problem as me. It's not hard to run OSX virtualised on Windows, but there are exactly zero accelerated video drivers available, which makes any kind of performance testing pointless.
21:10:15  <nielsm> I'm not sure if we ever got a full confirmation whether the issue only appeared on os 10.14+ or not
21:10:27  <nielsm> but my machine can't install later than 10.13
21:10:32  <michi_cc> andythenorth: Could you try what happens if you revert the change to from ?
21:10:48  <michi_cc> It's just two lines, manual editing should be possible :)
21:10:58  <andythenorth> sure
21:12:13  <milek7> i tried running it on kvm but performance was fine
21:13:49  <andythenorth> not exactly sure what we're trying to repro :)
21:13:53  <andythenorth> I've made the revert
21:14:02  <nielsm> still the weird slowness
21:14:07  <andythenorth> but there's no baseline peformances number, just weirdness
21:14:14  <nielsm> bad fps despite the gameloop and drawing times being good
21:16:47  <andythenorth> I've got nothing conclusive
21:16:57  <andythenorth> some of the issues are intermittent
21:16:58  <michi_cc> I don't really expect that change to do anything, but it is the only post-1.8 commit to even touch event handling.
21:18:08  <glx> hmm between 1.8 and 1.9 we moved the CF too IIRC
21:18:34  <nielsm> nope I'm not seeing any improvement with that change reverted
21:18:42  <LordAro> seems like it's almost certainly SDK related
21:19:45  <glx> I think most people in the issues use our provided builds
21:20:35  <nielsm> andythenorth: when you use the official build of 1.8 you don't have issues, right? what if you checkout 1.8 and build that yourself?
21:20:52  <nielsm> or can we try making the new cf build 1.8?
21:22:58  <nielsm> anyway, I'm off to bed, gn
21:23:27  <andythenorth> gn :)
21:23:53  <glx> and OSX version seems to matter too
21:25:22  <andythenorth> I'm not sure if 1.8.0 is information or not
21:25:30  <andythenorth> the reports aren't all using same save
21:25:36  <andythenorth> there's no fps window
21:25:40  <andythenorth> it's very subjective
21:26:32  <andythenorth> ffwd on an empty map is far faster on 1.8.0, but I'd have to time months to get a numeric value :P
21:27:03  <andythenorth> ffwd on master was briefly really fast on mac after peter decouple gui timing,
21:27:14  <andythenorth> then it got broken around the time kdtrees were added for stations
21:27:21  <andythenorth> but it wasn't necessarily causal
21:31:03  *** nielsm has quit IRC
21:46:46  *** frosch123 has quit IRC
21:58:11  *** andythenorth has left #openttd
22:08:02  <LordAro> why does GH think that grfcodec was updated 2 hours ago?
22:08:57  *** supermop_work has joined #openttd
22:10:21  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #7859: Feature #7756: Allow server to supply a reason to kicked/banned clients
22:10:44  <LordAro> aaand apparently i'm no longer authorised to merge PRs
22:10:48  <LordAro> TrueBrain: :(
22:15:15  *** frosch123 has joined #openttd
22:15:30  <frosch123> we have a test subject?
22:17:11  <frosch123> LordAro: try again?
22:17:34  <LordAro> frosch123: seems happier :)
22:17:40  <glx> ah unchecked restrict
22:17:43  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro closed issue #7756: Allow server to supply a reason to kicked / banned clients
22:17:43  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #7859: Feature #7756: Allow server to supply a reason to kicked/banned clients
22:18:06  <frosch123> LordAro: i finally fixed grfcodec earlier, that was on the todo list for N months :)
22:18:45  <LordAro> frosch123: oh?
22:19:36  <frosch123> no idea how it was originally imported, but it had random hashes for authors, and someone made a merge commit. so i reimported the repository
22:19:59  <LordAro> i see
22:22:01  <glx> hmm peter has a cmake branch for grfcodec and I have an open PR against this branch
22:22:36  <frosch123> really, someone working on grfcodec? :o
22:23:05  <frosch123> i guess you need that rebase --onto thingie then
22:23:13  <glx>
22:23:22  <glx> well not recent work
22:23:53  *** WormnestAndroid has quit IRC
22:24:34  <LordAro> should probably have all the CI gubbins set up with it as well
22:25:04  *** WormnestAndroid has joined #openttd
22:32:16  <frosch123> it is the least important tool, you can use a 7 year old release jsut fine
22:33:11  <glx> the cmake branch mostly ease compilation
22:34:57  *** Wolf01 has quit IRC
22:42:56  <DorpsGek_III> [OpenTTD/OpenTTD] stormcone opened pull request #7975: Fix #7974: Crash when CTRL+click to show a vehicle group that is coll…
22:45:15  *** el3ktr4 has quit IRC
22:45:40  *** frosch123 has quit IRC
22:50:14  <TrueBrain> LordAro: this time it was not me!! :p
22:50:50  <TrueBrain> I am so happy someone else broke it for once :)
22:51:27  <TrueBrain> (Really I am .. means someone else now also knows how it works :D)
22:55:56  *** Progman has quit IRC
23:11:52  *** nielsm has joined #openttd
23:14:44  *** Samu has quit IRC

Powered by YARRSTE version: svn-trunk