Times are UTC Toggle Colours
01:08:54 *** Smedles has quit IRC 01:19:15 *** iSoSyS has joined #openttd 01:26:55 *** Smedles has joined #openttd 01:55:59 *** Flygon has joined #openttd 02:04:04 *** glx has quit IRC 02:12:04 *** iSoSyS has quit IRC 02:16:07 *** Wormnest has quit IRC 02:26:22 *** debdog has joined #openttd 02:29:48 *** D-HUND has quit IRC 04:06:58 *** snail_UES_ has quit IRC 04:14:59 <DorpsGek_III> [OpenTTD/website] Ankit9915 opened pull request #170: improve docs https://git.io/JUyHO 05:35:07 <DorpsGek_III> [OpenTTD/website] prashant-45 opened pull request #171: Update download.html https://git.io/JUyF0 06:41:18 *** andythenorth has joined #openttd 06:53:03 *** supermop_Home_ has quit IRC 07:07:48 *** y2kboy23 has quit IRC 07:27:45 *** andythenorth has quit IRC 07:30:03 *** andythenorth has joined #openttd 07:34:38 <DorpsGek_III> [OpenTTD/website] auge8472 commented on pull request #171: Update download.html https://git.io/JUSvk 07:38:42 <DorpsGek_III> [OpenTTD/website] auge8472 commented on pull request #170: improve docs https://git.io/JUSvZ 07:41:35 <DorpsGek_III> [OpenTTD/website] auge8472 commented on pull request #171: Update download.html https://git.io/JUSvr 07:47:30 <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #170: improve docs https://git.io/JUSff 07:47:30 <DorpsGek_III> [OpenTTD/website] TrueBrain closed pull request #170: improve docs https://git.io/JUyHO 07:48:01 <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #171: Update download.html https://git.io/JUSfJ 07:48:01 <DorpsGek_III> [OpenTTD/website] TrueBrain closed pull request #171: Update download.html https://git.io/JUyF0 07:48:16 <TrueBrain> we can expect more of these PRs, sadly enough, in this whole month 07:49:36 <TrueBrain> please mark them with a label "spam"; DigitalOcean really should stop with this ... they REALLY REALLY should 07:50:03 <TrueBrain> https://blog.domenic.me/hacktoberfest/ and https://news.ycombinator.com/item?id=24643894 for more background and opinions 07:52:33 *** WormnestAndroid has quit IRC 07:52:46 *** WormnestAndroid has joined #openttd 07:55:21 <TrueBrain> it is meant nice from DigitalOcean, but they fail to put safeguards in place to avoid this kind of spam .. they simply put it to all the maintainers .. some projects are hit with massive amounts of these kind of silly PRs :P 07:57:35 *** y2kboy23 has joined #openttd 07:58:44 <DorpsGek_III> [OpenTTD/team] LubosKolouch opened issue #24: [cs_CZ] Translator access request https://git.io/JUSfF 08:01:02 <andythenorth> that's 'lolz' 08:03:41 <LordAro> how interesting 08:03:58 <LordAro> TrueBrain: how did you make the link between the PRs and this DigitalOcean thing? 08:04:20 <TrueBrain> because I read hackernews, and knew this could be coming 08:04:31 <TrueBrain> the username, the content of the PR, and their history (joined today) 08:04:35 <TrueBrain> 1+1=2 08:04:59 <TrueBrain> the other forks they created were also a nice give-away 08:06:15 <LordAro> TrueBrain: and what's happened to DorpsGek for that translator PR? 08:06:19 <andythenorth> is it naptime yet? 08:06:26 <TrueBrain> LordAro: the user removed the label 08:06:31 *** sla_ro|master has joined #openttd 08:06:32 <TrueBrain> I am trying to fix that, but .. I am having a hard time :D 08:06:41 <LordAro> aha 08:06:47 <TrueBrain> users can be silly people .. 08:06:53 <TrueBrain> when you create a new issue, it automatically adds the label 08:06:59 <TrueBrain> he removed it, at least, I assume 08:07:11 <TrueBrain> but the event is given to the action in the payload 08:07:15 <TrueBrain> and not fetched live .. 08:07:29 <LordAro> no ~~plan~~project survives contact with ~~the enemy~~users 08:08:26 <TrueBrain> hmm .. what to do about it ... 08:08:34 <TrueBrain> ask the user to make a new issue! 08:09:51 <DorpsGek_III> [OpenTTD/team] TrueBrain closed issue #24: [cs_CZ] Translator access request https://git.io/JUSfF 08:09:51 <DorpsGek_III> [OpenTTD/team] TrueBrain commented on issue #24: [cs_CZ] Translator access request https://git.io/JUSfF 08:10:29 <TrueBrain> we could also make the bot react on label changes 08:10:39 <TrueBrain> but really, this should not happen to start with :) 08:11:03 <TrueBrain> (given 12 hours earlier a user requested access and this did went okay, I am fairly certain it is not our code at issue :D) 08:19:00 *** cHawk- has quit IRC 09:30:14 <DorpsGek_III> [OpenTTD/team] LubosKolouch opened issue #25: [cs_CZ] Translator access request https://git.io/JUSqP 09:35:55 <DorpsGek_III> [OpenTTD/team] LubosKolouch commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP 09:37:43 <DorpsGek_III> [OpenTTD/team] TrueBrain commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP 09:39:04 <TrueBrain> LordAro: I think we will just need to add this user manually to the team and be done with it .. no clue what is going wrong .. I cannot reproduce the problem :) 09:39:53 <TrueBrain> on mobile too, this just works ... very odd 09:41:38 <LordAro> how odd 09:43:30 <TrueBrain> okay, it seems GitHub rolled out a change in that 12 hours 09:43:35 <DorpsGek_III> [OpenTTD/team] LubosKolouch commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP 09:44:11 <DorpsGek_III> [OpenTTD/team] TrueBrain commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP 09:47:29 <TrueBrain> 1st of October, guess they rolled out something new .. 09:47:35 <TrueBrain> but their docs say this should work :P 09:47:53 <DorpsGek_III> [OpenTTD/team] LubosKolouch commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP 09:48:13 <DorpsGek_III> [OpenTTD/team] LubosKolouch commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP 09:49:01 <DorpsGek_III> [OpenTTD/team] LubosKolouch commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP 09:49:02 <DorpsGek_III> [OpenTTD/team] TrueBrain commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP 09:50:21 <DorpsGek_III> [OpenTTD/team] LubosKolouch commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP 09:51:48 <DorpsGek_III> [OpenTTD/team] TrueBrain commented on issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP 09:51:49 <DorpsGek_III> [OpenTTD/team] TrueBrain closed issue #25: [cs_CZ] Translator access request [request_access] https://git.io/JUSqP 09:51:56 <TrueBrain> doing it manually is painful 09:52:01 <TrueBrain> why GitHub, whyyyyyy 09:57:25 <LordAro> haha 09:59:17 <TrueBrain> I send GitHub a support request for this 09:59:24 <TrueBrain> it really feels like they fucked something up :P 09:59:36 <TrueBrain> especially as the documentation still says this should be possible 09:59:58 <LordAro> i was just looking at the same page 10:00:13 <LordAro> could possibly be an issue with it not being an explicit list? 10:01:21 <TrueBrain> I think more the issue is: it worked 14 hours ago, it doesn't work now, what give GitHub? :P 10:01:26 <TrueBrain> they don't publish a changelog or anything 10:01:39 <LordAro> mm 10:01:45 <TrueBrain> but non-members don't even see the "labels" dialog anymore 10:05:26 <TrueBrain> even their GUI to create issue templates still support it 10:06:01 <DorpsGek_III> [OpenTTD/team] TrueBrain opened pull request #26: Testing labels in issue template https://git.io/JUS3f 10:06:16 <TrueBrain> I did not want it to open a PR for me 10:06:17 <TrueBrain> lol 10:06:24 <TrueBrain> anyway, the syntax is even unchanged 10:06:34 <DorpsGek_III> [OpenTTD/team] TrueBrain closed pull request #26: Testing labels in issue template https://git.io/JUS3f 10:07:17 <TrueBrain> so I really can only conclude that it is either a bug in github.com, or a setting we are not aware of :) 10:27:01 *** cHawk- has joined #openttd 10:51:52 *** tokai has joined #openttd 10:51:53 *** ChanServ sets mode: +v tokai 10:58:43 *** tokai|noir has quit IRC 11:14:06 <DorpsGek_III> [OpenTTD/master-server] TrueBrain opened pull request #14: Add: [Actions] CodeQL analyze on push/pull-request https://git.io/JUScU 11:14:08 <TrueBrain> another day, another attempt :) 11:14:53 <TrueBrain> LordAro: did you figure out how to merge your Github Actions PR? 11:15:08 <LordAro> i've not tried 11:15:19 <TrueBrain> k; let me know if you need any help :) 11:21:05 <TrueBrain> https://github.com/OpenTTD/master-server/security/code-scanning?query=is%3Aopen+ref%3Arefs%2Fpull%2F14%2Fhead 11:21:07 <TrueBrain> there we go :) 11:22:26 <TrueBrain> it is not reporting it in the PR, which is a bit odd 11:26:24 <TrueBrain> and it is running it against wrong versions of the dependencies . hmm 11:30:40 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: Add: [Actions] CodeQL analyze on push/pull-request https://git.io/JUScU 11:41:46 <LordAro> TrueBrain: perhaps because the issues its reporting are not new? 11:41:51 <LordAro> try introducing a new issue :p 11:42:26 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: Add: [Actions] CodeQL analyze on push/pull-request https://git.io/JUScU 11:42:29 <TrueBrain> okay, lets see 11:49:37 <TrueBrain> nope :( 11:50:04 <TrueBrain> weirdly enough, it didn't pick up on the new alert at all 11:50:18 <TrueBrain> owh, possibly I solved the alert by upgrading to Python 3.8 .. 11:50:25 <TrueBrain> and it just doesn't remove alerts on its own, or something? 11:51:03 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: Add: [Actions] CodeQL analyze on push/pull-request https://git.io/JUScU 11:51:04 <TrueBrain> lets try again, this time it should give an alert for sure :D 11:58:21 <TrueBrain> it seems to no longer pick up new alerts or something .. lol 11:58:23 <TrueBrain> this is a bit puzzling :D 12:08:10 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: Add: [Actions] CodeQL analyze on push/pull-request https://git.io/JUScU 12:08:46 <TrueBrain> funny, CodeQL doesn't want to run on the merge result of a pull request, but on the head of the pull request .. I wonder why 12:16:15 <TrueBrain> okay, it is working this funky because it is not in master yet :D 12:16:15 <TrueBrain> lol 12:16:26 <TrueBrain> "Missing analysis for base commit 6a01e3118f9a0c348963c127647c2462f34900ba" 12:18:39 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: Add: [Actions] CodeQL analyze on push/pull-request https://git.io/JUScU 12:26:52 *** snail_UES_ has joined #openttd 12:29:18 <TrueBrain> wow .. I now pip installed all the exact versions we are using, and now analysis takes a lot longer :P 12:29:24 <TrueBrain> but it had the wrong signatures for some .. 12:32:00 *** supermop_Home has joined #openttd 12:37:24 <TrueBrain> it did find 4 very valid "code correctness" statements :) So this is already useful :D 12:40:14 <TrueBrain> it takes ~10 minutes, damn .. that is a long as time 12:40:18 <TrueBrain> as? asssssss 12:44:19 <LordAro> is there an option to use multiple threads? or is it already using them? 12:45:01 *** glx has joined #openttd 12:45:01 *** ChanServ sets mode: +v glx 12:46:05 <DorpsGek_III> [OpenTTD/team] glx22 commented on issue #23: [cs_CZ] Translator access request https://git.io/JUyGp 12:47:03 <TrueBrain> LordAro: I have no clue; this is done with the Actions supplied by GitHub 12:47:21 <TrueBrain> there is no configuration option for it 12:48:47 <TrueBrain> but honestly, 10 minutes .. we can make it non-mandatory, and just accept the time it takes 12:49:08 <TrueBrain> it is not like we are -that- active in the Python projects :) 12:49:15 <TrueBrain> btw, you can also enable this in your CI for OpenTTD 12:49:31 <TrueBrain> it has a whole C++ collection of checks 12:49:58 <TrueBrain> it understands cmake, so it is a variant on the Linux step 12:50:23 <LordAro> sounds fun 12:52:25 <TrueBrain> https://lgtm.com/projects/g/OpenTTD/OpenTTD?mode=tree <- to give you an idea what to expect 12:53:02 <TrueBrain> the codeql-actions does detect things LGTM doesn't, and the other way around, with the "queries: security-and-quality" 12:54:20 <LordAro> "d++;" "This expression has no effect (because operator++ has no external side effects)." uh 12:54:53 <glx> oh nice one :) 12:55:08 <TrueBrain> https://github.com/TrueBrain/OpenTTD-master-server/pull/1/checks?check_run_id=1193441820 12:56:31 <LordAro> :) 12:56:38 *** andythenorth has left #openttd 12:56:55 <LordAro> i don't understand that d++ one at all. is it something to do with it being an iterator? 12:58:29 <TrueBrain> so with master having CodeQL loaded, PRs work nicely 12:59:33 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: Add: [Actions] CodeQL analyze on push/pull-request https://git.io/JUScU 12:59:42 <TrueBrain> so I might do this for all Python repos .. and I think I also add the commit-checker to all 12:59:54 <TrueBrain> well, one thing at the time 12:59:57 <LordAro> might as well 13:00:06 <TrueBrain> hmm .. I can copy it from eints 13:00:08 <TrueBrain> small effort :P 13:00:14 <LordAro> you could fix the few issues it finds as well :p 13:00:20 <TrueBrain> after merge, yes 13:00:37 <TrueBrain> otherwise it will be very hard to see what the error was, and if it is fixed 13:01:37 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: Add: [Actions] CodeQL analyze on push/pull-request https://git.io/JUScU 13:03:03 <TrueBrain> hmm .. commit-checker is not showing all commits in the PR 13:03:28 <LordAro> i've noticed that before 13:05:27 <TrueBrain> okay, I will investigate that a bit later 13:05:34 <TrueBrain> if I am going to copy it 10 times, it better be correct :P 13:05:40 <glx> it used to show all commits 13:07:31 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: [Actions] Add CodeQL and commit-checker https://git.io/JUScU 13:07:36 <TrueBrain> lets make a bit of noise to see what was happening 13:08:08 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: [Actions] Add CodeQL and commit-checker https://git.io/JUScU 13:08:56 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: [Actions] Add CodeQL and commit-checker https://git.io/JUScU 13:10:42 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: [Actions] Add CodeQL and commit-checker https://git.io/JUScU 13:10:47 <TrueBrain> git can be such an annoying brat 13:12:31 <TrueBrain> ah, no, it is doing what it was suppose to be doing .. the output is only a bit annoying 13:12:37 <TrueBrain> seems stderr/stdout are confused 13:13:31 <glx> yeah it's mixed in a weird order 13:14:04 <DorpsGek_III> [OpenTTD/master-server] TrueBrain updated pull request #14: [Actions] Add CodeQL and commit-checker https://git.io/JUScU 13:14:04 <TrueBrain> I removed the "set -x" 13:14:15 <TrueBrain> GitHub Actions are now advanced enough for that not to be the only way to debug them 13:14:44 <TrueBrain> that is a lot more readable 13:14:58 <TrueBrain> there is a \n too much in the commit-checker itself, it seems 13:15:24 <TrueBrain> right, PR ready for review :) 13:33:49 *** nielsm has joined #openttd 13:43:09 <DorpsGek_III> [OpenTTD/team] MontyMontana opened issue #27: [es_ES] Translator access request https://git.io/JUSgX 14:09:49 <LordAro> ^ label works now? 14:23:59 <DorpsGek_III> [OpenTTD/master-server] LordAro approved pull request #14: [Actions] Add CodeQL and commit-checker https://git.io/JUSoY 14:29:05 *** andythenorth has joined #openttd 14:29:32 *** cHawk_ has joined #openttd 14:35:39 *** cHawk- has quit IRC 14:41:26 <DorpsGek_III> [OpenTTD/website] KanchanKangne opened pull request #172: Improve Docs https://git.io/JUS68 14:44:25 <DorpsGek_III> [OpenTTD/website] LordAro commented on pull request #172: Improve Docs https://git.io/JUS6r 14:44:26 <DorpsGek_III> [OpenTTD/website] LordAro closed pull request #172: Improve Docs https://git.io/JUS68 14:49:23 <DorpsGek_III> [OpenTTD/website] auge8472 commented on pull request #172: Improve Docs https://git.io/JUSiL 14:50:04 <andythenorth> can we just offer free t-shirts for NOT making spam requests 14:51:50 <TrueBrain> that change is even worse than the other two :) 14:51:54 <TrueBrain> it really REALLY doesn't add anyhing :D 14:51:55 <TrueBrain> fun 14:52:15 <andythenorth> I am checking if we use DO, and if we do I'm going to cancel 14:53:11 <TrueBrain> it is meant well of them; just too few rules and enforcement from their side, moving the burden to the community they are trying to help 14:54:00 <DorpsGek_III> [OpenTTD/website] LordAro commented on pull request #172: Improve Docs https://git.io/JUSiw 14:54:27 <TrueBrain> it is fun to see other PRs 14:54:30 <TrueBrain> they really are not bots btw 14:54:40 <TrueBrain> they do look into repositories, and find .. "something" they can do 14:54:47 <TrueBrain> just nothing anyone asked for :P 14:54:51 <andythenorth> it's such misguided waste of effort :) 14:55:38 <TrueBrain> https://github.com/ExpertServices/Websitepanel/pull/32/files 14:55:39 <TrueBrain> like this 14:55:40 <TrueBrain> it is cute 14:55:56 <TrueBrain> https://github.com/Shreyas-Sonawane/Credit-Management-Website/pull/8/files <- hahahahaha :D 14:56:27 <TrueBrain> all done via the GitHub GUI 14:56:31 <TrueBrain> so also with low effort from their side 14:57:18 <LordAro> wonder why that repo has been picked up 14:57:26 <LordAro> all 8 PRs are of the same type 14:57:42 <LordAro> are they just searching GH for "website", i wonder? 14:57:43 <glx> nice one, it fixes a "no return at end of line" but adds a broken tag 14:57:59 <TrueBrain> a lot of his PRs accidentally fix EOL :P 15:01:50 <DorpsGek_III> [OpenTTD/team] Xaroth opened issue #28: [nl_NL] Translator access request https://git.io/JUSPB 15:02:28 <DorpsGek_III> [OpenTTD/team] TrueBrain commented on issue #28: [nl_NL] Translator access request https://git.io/JUSPB 15:02:36 *** andythenorth has left #openttd 15:03:03 <LordAro> lol 15:03:27 <TrueBrain> so labels do work 15:03:36 <TrueBrain> at least, now :P 15:04:10 <TrueBrain> I am trying to update my ticket on GitHub support, but it is failing 15:04:12 <TrueBrain> which is hilarious :D 15:05:47 *** y2kboy23 has quit IRC 15:06:06 <TrueBrain> "Comment submission failed" 15:06:09 <TrueBrain> well .. okay ... 15:06:34 <TrueBrain> also cannot close it :D 15:06:35 <TrueBrain> haha 15:07:39 *** cHawk_ has quit IRC 15:09:12 *** y2kboy23 has joined #openttd 15:21:50 <DorpsGek_III> [OpenTTD/bananas-api] TrueBrain opened pull request #71: [Actions] Add CodeQL and commit-checker https://git.io/JUS1u 15:21:53 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain opened pull request #43: [Actions] Add CodeQL and commit-checker https://git.io/JUS1z 15:21:56 <DorpsGek_III> [OpenTTD/bananas-server] TrueBrain opened pull request #31: [Actions] Add CodeQL and commit-checker https://git.io/JUS1g 15:21:58 <DorpsGek_III> [OpenTTD/DorpsGek] TrueBrain opened pull request #34: [Actions] Add CodeQL and commit-checker https://git.io/JUS12 15:22:02 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain opened pull request #10: [Actions] Add CodeQL and commit-checker https://git.io/JUS1a 15:22:05 <DorpsGek_III> [OpenTTD/eints] TrueBrain opened pull request #21: [Actions] Add CodeQL and commit-checker https://git.io/JUS1r 15:22:08 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] TrueBrain opened pull request #11: [Actions] Add CodeQL and commit-checker https://git.io/JUS1K 15:22:13 <TrueBrain> I want that tshirt!! (really, I do not :P) 15:22:37 <DorpsGek_III> [OpenTTD/master-server] TrueBrain merged pull request #14: [Actions] Add CodeQL and commit-checker https://git.io/JUScU 15:22:41 <glx> lol 15:25:00 <TrueBrain> I like how all the repos are kinda of the same :) 15:31:57 <DorpsGek_III> [OpenTTD/team] TrueBrain opened issue #29: [nl_NL] Translator access request https://git.io/JUSMP 15:32:09 <TrueBrain> sorry, was testing the GitHub App 15:32:15 <TrueBrain> but that too does the label correctly 15:32:24 <DorpsGek_III> [OpenTTD/team] TrueBrain commented on issue #29: [nl_NL] Translator access request https://git.io/JUSMP 15:34:38 <TrueBrain> eints has 77 alerts .. wow 15:35:41 <LordAro> oh dear 15:35:46 <LordAro> now do nml! 15:35:49 <DorpsGek_III> [OpenTTD/eints] TrueBrain commented on pull request #21: [Actions] Add CodeQL and commit-checker https://git.io/JUSDU 15:36:14 <TrueBrain> unused imports ... "from . import commands # noqa" 15:36:16 <TrueBrain> no shit? :P 15:36:50 <TrueBrain> "Extracting files from a malicious tar archive without validating that the destination file path is within the destination directory can cause files outside the destination directory to be overwritten, due to the possible presence of directory traversal elements (..) in archive paths." 15:36:56 <TrueBrain> well, that is a security issue indeed 15:37:17 <glx> LordAro: I'm currently reviewing nml#103 :) (it's big) 15:37:20 <TrueBrain> all repositories report some alerts; nothing too scary 15:37:48 <LordAro> glx: i'm surprised it doesn't need a rebase 15:37:51 <TrueBrain> I don't even have NML cloned .. let me fix this 15:40:35 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] TrueBrain updated pull request #11: [Actions] Add CodeQL and commit-checker https://git.io/JUS1K 15:40:58 <DorpsGek_III> [OpenTTD/nml] TrueBrain opened pull request #163: Add CodeQL and commit-checker https://git.io/JUSDz 15:41:03 <TrueBrain> well, there it goes LordAro ... hold on to your hats :P 15:41:44 <TrueBrain> owh .. no requirements.txt 15:41:46 <TrueBrain> euh 15:41:48 <TrueBrain> that is not okay :P 15:42:36 <DorpsGek_III> [OpenTTD/nml] TrueBrain updated pull request #163: Add CodeQL and commit-checker https://git.io/JUSDz 15:44:14 <LordAro> we had that argument already, it doesn't need one :p 15:44:46 <TrueBrain> every repo needs one! And I am sure we already had it .. as I will always mention it when ever I notice it :P 15:44:56 <TrueBrain> how do I know the last version you tested it against :P 15:45:07 <TrueBrain> anyway, it mostly broke my copy/paste 15:45:13 <LordAro> :p 15:45:16 <TrueBrain> but it is running now, don't you worry :) 15:50:50 *** gelignite has joined #openttd 15:53:25 <LordAro> only 52? 15:53:27 <LordAro> i am surprise 15:56:01 <TrueBrain> But 5 that require attention 15:56:09 <TrueBrain> That is the highest so far :p 15:56:33 <LordAro> 8, including the uninitialized variables 15:58:09 <TrueBrain> Not sure those need attention as such .. 15:58:14 <TrueBrain> The first two are baaaadddd 15:58:21 <TrueBrain> The 5th is ... odd 15:58:33 <TrueBrain> Yeah, CodeQL does a good job :) 15:58:44 *** Wormnest has joined #openttd 15:59:47 <LordAro> looks like someone's attempt to get around the whole [[0] * N] * M issue 16:00:51 <LordAro> https://stackoverflow.com/a/2398187/995325 interesting 16:01:55 <TrueBrain> It is terrible code nevertheless :p :p 16:02:00 <LordAro> indeed 16:02:37 <glx> sometimes it's surprising it works ;) 16:02:59 <LordAro> or perhaps how infrequently people come across the broken bits :p 16:03:26 <LordAro> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95189 i.e. this one 16:12:09 <DorpsGek_III> [OpenTTD/nml] glx22 commented on pull request #103: Blacken & Flake8 nml https://git.io/JUSHs 16:25:11 *** frosch123 has joined #openttd 16:29:26 *** HerzogDeXtEr has joined #openttd 16:37:02 *** cHawk_ has joined #openttd 16:38:34 *** Flygon has quit IRC 16:38:58 <DorpsGek_III> [OpenTTD/OpenTTD] JuanManzana commented on issue #8310: when I logged in to 1M city mania the error window pops up... https://git.io/JU0EE 16:39:50 <DorpsGek_III> [OpenTTD/master-server] TrueBrain opened pull request #15: Various of fixes found by CodeQL https://git.io/JUS5r 16:40:00 <TrueBrain> well, the fixes aren't found by CodeQL :P 16:44:00 *** Progman has joined #openttd 16:50:46 <TrueBrain> frosch123: good news, the CodeQL PRs I created do find when people change default parameters in Python :) 16:51:18 <TrueBrain> https://github.com/OpenTTD/master-server/pull/15/checks?check_run_id=1194668924 <- oeh, PRs that fix things are also reported nicely what they fix etc :D Sweet! 16:51:48 <LordAro> nice. 16:52:32 <frosch123> \o/ 16:52:37 <TrueBrain> I did not put CodeQL on a schedule, which they do suggest .. they run it every week once, to find out if anything new happened 16:52:54 <TrueBrain> but as we bump requirements every month (most likely), this will show up at that point in time 16:52:58 <frosch123> i am quite surprised that we are so popular that we got 3 spam prs 16:53:10 <frosch123> or i just underestimate how much junk real projects get 16:53:20 <TrueBrain> we have a lot more repositories on GitHub now compared to last week :P Higher chance? 16:53:32 <TrueBrain> s/week/year/ 16:54:10 <TrueBrain> hmm, I never linked pyup to the master-server repositories, it seems 16:54:29 <TrueBrain> something to fix this weekend, I guess 16:55:34 <DorpsGek_III> [OpenTTD/master-server] LordAro approved pull request #15: Various of fixes for problems found by CodeQL https://git.io/JUSFr 16:56:05 <LordAro> frosch123: i think the spam people are searching for "website" repos 16:56:09 <DorpsGek_III> [OpenTTD/master-server] TrueBrain merged pull request #15: Various of fixes for problems found by CodeQL https://git.io/JUS5r 16:56:23 <LordAro> given all the others TB linked are named similarly 16:56:37 <frosch123> LordAro: yeah, you linked one that has 12 forks and 8 spam prs 16:56:45 <frosch123> so not exactly a popular project 16:57:45 <TrueBrain> guess it has to do with GitHub Explore 16:57:54 <frosch123> TrueBrain: so, when can we cancel our digitalocean thingie? 16:58:14 <TrueBrain> well, I wanted to use them for off-cloud backup 16:58:16 <TrueBrain> now I am not so sure :D 16:58:48 <frosch123> now would be a good chance to write something into "why do you want to quit our service" :p 16:59:00 <TrueBrain> but by pure coincidence, I removed the last links to DO last week :) 16:59:16 <TrueBrain> so before the end of the month, I would say :P 16:59:46 <TrueBrain> again, I really have nothing against DO, and I like they want to contribute to open source .. they just should add more safeguards for these kind of things 17:00:11 <TrueBrain> last year 20% of the PRs were marked either spam or invalid .. and that is just the ones reported by people 17:00:16 <TrueBrain> it is insanely high 17:06:20 <TrueBrain> so, who wants to review 10 times the same PR? :D 17:07:23 <TrueBrain> it even tracks regressions, as in: you can see the timeline of a finding it did :) 17:07:32 <TrueBrain> what introduced it, when it got fixed, etc 17:07:43 <TrueBrain> they did this pretty nice :) 17:07:56 <TrueBrain> now I just wish they added "single PR" for dependabot .. 17:19:31 *** cHawk- has joined #openttd 17:25:39 *** cHawk_ has quit IRC 17:27:41 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] opened pull request #16: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deployments-create https://git.io/JUSpT 17:28:12 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] opened pull request #17: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /docker-build https://git.io/JUSpq 17:28:32 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] opened pull request #18: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /docker-publish https://git.io/JUSpO 17:28:46 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] opened pull request #19: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /checkout https://git.io/JUSpn 17:28:53 <TrueBrain> Hmmm .. didn't we disable this spam? 17:29:34 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] opened pull request #20: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deployments-update https://git.io/JUSp0 17:29:41 <LordAro> apparently not :p 17:29:43 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] opened pull request #21: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deploy-aws https://git.io/JUSpu 17:29:47 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] opened pull request #22: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /checkout-dispatch https://git.io/JUSpg 17:30:02 <TrueBrain> As this is absolutely not okay :p 17:30:22 <LordAro> not so much 17:31:17 <TrueBrain> well, I hit the "disable" button once again :) 17:31:31 <TrueBrain> sadly, I have to close the PRs now too .. 17:31:53 <DorpsGek_III> [OpenTTD/actions] TrueBrain closed pull request #16: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deployments-create https://git.io/JUSpT 17:31:54 <DorpsGek_III> [OpenTTD/actions] TrueBrain closed pull request #17: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /docker-build https://git.io/JUSpq 17:31:57 <DorpsGek_III> [OpenTTD/actions] TrueBrain closed pull request #18: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /docker-publish https://git.io/JUSpO 17:31:59 <DorpsGek_III> [OpenTTD/actions] TrueBrain closed pull request #19: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /checkout https://git.io/JUSpn 17:32:03 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] commented on pull request #16: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deployments-create https://git.io/JUSp1 17:32:05 <DorpsGek_III> [OpenTTD/actions] TrueBrain closed pull request #20: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deployments-update https://git.io/JUSp0 17:32:09 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] commented on pull request #18: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /docker-publish https://git.io/JUSpM 17:32:11 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] commented on pull request #17: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /docker-build https://git.io/JUSpD 17:32:15 <TrueBrain> owh, will you shut up dependabot ... come back when you can be less noisy plz ... 17:32:15 <DorpsGek_III> [OpenTTD/actions] TrueBrain closed pull request #21: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deploy-aws https://git.io/JUSpu 17:32:17 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] commented on pull request #19: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /checkout https://git.io/JUSpy 17:32:21 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] commented on pull request #20: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deployments-update https://git.io/JUSpS 17:32:23 <DorpsGek_III> [OpenTTD/actions] TrueBrain closed pull request #22: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /checkout-dispatch https://git.io/JUSpg 17:32:27 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] commented on pull request #21: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /deploy-aws https://git.io/JUSp9 17:32:29 <DorpsGek_III> [OpenTTD/actions] dependabot[bot] commented on pull request #22: Upgrade: Bump @actions/core from 1.2.5 to 1.2.6 in /checkout-dispatch https://git.io/JUSpH 17:32:30 <TrueBrain> there are a pretty few amount of requests for them to fix this shit ... :P 17:33:57 <Xaroth> lol @ dependabot 17:34:15 <TrueBrain> nothing "lol" about it :P 17:34:22 <TrueBrain> it is a freaking nightmare how they implemented this 17:34:33 <TrueBrain> most other depend-watchers/upgraders allow grouping 17:34:43 <TrueBrain> but .. not the one GitHub acquired 17:34:53 <TrueBrain> and development seems to be focused on integration rather than making it useful :P 17:35:02 <TrueBrain> end-of-rant 17:35:18 <LordAro> narrator: but it was not the end 17:36:32 <TrueBrain> right, now it only emails maintainers about this 17:36:38 <TrueBrain> and that can be configured in notification 17:36:46 <TrueBrain> I don't mind if it tells me about it; I do mind the spam of PRs :P 17:37:49 <TrueBrain> funny enough, by default, it is set to use weekly email digest for that 17:37:59 <TrueBrain> AND FOR NOTIFICATION THEY CAN DO IT?! :P 17:38:54 <glx> it's silly to not bump all actions at once 17:39:25 <glx> it's a single repo 17:43:44 <TrueBrain> okay, checked all repos, on many the dependabot stuff was still on in case of a vulnerability 17:43:51 <TrueBrain> it is now off on all of them, I think :) 17:44:11 <TrueBrain> it now only sends emails to the teams that are in charge of that repository 17:45:35 <DorpsGek_III> [OpenTTD/eints] TrueBrain merged pull request #20: Fix: change footer to point to new home for eints https://git.io/JU1WQ 17:48:25 *** andythenorth has joined #openttd 17:52:13 <DorpsGek_III> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/JUSjd 17:52:13 <DorpsGek_III> - Update: Translations from eints (by translators) 18:04:23 <TrueBrain> and here is pyup! 18:04:25 <DorpsGek_III> [OpenTTD/bananas-api] pyup-bot opened pull request #72: Scheduled monthly dependency update for October https://git.io/JU9vc 18:05:08 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] pyup-bot opened pull request #12: Scheduled monthly dependency update for October https://git.io/JU9v0 18:06:06 <DorpsGek_III> [OpenTTD/bananas-frontend-web] pyup-bot opened pull request #44: Scheduled monthly dependency update for October https://git.io/JU9vo 18:06:41 <DorpsGek_III> [OpenTTD/bananas-api] LordAro approved pull request #72: Scheduled monthly dependency update for October https://git.io/JU9vX 18:07:08 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] LordAro approved pull request #12: Scheduled monthly dependency update for October https://git.io/JU9vS 18:07:15 <TrueBrain> and THOSE you approve? :( :P 18:07:21 <DorpsGek_III> [OpenTTD/bananas-server] pyup-bot opened pull request #32: Scheduled monthly dependency update for October https://git.io/JU9vF 18:07:23 <DorpsGek_III> [OpenTTD/bananas-frontend-web] LordAro approved pull request #44: Scheduled monthly dependency update for October https://git.io/JU9vN 18:07:34 <LordAro> yes. 18:08:17 <DorpsGek_III> [OpenTTD/DorpsGek] pyup-bot opened pull request #35: Scheduled monthly dependency update for October https://git.io/JU9fT 18:08:27 <TrueBrain> what is wrong with my PRs? :D 18:09:02 <LordAro> which ones did i miss? 18:09:09 <TrueBrain> which of the 10? :P 18:09:13 <TrueBrain> in every repo you had open at least one :) 18:09:35 <LordAro> oh 18:09:38 <TrueBrain> lol 18:09:43 <LordAro> i didn't see DorpsGek notify :p 18:10:01 <DorpsGek_III> [OpenTTD/DorpsGek] LordAro approved pull request #34: [Actions] Add CodeQL and commit-checker https://git.io/JU9fZ 18:10:03 <LordAro> or maybe i did 18:10:05 <LordAro> idk 18:10:16 <DorpsGek_III> [OpenTTD/DorpsGek] LordAro approved pull request #35: Scheduled monthly dependency update for October https://git.io/JU9fn 18:10:52 <TrueBrain> I dont blame you for missing that spam :P 18:11:26 <DorpsGek_III> [OpenTTD/bananas-server] LordAro approved pull request #32: Scheduled monthly dependency update for October https://git.io/JU9fB 18:11:39 <DorpsGek_III> [OpenTTD/bananas-server] LordAro approved pull request #31: [Actions] Add CodeQL and commit-checker https://git.io/JU9fR 18:12:07 <DorpsGek_III> [OpenTTD/bananas-frontend-web] LordAro approved pull request #44: Scheduled monthly dependency update for October https://git.io/JU9fz 18:12:25 <DorpsGek_III> [OpenTTD/bananas-frontend-web] LordAro approved pull request #43: [Actions] Add CodeQL and commit-checker https://git.io/JU9fV 18:12:43 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] LordAro approved pull request #11: [Actions] Add CodeQL and commit-checker https://git.io/JU9fr 18:13:21 <DorpsGek_III> [OpenTTD/bananas-api] LordAro approved pull request #71: [Actions] Add CodeQL and commit-checker https://git.io/JU9fi 18:13:41 <DorpsGek_III> [OpenTTD/eints] LordAro approved pull request #21: [Actions] Add CodeQL and commit-checker https://git.io/JU9fM 18:13:51 <TrueBrain> spammert :P 18:14:19 <DorpsGek_III> [OpenTTD/nml] LordAro approved pull request #163: Add CodeQL and commit-checker https://git.io/JU9fS 18:14:31 <DorpsGek_III> [OpenTTD/master-server-web] LordAro approved pull request #10: [Actions] Add CodeQL and commit-checker https://git.io/JU9fQ 18:14:43 <LordAro> what did i miss? :p 18:16:18 <TrueBrain> nope, that was it :) 18:16:19 <TrueBrain> tnx a lot :D 18:16:42 <DorpsGek_III> [OpenTTD/nml] LordAro approved pull request #145: Tidying grfstrings.handle_string a bit. https://git.io/JU9JU 18:17:41 <DorpsGek_III> [OpenTTD/nml] LordAro merged pull request #151: Add: Ignore unreferenced named parameters https://git.io/Jfa8j 18:17:57 <LordAro> oops, missed the message about not merging that one until Eddi|zuHause had tested it 18:18:02 <LordAro> ah well, he had 5 months 18:18:17 <Eddi|zuHause> i what? 18:18:31 <LordAro> nml#151 was apparently waiting for you to test it 18:19:09 <Eddi|zuHause> i'm fairly sure i tested that 18:20:01 <Eddi|zuHause> i'm also fairly sure it didn't help solve my original issue of running out of parameters :) 18:30:23 <DorpsGek_III> [OpenTTD/nml] TrueBrain merged pull request #163: Add CodeQL and commit-checker https://git.io/JUSDz 18:30:38 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] TrueBrain merged pull request #11: [Actions] Add CodeQL and commit-checker https://git.io/JUS1K 18:31:15 *** iSoSyS has joined #openttd 18:31:17 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] TrueBrain merged pull request #12: Scheduled monthly dependency update for October https://git.io/JU9v0 18:31:29 <DorpsGek_III> [OpenTTD/eints] TrueBrain merged pull request #21: [Actions] Add CodeQL and commit-checker https://git.io/JUS1r 18:31:39 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain merged pull request #10: [Actions] Add CodeQL and commit-checker https://git.io/JUS1a 18:31:49 <DorpsGek_III> [OpenTTD/DorpsGek] TrueBrain merged pull request #34: [Actions] Add CodeQL and commit-checker https://git.io/JUS12 18:32:13 <DorpsGek_III> [OpenTTD/DorpsGek] TrueBrain merged pull request #35: Scheduled monthly dependency update for October https://git.io/JU9fT 18:32:23 <DorpsGek_III> [OpenTTD/bananas-server] TrueBrain merged pull request #31: [Actions] Add CodeQL and commit-checker https://git.io/JUS1g 18:32:46 <TrueBrain> branch is out-of-date .. lol .. how? :D 18:32:56 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain merged pull request #43: [Actions] Add CodeQL and commit-checker https://git.io/JUS1z 18:33:04 <DorpsGek_III> [OpenTTD/bananas-api] TrueBrain merged pull request #71: [Actions] Add CodeQL and commit-checker https://git.io/JUS1u 18:33:26 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain merged pull request #44: Scheduled monthly dependency update for October https://git.io/JU9vo 18:33:53 <DorpsGek_III> [OpenTTD/bananas-api] TrueBrain updated pull request #72: Scheduled monthly dependency update for October https://git.io/JU9vc 18:34:03 <DorpsGek_III> [OpenTTD/bananas-server] TrueBrain updated pull request #32: Scheduled monthly dependency update for October https://git.io/JU9vF 18:35:36 <DorpsGek_III> [OpenTTD/bananas-api] TrueBrain merged pull request #72: Scheduled monthly dependency update for October https://git.io/JU9vc 18:35:54 <DorpsGek_III> [OpenTTD/bananas-server] TrueBrain merged pull request #32: Scheduled monthly dependency update for October https://git.io/JU9vF 18:37:06 <TrueBrain> right ... that was a lot of spam :D 18:37:14 <TrueBrain> this weekend I will try to fix most alerts we now have :D 18:37:19 <TrueBrain> tnx again LordAro ! 18:37:21 <LordAro> \o/ 19:48:33 <TrueBrain> https://hacktoberfest.digitalocean.com/hacktoberfest-update 19:48:42 <TrueBrain> Seems all the bad PR got their attention 19:54:17 <frosch123> so they added a "if you desperately want a t-shirt, you can just get it" :) 19:57:40 <LordAro> https://gist.github.com/LordAro/d292a50202928def4bb6e8338713c053 trying out some minor NML properties refactoring (starting off with action0properties) - thoughts? 20:00:52 <frosch123> what has changed? put everything in a single initialisation and move to a new file? or did you change something inside the tables? 20:01:09 <LordAro> yeah, just put everything into a single initialisation 20:01:26 <LordAro> (some minor changes of some .extend(foo) to **foo) 20:02:08 <LordAro> there's 2 files in the gist 20:02:51 <LordAro> the first is if we add a fmt: off directive to retain alignment (though i can do some further manual tidyups) - but just the one, rather than having them scattered throughout the file 20:02:59 <LordAro> the second is just letting black do all the formatting 20:03:33 <frosch123> really? the second one is still aligned 20:03:43 <frosch123> i have a hard time seeing any difference between the files 20:03:46 <LordAro> ...crap 20:03:48 <LordAro> hang on 20:06:09 <LordAro> ok, try now 20:07:03 *** iSoSyS has quit IRC 20:08:11 <frosch123> yeah... i guess i still prefer the eints solution: put data tables into a separate file, and do not format them :) 20:08:28 <frosch123> data tables are no source code 20:08:53 <frosch123> they are not python, they are their own domain specific language 20:08:55 <LordAro> yeah, the issue with that is that most of the rest of action0properties.py is functions that are used for the properties initialisation 20:09:11 <frosch123> LordAro: the classes could go into a real file 20:09:25 <frosch123> the "named lambdas" can stay with the table 20:10:41 <LordAro> frosch123: the classes are used in the "named lambdas" though 20:11:00 <frosch123> yes, so the table would import those classes? 20:11:05 <frosch123> or is that too much crap? 20:11:32 <LordAro> i would say so :p 20:11:48 <frosch123> oh wait.. there are two types of classes in there 20:11:48 <LordAro> hence why i just put properties in a single table at the bottom of the file instead 20:13:25 <frosch123> hmm, i got mislead by the first two classes. most classes are just like the named lambdas 20:13:32 <FLHerne> Oh, nml is back on the agenda? 20:13:48 <LordAro> FLHerne: glx reviewed my "reformat everything" PR 20:13:55 <LordAro> so i took a look at it again :p 20:15:15 <frosch123> FLHerne: possibly it's more attractive than ruby 20:16:05 <FLHerne> glx: Did you agree with Eddi that the unused-parameters thing doesn't break stuff? 20:16:51 <FLHerne> LordAro: Hm, that means I have to rebase #70 and try to get it merged first... 20:17:13 <FLHerne> (I think we were comparing nightmarishness of rebases before) 20:18:31 <LordAro> FLHerne: i'm also trying to do this in such a way that future rebases should just be a case of "cherry pick all but last commit, then rerun black" 20:22:40 <glx> FLHerne: I didn't merge the unused-parameters myself ;) 20:26:42 <FLHerne> LordAro: Did *you* agree with Eddi that... :p 20:27:26 <LordAro> FLHerne: i didn't notice the comment before i clicked the merge button :p 20:27:38 <LordAro> only that it had been approved for months 20:28:45 <FLHerne> Well, okay, let's see if he complains :D 20:38:02 <DorpsGek_III> [OpenTTD/nml] FLHerne updated pull request #70: Reduce boilerplate for creating BinOps https://git.io/Jey9d 20:38:30 <FLHerne> LordAro: So, please can I merge this one before you reformat the entire codebase? ;-) 20:38:44 <FLHerne> I've lost all the random sed commands I used to create it 20:40:23 <FLHerne> What does this CodeQL thing actually do? 20:44:45 *** andythenorth has quit IRC 20:49:24 <LordAro> static analyser 20:49:29 <LordAro> but yeah, i guess you can :p 20:50:06 <LordAro> fixing those new issues would be ideal 20:54:42 <frosch123> LordAro: i think the easiest option is to exclude global_constants, grfstrings, action0properties, action2var_variables and action3_callbacks from the formatting and checking, and format the rest. just leave those 5 files for later :) 20:55:45 <frosch123> the latter 3 are essentially already "tables in separate files" 20:56:07 *** andythenorth has joined #openttd 20:56:17 <frosch123> grfstrings could possibly be split later 21:03:05 <FLHerne> Oh, making the cyclic import not matter was actually why I refactored the `commutative` thing 21:03:19 <FLHerne> I guess I should fix it properly to make the analyzer happy 21:05:05 *** gelignite has quit IRC 21:12:58 *** frosch123 has quit IRC 21:24:44 *** sla_ro|master has quit IRC 21:28:22 *** andythenorth has quit IRC 21:31:21 <DorpsGek_III> [OpenTTD/nml] LordAro updated pull request #103: Blacken & Flake8 nml https://git.io/JfIhy 21:45:27 <TrueBrain> It fixes many alerts, and introduces a bunch of new ones .. lol .. 21:45:50 <LordAro> shhh 21:46:43 <TrueBrain> It fails to put 1 and 1 together; that is funny 22:15:18 *** HerzogDeXtEr has quit IRC 22:20:07 <Eddi|zuHause> <FLHerne> glx: Did you agree with Eddi that the unused-parameters thing doesn't break stuff? <-- well, it does kinda break CETS, but that wasn't really the point. and it should not be a reason to hold back the merging. 22:21:51 <Eddi|zuHause> there's a fairly trivial way to force CETS to reference the parameters it cares about, and a more involved one to move the parameter definitions to the separate "build units" 22:47:38 *** Progman has quit IRC 22:55:22 <DorpsGek_III> [OpenTTD/nml] LordAro updated pull request #103: Blacken & Flake8 nml https://git.io/JfIhy 22:59:07 <DorpsGek_III> [OpenTTD/nml] LordAro updated pull request #103: Blacken & Flake8 nml https://git.io/JfIhy 23:00:12 *** Wormnest has quit IRC 23:02:13 <DorpsGek_III> [OpenTTD/nml] LordAro updated pull request #103: Blacken & Flake8 nml https://git.io/JfIhy 23:18:19 *** nielsm has quit IRC