Times are UTC Toggle Colours
01:30:38 *** gnu_jj has joined #openttd 02:00:52 *** Wormnest has quit IRC 02:02:23 *** Flygon has joined #openttd 02:24:11 *** debdog has joined #openttd 02:27:33 *** D-HUND has quit IRC 02:47:29 *** nielsm has joined #openttd 03:22:01 *** glx has quit IRC 04:38:20 *** snail_UES_ has quit IRC 06:41:47 *** berndj-blackout has quit IRC 06:41:51 *** berndj has joined #openttd 07:22:32 <TrueBrain> https://github.com/digitalocean/hacktoberfest/pull/596 07:25:43 *** jottyfan has joined #openttd 07:35:47 *** andythenorth has joined #openttd 07:49:33 *** sla_ro|master has joined #openttd 08:04:28 *** jottyfan has quit IRC 08:11:45 *** andythenorth has quit IRC 08:18:57 *** andythenorth has joined #openttd 08:20:13 *** Progman has joined #openttd 08:33:21 <andythenorth> yo 08:33:59 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] TrueBrain opened pull request #13: Fix: always show a response in the browser during authentication https://git.io/JUQ7W 08:40:42 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain opened pull request #45: Various of fixes for problems found by CodeQL https://git.io/JUQ7F 08:49:22 *** iSoSyS has joined #openttd 08:59:19 <LordAro> oy 09:00:13 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] LordAro approved pull request #13: Fix: always show a response in the browser during authentication https://git.io/JUQdV 09:02:19 <DorpsGek_III> [OpenTTD/bananas-frontend-web] LordAro commented on pull request #45: Various of fixes for problems found by CodeQL https://git.io/JUQdX 09:04:04 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain commented on pull request #45: Various of fixes for problems found by CodeQL https://git.io/JUQdF 09:04:14 <DorpsGek_III> [OpenTTD/bananas-frontend-cli] TrueBrain merged pull request #13: Fix: always show a response in the browser during authentication https://git.io/JUQ7W 09:05:26 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain commented on pull request #45: Various of fixes for problems found by CodeQL https://git.io/JUQdh 09:07:40 <DorpsGek_III> [OpenTTD/bananas-frontend-web] LordAro commented on pull request #45: Various of fixes for problems found by CodeQL https://git.io/JUQFL 09:12:21 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain commented on pull request #45: Various of fixes for problems found by CodeQL https://git.io/JUQFg 09:12:56 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain commented on pull request #45: Various of fixes for problems found by CodeQL https://git.io/JUQFa 09:12:59 <TrueBrain> too much typing! :P 09:13:07 <TrueBrain> this really broke me head several times today already 09:14:56 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain updated pull request #45: Various of fixes for problems found by CodeQL https://git.io/JUQ7F 09:15:04 <TrueBrain> added to the commit message that it is not only the SAST that could get confused :) 09:16:11 * andythenorth has an annoying cold 09:16:11 <LordAro> :p 09:16:13 <andythenorth> meh 09:16:35 <LordAro> aah, the sickness! 09:16:50 <LordAro> quick, kick him before he infects us all! 09:23:23 <TrueBrain> LordAro: if you are better suggestions, let me know. But how ever I run this circle .. this is just an annoying flask-implementation-detail .. and I should never have mentioned it is :D 09:23:33 <TrueBrain> if there was a "return" from the start, nobody would think twice about it 09:24:35 <DorpsGek_III> [OpenTTD/bananas-server] TrueBrain opened pull request #33: Fix CodeQL warning and a sentry crash report https://git.io/JUQbK 09:30:58 <DorpsGek_III> [OpenTTD/DorpsGek] TrueBrain opened pull request #36: Various of fixes for problems found by CodeQL https://git.io/JUQNl 09:31:38 <TrueBrain> and this concludes all the CodeQL alerts in the repositories I am fixing them in :) I think ... :P 09:31:55 *** SpComb^ has joined #openttd 09:33:26 <LordAro> TrueBrain: it's like "return os.exit(1)" though, you'd definitely say that was weird 09:33:46 <TrueBrain> because you assume every human knows what os.exit() does 09:33:59 <TrueBrain> what flask.abort() does .. I honestly would expect it to return a web-result 09:34:04 <TrueBrain> not raise an exception 09:34:14 <TrueBrain> but this leads to NOT_REACHED() statements 09:34:21 <TrueBrain> which, as you might know, are ugly as fuck :P 09:34:50 <TrueBrain> but for example the redirect() slightly above it, does return a web-result 09:35:16 <TrueBrain> so flask.redirect() does something else than flask.abort() 09:35:21 <TrueBrain> it is just messy 09:35:32 <TrueBrain> and this is why I mention: any comment would only make the user go: huh? 09:35:40 <TrueBrain> while no comment with a return would go a user like: sure! 09:36:38 <TrueBrain> it really would have been better if their docs said: you should use "raise flask.abort()" 09:36:42 <TrueBrain> THAT would be very clear 09:36:46 <DorpsGek_III> [OpenTTD/bananas-server] LordAro approved pull request #33: Fix CodeQL warning and a sentry crash report https://git.io/JUQAI 09:36:58 <TrueBrain> bananas-server one failed to fix the alert :( 09:37:34 *** iSoSyS has quit IRC 09:37:49 <TrueBrain> tempted to write it off as a false-positive after the PR 09:37:52 <DorpsGek_III> [OpenTTD/DorpsGek] LordAro approved pull request #36: Various of fixes for problems found by CodeQL https://git.io/JUQAm 09:38:27 <TrueBrain> LordAro: I think I know the better solution to abort(): not use it! 09:38:29 <TrueBrain> let me try that .. 09:40:10 *** SpComb is now known as SpComb_ 09:40:28 *** SpComb^ is now known as SpComb 09:41:49 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain updated pull request #45: Various of fixes for problems found by CodeQL https://git.io/JUQ7F 09:41:53 <TrueBrain> solved the argument :) 09:42:18 <DorpsGek_III> [OpenTTD/DorpsGek] TrueBrain merged pull request #36: Various of fixes for problems found by CodeQL https://git.io/JUQNl 09:43:48 *** Laedek has joined #openttd 09:55:53 <DorpsGek_III> [OpenTTD/bananas-server] TrueBrain dismissed a review for pull request #33: Fix CodeQL warning and a sentry crash report https://git.io/JUQAI 09:55:53 <DorpsGek_III> [OpenTTD/bananas-server] TrueBrain updated pull request #33: Fix CodeQL warning and a sentry crash report https://git.io/JUQbK 09:55:58 <TrueBrain> let's see if this fixes the alert 10:06:06 <LordAro> works for me :p 10:06:33 <TrueBrain> yeah, turns out the problem was even worse .. as not_found() was used in a proper workflow, and abort() was completely unneeded :) 10:07:03 <TrueBrain> https://github.com/OpenTTD/bananas-server/pull/33/checks?check_run_id=1202529122 10:07:09 <TrueBrain> so .. did it fix it? or didn't it? wtf? :P 10:09:10 <LordAro> lol 10:10:45 <TrueBrain> what is unclear in documentation, if you want the "open" to be in the __enter__ or in the __init__ 10:10:51 <TrueBrain> the example in the Python docs suggest the latter 10:11:00 <TrueBrain> but that still allows leaking of the fd honestly 10:11:15 <TrueBrain> but, if you want to shoot yourself in the foot 10:11:26 <TrueBrain> I am now 99.99% sure the fd is always closed in this codebase, and will consider it now a false positive :D 10:16:59 *** frosch123 has joined #openttd 10:18:38 <DorpsGek_III> [OpenTTD/bananas-frontend-web] LordAro approved pull request #45: Various of fixes for problems found by CodeQL https://git.io/JUQjv 10:20:43 <DorpsGek_III> [OpenTTD/bananas-server] LordAro approved pull request #33: Fix CodeQL warning and a sentry crash report https://git.io/JUQj3 10:21:01 <TrueBrain> Cheers LordAro! 10:21:33 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain merged pull request #45: Various of fixes for problems found by CodeQL https://git.io/JUQ7F 10:21:42 <LordAro> i also "officially" resolved the "open" as a false positive 10:21:45 <LordAro> as apparently i can do that 10:21:58 <DorpsGek_III> [OpenTTD/bananas-server] TrueBrain merged pull request #33: Fix CodeQL warning and a sentry crash report https://git.io/JUQbK 10:22:03 <LordAro> bet it doesn't persist after the merge.. 10:22:20 <TrueBrain> Ghehe 10:22:50 *** andythenorth has quit IRC 10:23:37 *** andythenorth has joined #openttd 10:24:09 <DorpsGek_III> [OpenTTD/team] ozcanakdora opened issue #31: [tr_TR] Translator access request https://git.io/JUQjr 10:26:33 <DorpsGek_III> [OpenTTD/team] ozcanakdora commented on issue #31: [tr_TR] Translator access request https://git.io/JUQjr 10:27:43 <DorpsGek_III> [OpenTTD/team] LordAro commented on issue #31: [tr_TR] Translator access request https://git.io/JUQjr 10:29:16 <TrueBrain> Did he delete his comment? 10:29:21 <LordAro> i guess so 10:29:46 <TrueBrain> Was afraid DorpsGek was acting up :p 10:29:57 <LordAro> me too :p 10:31:39 *** andythenorth has quit IRC 10:33:24 <LordAro> oh yes, i didn't quite finish blackening nml 10:33:31 <LordAro> damn line lengths 10:34:06 <LordAro> and black CI failed inexplicably 10:34:16 <LordAro> https://github.com/OpenTTD/nml/pull/103/checks?check_run_id=1196186620#step:4:44 10:36:45 <TrueBrain> well, "inexplicably".. 10:36:49 <TrueBrain> syntax error near unexpected token `(' 10:36:55 <TrueBrain> black -l 120 --exclude (generated|nml/actions/action2var_variables.py|nml/actions/action3_callbacks.py) --check nml 10:37:02 <TrueBrain> I can add 1 to 1, and get to 2, with this information ;) 10:37:05 <LordAro> ooh 10:37:14 <LordAro> i thought it was during the pip install process 10:37:23 <TrueBrain> not sure if "inexplicably" means "not reading", in your case :P 10:37:24 <TrueBrain> :D :D 10:37:26 <TrueBrain> <3 10:37:29 <LordAro> :( 10:37:32 <LordAro> so mean 10:37:38 <TrueBrain> counting to three is difficult, I know :P 10:37:39 <TrueBrain> :D :D 10:37:40 <TrueBrain> sorry :P 10:38:00 <TrueBrain> I like that on the top of a GitHub Actions it tells you now what it is going to execute 10:38:10 <TrueBrain> but yeah, it is not immediately clear which line really failed 10:43:52 <TrueBrain> funny, black does have an GitHub Action made by upstream 10:43:56 <TrueBrain> just .. with no configuration settings 10:44:12 <LordAro> that is their style :p 10:44:49 <TrueBrain> you can make a pyproject.toml with settings in there 10:45:02 <TrueBrain> https://github.com/psf/black#configuration-format 10:45:03 <TrueBrain> open the example 10:45:18 <TrueBrain> we might want to do that for all projects tbh, and just use the upstream GitHub action 10:45:18 <LordAro> that could work 10:45:22 <LordAro> yeah 10:48:28 <TrueBrain> I rather have that composite workflows work with more things besides "run", as that would allow us to put a "black" workflow on a single place 10:49:00 <TrueBrain> actions in actions would really help, basically :) 10:49:39 <TrueBrain> in fact, it would make most of the "actions" repository redundant :D 10:49:47 <LordAro> aye 10:49:54 <LordAro> you want to work on that? :p 10:50:06 <LordAro> given i still haven't gotten my head around how they're supposed to work anyway 10:50:20 <TrueBrain> no, sorry, you misunderstood me: GitHub doesn't support this yet 10:50:31 <TrueBrain> their only "supported" composite workflows are with "run" statements 10:50:35 <TrueBrain> you cannot do actions in actions 10:50:37 <LordAro> oh right, yes 10:50:49 <TrueBrain> and I would love to implement it, but I don't work for GitHub :P 10:51:39 *** tokai has joined #openttd 10:51:39 *** ChanServ sets mode: +v tokai 10:54:35 <TrueBrain> funny, you can now select that you can only use external GitHub Actions that are made by verified creators 10:54:49 <TrueBrain> but there is no way to become a verified creator atm, unless you have ties with GitHub as organisation 10:54:53 <TrueBrain> that is not fair :P 10:55:40 <TrueBrain> I really do like on forks "schedules" become disabled by default now .. as that was so silly it wasn't :) 10:57:53 <DorpsGek_III> [OpenTTD/team] leonengel opened issue #32: [hr_HR] Translator access request https://git.io/JU7fZ 10:58:24 <DorpsGek_III> [OpenTTD/team] leonengel opened issue #33: [it_IT] Translator access request https://git.io/JU7fc 10:58:43 *** tokai|noir has quit IRC 10:59:06 <LordAro> double translator! 10:59:16 <TrueBrain> unusual :) 10:59:24 <LordAro> imagine knowing more than two languages 11:02:16 <TrueBrain> I am Dutch; that is not hard to imagine :P 11:05:33 <LordAro> I am English; I think I could still do some very basic French if I really worked at it? :p 11:07:58 <TrueBrain> I learnt 6 languages during high school .. 2 of them were dead languages :P 11:08:19 <frosch123> 2 dead languages? what's the other one? 11:08:25 <TrueBrain> Old Greek and Latin 11:08:47 <frosch123> old greek, fancy :) 11:08:51 <TrueBrain> bonus: I can read signs in Greece just fine :P 11:09:02 <frosch123> oh, i can do that too, because maths 11:09:10 <TrueBrain> well, I remember 3 words from old greek .. that is it .. so yeah :P 11:09:21 <LordAro> very fancy 11:09:34 <TrueBrain> pretty sure it was a waste of brainpower :P 11:09:52 <TrueBrain> Latin is not much better, but I have those flashbacks from time to time :P 11:10:12 <frosch123> i liked latin because i liked roman stuff 11:10:47 <frosch123> and when english moved from learning about talking english to talking about english literature, latin was actually more useful 11:11:01 <TrueBrain> shit like: a ae ae am, sometimes hit my brain for no reason WHAT SO EVER :P 11:11:46 <TrueBrain> wait, that was greek .. 11:11:56 <TrueBrain> a ae ae am a, I guess 11:12:31 <frosch123> us i or um e ? 11:12:34 <TrueBrain> never understood why they had 5 of those .... 11:12:36 <frosch123> not quite sure 11:12:48 <TrueBrain> us i o um o 11:12:48 <frosch123> TrueBrain: they had 7 11:13:05 <TrueBrain> well, yes, but you can ignore 2 :P 11:13:18 <frosch123> and even funnier, i learned from smatz that czech has the same cases to this day 11:13:31 <TrueBrain> old Dutch had several too ... 11:13:37 <TrueBrain> happy we are down to 3 :) 11:13:51 <TrueBrain> German has still 4, right? 11:13:54 <frosch123> rescue the genitive! 11:14:20 <frosch123> officially we have 4, but one is talked dead like ottd :p 11:14:52 <TrueBrain> I remember we had to learn that .. for some shitty reason .. 11:15:20 <TrueBrain> owh, Dutch also knows 4 officially, I read ... 11:15:33 <TrueBrain> TIL 11:17:27 <TrueBrain> and of course the shitty things like: tu te tui tibi te .. ugh :P 11:17:38 <TrueBrain> well, honestly, it helps sometimes in understanding languages you don't know .. 11:18:43 <LordAro> like programming languages, i suppose 11:18:44 <TrueBrain> or: sum es est sumus estis sunt 11:19:12 <TrueBrain> or, depending on the .. what is the english word for that .. "time" ? 11:19:18 <TrueBrain> eram eras erat eramus eratis erant 11:19:20 <frosch123> looks like your memory is better than mine :) 11:19:28 <TrueBrain> I am also looking shit up, don't worry :P 11:19:37 <frosch123> TrueBrain: tense? 11:19:43 <TrueBrain> Indicativus, in Latin :P 11:20:00 <frosch123> indicative, conjunctive 11:20:10 <TrueBrain> I learnt Dutch a lot better by learning Latin .. 11:20:19 <TrueBrain> never knew the mathematical connection between tenses etc 11:20:24 <TrueBrain> (I am dyslectic .. sue me :P) 11:20:45 <TrueBrain> by learning a language from the theory, it really helped understanding my own language 11:20:49 <TrueBrain> which is funny .. 11:21:22 <frosch123> https://en.wikipedia.org/wiki/Archaic_Dutch_declension <- hmm... 11:22:29 <TrueBrain> Dutch is a very simple language to learn :P 11:22:37 <TrueBrain> also relative pure, in that what you write is what you speak, mostly 11:22:40 <TrueBrain> bit like Danish 11:23:08 <frosch123> i think that applies to most languages, except english 11:23:20 <TrueBrain> some are more pure than others :) 11:23:46 <frosch123> also the cow/beef, swine/pork thingie is funny 11:23:59 <TrueBrain> what do you mean? 11:24:33 <frosch123> the animals use the german-derived names, the meat uses the french-derived names 11:24:41 <TrueBrain> lol 11:24:46 <TrueBrain> sounds about right :P 11:25:07 <frosch123> which apparently reflects the difference between french rulers and germanish workers 11:25:08 <TrueBrain> I like in Dutch, and I guess other languages have that too, that it is heavily evolving .. we care less and less about certain aspects 11:25:47 <TrueBrain> "van jouw" used to be a big no-no (it is "van jou") .. but less and less people care :P 11:26:12 <TrueBrain> it comes and goes, of course, but it is funny 11:26:27 <TrueBrain> "as long as you can understand each other, who gives a rats ass", basically :P 11:27:13 <frosch123> i only understand dutch in paragraphs. you need enough context to guess the words :) 11:27:23 <TrueBrain> the main part in Dutch where people are still picky on nom/gen/dat/acc shit, is with "zij/hun/hen", dutch for yours 11:27:32 <frosch123> i guess that's also how i translated latin mostly 11:27:34 <TrueBrain> there people go bananas on using it correctly 11:27:53 <TrueBrain> yeah .. I passed Latin on being able to understand context 11:28:02 <TrueBrain> what I often had wrong, was that I picked the inverse 11:28:07 <TrueBrain> as I missed the negate in the sentence 11:28:23 <TrueBrain> so Camilia was NOT angry at the dog 11:29:06 <frosch123> oh, yeah, when you got something wrong in the beginning of a text, and you guessed the rest of the text with that, your translations turns worse and worse 11:29:13 <TrueBrain> I also learnt my appreciation for long sentences, connected with commas; and let's not forget the side-sentences you can create 11:29:25 <TrueBrain> Caesar was my hero, with a single sentence over 6 pages 11:29:50 <frosch123> now you are exagerating 11:29:51 <TrueBrain> s/I also learnt/I also learnt from latin/ 11:30:22 <TrueBrain> sadly, my exam was about Caesar .. the first 3 words and the last 4 were pages apart 11:30:25 <TrueBrain> he was a hero in that kind of shit 11:33:14 <TrueBrain> right, what was I doing .. owh, yeah, deploying all the new stuff to production .. 11:34:10 <DorpsGek_III> [OpenTTD/bananas-api] TrueBrain created new tag: 1.0.4 https://git.io/JU7TN 11:34:33 <DorpsGek_III> [OpenTTD/bananas-frontend-web] TrueBrain created new tag: 1.0.5 https://git.io/JU7Tp 11:35:04 <DorpsGek_III> [OpenTTD/bananas-server] TrueBrain created new tag: 1.0.12 https://git.io/JU7ke 11:36:18 <DorpsGek_III> [OpenTTD/DorpsGek] TrueBrain created new tag: 1.0.11 https://git.io/JU7kL 11:36:50 <TrueBrain> hmm, pyup never made PRs .. let me see if I can fix that .. 11:37:28 <DorpsGek_III> [OpenTTD/master-server] pyup-bot opened issue #18: Initial Update https://git.io/JU7ks 11:37:34 <TrueBrain> Error 11:37:34 <TrueBrain> Unknown Error 11:37:38 <TrueBrain> well, that clearly is not working 11:37:48 <DorpsGek_III> [OpenTTD/master-server] TrueBrain closed issue #18: Initial Update https://git.io/JU7ks 11:39:22 <TrueBrain> there isn't a button: make PR now :P 11:39:37 *** DorpsGek_III has quit IRC 11:44:22 *** DorpsGek_III has joined #openttd 11:44:23 <DorpsGek_III> [OpenTTD/master-server] TrueBrain opened pull request #19: Update: dependencies update https://git.io/JU7kH 11:45:24 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain opened pull request #13: Update: dependencies update https://git.io/JU7kx 11:45:40 <TrueBrain> I guess if pyup doesn't want to do it, I have to, or something 11:47:24 *** andythenorth has joined #openttd 11:51:43 <DorpsGek_III> [OpenTTD/nml] LordAro updated pull request #103: Blacken & Flake8 nml https://git.io/JfIhy 11:51:46 <LordAro> that was a bit of effort 11:52:34 <DorpsGek_III> [OpenTTD/master-server] LordAro approved pull request #19: Update: dependencies update https://git.io/JU7IE 11:53:26 <DorpsGek_III> [OpenTTD/master-server-web] LordAro approved pull request #13: Update: dependencies update https://git.io/JU7IK 11:53:30 <LordAro> and apparently i missed one 11:53:31 <LordAro> hmm. 11:55:30 <LordAro> in fact, it's a false positive 11:58:08 <LordAro> kinda 11:58:11 <DorpsGek_III> [OpenTTD/nml] LordAro updated pull request #103: Blacken & Flake8 nml https://git.io/JfIhy 11:58:57 <DorpsGek_III> [OpenTTD/master-server] TrueBrain merged pull request #19: Update: dependencies update https://git.io/JU7kH 11:59:05 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain merged pull request #13: Update: dependencies update https://git.io/JU7kx 11:59:51 <DorpsGek_III> [OpenTTD/eints] TrueBrain created new tag: openttd-github-1.0.5 https://git.io/JU7L8 12:00:20 <DorpsGek_III> [OpenTTD/nml] LordAro merged pull request #145: Tidying grfstrings.handle_string a bit. https://git.io/Jf0hp 12:03:40 <DorpsGek_III> [OpenTTD/nml] LordAro updated pull request #103: Blacken & Flake8 nml https://git.io/JfIhy 12:04:27 <LordAro> Flygon: 12:04:31 <LordAro> er 12:04:34 <LordAro> woops 12:04:47 <LordAro> FLHerne: how goes that cyclic import fixing? 12:06:54 <DorpsGek_III> [OpenTTD/master-server] TrueBrain created new tag: 1.0.6 https://git.io/JU7te 12:07:02 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain created new tag: 1.0.4 https://git.io/JU7tv 12:07:15 <TrueBrain> right, shipped everything I think :) 12:29:34 <DorpsGek_III> [OpenTTD/team] JSanchezFDZ opened issue #34: [es_ES] Translator access request https://git.io/JU7q5 12:32:17 <DorpsGek_III> [OpenTTD/team] LordAro commented on issue #34: [es_ES] Translator access request https://git.io/JU7q5 12:32:44 <DorpsGek_III> [OpenTTD/team] LordAro commented on issue #33: [it_IT] Translator access request https://git.io/JU7fc 12:33:03 <DorpsGek_III> [OpenTTD/team] LordAro commented on issue #32: [hr_HR] Translator access request https://git.io/JU7fZ 12:55:48 <Flygon> Aw 12:55:55 <Flygon> I got so excited for a moment there too. 12:56:03 <Flygon> I still love you LordAro. <3~ 12:56:09 <LordAro> Flygon: sorry :p 12:56:18 <Flygon> It's fine. :P 12:56:25 <LordAro> you're quite welcome to try fixing the python cyclic import issue as well, if you like 12:56:45 <Flygon> The last time I coded something, I somehow caused a flamewar about how Nested Loops should function. 12:56:50 <Flygon> I probably shouldn't, sorry. :P 12:57:00 <LordAro> haha 12:59:54 *** glx has joined #openttd 12:59:55 *** ChanServ sets mode: +v glx 13:15:41 <LordAro> def __lt__(self, other): if not isinstance(other, Change): return False .... 13:15:45 <LordAro> seems oddly defensive, no? 13:34:42 <TrueBrain> pretty common, not? 13:35:28 <LordAro> yeah, i've changed my mind since :p 13:36:22 *** Flygon has quit IRC 13:37:05 *** Flygon has joined #openttd 13:46:22 <DorpsGek_III> [OpenTTD/eints] LordAro opened pull request #22: Fix various issues pointed out by CodeQL https://git.io/JU7ZK 13:51:12 <DorpsGek_III> [OpenTTD/eints] TrueBrain commented on pull request #22: Fix various issues pointed out by CodeQL https://git.io/JU7Zj 13:51:37 <DorpsGek_III> [OpenTTD/eints] LordAro updated pull request #22: Fix various issues pointed out by CodeQL https://git.io/JU7ZK 13:52:33 <DorpsGek_III> [OpenTTD/eints] TrueBrain commented on pull request #22: Fix various issues pointed out by CodeQL https://git.io/JU7nI 13:53:01 <DorpsGek_III> [OpenTTD/eints] LordAro commented on pull request #22: Fix various issues pointed out by CodeQL https://git.io/JU7nt 13:53:37 <DorpsGek_III> [OpenTTD/eints] LordAro commented on pull request #22: Fix various issues pointed out by CodeQL https://git.io/JU7n3 13:54:11 <DorpsGek_III> [OpenTTD/eints] LordAro updated pull request #22: Fix various issues pointed out by CodeQL https://git.io/JU7ZK 13:54:22 <TrueBrain> LordAro: honestly, I am considering making the "click.py" into a small pip package .. 13:54:33 <TrueBrain> it is super-handy, and it is copied in ALL Python projects we have atm :P 13:54:38 <LordAro> heh 13:54:39 <TrueBrain> I might do that tomorrow :) 13:54:49 <TrueBrain> never made a pip package before :D 13:54:59 <LordAro> you can copy NML! 13:55:41 <DorpsGek_III> [OpenTTD/eints] TrueBrain commented on pull request #22: Fix various issues pointed out by CodeQL https://git.io/JU7nW 13:55:50 <TrueBrain> I think I am going to try it without setup.py 13:55:53 <TrueBrain> seems to be the new thing 13:55:57 <TrueBrain> so might as well 13:57:49 <TrueBrain> a return after an abort .. I see here the same weird use of "abort" creeped in 13:57:53 <TrueBrain> creep'd? 13:58:03 <LordAro> yeah, redirect is the same 13:58:19 <TrueBrain> and they don't even mean "abort" I guess, more "error" 13:58:19 <LordAro> i just left it as is for simplicity 13:58:31 <TrueBrain> yeah, lets not try to fix everything weird in eints :D 13:58:39 <TrueBrain> bottle is one hell of a weird library 13:58:48 <LordAro> aiohttp when? :p 13:59:15 <TrueBrain> we now have a mix of aiohttp and flask :) 13:59:29 <TrueBrain> guess flask -> aiohttp would be the first to tackle here :) 13:59:36 <TrueBrain> (in other projects, not in eints) 13:59:43 <TrueBrain> flask is a single-threaded server atm, in production 13:59:52 <TrueBrain> but aiohttp maturity is not there yet, tbh 14:00:20 <LordAro> no? seems to work well enough for all usages i've seen it in 14:00:47 <TrueBrain> there are odd problems not resolved yet last I checked 14:00:51 <TrueBrain> like when a socket closes unexpected 14:01:01 <TrueBrain> but bananas-api runs it, and no production issues so far 14:01:47 <TrueBrain> lol, TIL total_ordering is a thing :) 14:03:11 <LordAro> my thought process was "this is python, there must be a builtin way of specifying the 4 other operators" 14:03:22 <LordAro> it's even mentioned in the CodeQL warning :p 14:03:37 <DorpsGek_III> [OpenTTD/eints] TrueBrain requested changes for pull request #22: Fix various issues pointed out by CodeQL https://git.io/JU7n6 14:03:45 <TrueBrain> CodeQL is nice :) 14:03:54 <TrueBrain> found one nitpick :) 14:03:57 <TrueBrain> rest looks good 14:04:36 <LordAro> hmm, 40 fixes implies that there's 9 unfixed things 14:04:45 <TrueBrain> you can view those if you like 14:04:53 <TrueBrain> https://github.com/OpenTTD/eints/security/code-scanning 14:04:57 <TrueBrain> it shows on the top now 14:05:00 <TrueBrain> 6 alerts open on that PR 14:05:10 <LordAro> so it can 14:06:30 <TrueBrain> it is not that bad, the amount of alerts for eints 14:06:54 <TrueBrain> after you ignored bottle, ofc :) 14:07:42 <LordAro> https://github.com/OpenTTD/eints/security/code-scanning/14?query=ref%3Arefs%2Fpull%2F22%2Fhead this one is odd 14:07:58 <LordAro> i have to question why that code block is there if it's not necessary... 14:08:10 <LordAro> or actually, how a KeyError can be raised at all... 14:10:32 <TrueBrain> and this is why you need to add a comment if you do these kind of exception ignoring :P 14:10:40 <TrueBrain> as I am also clueless if that would ever do anything :D 14:10:59 <LordAro> i'm going to go ahead and remove it ¯\_(ツ)_/¯ 14:11:09 <TrueBrain> possibly a KeyError is thrown if it already exists or something? 14:11:24 <TrueBrain> honestly, leave it for now 14:11:39 <TrueBrain> frosch123: are we dropping redmine support in eints on GitHub? 14:12:11 <TrueBrain> LordAro: the issue with changing this kind of code, is that you cannot test it .. so removing it might make it non-workable .. :P 14:12:35 <LordAro> well someone would find out when they tried to use it again :p 14:12:47 <LordAro> it's not like an issue that would only reappear a week after they started using it 14:13:44 <TrueBrain> that doesn't sound like a good plan of action :) 14:14:05 <TrueBrain> better add a comment # XXX -- we have no clue why this is here. If you ever test this, can you remove it? :P 14:14:48 <TrueBrain> or .. we can check the history on that file? 14:15:22 <TrueBrain> added in 1 commit 14:15:23 <TrueBrain> bah :P 14:15:29 <LordAro> yup :p 14:16:56 <TrueBrain> okay, another way to figure out if this is needed .. 14:16:58 <glx> add a log line to see how often it happens 14:16:59 <TrueBrain> https://github.com/search?q=%22SET+search_path+TO+%22+extension%3Apy&type=Code&ref=advsearch&l=&l= 14:17:07 <TrueBrain> glx: we don't execute that code, so never 14:18:39 <LordAro> https://github.com/psycopg/psycopg2/blob/dc007e790a531cd2466f5c0bc1a6c8ee51097b5a/psycopg/cursor_type.c#L182 hmm 14:19:08 <FLHerne> LordAro: I'm not really sure of the right way to do it :-/ 14:19:11 *** snail_UES_ has joined #openttd 14:20:00 <TrueBrain> LordAro: yeah, but that would never happen in our case; and nobody else is doing any KeyError check for this kind of code .. 14:20:06 <TrueBrain> so yeah, okay, I think it is safe to drop it :P 14:20:16 <LordAro> indeed 14:20:19 <TrueBrain> "if db_schema is not None and db_schema != "":" <- hihi 14:20:23 <TrueBrain> "if db_schema:" 14:20:25 <TrueBrain> works better :P 14:20:26 <frosch123> TrueBrain: bottle and flask are different. iirc flask's abort/redirect throws, while bottle's does not 14:20:41 <FLHerne> I think the right solution is probably to make all/most of the Operators subclasses of BinOp, but that's another big change 14:20:43 <TrueBrain> frosch123: then that code would be broken .. hmm .. lets check 14:21:01 <TrueBrain> raise HTTPError(code, text) 14:21:04 <TrueBrain> frosch123: bottle raises too 14:21:05 <DorpsGek_III> [OpenTTD/eints] LordAro updated pull request #22: Fix various issues pointed out by CodeQL https://git.io/JU7ZK 14:21:29 <TrueBrain> frosch123: redirect is different: flask returns, bottle raises 14:22:13 <frosch123> oh, the other way around :p 14:22:20 <frosch123> well, confusing in any case 14:22:26 <TrueBrain> :D Yup, confusing it is! 14:23:50 <DorpsGek_III> [OpenTTD/eints] LordAro updated pull request #22: Fix various issues pointed out by CodeQL https://git.io/JU7ZK 14:24:58 <TrueBrain> LordAro: why the change in indentation for pages/login.py:43? 14:25:11 <TrueBrain> owh, nevermind 14:25:13 <TrueBrain> lol 14:25:15 <TrueBrain> willy function is silly 14:25:22 <LordAro> TrueBrain: yah, return value 14:25:26 <LordAro> was unnecessary in the else 14:25:30 <LordAro> so i moved it :) 14:25:51 <TrueBrain> that function reads really weird, with some raising exceptions, others returning values :D 14:26:03 <TrueBrain> (not your fault or something to fix) 14:27:16 <DorpsGek_III> [OpenTTD/eints] TrueBrain commented on pull request #22: Fix various issues pointed out by CodeQL https://git.io/JU7Ch 14:29:28 <LordAro> TrueBrain: i'm reasonably certain that the read is unnecessasry 14:29:29 <LordAro> but eh. 14:29:43 <TrueBrain> I would love to believe you 14:29:48 <TrueBrain> but that would mean you have to test the script :P 14:30:02 <LordAro> just replace urllib with requests :p 14:30:05 <TrueBrain> not a big fan of YOLOing these things :) 14:30:15 <TrueBrain> (as it will be WEEKS before anyone notices it) 14:30:31 <TrueBrain> replace bottle with aiohttp, replace urllib with requests .. you have a big list of things to do :P 14:30:35 <TrueBrain> :D 14:30:52 <DorpsGek_III> [OpenTTD/eints] LordAro updated pull request #22: Fix various issues pointed out by CodeQL https://git.io/JU7ZK 14:31:00 <LordAro> D: 14:31:28 <TrueBrain> now at least we know for sure nothing goes BOOM because of this PR ;) 14:31:59 <TrueBrain> did you btw start eints after your changes, just to see if the Python code loads etc? 14:32:31 <LordAro> i feel like you want me to say yes 14:32:33 <LordAro> :p 14:32:40 <TrueBrain> I feel like you didn't, and should ;) 14:32:51 <TrueBrain> "make run" is easy ;) 14:33:24 <DorpsGek_III> [OpenTTD/nml] glx22 updated pull request #164: Fix: Remove trailing whitespaces in NFO output https://git.io/JUQLZ 14:33:36 <DorpsGek_III> [OpenTTD/eints] TrueBrain approved pull request #22: Fix various issues pointed out by CodeQL https://git.io/JU7Wu 14:34:10 <LordAro> TrueBrain: it seems to start with an empty data dir and empty rights.dat file :) 14:34:24 <TrueBrain> good :) 14:34:56 <TrueBrain> in my experience, these kind of changes tend to fail in simple: does it start ... from experience of doing the other repositories :P 14:35:08 <TrueBrain> and we are lacking a good test for that 14:35:13 <TrueBrain> (in most repositories) 14:35:25 <TrueBrain> bananas-api is the only one with a regression-test, I believe :) 14:35:47 <DorpsGek_III> [OpenTTD/nml] LordAro commented on pull request #164: Fix: Remove trailing whitespaces in NFO output https://git.io/JU7WP 14:37:42 <DorpsGek_III> [OpenTTD/nml] glx22 commented on pull request #164: Fix: Remove trailing whitespaces in NFO output https://git.io/JU7Wb 14:38:49 <DorpsGek_III> [OpenTTD/nml] LordAro commented on pull request #164: Fix: Remove trailing whitespaces in NFO output https://git.io/JU7lU 14:41:17 <DorpsGek_III> [OpenTTD/nml] LordAro approved pull request #155: Add: Support for parameters in switches https://git.io/JU7ls 14:41:50 <DorpsGek_III> [OpenTTD/nml] glx22 updated pull request #164: Fix: Remove trailing whitespaces in NFO output https://git.io/JUQLZ 14:42:05 <TrueBrain> LordAro: CodeQL says no alerts now :o nice :D 14:42:05 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] LordAro approved pull request #14: Fix: Check ObjC files as other source files https://git.io/JU7lZ 14:42:13 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] LordAro merged pull request #14: Fix: Check ObjC files as other source files https://git.io/JUQfg 14:42:25 <DorpsGek_III> [OpenTTD/eints] LordAro merged pull request #22: Fix various issues pointed out by CodeQL https://git.io/JU7ZK 14:42:27 <LordAro> TrueBrain: nice. 14:42:41 <TrueBrain> oeh, it even shows the CodeQL things inline in the PR 14:42:42 <TrueBrain> nice 14:43:09 <LordAro> TrueBrain: i'll let you do the openttd-github branch fiddling 14:43:28 <LordAro> https://github.com/OpenTTD/eints/security/code-scanning/80?query=ref%3Arefs%2Fheads%2Fopenttd-github there's this one too 14:43:56 <TrueBrain> feel free to rebase openttd-github and force push 14:44:02 <TrueBrain> if possible, with that error fixed :P 14:44:09 <LordAro> :+1: 14:44:34 <TrueBrain> it is a bit of an ugly way we are doing this atm btw :) 14:44:42 <TrueBrain> nobody really reviews the commits in openttd-github 14:44:57 <TrueBrain> commits => changes 14:45:11 <LordAro> mm 14:45:12 <TrueBrain> not sure we can make that a bit better 14:45:31 <LordAro> could have PRs for syncing the branches 14:45:40 <LordAro> with merge commits and everything 14:45:42 <LordAro> but idk 14:45:50 <TrueBrain> that is the issue, it will be littered with merge commits 14:46:35 <TrueBrain> guess the more fundamental question is, will the eints version from GitHub ever be used for anything else in the (not so near) future :D 14:47:36 <TrueBrain> anyway, I can sync openttd-github branch after dinner LordAro , if you haven't already :) 14:47:46 <LordAro> nearly there 14:48:56 <TrueBrain> that's what she said 14:51:22 <LordAro> done 14:51:26 <TrueBrain> the openttd-ldap branch will still throw errors, I guess :P We haven't rebased that in ... months 14:51:27 <TrueBrain> Feb 2019 14:52:04 <LordAro> i should be able to retrieve the old commit hash from my fork if i've broken everything :p 14:52:30 <TrueBrain> nah, it looks good 14:52:39 <DorpsGek_III> [OpenTTD/nml] LordAro approved pull request #164: Fix: Remove trailing whitespaces in NFO output https://git.io/JU78Y 14:52:52 <DorpsGek_III> [OpenTTD/nml] LordAro merged pull request #164: Fix: Remove trailing whitespaces in NFO output https://git.io/JUQLZ 14:53:10 <TrueBrain> owh, openttd-ldap is not scanned 14:53:13 <TrueBrain> sweet, so not an issue :) 14:53:27 <LordAro> only becomes an issue if anyone ever updates it :p 14:53:42 <TrueBrain> which is very unlikely to ever happen again :) 14:54:42 <LordAro> glx: re nml#78, you removed the commits that were causing all the slowness, right? 14:55:08 <glx> need to check, was a long time ago 14:55:26 <LordAro> Yexo approved it, so presumably so 14:55:50 <LordAro> @seen Yexo 14:55:50 <DorpsGek> LordAro: Yexo was last seen in #openttd 16 weeks, 4 days, 18 hours, 16 minutes, and 3 seconds ago: <Yexo> Oh well, not worth spending more time on, still interesting 14:56:10 <TrueBrain> that does some up #openttd tbh :P 14:56:18 <LordAro> i was thinking the same :p 14:56:21 <TrueBrain> :D :D 14:56:34 <LordAro> glx: might as well rebase it while you're at it anyway 14:56:59 <LordAro> certainly can't see any loops anymore 14:57:01 <TrueBrain> https://translator.staging.openttd.org/ <- LordAro still works, so \o/ 14:57:08 <LordAro> huzzah 14:57:15 <glx> yeah I'm rebasing #155 now, will do #78 after 14:57:42 <DorpsGek_III> [OpenTTD/eints] TrueBrain created new tag: openttd-github-1.0.6 https://git.io/JU781 14:57:45 <TrueBrain> lets push it to production, why not 14:57:59 <FLHerne> LordAro: I need to finish RL stuff now (right now my housemate and I can't get to the fridge because there's a half-built canoe blocking it) 14:58:10 <FLHerne> But I'll fix my PR later 14:58:17 <TrueBrain> sounds like a TERRIBLE place to build a canoe 14:58:42 <FLHerne> Well, it was outside, but it's raining and forecast to do so all week 14:58:58 <FLHerne> And I can't put it where I was going to inside, because there's stuff in the way 14:59:04 <TrueBrain> :D 14:59:16 <TrueBrain> sounds more important than NML for sure :) 14:59:35 <FLHerne> So it's like one of those 15-piece puzzles, and the empty square is currently not the kitchen :p 15:00:56 <TrueBrain> LordAro: 2 alerts left in the openttd-github branch 15:01:10 <LordAro> oh no 15:01:13 <TrueBrain> seems CodeQL doesn't know about delayed imports 15:01:50 <LordAro> yeah 15:01:57 <TrueBrain> second one I don't really understand 15:02:12 <TrueBrain> owh, no, they are the same 15:02:13 <TrueBrain> lol 15:02:15 <LordAro> isn't it just the same issue?> 15:02:23 <TrueBrain> going to ignore them both honestly 15:02:26 <TrueBrain> it is not the pretiest 15:02:27 <TrueBrain> but .. 15:02:48 <TrueBrain> there, 0 alerts 15:03:19 <andythenorth> hmm can I CodeQL this? https://github.com/andythenorth/iron-horse/tree/master/src 15:03:20 <LordAro> fixing the warnings by disabling the warnings 15:03:22 * andythenorth looks 15:03:23 <LordAro> excellent. 15:03:38 <LordAro> andythenorth: should be able to 15:03:45 <LordAro> though adding flake first might be easier 15:05:08 <andythenorth> I'm just curious how far I've diverged from anything considered 'good' 15:05:25 <andythenorth> I use pyflakes and auto-pep8 sometimes, but not systematically 15:05:39 <andythenorth> and I PEP8 troubles me also 15:05:48 <LordAro> andythenorth: https://github.com/OpenTTD/eints/blob/master/.github/workflows/testing.yml copy this, and remove the docker & black (probably) sections 15:06:11 <andythenorth> o_O 15:06:17 <andythenorth> how interesting 15:06:20 <LordAro> i think there's some settings you have to hit on GH itself - TrueBrain knows about them 15:06:37 <LordAro> andythenorth: oh, and change the path that flake8 is using 15:06:49 <andythenorth> oh yes 15:06:53 <andythenorth> hmm 15:07:17 <andythenorth> I was playing warcraft 1 on fastest speed, and now my brain is all out of time 15:07:25 <andythenorth> everything seems weirdly speeded up 15:08:26 <TrueBrain> No other settings needed. Just that file in the right place :) 15:08:48 <LordAro> TrueBrain: so, merging my Actions CI PR 15:08:59 <LordAro> i think you said there's something i need to disable? 15:10:53 *** HerzogDeXtEr has joined #openttd 15:13:20 <TrueBrain> To merge it you have to change which checks are mandatory 15:13:33 <TrueBrain> In the branch protection 15:14:23 <LordAro> aha 15:14:50 *** Wormnest has joined #openttd 15:15:03 <LordAro> do the new ones need enabling? (after it's been merged) 15:15:35 <glx> new ones need to be required yes 15:15:40 <glx> else CI is useless ;) 15:15:54 <LordAro> :) 15:16:03 <TrueBrain> And no need to do it after, just before is fine too 15:17:15 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #8323: Add GH Actions CI workflow https://git.io/JUMIi 15:17:18 <LordAro> \o/ 15:17:26 <glx> and now all PRs need a rebase :) 15:17:31 <LordAro> huzzah! 15:18:38 <TrueBrain> Gratz!! 15:21:41 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro opened pull request #8324: Add problem matchers to CI https://git.io/JU7RJ 15:26:18 <LordAro> oh, that's not good 15:26:24 <LordAro> why has vcpkg failed? 15:26:25 *** HerzogDeXtEr has quit IRC 15:27:24 <LordAro> ...because repo.msys2.org appear to be down 15:27:28 <LordAro> how excellent. 15:27:40 <glx> yup timeout 15:29:16 <LordAro> doesn't look like there's a "rerun CI" button anywhere either 15:29:47 <glx> there's a rerun failed checks 15:29:53 <glx> once all are finished 15:30:13 <LordAro> ah yes, it's there now 15:32:13 <LordAro> https://github.com/OpenTTD/OpenTTD/pull/8324/files well the non-windows stuff works anyway 15:32:19 <LordAro> and shows up all the warnings from the OSX build :p 15:32:59 <glx> indeed 15:33:41 <glx> having them displayed in all PRs will maybe let someone decide to fix them :) 15:34:06 <LordAro> a couple of them are relatively doable 15:34:12 <LordAro> have no idea about this Gestalt stuff though 15:40:46 <DorpsGek_III> [OpenTTD/nml] glx22 dismissed a review for pull request #155: Add: Support for parameters in switches https://git.io/JU7ls 15:40:46 <DorpsGek_III> [OpenTTD/nml] glx22 updated pull request #155: Add: Support for parameters in switches https://git.io/Jfidi 15:42:24 *** snail_UES_ has quit IRC 15:42:58 <TrueBrain> So add the MSVC already 15:43:09 <TrueBrain> Of the same dude, predictable repo 15:43:25 <DorpsGek_III> [OpenTTD/nml] LordAro approved pull request #155: Add: Support for parameters in switches https://git.io/JU70j 15:43:35 <LordAro> TrueBrain: look closer 15:43:59 <TrueBrain> So why isn't it working? :p 15:44:18 <LordAro> external issues 15:44:24 <TrueBrain> Pfffft 15:44:31 <TrueBrain> Laaaammmmeeeee 15:46:55 *** innocenat_ has quit IRC 15:49:45 *** innocenat_ has joined #openttd 15:51:38 <DorpsGek_III> [OpenTTD/nml] glx22 merged pull request #155: Add: Support for parameters in switches https://git.io/Jfidi 15:55:50 <DorpsGek_III> [OpenTTD/nml] LordAro updated pull request #103: Blacken & Flake8 nml https://git.io/JfIhy 15:57:13 <DorpsGek_III> [OpenTTD/nml] glx22 dismissed a review for pull request #78: Add: optimise switches https://git.io/Jfy6B 15:57:14 <DorpsGek_III> [OpenTTD/nml] glx22 updated pull request #78: Add: optimise switches https://git.io/Jed1S 16:01:15 <DorpsGek_III> [OpenTTD/nml] LordAro commented on pull request #28: Fix: Allow access to towns as parent object https://git.io/JU7uA 16:01:15 <DorpsGek_III> [OpenTTD/nml] LordAro closed pull request #28: Fix: Allow access to towns as parent object https://git.io/fjtDy 16:02:37 <glx> oups forgot to check regression before pushing 16:02:54 *** Flygon has quit IRC 16:10:32 <FLHerne> So it fits, just about -- back to NML :P http://www.flherne.uk/files/IMG_20201003_170548.jpg 16:10:55 <TrueBrain> Hahaha 16:10:59 <TrueBrain> Impressive 16:14:55 <glx> ok optimising doesn't work well with the recent NML additions 16:17:31 <glx> nfo seems correct, but looks so unoptimised 16:20:50 <TrueBrain> Sure it is new? :p 16:21:17 <glx> well it inlined the content of a procedure 16:22:10 <glx> and kept the procedure code too 16:23:06 *** gelignite has joined #openttd 16:35:01 <TrueBrain> "Just in case" 16:35:03 <TrueBrain> :D 17:51:40 *** snail_UES_ has joined #openttd 17:51:52 <DorpsGek_III> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/JU7Pk 17:51:52 <DorpsGek_III> - Update: Translations from eints (by translators) 17:54:29 <DorpsGek_III> [OpenTTD/nml] glx22 updated pull request #78: Add: optimise switches https://git.io/Jed1S 17:56:27 <andythenorth> hmm 17:57:10 <andythenorth> what's the best format for uploading to Bananas? 17:57:19 <andythenorth> individual files? tar? zip? 17:57:34 <andythenorth> currently Horse makefile produces a tar which bananas can't accept 17:58:00 <frosch123> i though it does 17:58:25 <andythenorth> it contains license.txt 17:58:34 <andythenorth> which is needed when I distribute the tar manually 17:58:43 <andythenorth> I might need a bananas specific target 17:58:46 <frosch123> ah yes, my work around was: upload tar, delete license via the gui 18:00:55 <andythenorth> least work is just to manually upload required files I think 18:02:44 *** b_jonas has quit IRC 18:07:50 <DorpsGek_III> [OpenTTD/OpenTTD] Cin316 commented on issue #8300: Low framerate on macOS https://git.io/JUqTu 18:08:48 <andythenorth> I can drop license.txt easily enough 18:08:58 <andythenorth> but if I accidentally distribute that it's a GPL variation 18:09:09 <andythenorth> and Ill probably forget 18:09:28 <andythenorth> I'll * 18:34:20 <andythenorth> this is curious 18:34:32 <andythenorth> I've made a tar which bananas will accept 18:34:36 <andythenorth> but it won't parse the files in it 18:40:24 <andythenorth> frosch123 what did I break now? :) grf.farm/misc/bananas-dist-iron-horse-2.8.0-beta-1-15-g88a888fc.tar 18:41:22 <DorpsGek_III> [OpenTTD/bananas-server] TrueBrain opened pull request #34: Fix: don't report SocketClosed when sending https://git.io/JU7DZ 18:41:50 <TrueBrain> I love sentry for reporting useful errors :D 18:41:53 *** Gustavo6046 has quit IRC 18:43:24 <TrueBrain> andythenorth: folder in a folder in a folder in a folder 18:43:30 <TrueBrain> I hear you like nesting :) 18:44:02 <TrueBrain> but this is obvious after upload, not? 18:44:24 <andythenorth> oh that's interesting 18:44:30 * andythenorth wonders why it does that 18:44:48 <TrueBrain> https://pasteboard.co/JtYfZ6I.png 18:44:52 <TrueBrain> I mean .. that was easy to spot :P 18:44:53 *** Gustavo6046 has joined #openttd 18:45:04 <TrueBrain> tar tvf bananas-dist-iron-horse-2.8.0-beta-1-15-g88a888fc.tar 18:45:04 <TrueBrain> iron-horse-2.8.0-beta-1-15-g88a888fc/iron-horse-2.8.0-beta-1-15-g88a888fc/iron-horse.grf 18:45:05 <TrueBrain> .. 18:45:16 <andythenorth> ok 18:45:27 <TrueBrain> the upload does what it should: preserve folders .. well, it removes the first, because that is a very common mistake 18:45:31 <andythenorth> I wonder why the tar was made to do that 18:45:36 <TrueBrain> it does not remove multiple, because .. it has to stop somewhere :) 18:45:53 <andythenorth> there was probably a reason 18:46:19 <andythenorth> I guess I have to learn how this works 18:46:49 <andythenorth> what makes tars? 18:46:55 * andythenorth will go look 18:47:30 <andythenorth> bin/mk-archive 18:47:32 <andythenorth> hmm 18:47:41 <TrueBrain> it is your code; I don't know who made you that tar :) 18:48:16 <TrueBrain> the tar is unlikely to be accepted by OpenTTD too btw :P 18:48:36 <andythenorth> I guess people have just been unpacking it manually 18:48:37 <TrueBrain> well, the grf might, but the .txt files not :D 18:48:45 <andythenorth> nobody reported it broken when I distributed in forums 18:48:58 <andythenorth> now to learn what this does .... https://github.com/andythenorth/iron-horse/blob/master/bin/mk-archive 18:49:32 <andythenorth> L10-11 look relevant 18:51:36 <TrueBrain> enable verbose, and you can see what it is doing? 18:53:17 <TrueBrain> I do not understand most of that code, so I cannot help you with that :) 19:04:27 * andythenorth read the docstrings 19:06:20 <andythenorth> seems to work 19:14:18 <TrueBrain> good :) 19:48:50 *** HerzogDeXtEr has joined #openttd 19:59:29 <TrueBrain> frosch123 / LordAro : would you mind approving https://git.io/JU7DZ ? Would like to have this fixed on production ASAP :D 20:01:32 <DorpsGek_III> [OpenTTD/bananas-server] LordAro approved pull request #34: Fix: don't report SocketClosed when sending https://git.io/JU77Z 20:01:42 <TrueBrain> ty! 20:01:51 <DorpsGek_III> [OpenTTD/bananas-server] TrueBrain merged pull request #34: Fix: don't report SocketClosed when sending https://git.io/JU7DZ 20:03:05 *** iSoSyS has joined #openttd 20:10:27 <DorpsGek_III> [OpenTTD/bananas-server] TrueBrain created new tag: 1.0.13 https://git.io/JU75T 20:54:18 *** andythenorth has quit IRC 20:56:50 *** snail_UES_ has quit IRC 21:00:54 *** frosch123 has quit IRC 21:08:01 *** Afdal has joined #openttd 21:08:24 <Afdal> Can I just say I really hate the new Maximum Reliability algorithm 21:08:41 <Afdal> The rule now seems to be that the newer your vehicle the more it sucks 21:10:03 <Afdal> For example, why would I ever upgrade to a Lev2, Lev3, or a Lev4 when they apparently can't beat the reliability of a Lev1 as a rule? 21:10:23 *** Wormnest_ has joined #openttd 21:10:30 <Afdal> Talk about anti-fun :( 21:11:08 <Afdal> At least with the more random older system you could reasonably expect at least -some- top tier vehicles to have really good reliability 21:12:20 <Afdal> In fact even a basic Max reliability of 90% seems incredibly rare now 21:12:29 <Afdal> That is extremely not cool :( 21:13:14 <Afdal> You're giving me yet another reason to learn C++ and finally give OpenTTD a sensible breakdown system 21:13:22 <Afdal> I don't have time for that -_- 21:14:38 *** Wormnest has quit IRC 21:16:30 <Afdal> I actually kind of can't believe more people haven't complained about this change. This is close to game-ruining for me. 21:16:53 <Afdal> 85% reliability is NOT an acceptable end-game reliability 21:20:26 <FLHerne> Afdal: What new algorithm is this? 21:20:46 <Afdal> I'm trying to figure out when this change was made 21:20:52 <FLHerne> I think most serious players have breakdowns disabled anyway 21:20:57 <Afdal> "serious" 21:20:58 <Afdal> for you 21:21:14 <Afdal> I think it's been sometime around 1.0.8 or 1.0.9 maybe 21:21:45 <Afdal> is that a page with links to all the changelogs 21:22:18 <FLHerne> Well, the breakdown mechanics suck, so most people who've been playing OpenTTD long enough to get fed up of it turn it off :p 21:22:30 <FLHerne> (judging empirically by comments over the years) 21:22:42 <FLHerne> I'm not saying that's a good thing... 21:23:16 <Afdal> Seems like 1.9.0 was when this major change was made 21:23:27 <FLHerne> https://github.com/OpenTTD/OpenTTD/blob/master/changelog.txt 21:24:17 <Afdal> oh that's handy 21:24:44 <Afdal> yep it was 1.9.0 21:24:53 <Afdal> Change: Synchronise introduction date and reliability randomness across vehicles with the same base introduction date (#7147) 21:25:14 <FLHerne> I don't see how that change would cause the behaviour you describe 21:25:17 <Afdal> what this does now is ensure that every vehicle in the same class has worse reliability than the previous one 21:25:40 <Afdal> Basically meaning it's always a tradeoff between more speed/power/cargo and your vehicles breaking down more 21:25:46 <FLHerne> https://github.com/OpenTTD/OpenTTD/pull/7147 21:26:17 <Afdal> At least I think this is what's causing this behavior 21:26:28 <FLHerne> It doesn't do that 21:26:39 <Afdal> what else could it be 21:26:41 <FLHerne> Or at least, it's not intended to do that and I can't see how it possibly could 21:27:01 <Afdal> It's definitely real though, I've observed it in many games now and the max. reliability randomizer definitely used to work defferently 21:27:11 <FLHerne> It has the effect that all vehicles introduced *on the same date* have the same random adjustment to reliability 21:27:42 <Afdal> Well that seems like a fine enough change on its own 21:27:44 <Afdal> you're right 21:28:13 <Afdal> Nothing else says "reliability" on this changelog list though I:> 21:28:13 <FLHerne> (which is basically a side-effect of making them all have the same random adjustment to the intro date) 21:29:33 <FLHerne> https://github.com/OpenTTD/OpenTTD/pull/8317 might help a bit, anyway 21:30:42 <Afdal> My preferred change to the breakdown algorithm is to simply allow players to set a %reliability at which breakdowns are impossible 21:31:06 <Afdal> So as long as you keep a vehicle serviced above that %, your train networks can run deterministically :) 21:32:36 <FLHerne> But assuming your servicing is deterministic, that's just 'breakdowns disabled' with added inconvenience :p 21:32:58 <FLHerne> (yes, I know, the entire game is a pointless inconvenience...) 21:33:16 <Afdal> At least it preserves breakdowns as an actual mechanic 21:33:35 <Afdal> anyway that's a different topic 21:33:47 <Afdal> I wanna stay on this new max. reliability algorithm 21:33:56 <Afdal> Could it be related to the nerfing of reset_engines? 21:34:07 <Afdal> (it no longer alters reliabilities randomly) 21:36:57 <Afdal> I'm looking at a huge vehicle list by introduction date and it seems it is very strongly correlated to maximum reliability 21:37:18 <Afdal> So I think it might be related to that change we discussed, even if it doesn't quite describe it 21:37:25 *** sla_ro|master has quit IRC 21:37:49 <FLHerne> I still don't see how 21:38:00 <Afdal> nothing introduced after 2018 for example in this list can get max. reliability above 83% 21:38:02 <FLHerne> Reliability has always been correlated to intro date 21:38:17 <Afdal> No it used to be more randomized 21:38:23 <FLHerne> It starts out terrible, increases over the first few years of model life, then slowly tails off 21:38:29 <Afdal> Ah I see what you mean 21:38:38 <FLHerne> So the most recent vehicles are always unreliable 21:38:45 <Afdal> I mean the maximum reliability -after- it's crept upward to reach its final value 21:39:06 <Afdal> usually takes a couple years to reach its final value 21:39:23 <Afdal> I'm comparing all maximum reliabilities at the year 2100 21:39:35 <Afdal> so no need to worry about that effect 21:40:44 <Afdal> this train designed in 1926 at 90% max reliability is the most reliable in this entire list of ~50 engines 21:55:18 <Afdal> I'm noticing on some newGRFs 21:55:40 <Afdal> the time~max.reliability correlation holds except past a certain range of years 21:55:54 <Afdal> it might be within a 255 year window 21:56:44 <Afdal> like for example something introduced in 1910 might have the best max. reliability among most other vehicles but then something introduced in 1850 has junk reliability 22:01:04 <glx> I think it's related to "model life" property https://newgrf-specs.tt-wiki.net/wiki/Action0/Vehicles 22:01:13 *** gelignite has quit IRC 22:01:42 <Afdal> Yeah I'm testing some different newgrfs and different versions of them and it seems it's a pattern in some and not others 22:02:24 <Afdal> oh but it shouldn't be that 22:02:37 <Afdal> I'm looking at the available vehicles list 22:02:44 <Afdal> not current active vehicles in a given game 22:03:06 <Afdal> I do think it's related to a newGRF option change though 22:06:15 <Afdal> furthermore the pattern seems to change depending on my game start date 22:16:18 <Afdal> maybe not 22:16:23 <Afdal> I dunno, this is really confusing 22:17:05 <Afdal> All I can say is that I've started up multiple games now and played through to find out that I end up with not a single train above 85% from 2000 to 2050 22:17:12 <Afdal> that is an intolerable change 22:18:45 *** HerzogDeXtEr has quit IRC 22:19:31 *** snail_UES_ has joined #openttd 22:24:20 *** nielsm has quit IRC 22:25:24 <TrueBrain> hmm .. CompileFarm for Windows failed because of a timeout 22:25:34 <TrueBrain> vcpkg failed on pkg-config .. 23:10:27 <glx> https://github.com/msys2/MSYS2-packages/issues/2171 23:11:19 <glx> but as it's inside a vcpkg packages it's not very a usable workaround 23:21:16 *** tokai|noir has joined #openttd 23:21:16 *** ChanServ sets mode: +v tokai|noir 23:28:03 *** tokai has quit IRC 23:34:19 <glx> #8324 CI run fails for the same reason 23:38:05 <TrueBrain> Lol .. it is a single server?! 23:38:44 <TrueBrain> Vcpkg uses a mirror that is not a CDN? Damn ... even we don't do that for files .. not for the last 10 years at least 23:39:25 <glx> well it's an msys2 issue