Times are UTC Toggle Colours
00:02:21 *** tokai has joined #openttd 00:02:21 *** ChanServ sets mode: +v tokai 00:25:23 *** sla_ro|master has quit IRC 00:27:31 *** iSoSyS has joined #openttd 00:29:36 *** Flygon has joined #openttd 00:44:06 *** Wormnest has quit IRC 00:58:51 <DorpsGek_III> [OpenTTD/nml] FLHerne opened pull request #169: Builtin functions refactoring https://git.io/JkJYo 01:00:37 <FLHerne> oops, I broke it 01:19:34 <DorpsGek_III> [OpenTTD/nml] FLHerne updated pull request #169: Builtin functions refactoring https://git.io/JkJYo 01:21:14 <DorpsGek_III> [OpenTTD/nml] FLHerne commented on pull request #169: Builtin functions refactoring https://git.io/JkJ3y 01:27:38 *** iSoSyS has quit IRC 01:52:18 <DorpsGek_III> [OpenTTD/nml] glx22 commented on pull request #169: Builtin functions refactoring https://git.io/JkJZg 02:27:18 *** snail_UES_ has joined #openttd 02:48:42 *** m1cr0m4n has joined #openttd 02:49:44 *** m1cr0man has quit IRC 02:59:20 <DorpsGek_III> [OpenTTD/OpenTTD] TinCanTech closed issue #8336: [Game play] Vehicle disasters should always be banner headlines. https://git.io/JTjuk 02:59:20 <DorpsGek_III> [OpenTTD/OpenTTD] TinCanTech commented on issue #8336: [Game play] Vehicle disasters should always be banner headlines. https://git.io/JTjuk 03:45:10 *** D-HUND has joined #openttd 03:48:39 *** debdog has quit IRC 03:49:53 <Eddi|zuHause> anyone understand what this person wants? 03:50:31 <Eddi|zuHause> sounds like he's just confused about the news settings 04:36:00 *** glx has quit IRC 04:54:12 *** Eddi|zuHause2 has joined #openttd 04:56:59 *** Eddi|zuHause has quit IRC 05:45:50 *** HerzogDeXtEr has joined #openttd 06:14:45 *** snail_UES_ has quit IRC 07:24:42 *** tokai|noir has joined #openttd 07:24:43 *** ChanServ sets mode: +v tokai|noir 07:25:55 *** jottyfan has joined #openttd 07:31:39 *** tokai has quit IRC 07:32:48 *** longtomjr has joined #openttd 07:39:34 <longtomjr> Yaay "Improve performance of trains and road vehicles with a continuously updating NewGRF vehicle image." (newest JGR release, he had a look at our server game that were giving issues and did some profiling) 07:50:18 *** jottyfan has quit IRC 08:12:09 *** longtomjr has quit IRC 08:12:32 *** longtomjr has joined #openttd 08:46:33 <TrueBrain> celebrate and give him a big hug! 09:01:43 <longtomjr> Maybe an elbow tap or something 09:02:17 <longtomjr> train ticks went from 20ms to 2ms 09:02:41 <longtomjr> That is an order of magnitude increase. He also added a setting to disable it completely, for folks who's PCs might struggle 09:05:20 <TrueBrain> which is everyone's PC if you add enough trains :P 09:33:10 *** andythenorth has joined #openttd 09:34:35 *** tokai has joined #openttd 09:34:35 *** ChanServ sets mode: +v tokai 09:37:41 *** grossing has quit IRC 09:41:27 *** tokai|noir has quit IRC 09:42:28 *** Eddi|zuHause2 is now known as Eddi|zuHause 09:49:59 *** WormnestAndroid has quit IRC 09:50:12 *** WormnestAndroid has joined #openttd 10:19:31 *** frosch123 has joined #openttd 10:22:25 *** Flygon_ has joined #openttd 10:23:34 *** Flygon has quit IRC 10:25:07 <TrueBrain> today I learnt that a deployment key of Repo A also gives you read access to any public repo on GitHub 10:25:17 <TrueBrain> not what I expected .. I understand why, but I just didn't expect it 10:27:01 <frosch123> "read access to public repo" <- did you mean that, because that should not require any auth? 10:27:20 <LordAro> TrueBrain: https://askubuntu.com/q/1290477/121467 i think you joked about a 32bit 20.04 build in the past - still not possible :p 10:28:07 <TrueBrain> frosch123: it does if you use ssh, of course :) 10:28:24 <TrueBrain> in GitHub you can make deployment keys per repository, which allows read/write access to that repo over SSH 10:28:30 <TrueBrain> which is a very clean way of doing stuff 10:28:37 <TrueBrain> I just expected that deployment key to be bound to that repo 10:28:44 <TrueBrain> but .. it allows access to all public things too 10:29:00 <TrueBrain> which means I can use a deployment key on any repo to clone any other ... which is annoying when you want to debug stuff 10:29:09 <TrueBrain> especially as the audit log is on the deployment key of that repo 10:29:14 <TrueBrain> it is a bit weird .. I get it, but it is a bit weird 10:29:53 <TrueBrain> owh, shit, and now I am the actor of this key 10:30:03 <TrueBrain> let me fix that .. 10:32:19 <frosch123> https://wiki.openttd.org/User:HariSeldon <- pretty funny that mediawiki interprets leading / as reletive link 10:33:36 <TrueBrain> lol ... 10:33:38 <frosch123> but since there are actual relativepath extensions, i guess this is a bug 10:34:00 <TrueBrain> right, I forgot how weird deployment keys on GitHub are 10:34:03 <TrueBrain> they do have an owner 10:34:06 <TrueBrain> but that is not mentioned anywhere 10:34:16 <TrueBrain> wait, it is 10:34:29 <TrueBrain> but WHO adds keys is very important 10:34:43 <TrueBrain> which again, is not something that is clear when adding them .. technically, I get it 10:34:48 <TrueBrain> but .. boy ... 10:35:30 <longtomjr> You can create keys through the API btw, so you can make that part of your infrastructure setup 10:36:17 <TrueBrain> that is one downside of using CDK: I have nothing that can talk to other infrastructures :) 10:36:25 <TrueBrain> so this part is not automated 10:36:37 <TrueBrain> wouldn't hurt to automate it, honestly, as setting up secrets is a boring job :P 10:36:45 <longtomjr> Yep, I am doing that with my terraform setup, to get flux working 10:36:51 <TrueBrain> but every time I work with Deploy Keys, I am confused and annoyed by the implementation 10:37:05 <TrueBrain> every ... single ... time ... 10:37:09 <longtomjr> I mean you can still just do it using a python library 10:37:12 <TrueBrain> so either I am not growing/learning, or it is just weird :P 10:37:24 <TrueBrain> yeah, I could, but that would make it very hard for anyone else to understand, honestly 10:37:53 <TrueBrain> and I like having AWS decoupled from GitHub, honestly 10:38:00 <TrueBrain> if we want to migrate, there are no hardlinks between the two 10:38:04 <TrueBrain> I hope we never want to :P 10:38:53 <TrueBrain> but to terraform GitHub wouldn't be the worst idea 10:39:05 <TrueBrain> or ansible, or chef, or what-ever 10:39:31 <longtomjr> Terraform github is fine for deploy keys I found. 10:39:37 <longtomjr> Have not done much other stuff 10:40:14 <TrueBrain> I would also use it for branch protection, just to sync all those settings 10:40:22 <TrueBrain> they now "should" be in sync :P 10:40:54 <longtomjr> are you using the deploy key as an env var? 10:40:56 <TrueBrain> yippie, now the Deploy Key has the right actor 10:41:16 <TrueBrain> on AWS it is sent to the Python process as a base64 encoded env-variable, yes 10:41:32 <TrueBrain> it is stored as a secret 10:41:45 <TrueBrain> why you ask? 10:41:56 <TrueBrain> right, finally this works \o/ 10:41:58 <longtomjr> Just wondering if you might want to setup some key rotation somehow 10:42:04 <TrueBrain> https://github.com/OpenTTD/wiki-staging-data/commits/master 10:42:04 <TrueBrain> https://wiki.staging.openttd.org/en/ 10:42:17 <TrueBrain> longtomjr: I rotate all keys every 6 months 10:42:21 <TrueBrain> but it is a manual action atm 10:42:39 <TrueBrain> same for IAM access to AWS 10:42:43 <TrueBrain> (from GitHub to AWS) 10:43:05 <TrueBrain> I often like doing it manually, as it allows me to check logs etc for abuse while at it :) 10:43:40 <TrueBrain> frosch123: as can be seen on the URLs above, I switched out your export for some dummy data, so I could test "git push" and "pushes to GitHub should update the wiki" 10:43:41 <longtomjr> Is there a way to get to your own user page 10:43:55 <TrueBrain> "own user page", what do you mean? 10:44:12 <longtomjr> If I want to go to my user page as a user 10:44:20 <TrueBrain> what "user page" do you mean? 10:44:25 <TrueBrain> I am missing context :) 10:45:15 <frosch123> TrueBrain: github already snitched it to me via mail :) 10:45:29 <longtomjr> say I want to go to User:longtomjr to start editing my user page, how does that work on truewiki? 10:45:31 <TrueBrain> frosch123: I assumed as much ;) Someone was reading those emails :D 10:45:39 <TrueBrain> longtomjr: we do not support the User namespace 10:45:51 <TrueBrain> the only usage we have seen on the current wiki, is abuse :P 10:45:55 <frosch123> TrueBrain: i even get them twice :) 10:46:05 <longtomjr> So no plans for user pages? 10:46:07 <TrueBrain> none 10:46:16 <TrueBrain> if anyone can present a use-case, we can talk it over 10:46:21 <TrueBrain> but history has shown people only abuse it :) 10:46:32 <frosch123> longtomjr: every github user can have their own wiki 10:46:46 *** grag[m] has quit IRC 10:46:46 *** joey[m] has quit IRC 10:46:46 *** CornsMcGowan[m] has quit IRC 10:46:46 *** igor[m] has quit IRC 10:46:46 *** magdalena[m] has quit IRC 10:46:46 *** jact[m] has quit IRC 10:46:46 *** ad5twoknebor[m] has quit IRC 10:46:46 *** josef[m]1 has quit IRC 10:46:46 *** christoph[m] has quit IRC 10:46:46 *** karoline[m] has quit IRC 10:46:46 *** johanna[m] has quit IRC 10:46:46 *** menelaos[m] has quit IRC 10:46:46 *** fjodor[m] has quit IRC 10:46:46 *** nolep[m] has quit IRC 10:46:46 *** hamstonkid[m] has quit IRC 10:46:46 *** elliot[m] has quit IRC 10:46:46 *** ircer[m] has quit IRC 10:46:46 *** pothyurf[m] has quit IRC 10:46:46 *** glothit7ok[m] has quit IRC 10:46:46 *** paulus[m] has quit IRC 10:46:46 *** yoltid[m] has quit IRC 10:46:46 *** christoph[m]1 has quit IRC 10:46:47 *** philip[m] has quit IRC 10:46:47 *** einar[m] has quit IRC 10:46:47 *** karl[m] has quit IRC 10:46:47 *** jeeg[m] has quit IRC 10:46:47 *** dude[m]1 has quit IRC 10:46:47 *** ookfof[m] has quit IRC 10:46:47 *** albert[m] has quit IRC 10:46:47 *** shedidthedog[m] has quit IRC 10:46:47 *** blikjeham[m] has quit IRC 10:46:47 *** emeraldsnorlax[m] has quit IRC 10:46:47 *** Aileen[m] has quit IRC 10:46:47 *** natalie[m] has quit IRC 10:46:48 *** leward[m] has quit IRC 10:46:48 *** jeremy[m] has quit IRC 10:46:48 *** natmac[m] has quit IRC 10:46:48 *** phil[m] has quit IRC 10:46:48 *** dekeract[m] has quit IRC 10:46:48 *** freu[m] has quit IRC 10:46:48 *** osvaldo[m] has quit IRC 10:46:48 *** yur3shmukcik[m] has quit IRC 10:46:48 *** khavik[m] has quit IRC 10:46:48 *** yoyo[m] has quit IRC 10:46:48 *** rudolfs[m] has quit IRC 10:46:48 *** Heiki[m] has quit IRC 10:46:48 *** dave[m] has quit IRC 10:46:48 *** twom[m] has quit IRC 10:46:48 *** linda[m] has quit IRC 10:46:48 *** pina[m] has quit IRC 10:46:48 *** amal[m]1 has quit IRC 10:46:48 *** ciet[m] has quit IRC 10:46:48 *** udo[m] has quit IRC 10:46:48 *** fiddeldibu[m] has quit IRC 10:46:48 *** iarp[m] has quit IRC 10:46:48 *** olmvnec[m] has quit IRC 10:46:48 *** labs[m] has quit IRC 10:46:48 *** ist5shreawf[m] has quit IRC 10:46:49 *** julie[m] has quit IRC 10:46:49 *** patrick[m] has quit IRC 10:46:49 *** nartir[m] has quit IRC 10:46:49 *** tonyfinn[m] has quit IRC 10:46:49 *** dag[m] has quit IRC 10:46:49 *** hylshols7qui[m] has quit IRC 10:46:49 *** robert[m] has quit IRC 10:46:49 *** cyberjunkie[m] has quit IRC 10:46:49 *** gretel[m] has quit IRC 10:46:49 *** cawal[m] has quit IRC 10:46:49 *** patricia[m] has quit IRC 10:46:51 <TrueBrain> well, yes, we could setup <yournamehere>.wiki.openttd.org :D 10:47:03 <longtomjr> what just happened 10:47:08 <longtomjr> in irc? 10:47:08 <TrueBrain> but User namespace is a terrible mediawiki idea 10:47:13 <LordAro> matrix just died 10:47:15 <TrueBrain> owh, Matrix being unstable as fuck 10:47:20 <frosch123> you have to decide, is your page personal (use your own wiki), or is is of general interest (put it on ottd wiki) 10:47:21 <reldred> net split 10:47:22 <TrueBrain> people should run their own ... lot less issues :P 10:47:38 <LordAro> "Quit: killed" is not normally a netsplit ;) 10:47:50 <TrueBrain> I would guess an upgrade of the IRC gateway :P 10:47:51 <reldred> loool, I didn't see that on my client 10:48:01 <TrueBrain> too bad, they are ALL connected via ONE gateway, it seems 10:48:25 <frosch123> at least we are back to a normal number of 90 idlers 10:48:30 <TrueBrain> for now 10:48:31 <reldred> well, it's kinda a netsplit, they were all on one server just not the upstream OFTC server :P 10:48:47 <TrueBrain> well, strictly seen, with Matrix, you are not on any server 10:48:58 <TrueBrain> but they connect to IRC via a single gateway :P 10:49:31 *** albert[m] has joined #openttd 10:49:33 <longtomjr> anyways, I can see that there is probably no use for user namespaces. 10:49:57 <longtomjr> How often does the wiki sync with gh 10:50:08 <TrueBrain> 5 minutes after last change, a push is done to GitHub 10:50:17 <longtomjr> Also, the preview does not show newlines for some reason 10:50:35 <TrueBrain> I will add it to my bug-list! 10:51:12 <TrueBrain> possibly I will lower the 5 minute-delay, but that is always part of the experiment :) 10:51:47 <longtomjr> Do you have it flush when the container gets an exit signal? 10:51:48 <TrueBrain> [OpenTTD/wiki-staging-data] DorpsGek pushed 1 commits to master https://git.io/JkJp0 10:51:48 <TrueBrain> - modified: en/More info (by longtomjr) 10:51:54 <TrueBrain> would be what DorpsGek_III would announce, if w ewould enable it 10:52:03 <TrueBrain> longtomjr: on my TODO-list, but no 10:53:12 <longtomjr> Ok 10:54:31 <TrueBrain> so if the server crashes within that 5 minutes, changes will be lost :) 10:54:52 <TrueBrain> (same goes for BaNaNaS, btw) 10:55:28 <TrueBrain> but everything should be guarded, so crashes should never happen :D 10:55:30 <TrueBrain> famous last words :P 10:55:45 <TrueBrain> but okay, this all seems to work \o/ :D 10:55:48 <longtomjr> Hehe, what happens when you deploy a new version? 10:56:05 <TrueBrain> any pending changes will be lost; this is why it is on my TODO to "git push" on SIGHUP :) 10:56:29 <longtomjr> That is what I thought of initially, that is why I asked 10:56:36 <longtomjr> Can you have a sidecar do it? 10:56:38 <TrueBrain> it is just really unlikely to happen :P 10:56:55 <longtomjr> (does docker have sidecars or something similar?) 10:57:02 <TrueBrain> I use ECS, which has sidecars 10:57:30 <longtomjr> Ah ok, that might be the best approach, since then you don't require the main container to be in a healthy state. 10:57:39 <TrueBrain> but similar as with BaNaNaS, the chances of it ever happening are very slim .. as we have very low mutation rate 10:58:05 <TrueBrain> well, that is the thing: do you want to push if your main container is not healthy? :P 10:58:25 *** sla_ro|master has joined #openttd 10:58:52 <longtomjr> Hmm, you might want to push it to a branch and notify someone, and then it can be a manual merge if everything is opk 10:59:11 <TrueBrain> is that worth the effort, is the question :D 10:59:20 <longtomjr> Sounds interesting to do at least 10:59:38 <longtomjr> afk for a bit, need to help getting lunch ready 11:08:24 *** patricia[m] has joined #openttd 11:08:25 *** josef[m] has joined #openttd 11:08:26 *** hylshols7qui[m] has joined #openttd 11:08:27 *** amal[m] has joined #openttd 11:08:28 *** labs[m] has joined #openttd 11:08:28 *** iarp[m] has joined #openttd 11:08:29 *** paulus[m] has joined #openttd 11:08:30 *** julie[m] has joined #openttd 11:08:31 *** christoph[m] has joined #openttd 11:08:32 *** shedidthedog[m] has joined #openttd 11:08:32 *** dude[m] has joined #openttd 11:08:33 *** natmac[m] has joined #openttd 11:08:34 *** hamstonkid[m] has joined #openttd 11:08:35 *** cawal[m] has joined #openttd 11:08:35 *** twom[m] has joined #openttd 11:08:36 *** ircer[m] has joined #openttd 11:08:37 *** rudolfs[m] has joined #openttd 11:08:38 *** fiddeldibu[m] has joined #openttd 11:08:39 *** joey[m] has joined #openttd 11:08:40 *** jact[m] has joined #openttd 11:08:41 *** jeremy[m] has joined #openttd 11:08:41 *** ist5shreawf[m] has joined #openttd 11:08:41 *** tonyfinn[m] has joined #openttd 11:08:42 *** pina[m] has joined #openttd 11:08:43 *** menelaos[m] has joined #openttd 11:08:44 *** udo[m] has joined #openttd 11:08:45 *** yoltid[m] has joined #openttd 11:08:45 *** glothit7ok[m] has joined #openttd 11:08:46 *** khavik[m] has joined #openttd 11:08:47 *** dave[m] has joined #openttd 11:08:48 *** Aileen[m] has joined #openttd 11:08:49 *** natalie[m] has joined #openttd 11:08:49 *** linda[m] has joined #openttd 11:08:50 *** yur3shmukcik[m] has joined #openttd 11:08:51 *** ad5twoknebor[m] has joined #openttd 11:08:52 *** philip[m] has joined #openttd 11:08:53 *** blikjeham[m] has joined #openttd 11:08:53 *** ciet[m] has joined #openttd 11:08:54 *** yoyo[m] has joined #openttd 11:08:55 *** phil[m] has joined #openttd 11:08:56 *** johanna[m] has joined #openttd 11:08:57 *** einar[m] has joined #openttd 11:08:57 *** fjodor[m] has joined #openttd 11:08:57 *** ookfof[m] has joined #openttd 11:08:58 *** pothyurf[m] has joined #openttd 11:08:59 *** olmvnec[m] has joined #openttd 11:09:00 *** gretel[m] has joined #openttd 11:09:00 *** karoline[m] has joined #openttd 11:09:01 *** jeeg[m] has joined #openttd 11:09:02 *** karl[m]1 has joined #openttd 11:09:03 *** dag[m] has joined #openttd 11:09:04 *** igor[m] has joined #openttd 11:09:05 *** christoph[m]1 has joined #openttd 11:09:06 *** grag[m] has joined #openttd 11:09:06 *** leward[m] has joined #openttd 11:09:07 *** freu[m] has joined #openttd 11:09:08 *** patrick[m] has joined #openttd 11:09:09 *** CornsMcGowan[m] has joined #openttd 11:09:10 *** elliot[m] has joined #openttd 11:09:11 *** magdalena[m] has joined #openttd 11:09:11 *** emeraldsnorlax[m] has joined #openttd 11:09:12 *** cyberjunkie[m] has joined #openttd 11:09:13 *** robert[m] has joined #openttd 11:09:14 *** nartir[m] has joined #openttd 11:09:15 *** osvaldo[m] has joined #openttd 11:09:16 *** nolep[m] has joined #openttd 11:09:17 *** Heiki[m] has joined #openttd 11:09:18 *** dekeract[m] has joined #openttd 11:10:50 *** matt21347 has joined #openttd 11:16:59 <andythenorth> it's lunch? 11:17:12 <frosch123> omg... mediawiki actually does ../ links 11:19:37 <andythenorth> ../lunch? 11:21:33 <Eddi|zuHause> ~/lunch? 11:22:32 <andythenorth> > lunch? 11:22:38 <LordAro> C:\Documents and Settings\lunch 11:22:56 <andythenorth> bring back peter1138 11:23:59 <LordAro> mm 11:26:15 <longtomjr> Back from lunch 11:26:27 <longtomjr> it is 13:26 here 11:26:29 <longtomjr> so lunchtime yep 11:41:19 *** grossing has joined #openttd 12:33:15 <DorpsGek_III> [OpenTTD/nml] FLHerne updated pull request #169: Builtin functions refactoring https://git.io/JkJYo 12:33:48 * andythenorth had a snack 12:34:34 * FLHerne pretty much doesn't have any food 12:34:38 <FLHerne> I ate it all :-( 12:35:19 <FLHerne> I have a couple of eggs left, but you can only eat so many eggs in one day 12:35:33 <andythenorth> egg-bound 12:35:38 <andythenorth> there are shops 12:35:40 <andythenorth> I have been in them 12:36:19 <DorpsGek_III> [OpenTTD/nml] FLHerne updated pull request #169: Builtin functions refactoring https://git.io/JkJYo 12:36:20 <FLHerne> Bleh 12:36:36 <FLHerne> Someone™ needs to add this black check to `make test` 12:47:02 * FLHerne hates makefiles 12:47:22 <FLHerne> We have python, why can't we use unittest or pytest or something? 12:51:29 <LordAro> probably 12:56:38 *** nielsm has joined #openttd 13:30:32 *** snail_UES_ has joined #openttd 13:41:20 <TrueBrain> right, all my pre-checks completed .. I think, ignoring the content, the wiki on staging is production-ready ... proof-me-wrong, I would say :D 13:44:30 <frosch123> i forgot... is supporting [[:Foobar]] on your list? 13:44:30 <longtomjr> maybe test it with the production content? 13:44:59 <andythenorth> ship it! 13:46:00 <TrueBrain> frosch123: it is on my list, but not for v1; do you have pages that actively use it? 13:46:19 <frosch123> everything that uses Template:Merge for example 13:46:34 <TrueBrain> longtomjr: we have done that for the last few days I would think :) I guess more interesting now is to test if everything works as expected, like editng, renaming, linking, etc 13:46:36 <frosch123> removing the : would break it for Categories and Files 13:46:48 <TrueBrain> k; let me see if I can fix that for now at least :) 13:47:03 <frosch123> i made the conversion remove it for non-templated links 13:47:28 <TrueBrain> how is [[en/Bla]] different from [[:en/Bla]] for Categories and Files? 13:47:56 <longtomjr> TrueBrain, what is the login timeout? Or am I just getting logged out because you did a new deploy? 13:48:06 <TrueBrain> longtomjr: new deploy logs everyone out 13:48:16 <frosch123> [[:Category:Foobar]] links to the category, [[Category:Foobar]] adds the page to the category? 13:48:29 <TrueBrain> yeah, but that already works 13:48:30 *** iSoSyS has joined #openttd 13:48:35 <TrueBrain> and has been for a while 13:48:56 <frosch123> yes, but Template:merge uses [[:{{{1}}}]] where 1 can be anything 13:49:04 <frosch123> page, category, tempalte, file 13:49:11 <longtomjr> I am going to run through a couple of tests. Is it ok to just post here if I pick something up? 13:49:26 <TrueBrain> ah, okay, it sounded like something else would break frosch123 :) 13:49:28 <TrueBrain> but I gotcha 13:49:42 <TrueBrain> longtomjr: post here, make an issue in the TrueWiki repo, all the same to me 13:49:48 <TrueBrain> just .. don't spam :P 13:49:54 <TrueBrain> use gists or what-ever if it is more than a line :P 13:50:48 <longtomjr> ok, Gonna open issues for things that you might just close as 'wontfix 13:50:51 <longtomjr> if that is ok 13:51:16 <longtomjr> also, you said you have a list, so it might duplicate some things 13:51:39 <TrueBrain> any and all feedback is appreciated, use what-ever channel works best for you :) 13:52:00 <TrueBrain> I will process them no matter what, so it is all good 13:53:29 <DorpsGek_III> [OpenTTD/nml] FLHerne updated pull request #169: Builtin functions refactoring https://git.io/JkJYo 13:53:37 *** iSoSyS has quit IRC 13:56:07 <longtomjr> Am I just blind, or is there no way to upload media? 13:56:24 <TrueBrain> create a page in File/ 13:56:54 <TrueBrain> either by browsing there via the breadcrumbs, or by first making a link to a file 13:57:12 <longtomjr> Found it 14:02:01 <longtomjr> Did some clicking and some editing, nothing else I am picking up, but I have not worked with mediawiki in years, so I might be missing things. 14:04:03 <TrueBrain> tnx :) 14:04:20 <TrueBrain> nobody would admit if they have worked with mediawiki honestly :P 14:04:55 <TrueBrain> and for sure we will miss things, that is normal :D 14:05:12 <TrueBrain> but the more people that try stuff, the less chance it is something HUGE :P 14:05:16 <TrueBrain> so much appreciated :) 14:05:24 <frosch123> i learned various mediawiki "features" from our users :) 14:05:25 <longtomjr> :) 14:06:01 <frosch123> apparently you can install custom css and js in your userpages, and it will use it... 14:06:05 <frosch123> like wtf 14:06:07 <TrueBrain> frosch123: merged [[:en/Bla]] fix; now being deployed to staging 14:06:20 <frosch123> \o/ 14:15:15 <TrueBrain> and moved my TODO to issue-tracker :) 14:20:09 <frosch123> hmm, something broke... check-all finished in 2 minutes, usually it takes 10 on my machine 14:20:33 <frosch123> ah, nvm, user error 14:27:14 <TrueBrain> :D pfew :P 14:27:43 <frosch123> also, the wantedpages thingie only works for pages in the main namespace 14:28:07 <TrueBrain> "wantedpages"? 14:28:18 <DorpsGek_III> [OpenTTD/nml] FLHerne commented on pull request #169: Builtin functions refactoring https://git.io/JkUCo 14:28:33 <frosch123> https://wiki.openttd.org/Special:WantedPages <- the thing i use to filter expected missing pages 14:29:04 <frosch123> but it does not contain Scenario: pages for example 14:29:20 <TrueBrain> .... lol 14:29:24 <TrueBrain> somehow I am not really surprised :P 14:30:46 <frosch123> also, like 4 links on the wiki have duplicate " ", which mediawiki shortens to one :p 14:31:40 <TrueBrain> yeah, I am not doing that crap :P 14:31:52 <frosch123> neither me :p 14:32:01 <frosch123> fixing the source instead 14:32:49 <TrueBrain> \o/ 14:33:59 <TrueBrain> longtomjr: you didn't even upload an image?! Awh :( 14:34:23 <TrueBrain> frosch123: mind reading https://github.com/TrueBrain/TrueWiki/pull/51, if that reflects your reality too? :D 14:34:33 <TrueBrain> https://github.com/TrueBrain/TrueWiki/blob/e6bdde1673b8d38aab2b032fc38fe2b61380f7a5/README.md for easier reading 14:34:53 <frosch123> "opinionated" \o/ 14:35:38 <TrueBrain> well, we are, aren't we? :D 14:35:54 <longtomjr> TrueBrain, I created the image redlink 14:35:57 <TrueBrain> I rather be upfront about that :P 14:36:14 <longtomjr> saw that I could upload, and realised I did not have something to upload 14:36:15 <TrueBrain> longtomjr: I am curious if uploading works, and if you see any problems with it .. if you don't mind testing :) 14:36:21 <longtomjr> Sure 14:36:28 <TrueBrain> https://wiki.openttd.org/File:1-way_signal_loop.png 14:36:29 <longtomjr> will take a screenie 14:36:31 <TrueBrain> here, have a png :) 14:39:00 <longtomjr> "Maximum request body size 1048576 exceeded, actual body size 1051543" 14:39:03 <longtomjr> when clicking preview 14:39:24 <TrueBrain> hmm ... we have a size limit .. cool :D 14:39:33 <TrueBrain> let me get an image big enough to trigger that :P 14:39:40 <longtomjr> 8.3 mb 14:39:56 <TrueBrain> well, that honestly is a bit big, yes :P 14:40:12 <longtomjr> In game screenshot, but 4k monitor 14:40:19 <longtomjr> also, size limit looks like the reverse proxy 14:40:26 <TrueBrain> I believe the current biggest upload is 2MB :P 14:42:17 <longtomjr> It goes from the file I selected, to "no file selected" when I hit preview 14:43:34 <longtomjr> also, the preview does not work 14:43:36 <TrueBrain> read ... the text! 14:43:44 <TrueBrain> I know reading is hard, but come on :P 14:44:03 <longtomjr> Maybe gray out the button? 14:44:25 <longtomjr> I read the first line 14:44:53 <TrueBrain> it is only a problem if you change the file; so greying out the button is not the ideal solution 14:44:58 <TrueBrain> guess we need a bit of Javascript for this honestly 14:45:50 <longtomjr> I think my monkey brain kinda assumed that after the first line, the rest is just gonna be a list of potential compatible licences, or a link to somewhere that explains licences 14:46:08 <longtomjr> maybe a forum post that explains licences would be perfect :P 14:46:11 <TrueBrain> suggestions to improve it are welcome :) 14:46:23 <longtomjr> But yep, I did not read 14:46:55 <TrueBrain> :P 14:47:05 <TrueBrain> Honestly, I knew people wouldn't read that when I wrote it 14:47:21 <TrueBrain> partial because of what you mention: there are 2 things, and if people read 1, that is already something 14:47:24 <TrueBrain> but also because people don't read 14:47:39 <TrueBrain> I think a piece of Javascript that repeats the message when pressing Preview is the best approach here 14:48:38 <longtomjr> Maybe at the top part of `This is a preview` 14:48:44 <longtomjr> say new uploads will not render 14:48:54 <TrueBrain> it is not that they don't render, the upload is lost 14:48:58 <TrueBrain> so that is already too late 14:49:13 <longtomjr> Aah ok 14:49:24 <TrueBrain> (there is no "temporary" storage, basically) 14:49:30 *** glx has joined #openttd 14:49:30 *** ChanServ sets mode: +v glx 14:49:43 <longtomjr> If "has selected file" then "Warn on preview page" 14:50:27 <longtomjr> Do you have to rollback changes via git btw? 14:50:58 <TrueBrain> copy/paste from GitHub history 14:51:13 <longtomjr> Ah ok 14:51:55 <TrueBrain> frosch123: fun fact, nobody can upload a gif :P 14:52:00 <TrueBrain> do we want to support uploading gifs .. 14:52:09 <TrueBrain> (for the migration it doesn't matter btw :P) 14:52:27 <longtomjr> Also also, the picture on the more info page does clip overflow without a scroll bar 14:53:13 <longtomjr> Gifs are useful for illustrating something that might not fit an image, but, 2mb might be a bit small for that 14:54:39 <TrueBrain> tnx frosch123 , added all your comments :D 14:55:02 <TrueBrain> longtomjr: I will fix that in a bit; I was sure I already did, but clearly I did not :) 14:55:28 <frosch123> hmm, no idea idea whether we have any animated gif 14:56:26 <frosch123> we do :p 14:56:28 <andythenorth> we should use some! 14:56:52 <andythenorth> this one is good https://i.imgur.com/Qy7RYKK.gif 14:56:56 <frosch123> https://wiki.openttd.org/File:EGrvts_preview.gif <- cute 14:57:33 <frosch123> https://wiki.openttd.org/File:Presigs.gif <- technically animated, but not sure how useful that acutally is 14:58:16 <frosch123> pff. people added gifs to the junctionary, to show how multiple trains travel through them 15:00:44 <frosch123> 6 animated gifs in total 15:00:51 <TrueBrain> ah, aiohttp limits the request body size, finally found it :) 15:01:02 <frosch123> 7 even 15:01:03 <longtomjr> Yep, that is what I thought it was 15:01:14 <longtomjr> When I saw the message 15:01:48 <longtomjr> how does the uploads work, multipart request? 15:02:53 <TrueBrain> 4MiB limit sufficient? 15:02:55 <TrueBrain> longtomjr: yes 15:03:34 <longtomjr> I would bump the aiohttp limit to like 10 or something, and then limit the file uploads at the file upload coad 15:03:38 <longtomjr> code 15:04:04 <longtomjr> Since this way it will be hard to find where the limit gets set. 15:04:23 <TrueBrain> that is not answering my question really :D 15:04:29 <TrueBrain> biggest file atm is just over 2MiB 15:04:41 <longtomjr> Then 4 is plenty for file uploads yep 15:04:42 <longtomjr> sorry 15:04:45 <TrueBrain> :P 15:05:00 <TrueBrain> for now I am just going to raise the limit in aiohttp; making a pretty error is somethng for v1.1 :) 15:06:02 <TrueBrain> UGH! I sometimes hate Windows .. I was typing text 15:06:05 <TrueBrain> a popup appeared 15:06:09 <TrueBrain> I pressed space, as I was typing text 15:06:12 <TrueBrain> and the popup was gone 15:06:15 <TrueBrain> NO CLUE what was on the popup 15:06:19 <TrueBrain> why ..... do people do that ... 15:06:24 <TrueBrain> don't steal focus ffs 15:06:37 <longtomjr> It asked if you want to forever lock in that windows can update whenever they feel like it 15:07:33 <longtomjr> tbh, that might not have been Windows, it could have been anything that runs in the background 15:08:54 <TrueBrain> but it is Windows that allows it 15:08:58 <TrueBrain> which is more my point 15:09:04 <TrueBrain> I expect my desktop manager to manage those things 15:09:05 <longtomjr> Ah yep 15:09:21 <TrueBrain> I think it was a Discord popup, as Discord is acting up :P 15:11:47 <TrueBrain> right, fixed that images could boom in width (now clamped to max 900px), upload limit, and added GIF support 15:11:52 <TrueBrain> if black wouldn't fail on me :D 15:12:58 <TrueBrain> (and this is the reason I make a Pull Request out of everything ... github-actions validators ftw!) 15:13:27 *** andythenorth has quit IRC 15:13:43 <frosch123> TrueBrain: is there any remote chance error messages could show line numbers or similar? 15:14:06 <TrueBrain> frosch123: -very- difficult 15:14:12 <TrueBrain> because of templates, this information is lost, honestly 15:14:28 <TrueBrain> I have looked into it for a few hours even, but .. I did not see a clean way 15:14:30 <frosch123> ok, i hoped wikitextparser would know it all :) 15:14:40 <TrueBrain> no, wikitextparser knows nothing about templates 15:14:46 <TrueBrain> so we need to do the bookkeeping ourself 15:14:52 <TrueBrain> but internally "lines" have no meaning 15:14:55 <TrueBrain> it is a single bytearray 15:15:00 <TrueBrain> so that bookkeeping is very difficult 15:15:44 <TrueBrain> I have considered building the parsing in a different way, where that would be possible 15:15:49 <TrueBrain> might even make parsing a lot faster 15:15:56 <TrueBrain> but ... I decided to first finish v1 :P 15:16:03 <TrueBrain> so I agree, it would be a very welcome feature 15:17:29 <DorpsGek_III> [OpenTTD/team] achton opened issue #79: [da_DK] Translator access request https://git.io/JkURF 15:18:33 <TrueBrain> frosch123: https://github.com/TrueBrain/TrueWiki/issues/54 , just so we don't forget :D 15:20:04 <TrueBrain> longtomjr: https://wiki.staging.openttd.org/File/en/Big%20File.jpeg uploads up to 4MiB now work :) 15:22:43 <TrueBrain> okay, what else ... :D 15:23:51 <TrueBrain> can't believe we still render < 30ms for simple pages .. :D 15:24:35 <longtomjr> yay 15:25:08 <TrueBrain> good thing about that is, no need to add caching (which only makes the memory usage go up :P) 15:26:09 <TrueBrain> I still think we should prerender the whole site and publish that :P 15:27:13 <longtomjr> Yep, that just makes the view part so easy 15:28:02 <TrueBrain> lets see how long rendering everything currently takes ... 15:30:40 <TrueBrain> 4 minutes 15:30:42 <TrueBrain> okay ... 15:31:55 <TrueBrain> frosch123: "Cell attribute '[[Schleuse' is not a valid attribute" <- what is this new error? :P 15:32:53 <TrueBrain> 14681 deadlinks currently :D 15:32:57 <TrueBrain> pretty sure most are legit 15:33:01 <TrueBrain> that is .. insane :P 15:33:31 <longtomjr> That is crazy 15:33:44 *** andythenorth has joined #openttd 15:33:54 <TrueBrain> but I also cannot believe we can render the full wiki in < 4 minutes .. that is also insane :D 15:35:49 <TrueBrain> I could make that a lambda@edge checks if you have a cookie; if so, you are logged in, send to the live instance. If not, serve from S3 15:36:08 <TrueBrain> hmm ... no, that would be rather expensive 15:36:13 <TrueBrain> a lambda@edge for every visit .. 15:36:15 <TrueBrain> nevermind :) 15:57:05 <frosch123> TrueBrain: already fixed :p 15:57:32 <frosch123> i am currently running the export of the last fixes 15:57:40 <frosch123> then i expect 0 expected errors, let's see 15:57:59 *** Flygon_ has quit IRC 15:59:05 <frosch123> 0 unexpected errors ofc :p 16:03:02 <TrueBrain> Haha 16:20:34 <frosch123> i wonder whether i can enter \u200e into truewiki filenames 16:20:51 <frosch123> people managed that twice on mediawiki, and i do not know how 16:35:59 *** SpeedStick has joined #openttd 16:38:09 *** SpeedStick has quit IRC 16:38:27 *** berndj has quit IRC 16:39:55 *** berndj has joined #openttd 16:40:33 <frosch123> 53 links to Special: left, the rest is fine 16:45:04 <TrueBrain> W00p 16:51:39 *** nielsm has left #openttd 16:51:46 *** nielsm has joined #openttd 17:03:59 *** y2kboy23 has quit IRC 17:04:32 *** y2kboy23 has joined #openttd 17:50:02 *** Progman has joined #openttd 17:51:57 <DorpsGek_III> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/JkU19 17:51:57 <DorpsGek_III> - Update: Translations from eints (by translators) 17:53:51 *** Wolf01 has joined #openttd 17:58:15 <TrueBrain> frosch123: Special:Contributions/<IP> <- people linked to special pages by IP? LOL .. now that is weird :P 17:58:22 <TrueBrain> (I removed the IP, to be clear :P) 17:59:01 <TrueBrain> frosch123: those PAGESINCAT and DISPLAYTITLE you already fixed? 17:59:59 <frosch123> no, i would fix them on the original wiki, be deleting the paragraphs they are in, or similar 18:00:14 <frosch123> but did not bother yet 18:00:24 <TrueBrain> k; I am just happy I do not have to implement that :P 18:00:29 <TrueBrain> I don't want to!! :P 18:00:40 <frosch123> oh, i implemented the DISPLAYTITLE 18:00:48 <frosch123> it can be deleted after the migration 18:01:00 <TrueBrain> it is a rather silly variable tbh :P 18:01:21 <frosch123> it works around mediawiki limitations that truewiki does not have 18:01:24 <frosch123> at least in this case 18:01:41 <TrueBrain> Table attribute '|-' is not a valid attribute <- that is still in your latest export 18:02:03 <frosch123> oh, yet another case... 18:02:35 <frosch123> well, it's in that pl guy stuff 18:02:35 <TrueBrain> people tried to make really weird tables over the years :P 18:02:42 <frosch123> still waiting for an answer, what to migrate 18:03:32 <TrueBrain> I like the ratio of 59 missing templates and 14655 linked pages not found :D 18:03:36 <TrueBrain> that ratio is just amazing :D 18:04:04 <frosch123> missing pages are mostly missing translations 18:04:10 <frosch123> so, they do not mean anything 18:04:46 <TrueBrain> I understand; still .. that number .. it is insane :) 18:05:08 <TrueBrain> https://wiki.openttd.org/User:Yazalo/En <- this is not something TrueWiki supports btw (PAGESINCAT) 18:05:50 <TrueBrain> I can add support for it, but I do not really see the point, honestly 18:05:54 <frosch123> i deleted those categories 18:06:00 <frosch123> so, even if you had implemented it 18:06:23 <frosch123> you would have to implement PAGESINFOLDER :) 18:06:44 <TrueBrain> okay .. so we are just going to leave that broken :) 18:06:50 <TrueBrain> fixed the DISPLAYTITLE on the live wiki 18:06:53 <TrueBrain> that resolves those :P 18:07:12 <frosch123> fixed? you removed it? 18:07:15 <TrueBrain> yes 18:07:30 <frosch123> i made a special conversion rule to rename the page :) 18:07:47 <frosch123> (well, i already had the rule, i just added the page to the list) 18:07:49 <TrueBrain> mediawiki has this stupid rule that the first character has to be uppercase 18:07:59 <TrueBrain> fuck that shit 18:08:13 <TrueBrain> is there anything left to do on your migration script? 18:08:42 <frosch123> on the script, no. but i need to review the folders of categories, templates and fiels 18:08:48 <frosch123> they ar eonly a rough approximation 18:08:57 <frosch123> i'll do that tomorrow. 18:08:57 <TrueBrain> k k 18:09:05 <frosch123> then i'll do a full history export, just to see whether it works 18:09:11 <TrueBrain> :D 18:09:22 <TrueBrain> when you are done, you can merge 1 or 2 commits from the wiki-data-staging 18:09:28 <TrueBrain> and we can push that over the current wiki-data-staging 18:09:36 <TrueBrain> wiki-staging-data, what-ever :P 18:09:51 <TrueBrain> ugh, why did I name it like that? That is silly 18:09:52 <TrueBrain> owh well 18:09:53 <DorpsGek_III> [OpenTTD/team] frosch123 commented on issue #79: [da_DK] Translator access request https://git.io/JkURF 18:10:11 <TrueBrain> anyway, if you push it there, we can ask people to check it out on staging 18:10:23 <TrueBrain> and I think we have to set a date, like, end-of-the-week, to bring this to production 18:10:36 <TrueBrain> if we like, we can already "prefix" stuff on the staging 18:10:39 <TrueBrain> "pre-fix" 18:10:41 <TrueBrain> not prefix :P 18:10:43 *** gelignite has joined #openttd 18:11:02 <TrueBrain> I can bring the current wiki to read-only if we like too 18:11:09 <frosch123> TrueBrain: with merge you mean the actions? 18:11:30 <TrueBrain> frosch123: yes 18:11:46 <TrueBrain> in fact, that is the only commit you would need to cherry-pick 18:12:11 <frosch123> TrueBrain: let me fix the Special: first, then we can set it to readonly 18:12:18 <TrueBrain> yeah, no rush 18:12:22 <frosch123> maybe the pl guy finally reads their mail then 18:12:25 <TrueBrain> when-ever you want the 3 hour long export, I would say 18:12:43 <frosch123> i have no idea how long it will take :p 18:12:52 <TrueBrain> :D 18:12:59 <frosch123> making 100k git commits takes times 18:13:01 <TrueBrain> we just drop it in read-only mode till when-ever we are ready :P 18:13:07 <TrueBrain> 100k? Really? 18:13:13 <TrueBrain> damn ... current is 18k 18:13:14 <frosch123> one commit for every change 18:13:16 <TrueBrain> which is already slow as fuck 18:13:30 <TrueBrain> 11k even 18:13:34 <TrueBrain> so that might be an issue ... 18:13:35 <frosch123> yes, git log <filename> is very slow 18:13:47 <TrueBrain> guess I do need to look into v2 protocol fetch-depth=1 checkout 18:13:52 <TrueBrain> well, I don't care about "git log" tbh 18:13:59 <TrueBrain> but "git commit" already takes ~1 second 18:14:08 *** Wormnest has joined #openttd 18:14:19 <frosch123> hmm, git commit is affected by number of commits present? 18:14:20 <TrueBrain> not sure how that scales to 100k commits :) 18:14:29 <TrueBrain> it seems so 18:14:42 <TrueBrain> on the empty repository it is a lot quicker to save 18:14:46 <TrueBrain> than it is on the 10k one 18:14:52 <TrueBrain> like ... noticeable quicker 18:15:10 <TrueBrain> it fully might be GitPython, and that it is related to the amount of files 18:15:13 <TrueBrain> not the amount of commits 18:15:24 <TrueBrain> I will check out what makes it slow :) 18:16:19 <TrueBrain> hmm .. today it isn't that slow 18:16:24 <TrueBrain> might have been some other changes I did 18:16:31 <TrueBrain> owh, wait, no 18:16:33 <TrueBrain> I am testing wrong :P 18:18:26 <TrueBrain> yes, it is the amount of files :D 18:19:25 <TrueBrain> which, I am pretty sure, is due to how GitPython does things 18:19:32 <TrueBrain> owh well, don't care; so 10k commits of 100k commits, go for it :D 18:28:24 <longtomjr> Are you preserving the history from mediawiki? 18:28:43 <frosch123> yes 18:28:55 <frosch123> except for deleted pages 18:29:03 <frosch123> they will just never have existed 18:29:46 <longtomjr> Interesting 18:31:07 <frosch123> i guess we do it because we can :) 18:32:35 <TrueBrain> as with many many many many many things we do :P 18:33:07 <longtomjr> It is just not something I thought about before that could be a problem with a migration like this 18:33:47 <TrueBrain> it is also the reason we still have the sources of SVN r1 18:33:57 <TrueBrain> and a snapshot of the source ever since every day 18:34:13 <TrueBrain> https://cdn.openttd.org/openttd-nightlies/2004/20040809-trunk-r1/ 18:34:16 <TrueBrain> in case you want to compile it :P 18:34:30 <TrueBrain> we are a bit nuts when it comes to history :D 18:40:01 <frosch123> but we lack the vms with the old setup that is actually able to compile the old sources 18:40:12 <TrueBrain> well, I have them :P 18:40:21 <TrueBrain> but yeah, others it would take a bit more effort to set that up :D 18:40:38 <frosch123> :) 18:40:42 *** jottyfan has joined #openttd 18:41:03 <frosch123> did you put them into the arctic code vault? 18:41:17 <TrueBrain> no, but I did in my own vault :) 18:41:32 <frosch123> dutch permasea? 18:41:40 <TrueBrain> nah, backblaze :P 18:41:48 <TrueBrain> over a TB of my backups and archive is OpenTTD related :P 18:43:33 *** jottyfan has quit IRC 18:49:36 <longtomjr> Goodness 19:06:08 *** jottyfan has joined #openttd 19:12:35 <andythenorth> well 19:12:43 <andythenorth> today happened then 19:15:05 *** iSoSyS has joined #openttd 19:16:44 *** longtomjr has quit IRC 19:16:55 <frosch123> breakfast, lunch, dinner, second dinner? 19:18:21 <TrueBrain> tanks 19:18:24 <TrueBrain> don't forget about the tanks 19:18:43 <frosch123> didn't he ragequit? 19:18:50 <frosch123> i forgot what it was about 19:23:42 *** iSoSyS has quit IRC 19:24:25 <andythenorth> there was a tank? 19:42:18 *** jottyfan has quit IRC 20:09:04 <glx> <TrueBrain> it is also the reason we still have the sources of SVN r1 <-- real r1 or r975 or something from crashed svn ? 20:10:04 * glx clicked and have the answer 20:10:29 <glx> too bad we lost 975 commits :) 20:22:21 <andythenorth> make the commits great again 20:26:12 <TrueBrain> Those commits, I am pretty sure, are lost forever :p 20:26:29 <TrueBrain> C'est la vie 20:27:54 <andythenorth> no they must be counted 20:28:02 <andythenorth> I will launch many lawsuits 20:28:45 <frosch123> corona statistics are more interesting 20:29:08 <andythenorth> oof :) 20:29:13 <andythenorth> the missing commits are a GPL violation! 20:29:18 <andythenorth> now I get kicked :( 20:29:18 <frosch123> i may stretch the term "interesting" though 20:32:00 <TrueBrain> If you ever want a new job, in 4 years you can apply :p 20:33:34 <frosch123> brittish premiers can switch quite fast 20:33:53 <andythenorth> they are talking about removing Boris 20:34:49 <andythenorth> 'they' 20:34:57 <frosch123> "new premier" sounds like a possible excuse to delay another year :) 20:39:26 *** sla_ro|master has quit IRC 20:44:25 * andythenorth plays tanks 20:49:29 <TrueBrain> Funny, I fixed a bug that is now a bug again ... regression!!! 20:49:48 <TrueBrain> Tnx Sentry, you made it obvious where the error is :) 20:50:37 <frosch123> yeah, i didn't bother making notes :) 20:51:28 <TrueBrain> Happy you tested a fixed bug :D 20:52:32 *** gelignite has quit IRC 20:55:22 *** jottyfan has joined #openttd 21:05:54 *** jottyfan has quit IRC 21:09:51 <frosch123> TrueBrain: is "Folder" always up-to-date, or does it wait for indexing? 21:11:53 <TrueBrain> Always uptodate 21:12:13 <frosch123> https://wiki.staging.openttd.org/Folder/Page/en/EchtSchnell/ <- ok, it lists a file that does not exist 21:12:16 <TrueBrain> Index is only for category, translations and 'used on pages' 21:12:44 <frosch123> the file may contain NBSP which got stripped somewhere 21:12:54 <TrueBrain> Very interesting :D 21:13:12 <TrueBrain> Told you people will find a case where I forgot escaping :p 21:13:29 <TrueBrain> Will check tomorrow :) 21:14:31 <TrueBrain> https://github.com/OpenTTD/wiki-staging-data/blob/master/Page/en/EchtSchnell%C2%A0%C2%A0%C2%A0/%C2%A0%C2%A0%C3%A4%C3%B6%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C3%BC.mediawiki 21:14:38 <TrueBrain> What ... did you do?! Lol 21:15:01 <TrueBrain> Wtf is c2a0 .. 21:15:27 <TrueBrain> Non breaking space 21:15:33 <frosch123> all NBSP :) 21:15:52 <frosch123> it's also funny that you can save a page, click browser back, edit the name, and create a new page 21:16:21 <TrueBrain> Yup .. bit intentional. Wasnt sure what to do otherwise 21:16:44 <frosch123> https://wiki.staging.openttd.org/en/EchtSchnell%C2%A0%C2%A0%C2%A0/%C2%A0%C2%A0%C3%A4%C3%B6%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C2%A0%C3%BC <- isn't it pretty? 21:17:05 <TrueBrain> Yeah, you broke it nicely :D 21:17:12 <TrueBrain> I appreciate that :) 21:18:03 <TrueBrain> I wonder why the file listing fails.. would strip() remove nbsp? 21:19:04 <frosch123> yes, just tested 21:19:20 <TrueBrain> Ah, well, that explains the difference :D 21:19:28 <TrueBrain> So it is not my escaping :D 21:19:39 <TrueBrain> I will blacklist nbsp too :p 21:19:59 <frosch123> maybe check whether strip() changes anything after split("/") 21:20:16 <TrueBrain> Will do that too yes, good idea 21:20:28 <frosch123> there are plenty more spaces :) 21:20:30 <TrueBrain> But I guess a nbsp in the middle is also a bit meh 21:20:47 <TrueBrain> True ... 21:20:57 <TrueBrain> Guess I could ask unicodedata for all spaces 21:21:18 <frosch123> when we get japanase, some spaces may be okay 21:21:29 <TrueBrain> On the other hand ... if people want to do stupid shit ... 21:26:34 <frosch123> https://wiki.staging.openttd.org/Template/y%27o%22l%29o <- there is no "create" button 21:27:04 <TrueBrain> Because the URL is invalid 21:27:14 <frosch123> ah, no language 21:27:18 <TrueBrain> That page cannot exist 21:27:26 <TrueBrain> :) 21:27:39 <frosch123> https://wiki.staging.openttd.org/edit/en/javascript <- it did not tell me that :) 21:28:20 <TrueBrain> Should it? 21:28:36 <TrueBrain> We need to do a round of: show better errors :) 21:29:07 <frosch123> maybe the the 404 page of the invalid url should say something 21:29:17 <TrueBrain> Yeah 21:29:43 <TrueBrain> But many different reasons etc.. but we can at least be more clear 21:30:27 <frosch123> https://wiki.staging.openttd.org/edit/Template/en/y%27o%22l%29o <- haha, even more evil. it created that page for me, i cannot edit the name, but also not save it :) 21:31:16 <TrueBrain> Haha, yeah, that is a nice edgecase 21:31:45 <TrueBrain> Guess we should mention the link is invalid on the parent Page 21:31:58 <TrueBrain> And not link it 21:32:15 <frosch123> gave sentry a self-recusive template 21:32:42 <TrueBrain> Ah, yes, that was still on my TODO but fell off 21:32:47 <TrueBrain> Nice testing :D 21:35:48 <frosch123> entering invalid names for Files says "file already exists" 21:37:37 *** nielsm has quit IRC 21:39:59 <TrueBrain> Odd .. make that into an issue please with an example 21:40:07 <TrueBrain> Will pick that up tomorrow :) 21:44:04 <TrueBrain> Ah, yes, Main Page is an illegal name for Folder :) 21:44:11 <TrueBrain> But the error needs to be better 21:44:25 <TrueBrain> Folder = File 21:44:59 <TrueBrain> But guess it is true for any file without extension 21:46:42 <frosch123> no, then it told me to add .png for png files 21:47:15 <TrueBrain> Ah, yeah.. k 21:55:58 <frosch123> hmm, we still have 92 links to wiki.openttd.org :) 21:58:41 *** andythenorth has quit IRC 22:00:21 <TrueBrain> They returned?! 22:00:42 <frosch123> File: and User: are new 22:08:24 <frosch123> https://wiki.staging.openttd.org///////Folder//////File//////// <- also funny :) 22:08:31 *** HerzogDeXtEr has quit IRC 22:08:47 <frosch123> but harmless 22:08:48 <TrueBrain> Hahaha 22:09:02 <TrueBrain> Yeah, but I am going to fix that :p 22:16:41 <frosch123> night 22:16:49 *** frosch123 has quit IRC 22:17:02 *** Wolf01 has quit IRC 22:38:34 *** tokai|noir has joined #openttd 22:38:34 *** ChanServ sets mode: +v tokai|noir 22:45:22 *** Gustavo6046 has quit IRC 22:45:26 *** tokai has quit IRC 22:51:57 *** Gustavo6046 has joined #openttd 22:58:16 *** matt21347 has quit IRC 23:01:02 *** WormnestAndroid has quit IRC 23:01:29 *** WormnestAndroid has joined #openttd 23:17:23 *** Progman has quit IRC 23:22:17 *** Gustavo6046 is now known as Guest5429 23:22:21 *** Gustavo6046 has joined #openttd 23:23:56 *** Guest5429 has quit IRC 23:34:07 *** WormnestAndroid has quit IRC 23:34:32 *** WormnestAndroid has joined #openttd