Config
Log for #openttd on 13th February 2021:
Times are UTC Toggle Colours
00:03:35  *** supermop_Home has quit IRC
00:05:35  *** Flygon has quit IRC
00:39:32  *** arikover has quit IRC
01:30:40  *** glx has quit IRC
01:52:06  *** Flygon has joined #openttd
02:54:02  *** Wormnest has quit IRC
03:34:30  *** D-HUND has joined #openttd
03:37:52  *** debdog has quit IRC
03:47:17  *** HerzogDeXtEr has quit IRC
04:24:54  *** WormnestAndroid has quit IRC
04:26:55  *** WormnestAndroid has joined #openttd
04:46:41  *** Timberwo1f has quit IRC
04:46:45  *** Timberwolf has joined #openttd
05:04:36  *** snail_UES_ is now known as Guest13072
05:04:36  *** snail_UES_ has joined #openttd
06:19:10  *** Wuzzy has quit IRC
07:48:35  *** nielsm has joined #openttd
08:12:33  *** Wolf01 has joined #openttd
08:19:48  *** sla_ro|master has joined #openttd
08:21:34  *** andythenorth has joined #openttd
08:22:34  <Wolf01> What a good day to have headache :S
08:26:30  <Eddi|zuHause> happy headache day then
08:35:08  *** Progman has joined #openttd
09:16:11  *** jottyfan has joined #openttd
09:19:05  *** snail_UES_ has quit IRC
09:44:46  *** iSoSyS has joined #openttd
10:04:07  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8378: Remove undefined behaviour from save/load code https://git.io/JtiYA
10:42:45  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8537: Feature: Automatic UI and font zoom levels. https://git.io/Jti3p
10:42:54  <TrueBrain> michi_cc: that was one of the more interesting reviews I did in ages :P
10:44:19  <TrueBrain> the zoom-system on its own is a gem in the OpenTTD code .. really difficult to follow, mostly because of the naming used, and the way it is structed :P
10:48:20  *** Samu has joined #openttd
10:54:06  <TrueBrain> float offset = aa ? 0.0f : 0.5f; <- this PR is full of lovely variable names :)
10:54:46  <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #8537: Feature: Automatic UI and font zoom levels. https://git.io/Jtis7
10:56:59  <michi_cc> TrueBrain: While #8518 will not change substantially, I'd like to do a separate cleanup PR first to address the comment by LordAro.
10:57:56  <TrueBrain> makes sense
10:58:31  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/JtiGz
10:59:03  <TrueBrain> the PR otherwise looks fine by me .. as in .. I am sure the code does what it does, that is nearly impossible for me to review :)
11:00:10  <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on pull request #8537: Feature: Automatic UI and font zoom levels. https://git.io/JtiGo
11:03:00  <TrueBrain> michi_cc: #8519 code-wise looks fine, but I believe it dropped performance? Is that something we want to deal with? (all these questions are honest questions to be clear; not trying to be snappy, just wondering :D)
11:06:23  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8519: [OSX] Render screen in full native resolution on HiDPI displays. https://git.io/JtiG7
11:06:33  <TrueBrain> I keep asking on IRC, getting an answer there, forgetting about it .. so .. I should ask it in the PR :D
11:07:28  <TrueBrain> michi_cc: seems on all 5 accounts it is: yes, we want this. At least, as far as I am concerned :)
11:13:05  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8537: Feature: Automatic UI and font zoom levels. https://git.io/JtiGx
11:20:23  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8537: Feature: Automatic UI and font zoom levels. https://git.io/JtiZ4
11:35:26  <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #8519: [OSX] Render screen in full native resolution on HiDPI displays. https://git.io/JtiZo
11:49:00  <michi_cc> TrueBrain: You OCD is slacking :P You missed the broken comment on #8537: "Windows 8.1.*/"
11:52:51  *** Progman has quit IRC
12:00:20  *** HerzogDeXtEr has joined #openttd
12:11:44  <TrueBrain> I AM SORRY :(
12:15:02  <michi_cc> We still love you :)
12:15:06  <TrueBrain> <3
12:15:09  <TrueBrain> michi_cc: when looking at SDL, their default DPI is too 96 (and I guess all platforms have this as base), and so I find myself duplicating the (cur_dpi >= BASE_DPI * 3) part of win32
12:15:17  <TrueBrain> wouldn't this hold for all drivers?
12:15:33  <michi_cc> Not for OSX at least.
12:15:42  <TrueBrain> ah .. always an exception :)
12:16:04  <michi_cc> They have a backingScaleFactor that can either be 1.0 or 2.0. And even then, base DPI for OSX would be 72.
12:16:32  <TrueBrain> I like how Apple does everything different :P
12:17:16  <nielsm> https://en.wikipedia.org/wiki/Think_different
12:17:57  <michi_cc> I thought about putting some of the logic into the base driver, but if you potentially consider mobile/touch/web you might want to different logic for these.
12:18:19  <michi_cc> I.e. just a GetDPI function, not a SuggestZoom function.
12:18:44  <TrueBrain> no, I agree with you; if only 1 target is different, there is no real benefit to abstracting it further :)
12:19:15  <michi_cc> I just changed my mind :)
12:20:04  <michi_cc> Have both a GetDPI and a SuggestZoom virtual in the driver, with Win32 (and possibly SDL/OSX) just overriding the GetDPI for now.
12:20:26  <michi_cc> Scaling OSX to an arbitrary internal base DPI is simple enough.
12:20:33  <TrueBrain> wow, setting HIGH_DPI on SDL gives some funny resulsts ...
12:20:50  <TrueBrain> https://pasteboard.co/JOa3Fbe.png
12:20:53  <TrueBrain> this looks ... special
12:21:16  <TrueBrain> windows don't rescale after changing interface size, it seems :P
12:21:39  <TrueBrain> really weird interaction there :)
12:21:51  <michi_cc> I didn't notice it that wrong. I know that the landscape icons on the main menu don't properly rescale.
12:22:05  <TrueBrain> I opened the window with everything set to max
12:22:08  <TrueBrain> then changed it to normal
12:22:11  <TrueBrain> it left the window like that
12:22:15  <TrueBrain> closing/opening the window fixes it :P
12:30:35  <TrueBrain> hmm .. it is difficult to see in-game what value was auto-detected
12:30:40  <TrueBrain> I wonder if we can do anything to improve that
12:32:36  <TrueBrain> michi_cc: https://github.com/OpenTTD/OpenTTD/commit/2987a9c551d06a4cec68b5be18ca4f75be612c5c
12:32:46  <TrueBrain> tested on Windows, there it works identical as your win32 implementation
12:33:00  <TrueBrain> going to check now if I can test this on Linux too .. no clue how to set DPI there :P
12:37:44  <milek7> that will likely break SDL on macos
12:38:03  <milek7> "The window size in screen coordinates may differ from the size in pixels, if the window was created with SDL_WINDOW_ALLOW_HIGHDPI on a platform with high-dpi support (e.g. iOS or OS X). Use SDL_GL_GetDrawableSize(), SDL_Vulkan_GetDrawableSize(), or SDL_GetRendererOutputSize() to get the real client area size in pixels. "
12:38:21  <TrueBrain> if that is the only thing that will break with SDL on MacOS, we can call ourself lucky
12:40:07  <milek7> ?
12:44:01  <TrueBrain> hmm, it cannot get DPI on Ubuntu .. odd
12:45:14  <TrueBrain> especially as SDL source shows it is implemented for x11
12:45:15  <TrueBrain> hmm
12:47:24  <TrueBrain> michi_cc: oops, gave you the wrong link: https://github.com/michicc/OpenTTD/compare/pr/autozoom_setting...TrueBrain:autozoom?expand=1 :)
12:52:17  <TrueBrain> I love reading rants of other people that tackled this :D
12:52:31  <TrueBrain> https://github.com/mosra/magnum/commit/ae31c3cd82ba53454b8ab49d3f9d8ca385560d4b <- someone took some time and effort on documenting it:P
12:59:01  <TrueBrain> okay, reading some more SDL source, it appears that it looks simple to implement this for SDL, but given Linux is our main target for SDL, it is not ..
13:06:03  *** roadt_ has joined #openttd
13:06:24  *** roadt__ has quit IRC
13:08:59  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8537: Feature: Automatic UI and font zoom levels. https://git.io/JtiWq
13:11:49  <TrueBrain> cool, SDL also imported their bugzilla into GitHub :D
13:12:02  <TrueBrain> we did it nicer, I think, but who is counting
13:12:20  <TrueBrain> (they did not preserve dates, and all comments are in the issue itself, not in comments :P
13:16:20  *** Wuzzy has joined #openttd
13:29:02  <Wolf01> TB: it's like when my boss says "Do this 3 days job but don't waste on it more than 1 hour"
13:29:40  <Eddi|zuHause> turns out bosses tend to have no clue how much work something really is
13:30:40  <Wolf01> He was the first developer of the company, but everything changed since he is not developing anymore
13:43:54  *** frosch123 has joined #openttd
13:59:19  <_dp_> programmers in general tend to grossly underestimate time required to do stuff
13:59:41  *** supermop_Home_ has joined #openttd
14:01:22  <_dp_> even when I had to estimate my own work I only managed to get it about right by multiplying my initial estimations by pi :p
14:08:56  *** Gustavo6046 has quit IRC
14:09:44  <Eddi|zuHause> the worst part are situations where it just refuses to work for no (documented) reason
14:10:44  <Eddi|zuHause> when the difficult parts take half an hour, and the easy parts take 5 days
14:23:07  <supermop_Home_> yo
14:33:01  <Wolf01> I started to say "a week" every time they ask me for something
14:34:20  <Wolf01> Also I should not do tests by myself, I'm really biased I and can workaround what doesn't work
14:36:37  <michi_cc> Okay, annoying weekend work done, now let's see what this thing they call OTTD is about :)
14:36:44  <TrueBrain> w00p
14:36:50  <Wolf01> :D
14:37:04  <michi_cc> cleaning bathroom != fun
14:42:18  <supermop_Home_> i beg to differ
14:49:00  *** Gustavo6046 has joined #openttd
14:53:36  *** Flygon has quit IRC
15:09:42  *** jottyfan has quit IRC
15:12:37  *** Progman has joined #openttd
15:15:36  *** Wormnest has joined #openttd
15:46:04  *** jottyfan has joined #openttd
15:50:20  *** heffer has quit IRC
15:56:11  <DorpsGek> [OpenTTD/OpenTTD] LordAro requested changes for pull request #8468: Fix #8316: Make sort industries by production and transported with a cargo filter possible https://git.io/Jtiuh
15:57:14  <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8452: Doc: Add labels to landscape grid description. https://git.io/Jtizf
15:59:25  *** _2TallTyler has joined #openttd
16:01:55  <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8588: Fix: Desert/rainforest data coordinate 'y' is off by 1 when their 'x' coordinate is negative https://git.io/JtizO
16:02:07  <TrueBrain> someone is in a mood :P
16:02:29  <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8566: Move "town name" selection into map generator GUI https://git.io/JtizG
16:02:29  <LordAro> ikr
16:02:40  <LordAro> what else needs doing?
16:03:04  <TrueBrain> your own PRs? :D
16:03:59  <TrueBrain> LordAro: you approved a PR with outstanding comments, you know that right?
16:04:25  <TrueBrain> (last one you approved, renaming of a few strings)
16:04:30  <LordAro> which one? #8566 the comments are minor enough to leave for now
16:04:54  <TrueBrain> the renaming of strings sounds like a really easy win, not?
16:05:17  <TrueBrain> (honest question, no clue about the amount of work involved)
16:05:34  <LordAro> i've no idea how easy eints would make it
16:05:57  <TrueBrain> I was hoping frosch123 would just say: SURE, give me 2 minutes :P
16:06:07  <TrueBrain> anyway, I guess you are right, too minor
16:06:27  <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8607: Codechange: Implement a constructor for CurrencySpec (fixes VS2017 compile failure) https://git.io/Jtizz
16:06:38  <LordAro> bleh, that one needs a rebase
16:06:42  <LordAro> ...or i could just force-merge it
16:07:27  <DorpsGek> [OpenTTD/OpenTTD] LordAro merged pull request #8608: Codechange: [NewGRF] Make it more explicit which parts of the TTD veh… https://git.io/JtncP
16:07:59  <TrueBrain> pretty sure glx won't mind rebasing :)
16:08:21  <TrueBrain> LordAro: while you are in the mood, can I pickle your brain on https://github.com/OpenTTD/OpenTTD/pull/7851 .. I like the concept, but the code itself feels overcomplicated
16:08:45  * LordAro looks
16:12:21  <DorpsGek> [OpenTTD/nml] matthijskooijman commented on pull request #188: Fix broken regression PCX and enable pillow 8.1.0 with an improved error message https://git.io/Jtiz5
16:13:05  <LordAro> TrueBrain: i feel like i'd expect it to wrap around
16:13:16  <TrueBrain> I had the same, yes
16:13:17  <LordAro> code itself... eh
16:13:26  <TrueBrain> but the code itself .. it feels like this should be easier?
16:17:07  <TrueBrain> I might toy around with it next week, but I was mostly curious if this is like: yeah, this is how OpenTTD does it :)
16:17:43  <LordAro> i'm not really sure about the hasbit stuff with the out parameter
16:18:41  <LordAro> and i think the duplicated "if (rt >= RAILTYPE_END) ..." is wrong for the PREV_RAILTYPE block
16:19:26  <LordAro> but other than that... you need 2 loops, and to handle the "actually change stuff" case
16:20:48  <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #7851: Change: add support for next/previous railtype global hotkeys https://git.io/JtigW
16:22:32  <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #8638: Feature: [GS] Allow non-question type windows to have no buttons https://git.io/JtigR
16:23:23  <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #8638: Feature: [GS] Allow non-question type windows to have no buttons https://git.io/Jtigz
16:24:19  <TrueBrain> owh, right, the "question" window which is no longer really a "question" window anymore :P
16:24:28  <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #8639: Add: Allow translation of "(Directory)" and "(Parent directory)" https://git.io/Jtiga
16:24:53  <LordAro> TrueBrain: little bit
16:25:03  <TrueBrain> we really should rename it
16:25:05  <TrueBrain> but not for that PR
16:25:20  <LordAro> mm
16:25:31  *** glx has joined #openttd
16:25:31  *** ChanServ sets mode: +v glx
16:28:57  <DorpsGek> [OpenTTD/OpenTTD] ldpl updated pull request #8638: Feature: [GS] Allow non-question type windows to have no buttons https://git.io/JtEZG
16:30:09  <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8638: Feature: [GS] Allow non-question type windows to have no buttons https://git.io/JtigD
16:30:25  <andythenorth> the modern world of computing, where a to-do list app requires 1GB of memory allocated
16:30:47  <glx> hmm seems I should update check requirements
16:30:54  <_dp_> I can rename it in next pr but where to put it? GSCompany/GSSClient.MessageBox ?
16:31:12  <LordAro> DialogueWindow ?
16:32:01  <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #8607: Codechange: Implement a constructor for CurrencySpec (fixes VS2017 compile failure) https://git.io/JtnOX
16:32:58  <_dp_> hm, but can't quite put CloseQuestion in gscompany/client
16:33:18  <_dp_> well, I guess I could do 2 identical functions...
16:34:23  <_dp_> still kinda bad to have shared uniqueid ...
16:34:46  *** snail_UES_ has joined #openttd
16:34:49  <_dp_> also there was some answer event somewhere...
16:37:30  <_dp_> also... what's the point of having QT_QUESTION at all?
16:37:44  <_dp_> it's not like it's any different from QT_INFORMATION anyway
16:38:05  <_dp_> well, for window title I guess...
16:41:47  <_dp_> hm, title could be just a string if network commands could send 2 texts...
16:42:37  *** jottyfan has quit IRC
16:45:48  <LordAro> C:/msys64/home/LordAro/OpenTTD/src/os/windows/crashlog_win.cpp:24:10: fatal error: timeapi.h: No such file or directory 24 | #include <timeapi.h>
16:45:52  <LordAro> that's a new one
16:46:03  <glx> oh
16:46:22  <glx> but it should be in windows sdk
16:47:13  <LordAro> hmm
16:47:25  <LordAro> should be using the right gcc
16:48:35  <LordAro> i'll nuke the build dir
16:49:05  <glx> to e honnest I didn't check if mingw still builds
16:49:21  <LordAro> i don't expect you to :p
16:49:42  <glx> I could, I have it in a dropdown in VS
16:53:19  <LordAro> no change
16:53:26  <glx> confirmed here
16:54:53  <LordAro> it appears in mmsystem.h
16:55:06  <LordAro> s/it/timeBeginPeriod/
16:55:23  <glx> https://docs.microsoft.com/en-us/windows/win32/api/timeapi/nf-timeapi-timeendperiod
16:55:53  <glx> and doc says windows.h should be enough (but it's not)
16:56:03  <LordAro> something to do with winmm ?
16:57:10  <LordAro> mmsystem.h is included from windows.h as well
16:57:21  <LordAro> so, mingw matches the documentation, msvc does not? :p
16:57:45  <glx> well if I comment the include mingw doesn't find the function
16:57:53  <LordAro> oh, it's guarded behind ifndef WIN32_LEAN_AND_MEAN
16:58:26  <DorpsGek> [OpenTTD/OpenTTD] ldpl commented on pull request #8638: Feature: [GS] Allow non-question type windows to have no buttons https://git.io/Jti2N
16:58:34  <LordAro> perhaps that's the problem with normal windows too?
16:58:41  <LordAro> stdafx.h defines that
16:59:35  <glx> seems so
17:00:10  <glx> timeapi.h is included by mmsystem.h, conditionnaly included by windows.h
17:03:46  <LordAro> i'll leave you to work out the proper solution, as you have both build systems :p
17:05:22  <LordAro> but just plain swapping out timeapi.h for mmsystem.h works for me
17:08:15  <DorpsGek> [OpenTTD/OpenTTD] michicc opened pull request #8666: Cleanup: Seperate platform-specific code for font handling. https://git.io/Jtial
17:08:16  <michi_cc> Chance for CI failure: 99.9%
17:08:27  <LordAro> :D
17:11:40  <TrueBrain> Lol
17:12:19  <LordAro> 4 minutes in, nothing yet
17:14:53  <LordAro> i swear link time on mingw has gotten slower
17:15:00  <LordAro> i'm not doing a release build
17:15:12  <LordAro> it's taking more than a minute
17:20:07  <LordAro> /* Removing with the cheat costs more in TTDPatch / the specs. */
17:20:08  <LordAro> TIL
17:20:14  <LordAro> multiplies by 25
17:20:45  <glx> ok if I remove WIN32_LEAN_AND_MEAN, I get a weird error in company_func.h
17:21:04  <LordAro> i got something related to the include order of winsock
17:21:21  <michi_cc> glx: Don't remove WIN32_LEAN_AND_MEAN, it's not worth it.
17:21:23  <glx> if I keep it and add a conditional undef (as in dmusic.cpp) I get many redefinition
17:22:01  <michi_cc> I think mmsystem.h used to be the only header, timeapi.h has to be some new-fangled addition :)
17:22:18  <LordAro> is it terrible to just include mmsystem.h directly?
17:22:27  <glx> yeah mmsystem.h should work for vs
17:24:17  <glx> we already manually include stuff guarded by WIN32_LEAN_AND_MEAN
17:25:13  *** erle- has joined #openttd
17:26:20  <glx> and removing the define is not an easy task, especially on our old project :)
17:28:04  <michi_cc> It would also pull in a lot of crap nobody needs anymore. I think selectively including proper headers is always preferable.
17:28:56  <DorpsGek> [OpenTTD/OpenTTD] LordAro opened pull request #8667: Change: Use a more specific error message when attempting to bulldoze your own HQ https://git.io/JtiVI
17:29:09  <glx> it includes winsock.h by default and we use winsock2, so I guess the redefinition errors come from it
17:29:54  <glx> anyway including mmsystem only works
17:29:56  <glx> so
17:30:37  *** jottyfan has joined #openttd
17:34:29  *** _2TallTyler has quit IRC
17:36:09  *** virtualrandomnumber has joined #openttd
17:36:25  *** virtualrandomnumber has quit IRC
17:40:45  <LordAro> C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: BFD (GNU Binutils) 2.36.1 assertion fail ../../binutils-2.36.1/bfd/coffgen.c:460
17:40:49  <LordAro> hmm.
17:41:04  <glx> doesn't look good
17:41:14  <LordAro> oddly, it built anyway
17:41:18  *** snail_UES_ has quit IRC
17:42:18  *** snail_UES_ has joined #openttd
17:45:24  <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #8668: Fix f1f281b31: [Win32] MinGW doesn't know timeapi.h https://git.io/JtiVD
17:46:01  <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8668: Fix f1f281b31: [Win32] MinGW doesn't know timeapi.h https://git.io/JtiVQ
17:46:31  <glx> maybe one day I'll try https://github.com/msys2/setup-msys2 to add a mingw workflow :)
17:47:10  <LordAro> neat
17:47:27  <LordAro> can never have too many CI targets :p
17:49:13  <glx> I disabled windows CI requirements to merge VS2017 PR, but I'll re enable them once some approved PRs are merged
17:49:26  <glx> else they would need a rebase
17:49:40  <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #8378: Remove undefined behaviour from save/load code https://git.io/Jtiwv
17:50:33  <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #8378: Remove undefined behaviour from save/load code https://git.io/JIjs7
17:53:23  *** D-HUND is now known as debdog
18:07:46  <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #8668: Fix f1f281b31: [Win32] MinGW doesn't know timeapi.h https://git.io/JtiVD
18:08:38  <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #8667: Change: Use a more specific error message when attempting to bulldoze your own HQ https://git.io/JtiwM
18:10:17  <DorpsGek> [OpenTTD/OpenTTD] LordAro closed issue #8662: Company HQ cannot be bulldozed https://git.io/JtrMF
18:10:20  <DorpsGek> [OpenTTD/OpenTTD] LordAro merged pull request #8667: Change: Use a more specific error message when attempting to bulldoze your own HQ https://git.io/JtiVI
18:18:24  *** tokai has joined #openttd
18:18:24  *** ChanServ sets mode: +v tokai
18:18:36  *** arikover` has joined #openttd
18:18:45  <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #8588: Fix: Desert/rainforest data coordinate 'y' is off by 1 when their 'x' coordinate is negative https://git.io/JtLJP
18:31:36  <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #8537: Feature: Automatic UI and font zoom levels. https://git.io/JLpSS
18:33:26  <michi_cc> TrueBrain: If you do have something about SDL and HiDPI that makes sense, feel free to push onto the PR
18:33:47  <TrueBrain> michi_cc: well, depends on the answer to the question I posted :D Do we want to go the dlopen() route :)
18:33:53  <TrueBrain> otherwise, it is not really useful
18:34:32  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8378: Remove undefined behaviour from save/load code https://git.io/Jtir6
18:35:04  <michi_cc> Opinions of real Linux users would be more useful, but if HiDPI is a thing on Linux (and maybe more people on with Steam), launching tiny is bad.
18:35:22  <TrueBrain> On Ubuntu it works the same as Windows
18:35:26  <TrueBrain> not so much high DPI
18:35:34  <TrueBrain> but you can set the font-size
18:35:38  <TrueBrain> we should honor that, honestly
18:35:52  <nielsm> I think a heuristic based on window size would be fine for most
18:36:11  <TrueBrain> nielsm: no, turns out that doesn't work on X11 / Windows, really :)
18:36:18  * LordAro does not have a HiDPI monitor to test with
18:36:23  <TrueBrain> I posted a commit with a nice rant about that in the PR :P
18:37:02  <michi_cc> *Window* size not really useful, screen size in inch would be, but you don't get that remotely accurately.
18:37:38  <michi_cc> I wouldn't want a huge GUI/font just because I display OTTD on a wall size 8K screen :P
18:38:07  <TrueBrain> owh, window-size, as in: if more than 4k, scale up?
18:38:16  <TrueBrain> that is most likely not what users expect
18:38:20  <nielsm> I think it's reasonable to assume most people play on 24 inch or smaller displays
18:38:37  <TrueBrain> it is?
18:39:03  <nielsm> and that a window size larger than 1600x1200 (both dimensions must be greater) warrants 2x scaling
18:39:04  <TrueBrain> well, with Steam we can quantify those numbers :)
18:39:35  <TrueBrain> I like the approach michi_cc took, as it basically reads what the user would like
18:39:35  <michi_cc> A normal Full-HD screen with 22-24 inch does not warrant 2X scaling IMHO.
18:39:42  <TrueBrain> if you scale in Windows your font-size, OpenTTD honors that
18:39:56  <nielsm> yes 1920x1080 or 1920x1200 would not scale under that
18:40:00  <nielsm> because 1200 is not greater than 1200
18:40:16  <TrueBrain> I have 1440, and I wouldn't want fonts to scale
18:40:26  <TrueBrain> but if I compare how I use my computer with how my father does, nearly identical setups
18:40:29  <TrueBrain> he has font-scaling active
18:40:33  <michi_cc> nielsm: This assumes OTTD starts in fullscreen initially.
18:40:39  <TrueBrain> pretty sure it depends on the human :D
18:41:54  <TrueBrain> michi_cc: re 8378, with the _proc addition, it really reads easier, tnx for fixing that :D
18:42:18  <TrueBrain> and for SDL / Linux, I will make a dlopen PR, just so we can see if we like that
18:42:32  <michi_cc> TrueBrain: For the missed proc, I had the file open and look at it and everything and still forgot to change it :)
18:42:33  <TrueBrain> well, not now, but next week :D
18:42:40  <TrueBrain> michi_cc: ghehehe :D
18:43:03  <nielsm> there's also some Fitt's Law going on though, it's not just DPI/physical size on the display, if the GUI elements are too small relative to the rest of the game display the size of the GUI elements relative to the length of movements required to reach those GUI elements becomes bad
18:43:27  <_dp_> ubuntu has scaling but dunno how openttd will ever detect that
18:43:40  <TrueBrain> _dp_: I do
18:43:56  <TrueBrain> that is exactly what I was talking about :) I wrote it in the PR, but basically we need to check Xft.dpi
18:44:14  <TrueBrain> which sadly is a bit difficult to access
18:44:33  <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #8378: Remove undefined behaviour from save/load code https://git.io/JIjs7
18:44:37  <_dp_> also... do you handle different scaling on different displays in any way? xD
18:44:56  <TrueBrain> the draft I have, uses the display that OpenTTD is opening on
18:45:49  <TrueBrain> what I like about this approach, about reading what the user set OS-wide basically, is that we let the user control it, and just honor the preference
18:45:56  <TrueBrain> it works for hardware now and in 5 years
18:45:57  <TrueBrain> or even 10
18:46:37  <TrueBrain> you can, however, on Linux also configure "true" high DPI
18:46:41  <TrueBrain> where X11 is set to a higher DPI
18:46:46  <TrueBrain> that .... is another can of worms
18:46:58  <TrueBrain> and acts more like what macOS does
18:48:00  <TrueBrain> to me it reads screens got higher DPI, people complained fonts were too small, OSes wrote code to allow font-scaling, but as other applications were failing because of it, it fakes a higher DPI, or something like that ... feels like the problem became the solution became the problem, or something :D
18:48:28  <milek7> macos dpi handling is just insane
18:48:29  <milek7> but maybe that's just me :P
18:49:28  <milek7> well, maybe not worse than linux, where everybody have their own setting
18:50:01  <TrueBrain> it is weird that if I say: create a window of 1000 pixels in width, that I get one with more
18:50:05  <TrueBrain> but not really
18:50:11  <TrueBrain> or something
18:50:24  <michi_cc> I think too many programs everywhere (no matter which OS) blindly assumed a fixed DPI <-> pixel ratio to ever allow changing the "default" DPI.
18:50:52  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8378: Remove undefined behaviour from save/load code https://git.io/JtioY
18:51:07  <TrueBrain> I also like that most APIs have a horizontal DPI and vertical DPI
18:51:13  <TrueBrain> like .. how many shit breaks if those are not identical?
18:51:47  <michi_cc> It's even better if the docs of said API explicitly state that they will never be different.
18:52:01  <TrueBrain> SDL also gives a diagonal DPI
18:52:01  <michi_cc> Why bother then?
18:52:05  <TrueBrain> which is just some math on the other two
18:52:18  <TrueBrain> this whole DPI is just one mistake on top of another, it seems
18:52:25  <TrueBrain> it means different things based on OS and/or settings
18:53:07  <milek7> things like that happen too.. https://i.imgur.com/cAQBUd9.png
18:53:32  <michi_cc> A look at #8666 would be nice, then I could rebase the OSX font PR on top of it :D
18:53:47  <milek7> (it broke because apparently it doesn't like fractional QT_SCALE_FACTOR)
18:53:52  <TrueBrain> how on earth am I going to review that .. eeuuuhhhh
18:54:37  <michi_cc> TrueBrain: LordAro suggest it, so get him to do it :P
18:54:43  <michi_cc> *ed
18:54:53  <TrueBrain> and how would he do it? :P
18:54:56  <TrueBrain> I am now already looking at it
18:55:29  <DorpsGek> [OpenTTD/OpenTTD] LordAro opened pull request #8669: Change: Make order window hotkeys toggle for load & unload variants https://git.io/Jtiol
18:55:59  <LordAro> michi_cc: if it compiles...
18:56:13  <LordAro> suppose you could check on all the platforms that text is still displayed
18:57:23  <milek7> about that MacOS dpi handling, I wonder
18:57:30  <milek7> does mouse position is quantized to 2px, or not?
18:59:15  <TrueBrain> michi_cc: there are some odd things in the commits themselves, but the total result is fine (assuming your copy/paste was a success)
18:59:16  <TrueBrain> do you care?
19:00:07  <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/Jtior
19:00:07  <DorpsGek>   - Update: Translations from eints (by translators)
19:00:23  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8666: Cleanup: Seperate platform-specific code for font handling. https://git.io/Jtioo
19:00:27  <TrueBrain> I found out I do not
19:00:42  <TrueBrain> (example: #if defined(WITH_FONTCONFIG) /* end ifdef APPLE */ )
19:00:53  <TrueBrain> it doesn't end the ifdef anymore .. but that statement is removed the next commit
19:00:54  <TrueBrain> so what-ever
19:04:01  <LordAro> :o
19:04:43  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8669: Change: Make order window hotkeys toggle for load & unload variants https://git.io/Jtioh
19:04:44  <TrueBrain> such a nitpick :D ^^
19:05:48  <michi_cc> TrueBrain: Yes, the #ifdefs in between are a bit wonky, but I don't care as they are gone in the end.
19:06:10  <TrueBrain> +1
19:08:02  <michi_cc> milek7: On the OS side it is a float value, but as OTTD truncates that to int and will (without #8519) run with OS scaling on, the OTTD cursor will be in 2 real pixel steps.
19:08:38  <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #8669: Change: Make order window hotkeys toggle for load & unload variants https://git.io/JtiKO
19:08:57  <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #8378: Remove undefined behaviour from save/load code https://git.io/JIjs7
19:09:19  <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #8666: Cleanup: Seperate platform-specific code for font handling. https://git.io/Jtial
19:16:14  <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #8669: Change: Make order window hotkeys toggle for load & unload variants https://git.io/Jtiol
19:16:55  <TrueBrain> DOTS ARE IMPORTANT! :P
19:17:27  <LordAro> i can never remember whether they were purposefully not used for OTTD
19:17:49  <LordAro> only thing i ever remember is that Alberth decided on "the opposite" for FRCT
19:18:29  <TrueBrain> well, sentences that start with a capital should end with a dot
19:18:31  <TrueBrain> that is all I know
19:18:43  <TrueBrain> especially if they are Doxygen comments :D
19:20:28  <TrueBrain> hotkeys ... how to find which one does what ... lol
19:20:39  <TrueBrain> also, never knew you could click "far end" and that it changes
19:20:44  <TrueBrain> like .. that is a lovely hidden feature :P
19:20:54  <TrueBrain> owh, you can click anywhere on the order for it to do that
19:21:41  <TrueBrain> so J does not toggle the label of the button
19:21:43  <TrueBrain> also interesting
19:22:04  <TrueBrain> why is that?
19:22:32  <TrueBrain> ah, no, LordAro broke that
19:22:33  <TrueBrain> okay
19:22:40  <erle-> Do path signals exist in real life?
19:22:59  <LordAro> TrueBrain: are you sure?
19:23:36  <TrueBrain> I do not get what your PR fixes, I have to admit
19:23:43  <TrueBrain> for me it is now a regression, but I do not understand most of this :D
19:23:54  <LordAro> erle-: not in the form that OTTD calls them
19:25:56  <LordAro> TrueBrain: i shall amend the description
19:26:25  <TrueBrain> LordAro: it is my lack of understanding, to be clear, nothing to do with you or your PR :)
19:26:37  <LordAro> it took me quite some time to understand the original issue
19:26:46  <TrueBrain> what I did find out: before your PR, pressing J changes the order to Full load any cargo
19:26:54  <TrueBrain> with your PR, J changes it to Full load
19:26:58  <TrueBrain> and does NOT switch the button
19:27:04  <TrueBrain> that is intended?
19:27:12  <nielsm> erle-: they are not called that but it's how signalling at stations tends to work in reality
19:27:25  <LordAro> full load vs full load any - unintentional
19:27:34  <erle-> I mean, the path is not really selcted by the train conductor to begin with
19:27:42  <LordAro> "not switching the button" - "intentional" (because that's how it behaves currently)
19:27:47  <nielsm> erle-: check out the game SimSig to see how railway signalling works in reality (it's a very accurate simulation)
19:27:48  <erle-> but by the guy who switches the raisl
19:28:01  <TrueBrain> LordAro: before your PR, if I press J, it toggles the button for me :)
19:28:26  <erle-> nielsm, I once played a whole day at ETH Zürich railroad department
19:28:27  <LordAro> TrueBrain: yes, because it switches to full load any
19:28:31  <erle-> they have a model railroad with four stations
19:28:33  <LordAro> the button only changes for full load any
19:28:36  <erle-> each has one generation of controlling
19:28:39  <erle-> one iwth computer
19:28:46  <erle-> one with switch board 70's style
19:28:49  <erle-> one with heavy levers
19:28:54  <nielsm> oh nice
19:29:03  <erle-> so you pull the huge lever
19:29:09  <erle-> and it sets the rails on the model
19:29:20  <erle-> we were four teams in each station and had to send out trains to schedule
19:29:27  <erle-> but every mistake resulted in chaos
19:30:06  <erle-> nielsm, http://archiv.ivt.ethz.ch/oev/eisenbahn/2011_ebl_illustration_25830.jpg
19:30:08  <erle-> :)
19:30:12  <TrueBrain> LordAro: I do not get what the issue was, but with your PR I can get it stuck on "No loading", where before your PR that was not possible :P
19:30:22  <TrueBrain> owh, it is
19:30:26  <TrueBrain> boy, this hotkey stuff is messy
19:30:33  <LordAro> yup
19:30:35  <TrueBrain> not only is it rather unclear what it should be doing
19:30:38  <TrueBrain> but also what you now changed :D
19:31:02  <LordAro> basically, this improves things for hotkeys which aren't set by default
19:31:07  <TrueBrain> ah, if you go via Transfer, things get weird
19:31:16  <LordAro> as i said in the PR :p
19:31:35  <TrueBrain> so you did
19:31:39  <erle-> nielsm, they told us that each of them are still used in some remote station in Switzerland, but all busy ones are computer controlled of course
19:31:40  <TrueBrain> but reading and understanding are two things
19:31:49  <nielsm> but yeah TT pretends trains pick their own path when in reality you have people working out timetables and dispatchers controlling points and signals
19:32:13  <nielsm> but path signals in OTTD are a very good approximation
19:32:40  <TrueBrain> LordAro: okay, what is most confusing, is that the label on the dropdown doesn't change
19:32:46  <TrueBrain> that would help so much, if that shows the current selection
19:32:49  <TrueBrain> not for your PR
19:32:55  <LordAro> agreed
19:33:04  <TrueBrain> but that is mostly what makes hotkeys difficult to process
19:33:17  <TrueBrain> so that indeed only makes the bug in your PR, that you picked the wrong state :D
19:33:26  <LordAro> :)
19:33:35  <LordAro> i'll see what i can do about the selection button
19:33:46  <LordAro> but i think it's intentional
19:33:54  <LordAro> as in "this is the option you're most likely to want"
19:34:20  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8669: Change: Make order window hotkeys toggle for load & unload variants https://git.io/Jti6H
19:34:34  <TrueBrain> LordAro: which is fine if you did not select any
19:34:39  <TrueBrain> but after you select one, it becomes weird :P
19:34:47  <TrueBrain> but as said, mostly when you use hotkeys
19:34:51  <TrueBrain> otherwise I am sure it is fine :)
19:35:10  <TrueBrain> well, and "transfer" just messes things up :D
19:35:29  <erle-> nielsm, it simulates that controlling is setting the path and then opening the signal
19:35:40  <erle-> the conductor does not really have to look for other trains
19:35:53  <TrueBrain> so before your PR, it always untoggled first if there was anything toggle, and with your PR, it now always sets what is on the button/hotkey
19:35:56  <TrueBrain> that sounds sane to me
19:37:34  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8669: Change: Make order window hotkeys toggle for load & unload variants https://git.io/JtiiJ
19:37:42  <TrueBrain> okay, learnt something about OpenTTD I rather not have learnt, but here we are :)
19:38:06  <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #8669: Change: Make order window hotkeys toggle for load & unload variants https://git.io/Jtiol
19:38:22  <LordAro> turns out, redoing the order window like Zorg suggests may not be a bad idea :p
19:38:37  <TrueBrain> I like that GitHub shows tabs as 8 spaces
19:38:42  <TrueBrain> which makes your "added spaces" look REALLY odd :P
19:39:41  <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #8537: Feature: Automatic UI and font zoom levels. https://git.io/JLpSS
19:40:19  <TrueBrain> I love that if you select in the dropdown the top setting, it shows an error without explainnig the error
19:40:31  <andythenorth> the orders window is lolz
19:40:34  <andythenorth> never change it
19:40:36  <andythenorth> it's perfection
19:43:18  *** nielsm has quit IRC
19:43:31  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8669: Change: Make order window hotkeys toggle for load & unload variants https://git.io/JtiiZ
19:44:44  <TrueBrain> sorry LordAro , it is always the simple fixes that gets you :P
19:45:30  <LordAro> of course :)
19:45:41  <TrueBrain> and this is preview striking again :P
19:45:46  <TrueBrain> without it, I would have approved the PR :D
19:49:30  * LordAro shakes fist at emscripten
19:49:45  <TrueBrain> :D
19:54:02  *** jottyfan has quit IRC
19:56:32  <FLHerne> andythenorth: But JGR's shown that it can be so much MORE!
19:56:33  <LordAro> 1) fixed (trying to set the same load type as is already set) - would also have done the same for unload, which you didn't spot :p
19:56:46  <TrueBrain> I did, but I assumed you could deduce that LordAro  :)
19:56:52  <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #8669: Change: Make order window hotkeys toggle for load & unload variants https://git.io/Jtiol
19:56:52  <LordAro> :>
19:57:30  <FLHerne> More buttons! More nonsensical labels! More ways to set conflicting options and make all your trains jam!
19:58:29  <TrueBrain> LordAro: I am, however, a bit disapointed you consider it needed to change the @param comment of 1 of the two, but not the other :P
19:59:05  <andythenorth> pls more nonsenses
20:00:26  <LordAro> TrueBrain: your information is out of date :p
20:00:56  <TrueBrain> ah, lol, fair :D
20:01:20  <TrueBrain> so that leaves the question, is 2) intended? Does it feel right? :D
20:01:47  <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #8669: Change: Make order window hotkeys toggle for load & unload variants https://git.io/Jtiol
20:01:51  <LordAro> ^ should answer your question :)
20:02:03  <LordAro> probably should've checked it compiles first
20:02:14  <TrueBrain> we have a CI for that :P
20:02:17  *** snail_UES_ has quit IRC
20:02:22  <LordAro> it doesn't! \o/
20:03:31  *** jottyfan has joined #openttd
20:03:44  <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #8537: Feature: Automatic UI and font zoom levels. https://git.io/JLpSS
20:05:00  *** jottyfan has quit IRC
20:07:01  <DorpsGek> [OpenTTD/OpenTTD] EdisonDD opened issue #8670: I'm having an issue where OpenTTD won't open on MacOS Big Sur. it'll download the graphics up to 200% then crash https://git.io/JtiPZ
20:07:15  <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #8669: Change: Make order window hotkeys toggle for load & unload variants https://git.io/Jtiol
20:08:30  <TrueBrain> I love it that people modify our template
20:08:33  <TrueBrain> fixes stuff
20:08:41  <TrueBrain> version 10.12 .. hmm .. no clue which version he means
20:08:56  <LordAro> that is neither OTTD nor Big Sur
20:09:17  *** nielsm has joined #openttd
20:09:54  <LordAro> sounds perhaps like bootstrap is failing on OSXI though?
20:10:25  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #8670: Crash on macOS Big Sur after downloading graphics to 200% https://git.io/JtiPZ
20:10:30  <DorpsGek> [OpenTTD/OpenTTD] orudge commented on issue #8670: Crash on macOS Big Sur after downloading graphics to 200% https://git.io/JtiPZ
20:10:55  <LordAro> ah yes, 1.10.1+2
20:10:57  <LordAro> of course
20:10:59  <LordAro> :p
20:11:11  <LordAro> only possibly explanation
20:11:15  <LordAro> s/y/e/
20:11:46  *** jottyfan has joined #openttd
20:12:00  *** jottyfan has joined #openttd
20:12:02  <TrueBrain> but I guess orudge can verify if the bootstrap works or not :)
20:12:37  *** jottyfan has quit IRC
20:21:57  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8669: Change: Make order window hotkeys toggle for load & unload variants https://git.io/JtiPN
20:22:21  <TrueBrain> sorry LordAro , found one more issue :)
20:23:31  <LordAro> i'm not sure... did you?
20:23:38  <TrueBrain> the button no longer toggles
20:23:40  <TrueBrain> that is really weird
20:23:44  <LordAro> ah
20:23:45  <LordAro> yes
20:23:58  <LordAro> not enough context :)
20:24:03  <TrueBrain> I fixed my comment :P
20:24:10  <andythenorth> newgrf vehicle liveries anyone? o_O
20:24:16  * andythenorth wondering what to do next
20:25:21  <LordAro> andythenorth: yes
20:25:24  <LordAro> go implement it
20:25:32  <TrueBrain> no, please, no, no, no no no
20:25:35  <TrueBrain> :P
20:25:37  <andythenorth> the spec is unagreed
20:25:55  <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #8669: Change: Make order window hotkeys toggle for load & unload variants https://git.io/Jtiol
20:25:59  <LordAro> it's what we'd tell anyone else :p
20:26:41  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8669: Change: Make order window hotkeys toggle for load & unload variants https://git.io/JtiXk
20:28:41  *** WormnestAndroid has quit IRC
20:29:02  *** WormnestAndroid has joined #openttd
20:29:51  <andythenorth> so are we supposed to be warning about inflation in newgrfs now?
20:30:05  * andythenorth has a 'to-do' list item
20:30:14  <LordAro> now, do i want to touch #8505 ...
20:30:36  <TrueBrain> yes, yes, you do
20:30:43  <LordAro> but complicated
20:30:53  <TrueBrain> or fix the last pieces of your scroll PR!
20:31:04  <LordAro> oh yeah
20:31:12  <LordAro> though there's no nice fixes for that either
20:31:18  <LordAro> lots of casts everywhere
20:33:53  <DorpsGek> [OpenTTD/OpenTTD] orudge commented on pull request #7744: Draft Feature: OpenGL video driver https://git.io/JtiXl
20:34:28  <TrueBrain> insane how fast the macOS driver is versus other OS-drivers
20:34:39  <TrueBrain> Win32 gives me ~200 fps without OpenGL :P
20:36:01  *** jottyfan has joined #openttd
20:38:14  <DorpsGek> [OpenTTD/OpenTTD] orudge commented on pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/JtiXB
20:40:15  <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #7744: Draft Feature: OpenGL video driver https://git.io/JtiX0
20:43:16  <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/JtiX2
20:47:57  <DorpsGek> [OpenTTD/OpenTTD] orudge commented on pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/JtiX1
21:01:10  <DorpsGek> [OpenTTD/OpenTTD] orudge commented on pull request #8519: [OSX] Render screen in full native resolution on HiDPI displays. https://git.io/JtiXj
21:02:35  <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/Jti1J
21:05:51  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/Jti1L
21:08:11  <TrueBrain> michi_cc: I don't know what the OpenTTD coding standard says about these kind of implicit statements btw :)
21:08:15  <TrueBrain> I just always find them a bit annoying to read
21:08:25  <TrueBrain> it might be fully me, so I leave it to others to judge that :)
21:09:39  <michi_cc> Tron would have said less keystrokes is better :p
21:09:40  <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/Jti10
21:09:50  <TrueBrain> yeah ... he said a lot of things
21:10:03  <LordAro> AA being commonly used for ani-aliasing is quite common, tbf
21:10:10  <glx> compiler optimise it anyway, so better have easy to read
21:10:14  <TrueBrain> but a variable "aa" is just silly LordAro  :)
21:10:26  *** Wormnest has quit IRC
21:10:27  <LordAro> perhaps
21:10:51  <TrueBrain> but it seems michi_cc took to many lessons from Tron :P
21:11:05  <LordAro> Tron predates me
21:11:08  <TrueBrain> I still remember how he was against the prefix in commit messages
21:11:11  <TrueBrain> so he fixed that
21:11:16  <TrueBrain> Add\n<his commit message>
21:11:16  <LordAro> also, fewer keystrokes*
21:11:19  * LordAro runs away
21:11:32  <DorpsGek> [OpenTTD/OpenTTD] orudge commented on pull request #7744: Draft Feature: OpenGL video driver https://git.io/Jti1o
21:11:32  <glx> ahah I remember these commits
21:11:49  <michi_cc> Even the out setting is called "medium.aa".
21:12:02  <michi_cc> s/the out/our/
21:12:08  *** nielsm has quit IRC
21:15:51  <TrueBrain> michi_cc: so name the variable "is_aa" or "use_aa" or what-ever the boolean means :)
21:16:21  <TrueBrain> I have nothing against the letters "aa". It is just that as variable name, it is pretty difficult to read, I noticed :)
21:17:16  *** snail_UES_ has joined #openttd
21:18:08  <glx> with context I supposed it was antialiasing
21:18:22  <DorpsGek> [OpenTTD/OpenTTD] orudge approved pull request #8652: [OSX] Cleanup video driver. https://git.io/Jti17
21:19:36  <orudge> [20:34:40] <TrueBrain> Win32 gives me ~200 fps without OpenGL :P <-- this is why I would be interested to try Direct2D, which is basically 2D on a D3D surface, though it may be redundant now that we (nearly) have OpenGL :)
21:20:03  <TrueBrain> I am happy michi_cc went for OpenGL, as more OSes benefit from that :P
21:20:13  <TrueBrain> DirectX would have been so Windows-only
21:20:20  <TrueBrain> well .. there are emulation layers, ofc :D
21:20:22  <orudge> Yup
21:21:20  <orudge> My initial motivation behind D2D (and XAudio etc) was to have alternatives for the "Win32isms" that were unsupported by UWP. But then Microsoft decided to allow desktop apps in the Windows Store, and on their ARM devices (originally they were UWP-only), so that became unnecessary.
21:21:21  <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #8652: [OSX] Cleanup video driver. https://git.io/JtaO5
21:21:25  <orudge> Sensible on MS's part
21:21:38  <TrueBrain> ghehe
21:22:32  <orudge> michi_cc: any more macOS things to be tested just now? :)
21:23:10  <michi_cc> No, unless testing includes figuring out OpenGL performace :)
21:23:20  <michi_cc> Have to rebase/update the other PRs first.
21:24:09  <andythenorth> I would test more on mac, but I really like my current savegame
21:24:20  <andythenorth> and testing PRs always ends in the death of a savegame
21:26:50  <glx> how ?
21:27:03  <glx> as long as there's no bump your save is safe
21:27:14  <TrueBrain> as long as you don't save, your save is safe :P
21:27:32  <glx> and mac PRs should not affect the saves anyway
21:27:49  <glx> they don't touch game internals
21:28:19  <andythenorth> 'this savegame is made with a newer version'
21:28:35  <andythenorth> pretty much every time
21:28:40  <glx> oh it's not a nightly save ?
21:28:57  <andythenorth> self compiled master
21:30:04  <glx> unless your build is weird, I don't see an issue if the PR doesn't change savegame version
21:30:41  <andythenorth> dunno, it's happened countless times though :)
21:30:42  <DorpsGek> [OpenTTD/OpenTTD] LordAro opened pull request #8671: Fix #8620: Scale spacing between date & news in history window according to font scaling https://git.io/JtiMR
21:30:42  <glx> of course you can always backup the save before testing
21:30:50  <TrueBrain> I am happy -c does what I expect it to do .. development I now mostly do with -c and a custom config
21:30:57  <TrueBrain> also avoids you setting a weird config to something odd
21:31:00  <TrueBrain> and forgetting about it :P
21:31:15  <andythenorth> it doesn't break the savegame, but if I play 10 years in the PR, then I can't load that save point into master
21:31:20  <andythenorth> usually
21:31:39  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8671: Fix #8620: Scale spacing between date & news in history window according to font scaling https://git.io/JtiMw
21:32:09  <LordAro> fastest TB approval evar :D
21:32:22  <TrueBrain> well, you did all the work for me, so I am really happy :)
21:32:27  <TrueBrain> the screenshots really help
21:32:29  <glx> happens only if the PR bumps savegame version andythenorth I think
21:33:42  <glx> haha I like the RTL sentence LordAro
21:34:08  <LordAro> #8623 & #8624 I think are OGFX "bugs"
21:34:17  <LordAro> glx: i couldn't be bothered with screenshots at that point
21:34:20  <LordAro> linking on windows is slow
21:34:21  *** WormnestAndroid has quit IRC
21:35:03  *** Wormnest has joined #openttd
21:35:14  *** WormnestAndroid has joined #openttd
21:35:33  <LordAro> i don't have an original gfx set to test with on this computer, but i would assume that those are limited to the "correct" height
21:36:04  <glx> hmm I can try to check, I use original files
21:36:44  <LordAro> definitely the same bug, anyway
21:36:57  <LordAro> i'll close one as duplicate and move if it you can confirm it
21:37:35  <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on issue #8625: Inconsistencies with "scoring year" https://git.io/JtBO6
21:38:30  * andythenorth has been ignoring Horse loading speeds for 2 years
21:38:33  <andythenorth> maybe I should fix that
21:38:57  <TrueBrain> LordAro: in that issue is one thing that we can fix
21:39:09  <TrueBrain> there is a year in the highscore list
21:39:24  <LordAro> ah yes
21:39:35  <TrueBrain> and in that PR, document the graphical issue in known-bugs.txt yes :P
21:39:42  <TrueBrain> so not worth anyones time
21:39:54  <TrueBrain> most people never see it, and those that do .. see it once, maybe twice :P
21:41:18  *** frosch123 has quit IRC
21:43:16  *** WormnestAndroid has quit IRC
21:43:33  *** WormnestAndroid has joined #openttd
21:49:57  <DorpsGek> [OpenTTD/OpenTTD] Wuzzy2 commented on issue #8625: Inconsistencies with "scoring year" https://git.io/JtBO6
21:54:34  <DorpsGek> [OpenTTD/OpenTTD] LordAro opened pull request #8672: Fix #8625: Wrong ending year was displayed in highscore table https://git.io/JtiDQ
21:55:17  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8672: Fix #8625: Wrong ending year was displayed in highscore table https://git.io/JtiDd
21:55:26  <TrueBrain> nice :D
21:55:49  <LordAro> adapted from your original comment :)
21:56:20  <TrueBrain> :D
21:57:16  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #8672: Fix #8625: Wrong ending year was displayed in highscore table https://git.io/JtiDp
21:57:35  <michi_cc> orudge: Still around?
21:57:35  <glx> for once TrueBrain OCD failed :)
21:57:57  <LordAro> how did i screw that up?
21:58:16  <glx> dunno, but it's visible in github
21:58:17  <TrueBrain> haha, I did see that, but assumed it was intentional
21:58:18  <LordAro> ah, tab
21:58:47  <DorpsGek> [OpenTTD/OpenTTD] EdisonDD commented on issue #8670: Crash on macOS Big Sur after downloading graphics to 200% https://git.io/JtiPZ
21:59:12  <DorpsGek> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #8672: Fix #8625: Wrong ending year was displayed in highscore table https://git.io/JtiDd
21:59:15  <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #8672: Fix #8625: Wrong ending year was displayed in highscore table https://git.io/JtiDQ
21:59:34  <andythenorth> loading speeds are so boring
21:59:39  <TrueBrain> now glx can approve it if he likes :P
22:00:29  <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #8672: Fix #8625: Wrong ending year was displayed in highscore table https://git.io/JtiyT
22:03:27  <LordAro> glx: you know how to get backtraces out of dmp files - can you look at #8649 ?
22:04:14  <glx> will do
22:07:48  <glx> hmm what's the debug level and type to be sure sprite font is used ?
22:08:25  <glx> oh I could just switch baseset and see if font changes
22:09:18  <LordAro> if it looks super pixelly, it's the sprite font :p
22:11:17  <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on issue #8594: NRT - Pathfinder doesn't consider speed limits when calculating a route https://git.io/JtqIG
22:11:28  <glx> ok confirmed it's OpenGFX
22:11:36  <LordAro> :+1:
22:11:37  <glx> no issue with original
22:11:42  <LordAro> i'll fiddle with issues
22:12:44  <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on issue #8624: Upper-case umlauts don't render properly in manager name https://git.io/JtBku
22:12:44  <glx> even î is sometimes cropped to ï
22:12:47  <DorpsGek> [OpenTTD/OpenTTD] LordAro closed issue #8624: Upper-case umlauts don't render properly in manager name https://git.io/JtBku
22:13:09  <DorpsGek> [OpenTTD/OpenGFX] Wuzzy2 opened issue #53: Upper-case umlauts don't fit into input field https://git.io/JtiyV
22:13:19  <glx> seems character height is incorrectly detected for openGFX
22:14:07  <glx> or if the heigh is fixed for sprite font, then opengfx doesn't respect it
22:14:32  <DorpsGek> [OpenTTD/OpenGFX] LordAro commented on issue #53: Upper-case umlauts don't fit into input field https://git.io/JtiyV
22:15:02  <DorpsGek> [OpenTTD/OpenTTD] LordAro closed issue #8661: Orders not showing correctly in the UI https://git.io/JtrgT
22:15:05  <DorpsGek> [OpenTTD/OpenTTD] LordAro merged pull request #8669: Change: Make order window hotkeys toggle for load & unload variants https://git.io/Jtiol
22:15:21  <DorpsGek> [OpenTTD/OpenTTD] LordAro merged pull request #8672: Fix #8625: Wrong ending year was displayed in highscore table https://git.io/JtiDQ
22:15:24  <DorpsGek> [OpenTTD/OpenTTD] LordAro closed issue #8625: Inconsistencies with "scoring year" https://git.io/JtBO6
22:15:29  <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/JLxK8
22:15:32  <DorpsGek> [OpenTTD/OpenTTD] LordAro merged pull request #8671: Fix #8620: Scale spacing between date & news in history window according to font scaling https://git.io/JtiMR
22:15:35  <DorpsGek> [OpenTTD/OpenTTD] LordAro closed issue #8620: Too little spacing in newslog https://git.io/Jt4yB
22:15:43  <TrueBrain> THE SPAM :P
22:15:54  <LordAro> LOUD NOISES
22:19:19  <LordAro> https://github.com/OpenTTD/OpenTTD/compare/master...LordAro:bug8594 i'm /fairly/ certain that this is a fix for #8594 ... but i have no way to test it and i'm lazy
22:20:00  <LordAro> but that's enough productivity for today
22:20:00  <TrueBrain> :(
22:20:04  * LordAro aways into the night
22:20:04  <TrueBrain> :D
22:20:07  <TrueBrain> it was a good day :)
22:20:20  <LordAro> if i'm lucky, Zorg will give me a savegame
22:20:34  <LordAro> back below 100 issues!
22:20:35  <TrueBrain> only a hand-drawn one, I am afraid
22:23:00  <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/JtiyN
22:23:35  *** Wolf01 has quit IRC
22:23:46  *** Samu has quit IRC
22:24:44  <TrueBrain> I wish GitHub would show how someone resolved a comment
22:24:46  <TrueBrain> that would be easier
22:25:53  * andythenorth considers opening an issue
22:26:10  <LordAro> close one first
22:26:14  <LordAro> thems the rules
22:27:36  *** Wormnest has quit IRC
22:28:12  <TrueBrain> michi_cc: owh, BMP did not refer to bitmap image file, haha, this explains a thing or two :)
22:29:31  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/JtiSY
22:29:59  <TrueBrain> michi_cc: seriously nice work in picking up my comments :D I now understand a lot more what it does :D
22:30:20  <michi_cc> Well, either do it right or go home :P
22:36:33  <DorpsGek> [OpenTTD/OpenTTD] Wuzzy2 commented on issue #8625: Inconsistencies with "scoring year" https://git.io/JtBO6
22:36:58  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #8649: Multiplayer crash https://git.io/JtavV
22:37:18  *** tokai|noir has joined #openttd
22:37:18  *** ChanServ sets mode: +v tokai|noir
22:39:40  *** andythenorth has quit IRC
22:39:47  <Wuzzy> wow, you actually try to keep the  issue count below 100 at all times? mad props!
22:39:58  * Wuzzy tips the hat
22:44:12  *** tokai has quit IRC
22:44:51  <LordAro> Wuzzy: see, i'm just tempted to add "weird things happen if you change ending year backwards during a running game" to the known-issues text :p
22:45:05  <TrueBrain> +1
22:45:10  <orudge> michi_cc: yes, just
22:45:19  <Wuzzy> doesnt neccessarily have to be during a running game
22:45:44  <LordAro> well, whatever
22:45:48  <Wuzzy> play one game, finish in 2051, go main menu, change scoring year to 2020, go highscore, boom
22:45:53  <glx> oh highscore is in the menu
22:46:05  <michi_cc> orudge: #8518 has an artistic question for you  :)
22:46:11  <LordAro> oh yeah...
22:46:28  <Wuzzy> I feel like this feature should have never been added in the first place, its just so much wrong. but i know i will be ignored
22:46:30  <orudge> michi_cc: I see, yes. Will test it out
22:46:30  <LordAro> fine, probably right :p
22:46:45  <LordAro> but i refuse to budge on the 1%
22:46:51  <glx> maybe just drop highscore
22:46:55  <Wuzzy> well how do you know its 1%
22:46:55  <glx> easy fix
22:46:57  <TrueBrain> you are overestimating it LordAro , I am telling you
22:47:15  <LordAro> TrueBrain: the text says "less than 1%" :p
22:47:21  <michi_cc> orudge: Personally I think always using 0.5 as the offset might look just a tiny touch better, but it's a really subtle difference.
22:47:22  <Wuzzy> do really so few players play at least the full 100 years once?
22:47:28  <LordAro> glx: maybe
22:47:47  <glx> most player don't care about the score
22:47:55  <glx> and play as in sandbox
22:49:11  <FLHerne> Take andy's advice and delete years :D
22:49:17  <FLHerne> Who needs 'em?
22:50:19  <Wuzzy> to be fair, the highscore is pretty weird in OpenTTD to begin with. even if that "custom end year" was fully reverted. especially given all those NewGRFs that change gameplay, highscores are hardly comparable anymore
22:50:50  <Wuzzy> but yeah, it is not THAT of a big deal
22:51:00  <glx> and game script can have big impact too
22:51:40  <Wuzzy> i got the full 1000 two or three times now
22:51:41  <supermop_Home_> making a new release of my trams to fix desyncs... any ideas on a better name?
22:52:07  <Wuzzy> TramSync
22:53:51  <supermop_Home_> somehow 'Mop Generic Road Vehicles' just isn't very exciting
22:55:43  <LordAro> i like having the score
22:55:59  <LordAro> bit yeah, the highscore table is fairly useless
22:57:06  *** WormnestAndroid has quit IRC
22:57:25  *** snail_UES_ has quit IRC
22:57:43  *** WormnestAndroid has joined #openttd
22:58:12  <DorpsGek> [OpenTTD/OpenTTD] orudge commented on pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/JtiSN
22:58:21  <orudge> michi_cc: agreed
23:01:16  *** Wormnest has joined #openttd
23:04:43  <supermop_Home_> ok so how does bananas work now? do i sign up for a new account?
23:05:23  <glx> not migrated account yet supermop_Home_ ?
23:06:03  <supermop_Home_> don think so
23:06:21  <supermop_Home_> my GitHub account was just unflagged a few days ago
23:06:36  <glx> https://bananas.openttd.org/manager/user-migration
23:06:36  <supermop_Home_> and the last time i used bananas was probably 2017 or 18
23:13:07  *** snail_UES_ has joined #openttd
23:22:34  <LordAro> i should do that at some point
23:30:57  <supermop_Home_> still unsure about a name
23:31:28  <supermop_Home_> also have little desire to check all covered hopper sprites right now, despite people in forums complaining about them
23:31:46  <supermop_Home_> mostly just want to not desync people
23:35:38  <LordAro> i feel like grfs having the ability to cause desyncs is a bug
23:36:03  *** tokai has joined #openttd
23:36:03  *** ChanServ sets mode: +v tokai
23:38:32  <supermop_Home_> me too
23:38:48  <supermop_Home_> i don't really understand how it happened
23:43:01  *** tokai|noir has quit IRC
23:49:33  <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #8519: [OSX] Render screen in full native resolution on HiDPI displays. https://git.io/JtiHA
23:55:25  <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #8519: [OSX] Render screen in full native resolution on HiDPI displays. https://git.io/JLxK4

Powered by YARRSTE version: svn-trunk