Config
Log for #openttd on 14th February 2021:
Times are UTC Toggle Colours
00:02:33  <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/JLxK8
00:03:15  <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/JtiQE
00:04:17  *** sla_ro|master has quit IRC
00:51:21  *** Wormnest has quit IRC
01:03:31  *** erle- has quit IRC
01:17:53  *** Wormnest has joined #openttd
01:19:43  *** Flygon has joined #openttd
01:47:44  *** Progman has quit IRC
01:54:33  *** tokai|noir has joined #openttd
01:54:33  *** ChanServ sets mode: +v tokai|noir
02:01:16  *** tokai has quit IRC
02:10:26  *** Wormnest has quit IRC
02:36:42  *** iSoSyS has joined #openttd
02:37:00  *** iSoSyS has quit IRC
02:51:58  *** Wormnest has joined #openttd
02:56:11  *** arikover` has quit IRC
03:07:15  *** heffer has joined #openttd
03:33:10  *** D-HUND has joined #openttd
03:36:30  *** debdog has quit IRC
03:38:24  *** HerzogDeXtEr has quit IRC
03:39:50  *** HerzogDeXtEr has joined #openttd
03:40:57  *** HerzogDeXtEr has quit IRC
03:52:21  *** Wormnest has quit IRC
04:14:12  *** glx has quit IRC
05:11:48  *** Wuzzy has quit IRC
06:31:42  *** snail_UES_ has quit IRC
06:33:15  *** gelignite has joined #openttd
06:33:17  *** gelignite has quit IRC
06:57:52  *** nielsm has joined #openttd
07:16:41  *** andythenorth has joined #openttd
07:34:28  *** tokai has joined #openttd
07:34:28  *** ChanServ sets mode: +v tokai
07:41:16  *** tokai|noir has quit IRC
07:43:50  *** tokai|noir has joined #openttd
07:43:50  *** ChanServ sets mode: +v tokai|noir
07:50:56  *** tokai has quit IRC
08:20:06  *** jottyfan has joined #openttd
08:27:21  *** andythenorth has quit IRC
08:31:49  *** andythenorth has joined #openttd
08:36:57  *** Wolf01 has joined #openttd
08:44:27  *** supermop_Home_ has quit IRC
09:04:39  <DorpsGek> [OpenTTD/OpenTTD] orudge commented on pull request #8519: [OSX] Render screen in full native resolution on HiDPI displays. https://git.io/JtPYI
09:07:29  *** Progman has joined #openttd
09:21:15  *** sla_ro|master has joined #openttd
09:46:47  *** Progman has quit IRC
09:50:04  <andythenorth> moin
10:07:43  *** HerzogDeXtEr has joined #openttd
10:21:54  <TrueBrain> LordAro: did we have certbot running on the BaNaNaS VPSes?
10:24:33  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8519: [OSX] Render screen in full native resolution on HiDPI displays. https://git.io/JtP3C
10:25:16  <TrueBrain> hmm, it should .. but .. the certs are not renewed yet
10:25:19  <TrueBrain> they should already have been
10:25:50  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/JtP3l
10:26:39  <TrueBrain> All renewal attempts failed. The following certs could not be renewed:
10:26:58  <TrueBrain> Attempting to renew cert (bananas-2.cdn.openttd.org) from /etc/letsencrypt/renewal/bananas-2.cdn.openttd.org.conf produced an unexpected error: Problem binding to port 80: Could not bind to IPv4 or IPv6.. Skipping.
10:27:13  <TrueBrain> of course it cannot, as nginx is listening there
10:27:41  <TrueBrain> LordAro: any ideas?
10:27:48  <LordAro> hmm
10:28:01  <LordAro> i'm not super experienced with certbot
10:28:27  <TrueBrain> that makes two of us
10:28:34  <TrueBrain> I assumed that this geerlingguy had this figured out :P
10:28:47  <LordAro> there's probably a "use existing webserver" mode, and we'll need to point nginx at the well-known dir
10:29:09  <TrueBrain> https://github.com/geerlingguy/ansible-role-certbot#standalone-certificate-generation
10:29:24  <TrueBrain> I think I deserve my search certificate \o/ :D
10:29:35  <TrueBrain> I am always happy that if I search on the web for stuff, I manage to find stuff
10:29:36  <TrueBrain> that is rare
10:29:41  <TrueBrain> so I have to celibrate :D
10:30:18  <LordAro> heh
10:33:28  <TrueBrain> hmm, but in his own example playbook, he doesn't use that
10:33:29  <TrueBrain> odd
10:33:59  <TrueBrain> https://github.com/geerlingguy/ansible-role-certbot/blob/master/molecule/default/playbook-standalone-nginx-aws.yml#L96 <- seems to be solving it differently
10:36:09  <TrueBrain> owh, but we also don't have the default nginx blobs .. certbot normally generates a small nginx snippet
10:36:13  <TrueBrain> but that is not there either
10:37:20  <TrueBrain> I never really looked into how certbot does what it he does, honestly :P
10:37:41  <TrueBrain> but I guess that we disable the default vhosts has something to do with it
10:37:42  <TrueBrain> not sure
10:38:35  <_dp_> lol, just looked at my "highscore" table for the first time: https://i.imgur.com/qFocl80.png
10:39:14  <_dp_> you can tell how much I care when I don't know who is that on #1 and #2 is a server company xD
10:41:01  <LordAro> TrueBrain: no, default vhost is just replacing it with our own
10:41:24  <TrueBrain> but what I know from certbot, that it normally does something in a vhost to get the letsencrypt traffic
10:41:29  <TrueBrain> so that might be related here?
10:41:32  <TrueBrain> I really do not know :D
10:41:42  <TrueBrain> I know certbot can work via nginx, but .. it is a bit of magic to me :(
10:49:01  <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/JLxK8
10:50:17  <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #8519: [OSX] Render screen in full native resolution on HiDPI displays. https://git.io/JtPsy
10:50:21  <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #8519: [OSX] Render screen in full native resolution on HiDPI displays. https://git.io/JLxK4
10:50:27  <Eddi|zuHause> _dp_: i'm pretty sure i never reached 2051
10:51:51  * andythenorth fetches
11:04:30  <Wolf01> I did, left the game in FF and forgot about it, I even managed to win
11:04:40  <andythenorth> it's interesting what 8518 / 8519 change
11:06:35  <andythenorth> the window highlight / shading lines are all substantially smaller
11:06:46  <andythenorth> oh the mouse isn't working reliably, that's interesting
11:06:54  <andythenorth> can't click UI elements
11:09:58  <andythenorth> seems intermittent
11:10:10  <LordAro> TrueBrain: i think adding the relevant --pre-hook & --post-hook commands "will do"
11:10:26  <TrueBrain> LordAro: but normally you don't have to shut down nginx to renew certs
11:10:29  <TrueBrain> that is what is odd to me :P
11:10:31  <LordAro> assuming we want to go for "turn off nginx while certificate is renewed" method
11:10:33  <LordAro> which, yeah
11:10:45  <TrueBrain> I believe letsencrypt only wants to be able to read a certain file
11:10:51  <michi_cc> andythenorth: I've just checked in case I did some rebase/merge messup, but I can't reproduce that.
11:11:07  <andythenorth> I'll need to dig some more, see if I can find a trigger
11:12:18  <TrueBrain> LordAro: location /.well-known/acme-challenge, is the location it wants to read
11:12:40  <LordAro> yeah
11:12:43  <TrueBrain> what some people do, is upstream proxy that in nginx, and set certbot on another port
11:12:48  <TrueBrain> https://dev.to/joelaberger/no-magic-letsencrypt-certbot-and-nginx-configuration-recipe-3a97 as example
11:12:56  <LordAro> location /.well-known/acme-challenge/ { alias /srv/lordaro.co.uk/.well-known/acme-challenge/; }
11:13:01  <LordAro> is what i have on my webserver
11:13:09  <TrueBrain> that sounds more sane
11:13:13  <TrueBrain> than upstream to certbot :P
11:13:24  <LordAro> mm
11:13:38  <LordAro> need to find the options to certbot to stop it trying to use port 80 though
11:14:25  <LordAro> `--webroot -w /srv/foobar`
11:14:27  <LordAro> apparently
11:15:33  <LordAro> or, looking at what my own cronjob is doing, set it in the relevant config file properly
11:15:41  <andythenorth> michi_cc is the setting _allow_hidpi_window ?
11:15:47  <LordAro> now... how to do all that with ansible...
11:16:20  <michi_cc> andythenorth: That's in the code, it should be allow_hidpi under [misc] in the config file.
11:16:20  * andythenorth thinks it might be allow_hidpi
11:17:35  <andythenorth> something is awry when changing UI or font zoom, they only update partially until the client is restarted
11:18:16  <andythenorth> ok mouse clicks are gone, it's not specific to being in hdpi mode
11:18:34  <andythenorth> the map still pans/scrolls on mouse, so it's not all mouse gone
11:18:50  <andythenorth> windowshade still works on scrolling a window title bar
11:19:18  <Wolf01> andythenorth: maybe in retina displays mouse clicks work once every 4 pixels or whatever :D
11:19:56  <andythenorth> seems so far like it's an elapsed time thing
11:24:40  <andythenorth> not happening in title game / world gen menu
11:24:58  <michi_cc> You'll have to go back to see which merge did that I think as I absolutely can't see that.
11:25:37  <andythenorth> it might relate to scrolling the map
11:25:47  <andythenorth> is it possible that clicks are trapped by scroll and not released?
11:26:11  <andythenorth> scroll seems to be the trigger so far, best guess
11:26:25  <michi_cc> Which scroll mode?
11:27:28  <andythenorth> "Move viewport with RMB, mouse position locked"
11:27:43  <andythenorth> ah
11:28:03  <andythenorth> if I try and scroll the map in title game (obviously doesn't work) then mouse clicks are subsequently eaten
11:28:21  <andythenorth> seems like: scroll, 1 subsequent mouse click handled, rest eaten
11:28:37  <michi_cc> Real RMB or Cmd+LMB?
11:28:49  <andythenorth> and if I use the 1 click on a dropdown, the dropdown stays open
11:28:53  <andythenorth> cmd
11:28:57  <andythenorth> but let me try RMG
11:28:59  <andythenorth> RMB
11:29:06  <michi_cc> It might actually be a OTTD bug in that case as it might not properly clear the fix at mode.
11:29:57  <andythenorth> ok so an actual mac RMB (two-finger trackpad click) seems to work fine
11:31:14  <michi_cc> Okay, reproduced.
11:31:35  <michi_cc> Bah, I messed up :(
11:33:45  <andythenorth> who doesn't? :)
11:36:53  *** frosch123 has joined #openttd
11:37:17  <DorpsGek> [OpenTTD/OpenTTD] michicc opened pull request #8673: Fix 9c872192: [OSX] Clear mouse button emulation flag. https://git.io/JtPGj
11:38:06  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8673: Fix 9c872192: [OSX] Clear mouse button emulation flag. https://git.io/JtPZv
11:40:39  <frosch123> aw, i was hoping you would kill the highscore/endyear completely :)
11:40:56  <andythenorth> :)
11:41:03  <andythenorth> also inflation :P
11:41:20  * andythenorth anticipates starting the game in 2022 with 15 newgrfs warning about inflation :)
11:41:41  <andythenorth> 'social deprecation tactics'
11:41:54  <frosch123> newgrf added warnings about that? :p
11:42:23  <frosch123> well, there have been warnings about plane speed factor before, so i guess no surprise
11:45:13  *** tokai has joined #openttd
11:45:13  *** ChanServ sets mode: +v tokai
11:47:34  *** Progman has joined #openttd
11:52:06  *** tokai|noir has quit IRC
11:53:35  *** tokai|noir has joined #openttd
11:53:36  *** ChanServ sets mode: +v tokai|noir
11:58:49  <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #8673: Fix 9c872192: [OSX] Clear mouse button emulation flag. https://git.io/JtPGj
12:00:25  *** tokai has quit IRC
12:01:26  <andythenorth> confirmed fixed
12:07:21  <andythenorth> so many macos changes in commit log :)
12:16:14  <andythenorth> michi_cc TL;DR results so far
12:16:32  <andythenorth> - I've turned HiDPI off, it drops game speed to about 0.95x
12:16:52  <andythenorth> - (without HiDPI) I can use full animation again
12:16:57  <andythenorth> - FFWD works
12:17:16  <andythenorth> - CPU use seems to be reduced in some cases and increased in others
12:17:50  <andythenorth> - 'idle, game paused' is about 10% now, previously 6-7%
12:18:21  <andythenorth> - during gameplay CPU use is maybe 50-60% on average, previously 80-100% (with full animation off)
12:19:40  * andythenorth watches the steel mill fire cycle animations for days
12:19:49  <michi_cc> HiDPI: expected; idle: no idea, but I changed some APIs around; rest: sounds quite okay
12:20:18  <andythenorth> seems like a result to me
12:20:24  <michi_cc> Though compared to the results orudge gave on OGL, your video baselines seems to be quite bad.
12:20:54  <andythenorth> intel mac baselines are very bad compared to M1
12:21:23  <andythenorth> and mine seems to be particularly bad, it has both integrated and discrete GPU, and switches between them
12:21:28  <andythenorth> which seems to have issues
12:21:57  <andythenorth> I have many other general display / screen paint issues on this mac, which I've never seen on the ones with integrated intel GPUs
12:22:27  <andythenorth> we have an M1 here, so once we have a build I can get numbers for that
12:22:52  <andythenorth> got a couple of integrated GPU macs as well, I'll try
12:26:37  <andythenorth> how do I build a mac binary?
12:26:39  <andythenorth> some cpack thing?
12:27:37  <andythenorth> just 'cpack'?
12:29:51  <andythenorth> michi_cc the 13" macbook pro with intel integrated GPU is getting much HiDPI higher frame rate than mine
12:30:16  <andythenorth> fewer pixels to draw overall, but maybe a better pipeline to the screen in hardware also
12:30:32  <michi_cc> Yes, just cpack should produce output in  the bundle subdir.
12:31:09  <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #8537: Feature: Automatic UI and font zoom levels. https://git.io/JLpSS
12:33:43  <andythenorth> ok for roughly equivalent maps, (both newgame), both in corner of map, same zoom level
12:34:02  <andythenorth> 13" macbook pro, ffwd: consistent 23x
12:34:23  <andythenorth> 16" macbook pro, ffwd: consistent 10x
12:36:22  <andythenorth> with full animation off
12:37:18  <andythenorth> 13" macbook pro, ffwd: very unstable 200-400x
12:37:39  <andythenorth> 16" macbook pro, ffwd: very unstable 300-600x
12:38:14  <andythenorth> having an animated FIRS industry on the screen cuts the rate by a factor of 10 :P
12:38:15  <andythenorth> oof
12:38:56  <michi_cc> Also, the faster the speedup, the more you see external OS events in the rate I guess.
12:39:20  <Eddi|zuHause> andythenorth: you can provide a game seed so you get the exact same map instead of "roughly equivalent"
12:39:33  <andythenorth> Eddi|zuHause thanks :)
12:41:06  <Eddi|zuHause> not sure if that's a "stop telling me things that i already know"-semi-polite "thanks"
12:41:28  *** tokai has joined #openttd
12:41:28  *** ChanServ sets mode: +v tokai
12:42:18  <andythenorth> kinda, but often you tell me things I don't know
12:42:22  <andythenorth> so don't stop
12:43:14  <andythenorth> michi_cc on the 13" mac, HiDPI false, full animation on, ffwd is about 40x over an area of sea, compared to 1.10-RC1 which does about 4x
12:45:12  <Wolf01> Hmmm force removing VS2013/2015, 2 hours have passed and still doing stuff
12:45:27  <Eddi|zuHause> anyone fixed the crash in diagonal crossings yet?
12:45:59  <Eddi|zuHause> Wolf01: might have been faster to install a fresh windows :p
12:46:07  <Wolf01> Yes
12:48:25  *** tokai|noir has quit IRC
12:52:18  <andythenorth> the only concern I have is about HiDPI on by default
12:52:54  <andythenorth> turning that on masks the huge other performance improvements
12:53:17  <andythenorth> I don't play many mac games, but none of them run HiDPI, whether 3D rendered or 2D bitmap
13:04:10  *** Samu has joined #openttd
13:05:58  <TrueBrain> michi_cc: ieuw, floatssssss :P I like what you did with the automatic zoom PR :)
13:06:04  <TrueBrain> looks really clean now :)
13:07:41  <TrueBrain> even fixed the unneeded reloading, w00p
13:08:59  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8537: Feature: Automatic UI and font zoom levels. https://git.io/JtPc9
13:10:32  <DorpsGek> [OpenTTD/OpenTTD] Milek7 opened pull request #8674: Fix: VkMapping declarations violated C++ ODR rule. https://git.io/JtPcb
13:14:23  <Eddi|zuHause> i should time building openttd at some point. i think it's going towards 10 minutes
13:16:01  <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8674: Fix: VkMapping declarations violated C++ ODR rule. https://git.io/JtPCf
13:16:43  <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #8537: Feature: Automatic UI and font zoom levels. https://git.io/JLpSS
13:16:54  <michi_cc> TrueBrain: PRs are cheap :)
13:19:20  *** Progman has quit IRC
13:31:44  <Eddi|zuHause> real    5m6,139s
13:31:46  <Eddi|zuHause> user    10m29,992s
13:31:47  <Eddi|zuHause> sys     0m51,316s
13:32:01  <Eddi|zuHause> well, 5 minutes is almost 10 minutes, right? :p
13:32:11  *** Wuzzy has joined #openttd
13:35:34  <Wuzzy> This OpenSFX PR will clear up the license mess and is ready for review: https://github.com/OpenTTD/OpenSFX/pull/14
13:40:37  *** APTX_ has joined #openttd
13:41:10  *** APTX has quit IRC
13:43:34  <milek7> Eddi|zuHause: debug or release?
13:43:42  <Eddi|zuHause> release
13:44:08  <Eddi|zuHause> i'm going to assume linking is single-thread
13:44:21  *** APTX has joined #openttd
13:45:18  <milek7> LTO makes it slow
13:45:20  <Eddi|zuHause> which will be the main bottleneck on a release build
13:45:32  <milek7> but still, 5m is rather slow
13:45:45  <Eddi|zuHause> well. it is a 10 year old computer :p
13:45:50  <milek7> real	0m52,587s
13:48:07  <Eddi|zuHause> i should learn how to do breakpoints in gdb
13:48:23  <Eddi|zuHause> because at the point of crash all the useful information is already gone
13:50:41  *** APTX_ has quit IRC
13:53:42  <milek7> rr is great in such situations
13:53:52  <milek7> https://rr-project.org/
13:54:13  <milek7> it requires relatively modern cpu, though
13:57:01  <FLHerne> Wuzzy: The updated license text doesn't mention CC0 or CC BY non-SA, but there are still links further down
13:57:05  <FLHerne> Are those still needed?
13:57:17  <FLHerne> (in #14)
13:57:37  <Wuzzy> yes, because CC0 and CC BY are mentioned in the sound list
13:57:50  <Eddi|zuHause> "rr needs /proc/sys/kernel/perf_event_paranoid <= 1, but it is 2."
13:57:53  <Wuzzy> there's a list of origin sounds
13:59:19  <FLHerne> Oh right, found it
13:59:36  <Eddi|zuHause> [FATAL /home/abuild/rpmbuild/BUILD/rr-5.3.0/src/PerfCounters.cc:247:get_cpu_microarch()] AMD CPUs not supported.
13:59:43  <Eddi|zuHause> yeah, so no.
14:00:56  <milek7> yeah, for AMD it only works since Zen
14:01:43  <FLHerne> Wuzzy: You've updated the links to source repo and bug tracker, but not 5.0 Acknowledgements where it says "Thanks go out to the guys at #openttdcoop for providing the source repository and bug tracking services." ;-)
14:02:14  <Wuzzy> hmmm
14:02:26  <Wuzzy> but #openttdcoop still seems to exist
14:02:30  <Wuzzy> what should it be replaced with?
14:02:32  <FLHerne> Not sure if remove that, or switch to thanking TrueBrain, or change it to "former" *and* thank TrueBrain :p
14:02:52  <Wuzzy>  /join #openttdcoop
14:02:58  <FLHerne> Well, the current hosting is on OTTD's GitHub
14:03:28  <TrueBrain> I was about to say, I have little to do with providing source or bug repo :P But I do appreciate it ;)
14:03:32  <FLHerne> openttdcoop still exists, but devzone doesn't
14:03:54  <FLHerne> TrueBrain: Isn't it your fault everything is on GitHub? :D
14:04:02  <FLHerne> Well, it does, but it's dead
14:04:05  <TrueBrain> fault, yes
14:04:11  <TrueBrain> that needs no thanking :D
14:05:24  <FLHerne> Wuzzy: OpenSFX used to live here, hence the acknowledgement https://dev.openttdcoop.org/projects/opensfx
14:05:51  <Wuzzy> what should it be replaced with then?
14:06:18  <Wuzzy> i think the acklowledgement is still technically valid, even if OpenTTDCoop is functionally dead today. history, basically
14:06:27  <FLHerne> I'd be tempted to just delete it, but that might be uncharitable :p
14:07:06  <TrueBrain> we also no longer thank the list of old providers that hosted openttd.org :P
14:07:18  <TrueBrain> it is a bit silly to do so, honestly
14:08:06  <FLHerne> If you want to keep it, "...providing the <former/original?> source repository....   , and to TrueBrain <et al.?> for supporting the move to GitHub."
14:08:30  <TrueBrain> I did not move OpenSFX to GitHub
14:09:08  <TrueBrain> (supporting, sure, the real move, no)
14:09:18  <TrueBrain> but I also see no point in thanking me for any of that, honestly
14:09:25  <Wuzzy> I guess I just remove the entire acknowledgement section then...
14:09:42  <Wuzzy> is that ok?
14:14:36  *** glx has joined #openttd
14:14:36  *** ChanServ sets mode: +v glx
14:53:45  <DorpsGek> [OpenTTD/BaNaNaS] frosch123 opened pull request #81: Change: migrate OpenTTD user supermop to GitHub user supermop https://git.io/JtP81
14:54:05  <DorpsGek> [OpenTTD/BaNaNaS] TrueBrain approved pull request #81: Change: migrate OpenTTD user supermop to GitHub user supermop https://git.io/JtP8M
14:54:39  <DorpsGek> [OpenTTD/BaNaNaS] TrueBrain merged pull request #81: Change: migrate OpenTTD user supermop to GitHub user supermop https://git.io/JtP81
14:57:37  <FLHerne> Wuzzy: Most of the core openttdcoop people of that time are in the SFX credits anyway
14:58:26  <FLHerne> No, not really
14:58:37  <FLHerne> But Rubidium and Zephyris are
14:58:40  <glx> I quickly tested opensfx#19 in my debian VM, it doesn't work
15:09:34  *** iSoSyS has joined #openttd
15:17:08  <DorpsGek> [OpenTTD/OpenSFX] Wuzzy2 updated pull request #14: Change readme, license, descriptions  https://git.io/JtrZp
15:22:33  <Wuzzy> FLHerne: I just went updated the readme for the PR by removing the acknowledgements
15:22:47  <Wuzzy> is there anything else that needs addressing?
15:25:17  <Eddi|zuHause> _dp_: so i think i found the issue. i call "RoadBitsToAxis(road)" which will fail on halftile roads
15:25:56  *** Progman has joined #openttd
15:25:57  <Eddi|zuHause> must extend that to a full tile road first, or something
15:28:07  <_dp_> regular crossings extend half-tiles
15:28:12  <_dp_> all other stuff removes them though
15:28:55  *** Flygon has quit IRC
15:31:36  <Eddi|zuHause> yes. the question is how to do this elegantly
15:31:40  <Eddi|zuHause> code-wise
15:33:31  <Eddi|zuHause> the old code used the track direction not the road direction for this, so it circumvented the issue
15:35:49  <Eddi|zuHause> i'm not sure why this issue wasn't in the old patch
15:36:34  <Eddi|zuHause> i think it had stricter checks that made it discard the halftile road
15:38:53  <Wolf01> Destroy the road bit or complete the road?
15:40:26  <Eddi|zuHause> yeah, i think master behaviour changed in the last 15 years
15:41:14  <Wolf01> I remember both cases, but not which one is the current
15:41:47  <Wolf01> I would try to complete the road, because it's not fair to destroy a road bit of a competitor for example
15:42:00  <Eddi|zuHause> well, apparently extending it is the new way :p
15:43:50  <Eddi|zuHause> "beginning with GCC 10, when using just -flto it will default to using the detected number of CPU cores/threads available rather than just a single thread."
15:44:12  <Eddi|zuHause> > gcc --version
15:44:14  <Eddi|zuHause> gcc (SUSE Linux) 7.5.0
15:44:19  <Eddi|zuHause> hm...
15:45:28  <Eddi|zuHause> do i want to go through the trouble of installing a newer gcc?
15:46:32  <Eddi|zuHause> i could also look for the parameter to pass for setting the number of threads manually
15:49:46  <FLHerne> Wuzzy: misc. nitpicking thoughts...
15:49:59  <Wuzzy> I listen
15:50:27  <FLHerne> "Freely available under the terms of the following licenses" in the description is a bit unclear, maybe add [for sound files] and [for code]
15:50:45  <FLHerne> [for code and docs] even
15:51:23  <FLHerne> Might be easier to read, and more maintainable, to have a separate file for each of the license texts
15:51:31  <DorpsGek> [OpenTTD/OpenTTD] Eddi-z updated pull request #8556: Feature: Allow diagonal tracks on level crossings https://git.io/JtebC
15:52:14  <FLHerne> (that way it'll be more obvious if you copy-paste one license into the middle of another, and also you wouldn't have to :p)
15:52:27  <FLHerne> Hm, but then OTTD doesn't display it nicely
15:53:13  <FLHerne> So probably ignore that idea
15:53:30  <DorpsGek> [OpenTTD/OpenTTD] Eddi-z commented on pull request #8556: Feature: Allow diagonal tracks on level crossings https://git.io/JtPBH
15:55:06  <FLHerne> "Freely available under the Creative Commons Attribution-ShareAlike 3.0 Unported license [for sound files] and your choice of the GNU General Public License version 2 (or later) or Common Development and Distribution License 1.1 [for code and documentation]" ?
15:55:51  <FLHerne> It does seem a pity to delete all the translations, but I don't have a better idea
15:56:09  *** egork has joined #openttd
15:56:25  <FLHerne> (and thanks for doing this, it's been needed for years)
15:58:32  <Eddi|zuHause> could make an announcement on the forums to request new translations
16:00:27  <egork> hello! is there an external map editor (not only a height map) where I could overlay a google map and lay out roads or rails?
16:00:42  <Eddi|zuHause> egork: no
16:01:22  <Eddi|zuHause> there was a proposal for an extended heightmap format that can add roads, but it was never implemented
16:02:31  <andythenorth> hmm so vehicle customisation when? :P
16:04:08  <egork> thank you Eddi
16:05:19  *** gelignite has joined #openttd
16:09:29  <DorpsGek> [OpenTTD/OpenTTD] Eddi-z updated pull request #8556: Feature: Allow diagonal tracks on level crossings https://git.io/JtebC
16:09:30  <glx> Wuzzy: can I force push to your opensfx#19 branch ?
16:09:34  *** egork has quit IRC
16:10:30  <Wuzzy> what do you want to push?
16:10:53  <glx> some fixes in Makefile, and I added workflow files
16:11:06  <glx> (not fully working yet)
16:11:34  <Wuzzy> ehhh, makefile fixes... better not
16:11:40  <Wuzzy> at least not for  #14
16:11:45  <Wuzzy> oh wait...
16:12:08  <Wuzzy> feel free to push, but i feel very stressed by the thought of FORCEpush
16:12:46  <Wuzzy> push things that work. dont push things that do not work
16:12:59  <Eddi|zuHause> Wuzzy: doesn't make much of a difference. you need to pull either way
16:13:17  <Wuzzy> i know, but force push is danger zone
16:13:34  <Eddi|zuHause> force push is the default way of updating PRs
16:13:41  <glx> force push is the usual way for PRs
16:13:48  <Wuzzy> just do a normal push. i dont care about "clean commit history" .. . this is a dangerous ideology
16:14:03  <glx> but I rebased, so push won't work
16:14:09  <Wuzzy> sigh
16:14:27  <Wuzzy> in that case i have to disapprove
16:15:16  <Eddi|zuHause> in that case, the next step would be to PR his branch on his repo :)
16:15:49  <Wuzzy> force-push is dangerous when multiple people are involved
16:16:03  <glx> well I already have it https://github.com/glx22/OpenSFX/pull/1
16:16:23  <Wuzzy> if you are really obsessed with "clean commit history" BS, at least do it whe everythig has settled, and not right from the start, when its hard to track your changes
16:16:24  <Eddi|zuHause> well, force-push is only dangerous when people aren't talking to each other
16:16:39  <glx> that's why I asked
16:17:15  <Wuzzy> can you produce a diff, maybe? that would be better
16:17:49  <Wuzzy> i thik the .workflow thing warrants its own PR...
16:17:58  <Wuzzy> but then, given the long review waiting time... lol
16:18:16  <andythenorth> some people have been taught that force push is bad
16:18:17  <glx> workflow helps to test the makefile changes
16:18:22  <andythenorth> some people have to get over that
16:18:44  <Wuzzy> i dont want to blindly accept a force-push from a stranger on my own PR
16:18:55  <glx> Wuzzy: feel free to sherry pick my commits then
16:19:20  <Wuzzy> can you produce a patchfile?
16:19:25  <Wuzzy> that would be best
16:19:30  <TrueBrain> "stranger" .. saying that about a developer that is trying to help .. lol
16:19:59  <Wuzzy> ok that was harsh.
16:20:02  <TrueBrain> yup
16:20:05  <TrueBrain> :D
16:20:14  <Wuzzy> but technically we're all strangers to each other
16:20:24  <Wuzzy> more or less... anywaay
16:20:54  <Wuzzy> glx: i would appreciate if you could just tell me what bugs i introduced into my makefile so i can fix them
16:23:59  <glx> Wuzzy: https://github.com/OpenTTD/OpenSFX/blob/b74c3d8f4ccb82e86a27ca55fceba2d21979da04/Makefile#L152 <-- this line errors when I try in my debian VM (unterminated shell call, missing ")")
16:24:28  *** tokai|noir has joined #openttd
16:24:28  *** ChanServ sets mode: +v tokai|noir
16:24:37  <glx> my solution is to use the same way as in all other openttd repos https://github.com/glx22/OpenSFX/pull/1/commits/1c825af5e4278bca28ecb36d61394acc7223a203
16:24:49  <glx> our good old findversion.sh
16:26:40  <Wuzzy> is that the only bug?
16:27:21  <glx> well there seem to be more, as workflow fail, but I didn't check in detail
16:27:32  <Wuzzy> my issue with you using force-push / premature rebase is that I dont get a diff out of it 🙁 this makes analysis more painful
16:27:39  <Wuzzy> but ok i try to look at it
16:28:29  <glx> I didn't touch your commits (except rewording commit messages so commit checker is happy)
16:30:06  <glx> other solution is you can rebase your PR (and fix commit messages) then I can push without force my changes
16:30:24  <glx> if it's cleaner for you
16:31:16  *** tokai has quit IRC
16:32:48  <Wuzzy> wait, what??? it turns out your makefile is identical wih mine!!!!!!
16:33:17  <glx> can't be identical, I added a change
16:34:05  *** tokai has joined #openttd
16:34:05  *** ChanServ sets mode: +v tokai
16:34:32  <Wuzzy> oops i looked at wrong file lol
16:35:46  *** tokai|noir has quit IRC
16:47:28  <DorpsGek> [OpenTTD/OpenSFX] Wuzzy2 updated pull request #19: Replace Mercurial code with Git code https://git.io/JtrPG
16:47:45  <Wuzzy> glx: i have pushed your changes ... by hand. i hope its correct
16:50:48  <Wuzzy> glx: thank you for working on the .workflow btw. but it needs to be seen if it actually works... 😀
16:51:04  <Wuzzy> the .workflow will be important for release
16:51:09  <glx> can't work because you need to rebase
16:51:17  <glx> there's a conflict
16:51:43  <Wuzzy> This PR needs to wait for #14
16:52:08  <glx> and for some weird reason github doesn't recognise me as author
16:52:45  <Wuzzy> thats because i put "unknown@unknown.invalid" as email 😆
16:53:16  <glx> oh, use my openttd email then, glx@
16:53:26  <Wuzzy> glx@ ... what?
16:53:33  <Wuzzy> @ nothing?
16:53:34  <glx> openttd.org
16:53:54  <LordAro> glx: is there any particular reason you're not PRing the workflow stuff yourself?
16:54:11  <glx> workflow can't work without makefile fixes
16:54:39  <Wuzzy> becaue reviewing takes forever so glx is trying to shoehorn as many things into one PR in the hopes it'll get done sooner?
16:54:44  <glx> so it seems to be a good idea to do both at the same time
16:55:09  <glx> as workflow will help to test makefile changes
16:58:26  <DorpsGek> [OpenTTD/OpenSFX] Wuzzy2 updated pull request #19: Replace Mercurial code with Git code https://git.io/JtrPG
16:58:48  <Wuzzy> I want #14 to be merged first, before continuing with #19
16:59:11  <Wuzzy> one PR after the other
17:00:02  <Wuzzy> glx: your opinion on #14?
17:31:36  *** snail_UES_ has joined #openttd
17:40:47  *** Wormnest has joined #openttd
17:59:55  *** supermop_Home has joined #openttd
18:08:23  <supermop_Home> thanks for setting up my bananas account
18:19:58  <supermop_Home> when was the town can build flag added for roads?
18:20:15  <supermop_Home> want to make sure i set the minimum version for unspooled correctly
18:21:25  <glx> 1.10 I guess
18:26:26  *** jottyfan has quit IRC
18:30:19  <supermop_Home> oops
18:30:40  <supermop_Home> i uploaded the old version without town build flags after the new version
18:31:02  <supermop_Home> so now version 3.2 is new game available, and 4.2 is save games only
18:33:16  *** Eddi|zuHause2 has joined #openttd
18:34:32  <glx> I think you can edit the settings
18:35:06  <frosch123> you can only flip the upload order via PR
18:37:05  *** Eddi|zuHause has quit IRC
18:38:58  *** HerzogDeXtEr has quit IRC
18:42:55  <glx> funny first upload puts description and tags in global, second upload puts them in versions
18:43:35  <frosch123> yes, the gui is bad :) people don't get they can skip the details on second upload
18:44:24  <frosch123> all the version-specific stuff if not needed, when identical with global
18:49:21  <andythenorth> one day we will improve it :)
18:52:31  <glx> something like https://github.com/OpenTTD/BaNaNaS/compare/master...glx22:44450601 ?
19:01:17  <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/JtP2Q
19:01:18  <DorpsGek>   - Update: Translations from eints (by translators)
19:13:13  <supermop_Home> so i can just upload version 4.2 again to fix it?
19:13:47  <_dp_> can someone fix #7941 please?
19:14:04  <_dp_> pathfinder is one of the few places left that I haven't touched yet and I don't want to start :p
19:16:23  *** tokai|noir has joined #openttd
19:16:23  *** ChanServ sets mode: +v tokai|noir
19:18:01  <LordAro> seems very difficult to fix
19:18:08  <LordAro> at first glance of the issue
19:18:18  <_dp_> yeah, it's kinda tricky
19:19:21  <frosch123> glx: yes, unless you also want to fake the upload dates. i.e. you can also swap md5sum-partial and filesize between the entries
19:19:35  <frosch123> plus version name
19:20:14  <frosch123> but ok, too complicated :) leave it at this
19:23:26  *** tokai has quit IRC
19:27:20  *** tokai has joined #openttd
19:27:20  *** ChanServ sets mode: +v tokai
19:34:11  *** tokai|noir has quit IRC
19:41:08  *** jottyfan has joined #openttd
19:42:42  *** jottyfan has quit IRC
19:50:46  *** tokai|noir has joined #openttd
19:50:46  *** ChanServ sets mode: +v tokai|noir
19:57:42  *** tokai has quit IRC
20:01:07  *** tokai has joined #openttd
20:01:07  *** ChanServ sets mode: +v tokai
20:08:07  *** tokai|noir has quit IRC
20:20:31  *** snail_UES_ is now known as Guest13193
20:20:32  *** snail_UES_ has joined #openttd
20:22:25  <glx> I can't open pull requests anyway
20:24:11  <frosch123> why? were you also banned from github? like supermop
20:27:22  <glx> ah no it's only for this repo it seems
20:28:42  <glx> oh silly me, missing title
20:29:03  <DorpsGek> [OpenTTD/BaNaNaS] glx22 opened pull request #82: Fix: newgrf/44450601 versions uploaded in the wrong order https://git.io/JtPw5
20:29:14  *** snail_UES_ has quit IRC
20:29:33  *** snail_UES_ has joined #openttd
20:29:56  <glx> usually github picks the commit message as title
20:32:05  *** tokai|noir has joined #openttd
20:32:05  *** ChanServ sets mode: +v tokai|noir
20:34:00  <DorpsGek> [OpenTTD/BaNaNaS] frosch123 approved pull request #82: Fix: newgrf/44450601 versions uploaded in the wrong order https://git.io/JtPrm
20:34:45  <DorpsGek> [OpenTTD/BaNaNaS] frosch123 merged pull request #82: Fix: newgrf/44450601 versions uploaded in the wrong order https://git.io/JtPw5
20:38:08  <glx> oh of course the website still considers 0.3.2 to be newer
20:38:51  *** tokai has quit IRC
20:40:34  <DorpsGek> [OpenTTD/OpenTTD] ldpl commented on pull request #8556: Feature: Allow diagonal tracks on level crossings https://git.io/JtPrE
20:40:43  <frosch123> amazingly it works in-game though :)
20:40:53  <frosch123> i doubt we ever tested that
20:42:28  <glx> as long as it works in-game it's fine
20:54:16  *** WormnestAndroid has quit IRC
20:54:36  *** tokai has joined #openttd
20:54:36  *** ChanServ sets mode: +v tokai
20:55:25  *** tokai has quit IRC
20:57:32  *** WormnestAndroid has joined #openttd
21:01:31  *** tokai|noir has quit IRC
21:19:35  *** nielsm has quit IRC
21:38:06  <DorpsGek> [OpenTTD/OpenTTD] J0anJosep updated pull request #8480: Multitile depots https://git.io/JL5Hh
21:42:46  <supermop_Home> thanks for fixing guys
21:44:00  *** gelignite has quit IRC
21:55:07  *** Samu has quit IRC
22:09:04  <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #8452: Doc: Add labels to landscape grid description. https://git.io/JLyT1
22:13:18  <DorpsGek> [OpenTTD/OpenTTD] J0anJosep updated pull request #8480: Multitile depots https://git.io/JL5Hh
22:14:11  <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #8566: Move "town name" selection into map generator GUI https://git.io/JtfK3
22:15:30  <glx> ah I can reenable windows CI requirements
22:19:11  <glx> hmm no still one approved to merge
22:19:54  <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #8674: Fix: VkMapping declarations violated C++ ODR rule. https://git.io/JtPcb
22:21:47  <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #8638: Feature: [GS] Allow non-question type windows to have no buttons https://git.io/JtEZG
22:30:17  *** frosch123 has quit IRC
22:32:00  *** Progman has quit IRC
22:33:20  <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #8639: Add: Allow translation of "(Directory)" and "(Parent directory)" https://git.io/JtPXR
22:40:43  <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #8578: Fix: Stopped ships shouldn't block depots https://git.io/JtPXi
22:41:02  <michi_cc> glx: I produced more approvals :p
22:41:27  <glx> but I reenabled CI requirements
22:42:33  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8578: Fix: Stopped ships shouldn't block depots https://git.io/JtUbR
22:42:34  <TrueBrain> no problem :P
22:42:37  <glx> I'll probably "update" #8639 to previous version, to remove .. from the string (even if it's a constant)
22:42:38  <TrueBrain> evil laughter
22:42:57  <glx> yeah I can force merge too if I want
22:43:09  <TrueBrain> I am aware :)
22:47:52  *** WormnestAndroid has quit IRC
22:48:05  <LordAro> glx: better do it before someone merges it :p
22:48:24  *** WormnestAndroid has joined #openttd
22:48:26  <glx> yeah it's compiling
22:49:03  <glx> (and only admins can merge it for now)
22:54:06  *** Wolf01 has quit IRC
22:56:15  *** sla_ro|master has quit IRC
22:56:47  <DorpsGek> [OpenTTD/OpenTTD] michicc closed pull request #7724: [Win32] Use sRGB for graphics output. https://git.io/fjjA8
22:56:54  <DorpsGek> [OpenTTD/OpenTTD] glx22 dismissed a review for pull request #8639: Add: Allow translation of "(Directory)" and "(Parent directory)" https://git.io/JtPXR
22:56:57  <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #8639: Add: Allow translation of "(Directory)" and "(Parent directory)" https://git.io/JtEWD
22:57:38  <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #8639: Add: Allow translation of "(Directory)" and "(Parent directory)" https://git.io/JtP1n
23:08:40  <DorpsGek> [OpenTTD/OpenTTD] glx22 closed issue #8636: Untranslatable strings in save/load dialog https://git.io/Jt08Y
23:08:43  <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #8639: Add: Allow translation of "(Directory)" and "(Parent directory)" https://git.io/JtEWD
23:15:20  <DorpsGek> [OpenTTD/OpenTTD] James103 commented on issue #8670: Crash on macOS Big Sur after downloading graphics to 200% https://git.io/JtiPZ
23:16:34  <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #8670: Crash on macOS Big Sur after downloading graphics to 200% https://git.io/JtiPZ

Powered by YARRSTE version: svn-trunk