Log for #openttd on 27th May 2022:
Times are UTC Toggle Colours
2022-05-26T1810:21:45  *** sla_ro|master has quit IRC
10:34:56  *** WormnestAndroid has joined #openttd
11:20:00  *** Samu has joined #openttd
11:25:07  *** WormnestAndroid has quit IRC
11:25:21  *** WormnestAndroid has joined #openttd
11:26:22  <Samu> did you change something regarding train signals? trAIns can't reach stations for some reason
11:30:30  <Samu>
11:30:54  <Samu> train makes a 180 turn instead of heading to station
11:36:39  *** sla_ro|master has joined #openttd
11:57:10  *** glx has joined #openttd
11:59:00  <glx> Samu: exit signal is one way
11:59:09  <glx> And the wrong way
11:59:43  <LordAro> good ol presignals
12:03:04  <Samu> trains never had issues, something changed regarding signals?
12:05:19  <Samu> openttd 12.2 trAIns works fine
12:05:25  <glx> Maybe a conversion bug during command templating
12:05:45  <glx> I guess signals should be pbs
12:07:35  <Samu> need some minut,es im gonna compare this in detail 12.2 vs master
12:10:35  *** glx is now known as Guest505
12:10:35  *** glx_ has joined #openttd
12:10:35  *** ChanServ sets mode: +v glx
12:11:28  *** Guest505 has quit IRC
12:15:33  <glx> oh could be related to signal cycle reduction
12:16:59  <glx> but API code is kind of ugly in this area
12:20:42  <LordAro> ah, could be
12:27:16  <Samu> trAIns is trying to build a SIGNALTYPE_EXIT_TWOWAY
12:28:05  <Samu> ends up passing SIGTYPE_EXIT to command
12:28:31  <glx> yes expected in the API code
12:29:42  <Samu> oh, hmm
12:29:55  <Samu> not familiar with this code
12:30:43  <glx> but command might have changed, so I need to check
12:36:21  <glx>
12:36:40  <glx> it's not supposed to remove TWO_WAY bit
12:37:12  <glx> oh it is
12:39:57  <glx> signal building code is so hard to follow
12:52:50  <Samu> signal cycle seems to be the issue, the counting
12:53:43  <Samu> signal side being 3 means two-way, right?
13:23:55  <Samu> okay, the bug is in ScriptRail::BuildSignal
13:24:55  <Samu> signal_cycles in 12.2 is 1, but not passed into docommand, so it becomes 0 when it reaches the command at the other side
13:25:19  <Samu> signal_cycles in master is also 1, but it is passed through
13:25:26  <glx> it was passed as bit stuff
13:25:34  <Samu> should be 0
13:26:38  <glx> oh no you're right, it was passed only for one way
13:29:28  * glx looks at improving regression
13:45:56  <Samu> else {
13:45:56  <Samu> 		signal_cycles = 0;
13:46:01  <Samu> wow such an easy fix
13:46:25  <Samu> looked complex at first
13:46:27  <glx> yes it's an easy fix, but I want to fix regression so it detects this
14:26:02  <glx> hmm and while at it, let's add -Q flag to regression check
15:38:15  *** Wormnest has joined #openttd
16:08:13  <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #9899:  Fix 55170ae: [Script] Building two-way signals could end up one-way
16:16:08  *** lobster has quit IRC
16:35:42  *** Smedles has quit IRC
16:35:46  *** Smedles has joined #openttd
16:52:52  *** tokai has joined #openttd
16:52:52  *** ChanServ sets mode: +v tokai
16:56:00  *** Wolf01 has joined #openttd
16:57:05  *** Flygon has quit IRC
16:59:59  *** tokai|noir has quit IRC
17:22:22  <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #9899:  Fix 55170

Powered by YARRSTE version: svn-trunk