Times are UTC Toggle Colours
09:52:58 *** sla_ro|master has quit IRC 11:13:33 *** ely-the-kitsune has quit IRC 12:10:42 *** sla_ro|master has joined #openttd 12:33:45 *** Samu has joined #openttd 12:40:17 *** glx has joined #openttd 12:40:17 *** ChanServ sets mode: +v glx 12:46:36 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on issue #9966: [Bug]: Command line option for help (`-h`) prints just the version and no other info. https://github.com/OpenTTD/OpenTTD/issues/9966 12:48:03 <glx> as if I didn't received notifications for updates on my issue :) 12:56:11 <LordAro> i kinda like James' completely context-free messages 12:56:16 <LordAro> nothing is assumed 13:07:10 *** ckb has quit IRC 13:07:25 *** ckb has joined #openttd 13:18:46 <glx> and of course updating to VS2022 17.3.1 doesn't change anything 13:20:02 <peter1138> Even in their assembly output it only does inc rax... 13:20:11 <glx> yes 13:22:12 <LordAro> lol. 13:22:22 <peter1138> I wonder if '*q = '\r'; q++;' works. 13:23:00 <peter1138> (Or the other way around as necessary) 13:29:43 <peter1138> Nope. 13:30:18 <glx> *q = '\r'; q++; 13:30:18 <glx> 00007FF6EE85EF81 inc rax 13:30:24 <glx> it's the same indeed 13:35:30 *** virtualrandomnumber has joined #openttd 13:41:54 <nielsm> https://godbolt.org/z/aaoWGnM5e changing it to use indexed array access does make it compile right, at least 14:09:23 *** ely-the-kitsune has joined #openttd 14:12:57 <supermop_toil> yo 14:25:10 *** virtualrandomnumber has quit IRC 14:37:33 <ely-the-kitsune> hi 14:44:34 <andythenorth> o/ 14:48:46 <glx> did a quick test without \r insertion, not a good idea, \r is required 14:54:49 <nielsm> how about using a stringstream instead of fixed buffer 14:55:46 <glx> in the end it goes to windows API, and this one is still in C 14:56:49 <glx> with the A and W variant implying convert_to_fs 14:58:33 <glx> we sure can work around the compiler bug, but this bug should not exist :) 14:58:48 <nielsm> yeah 14:59:16 <nielsm> it might be causing more miscompilations elsewhere too 15:00:14 <glx> and in this case the buffer is full of 0 at start, but it could also be full of garbage 15:52:52 <andythenorth> hmm can I chain nfo procedure calls? 15:52:55 <andythenorth> thought I could 😛 15:54:32 <andythenorth> got a weird bug 15:54:36 <andythenorth> probably I caused it 😛 16:03:21 <glx> a procedure can be a chain of switches 16:04:42 <glx> and I don't think anything prevents calling a procedure in a procedure 16:09:46 *** sla_ro|master has quit IRC 16:22:49 *** virtualrandomnumber has joined #openttd 16:24:30 *** virtualrandomnumber has quit IRC 16:29:05 *** virtualrandomnumber has joined #openttd 16:29:09 *** virtualrandomnumber has quit IRC 16:40:25 *** Wormnest has joined #openttd 16:59:25 * andythenorth bisecting for where the error was introduced :P 17:05:56 <peter1138> Amazon thinks I might like a new Piano or Keyboard. Uh oh. 17:09:08 <andythenorth> lol when you assume you broke a thing in the obvious way 17:09:20 <andythenorth> but it's an edge case you broke in a way you never considered 😛 17:09:21 <andythenorth> oof 17:17:12 <andythenorth> lol so my commit here was to prevent setting invalid action 0 props for trailing articulated parts 😛 17:17:13 <andythenorth> https://github.com/andythenorth/iron-horse/commit/b251374477b289a1369f6555bda544b75d3ed67f 17:17:49 <andythenorth> but not setting one of the properties causes trailing wagon parts to be treated as 'steam engine' for company colour purposes 17:17:56 <andythenorth> want to place bets on which one? 17:19:33 <frosch> refit_mask 17:19:50 <andythenorth> nope 17:19:56 <andythenorth> 2 more guesses 17:20:01 <andythenorth> I got it on 2nd guess 17:20:25 <frosch> oh, refit_mask is not even part of the diff 🙂 17:21:45 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1009512371351466144/unknown.png 17:21:45 <andythenorth> issue looks like this 17:22:03 <andythenorth> part 1 and 3 have no capacity 17:24:36 <andythenorth> I thought I broke it with changes to fetching random bits 17:24:42 <andythenorth> then I thought it might be engine class 17:24:54 <andythenorth> but nope 17:24:59 <andythenorth> power has to be explicitly 0 17:25:20 <andythenorth> it is in the specs, so eh 17:31:08 <frosch> ah, i found the special magic 17:32:39 <frosch> https://github.com/OpenTTD/OpenTTD/blob/master/src/newgrf.cpp#L1106 <- that code should probably be in a different place 17:33:34 <frosch> andythenorth: guess what, it's about dual-headness 🙂 17:33:44 <frosch> your favorite feature 17:34:23 <andythenorth> dual-head has the best surprises 17:34:31 <andythenorth> almost as though it's a side hack 17:35:10 <frosch> it would also have worked, if you had set the dualhead property to zero 🙂 17:35:15 <andythenorth> lol 17:35:25 <andythenorth> dualhead trailing parts 17:36:13 <andythenorth> ok docs say I should set dual_headed to 0 for trailing parts 17:36:19 * andythenorth does that 17:37:04 <andythenorth> oh dual_headed should be 0 😛 https://github.com/andythenorth/iron-horse/commit/b251374477b289a1369f6555bda544b75d3ed67f#diff-0108feac240339fb0ba286632f6774af73f6317010cf586ea3d20801a7593206R113 17:37:11 <andythenorth> existing code for it 17:37:46 <andythenorth> ha I 'optimised it' 17:37:55 <andythenorth> double conditional 17:39:28 <andythenorth> fixed that 😛 17:50:23 *** gelignite has joined #openttd 18:03:11 *** Flygon has quit IRC 18:37:33 *** sla_ro|master has joined #openttd 19:31:08 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #9967: Fix: [NewGRF] Default value of RailVehicleInfo::railveh_type was inconsistent with other default properties. https://github.com/OpenTTD/OpenTTD/pull/9967 19:51:13 *** gelignite has quit IRC 20:03:06 *** ely-the-kitsune has quit IRC 20:06:26 *** esselfe has quit IRC 20:11:37 *** esselfe has joined #openttd 20:14:27 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #9967: Fix: [NewGRF] Default value of RailVehicleInfo::railveh_type was inconsistent with other default properties. https://github.com/OpenTTD/OpenTTD/pull/9967#pullrequestreview-1076372261 21:39:37 *** HerzogDeXtEr has quit IRC 22:03:36 *** Wolf01 has quit IRC 22:05:04 *** Samu has quit IRC 22:30:26 *** nielsm has quit IRC 22:38:36 *** NGC3982 has joined #openttd 22:58:06 *** ckb has quit IRC 22:58:23 *** ckb has joined #openttd 23:00:41 *** ely-the-kitsune has joined #openttd 23:03:11 *** sla_ro|master has quit IRC 23:54:15 *** wallabra has quit IRC