Config
Log for #openttd on 23rd October 2022:
Times are UTC Toggle Colours
10:28:00  <petern> Probably assigning nullptr isn't valid.
10:48:49  <LordAro> TrueBrain: your backport PRs never added the 'backported' label :(
10:49:06  <TrueBrain> they still have the other label?
10:49:15  <TrueBrain> what was the PR that backported them, do you know?
10:49:16  <LordAro> nope, removes the backport requested label
10:49:39  <LordAro> #9602 & #9611 are the ones i've found so far
10:49:49  <LordAro> i've fixed the PRs manually though
10:50:09  <TrueBrain> those PRs don't have the backported label no, as they are not the ones being backported
10:50:17  <TrueBrain> they contain PRs that are backported, which are labeled correctly
10:50:21  <TrueBrain> not sure what you are sad abou tnow ๐Ÿ˜„
10:50:36  <LordAro> those are the backport PRs
10:50:42  <TrueBrain> yes, but they are not backported ๐Ÿ˜„
10:50:46  <LordAro> no
10:50:53  <TrueBrain> we label PRs that we did backport as "backported" ๐Ÿ™‚
10:50:58  <LordAro> no
10:51:00  <TrueBrain> "backport requested" -> "backported" ๐Ÿ™‚
10:51:02  <LordAro> i've done that
10:51:20  <LordAro> they were not done by whatever automation you were using
10:51:25  <TrueBrain> owh, you should have said before you did .. I have a script that does that ๐Ÿ˜› Clearly it wasn't run ๐Ÿ™‚
10:51:26  <LordAro> they only removed the backport requested label
10:51:53  <TrueBrain> or has a bug
10:52:01  <TrueBrain> either way, those PRs contain enough information to run the script again
10:53:49  <LordAro> looks like subsequent backport PRs did add the label
10:54:04  <TrueBrain> guess I did fix the bug already then ๐Ÿ˜›
10:55:42  <pickpacket> I know you've all been wondering what a teahouse looks like. Well, ladies and gentlemen, the results after my research are in
10:55:59  <pickpacket> They look like *drumroll* any other house!
10:56:18  <pickpacket> Consequently I have no idea where to draw inspiration from :P
11:10:49  <DorpsGek> [OpenTTD/OpenTTD] michicc opened pull request #10101: Fix a9a21e78: Depots aren't really stations. https://github.com/OpenTTD/OpenTTD/pull/10101
11:11:56  <Eddi|zuHause> that PR description is either a one-liner or a giant refactoring :p
11:12:32  <michi_cc[d]> It's unlikely that you'd do a giant refactoring to fix one specific git commit.
11:13:19  <Eddi|zuHause> dunno, i have seen some really euphemistic descriptions here :p
11:13:38  <LordAro> michi_cc[d]: congrats on PR #21
11:13:55  <Eddi|zuHause> what's a 21? :p
11:14:42  <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #10101: Fix a9a21e78: Depots aren't really stations. https://github.com/OpenTTD/OpenTTD/pull/10101#pullrequestreview-1152293760
11:16:35  <andythenorth> oof drawing pixels without my glasses
11:16:38  <andythenorth> faster
11:16:41  <andythenorth> but is it better? ๐Ÿ˜›
11:18:02  <pickpacket> towns have noise limits? never seen that before
11:19:23  <Eddi|zuHause> yes, those are the nimbys that don't want an airport
11:28:03  <glx[d]> For some unknown reason I can't merge with GitHub mobile app (something went wrong)
11:28:12  <glx[d]> It's annoying
11:29:13  <LordAro> changelog editing: https://demo.firepad.io/#z99NCo5j40
11:29:14  <DorpsGek> [OpenTTD/grfcodec] glx22 merged pull request #17: Update all deprecated stuff https://github.com/OpenTTD/grfcodec/pull/17
11:34:58  <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #10101: Fix a9a21e78: Depots aren't really stations. https://github.com/OpenTTD/OpenTTD/pull/10101#pullrequestreview-1152296270
11:36:05  <pickpacket> Eddi|zuHause: it's a non-default setting?
11:40:52  <andythenorth> can we merge faster PBS from JGRPP?
11:42:03  *** WormnestAndroid has quit IRC
11:42:08  *** WormnestAndroid has joined #openttd
12:01:40  <DorpsGek> [OpenTTD/OpenTTD] LordAro merged pull request #10097: Fix a394be2: Spell Maintenance correctly https://github.com/OpenTTD/OpenTTD/pull/10097
12:01:52  <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #10101: Fix a9a21e78: Depots aren't really stations. https://github.com/OpenTTD/OpenTTD/pull/10101#pullrequestreview-1152299415
12:03:42  <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #10101: Fix a9a21e78: Depots aren't really stations. https://github.com/OpenTTD/OpenTTD/pull/10101
12:06:27  <petern> Ok, removing bevels button...
12:06:37  <LordAro> :(
12:08:28  <petern> Oh
12:22:28  <petern> That's 1 yes and 1 no :p
12:22:47  <petern> (2 yes including andythenorth but we shouldn't listen to him)
12:30:02  <andythenorth> chunky bevels discord theme?
12:30:33  <petern> No bevels in Discord, just rounded rectangles.
12:31:03  <petern> I did wonder if a "flat" widget layout would work, but seems unlikely as we stuff buttons together with no spacing.
12:35:38  <FLHerne> andythenorth: "faster"?
12:36:20  <andythenorth> trains reserve further ahead
12:36:34  <andythenorth> so they're not always driving up to a red signal
12:36:39  <andythenorth> clearly "faster"
12:36:45  <LordAro> isn't that implemented really hackily?
12:36:49  <andythenorth> "'faster' PBS"
12:37:01  <andythenorth> it's really effective in my limited tests
12:37:11  <andythenorth> it's not actually "faster", I think it's probably "slower"
12:37:18  <andythenorth> JGR: will know ๐Ÿ™‚
12:37:37  <andythenorth> trains will reserve ahead through junctions I think, blocking them for other trains
12:37:44  <andythenorth> and it may be slower in the implementation, no idea
12:38:05  <FLHerne> oh, the multi-aspect thing
12:38:16  <andythenorth> yeah, although you don't need to use the MAS
12:38:23  <andythenorth> you can just use PBS red/green
12:44:04  <TallTyler> I really like the multi-aspect thing ๐Ÿ™‚
12:45:21  <TallTyler> The big improvement is that trains finding a yellow signal slow down so trains of different speeds can run on the same track without constantly catching up to each other and fully stopping. They just slow down and keep running on yellows without ever fully stopping.
12:45:45  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #10102: Fix #9087: NewGRF invalidation calls ReInitAllWindows with wrong parameter. https://github.com/OpenTTD/OpenTTD/pull/10102
12:46:58  <EmperorJake> TallTyler: There's a separate feature that allows trains to speed match with the one before it, it doesn't even need realistic braking I think
12:49:52  <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #10102: Fix #9087: NewGRF invalidation calls ReInitAllWindows with wrong parameter. https://github.com/OpenTTD/OpenTTD/pull/10102#pullrequestreview-1152305551
12:50:58  <andythenorth> TallTyler: faster
12:51:13  <andythenorth> PBS must be slow, because trains frequently stop and wait
12:51:53  <petern> I find it amusing how the reasoning behind "PBS is slow" morphed...
12:52:22  <andythenorth> might not be entirely accidental ๐Ÿ˜›
12:52:22  <petern> Slower code performance vs slower train speed
12:52:48  <petern> You and your memeing it
12:53:04  <andythenorth> when there are lolz, they must be harvested
12:54:26  <andythenorth> hmm should I actually watch Gold Rush?
12:54:30  <andythenorth> or just clips of Tony Beets?
12:54:36  <andythenorth> I think I tried watching the actual show once
12:54:48  <andythenorth> I wish I could subscribe to an alternative Discovery offering
12:55:15  <andythenorth> "Ice Road Truckers, but without the manufactured drama and competition"
12:55:36  <andythenorth> Deadliest Catch is actually ok for this, there is enough drama without them inventing much
12:59:18  <LordAro> i've been watching compilations of old HIGNFY series
12:59:48  <LordAro> "ooh look, isn't Boris so amusing"
12:59:55  <LordAro> etc
13:01:07  <TallTyler> EmperorJake: I thought that was incompatible with realistic braking and was automatically disabled but I could be wrong
13:02:52  <EmperorJake> Hmm the settings don't say anything like that
13:03:22  <petern> "realistic" ๐Ÿ˜„
13:08:45  <pickpacket> I sooo don't have it today... This is what I've managed on my first teahouse design so far:  https://lounge.warmedal.se/uploads/45d11c18a18ec9b3/image.png
13:14:30  <andythenorth> "faster"
13:16:56  <petern> It's dried up, so I guess I could go out for a bike ride.
13:17:08  <petern> Apart from my weird aversion mid-afternoon rides.
13:19:19  <LordAro> petern: likewise
13:20:11  <andythenorth> worst body-clock time of the day for exercise no?
13:20:18  <petern> It just feels like I should be coming home again already. Energy levels are different. Or something.
13:20:26  <andythenorth> stay in, merge faster PBS ๐Ÿ˜›
13:20:29  <andythenorth> profit
13:20:34  <andythenorth> go out later
13:20:44  <petern> School night tho'
13:21:13  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #10102: Fix #9087: NewGRF invalidation calls ReInitAllWindows with wrong parameter. https://github.com/OpenTTD/OpenTTD/pull/10102
13:21:15  <andythenorth> no PBS on school nights?
13:22:50  <petern> If you like
13:29:14  *** tokai has joined #openttd
13:29:14  *** ChanServ sets mode: +v tokai
13:29:53  <JGR> TallTyler: They are compatible, the speed matching thing is from Joker's parchpack
13:31:27  <JGR> The intent of the realistic braking feature is not about the "speed" of PBS at all
13:35:59  *** tokai|noir has quit IRC
13:39:50  *** WormnestAndroid has quit IRC
13:42:44  <andythenorth> side effects ๐Ÿ˜›
14:36:36  *** Flygon has joined #openttd
15:30:26  <andythenorth> Boom boom boom
15:30:30  <andythenorth> Venga boys are back in town
15:30:35  * andythenorth happy times
15:33:06  *** Wormnest has joined #openttd
15:33:18  *** WormnestAndroid has joined #openttd
15:33:52  *** Extrems has quit IRC
15:34:36  *** Extrems has joined #openttd
15:53:31  *** supermop_Home has joined #openttd
15:53:34  <supermop_Home> yo
15:55:52  <andythenorth> yo
15:57:00  <JustANortherner> Yo
15:57:10  <petern> lo
16:13:05  *** sla_ro|master has joined #openttd
16:13:59  *** nielsm has joined #openttd
16:38:25  <supermop_Home> I wonder if anyone has ever modified an F or FM to half-frame
16:40:03  <supermop_Home> feels like you'd just need to cut a custom gear for the film advance lever, re-screenprint the frame counter wheel, and add some blinders behind the shutter?
16:40:52  <supermop_Home> i guess you'd want to etch some new lines on the focusing screen
16:41:53  <supermop_Home> https://www.cameraquest.com/nffm2half.htm
16:45:33  <supermop_Home> ok i guess that concludes that thought experiment. the answer is yes
17:23:36  <andythenorth> oof 2 more boats to draw
17:24:48  <pickpacket> Finally getting somewhere!  https://lounge.warmedal.se/uploads/8a737baff4dfd84c/image.png  Those are just placeholder colours. I needed lots of contrast when figuring out the shape
17:25:37  <andythenorth> nice
17:47:06  *** Lord_Scruby has joined #openttd
17:47:07  <Lord_Scruby> the shaping does look pretty good
17:47:49  <pickpacket> ty
17:51:49  <DorpsGek> [OpenTTD/OpenTTD] maincomputer commented on issue #10077: [Bug]: Incorrect loan limit amount - other than what the player selected https://github.com/OpenTTD/OpenTTD/issues/10077
18:03:37  <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on issue #10077: [Bug]: Incorrect loan limit amount - other than what the player selected https://github.com/OpenTTD/OpenTTD/issues/10077
18:16:45  <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on discussion #10096: Updating OpenTTD to use liballegro5 https://github.com/OpenTTD/OpenTTD/discussions/10096
18:18:43  *** Wolf01 has joined #openttd
18:19:24  <Bouke> JGR: I find it strange that โ€œrealistic accelerationโ€ is in vanilla (and on by default?) while โ€œrealistic breakingโ€ is not. I think vanilla should also have the latter.
18:19:57  <JGR> It is too out of scope for vanilla
18:20:02  <JGR> I am not going to PR it
18:20:06  <TallTyler> Realistic acceleration makes the game easier, not harder. Realistic braking makes signaling harder.
18:20:19  <TallTyler> Original acceleration is a bit garbage ๐Ÿ™‚
18:21:37  <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on issue #10099: [Bug]: Windowed mode white screen issue with multiple monitors https://github.com/OpenTTD/OpenTTD/issues/10099
18:22:11  <Bouke> Well maybe not enabled by default then if you think itโ€™s bad for casual players. But at least available as a setting.
18:22:51  <andythenorth> well we need to do something about PBS ๐Ÿ™‚
18:23:02  <andythenorth> we have at least one candidate
18:23:19  <Bouke> In general, or with realistic braking?
18:23:41  <nielsm> routing restrictions for path signals should be in the main branch though
18:23:42  <andythenorth> well realistic braking is one fix for PBS
18:23:55  <JGR> Bouke: The implementation is more involved than a drop down with two items would make it appear
18:24:05  <nielsm> to deprecate the last use cases for block signals
18:24:45  <Bouke> jfs-: is this explained somewhere in more detail? What kind of restrictions?
18:24:58  <nielsm> "routing restrictions" means programmable signals
18:25:19  <FLHerne> hm
18:25:21  <nielsm> add programs to signals that restrict what routes they are allowed to set
18:25:24  <FLHerne> NewGRF signal types?
18:25:35  <Bouke> As BBS is currently used to build priority merges for example?
18:25:42  <TallTyler> https://github.com/JGRennison/OpenTTD-patches/wiki/Signalling
18:25:43  <JGR> Bouke: Here's some reading material: <https://github.com/JGRennison/OpenTTD-patches/wiki/Signalling> <https://github.com/JGRennison/OpenTTD-patches/wiki/Realistic-braking>
18:25:43  <FLHerne> have an action2 chain decide whether it's green or red
18:26:03  <FLHerne> with the surrounding signal states/distances as variables
18:26:12  <nielsm> no that won't be useful at all
18:26:13  <FLHerne> I'm sure there's no way that could become a nightmare
18:26:20  <andythenorth> lol
18:26:58  <FLHerne> nielsm: I think you could use it to implement a couple of signal types for priority merging, which is the main thing I use block signals for
18:27:04  <FLHerne> besides looking nice
18:27:51  <andythenorth> or we could bring back block, but not pre-signals
18:27:57  <nielsm> priority signals with routing restrictions is simply something like setting one signal to "attempt to reserve the next 3 blocks ahead"
18:28:06  <FLHerne> also, the GRF should be allowed to create and read user-configurable parameters per signal
18:28:29  <FLHerne> I mean, the behaviour would probably be similar to progsigs
18:28:49  <nielsm> now you're just making programmable signals but worse (much more confusing and harder to use)
18:29:12  <nielsm> what would make more sense would be a way to copy programs in/out of the game
18:29:14  <FLHerne> but it would possibly allow more advanced logic conveniently
18:29:25  <FLHerne> and/or without people insisting on adding it
18:30:14  <nielsm> you'd still need the exact same engine for evaluating and acting on the logic inside the game code (rail pathfinder), the difference is just if the user has direct or only indirect control of it
18:30:19  <DorpsGek> [OpenTTD/OpenTTD] James103 commented on issue #10099: [Bug]: Windowed mode white screen issue with multiple monitors https://github.com/OpenTTD/OpenTTD/issues/10099
18:31:18  <FLHerne> nielsm: exactly
18:31:59  <FLHerne> do you *want* to give the entire OTTD user base direct control over a programmable logic thing?
18:32:04  <FLHerne> the bug reports will be endless
18:32:33  <nielsm> they already have programmable vehicle orders
18:32:40  <nielsm> I don't see any endless stream of bug reports with those
18:32:41  <FLHerne> and the bug reports are endless :p
18:32:52  <FLHerne> tbf, not so much with the conditional ones
18:32:55  <andythenorth> /me just wanted faster PBS ๐Ÿ˜›
18:32:57  <andythenorth> le oof
18:32:58  <FLHerne> but only because no-one uses them
18:33:38  <nielsm> I think it could make sense to ship the game with some "templates" for common signal programs
18:33:42  <FLHerne> if it's behind NewGRF, then there'll be like one grf that adds a couple of useful signal types that most people use, and they can complain to whichever sucker makes it
18:34:28  <nielsm> you'd just see an endless stream of reports about NewGRF development tools being hard to use then
18:34:29  <FLHerne> and people who know what they're doing can add more but it'll be more obviously their own fault when it's broken
18:34:37  <FLHerne> eh
18:34:39  <JGR> Setting GRF authors up for failure doesn't seem that helpful
18:34:42  <FLHerne> there isn't really one now
18:34:53  <FLHerne> it's so obviously hard to use that people give up before complaining
18:34:57  <DorpsGek> [OpenTTD/OpenTTD] maincomputer commented on issue #10077: [Bug]: Incorrect loan limit amount - other than what the player selected https://github.com/OpenTTD/OpenTTD/issues/10077
18:35:10  <nielsm> I don't remember when I last saw someone reporting that conditional orders were broken either
18:35:16  * FLHerne might have a slight BoFH attitude today
18:36:03  <JGR> Conditional orders do work, but there aren't that many scenarios where they're really useful
18:38:31  <andythenorth> conditional orders aren't broken, they're just stupid
18:38:39  <andythenorth> the only one that really should be there is missing
18:38:48  <andythenorth> which is 'wait for cargo x%'
18:39:52  <andythenorth> 'other use cases may exist' ๐Ÿ˜›
18:41:11  <Bouke> andythenorth: Honest question: what is slow?
18:41:27  <andythenorth> they're always red until the train approaches
18:41:32  <TrueBrain> right, I pressed some buttons, and some person now has more buttons to press. If they find it important enough, they should note that in 2 files in the repository .. https://github.com/OpenTTD/OpenTTD/blob/master/CREDITS.md and https://github.com/OpenTTD/OpenTTD/blob/master/src/misc_gui.cpp
18:42:27  <TallTyler> Time to merge all the things? ๐Ÿ˜›
18:42:44  <TrueBrain> if that is how you wish to start things off ๐Ÿ˜›
18:43:01  <TallTyler> Not particularly ๐Ÿ˜›
18:43:10  <TrueBrain> anyway, gratz dude, well deserved ๐Ÿ™‚
18:43:10  <JGR> andythenorth: There is a load percentage conditional order
18:43:17  <Bouke> andythenorth: Why are they red by default?
18:43:24  <TallTyler> TrueBrain: Thank you ๐Ÿ˜Š
18:43:24  <andythenorth> what else could they be? ๐Ÿ™‚
18:43:35  <TallTyler> Yellow?
18:43:46  <Bouke> Why not green?
18:43:47  <andythenorth> but then trains would stop at yellows ๐Ÿ˜›
18:43:51  <andythenorth> or greens
18:44:04  <TallTyler> Distant signals are fake
18:44:10  <andythenorth> it's the literal implementation of PBS ๐Ÿ™‚
18:44:11  <Xaroth8> My condolences, TallTyler
18:44:57  <andythenorth> PBS is fixed in JGRPP with reserve-through (I don't know the official JGR terminology) ๐Ÿ™‚
18:45:27  <JGR> PBS in vanilla is fine for normal players
18:46:16  <JGR> It doesn't need fixing in that sense
18:47:01  <pickpacket> Whatโ€™s PBS?
18:48:55  <TallTyler> Path-based signaling
18:50:21  <TallTyler> If the only problem with path signals is that theyโ€™re red until a train gets to themโ€ฆ Donโ€™t path signals know if thereโ€™s only one possible route to the next signal? Could they automatically act like block signals in that case?
18:50:58  <TallTyler> Besides priority merges I mostly see comments from people here using block signals between junctions because having them green is โ€œmore realisticโ€
18:51:00  <nielsm> I don't understand why you want to see a signal be green when there is no train
18:51:00  <andythenorth> afaik, all they know is if a path is reserved through them
18:51:20  <andythenorth> that's why the JGR solution is so good ๐Ÿ™‚
18:51:25  <andythenorth> it doesn't just make all signals green
18:51:56  <andythenorth> if we could make them yellow by default and clear them as a train reserves a path, that would work
18:51:59  <andythenorth> but we can't afaict
18:52:49  <andythenorth> there's a couple of JGR features that are very hard to unsee once you've seen them
18:52:59  <andythenorth> auto-separate is the other one
18:53:09  *** HerzogDeXtEr has quit IRC
18:53:30  <TallTyler> With real signals you only want to drop them to red when a train passes them thereby turning it red by detecting itself. Yellow by default would be odd because a train could come from the other direction and drop a signal in front of a driver, potentially causing a crash.
18:54:36  *** felipedobri has joined #openttd
18:55:47  <michi_cc[d]> TallTyler: Remember which side you are on now when talking about how PRs go stale ๐Ÿ˜‡
18:57:52  <TrueBrain> maybe the worst part of this all, I never asked if TallTyler was okay with this ๐Ÿ˜›
18:58:03  <michi_cc[d]> Did we ever?
18:58:11  <TrueBrain> no, not really ๐Ÿ™‚
18:58:25  <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/4052feef1f6b027e8b2e4e9cbf4cc4264bc6eb0c
18:58:26  <DorpsGek>   - Update: Translations from eints (by translators)
18:58:37  <Xaroth8> VolunTOLD.
19:00:55  *** Xaroth8 is now known as Xaroth
19:01:02  <TallTyler> I had my opportunity to object ๐Ÿคท
19:01:07  *** felipedobri has quit IRC
19:01:13  <Xaroth> No you didn't :P
19:01:19  <TallTyler> I guess Iโ€™ll have to learn to review PRs now ๐Ÿ˜›
19:01:27  <Xaroth> TrueBrain is like a bus... you don't go stand in front of a bus.
19:01:33  <TrueBrain> TallTyler: That comes with the job description, yes ๐Ÿ˜›
19:02:06  <TallTyler> Challenge accepted, I guess
19:02:26  <michi_cc[d]> You are at least safe in the sense that self-approval isn't allowed.
19:02:49  <TallTyler> I still feel quite like a novice but Iโ€™ve definitely learned a lot in the past couple years of contributing
19:03:07  <andythenorth> I approve of myself
19:03:16  <TrueBrain> TallTyler: pretty sure most of us felt like that when we started out ๐Ÿ˜„
19:03:18  <petern> We just create a second sock-puppet account to get around self-approvals...
19:03:35  <andythenorth> hmm did I do more grf commits than OpenTTD has yet?
19:03:36  <TallTyler> Which sock puppet are you?
19:03:38  <michi_cc[d]> Well, we might be doing a release soon. Usually pressing the proper buttons for that was happily given to newest "volunteer". ๐Ÿ™‚
19:03:52  <petern> We're all sock puppet. There is only 1 actual developer...
19:04:01  <TrueBrain> with many many personalities
19:04:36  <TallTyler> Thatโ€™s where your username comes fromโ€ฆyouโ€™re the one true brain?
19:04:45  <andythenorth> 26,468 commits
19:04:49  <andythenorth> I have not caught up ๐Ÿ˜ฆ
19:04:54  <andythenorth> frigging translator commits ๐Ÿ˜ฆ
19:05:01  <andythenorth> I used to have those, but we nerfed them
19:05:17  <andythenorth> FIRS is only 6,881 commits
19:05:35  <andythenorth> Iron Horse is 6,081 commits
19:05:51  <petern> The scary thing is when VS Code tells me that I authored something 14+ years ago..
19:06:07  <TrueBrain> petern: I disabled that in VSCode ... I couldn't work like that ๐Ÿ˜›
19:07:48  <TallTyler> michi_cc[d]: Iโ€™m fine to be volunteered for that, but somebody would definitely have to walk me through it ๐Ÿ™‚
19:08:40  <michi_cc[d]> Well, there are only two complicated things with a release, the changelog PR and thinking of a proper announcement message.
19:08:58  <TrueBrain> the rest is totally and utterly automated ๐Ÿ˜„
19:09:03  <michi_cc[d]> Everything else is simpler than you'd expect, thanks to some hard work by TrueBrain.
19:16:27  *** frosch has quit IRC
19:21:07  <TallTyler> Hmm, do we need a new title game?
19:21:20  <TrueBrain> bit late now ๐Ÿ˜„
19:21:33  <michi_cc[d]> Not for a beta anyway, as that isn't branched.
19:21:55  <TallTyler> And in the past Iโ€™ve also seen a request for translators to get their languages completed before release
19:21:58  <Rubidium> maybe consider thinking about #9101 before branching?
19:22:01  <TrueBrain> michi_cc[d]: owh, beta first, duh, nice ๐Ÿ™‚
19:22:49  <michi_cc[d]> TallTyler: Indeed, hence why I personally would do a beta now.
19:23:21  <TrueBrain> Rubidium: yeah, otherwise we never do it ๐Ÿ˜„
19:23:24  <michi_cc[d]> There's also #9953, which seems to have stalled somewhere.
19:23:52  <michi_cc[d]> BTW, do the release CI actions need some fixing too, or was that done in one go with the other stuff?
19:24:31  <TrueBrain> glx[d]: fixed the nightly, so most of it should work
19:24:40  <TrueBrain> the one thing we are never sure of, are things like ubuntu deb files
19:24:55  <TrueBrain> those can break in mysterious ways, and are only checked upon release
19:25:35  <TallTyler> If we do a beta now when would the release be? Maybe there would be enough time for a new title save, if thatโ€™s important to people. Unfortunately turnout last year was pretty poor, I suspect because the cool new moving title scared people away ๐Ÿ˜ฆ
19:25:57  <TrueBrain> make it a xmas release?
19:26:27  <TallTyler> Beta on Halloween, release on Christmas sounds fun ๐Ÿ˜„
19:26:32  <michi_cc[d]> Depends if we want to do any RCs before or not. But IMHO a month gap minimum, otherwise there won't be much feedback.
19:27:27  <Rubidium> RC with thanksgiving?
19:27:47  <TrueBrain> seems we found a new tradition
19:28:13  <TallTyler> RIP April Foolโ€™s Day tradition
19:28:20  <TrueBrain> thatone is on me ๐Ÿ™‚
19:28:26  <TrueBrain> and I regret NOTHING
19:28:34  <TallTyler> New OpenTTD for Christmas will be an excellent gift
19:28:55  <TrueBrain> align with the xmas stream of .. darn it, forgot their name
19:28:57  <TrueBrain> how can I ..
19:29:04  <TrueBrain> make it land on their stream
19:29:12  <TallTyler> Jingle Jam?
19:29:15  <TrueBrain> give them the excluse ๐Ÿ˜›
19:29:20  <TrueBrain> andythenorth: will know the name I am looking for
19:30:46  <michi_cc[d]> Yogscast?
19:30:51  <TrueBrain> yes, thank you!
19:33:14  <andythenorth> I am going to try and meet Lewis soon
19:33:19  <andythenorth> we talked about it last week
19:33:33  <andythenorth> can't do it this week, kids are off school
19:33:48  <Rubidium> I guess you can't combine the RC with the #10k party at the Southern Alps on Thanksgiving
19:42:39  <TrueBrain> including skytrip?
19:55:17  <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #10103: Codechange: [CMake] Auto-fill list of #include in script_window.hpp https://github.com/OpenTTD/OpenTTD/pull/10103
20:01:22  * petern continues fiddling
20:03:54  <petern> Which somehow means waiting for another full compile.
20:05:10  <andythenorth> more thread units ๐Ÿ˜›
20:06:34  <petern> Is it not possible to paste text? Hmm
20:28:48  <petern> Do `network_chat_box_height` and `network_chat_box_width_pct` settings need to exist?
20:29:19  <petern> And indeed `network_chat_timeout`
20:30:55  *** virtualrandomnumber has joined #openttd
20:31:10  *** virtualrandomnumber has quit IRC
20:38:02  <TrueBrain> no; comes from a time where everything was a setting ๐Ÿ˜„
20:43:22  <TallTyler> So, if we do a title game competition, I can post the announcement today and the deadline could be December 1st? That gives people just over a month to create their entry with an easy deadline to remember, and a couple weeks to vote. Thoughts?
20:43:42  <TrueBrain> sounds good to me!
20:44:12  <petern> Is the deadline the end of the 1st or the beginning of it...
20:47:02  <TallTyler> I donโ€™t think anything is so pressing that it matters, but we could say 23:59:00 UTC to be specific ๐Ÿ™‚
20:53:04  <andythenorth> oh ๐Ÿ˜ฎ
20:53:08  <andythenorth> no Boris ๐Ÿ˜ฎ
20:53:12  <andythenorth> such UK
20:53:17  <TrueBrain> welcome to #uk-special ๐Ÿ™‚
20:59:36  <Flygon> Wait
20:59:38  <Flygon> For real?
20:59:39  <Flygon> What.
20:59:44  * Flygon confused Australia noises
21:00:07  <Flygon> How the hell did the UK top Australia in terms of Prime Ministerial cluster... ducks :D
21:00:57  <FLHerne> he ruled himself out (almost certainly because he wasn't going to win)
21:01:09  <FLHerne> not "no, Boris"
21:01:23  <FLHerne> I was almost looking forward to the carnage if he won
21:02:44  <Flygon> Oh
21:02:47  <Flygon> I thought you were like
21:02:50  <Flygon> "Nooo Boris got in".
21:02:53  <Flygon> Hahaha.
21:06:45  <TallTyler> The title game competition post is ready to go. Should I mention the release date of December 25th? What about the beta on Halloween? Or are those separate announcements?
21:21:11  <TallTyler> Okay, doesnโ€™t make sense to mention the beta, but can I promise a Christmas release?
21:21:41  <petern> I wouldn't yet...
21:21:50  <petern> I mean, who's going to be making released on the 25th? ๐Ÿ˜„
21:22:21  <TallTyler> How about โ€œbefore Christmas?โ€
21:23:29  <TallTyler> If thereโ€™s a title game competition people will be wondering when the release will be
21:23:45  <petern> You also don't really want a Christmas-themes competition game.
21:23:57  <petern> Yeah but then again, let them wonder?
21:24:15  <TallTyler> โ€œOpenTTD 13 coming soonโ€ ๐Ÿ˜›
21:25:35  <TallTyler> Posted: https://www.tt-forums.net/viewtopic.php?t=90357
21:32:53  *** nielsm has quit IRC
21:33:37  <TrueBrain> Pam pam pammm
21:34:49  <TrueBrain> Nicely done, looks good ๐Ÿ˜„
21:37:11  <Arastais> I have a window with a `WWT_RESIZEBOX`, but can't resize horizontally, only vertically. I've set every widget to `SetResize(1, y)` where y is either 1 or 0. Am i missing osmething?
21:45:12  <petern> You probably need a `SetFill()` somewhere too.
21:46:34  <petern> (Not sure though)
21:50:46  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10034: Feature: Button to honk a vehicle's horn https://github.com/OpenTTD/OpenTTD/pull/10034#issuecomment-1288208856
21:50:49  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler closed pull request #10034: Feature: Button to honk a vehicle's horn https://github.com/OpenTTD/OpenTTD/pull/10034
21:51:03  *** Wolf01 has quit IRC
22:03:25  <petern> Heh
22:04:41  <DorpsGek> [OpenTTD/OpenTTD] Arastais commented on pull request #10034: Feature: Button to honk a vehicle's horn https://github.com/OpenTTD/OpenTTD/pull/10034#issuecomment-1288211191
22:05:21  <Arastais> petern: i have that as well for everything except `WWT_FRAME`s, still no luck
22:08:40  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10034: Feature: Button to honk a vehicle's horn https://github.com/OpenTTD/OpenTTD/pull/10034#issuecomment-1288211921
22:14:27  *** sla_ro|master has quit IRC
22:24:41  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #9901: Fix: Improve performance when calculating company value https://github.com/OpenTTD/OpenTTD/pull/9901#pullrequestreview-1152383897
22:37:02  <Arastais> Arastais: did it for the frames too, no luck
22:37:40  <Arastais> in fact, I noticied that it can't even stretch to its default height based on its `WindowDesc`, it gets drawn in the center as if it were bigger but then gets adjusted to its fixed vertical size
22:38:44  <DorpsGek> [OpenTTD/OpenTTD] ageekhere commented on issue #10099: [Bug]: Windowed mode white screen issue with multiple monitors https://github.com/OpenTTD/OpenTTD/issues/10099
22:46:28  <DorpsGek> [OpenTTD/OpenTTD] krysclarke commented on issue #10099: [Bug]: Windowed mode white screen issue with multiple monitors https://github.com/OpenTTD/OpenTTD/issues/10099
22:47:58  <DorpsGek> [OpenTTD/OpenTTD] ageekhere commented on issue #10099: [Bug]: Windowed mode white screen issue with multiple monitors https://github.com/OpenTTD/OpenTTD/issues/10099
23:07:41  *** Montana has joined #openttd
23:08:19  <DorpsGek> [OpenTTD/OpenTTD] Arastais updated pull request #10058: Feature: [UI] Allow configuring AI/Game Script and NewGRF from world gen window https://github.com/OpenTTD/OpenTTD/pull/10058
23:11:46  <DorpsGek> [OpenTTD/OpenTTD] Arastais updated pull request #10058: Feature, Change: [UI] Split AI/Game Script configuration windows and add them to world gen window https://github.com/OpenTTD/OpenTTD/pull/10058
23:12:23  *** WormnestAndroid has quit IRC
23:15:09  *** WormnestAndroid has joined #openttd
23:16:28  <TallTyler> \o/
23:20:32  <DorpsGek> [OpenTTD/OpenTTD] Arastais updated pull request #10058: Feature, Change: [UI] Split AI/Game Script configuration windows and add them to world gen window https://github.com/OpenTTD/OpenTTD/pull/10058
23:21:06  <Arastais> sorry, theres gonna be a lot of updates bc there was a conflitch and i have to rebase now. I'll also need to comment the changes
23:21:28  <glx[d]> Arastais: it's easier for me to point you to https://wiki.openttd.org/en/Development/Coding%20style#control-flow than commenting in the PR ๐Ÿ™‚
23:23:13  <glx[d]> VS is configurable but it's not always simple
23:24:10  <glx[d]> and default configuration for if/else doesn't follow our style
23:27:44  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10058: Feature, Change: [UI] Split AI/Game Script configuration windows and add them to world gen window https://github.com/OpenTTD/OpenTTD/pull/10058#issuecomment-1288228805
23:32:58  <DorpsGek> [OpenTTD/OpenTTD] LC-Zorg commented on pull request #10054: Added widget showing company slots remaining https://github.com/OpenTTD/OpenTTD/pull/10054#issuecomment-1288229979
23:33:01  <DorpsGek> [OpenTTD/OpenTTD] Arastais updated pull request #10058: Feature, Change: [UI] Split AI/Game Script configuration windows and add them to world gen window https://github.com/OpenTTD/OpenTTD/pull/10058
23:34:45  <DorpsGek> [OpenTTD/OpenTTD] James103 commented on issue #9295: Music Audio is not normalized/leveled correctly https://github.com/OpenTTD/OpenTTD/issues/9295
23:35:52  <Arastais> glx[d]: I tired to stick to the coding style as always, but if you find something I missed let me know.
23:36:53  *** WormnestAndroid has quit IRC
23:37:18  <DorpsGek> [OpenTTD/OpenTTD] Arastais updated pull request #10058: Feature, Change: [UI] Split AI/Game Script configuration windows and add them to world gen window https://github.com/OpenTTD/OpenTTD/pull/10058
23:38:57  *** WormnestAndroid has joined #openttd
23:40:12  *** WormnestAndroid has joined #openttd
23:41:43  *** Montana has quit IRC
23:45:04  <Arastais> glx[d]: oh sorry, I think I misunderstood. I meant I need to put a comment in the PR saying what changes I've made since the last force push.
23:45:26  <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #10058: Feature, Change: [UI] Split AI/Game Script configuration windows and add them to world gen window https://github.com/OpenTTD/OpenTTD/pull/10058#pullrequestreview-1152396686
23:45:48  <DorpsGek> [OpenTTD/OpenTTD] Arastais commented on pull request #10058: Feature, Change: [UI] Split AI/Game Script configuration windows and add them to world gen window https://github.com/OpenTTD/OpenTTD/pull/10058#issuecomment-1288233967
23:47:09  <glx[d]> I know VS can be annoying with coding style
23:47:20  <LordAro> Arastais: we can see what changes are made, a comment isn't (usually) necessary
23:48:58  <Arastais> glx[d]: yea, all ur suggestions are from VS doing it without me noticing lol. Basically if you paste something or edit lines in a certain way (such as putting a semicolon), it auto-indents everything it can to the formatting in the VS settings. I'll correct them now
23:49:17  <Arastais> LordAro: lol sorry, i meant in terms of the UI. I made a comment saying how the UI looks in-game now
23:49:22  <LordAro> i'm talking about the act of purely force-pushing, making additional changes to the PR could well need a comment
23:49:27  <LordAro> :)
23:50:00  <glx[d]> yeah usually after a paste you can do a ctrl-z to undo the auto formatting
23:51:10  <glx[d]> and it's possible to configure VS to format as you want
23:52:18  *** WormnestAndroid has quit IRC
23:53:19  <glx[d]> because it will auto format every time a block is closed (very nice feature, except when it uses to wrong format)
23:53:57  <Arastais> glx[d]: yea I do but i miss some formatting rules and forget to ctrl-z sometimes
23:54:33  <DorpsGek> [OpenTTD/OpenTTD] Arastais updated pull request #10058: Feature, Change: [UI] Split AI/Game Script configuration windows and add them to world gen window https://github.com/OpenTTD/OpenTTD/pull/10058
23:57:07  <Arastais> foudn a few more mistakes, correcting them now
23:58:13  *** wallabra_ has joined #openttd
23:59:11  <glx[d]> we can be annoying with coding style but it's for the benefit of everybody ๐Ÿ™‚
2022-10-22022-10-24T10:32:50  <reldred> trains go nyooom

Powered by YARRSTE version: svn-trunk