Times are UTC Toggle Colours
10:33:59 <petern> (If you missed the meaning of not gone anywhere -- haven't progressed) 10:34:21 <dP> TallTyler: it's kind of the same problem with cargo subtypes, you can put whatever you want but without a sound logic behind it all ends up being counter-intuitive and abandoned 10:34:51 <andythenorth> cargo subtypes are shit 10:34:58 <andythenorth> that's why it's abandoned 🙂 10:35:48 <andythenorth> presenting UI choices for individual vehicles as a union of the available subtypes in the consist...is fucking stupid 🙂 10:36:07 <andythenorth> it makes sense...not even for cargos 10:36:21 <dP> again, it's all in the ui, technically subtypes are just another way to add variants 10:36:43 <andythenorth> no, because there's no way to autoreplace to a different subtype 10:36:48 <andythenorth> and frosch believes there never can be 10:37:54 <dP> hm, so the goal is to autoreplace liveries? 10:38:15 <TallTyler> And allow choosing them before purchasing 10:38:17 <dP> also, sounds like a technical issue with subtypes or autoreplace implementation 10:38:19 <andythenorth> the capability to do UI design in the game is nearly non-existent 10:38:25 <andythenorth> so we need to work with the existing UIs 10:39:00 <petern> andythenorth: thanks I like your confidence in our design 😦 10:39:13 <andythenorth> timetables 😛 10:39:38 <petern> Subtypes are not available until an engine has been purchase and exists as vehicle. This is a huge barrier. 10:40:29 <petern> What subtypes that are available can change based on callbacks, so (and do) can change at any time. 10:40:37 <dP> changing newgrf spec instead of ui sounds very wrong :p 10:40:51 <dP> ui changes come and go, spec changes are to stay there forever 10:41:06 <petern> The spec is broken. 10:41:14 <andythenorth> petern: sorry, I'll put it better: we're a bit hit and miss on UI design, historically 10:41:34 <petern> andythenorth: Btw, did the orange tabs look better? :p 10:42:21 <andythenorth> yes 10:42:28 <TallTyler> Also good luck changing UI design and not getting enormous pushback from players (unless you’re simply adding things, and then they complain about the new window being too big), so it’s not like UI is a sandbox either 10:42:56 <petern> petern: ^ This one 😄 10:43:02 <dP> TallTyler: you say it like variants don't change ui :p 10:43:42 <TallTyler> No, I know it’s a big change but I was referring to `ui changes come and go, spec changes are to stay there forever` 10:44:00 <TallTyler> I’m still not a fan of orange buttons 10:44:19 <petern> I had grey buttons, they're almost invisible. 10:44:59 <petern> I even had fake-tabs (which could look nicer with a bit of over-painting) but they're not really in the style of OpenTTD. 10:45:03 <TallTyler> I haven’t seen the grey button mock-up, but I wonder if a different button background (darker grey?) would make them look more like tabs 10:45:06 <TallTyler> Oh yeah that 10:45:44 <TallTyler> We have tabs in vehicle details but those are smaller and at the bottom 10:46:08 <petern> petern: 7This one 10:46:57 <TallTyler> I like the design of those but I see how they’d be invisible without the green background 10:47:08 <TallTyler> I don’t hate orange, just slightly dislike it 🙂 10:47:29 <TallTyler> I think you’ve shown me TTD windows that had mixed colour buttons? 10:48:13 <petern> ai/gamescript/newgrf have both yellow and mauve buttons 10:48:25 <petern> Oh maybe not newgrf. 10:48:45 <TallTyler> I should boot up OpenTTD 10:48:49 <petern> (Not sure why game script settings needs a Close button) 10:49:06 <petern> https://cdn.discordapp.com/attachments/1008473233844097104/1054712040679280650/image.png 10:49:28 <petern> https://cdn.discordapp.com/attachments/1008473233844097104/1054712133415350292/image.png 10:49:28 <petern> Scrollbars are kinda buttons 10:50:28 <petern> afaik it's only worldgen that has 2 buttons colours both different from the background 10:50:45 <petern> And that case is to highlight the important button 10:51:48 <dP> petern: hm, yeah, that sounds like a showstopper 10:52:31 <dP> I guess my main issue with variants is that they seem to follow the logic of what can be done simply rather than what is actually needed. 10:56:46 <dP> am I reading it right that two totally unrelated engines can be declared variants? 10:56:51 <TallTyler> Sometimes that's how it has to work? 🤔 10:57:23 <TallTyler> dP: Sometimes that's how it has to work? 🤔 11:01:20 <andythenorth> the main criteria is: does X increase lolz? 11:01:25 <andythenorth> variants increases lolz, at low cost 11:01:29 <andythenorth> therefore it's good 11:02:40 <JGR> dP: It requires that NewGRF authors use it in a reasonable way 11:02:41 <dP> lolz in spec are only good until you need to use them :p 11:03:07 <JGR> Which is true for large chunks of the specification 11:04:37 <JGR> In general making is easier for NewGRF authors to express reasonable things is positive 11:06:38 <dP> yeah, newgrf authors are known for their reasonableness :p 11:07:12 <reldred> HEY I haven't thrown a public tantrum lately 11:07:12 <JGR> The spec is just a means to an end 11:07:13 <TallTyler> I feel targeted 😛 11:08:03 <dP> ... 11:08:27 <andythenorth> variants just creates a virtual group, it has no other effect 11:08:46 <andythenorth> any patchpack that really hates it could just drop the action 0 prop 11:08:50 <andythenorth> and it will stop 11:08:51 <dP> yeah, but if you read the pr they claim to do liveries 11:09:06 <dP> and my first question to that if it's livery why can't I repaint the engine? 11:09:20 <andythenorth> because nobody made a painting tool 11:09:29 <andythenorth> every idea I proposed was shot down 11:09:59 <andythenorth> every idea anybody else proposed was shot down 11:10:42 <reldred> We need a BDFL 11:12:13 <JGR> I'm not sure that's the right thing for a mostly sandbox game 😛 11:14:06 <JGR> Maybe we should take a leaf from the world of work, steering groups to steer the other steering groups 11:14:24 <DorpsGek> [OpenTTD/OpenTTD] legitalk opened issue #10263: [Crash]: Assertion failed https://github.com/OpenTTD/OpenTTD/issues/10263 11:14:45 <dP> andythenorth: well, adding another sub-optimal way to do it will make implementing any sane idea even harder 11:15:31 <JGR> Not really in this case, you can just not use the feature if something amazing is invented in the far future 11:16:09 <andythenorth> the constraints for liveries 11:16:12 <andythenorth> as told to me 11:16:22 <andythenorth> 1. must be settable per vehicle 11:16:31 <andythenorth> 2. must be settable without a trip to another menu / UI window 11:16:41 <andythenorth> 3. must be settable for a whole train 11:16:58 <andythenorth> 5. must be settable per group 11:17:04 <andythenorth> 5. must be settable for all trains of type X 11:17:20 <andythenorth> 6. cannot use a livery painter tool in depot 11:17:29 <dP> JGR: no, imagine a perfect way to do liveries is added and you need to show them in buy ui. but you can't do tree because tree is already taken by variants 11:17:31 <andythenorth> if you can meet that, GG 11:18:20 <dP> why 6 11:19:42 <dP> i'd expect the opposite, if I have veh in depot sounds logical to be able to repaint it to whatever 11:20:17 <Brickblock1> dP: this could be fixed with a button to change between variants and liveries but I agree that it makes it harder to make a new system fit in. 11:23:33 <andythenorth> 6. I never understood why 11:23:37 <andythenorth> but we don't have a livery painter 11:23:55 <andythenorth> Iron Horse current release has a hidden livery painter 11:23:58 <andythenorth> but it's hidden 11:25:38 <petern> dP: No reason another tree from the variant wouldn't work. 11:25:41 <andythenorth> hmm what was I doing? 11:25:53 <andythenorth> did I need to test action 1 removal? 11:26:01 <petern> Nobody ever said 6 did they? 11:26:31 <andythenorth> I suspect they did not 11:26:37 <petern> Unless "livery painter" was about choosing a CC per vehicle part. 11:26:40 <andythenorth> 6 might be a porky pie 11:26:50 <petern> Which is doable but not really related to liveries 11:26:53 <dP> petern: in this example maybe, but you still need to figure out the interaction between two features that way 11:26:58 <petern> (Unless you hide liveries behind CC) 11:27:03 <andythenorth> who would do that? 11:27:07 <petern> Who? 11:27:11 <andythenorth> or behind ctrl-click? 11:27:21 <andythenorth> or behind magically-adapting-to-the-engine 11:27:31 <andythenorth> I did make a version with combinatorial logic once 11:27:37 <petern> That's a well-known concept dating back to the early days 😄 11:27:45 <andythenorth> which read the flip state of nearby vehicles 11:27:46 <andythenorth> as bits 11:27:52 <andythenorth> then set consist livery appropriately 11:28:11 <andythenorth> 'number of liveries increases with train length' 11:28:36 <andythenorth> I think I concluded there could only be 4, and it would have to rely on flip state of first and last vehicles 11:28:59 <petern> Someone could perhaps allow "individual autoreplace" inside a depot to allow "repainting" a variant to another variant. 11:29:01 <andythenorth> wonder if I videoed those 11:29:13 <petern> It's effectively a short-cut for sell & buy. 11:29:41 <petern> (But why bother when autoreplace can already do it?) 11:29:42 <andythenorth> oh I animated Horse steam engine wheels once 11:29:45 <andythenorth> found a video 11:30:00 <petern> Cool, you can reduce your action 1s and then add more action 1s. 11:30:53 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1054722557917532170/probably_fine.m4v 11:30:53 <andythenorth> lol ^ 11:31:06 <andythenorth> oh m4v doesn't? 11:31:59 <petern> Such hidden 11:32:24 <dP> petern: and that what makes it divert from livery logic. for example, what if you want to repaint but don't have the money to buy a new vehile? 11:32:31 <andythenorth> tough gig 11:32:36 <andythenorth> git gud? 😛 11:32:46 <dP> surely, repaint should cost less that buying a new one, right? 11:33:08 <andythenorth> subtype refitting sets are available 11:33:11 <andythenorth> in vast numbers 11:33:16 <pickpacket> So... I'm back on Debian Stable... testing kept breaking things. I guess the way to run the latest OpenTTD now is to either compile myself or get a static compile for i386 somewhere. What's the compile time like? 11:33:17 <andythenorth> pls choose an alternative grf 11:33:57 <petern> Should we add a flag to variants to say "this variant is just a livery" 11:34:02 <petern> Even if we don't use it yet. 11:34:07 <dP> dP: on a plus side though red trains can finally go faster xD 11:34:45 <petern> Then it would be possible to implement logic that allows switching same-variant-liveries without the normal sell & buy process. 11:35:16 <petern> Adding a flag for a "potential future use" is maybe not a good idea though. 11:35:51 <dP> yeah, if it's potential use make a potential flag xD 11:36:14 <petern> You have the issue then that you can autoreplace to change, and "potential future use" to change 11:36:27 <petern> "why does one cost more?" 11:36:53 <andythenorth> ahem 11:37:02 <andythenorth> when selling a vehicle, there's no income? 11:37:06 <petern> Although you could make autoreplace understand "potential future use" and rely on autorenew to do its thing. 11:37:20 <petern> There is 11:37:24 <andythenorth> well 11:37:28 <andythenorth> colour me surprised 11:37:30 <dP> but it drops quickly with age 11:37:35 <andythenorth> so what's the net cost of changing paint scheme? 11:37:55 <dP> and you need some money in reserve for autoreplace to work 11:37:55 <petern> Depends how old the vehicle is 🙂 11:38:14 <Brickblock1> one hundredth of purchase cost? 11:38:17 <andythenorth> no money -> no new paint 11:38:21 <andythenorth> money -> new paint 11:38:28 <petern> You need money to paint, tbh 🙂 11:38:37 <petern> Just not the same amount as a new engine. 11:41:25 <petern> Man came around "can I take your scrap metal?" 11:41:29 <petern> I mean... uh... 11:42:21 <dP> petern: just tell him to grow his own town 11:42:28 <petern> I said no because they need licenses and stuff to that commercially, and I'm not risking it with a random guy with a thick accent I can barely understand. 11:43:25 <petern> My scrap metal is an old metal washing line that's bent, a broken lawnmower, and I really should have taken it to the tip last time I went 😄 11:45:07 <andythenorth> how much would it cost you to repaint it? 11:45:22 <petern> Quite. 11:46:03 <dP> petern: somehow I'm already thinking how to abuse that xD 11:46:08 <dP> https://cdn.discordapp.com/attachments/1008473233844097104/1054726392748703764/aHR0cHM6Ly93d3cuZ2lueC50di91cGxvYWRzMi9mb3J6YS9jYXJfdHVuaW5nX2d1aWRlL2Fwb2xsb19pbnRlbnNhX2Vtb3ppb25lL2ZvcnphLWhvcml6b24tNS1hcG9sbG8taW50ZW5zYS1lbW96aW9uZS10eXJlcy1hbmQtcmltcy1zdWJtZW51LXBsYXlncm91bmRnYW1lcy5KUEc.png 11:46:20 <petern> It's not abuse if the author intended it. 11:46:41 <petern> kinda 🙂 11:47:03 <dP> wouldn't work with my racing train upgrades though unless it's a separate network command for livery change 11:47:09 <petern> andythenorth: half the file size with fixed reversing logic? 11:47:25 <andythenorth> should be 11:47:28 <petern> I don't know what that is. 11:47:47 <andythenorth> I didn't patch out all the action 1s yet 😛 11:48:12 <andythenorth> that branch will have a bad time with my variants branch 😛 11:48:21 <petern> They are at least automatically created though, rather than actual duplicate sprites? 11:48:30 <petern> Yeah 😄 11:51:33 <petern> > note 443MB (381,248 recs) 11:51:34 <petern> > drive_file 273MB (172,657 recs) 11:51:34 <petern> > user 99MB (73,890 recs) 11:51:48 <petern> Single-user fediverse instance gobbling space 11:57:19 <dP> right, so what was I doing before I went to read chat while it compiles and got distracted by variants.... 11:57:35 <TallTyler> Oof 11:59:01 <dP> I miss my desktop compile times xD 11:59:20 <pickpacket> I'm trying to compile (for the first time) but cmake can't find SDL2Config.cmake :( Is that a file that can be found in my system somewhere or a file I need to write myself? 11:59:35 <dP> 20 seconds wasn't that much time to completely forget what I was doing 11:59:45 <petern> pickpacket: You can download a prebuilt Debian package if you want. 12:00:11 <pickpacket> petern: only for x86_64, right? I'm running 32bit 12:00:17 <petern> Oh lol. 12:00:57 <pickpacket> 😔 12:01:13 <petern> Can we start a fundraiser to get pickpocket a 64bit computer? 12:01:21 <pickpacket> pfft 12:01:29 <pickpacket> If I wanted a new computer I'd buy one. 12:01:56 <pickpacket> I'm happy with this one and I'm not about to throw away a perfectly functioning computer :) 12:02:11 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler dismissed a review for pull request #7575: Feature: Industry production graph https://github.com/OpenTTD/OpenTTD/pull/7575#pullrequestreview-341585839 12:02:50 <petern> Anyway, if you are missing dependencies then COMPILING.md 12:03:05 <petern> On Debian you want to install the related -dev packages. 12:03:11 <pickpacket> ah 12:03:15 <petern> then *read* ... 12:04:56 <pickpacket> I did read. And I installed the dependencies :) Just not the dev packages 12:05:19 <petern> I added that because I missed it out originally. Not to be mean. 12:06:42 <petern> I accidentally the whole verb. 12:09:35 <andythenorth> I should test #10262 12:11:13 <pickpacket> :) 12:11:16 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler requested changes for pull request #7575: Feature: Industry production graph https://github.com/OpenTTD/OpenTTD/pull/7575#pullrequestreview-1224383919 12:14:18 <pickpacket> yay! It built! 12:15:26 <petern> Try not to hit the 4GB limit 🙂 12:15:38 <petern> I remember when that seemed massive. 12:15:41 <pickpacket> but where'd the executable or deb package go? 12:15:51 <pickpacket> yeah, I remember too 12:16:10 <pickpacket> wasn't even that long ago. Just 20 years or so 12:16:26 <petern> Probably in the bin directory under your build directory. 12:16:36 <pickpacket> I thought so too :( 12:17:29 <pickpacket> https://lounge.warmedal.se/uploads/83d871f8279ef224/image.png 12:18:29 <petern> Did you build it your just complete cmake config? 12:18:37 <pickpacket> the build log doesn't report any errors, though there were some things that couldn't be found (grfcodec, for example) 12:18:46 <TallTyler> My default build is in out/build/x64-Debug default) 12:18:50 <TallTyler> Not bin 12:18:57 <petern> your->or 12:19:24 <petern> I'm too used to Discord edits now, it's andy's fault. 12:19:24 <LordAro> sounds like you haven't actually built it yet 12:19:55 <pickpacket> petern: ~/Code/official-openttd/OpenTTD/build $ cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo .. 12:20:07 <petern> cmake configures it. 12:20:08 <LordAro> (a maximum of) 10 minutes seems very fast for a 32bit computer 12:20:11 <petern> You then need to run make. 12:20:29 <pickpacket> aha 12:20:40 <pickpacket> I also need to download the grfcodec, of course 12:20:46 <LordAro> you do not 12:21:04 <LordAro> unless you actually want to modify the base extra grf 12:21:32 <pickpacket> 👍 12:22:00 <dP> petern: `make -j` if you want it to finish in this century xD 12:22:20 <petern> It's 32 bit, likely is single core. 12:22:33 <dP> hm, 32 is that old? 12:22:43 <LordAro> it could just be a 32bit install 12:22:48 <LordAro> on a 64bit processor 12:23:24 <petern> They just reinstalled, so unlikely 🙂 12:24:02 <LordAro> that's no guarantee of anything :p 12:24:16 <pickpacket> 32bit Atom processor. It was a budget computer back in 2015 when I bought it 12:24:24 <LordAro> that'd do it 12:24:52 <LordAro> i suppose it might have more than one core 12:24:53 <pickpacket> the build is already 44% complete according to the output :) 12:25:11 <LordAro> `nproc` would tell you 12:25:36 <LordAro> dP: -j without any numbers can be dangerous, as it'll just queue as many jobs as it can 12:25:43 <LordAro> which can very easily overwhelm computers 12:25:58 <petern> N550 / N570 are dual-core 12:26:02 <petern> Oh, they're also 64 bit. 12:26:15 <petern> From 2010. 12:26:52 <petern> Maybe wikipedia is wrong, I'm sure these were not 64 bit. 12:26:55 <dP> LordAro: oh, so that's a feature, I thought it did nproc 12:27:04 <dP> that explains why it kills my laptop xD 12:27:09 <LordAro> lol 12:27:23 <andythenorth> petern: 10262 builds, that's enough, right? 😛 12:27:31 <petern> I knew that 🙂 12:27:34 <andythenorth> builds -> merge 12:27:37 <andythenorth> like svn 12:27:40 <pickpacket> LordAro: it claims 4 cores, but I call bullshit... 12:27:43 <LordAro> i once managed to run -j1200 by accident (nested make processes..) 12:27:47 <pickpacket> 2GB RAM 12:27:54 <LordAro> pickpacket: well, -j4 is an option then 12:28:10 <LordAro> you probably won't be able to do much else while running, mind 12:28:27 <pickpacket> kinnda used to that, tbh 12:28:47 <pickpacket> can't leave a youtube tab open for too long in any web browser 12:29:19 <petern> Ah Z25xx an Z2760 are 32 bit with 2 cores and hyper-threading, from 2013. 12:29:48 <glx[d]> Well 2GB is what a single tab will eat 🙂 12:30:22 <petern> My VS Code is currently at 3.6GB. Somehow that's the largest process today. 12:31:00 <petern> Only using 20GB out of 64GB. Mind you it did restart this morning. 12:31:04 <pickpacket> petern: apparently I'm running the z3735f, which intel claims has 4 cores... https://www.intel.com/content/www/us/en/products/sku/80274/intel-atom-processor-z3735f-2m-cache-up-to-1-83-ghz/specifications.html 12:31:30 <petern> That supports 64 bit 12:31:45 <petern> At least, the chip does. Maybe the system nerfed it. 12:32:02 <pickpacket> 🤷 12:32:10 <petern> 64 bit with only 2GB RAM might be wasteful anyway 🙂 12:32:39 <pickpacket> I've accidentally put a Ubuntu 86_64 live USB stick in it, and that wouldn't boot at all 12:33:04 <glx[d]> Shared with "GPU" I guess 12:33:09 <pickpacket> probably 12:33:17 <pickpacket> 52% :D 12:33:32 <petern> Remember the original netbooks...? 12:33:37 <pickpacket> yeah 12:33:44 <petern> Asus Eee PC 12:33:45 <pickpacket> I had an ASUS eee 12:34:02 <pickpacket> the second gen, with the Intel Celeron M processor and the 9" screen 12:34:15 <pickpacket> the one with the Atom processor was released pretty soon after 12:34:29 <pickpacket> loved that little thing 12:34:34 <dP> wth is `sizeof...(i)` ? 12:34:59 <andythenorth> petern: 10262 works for me 😛 12:35:00 <andythenorth> merge? 12:35:01 <petern> With the ...? 12:35:20 <DorpsGek> [OpenTTD/OpenTTD] andythenorth commented on pull request #10262: Change: Support flipping shorter engines without NewGRF support. https://github.com/OpenTTD/OpenTTD/pull/10262#issuecomment-1359293168 12:35:31 <LordAro> length of vararg template parameters 12:35:44 <petern> Magic 😒 12:35:44 <LordAro> https://en.cppreference.com/w/cpp/language/sizeof... 12:36:06 <dP> that freaking thing breaks even links xD 12:36:14 <LordAro> :D 12:36:17 <dP> tried to google it also before asking xD 12:37:25 <petern> Doesn't really seem related to sizeof() tbh. Silly cpp specs. 12:38:32 <LordAro> not really, no 12:38:33 <dP> I wrote some templates, now I dread hitting compile... 12:39:08 <petern> Hmm, definitely still feeling a bit off. Maybe menopause. 12:40:36 <andythenorth> I am still covid +ve 12:40:37 <andythenorth> such 12:40:48 <andythenorth> right what shall we do today? 12:40:53 <petern> 10262 12:40:56 <dP> at least my laptop doesn't go to 100 degrees on compile after I cleaned it 12:41:25 <petern> Should I install Debian on my "new" Laptop? 12:41:35 <andythenorth> who can merge 10262? 😛 12:41:57 <petern> It's got Windows on it atm and it's a bit slow. 12:42:44 <LordAro> andythenorth: i am covid -ve, yet still ill 12:46:28 <petern> Hmm, my Christmas tree is dropping needles. 12:47:18 <petern> Which is a feat, as it's not real 12:47:38 <TallTyler> Have you been watering it with sufficient fake water? 12:47:56 <petern> Oh, this is the wrong laptop. 12:49:28 <dP> oh dear, compile errors overflowed the console buffer 12:49:33 <dP> gotta love templates... 12:50:08 <LordAro> nice 12:54:06 <andythenorth> can 10262 yolo? or is it some kind of community management needed? 12:54:45 <LordAro> i'd like someone with knowledge of grf to review it 12:54:48 <andythenorth> existing grfs ...are probably less broken....in most cases? 12:54:51 <LordAro> like frosch 13:07:29 <TallTyler> https://cdn.discordapp.com/attachments/1008473233844097104/1054746866077683772/infrastructure.png 13:07:29 <TallTyler> https://cdn.discordapp.com/attachments/1008473233844097104/1054746866434183268/Test_Savegame.zip 13:07:29 <TallTyler> Okay, need some help here because I'm stuck stuck. I'm adding a scrollbar to the company infrastructure GUI but the `DrawPixelInfo` clipping region isn't sized properly, either vertically or horizontally (see the clipped text in the screenshot, and of course the completely missing total widget). When I comment out that code, it works fine. 13:07:29 <TallTyler> My code is: https://github.com/OpenTTD/OpenTTD/commit/ec25754426bacaececf2894eb1b6d66a24a63d13 13:07:29 <TallTyler> Based on a JGRPP commit: https://github.com/JGRennison/OpenTTD-patches/commit/f37575d170609080c107c397200d25c3173e9079 13:09:33 <TallTyler> Big differences between my commit and JGRs are all the chunky bevel changes, as well as continuing to use `Rect r` instead of `int width` in `DrawCountLine()` - changing that draws part of the count widget but does not fix it entirely. 13:22:11 <DorpsGek> [OpenTTD/OpenTTD] PikkaBird commented on pull request #10256: Fix #10248: Ground sprites depend on foundation sprite offsets. https://github.com/OpenTTD/OpenTTD/pull/10256#issuecomment-1359342271 13:39:01 *** Markk_ has joined #openttd 13:40:55 *** Markk_ is now known as Markk 13:49:19 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #10264: Fix: Incorrect available height for dropdowns due to unsigned promotion. https://github.com/OpenTTD/OpenTTD/pull/10264 13:50:04 <LordAro> oh hey, that was definitely me 13:50:43 <petern> UI scaling. 13:50:49 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #10264: Fix: Incorrect available height for dropdowns due to unsigned promotion. https://github.com/OpenTTD/OpenTTD/pull/10264#pullrequestreview-1224527139 13:51:09 <LordAro> sure? i did both max -> std::max, and made dropdown heights(?) unsigned 13:53:03 <petern> Nope, the std::max was still int until UI scaling, as the WD...Verticaul() returns uint. 13:53:20 <LordAro> fair 13:53:20 <andythenorth> ok more variants? 13:53:30 * andythenorth forgot what was supposed to be getting done 13:53:39 <andythenorth> wasn't there NRT Road Hog to do? 13:53:49 <andythenorth> hmm variants for road vehicles 13:53:57 <andythenorth> intriguing 13:54:19 <petern> Hmm, potentially the earlier one should be handled too, oops 13:55:08 <petern> I don't think that one can underflow though. 13:56:03 <petern> Okay, it can 🙂 13:56:19 * petern fixes 13:57:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #10264: Fix: Incorrect available height for dropdowns due to unsigned promotion. https://github.com/OpenTTD/OpenTTD/pull/10264#pullrequestreview-1224527139 13:57:16 <petern> Sorry Aro! 13:57:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10264: Fix: Incorrect available height for dropdowns due to unsigned promotion. https://github.com/OpenTTD/OpenTTD/pull/10264 13:57:22 <petern> LordAro 13:57:34 <petern> What was that shortening? 3/7ths 13:58:11 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #10264: Fix: Incorrect available height for dropdowns due to unsigned promotion. https://github.com/OpenTTD/OpenTTD/pull/10264#pullrequestreview-1224538557 13:58:59 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10264: Fix: Incorrect available height for dropdowns due to unsigned promotion. https://github.com/OpenTTD/OpenTTD/pull/10264#issuecomment-1359402274 13:59:02 <petern> 🙂 14:19:45 <andythenorth> oops 14:19:49 <andythenorth> wrong branch 😛 14:28:54 <petern> Oops? 14:29:25 <andythenorth> tried loading variants grf in action-1-removal openttd 😛 14:32:04 *** WormnestAndroid has quit IRC 14:39:27 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #10264: Fix: Incorrect available height for dropdowns due to unsigned promotion. https://github.com/OpenTTD/OpenTTD/pull/10264 14:57:11 <petern> Ahh 14:57:41 <LordAro> hhA 15:01:32 <Pruple> a-ha 15:01:43 <andythenorth> take on me 15:01:50 <andythenorth> hmm white pixels 15:01:54 <andythenorth> who added those to Horse? 15:02:27 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1054775798973878302/image.png 15:02:27 <andythenorth> such narrow liveries meanwhile 15:03:32 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1054776073646243941/image.png 15:03:33 <andythenorth> hmm this red isn't consistent 15:03:46 <andythenorth> the vans look different to the railcar 15:04:08 <andythenorth> 'quirks' 15:12:50 <andythenorth> was naptime? 15:19:13 *** WormnestAndroid has joined #openttd 15:20:56 <petern> nyes 15:32:46 <andythenorth> OpenTTD looks like it will be done soon? 15:32:50 <andythenorth> complete 15:35:11 <Pruple> still need to add smoke deflectors to the bevels 15:46:02 <Pruple> maybe I should learn to do the OpenTTD 15:46:25 <Pruple> try and implement some trivial stuff 🙂 15:49:20 <petern> Bevel deflectors? 15:49:35 <dP> I might have created a monster... <https://github.com/citymania-org/cmclient/blob/13.0/src/citymania/generated/cm_gen_commands.cpp> 15:49:46 <dP> and that's a somewhat optimized version already xD 15:49:50 * andythenorth implements 'tidying the house' 15:54:59 <Pruple> or I could just keep doing "it's a bug that this feature is missing" bug reports, seems to be working so far this week 🙂 15:55:18 <TallTyler> I can recommend "learning to do the OpenTTD" 15:58:09 <LordAro> dP: what exactly am i looking at? 15:58:52 <TallTyler> Hmm, police chased someone down the street in front of my apartment with guns drawn a few minutes ago, now they have bigger guns and dogs. Maybe I don't want to be here for a while. 15:58:56 <TallTyler> Oh America 15:59:14 <LordAro> 'murica 16:01:20 <dP> LordAro: well, I needed a command container so I decided to auto-generate some polymorphic classes since I'm too lazy to figure out how to do that with templates, but then I noticed that callback is templated and all hell broke lose xD 16:07:20 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1054792127885869076/Evilbottom_Train_Depot_.png 16:07:20 <andythenorth> ok this fancy livery then? 16:10:20 <petern> Why the brake van there? 16:11:35 <petern> LordAro, in terms of what he is trying to achieve, rather than what he's done... he needs custom command callbacks, and the new template command system cut that off from working, I think. 16:11:56 <petern> At least, that's one part of it. 16:12:32 <dP> That's not the part I did there though xD 16:13:15 <petern> True 16:13:40 <dP> there I was making code like this possible: 16:13:40 <dP> https://github.com/citymania-org/cmclient/blob/13.0/src/citymania/cm_station_gui.cpp#L210 16:14:36 <andythenorth> petern: chlorine tankers, you wouldn't want your pixel driver to risk death now 16:14:45 <andythenorth> that brake van makes all the difference in a crash 16:14:48 <petern> Yes 16:14:59 <dP> admittedly that could've been done with lambdas but i also need ability to store commands for other stuff 16:14:59 <petern> Variants livery flag? 16:20:31 <andythenorth> I doubt it 16:20:37 <andythenorth> maybe later 😛 16:20:58 <andythenorth> 30% discount on replacing within variant group? 😛 16:21:01 <andythenorth> then base cost for that 16:21:06 <andythenorth> such spec 16:22:33 <petern> Without knowing what a flag might do it's tricky 16:27:55 <andythenorth> very 16:28:11 <andythenorth> did Aro approve the variants patch yet? 😛 16:28:13 <andythenorth> or anyone 16:28:30 <LordAro> i am not someone who knows grf well enough to go near that 16:30:00 <petern> I should rebase and squash some of the commits. 16:34:11 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1054798885106745354/image.png 16:34:11 <andythenorth> such 16:34:21 <andythenorth> CC for the flashes, or realistic blue? 16:35:48 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1054799292038139934/image.png 16:36:01 <andythenorth> can always use group colour for realisticism 16:36:18 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1054799415677825064/image.png 16:40:40 <petern> Group colour is useless remember 16:42:21 <andythenorth> something something disagree 16:43:07 <petern> It was the best thing since sliced bread, but also the worst thing. 16:43:32 <andythenorth> hmm sliced bread 16:43:56 <andythenorth> if we buy loaves for a bit, my kids think they're the best thing ever, much better than sliced bread 16:44:07 <andythenorth> then if we switch back to sliced bread, it's the best thing ever again 16:44:21 <petern> Yu 16:46:24 <andythenorth> oof Horse was supposed to not have asymmetrical liveries on symmetrical vehicles 16:46:25 <andythenorth> oh dear 16:47:24 <andythenorth> requires greater drawing skill 😛 16:47:58 <andythenorth> well this seems to work 16:48:13 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1054802417675411549/image.png 16:49:44 <petern> 10262 broke it? 16:50:39 <petern> Or you just drew it wrong? 16:52:38 <andythenorth> it's fine 16:52:50 <andythenorth> super realistic 16:52:56 <andythenorth> new Horse: 1:1 accuracy 16:53:06 <andythenorth> total fidelity to RL 16:53:42 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1054803796657705011/image.png 16:53:42 <andythenorth> all your vans of mail 16:53:56 <petern> Cramped 16:54:04 <andythenorth> narrowest gauge 16:54:16 <andythenorth> looks like metro eh 16:54:20 <petern> They're all the same. Random may be nice after all 😉 16:54:44 <andythenorth> I'll do a random mail thing 16:54:50 <andythenorth> moar dice 16:54:56 <petern> Is this variants or flipping? 16:55:00 <andythenorth> this is variants 16:55:11 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1054804169451634789/image.png 16:57:38 <andythenorth> 6 more mail vans to add liveries to 16:57:41 <andythenorth> and some railcars 16:58:04 <andythenorth> if this PR goes off to die, I'll be doing my own patchpack 😛 17:00:52 *** nielsm has joined #openttd 17:10:49 *** wallabra has joined #openttd 17:13:13 <petern> Problem with allowing separate font size in game is it makes the UI go all wonky again. 17:13:59 <petern> https://cdn.discordapp.com/attachments/1008473233844097104/1054808899976433795/image.png 17:16:09 *** wallabra has quit IRC 17:16:22 *** wallabra has joined #openttd 17:22:15 *** Flygon has quit IRC 17:23:22 *** Wolf01 has joined #openttd 17:35:00 <petern> Of course you can do this with the config anyway. Hm. 17:51:37 <andythenorth> hmm 17:54:13 <TallTyler> andythenorth: There’s a couple bugs reported in the PR, including cargo filter not working for non-train vehicle types 17:54:36 <andythenorth> there are 18:19:31 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #10263: [Crash]: Assertion failed https://github.com/OpenTTD/OpenTTD/issues/10263 18:23:53 <glx[d]> hmm so it's an AI building a vehicle, and tile is {value=0xffffffff } 18:24:22 <petern> AI sent an incorrect command? 18:26:07 <glx[d]> there should be validation 18:26:28 <glx[d]> seems we don't have map size in the log 18:34:23 <glx[d]> hmm but the tile is not validated it seems 18:39:13 <glx[d]> doc says "The tile at depot has a depot that can build the engine and is owned by you. " as precondition but I don't see any check 18:39:30 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on issue #10263: [Crash]: Assertion failed https://github.com/OpenTTD/OpenTTD/issues/10263 18:41:08 *** gelignite has joined #openttd 18:42:06 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/a857ed824071b1b0123bbe2cbd56218f79d01bf4 18:42:07 <DorpsGek> - Update: Translations from eints (by translators) 18:45:33 *** wallabra has quit IRC 18:48:40 <petern> Missing check with the new command system? 18:48:50 *** wallabra has joined #openttd 18:49:29 <petern> TileIndex is implicitly checked somewhere apparently, but perhaps not for AI commands? 18:51:33 *** ag has quit IRC 18:59:10 <TallTyler> Hmm, commands can't call other commands? I got a `IsTopLevel()` assert trying to change all timetable waiting times at once 18:59:21 <glx[d]> yes 18:59:30 <glx[d]> that's expected 18:59:53 <TallTyler> Any way to avoid it? Just use a regular function to call the command? 19:00:40 <glx[d]> multiple commands in a loop (not efficient) or a new command for all at once 19:02:35 <TallTyler> Interesting 19:02:48 <TallTyler> JGRPP seems to let you nest commands 🙂 19:03:11 <TallTyler> Upstreaming is getting more and more different from the original implementation as vanilla and JGRPP diverge 19:03:21 <TallTyler> Not really a complaint, just an observation 🙂 19:03:51 <FLHerne> so long as it doesn't end up with the full cirdan experience 19:22:22 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10220: Feature: Engine variant groups https://github.com/OpenTTD/OpenTTD/pull/10220 19:22:37 <dP> petern: yeah, check seems to be in CommandHelper::Do but scripts use ScriptDoCommandHelper that has its own Do 19:23:23 <JGR> TallTyler: No, it's not allowed there either 19:24:10 <JGR> But there is a helper for queuing a DoCommandP if already executing a command, only needed in some special cases 19:24:23 <petern> Hmm, I can make this changeset smaller actually. 19:25:00 <petern> And I should test non-train variants properly. 19:27:39 <dP> also, this seems to be checking the wrong argument xD <https://github.com/OpenTTD/OpenTTD/blob/master/src/command_func.h#L228> 19:27:51 <dP> first tile already seems to be extracted into location there 19:29:19 <dP> or is it just sent twice... 19:29:24 <TallTyler> JGR: `CmdBulkChangeTimetable` calls `CMD_CHANGE_TIMETABLE`, no? I never learned the types of DoCommands - it uses `DoCommandEx`, but I don't know what that means 🙂 19:31:46 <petern> Basically the difference is one is top level and the other is a "child" call. I believe. 19:32:09 <TallTyler> Does the new command system have an equivalent? 19:32:38 <petern> Should do 19:33:18 <petern> There's ::Post and ::Do 19:33:45 <TallTyler> I'm using ::Post right now and it doesn't like it 19:34:08 <petern> Use ::Do 🙂 19:34:21 <petern> ::Post for your top level call that needs to be Postedf 19:35:04 <TallTyler> Inner ::Do doesn't want an error message? 19:35:32 <TallTyler> No squiggly red line, let's try it 😛 19:37:12 <TallTyler> It works! 19:44:58 <petern> I suspect that's enough forum reading for me. 19:50:02 <andythenorth> lol 19:50:03 <andythenorth> no 19:50:46 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10220: Feature: Engine variant groups https://github.com/OpenTTD/OpenTTD/pull/10220 19:50:52 <TallTyler> Quite 19:51:50 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10220: Feature: Engine variant groups https://github.com/OpenTTD/OpenTTD/pull/10220#issuecomment-1360076018 19:52:06 <TallTyler> Yay! 19:52:15 <TallTyler> Time for Andy to merge it? 😛 19:56:17 <petern> Maybe reddit is a better read 19:56:28 *** supermop_toil has joined #openttd 19:57:02 <andythenorth> I don't have merge rights 19:57:04 <andythenorth> not even for nml 19:57:07 <andythenorth> I rescinded them 19:58:24 <glx[d]> Yeah we gave the rights, and Andy used them to remove them by himself 19:58:44 <TallTyler> If it weren't GRF spec I'd suggest we follow the chunky bevels example and merge it for faster testing, but I imagine we wouldn't want GRF authors wasting their time making stuff which might change 19:59:20 <glx[d]> Usual chicken and egg 20:00:00 <glx[d]> Not merged it's not tested, but once merge it's hard to touch the spec 20:00:39 <TallTyler> Especially those close to a release 20:02:07 <glx[d]> IIRC there's a way to build "releases" of PRs 20:04:12 <andythenorth> NRT had preview releases 20:04:21 <andythenorth> WASM is a thing, but it's a pain with grfs 20:04:48 <TallTyler> Especially GRFs not in Bananas 20:05:11 <andythenorth> like test grfs that get deactivated in vanilla 😛 20:05:19 <andythenorth> bananas has no facility for test content 😛 20:12:16 *** Wormnest has joined #openttd 20:26:46 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #10265: Feature: Ctrl-click to bulk edit timetable speeds/waiting times https://github.com/OpenTTD/OpenTTD/pull/10265 20:28:30 <petern> Release early, release often? 20:28:59 <petern> I did that at work last week. 20:29:21 <petern> I only wanted to test a CI to see about creating proper builds instead of compiling everything on my desktop. 20:29:52 <petern> Turns out when you've done that it's not much further to deploying to test, and deploying to production on a release tag... 20:30:14 <petern> I guess this is devops now :p 20:32:28 <LordAro> pretty much 20:33:37 <andythenorth> hmm 20:33:46 <andythenorth> yeah, time for medicine 20:34:37 <LordAro> medicine medicine, or medicinal medicine? 20:36:05 <andythenorth> medicinal 20:36:13 <andythenorth> covid has not left me yet 20:37:20 <petern> Can we split catenary poles into lower and upper parts? 20:37:43 <supermop_toil> OOOF 20:37:57 <supermop_toil> i was begging for that like 2ish years ago 20:38:08 <andythenorth> aren't they poles for overhead monorail? 20:38:17 <andythenorth> which certainly doesn't clip bridges or anything 20:43:21 <petern> I waste a while trying to get them to sort properly until I realised 😛 20:43:41 <petern> Overall I think I got them better, just those 1 or 2 cases when it'll bug out. 20:43:50 <petern> (And not possible to solved without splitting them) 20:54:58 <DorpsGek> [OpenTTD/OpenTTD] LC-Zorg opened issue #10266: [Bug]: Opening the Operating profit graph window requires selection from list https://github.com/OpenTTD/OpenTTD/issues/10266 20:56:30 <DorpsGek> [OpenTTD/OpenTTD] LC-Zorg opened issue #10267: [Bug]: Opening the Company League Table window requires selection from list https://github.com/OpenTTD/OpenTTD/issues/10267 20:56:48 <DorpsGek> [OpenTTD/OpenTTD] ldpl commented on issue #10266: [Bug]: Opening the Operating profit graph window requires selection from list https://github.com/OpenTTD/OpenTTD/issues/10266 20:56:53 <reldred> Zorgening 20:57:36 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on issue #10266: [Bug]: Opening the Operating profit graph window requires selection from list https://github.com/OpenTTD/OpenTTD/issues/10266 20:57:39 <DorpsGek> [OpenTTD/OpenTTD] LordAro closed issue #10266: [Bug]: Opening the Operating profit graph window requires selection from list https://github.com/OpenTTD/OpenTTD/issues/10266 20:57:42 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on issue #10267: [Bug]: Opening the Company League Table window requires selection from list https://github.com/OpenTTD/OpenTTD/issues/10267 20:57:45 <DorpsGek> [OpenTTD/OpenTTD] LordAro closed issue #10267: [Bug]: Opening the Company League Table window requires selection from list https://github.com/OpenTTD/OpenTTD/issues/10267 20:57:46 <LordAro> thanks dP :D 20:58:39 <LordAro> we do need an RC1 though 20:58:53 <andythenorth> variants 😛 20:59:01 <LordAro> not sure we can feasibly do a 25/12 release at this point regardless 20:59:07 <LordAro> 1/1 maybe 21:00:15 <TallTyler> RC1 is feature freeze if I’m not mistaken, and there are still several things in the 13.0 milestone 21:00:20 <TallTyler> Including variants 🙂 21:00:36 <LordAro> RC1 is the *beginning* of feature freeze 21:00:47 <TallTyler> I agree though that the full release will need to be New Years ish 21:01:01 <LordAro> @seen frosch 21:01:01 <DorpsGek> LordAro: frosch was last seen in #openttd 1 week, 3 days, 4 hours, 7 minutes, and 50 seconds ago: <frosch> actually weird. the ttd engines were so maxed to exactly 255, and then it's actually an uint16? 21:03:32 <DorpsGek> [OpenTTD/OpenTTD] LC-Zorg commented on issue #10266: [Bug]: Opening the Operating profit graph window requires selection from list https://github.com/OpenTTD/OpenTTD/issues/10266 21:04:48 <FLHerne> Christmas RC1? 21:05:05 <LordAro> seems plausible 21:16:52 <glx[d]> dP: check used to be in DoCommandPInternal() which was called from ScriptObject::DoCommand() it seems 21:18:57 <glx[d]> changed in https://github.com/OpenTTD/OpenTTD/commit/6691ee3b963ee3282490360bb3cc1ea09d0c58ea#diff-ac22a60707a03981462f89d298d38d96315cfd004dca710b2d8b05155c0b6137 21:32:19 *** m1cr0man has quit IRC 21:32:42 *** m1cr0man has joined #openttd 21:48:51 <TallTyler> Did you see frosch? 21:49:20 <LordAro> alas not 21:49:23 <andythenorth> frosch seems to be having a break 21:50:59 <TallTyler> Would frosch be upset if we merged variants without his input? 21:51:30 <petern> like nrt? 21:51:55 <TallTyler> I wasn’t in IRC for that 🙂 21:57:48 <petern> Neither was he. 21:58:57 <TallTyler> andythenorth: was variants frosch's idea originally? 21:59:13 <andythenorth> can't remember 21:59:22 <andythenorth> lost in time 21:59:25 <andythenorth> logs will know 21:59:38 <reldred> I think it’s a dangerous idea for any one single person to ‘own’ the GRF spec 21:59:41 <TallTyler> I really want to play with variants 🙂 21:59:44 <andythenorth> I was there and definitely partly to blame for variants 21:59:52 <andythenorth> someone said 'IDs are cheap' 22:00:49 <LordAro> reldred: it's more that someone like frosch often has insights that the rest of us miss 22:01:38 <LordAro> and by "insight", i mean "points out potential issues" 22:06:16 <JGR> On the other hand, it's unrealistic to expect new concepts to be absolutely perfect first time 22:06:23 <LordAro> true 22:07:02 <LordAro> i'm not suggesting delaying anything 22:07:10 <LordAro> just waiting if at all possible 22:07:18 <LordAro> the tricky bit is knowing whether waiting is a good idea 22:07:44 <JGR> Waiting by itself doesn't make anything happen 22:08:33 <reldred> Can't let 'perfect' be the enemy of progress. 22:09:06 <reldred> A good plan executed violently is better than a perfect plan executed never, and so on and so forth. 22:09:41 <TallTyler> I suppose we could release variants with an explicit warning to NewGRF developers that the spec could change and break their NewGRFs within some agreed-upon period of time, maybe a year 22:10:10 <TallTyler> "probationary period" for grf spec 🙂 22:10:14 <andythenorth> frosch isn't 100% wanting to be the guardian of the grf spec 22:10:34 <andythenorth> it's more a case of 'but who else?' I think 😛 22:10:49 <andythenorth> we did try to trick TrueBrain into learning grf 22:12:32 <petern> How is Iron Horse variants looking? 22:12:40 <andythenorth> drawing things 22:12:41 <petern> "test-case" 22:13:03 <petern> I think the basic functionally of variants is quite simple 22:13:03 <andythenorth> I can zip that for the issue if we want 22:13:04 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1054884166614913054/iron-horse.grf 22:13:28 <petern> It doesn't add any new callbacks or varactions (beyond 0xc6 which should exist already) 22:13:40 <petern> It's a property and some extra flags. 22:14:16 <petern> The parent/child tree stuff was stolen from Groups 22:14:42 <petern> The extra flags do affect vehicle things, but not really in a newgrf way 22:15:08 <JGR> TallTyler: The lack of any proper feature detection mechanism in the spec is part of the problem here 22:15:41 <petern> The only feature detection is based on follow TTDPatch 😄 22:16:56 <JGR> In branch, if I add something as a spec extension which turns out to be crap, I can just delete it, and GRFs won't break 22:17:35 <JGR> They'll do nothing or report an error just like when loaded in vanilla, it makes adding stuff much less of a huge commitment hurdle 22:18:30 <TallTyler> Is that specific to your branch? 22:18:38 <JGR> Of course 22:18:49 <TallTyler> How hard would it be to upstream that? 22:18:59 <dP> hm, do variants also sync intro dates? 22:20:05 <JGR> TallTyler: I do not think that my mechanism/implementation would be accepted 22:20:43 <JGR> As it is designed around the restriction that i don't have control of the spec or what vanilla may add in future 22:22:22 <andythenorth> dP: they should be compatible with the existing intro date sync 22:22:23 <JGR> For vanilla, you control the spec, so you can design it however you want without any such restrictions 22:22:41 <dP> also, I personally hate that same properties have different numbers for different vehicle types, butt that seems to be the norm in spec sadly 22:24:14 <JGR> TallTyler: It's described here anyway, if you fancy some light reading: <https://jgrennison.github.io/OpenTTD-patches/newgrf-additions.html#feature-test> 22:38:03 *** nielsm has quit IRC 22:39:21 <DorpsGek> [OpenTTD/OpenTTD] andythenorth commented on pull request #10220: Feature: Engine variant groups https://github.com/OpenTTD/OpenTTD/pull/10220#issuecomment-1360406103 22:46:51 <dP> dP: actually, is there any specific reason why nothing is being added to common vehicle properties anymore? 22:47:06 <petern> There are no common vehicle properties 22:47:19 <dP> huh? <https://newgrf-specs.tt-wiki.net/wiki/Action0/Vehicles> 22:47:23 <petern> It's not a separate namespace. 22:47:56 <andythenorth> ^ I went on this journey a few weeks ago 😛 22:48:11 <andythenorth> when I did the nml patch, and the different prop numbers stuck out as weird 22:48:24 <andythenorth> 'we are where we are' 22:48:58 *** gelignite has quit IRC 22:49:15 <petern> There is no "05" in common properties because it's rail vehicle track type 22:49:29 <petern> Or road/tram type 22:49:53 <dP> so what? they don't have to be consequent 22:50:39 <dP> it just seems like it's a choice between consequent numbering per type or consistent numbering across types 22:50:45 <dP> i'd rather chose the later 22:51:43 <petern> At least it's consistent that it's not consistent. 22:52:35 <dP> there are 6 common properties so it failed even that :p 22:53:08 <petern> Yeah, we didn't create though. 22:53:38 <petern> Let's face it, if you were to come up with a new spec now... you wouldn't choose NFO. 22:53:47 <andythenorth> I might 22:54:05 <andythenorth> discord isn't so kickable eh 22:54:12 <andythenorth> I miss that about irc 22:54:31 <JGR> We could design a Glorious Second System as GRFv9 😛 22:54:44 <petern> Back in the day people wanted ini files. 22:54:54 <andythenorth> how's the ini file system working out? 22:55:05 <petern> NML hides these numbers anyway. 22:55:09 <petern> NML is basically DNS for NFO. 22:56:01 <JGR> It does quite a bit more than just that 22:56:06 <andythenorth> can I be arsed to draw more mail vehicles tonight? 22:56:08 <andythenorth> 'nope 22:56:17 <petern> Goes it throw out variants? 22:56:24 <andythenorth> I would play OpenTTD, but I don't know which branch 😛 22:56:26 <petern> Can't agree on what numbers to use 22:56:33 <andythenorth> so many branches 22:56:39 <JGR> andythenorth: AndyPP? 22:56:49 <andythenorth> horrific idea 22:57:24 <andythenorth> meanwhile, anyone know why `/src/3rdparty/fmt/format.h` is patched locally (by me)? 22:57:31 <andythenorth> I keep having to stash and unstash it 22:57:56 <andythenorth> diff is stuff like 22:57:56 <andythenorth> `- if (std::signbit(value)) { // value < 0 is false for NaN so use signbit. 22:57:56 <andythenorth> + if (false) { // value < 0 is false for NaN so use signbit.` 22:58:08 <JGR> https://discord.com/channels/142724111502802944/1008473233844097104/1032753443808489583 22:58:19 <andythenorth> I am so far away from even beginning to understand why I patched that 22:58:55 <andythenorth> I understand the comment a bit 😛 22:59:11 <LordAro> something to do with signbit not existing for the version of xcode, iirc? 23:00:53 <andythenorth> plausible 23:07:44 * andythenorth draws mail cars 23:11:50 <petern> Oh god. 23:11:56 <TallTyler> https://cdn.discordapp.com/attachments/1008473233844097104/1054898979827097640/IMG_4163.png 23:11:56 <TallTyler> 🤔 23:11:59 <petern> I started a 512x1024 world gen 23:12:14 <petern> In a full debug build. 23:12:25 <TallTyler> With rivers? 23:12:35 <petern> Yup 23:12:41 <LordAro> F 23:12:41 <TallTyler> Real question,should I add a setting to toggle wide rivers? 23:12:48 <petern> And Iron Horse 23:12:51 <petern> IMHO, no 23:25:06 *** keikoz has quit IRC 23:25:32 <petern> tt-forums needs chunky bevels 23:26:46 <JGR> That reminds me, usually tt-forums has a garish Christmas theme this time of year 23:26:56 <petern> Please no 😄 23:42:44 *** Wolf01 has quit IRC 23:52:56 <supermop_toil> LATER 23:54:06 <DorpsGek> [OpenTTD/OpenTTD] LC-Zorg opened issue #10268: [Bug]: List of available roads/tracks: Removing the scroll bar makes some road/track types unavailable if the player is using the enlarged GUI https://github.com/OpenTTD/OpenTTD/issues/10268 23:56:53 <LordAro> zorg's on a roll today 23:58:36 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on issue #10268: [Bug]: List of available roads/tracks: Removing the scroll bar makes some road/track types unavailable if the player is using the enlarged GUI https://github.com/OpenTTD/OpenTTD/issues/10268 23:58:39 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #10268: [Bug]: List of available roads/tracks: Removing the scroll bar makes some road/track types unavailable if the player is using the enlarged GUI https://github.com/OpenTTD/OpenTTD/issues/10268 23:58:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #10268: [Bug]: List of available roads/tracks: Removing the scroll bar makes some road/track types unavailable if the player is using the enlarged GUI https://github.com/OpenTTD/OpenTTD/issues/10268 23:59:10 <petern> "Removing the scrollbar" yea... cos that was definitely a deliberate action. 23:59:40 <LordAro> no real reason to suppose it wasn't 20222022-12-21T10:32:35 <Pruple> 👍