Times are UTC Toggle Colours
01:07:17 *** WormnestAndroid has joined #openttd 01:38:47 *** bryjen has quit IRC 14:35:49 <petern> Hmm, new jockey wheels to fit but it's raining, boo 14:43:38 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #10580: Backport master into release/13 https://github.com/OpenTTD/OpenTTD/pull/10580 14:45:08 <Rubidium_> why would you need SKIP in GS? You can just specify the index for parameters, just like https://github.com/OpenTTD/OpenTTD/blob/master/src/lang/english.txt#L5520, right? 14:46:01 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #10586: Codechange: Use a shared_ptr for viewport overlay. https://github.com/OpenTTD/OpenTTD/pull/10586#pullrequestreview-1367085340 14:48:21 <dP> because I want to use strings with less parameters than requested 14:48:38 <dP> like if it's STRING4 I want to sometimes just do 2 and skip two more 14:49:09 <dP> rn I have to pass empty strings around instead 14:49:45 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #10585: Fix #10574 -- revert the change and don't list unavailable rail/road types to game script. https://github.com/OpenTTD/OpenTTD/pull/10585#pullrequestreview-1367093587 14:50:46 <dP> though I guess RAW_STRING will help greatly with that 14:56:54 <Rubidium_> it's not allowed for a GS to do STR_BLA: {STRING4} {STRING2} {STRING}? And then pass STR_FIRST: {NUM}? It needs to actually consume four? 14:58:13 <Rubidium_> as that's exactly what happens for STR_ORDER_TEXT where for a waypoint it just sets one parameter for the first string, and the second string gets defined at index 5 with a parameter in 6 & 7, and the third is defined at index 8. 14:59:23 <Rubidium_> or is it that the string validation is too pedantic and it wants you to set index 2-4 as well? That's something a {SKIP} in the sub string is not going to solve 15:00:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10585: Fix #10574 -- revert the change and don't list unavailable rail/road types to game script. https://github.com/OpenTTD/OpenTTD/pull/10585#pullrequestreview-1367112359 15:03:18 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #10583: Fix: Clicking on editbox clear button didn't take account of padding. https://github.com/OpenTTD/OpenTTD/pull/10583#pullrequestreview-1367117126 15:06:40 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #10586: Codechange: Use a shared_ptr for viewport overlay. https://github.com/OpenTTD/OpenTTD/pull/10586 15:07:20 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #10583: Fix: Clicking on editbox clear button didn't take account of padding. https://github.com/OpenTTD/OpenTTD/pull/10583 15:08:56 <dP> Rubidium_: afiact, no, it needs to actually consume all, and #10492 added checks for that (was just ub before) 15:09:26 <dP> breaking half of gamescripts in the process 😆 15:10:41 <dP> oh, btw, if it's backported probably need to do something about that in 13.1 15:11:11 <dP> ah, it was removed, nvm 15:12:18 <petern> Yeah, I get GS errors now... 15:12:40 <Rubidium_> well, maybe it's as easy to solve as making the check slightly more lenient. So that STRINGN consumes at most N parameters 15:13:10 *** gelignite has joined #openttd 15:13:14 <dP> if it's possible, yes 15:14:29 <dP> if not would probably need to remove the check for older api compatibility 15:21:06 <dP> though allowing less may cause new problems as params are flat outside gs so there is no way to check if it actually consumed as many as it was given 15:21:51 <dP> so if you accidentally consume less it will shift params for other strings 15:22:46 <dP> though it's probably the case already anyway 15:25:51 <Rubidium_> that's the whole point of STRINGN, it should just behave as if it has consumed the string and N parameters, regardless of the number of parameters that were actually consumed by the substring 15:26:07 <Rubidium_> if it doesn't, then that's a bug (IMO) 15:27:50 <dP> ah, you mean auto-skip if it consumed less? 15:31:57 <Rubidium_> yes, that's how it's supposed to behave 15:34:53 <dP> been a while since I tested it but I don't think it did that before 10492 15:34:56 <dP> maybe does now, idk 15:50:35 <dP> https://cdn.discordapp.com/attachments/1008473233844097104/1091389087308583063/Screencast_from_31-03-23_194918.webm 16:23:27 <petern> Hmm 16:25:08 *** Wolf01 has joined #openttd 16:27:23 <andythenorth> improved industry placement you say? 16:30:42 <DorpsGek> [OpenTTD/OpenTTD] LC-Zorg commented on issue #10578: [Bug]: No way in GUI to select a previous version of AI or GS https://github.com/OpenTTD/OpenTTD/issues/10578 16:35:19 <glx[d]> Rubidium_: parameters are added based on the substring "parsing" and there's no padding if the substring consumes less than expected 16:40:26 <glx[d]> in most cases GS broken by the validation do the opposite, they consume more than expected 16:46:01 <glx[d]> example from BeeReward ``` 16:46:01 <glx[d]> destination_string = GSText(GSText.STR_TOWN_NAME, destination); 16:46:01 <glx[d]> ... 16:46:01 <glx[d]> goal_text = GSText(GSText.STR_COMPANY_GOAL_REWARD, cargo.cid, this.wanted_amount, destination_string, this.reward);``` 16:46:28 <glx[d]> with `STR_TOWN_NAME :{WHITE}{TOWN}` and `STR_COMPANY_GOAL_REWARD :Deliver {GOLD}{CARGO_LONG} {ORANGE}to {STRING}{ORANGE} for {WHITE}{STRING}{CURRENCY_LONG}` 16:47:14 <glx[d]> they added an extra `{STRING}` to discard the parameter from the first one 16:56:03 <DorpsGek> [OpenTTD/OpenTTD] SpartaWarsec opened issue #10588: [Bug]: Server time out (netzwork traffic) https://github.com/OpenTTD/OpenTTD/issues/10588 16:57:15 <DorpsGek> [OpenTTD/team] glx22 commented on issue #413: [sv_SE] Translator access request https://github.com/OpenTTD/team/issues/413 23:28:07 *** lobstarooo___ has joined #openttd 23:29:25 *** lobstarooo has joined #openttd 23:36:12 *** lobstarooo___ has quit IRC 23:36:16 *** lobstarooo is now known as lobstarooo___