Times are UTC Toggle Colours
00:01:15 <xarick> particularly that (7) 00:02:41 <Eddi|zuHause> goddess_ishtar: i think rather the latter. 00:08:35 <peter1138> It's basically just another meme. 00:08:58 <goddess_ishtar> are there any truly *bad* features? 00:11:24 <peter1138> Uh... I have some "pigs in blankets" flavour pork scatchings. 00:11:34 <peter1138> So basically pork flavour pork scratching. 00:11:43 <truebrain> goddess_ishtar: Trains come to mind 00:12:06 <peter1138> aircraft distance limits 00:12:12 <truebrain> Towns 00:12:26 <truebrain> 8bpp 00:13:38 <truebrain> Using TCP for BaNaNaS .. (now it is getting real :P) 00:14:47 <peter1138> We should use floppy disks. 00:16:15 <truebrain> And Hercules screens 00:16:23 <truebrain> Green/black or bust 00:16:59 <peter1138> My first VGA monitor (13", 640x480) had a switch on the back to switch between green, amber, and RGB. 00:17:38 <peter1138> Amber was achieved by disconnect blue. Which wasn't quite the right effect :D 00:18:28 <truebrain> I had this Hercules screen, but as it is phosphor based, it kept glowing when I turned it off ... was rather bright for a while 😛 00:18:50 <peter1138> They didn't flicker though. 00:22:19 <truebrain> Then they did for years, and now they no longer do again 😄 00:22:26 <truebrain> Circles, round round 00:26:24 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1184652579045658754/image.png?ex=658cc0b0&is=657a4bb0&hm=5ca298176b4135e616a475112dd9c98f3a5919cab70102c791c45abcb8f7f971& 00:26:24 <xarick> okay, it's fine after all 00:26:41 <xarick> 4 is still less than 7 00:42:12 <talltyler> _glx_: Ah, not sure how to solve that… I will try again tomorrow. 🙂 00:43:01 <talltyler> The unused parameter should be easy enough, although I’m not sure what to do with the double declaration since I need access from other files. Maybe an extern instead of putting it in a header. 00:43:48 <_glx_> you can check how it's done for other similar callbacks 00:48:45 <_glx_> ho look for InvalidateWindowClassesData() 00:48:46 <Eddi|zuHause> i don't remember who invented the BAD FEATURE... it was either V453000 or pruplebird 00:51:43 <peter1138> Hmm, 41 commits is... a lot. 00:51:46 <talltyler> Oh, good idea 00:51:47 <Eddi|zuHause> also, the first truely *bad* feature i remember is the original PBS implementation 00:53:11 <peter1138> I don't think that really qualifies. It was a good feature that ended up as a bad implementation. 00:53:36 <_glx_> it's declared in window_func.h which is included in settings_table.cpp 00:53:56 <_glx_> and not redeclared in .ini 🙂 00:54:06 <Eddi|zuHause> after that was a disagreement and back&forth about bridges. 00:56:28 <Eddi|zuHause> anyway, even disregarding the implementation details, the current path signals are a way better concept... 00:57:26 <Eddi|zuHause> anyway^2 the newgrf specs have plenty of *legacy* "features" that you could call *bad* 00:59:25 <_glx_> yeah stations spec is bad 🙂 01:00:12 <_glx_> bridge feature is very limited too 01:03:49 <peter1138> Well, we lost a developer over bridges. 01:04:17 <peter1138> And Simutrans is much better for it. 01:04:57 <peter1138> I'd dig out my newgrf bridges branch but there's a much newer one i believe. 01:06:19 <peter1138> And it wasn't a branch, because it was still SVN. 01:06:38 <_glx_> oh you had a patch for that 🙂 01:10:56 <peter1138> Huh, I've got an OpenAL sound driver patch here. Why? 01:11:03 <peter1138> It's for r13060. 01:11:53 <peter1138> Looks pretty bad, it uses a processing loop instead of callbacks. 01:17:23 <peter1138> Hmm, an old "routing" patch 01:17:28 <peter1138> I wonder who wrote this. 01:20:14 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #11582: Codechange: Cargo filters no longer take an index. https://github.com/OpenTTD/OpenTTD/pull/11582 01:25:05 <DorpsGek> [OpenTTD/OpenTTD] JGRennison opened pull request #11583: Codechange: Use MakeParameters with GetNextParameter in FormatString instead of StringParameters subspan https://github.com/OpenTTD/OpenTTD/pull/11583 01:26:30 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #11582: Codechange: Cargo filters no longer take an index. https://github.com/OpenTTD/OpenTTD/pull/11582#pullrequestreview-1780758248 01:32:34 <talltyler> Here’s the newer bridge PR you may be referencing: https://github.com/OpenTTD/OpenTTD/pull/9161 01:32:59 <talltyler> With some helpful comments from Zephyris 🙂 01:33:24 <peter1138> Ah yes, 1 massive commit. 01:35:04 <talltyler> Oh, I didn’t even notice 😦 01:37:29 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #11583: Codechange: Use MakeParameters with GetNextParameter in FormatString instead of StringParameters subspan https://github.com/OpenTTD/OpenTTD/pull/11583#pullrequestreview-1780778374 01:37:50 <peter1138> Use of MultiMap<> is a big no-no IMHO. 01:42:00 <peter1138> Big array of 64,000 possible bridge designs. 01:42:23 <peter1138> That's probably borrowed from objects which also used to use a giant array until I fix it. 01:42:36 <peter1138> I think this is "yeah, needs a ground up rewrite" PR :( 01:44:51 <peter1138> Nearly 2am is not the right time to look at this :) 01:46:06 <Rubidium> is looking really that bad? :D 01:48:05 <Rubidium> as long as you do not try to fix it, it ought to be just fine ;) 01:48:50 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #11582: Codechange: Cargo filters no longer take an index. https://github.com/OpenTTD/OpenTTD/pull/11582 03:30:32 <_glx_> CI will start to fail very soon, thanks to <https://github.com/microsoft/vcpkg/commit/146441473c8176a5509c6eac979860f37f834730> included in latest images 03:31:13 *** Wormnest has quit IRC 03:51:20 <_glx_> opened an issue <https://github.com/microsoft/vcpkg/issues/35670> 03:54:43 *** D-HUND has joined #openttd 03:58:00 *** debdog has quit IRC 04:59:05 *** Tirili has quit IRC 05:01:54 *** keikoz has joined #openttd 07:15:21 *** Flygon has quit IRC 07:58:56 *** HerzogDeXtEr has joined #openttd 09:08:24 *** Hanicef has joined #openttd 09:28:48 <xarick> hi 09:57:42 *** thelounge345 has quit IRC 09:58:59 *** dihedral has quit IRC 10:00:40 <peter1138> char8_t is quite a fuckup isn't it... 10:00:56 *** thelounge345 has joined #openttd 10:02:32 <peter1138> At least, in C++20. 10:03:12 *** dihedral has joined #openttd 10:11:38 <Hanicef> peter1138: never even heard of it, does it have the same issue as char? 10:13:17 <Hanicef> (that is, it's signedness is implementation-defined) 10:16:10 <peter1138> No, that's basically the reason it exists. 10:17:12 <peter1138> https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2513r4.html#intro 10:18:19 <Hanicef> oof, yeah, that's a big fuckup 10:18:45 <Hanicef> especially for a language that has a long history with being backwards-compatible 10:49:49 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1184809464512131103/image.png?ex=658d52cd&is=657addcd&hm=0108f4dd5bd6222d6e18a1aa3232c7218b286e73ad6826df299496e33c1ba63a& 11:02:27 <peter1138[d]> https://www.google.com/search?q=convert+time_point+to+integer 11:20:40 <andythenorth> peter1132023-12-14T22:46:30 *** HerzogDeXtEr has quit IRC 22:58:28 *** Wolf01 has quit IRC 23:23:46 <xarick> hmm... https://gist.github.com/SamuXarick/fc93c9beebc97747134e5a4ccb3c9dfb 23:23:58 <xarick> question ^^ 23:25:28 <xarick> I think Count is heavy 23:25:45 <xarick> better just test it right away 23:26:20 <xarick> oh, I'm dumb, the first method also has a count 23:29:58 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #11588: Change: Split ScriptDate:: into Calendar and Economy variants https://github.com/OpenTTD/OpenTTD/pull/11588 23:29:58 <_glx_> I think the less intensive would be to not use GSList 23:33:20 <xarick> oh boy mass placing signs is such a good feature! 23:33:40 <xarick> thx for whoever came up with the Async mode idea 23:37:31 *** Hanicef has quit IRC 23:38:52 <_glx_> the main idea was for extra text in industry (or town, can't remember) window, and story book updates 23:41:07 <xarick> 🙂 23:41:31 <xarick> removing 64k signs takes like 2 seconds now 23:41:53 <xarick> it takes forever without async 23:42:10 <_glx_> not forever, 64k ticks 🙂 23:54:56 <talltyler> @glx #11588 crashes OpenTTD entirely when trying to load a GS. I have no idea why and need some help. 😦 (no rush, I’m frustrated and done for the day, but maybe you could take a look sometime and see what I’m missing)