Times are UTC Toggle Colours
03:07:49 *** gnu_jj_ has joined #openttd 03:35:44 *** D-HUND has joined #openttd 04:13:08 <DorpsGek> [OpenTTD/OpenTTD] ldpl commented on discussion #12281: NewGRF House Spec Improvements https://github.com/OpenTTD/OpenTTD/discussions/12281 04:13:37 *** D-HUND is now known as debdog 04:19:25 <DorpsGek> [OpenTTD/OpenTTD] zacc opened pull request #12290: Change: Calculate occupancy of drive through road stops from most recent entered vehicle https://github.com/OpenTTD/OpenTTD/pull/12290 04:41:29 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/0cff40dd19a52ebd1b2435991dab9ebfdacbcec1 04:41:30 <DorpsGek> - Update: Translations from eints (by translators) 04:44:47 <DorpsGek> [OpenTTD/OpenTTD] zacc updated pull request #12290: Change: Calculate occupancy of drive through road stops from most recent entered vehicle https://github.com/OpenTTD/OpenTTD/pull/12290 05:08:32 *** keikoz has joined #openttd 05:28:52 <DorpsGek> [OpenTTD/OpenTTD] Release workflow was not successful https://github.com/OpenTTD/OpenTTD/actions/runs/8259771456 05:39:36 *** Ox7C5 has joined #openttd 06:27:07 *** Flygon has joined #openttd 14:02:58 <_glx_> I may have a way to prevent the window 14:12:36 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #12291: Codechange: [Win32] Disable assert message box when no GUI https://github.com/OpenTTD/OpenTTD/pull/12291 14:15:46 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic approved pull request #12286: Fix #12279: Update random path each step https://github.com/OpenTTD/OpenTTD/pull/12286#pullrequestreview-1934308264 14:17:30 <kuhnovic> xarick: go for the double kill! #12285 😉 14:23:57 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #12290: Change: Calculate occupancy of drive through road stops from most recent entered vehicle https://github.com/OpenTTD/OpenTTD/pull/12290#pullrequestreview-1934329918 14:23:57 <orudge> truebrain: Azure Code Signing seems to be working, on my own machine at least. Let's see if it works on GitHub. (Turns out the validation failed because the e-mail went to spam and I didn't notice it, d'oh.) 14:24:53 <truebrain> Nice! 14:26:04 <DorpsGek> [OpenTTD/OpenTTD] zacc updated pull request #12290: Change: Calculate occupancy of drive through road stops from most recent entered vehicle https://github.com/OpenTTD/OpenTTD/pull/12290 14:29:19 *** nielsm has joined #openttd 14:29:34 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #12290: Change: Calculate occupancy of drive through road stops from most recent entered vehicle https://github.com/OpenTTD/OpenTTD/pull/12290#issuecomment-1994535264 14:31:14 <peter1138> And afaict, without changing NewGRFs, the only place that out-of-bounds vector access occurred is... during validation of HouseSpecs. D'oh. 14:40:22 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #12290: Change: Calculate occupancy of drive through road stops from most recent entered vehicle https://github.com/OpenTTD/OpenTTD/pull/12290#issuecomment-1994556513 14:40:59 <DorpsGek> [OpenTTD/OpenTTD] zacc commented on pull request #12290: Change: Calculate occupancy of drive through road stops from most recent entered vehicle https://github.com/OpenTTD/OpenTTD/pull/12290#issuecomment-1994557806 14:42:49 <talltyler> “idempotent” is quite a fun word I’ve never seen before 🙂 14:43:01 <orudge> truebrain: https://github.com/orudge/OpenTTD/actions/runs/8266233018#artifacts <-- installers and openttd.exe files all signed 14:44:01 <_jgr_> talltyler: Really, seemed to be a pretty standard computer science term to me? 14:44:17 <_jgr_> (Not that I ever studied computer science formally) 14:44:19 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #12290: Change: Calculate occupancy of drive through road stops from most recent entered vehicle https://github.com/OpenTTD/OpenTTD/pull/12290#issuecomment-1994564439 14:44:42 <truebrain> orudge: Nice! Running also gives no annoying popup? 14:45:34 <orudge> No, no different to the normal signed builds 14:46:29 <_glx_> updated description of #12291 with example output 14:46:37 <talltyler> _jgr_: Maybe, but I never studied computer science either 😛 14:47:34 <talltyler> (And I’ve never worked with another software developer — only solo) 14:48:29 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #12291: Codechange: [Win32] Disable assert message box when no GUI https://github.com/OpenTTD/OpenTTD/pull/12291#pullrequestreview-1934395405 14:49:29 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #12291: Codechange: [Win32] Disable assert message box when no GUI https://github.com/OpenTTD/OpenTTD/pull/12291 14:54:20 <peter1138> Hmm, I hope I still have my NewGRF docks test GRF source. I need to change it as the feature is used by NewGRF roadstops now 🙂 14:54:38 <DorpsGek> [OpenTTD/OpenTTD] zacc commented on pull request #12290: Change: Calculate occupancy of drive through road stops from most recent entered vehicle https://github.com/OpenTTD/OpenTTD/pull/12290#issuecomment-1994588656 14:59:47 <DorpsGek> [OpenTTD/OpenTTD] orudge opened pull request #12292: Change: [CI] Use Azure Code Signing for Windows build https://github.com/OpenTTD/OpenTTD/pull/12292 15:00:11 <DorpsGek> [OpenTTD/OpenTTD] zacc updated pull request #12290: Change: Calculate occupancy of drive through road stops from most recent entered vehicle https://github.com/OpenTTD/OpenTTD/pull/12290 15:03:09 <DorpsGek> [OpenTTD/OpenTTD] zacc updated pull request #12290: Change: Calculate occupancy of drive through road stops from most recent entered vehicle https://github.com/OpenTTD/OpenTTD/pull/12290 15:10:33 <xarick> hello again I'm back 15:10:59 <kuhnovic> That was a good lunch then 15:11:16 <xarick> what do I do know with 12286? seems to be approved 15:11:39 <merni> Wait for omeone to merge it 15:12:34 <xarick> okay, and 12285 needs something? seems ready 15:12:46 <xarick> will conflict once 12286 is merged 15:18:02 <xarick> 12232 requires 12285 15:22:56 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #12286: Fix #12279: Update random path each step https://github.com/OpenTTD/OpenTTD/pull/12286 15:22:59 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler closed issue #12279: [Bug]: CreateRandomPath not updating tile nor dir for each step it advances https://github.com/OpenTTD/OpenTTD/issues/12279 15:23:52 <xarick> nice, conflicts to solve now 15:26:07 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12285: Fix #12280: Allow ships 90 degree turns if only choice https://github.com/OpenTTD/OpenTTD/pull/12285 15:26:11 <xarick> no conflicts, funny 15:27:16 <talltyler> __karma: If you touch the function, go for it, otherwise it would be a separate PR 15:29:14 <peter1138> Nice, I set up cmake to build for Android. 15:29:16 <peter1138> And it worked. 15:29:26 <peter1138> It carefully built a settingsgen for Android. Perfect. 15:29:48 <peter1138> `EI_HAVE_NO_IDEA_WHAT_IM_DOING` 15:30:00 <LordAro> nice 15:30:09 <LordAro> iirc there are ways to force to build for host rather than target 15:31:58 <peter1138> <https://cmake.org/cmake/help/book/mastering-cmake/chapter/Cross%20Compiling%20With%20CMake.html#running-executables-built-in-the-project> something something something 15:32:49 <peter1138> `if (NOT HOST_BINARY_DIR)` 15:32:49 <peter1138> Hm 15:33:42 <peter1138> So it's already done. Nice. 15:36:27 <peter1138> Thwarted by std::bit_cast. 15:36:39 <peter1138> I already stubbed out `std::source_location` 15:39:14 *** Wormnest has joined #openttd 15:50:27 <xarick> I'm listening to desolate music again <https://www.youtube.com/watch?v=T1a-H2jX1gU> 15:55:07 <_glx_> peter1138: yeah we kinda had to support host stuff for macos, emscripten and windows arm64 16:03:03 <talltyler> __karma: Does it work in wallclock mode? 16:04:26 <talltyler> Assuming it does, it could be `Fix #11345: Use correct default button value for vehicle service interval setting` 16:06:03 <talltyler> Ah, it does not 🙂 16:06:07 <talltyler> Looking at your commit 16:07:35 <talltyler> Look at `UpdateAllServiceInterval()` in `settings_table.cpp` 16:07:37 <LordAro> i'm sensing someone not getting bridged correctly 16:08:13 <peter1138> Discord username starts with _ 16:08:13 <talltyler> Oh, I replied to the GitHub bot 🙂 16:08:41 <_glx_> <https://github.com/microsoft/vcpkg/pull/28084> merged 2 days ago, in sync with our nighly failures 16:08:48 <talltyler> Er, never mind, not sure what bridge issue you see 16:09:04 <LordAro> well i don't see any messages from '__karma' at all 16:09:22 <talltyler> Their discord name starts with two underscores 16:09:33 <talltyler> Maybe the bridge doesn’t like that 16:10:24 <dwfreed> blame truebrain 16:10:26 <dwfreed> :D 16:11:51 <_glx_> peter1138: should no matter, mine also starts with _ 16:14:48 *** dwfreed[d] has joined #openttd 16:14:48 <dwfreed[d]> test 16:15:09 <dwfreed> Okay, so that's not broken 16:17:55 <_glx_> looks like I'll need to dive in docker to debug nightly failure 16:27:22 *** gelignite has joined #openttd 16:34:18 <DorpsGek> [OpenTTD/OpenTTD] orudge commented on pull request #12292: Change: [CI] Use Azure Code Signing for Windows build https://github.com/OpenTTD/OpenTTD/pull/12292#issuecomment-1994907640 16:38:55 <peter1138> Well, it built. But it's not an android app yet ;D 16:39:11 <LordAro> nah, ship it 16:46:21 <_glx_> oh nice it fails sooner in my docker 16:51:14 <_glx_> /vcpkg/buildtrees/breakpad/src/2023.01.27-5f635e6695.clean/src/common/linux/dump_symbols.cc:286:31: error: ‘SHF_COMPRESSED’ was not declared in this scope 16:51:14 <_glx_> 286 | return (section->sh_flags & SHF_COMPRESSED) != 0; 16:51:14 <_glx_> | ^~~~~~~~~~~~~~``` 16:52:25 <_glx_> oh stupid me, wrong image 16:52:44 <_glx_> I must redo from start 16:53:02 <LordAro> how old is your image? :p 16:53:18 <_glx_> I used the 2014 one by mistake 16:53:28 <LordAro> haha 17:06:53 <DorpsGek> [OpenTTD/team] RogierVC opened issue #531: [nl_NL] Translator access request https://github.com/OpenTTD/team/issues/531 17:08:49 <_glx_> it's better with the correct image 17:09:08 <_glx_> fails on the same place as nightly 17:09:50 <peter1138> Is it due to our changed, or is that just a coincidence? 17:10:00 <_glx_> coincidence I think 17:11:16 <_glx_> ```../src/2.14.2-7f52ee670b.clean/meson.build:1:0: ERROR: Value "plain" (of type "string") for combo option "Optimization level" is not one of the choices. Possible choices are (as string): "0", "g", "1", "2", "3", "s".``` 17:11:35 <LordAro> it's not wrong 17:11:57 <michi_cc> Exact error as in the last comments of <https://github.com/microsoft/vcpkg/pull/28084>. So probably not our fault. 17:14:28 <_glx_> and they have a pending fix <https://github.com/microsoft/vcpkg/pull/37396> 17:15:31 <_glx_> I like how their CI is fast "Failing after 931m — Build #20240312.28 had test failures " 17:15:45 <peter1138> o_O 17:15:59 <peter1138> Building everything? 17:16:02 <michi_cc> What can you do if it is test 9999/10000 🙂 17:16:27 <michi_cc> (Besides less testing 😛 ) 17:17:04 <_glx_> Failed: 5 (0.07%) 17:17:04 <_glx_> Passed: 7,597 (99.54%) 17:17:04 <_glx_> Other: 30 (0.39%) 17:17:04 <_glx_> Total: 7,632 17:17:39 <andythenorth> talltyler: doesn't it mean "goes wrong reliably and repeatably"? 17:17:40 <andythenorth> 😛 17:23:23 *** HerzogDeXtEr has joined #openttd 17:37:28 <rutoks> LordAro: _glx_ I believe I got everything done in my PR. Could you please take another look? Thanks 17:37:28 <rutoks> https://github.com/OpenTTD/OpenTTD/pull/12163 17:41:17 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #12163: Add: Basic autocompletion on tab for console commands https://github.com/OpenTTD/OpenTTD/pull/12163#pullrequestreview-1934824611 17:42:07 <rutoks> LordAroviaGitHub: Yeaaaah 17:42:18 <rutoks> https://tenor.com/view/yeah-csi-miami-glasses-sunglasses-horatio-caine-gif-14033607 17:42:35 <rutoks> What next? Do I just click merge? 17:42:54 <LordAro> i think you'll find that difficult :p 17:43:13 <LordAro> i'd like someone else to confirm it, they'll click merge 17:43:40 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #12288: Change: Increase house type limit to 4096. https://github.com/OpenTTD/OpenTTD/pull/12288 17:44:36 <rutoks> LordAro: I see. Thanks. But brace yourself, I also want to add more stuff like completing parameters for set command and stuff 17:44:47 <LordAro> haha 17:45:19 <LordAro> i doubt it'll take too long, so if you want to get started in a separate PR, go ahead 17:45:24 <LordAro> make a branch on top of your existing one 18:33:25 <truebrain> `52 IRC connections, 47 connected` .. either we reached a max-IRC-limit, or something else is funky, but 5 puppets are not connected 😄 18:33:45 <truebrain> dwfreed: is this IPv6 block limited to N connections? 18:41:48 *** gelignite has quit IRC 18:42:14 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #12292: Change: [CI] Use Azure Code Signing for Windows build https://github.com/OpenTTD/OpenTTD/pull/12292#pullrequestreview-1934946399 19:08:27 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #12293: Codefix 363e251: incorrect trace debug message https://github.com/OpenTTD/OpenTTD/pull/12293 19:08:45 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #12293: Codefix 363e251: incorrect trace debug message https://github.com/OpenTTD/OpenTTD/pull/12293#pullrequestreview-1935009329 19:08:48 <truebrain> only one mistake? I am shocked 😛 19:09:03 <Rubidium> only one I've noticed so far 19:09:16 <truebrain> that is fair 😄 19:30:40 <michi_cc> There's pobably no point doing RC2 while vcpkg is failing in build, right? 19:31:05 <truebrain> from the link _glx_ send, it should be working again; but maybe better wait to see if the nightly works tomorrow morning 😄 19:31:57 <michi_cc> There's a fix PR, but the state as of right now is still "open". 19:32:15 <truebrain> owh, you are right; I misread the merged entries in there 😛 19:32:22 <truebrain> so yeah .. releasing will be pointless 🙂 19:32:27 <michi_cc> So yeah, wait for successfull nightly first. 19:34:18 <truebrain> just a bit sad how often vcpkg breaks stuff, honestly. I would expect there to be a bit higher QA standard 🙂 19:34:44 <truebrain> either way, I have been trying to benchmark on GitHub Actions, and .. it is tricky. the runs tend to vary by a decent amount 19:34:53 <truebrain> been using CPU time (instead of instruction-count) 19:35:33 <truebrain> I also still think it is funny it is pretty difficult to get an accurate number for "memory usage" 19:35:46 <truebrain> this game I am testing is "somewhere between 188MB and 194MB" 🙂 19:35:58 <truebrain> like ... our game is deterministic enough that this shouldn't be the case 😛 19:38:05 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #12248: Doc: Prepare for 14.0-RC2 release https://github.com/OpenTTD/OpenTTD/pull/12248 19:41:47 *** gelignite has joined #openttd 19:42:31 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #12293: Codefix 363e251: incorrect trace debug message https://github.com/OpenTTD/OpenTTD/pull/12293 19:43:43 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #12248: Doc: Prepare for 14.0-RC2 release https://github.com/OpenTTD/OpenTTD/pull/12248#pullrequestreview-1935070601 19:49:09 <truebrain> CPU time: between 31s and 36s 19:49:12 <truebrain> well, that is pointless 😛 20:05:01 <DorpsGek> [OpenTTD/team] glx22 commented on issue #531: [nl_NL] Translator access request https://github.com/OpenTTD/team/issues/531 20:12:37 <truebrain> okay, so MacOS has a kperf framework, and although private, does give better performance indicators .. issue? It requires implementing yourself 😛 22:44:57 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on discussion #12281: NewGRF House Spec Improvements https://github.com/OpenTTD/OpenTTD/discussions/12281 23:20:17 <xarick> i think my AI is safe 23:20:22 <xarick> maybe 23:20:41 <xarick> I'm doing a AITile.IsBuildable(adjacentTile) check, if a depot is there, I don't think this passes as true 23:22:30 <xarick> I'm safe! 23:22:34 <xarick> 🙂 23:23:03 <xarick> can't speak for other AIs though 23:24:57 <xarick> https://github.com/OpenTTD/OpenTTD/blob/master/src/script/api/script_tile.cpp#L39