Log for on 27th October 2012:
Times are UTC Toggle Colours
00:40:31  *** FLHerne has left
01:13:54  *** Knogle has quit IRC
01:14:23  *** Knogle has joined
05:49:08  *** andythenorth has joined
05:49:08  *** ChanServ sets mode: +v andythenorth
05:50:42  *** andythenorth has quit IRC
06:14:38  *** andythenorth has joined
06:14:38  *** ChanServ sets mode: +v andythenorth
06:20:32  *** andythenorth has quit IRC
06:20:48  *** andythenorth has joined
06:20:48  *** ChanServ sets mode: +v andythenorth
07:04:26  *** Supercheese has quit IRC
08:24:21  *** Zuu has joined
08:24:21  *** ChanServ sets mode: +v Zuu
09:13:58  *** frosch123 has joined
09:13:58  *** ChanServ sets mode: +v frosch123
13:13:16  *** Knogle has quit IRC
13:14:21  *** Knogle has joined
13:21:24  *** FLHerne has joined
13:55:16  *** andythenorth has quit IRC
14:30:21  <frosch123> <- add text filter to adv settings :)
14:37:19  <planetmaker> frosch123, for IsVisible, it only returns true, if not folded and visible (like the return description). IMHO that's the better function description than what it says
14:37:26  <planetmaker> 10_...
14:38:08  <frosch123> what?
14:38:17  * frosch123 fails to parse
14:39:16  <planetmaker> :-) I think that the description of the return value would suit as function description
14:39:36  <planetmaker> The function description itself is a bit less clear IMHO
14:40:00  <planetmaker> (even on the cost that it's a bit duplicate text then)
14:40:15  <frosch123> you mean "Check whether an entry is visible and not folded or filtered away"?
14:40:49  <planetmaker> + * Check whether an entry is visible, or currently folded away.
14:41:09  <planetmaker> that's not accurate imho
14:41:17  <planetmaker> the return value's description is
14:44:06  <planetmaker> maybe... just
14:44:07  <planetmaker> , or currently folded away.
14:44:17  <planetmaker> + * Check whether an entry is visible
14:44:27  <planetmaker> ^ that way. folded away isn't visible by definition
14:44:42  <planetmaker> and out-of-view can also be the case, if not folded away
14:45:49  <planetmaker> hm.... does IsVisible return true for an item which must be scrolled to, but which is unfolded?
14:46:07  *** Knogle has quit IRC
14:46:13  <frosch123> yeah, that's what i wanted to express with explicitly mentioning folding
14:46:18  <frosch123> it does not consider scrolling
14:46:23  <frosch123> nor shall it :)
14:46:42  <planetmaker> so... maybe not IsVisible... but... hm
14:46:45  <frosch123> updated diff
14:46:50  <frosch123> better?
14:47:45  <planetmaker> maybe then better call it IsSelected?
14:48:01  <planetmaker> as also selected items may not be visible, given the actual window size?
14:48:04  <frosch123> selected is the clicked/highlighted line :)
14:48:35  <planetmaker> IsHighlighted would be that... but it's ambiguous, I know. I've no better name. But so is IsVisible
14:50:50  <planetmaker> maybe add a 2nd description line:
14:51:02  <planetmaker> * (might still not be drawn as it needs scrolling to)
14:51:12  <planetmaker> then it would be also clear to people like me :D
14:54:35  <frosch123> updated again :)
14:55:18  <planetmaker> :-)
14:59:20  <planetmaker> +	bool manually_expanded;            ///< Whether the user expanded/collapsed something manually.
14:59:40  <planetmaker> ^ should it either be manually_changed_folding?
14:59:48  <planetmaker> or should the comment say only expanded?
15:00:49  <planetmaker> in 30_...
15:01:22  <frosch123>  manually_changed_folding likely
15:01:37  *** andythenorth has joined
15:01:37  *** ChanServ sets mode: +v andythenorth
15:02:02  <planetmaker> yup, looks like, after reading the patch :-)
15:08:18  <planetmaker> hm, when does it auto-expand, frosch123 ?
15:08:48  <frosch123> "-Add: Autoexpand the adv. settings tree, if a filter term is entered immediately after opening the window without any manual expanding/collapsing."
15:08:56  <planetmaker> :D  "Bevorzuge Teamchat mit <ENTER>". Took me some time to figure out why it was included into a search for Zug
15:09:11  <frosch123> :)
15:09:15  <frosch123> try " zug"
15:10:08  <planetmaker> hm. But I also got all entries for "Wartung"
15:10:25  <frosch123> it checks the name and the help text
15:10:28  <planetmaker> but likely that's what we want
15:10:32  <frosch123> "zug" might not be a good search term
15:10:54  <frosch123> if a page title hits the filter, everything below is forced to be shown
15:11:40  <planetmaker> yes... there's a "zugewiesen" in the description text for ships
15:16:40  <planetmaker> behaviour is weired for a case like:
15:17:05  <planetmaker> search for a word. Press expand all. Clear the search. You have still only the items unfolded which were part of the search
15:17:47  <frosch123> i had it the other way around earlier
15:17:52  <frosch123> but that felt weird as well :)
15:18:42  <planetmaker> probably, yes
15:20:22  <planetmaker> hm. should the window remember the last filtering?
15:20:28  <frosch123> no
15:20:33  <frosch123> we do that nowhere
15:20:49  <planetmaker> should it have a "clear search" button for the query (imho yes)
15:20:59  <frosch123> also that we have nowhere :)
15:21:22  <frosch123> so, if, then a separate patch including other windows
15:23:33  <planetmaker> where do we use a similar broad search? Newgrfs...
15:23:47  <planetmaker> online content
15:23:47  <frosch123> signs
15:24:01  <frosch123> just grep for "StringFilter" :)
15:25:58  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24631 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
15:26:18  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24632 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
15:26:35  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24633 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
15:57:31  <frosch123> night
15:57:35  <frosch123> see you monday
15:57:39  *** frosch123 has quit IRC
17:45:32  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24634 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
17:52:03  *** FLHerne_ has joined
17:57:38  *** FLHerne has quit IRC
20:36:53  *** Supercheese has joined
21:01:43  *** andythenorth has quit IRC
22:25:04  *** TrueBrain has joined
22:25:04  *** ChanServ sets mode: +v TrueBrain
22:25:13  <TrueBrain> planetmaker: because I am lazy, and I hate many open channels :P
22:25:21  <TrueBrain> but nevertheless
22:25:32  <TrueBrain> I need a proof-read on I guess :P If anyone is capable/interested enough to do so :)
22:26:05  <planetmaker> btw, TrueBrain, there exists a 2-year old repo for the balancer...
22:26:20  <TrueBrain> where?
22:26:58  <planetmaker>
22:27:13  <planetmaker> (so also in svn)
22:27:19  <planetmaker> I guess :-)
22:27:45  <TrueBrain> yeah, it is, kinda, what is running on the host atm
22:27:45  <TrueBrain> I will commit my new stuff when it is running etc ;)
22:28:18  <planetmaker> yup, I just noticed that it's also svn... I first thought it was a separate hg repo
22:33:53  <TrueBrain> I am trying to write a post, but it seems I am too tired to do so
22:33:54  <TrueBrain> I make no sense :P
22:46:31  <planetmaker> generally, the code has only few comments ;-)
22:47:10  <planetmaker> I guess I grew used to doxygen's function descriptions in openttd code
22:47:31  <TrueBrain> it has too many comments sometimes ...
22:47:35  <TrueBrain> # Check every 10 seconds
22:47:38  <TrueBrain> self.event.wait(10)
22:47:40  <TrueBrain> I mean .. really?
22:49:04  <TrueBrain> but if any line is unclear, lemme know, I will add comments .. most of them are either clear by reading the line, or by the comment there, my goal was :D
22:51:03  <planetmaker> you explain the code lines. But not the functions themselves :-)
22:51:16  <planetmaker> though yes, granted, often it's clear
22:51:19  <TrueBrain> the names should be sufficient :)
22:51:36  <TrueBrain> others are implementations
22:52:59  <TrueBrain> but granted, a few I forgot; added them now :)
22:54:38  <TrueBrain> refresh
23:29:33  *** FLHerne_ has quit IRC

Powered by YARRSTE version: svn-trunk