Times are UTC Toggle Colours
01:10:59 *** Knogle has quit IRC 01:11:30 *** Knogle has joined #openttd.dev 05:46:48 *** Supercheese has quit IRC 07:28:50 *** Zuu has joined #openttd.dev 07:28:50 *** ChanServ sets mode: +v Zuu 07:52:30 *** Zuu has quit IRC 09:10:56 *** TrueBrain has quit IRC 13:13:28 *** Knogle has quit IRC 13:14:31 *** Knogle has joined #openttd.dev 17:41:35 *** frosch123 has joined #openttd.dev 17:41:35 *** ChanServ sets mode: +v frosch123 17:51:00 *** Dan has joined #openttd.dev 17:51:05 *** Dan has left #openttd.dev 17:52:24 <frosch123> - if (!force_visible && !filter.IsEmpty()) { 17:52:26 <frosch123> + if (!force_visible && !filter.IsEmpty() && mode == RM_ALL) { 17:52:31 <frosch123> Yexo: that part looks weird to me 17:53:21 <frosch123> it only filters the page names, when there is no restriction set 18:08:24 <frosch123> wrt. the strings 18:09:16 <frosch123> i would just go for "settings deviating from default values", "gameplay settings deviating from default values" and "settings deviating from new game settings" 18:09:21 <frosch123> i.e. with all the "one's" 18:09:26 <frosch123> *without 18:37:57 *** andythenorth has joined #openttd.dev 18:37:58 *** ChanServ sets mode: +v andythenorth 18:45:21 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24646 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:49:46 <Yexo> frosch123: where is force_visible even used? 18:49:55 <Yexo> I was looking for it yesterday but couldn't find it 19:17:35 <frosch123> when the string filter hits the name of a page, it forces all subordinate stuff to be shown 19:17:41 <frosch123> independent of their filter 19:17:56 <frosch123> so, if you enter "servicing", it shows you all settings of under the servicing page 19:18:05 <frosch123> even if the settings themself do not contain the string "servicing" 19:18:58 <Yexo> ah, right 19:19:00 <frosch123> SettingEntry::UpdateFilterState sets force_visible to true, if the page name hits, the subordinate SettingEntry::UpdateFilterState then skip the string test 19:23:12 <Yexo> I've removed the && mode==RM_ALL part of the line above, that was what you suggested, right? 19:25:19 <frosch123> i think in SettingsPage::UpdateFilterState "visible" needs initalising to "false" instead of "force_visible" 19:25:54 <frosch123> so it hides pages when all their settings fail the non-string filter, but the page hits the string filter 19:26:16 <Yexo> you're right 19:26:18 <Yexo> changed 19:26:28 *** andythenorth has quit IRC 19:26:50 *** andythenorth has joined #openttd.dev 19:26:50 *** ChanServ sets mode: +v andythenorth 19:27:11 <frosch123> looks fine to me 19:27:15 <frosch123> remain only the strings :) 19:27:38 <Yexo> yep 19:29:59 <Yexo> rewritten the strings, what do you think? 19:32:21 <frosch123> "non-local" sounds weird in singleplayer context 19:33:07 <Yexo> the option is disabled in that case 19:33:52 <Yexo> in singleplayer context it's the same as the AGAINST_DEFAULT option, because local settings are always the same 19:34:11 <frosch123> where is that in the code? 19:34:21 <frosch123> i only see that new-game comparison is disabled in main menu 19:34:40 <frosch123> and imo the other thing also makes sense in singeplayer 19:34:42 <Yexo> you're right, it's not there 19:34:55 <frosch123> STR_CONFIG_SETTING_TYPE_CLIENT :Client setting (not stored in saves; affects all games) 19:35:01 <frosch123> there we named it client-setting 19:35:18 <frosch123> in contrast to "game" and "company" settings 19:35:29 <Yexo> "Non-client settings that have a different value than the default" ? 19:35:37 <Yexo> I'm open for better ideas 19:35:46 <frosch123> or "Game and company settings that..." 19:36:15 <frosch123> "Non-client" sounds better to me 19:36:27 <Yexo> updated, what about this? 19:36:40 <Yexo> "Game and company settings" / "Game settings" 19:37:05 <frosch123> why does svn reorder the files every time? :p 19:37:34 <Yexo> no clue 19:37:45 <frosch123> STR_CONFIG_SETTING_RESTRICT_CHANGED_AGAINST_DEFAULT also includes client settings, doesn't it? 19:37:59 <frosch123> i.e. it's "all settings" 19:39:37 <Yexo> yes 19:40:13 <Yexo> that brings me back to "Settings" / "Non-client settings" 19:40:34 <frosch123> should be fine then :) 19:41:40 <Yexo> did we already have a FS entry for this? 19:42:11 <frosch123> can't remember any 19:43:53 <Terkhen> can you paste the patch link again? 19:44:11 <Yexo> http://devs.openttd.org/~yexo/filter_changes.diff 19:44:34 <Terkhen> thanks :) 19:49:41 <Terkhen> /* dealing with drop down boxes on the panel */ <--- missing capitalization 19:50:47 <Yexo> fixed 19:51:31 <Terkhen> looks fine to me besides that 19:53:13 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24647 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 19:54:09 <frosch123> next on the list: remove difficulty profiles :) 19:54:21 <frosch123> i'll likely have a look on thursday 19:54:56 <frosch123> someone feels like classifying the settings into basic/advanced/expert? resp. do we want such "filters"? 19:55:47 <andythenorth> classify them into 'normal' and 'train nerd' :P 19:55:52 * andythenorth lurks again 19:56:12 <frosch123> ah, "gameplay" and "realism" settings 19:56:43 <Yexo> I tried to do that once, must still be somewhere on the forums 20:08:30 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24648 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:22:49 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24649 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:23:18 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24650 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:24:02 *** andythenorth has quit IRC 20:24:35 <Yexo> is a filter "Client settings" useful? 20:24:44 *** andythenorth has joined #openttd.dev 20:24:44 *** ChanServ sets mode: +v andythenorth 20:24:58 <Yexo> so when playing on multiplayer you can see in the main menu which settings you can safely change? 20:25:40 <frosch123> in that case i thing we need both "client" and "non-client" settings 20:25:55 <frosch123> so you only need to consider the non-client settings when setting up a server 20:25:55 *** andythenorth has quit IRC 20:26:07 *** andythenorth has joined #openttd.dev 20:26:07 *** ChanServ sets mode: +v andythenorth 20:26:08 <Yexo> true, I didn't think of that use case 20:26:09 <frosch123> and you can filter for the client setting when changing stuff while in game 20:26:25 <frosch123> without being annoyed about not being allowed to change half of them 20:26:35 <Yexo> in a multiplayer game you'd need a "client + company settings" filter 20:26:37 <frosch123> hmm, though.. what to do about company settings? 20:26:55 <frosch123> yeah, so "game settings" and "client and company settings"? 20:27:06 <frosch123> the more categories we add, the more complicated it gets :p 20:27:34 <frosch123> hmm, actually.. what is even more troublesome: these categories are not orthogonal to basic/advanced/expert 20:27:45 <frosch123> it would need two comboxboxes then 20:27:51 <Yexo> that for sure 20:28:15 <Yexo> instead of a combobox we could show 3 checkboxes, 1 for game settings, one for client settings and one for company settings 20:28:22 <frosch123> i would have but basic/advanced/expert in the same box as deviations 20:28:28 <frosch123> if you want to see deviations, then all :) 20:28:38 <Yexo> hmm, that's true 20:29:46 <frosch123> yeah, checkboxes would make more sense 20:29:50 <frosch123> where to put them ? :) 20:30:03 <Yexo> horizontally instead of the current combobox? 20:30:27 <Yexo> just committed the patch, let's throw it out again and rewrite it :p 20:30:45 <frosch123> instead? 20:31:00 <frosch123> how would "deviations" work with checkboxes? 20:31:09 <Yexo> <Yexo> instead of a combobox we could show 3 checkboxes, 1 for game settings, one for client settings and one for company settings <- those checkboxes would cover all options the current combobox offers, so I see no reason to have both 20:31:20 <Yexo> hmm, good point 20:31:28 <frosch123> we can have two comboboxes 20:31:43 <frosch123> hmm, no 20:32:06 <Yexo> one combobox for basic/advanced/expert, 3 checkboxes for game/client/company settings, 1 checkbox for all/only changed 20:32:08 * andythenorth builds :P 20:32:15 <Yexo> that should cover everything 20:32:36 <frosch123> i would still put the "only changed" into the same as basic/advanced/expert 20:32:40 <Yexo> the all/only changed checkbox could be merged in the basic/advanced/expert combobox 20:33:03 <frosch123> so, ok, just another filter row for game/client/company 20:33:43 <Yexo> so that'd mean the combobox would have "all/changed/basic/advanced/expert"? 20:34:08 <Yexo> hmm, it'd still need changed against default and changed against new 20:34:09 <frosch123> "expert" would replace "all" 20:34:13 <Yexo> ok 20:34:29 <frosch123> basic/advanced/expert/changed default/changed new 20:34:34 <Yexo> so "basic/advanced/expert/changed against default/changed against new" 20:35:01 <Yexo> with the current "changed against default without local" becoming obsolete due to the client checkbox 20:35:28 <frosch123> yeah, not sure whether that is an improvement though :) 20:56:55 <frosch123> where would we put buttons like "revert to defaults" and "make these settings the new-game settings" ? 20:57:02 <frosch123> at the bottom bar? right aligned? 21:02:12 <Yexo> bottom-right seems fine 21:08:33 *** Zuu has joined #openttd.dev 21:08:33 *** ChanServ sets mode: +v Zuu 21:15:51 <frosch123> night 21:15:53 *** frosch123 has quit IRC 22:03:08 *** andythenorth has left #openttd.dev