Times are UTC Toggle Colours
00:56:07 *** Zuu has quit IRC 01:33:49 *** Supercheese has joined #openttd.dev 02:09:39 *** FLHerne has quit IRC 02:30:59 *** LordAro has quit IRC 05:08:29 *** Knogle has quit IRC 05:08:55 *** Knogle has joined #openttd.dev 06:42:41 *** andythenorth has joined #openttd.dev 06:42:41 *** ChanServ sets mode: +v andythenorth 08:50:30 *** LordAro has joined #openttd.dev 08:50:30 *** ChanServ sets mode: +v LordAro 09:01:20 *** andythenorth has quit IRC 09:01:27 *** andythenorth has joined #openttd.dev 09:01:27 *** ChanServ sets mode: +v andythenorth 09:04:07 *** Supercheese has quit IRC 09:17:28 *** Alberth has joined #openttd.dev 09:17:28 *** ChanServ sets mode: +v Alberth 09:36:21 *** Zuu has joined #openttd.dev 09:36:21 *** ChanServ sets mode: +v Zuu 10:34:29 *** frosch123 has joined #openttd.dev 10:34:29 *** ChanServ sets mode: +v frosch123 10:58:54 *** V453000 has joined #openttd.dev 11:01:31 <frosch123> +/*virtual */ uint32 TownScopeResolver::GetVariable(byte variable, uint32 parameter, bool *available) const <- missing " " in 20 11:02:53 <frosch123> all the Resolver classes miss doxygen for the class itself btw 11:05:40 <Alberth> I have no clue what the is actually doing, tbh 11:06:16 <Alberth> Ie I don't get further than "resolves the Foo scope", but that does not add anything useful 11:08:19 <frosch123> well, i actually only thought about just that :p i don't think there is something "useful" to write about the derived classes, except for reducing the doxygen warning output 11:08:45 <Alberth> I did try to rescue the existing docs as much as possible, but there was not much. 11:09:03 <Alberth> The base class needs documentation only, imho 11:17:58 *** Zuu has quit IRC 11:23:24 <michi_cc> Not sure how our Doxyfile is configured, but by default doxygen will not document members of undocumented classes/structs/files etc. 11:38:51 <Alberth> adding "resolve Foo scope" is easily done in that case for the derived classes, but an explanation of what 'resolve' and 'scope' mean would be useful imho, otherwise it is as understandable as /** some docs here */ 11:51:22 <frosch123> 50 and 60 do not set the TownScopeResolver to readonly like the old StorePSA functions did 11:51:35 <frosch123> err, 60 and 70 12:07:50 <Alberth> I'll have a go at adding doxy comments 12:09:30 <Alberth> hmm, adding a doc patch may be useful here, otherwise it gets everywhere 12:18:04 <Alberth> set town resolvers of objects and stations to 'true' 12:20:53 <frosch123> you mean the st != NULL thingie? 12:21:02 <frosch123> or really "true"? 12:21:53 <frosch123> + case VSG_SCOPE_PARENT: // TODO where is the town? <- that TODO can be removed from 100 12:22:16 <frosch123> well, the whole line actually 12:24:51 * Alberth has another look 12:26:11 *** Eagle_Rainbow has joined #openttd.dev 12:26:11 *** ChanServ sets mode: +v Eagle_Rainbow 12:26:55 * Eagle_Rainbow has updated the patch for the multiplayer filter edit box to http://www.tt-forums.net/viewtopic.php?f=33&t=59329&p=1053543#p1053543 12:32:26 <frosch123> same thing with the TownScopeResolver applies to 120 12:32:59 <frosch123> the GetTown functions all look slightly different :p 12:33:12 <frosch123> wrt. the "return NULL" case 12:36:02 <frosch123> not_yet_constructed <- better rename the var name in 120 12:36:21 <frosch123> it is very specific to only CBID_INDUSTRY_LOCATION, nothing else 12:36:38 <Alberth> Quite likely the GetTown functions are different, I wrote each of them separately during the 3 weeks that I needed for the patch queue :) 12:36:39 <frosch123> actually, maybe remove it and check the callback id instead in GetVariable 12:37:09 <Alberth> good idea 12:50:38 *** Webster has joined #openttd.dev 12:50:39 *** ChanServ sets mode: +v Webster 12:51:05 <frosch123> + object.parent_scope.v = parent; <- 140: could use SetVehicle 12:51:43 <Alberth> :) 12:52:00 <Alberth> I saw the function, and promptly forgot about it :) 12:52:53 *** Guest5209 has quit IRC 12:56:55 <frosch123> nice queue :) 12:58:21 <Alberth> when doing it for the 3rd or 4th time, you become good at refactoring this part of the code :) 13:01:26 <frosch123> do we want a generic "clear" button (maybe with some "X" icon) in all editboxes? 13:03:07 <Alberth> ctrl+u is hard to find, so having a button for it makes sense 13:03:23 <Alberth> although "X" means "close" to me :p 13:03:30 <frosch123> i wonder whether we have editboxes were clearing is not useful 13:04:22 <frosch123> i seem to remember soem clear symbol like "<[x]" 13:04:42 <frosch123> not sure where i encountered it 13:06:19 <Alberth> I would not know of any edit box that you definitely never want to clear 13:06:50 <Alberth> some texts are small, eg the year or a production level, but even there clearing would be useful some times 13:08:21 <frosch123> http://www.rockia.com/wp-content/uploads/2009/10/Del.png <- found it 13:08:40 <frosch123> ⌫ <- u 13:08:45 <frosch123> ⌫ <- u+232b 13:08:54 <frosch123> we might add that to the sprite font 13:09:29 <frosch123> ⌦ <- hmm, plus i guess that one for rtl :p 13:10:00 <frosch123> u+2326 13:11:59 <Alberth> looks like a fun symbol to add :) 14:55:40 *** Eagle_Rainbow has quit IRC 15:11:24 <Alberth> http://devs.openttd.org/~alberth/changes_metadiff.txt fixes done so far in a sort-of meta-diff, doxyment additions are still not done 15:11:52 <Alberth> should I upload a full new version as well? 15:15:41 <frosch123> ++ this->town_scope = new TownScopeResolver(this, t, this->object_scope.obj != NULL); <- i think the != NULL should be a == NULL 15:15:47 <frosch123> same for stations 15:16:15 <Alberth> correct 15:16:35 <Alberth> it's surprising how difficult booleans are :) 15:17:16 <frosch123> rest looks fine :) 15:18:46 *** V453000 has left #openttd.dev 15:18:55 <Alberth> fixed 15:24:50 <Alberth> thanks for the review so far 15:30:50 *** andythenorth has quit IRC 15:33:44 *** FLHerne has joined #openttd.dev 16:09:04 *** Zuu has joined #openttd.dev 16:09:04 *** ChanServ sets mode: +v Zuu 16:27:29 *** Zuu has quit IRC 17:07:44 *** Knogle has quit IRC 17:08:49 *** Knogle has joined #openttd.dev 17:15:57 *** andythenorth has joined #openttd.dev 17:15:57 *** ChanServ sets mode: +v andythenorth 17:59:53 *** FLHerne has quit IRC 18:10:08 *** andythenorth has quit IRC 18:12:23 *** FLHerne has joined #openttd.dev 18:46:35 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24677 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:47:21 *** andythenorth has joined #openttd.dev 18:47:21 *** ChanServ sets mode: +v andythenorth 19:03:21 *** Knogle has quit IRC 19:04:18 *** Knogle has joined #openttd.dev 19:28:39 <Alberth> http://devs.openttd.org/~alberth/160_docs.patch doxymentation patch 19:36:39 <frosch123> first hunk of src/newgrf_object.cpp contains some weird comments 19:36:45 <frosch123> //< inside a function 19:37:02 <frosch123> i guess those comments are already in the header file? 19:38:18 <Alberth> nope, copy/paste error 19:39:59 <Alberth> weird, no idea how it got there :) 19:40:12 <frosch123> maybe do some s/First parameter/First parameter (var 10)/ and s/Second parameter/Second parameter (var 18)/ 19:40:33 <frosch123> i always have to look them up which is which when comparing code with sepcs 19:40:53 <Alberth> k 19:43:09 <Alberth> easy to do by editing the patch :) 19:43:28 <frosch123> yup :) 19:43:57 <Alberth> this may get lost when using the evolve extension with hg 19:45:27 <Alberth> is there another sane way to check whether it still works other than throwing it into trunk and see what happens? 19:45:46 <Alberth> I cannot really think of one 19:48:44 <frosch123> http://paste.openttdcoop.org/show/1915/ <- attempt at a more general description in newgrf_spritegroup.h 19:48:49 <frosch123> not sure, how successful :p 19:49:52 <frosch123> Alberth: i can only imagine loading some old gamestate with a bunch of grfs (firs or ecs) and see whether it crashes 19:50:04 <frosch123> i think we can only check for immediate crashes for now 19:50:09 <frosch123> rest needs to go via nightlies 19:51:24 <Alberth> your attempt looks like Spanish with English words to me, but it probably beats my attempt by a million miles :) 19:51:58 <frosch123> i tried to make some relation between ottd code and nfo specs 19:52:09 <frosch123> maybe we could also add the nml terms :p 19:53:07 <Alberth> nfo specs should be sufficient imho 19:56:33 <Alberth> copied your text into the code. 19:57:03 * Alberth tries to run a few games 20:05:59 *** Zuu has joined #openttd.dev 20:05:59 *** ChanServ sets mode: +v Zuu 20:15:05 <Alberth> it fails to crash :p 20:15:34 <frosch123> aw :p 20:15:48 <Alberth> I found two ECS games, and they seem to work 20:16:04 <frosch123> also mapgen? 20:16:25 <frosch123> i.e. if to type "restart" in the console from those games 20:22:10 <Alberth> I just tried to make a new map with ogfx+, ECS of 2009, and FIRS r2876 (ie quite recent), and that works for all three cases 20:26:32 <frosch123> yay, sounds like we get a new nightly tomorrow :) 20:31:53 <Alberth> but it's the same as todays nightly :p 20:32:27 *** Supercheese has joined #openttd.dev 20:37:25 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24678 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:38:41 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24679 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:39:05 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24680 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:39:33 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24681 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:39:59 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24682 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:40:40 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24683 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:41:02 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24684 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:41:40 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24685 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:42:13 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24686 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:42:44 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24687 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:43:35 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24688 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:44:04 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24689 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:44:32 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24690 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:44:58 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24691 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:45:52 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24692 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:46:33 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24693 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:53:48 *** Knogle has quit IRC 20:56:48 *** Knogle has joined #openttd.dev 21:06:30 *** Hirundo_ has quit IRC 21:06:30 *** DorpsGek has quit IRC 21:06:30 *** planetmaker has quit IRC 21:07:01 *** planetmaker has joined #openttd.dev 21:07:01 *** ChanServ sets mode: +v planetmaker 21:09:01 *** Hirundo has joined #openttd.dev 21:10:50 *** DorpsGek has joined #openttd.dev 21:10:50 *** ChanServ sets mode: +v DorpsGek 21:13:49 *** andythenorth has left #openttd.dev 21:49:42 <michi_cc> Alberth: I get a lot of warnings with MSVC: "warning C4355: this': wird in Initialisierungslisten für Basisklasse verwendet". 21:49:43 <michi_cc> The docs for that warning state that 'this' isn't fully constructed yet when the member objects in the initializer list are constructed, which means you can get undefined behaviour in case any of those constructors tries to access 'this'. 21:50:35 <michi_cc> See http://farm.openttd.org/browse/OTTD-TEST-W64BIT-1620/log for the actual warnings. 21:52:02 <frosch123> that looks like a stupid warning 21:52:13 <frosch123> i have seen dozen of software doing stuff like that 21:52:25 <frosch123> can we disable that one via some pragma? 21:52:51 <Alberth> it's in the constructor, where the surrounding resolver object 'ro' is passed into the constructor of the scope resolvers probably 21:53:36 <Alberth> nothing is done with 'this', afaik durng construction 21:54:02 <Alberth> Hmm, I have just deleted the directory where I had a game running :p 21:54:36 <Alberth> (auto)save may be a bit troublesome :p 21:54:57 <frosch123> deleting files? 21:55:03 <frosch123> just buy a bigger harddisk :p 21:56:41 <michi_cc> It warns on the statements like "railtype_scope(this, tile, context)". As long as no ScopeResolver class actually tries to call a (virtual) member of 'ro' in its constructor, the warning doesn't matter, but if you do... 21:56:42 <frosch123> michi_cc: "#pragma warning(disable: 4355) " in stdafx.h, right? 21:57:30 <michi_cc> Probably :) Well, which ever way the existing pragmas are looking. 21:57:51 <frosch123> well, can you try? :) 22:00:31 <michi_cc> Works. Official description (for the comment) is "'this' : used in base member initializer list". 22:01:28 <Alberth> this->ro = ro; <-- this is what it does with the 'ro' this, ie nothing except storing 22:03:10 <frosch123> well, it is incompletely constructed, msvc has likely no chance to detect what is done with the pointer, and just warnds :) 22:07:42 <frosch123> actually, no, the warning is completely wrong 22:08:02 <frosch123> AirportScopeResolver only gets a pointer to the baseclass, and that one is already completely constructed 22:09:04 *** Zuu has quit IRC 22:11:08 <Alberth> but the ResolverObject has virtual methods 22:11:45 <frosch123> yeah, but those are only instantiated when the construction is finished 22:12:27 <frosch123> if you call a virtual function from the AirportScopeResolver constructor, it should call the function of the ResolverObject baseclass 22:15:05 <michi_cc> I guess the warning was introduced because many people don't know that and just assume that 'this' would always be an AirportScopeResolver in that case. 22:16:17 <frosch123> it's still a standard design to pass "parent" pointers or references via member constructors 22:23:55 *** Alberth has quit IRC 22:23:55 *** SmatZ has quit IRC 22:23:55 *** Hirundo has quit IRC 22:23:55 *** Belugas has quit IRC 22:23:55 *** planetmaker has quit IRC 22:23:55 *** Supercheese has quit IRC 22:23:55 *** FLHerne has quit IRC 22:23:55 *** welshdragon has quit IRC 22:23:55 *** orudge has quit IRC 22:24:03 *** Hirundo has joined #openttd.dev 22:24:03 *** planetmaker has joined #openttd.dev 22:24:03 *** Supercheese has joined #openttd.dev 22:24:03 *** FLHerne has joined #openttd.dev 22:24:03 *** Alberth has joined #openttd.dev 22:24:03 *** Belugas has joined #openttd.dev 22:24:03 *** welshdragon has joined #openttd.dev 22:24:03 *** SmatZ has joined #openttd.dev 22:24:03 *** resistance.oftc.net sets mode: +vvvv planetmaker Alberth Belugas SmatZ 22:24:03 *** orudge has joined #openttd.dev 22:24:03 *** resistance.oftc.net sets mode: +v orudge 22:25:05 *** Eagle_Rainbow has joined #openttd.dev 22:25:22 *** DorpsGek has quit IRC 22:25:33 *** DorpsGek has joined #openttd.dev 22:25:33 *** solenoid.oftc.net sets mode: +v DorpsGek 22:26:00 *** ChanServ sets mode: +v Eagle_Rainbow 22:28:16 *** Yexo has quit IRC 22:28:16 <frosch123> @op dorpsgek 22:28:16 <DorpsGek> frosch123: Error: I need to be opped to op someone. 22:28:23 <frosch123> exactly 22:28:27 *** Yexo has joined #openttd.dev 22:28:27 *** kinetic.oftc.net sets mode: +v Yexo 22:29:41 *** ChanServ sets mode: +o DorpsGek 22:30:01 <michi_cc> ChanServ to the rescue! : 22:30:03 <michi_cc> ) 22:30:10 <frosch123> did you do some trick? 22:30:14 <frosch123> or did it recover by itself? 22:30:33 <michi_cc> /msg ChanServ op #openttd.dev DorpsGek 22:31:13 *** michi_cc has quit IRC 22:31:13 *** Yexo has quit IRC 22:31:13 *** DorpsGek has quit IRC 22:31:13 *** SmatZ has quit IRC 22:31:13 *** Alberth has quit IRC 22:31:13 *** Eagle_Rainbow has quit IRC 22:31:13 *** Hirundo has quit IRC 22:31:13 *** Belugas has quit IRC 22:31:13 *** orudge has quit IRC 22:31:13 *** welshdragon has quit IRC 22:31:13 *** FLHerne has quit IRC 22:31:13 *** Supercheese has quit IRC 22:31:13 *** planetmaker has quit IRC 22:32:10 *** Yexo has joined #openttd.dev 22:32:10 *** DorpsGek has joined #openttd.dev 22:32:10 *** Eagle_Rainbow has joined #openttd.dev 22:32:10 *** magnet.oftc.net sets mode: +vovv Yexo DorpsGek DorpsGek Eagle_Rainbow 22:32:10 *** orudge has joined #openttd.dev 22:32:10 *** SmatZ has joined #openttd.dev 22:32:10 *** welshdragon has joined #openttd.dev 22:32:10 *** Belugas has joined #openttd.dev 22:32:10 *** Alberth has joined #openttd.dev 22:32:10 *** magnet.oftc.net sets mode: +vvvv orudge SmatZ Belugas Alberth 22:32:10 *** FLHerne has joined #openttd.dev 22:32:10 *** Supercheese has joined #openttd.dev 22:32:10 *** planetmaker has joined #openttd.dev 22:32:10 *** Hirundo has joined #openttd.dev 22:32:10 *** michi_cc has joined #openttd.dev 22:32:10 *** magnet.oftc.net sets mode: +vv planetmaker michi_cc 22:32:44 *** Alberth has left #openttd.dev 22:32:51 <Eagle_Rainbow> Seems like we have a blinker channel here... :-| 22:34:20 <michi_cc> frosch123: In case you didn't see, I did /msg ChanServ op #openttd.dev DorpsGek 22:34:32 <frosch123> i saw :) 22:37:08 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24694 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 23:07:28 *** LordAro has quit IRC 23:32:53 *** FLHerne has quit IRC 23:37:08 *** frosch123 has quit IRC