Config
Log for #openttd.dev on 12th November 2012:
Times are UTC Toggle Colours
00:00:13  *** Yexo- has joined #openttd.dev
00:00:43  *** pm has joined #openttd.dev
00:00:43  *** ChanServ sets mode: +v pm
00:01:40  *** Hirundo has quit IRC
00:02:03  *** SmatZ has quit IRC
00:02:13  *** |Terkhen| has joined #openttd.dev
00:03:30  *** frosch123 has quit IRC
00:04:53  *** Yexo has quit IRC
00:05:02  *** Terkhen has quit IRC
00:05:28  *** planetmaker has quit IRC
00:05:28  *** pm is now known as planetmaker
00:35:33  *** Webster has joined #openttd.dev
00:35:33  *** ChanServ sets mode: +v Webster
07:04:47  *** Knogle has quit IRC
07:05:33  *** Knogle has joined #openttd.dev
07:16:47  *** Knogle has quit IRC
07:25:46  *** |Terkhen| has left #openttd.dev
07:25:58  *** Terkhen has joined #openttd.dev
07:25:58  *** ChanServ sets mode: +v Terkhen
07:29:58  *** Zuu has joined #openttd.dev
07:29:58  *** ChanServ sets mode: +v Zuu
07:51:37  *** Zuu has quit IRC
08:11:47  *** Supercheese has quit IRC
09:44:01  *** frosch123 has joined #openttd.dev
09:44:01  *** ChanServ sets mode: +v frosch123
12:00:10  *** planetmaker has quit IRC
12:00:10  *** Terkhen has quit IRC
12:00:11  *** Yexo- has quit IRC
12:00:11  *** Hirundo_ has quit IRC
12:00:37  *** Hirundo has joined #openttd.dev
12:01:37  *** Terkhen has joined #openttd.dev
12:01:37  *** ChanServ sets mode: +v Terkhen
12:02:07  *** Yexo has joined #openttd.dev
12:02:37  *** planetmaker has joined #openttd.dev
12:02:37  *** ChanServ sets mode: +v planetmaker
15:11:11  *** V453000 has joined #openttd.dev
16:59:43  <frosch123> http://devs.openttd.org/~frosch/diffs/stuff2/ <- random selection of fixes, codechanges and featurettes
17:00:52  *** V453000 has left #openttd.dev
17:04:31  *** V453000 has joined #openttd.dev
17:04:34  *** V453000 has left #openttd.dev
17:14:45  *** SmatZ has joined #openttd.dev
17:14:45  *** ChanServ sets mode: +v SmatZ
17:31:54  *** FLHerne has joined #openttd.dev
17:33:59  *** ChanServ sets mode: +v Yexo
17:34:05  <Yexo> in 10_ the first chunk seems unnecesary if you apply the second chunk, but it's more clear to add it
17:34:42  <frosch123> well, multiplayer scenario editor :)
17:35:09  <Yexo> which we don't have :P
17:35:21  <Yexo> in 20_nop, where is it initialized already?
17:35:27  <frosch123> in constructor
17:35:40  <frosch123> of GoodsEntry
17:41:28  <Yexo> in 50_docs I'd like to see some more docs for last_speed, most notable the unit of the speed
17:42:04  <Yexo> and is days_since_pickup really in days or is it in "2.5 days"?
17:43:50  <Yexo> + * @param front The Vehicle to check. For trains, use the first engine. <- I assume it should be the first part for all vehicles types (articulated road vehicles, multiple aircraft parts)?
17:44:32  <frosch123> it's the front of the consist
17:44:55  <Yexo> that's what I thought, second part of that comment seems a bit off since it only talks about trains
17:45:07  <frosch123> do you have a better wording?
17:46:06  <Yexo> @param front The first Vehicle of the consist to check. <- perhaps like that?
17:46:50  <Yexo> No more comments up to and including 70_simplify.diff, will look at the other diffs later
17:47:09  <frosch123> thanks :)
17:51:46  *** LordAro has joined #openttd.dev
17:51:46  *** ChanServ sets mode: +v LordAro
17:57:44  *** V453000 has joined #openttd.dev
18:01:13  <frosch123> V453000: you won't get rid of us :p
18:01:35  *** V453000 has left #openttd.dev
18:07:03  *** LordAro has quit IRC
18:09:25  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24703 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:09:55  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24704 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:10:14  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24705 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:10:35  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24706 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:10:57  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24707 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:11:19  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24708 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:11:38  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24709 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:20:32  *** FLHerne has quit IRC
18:21:44  *** Zuu has joined #openttd.dev
18:21:44  *** ChanServ sets mode: +v Zuu
18:45:00  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24710 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:47:58  <michi_cc> frosch123: The commit message in 91_fs5262.diff has an obiwan ;)
18:49:28  <frosch123> has it?
18:50:25  *** Alberth has joined #openttd.dev
18:50:25  *** ChanServ sets mode: +v Alberth
18:55:18  <frosch123> hai albert :)
18:55:29  *** pachuco has joined #openttd.dev
18:55:32  <frosch123> http://devs.openttd.org/~frosch/diffs/stuff2/ <- in case you also want something to read
18:55:39  *** pachuco has quit IRC
18:55:42  <frosch123> 10-70 are already committed though
18:58:25  *** FLHerne has joined #openttd.dev
19:00:32  <Alberth> 80 message: no other vehicle unloading     s/un//  ?   (unless pickup means something else than I think
19:01:01  <Alberth> since 10k3 :)   quite old :)
19:01:22  <frosch123> well, it is about checking whether a vehicle only unloads, or also loads
19:02:06  <Alberth> 91 Tollerate  s/ll/l/
19:02:20  <Terkhen> I was just going to mention that :)
19:02:22  <Terkhen> hello btw
19:02:26  <Alberth> hi :)
19:02:27  <frosch123> michi_cc: did you mean that with obiwan? one "l" instead of two?
19:03:44  <michi_cc> Yeah, you're off by one l :
19:04:50  <frosch123> i checked the fs number 3 times :p
19:08:27  <Alberth> queue seems ok to me, with my barely existing newgrf knowledge
19:08:49  <frosch123> the first part was less about newgrfs :p
19:10:40  <Alberth> I was reading that now :)     Trying to fix the station acceptance thingie?
19:11:45  <frosch123> no, only the weird documentation of the GoodsEntry, and the numerous bugs and inconsistencies which resulted of it
19:12:09  <frosch123> but, it might be a some preparation for the accept/deny supplies thingie
19:12:15  <Alberth> I like 20 :)
19:12:25  <Yexo> I'd like to propose a rename of "days_since_pickup" to "station_ticks_since_pickup" or so
19:12:39  <frosch123> yeah, 20 is nice :p
19:12:46  <frosch123> smatz would also love it :)
19:13:39  <frosch123> GES_PICKUP might also profit from some renaming
19:13:59  <Yexo> +			case 0x61: return ge->HasVehicleEverTriedLoading() ? ge->days_since_pickup : 0; <- is that change required?
19:14:01  <frosch123> something like GES_HAS_RATING or so
19:15:02  <Yexo> HasBit(ge->acceptance_pickup, GoodsEntry::GES_HAS_RATING) <- would look strange
19:15:08  <frosch123> Yexo: technically not, but i tried to remove all magic values
19:16:30  *** FLHerne has quit IRC
19:16:56  <Yexo> VEHICLE_LENGTH should be renamed to VEHICLE_MAX_LENGTH or so
19:17:05  *** FLHerne has joined #openttd.dev
19:20:48  <Yexo> didn't check all code of 93_, but the rest looks fine
20:12:18  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24711 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
20:12:37  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24712 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
20:12:55  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24713 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
20:13:09  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24714 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
20:13:27  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24715 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
20:13:43  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24716 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
20:13:59  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24717 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:34:20  *** Alberth has left #openttd.dev
21:47:46  <frosch123> http://devs.openttd.org/~frosch/diffs/renaming/ <- the earlier suggested renamings
21:47:52  <frosch123> i am not sure whether MAX_VEHICLE_LENGTH fits
21:48:00  <frosch123> could as well be DEFAULT_VEHICLE_LENGTH
21:48:17  <Yexo> define both to be the same and use them where appropriate?
21:48:42  <frosch123> that's thard
21:48:54  <frosch123> i would need a MAX_VEHICLE_SHORTENING then :p
21:49:00  <frosch123> which makes it even more weird
21:49:59  <Yexo> hmm, I see
21:50:56  <Yexo> last chunk of stationticks.diff still has a var named "days"
21:51:19  <frosch123> ah, i only did sed :p
21:52:08  <Yexo> not sure about the MAX_VEHICLE_LENGTH, given the problem above
21:52:24  <frosch123> i rename the "days" to "traveltime", ok?
21:52:30  <Yexo> fine :)
21:52:36  <frosch123> VEHICLE_LENGTH fits stuff like TILE_SIZE
21:52:41  <frosch123> maybe we should not rename it
21:52:45  <Yexo> exactly
21:54:35  <frosch123> oh, we have Station::time_since_load and _unload
21:54:38  <frosch123> which use the same units
21:54:44  <frosch123> so maybe time_since_pickup then?
21:55:04  <Yexo> fine with me too
21:55:14  <Yexo> as long as "days" is gone I'm happy :)
21:58:54  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24718 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
21:59:41  <Yexo> thanks :)
22:05:35  *** FLHerne has quit IRC
22:07:24  *** FLHerne has joined #openttd.dev
23:02:56  *** frosch123 has quit IRC
23:49:01  *** Zuu has quit IRC

Powered by YARRSTE version: svn-trunk