Log for on 25th November 2012:
Times are UTC Toggle Colours
00:32:46  *** MinchinWeb_ has joined
00:39:57  *** MinchinWeb has quit IRC
01:38:18  *** Sturmi has quit IRC
08:21:40  *** Supercheese has quit IRC
09:00:05  *** Alberth has joined
09:00:05  *** ChanServ sets mode: +v Alberth
09:44:39  *** fonsinchen has joined
09:44:39  *** ChanServ sets mode: +v fonsinchen
09:59:35  *** Sturmi has joined
10:27:52  *** ntoskrnl has joined
11:20:19  *** ntoskrnl has quit IRC
11:32:12  *** frosch123 has joined
11:32:13  *** ChanServ sets mode: +v frosch123
11:39:01  *** MinchinWeb_ has quit IRC
11:39:04  <Alberth> moin
11:39:22  *** MinchinWeb_ has joined
11:41:13  <Alberth>
11:41:17  *** andythenorth has joined
11:41:17  *** ChanServ sets mode: +v andythenorth
11:41:24  <Alberth> yo andy
11:41:35  <andythenorth> lo
11:44:07  * planetmaker goes give that patch a try
11:46:17  <frosch123> Alberth: in src/scrip/api run both and :)
11:47:50  <frosch123> there is some function to get the cargos in sorted order
11:48:50  <frosch123> FOR_ALL_SORTED_CARGOSPECS
11:49:38  <frosch123> hmm, or FOR_ALL_SORTED_STANDARD_CARGOSPECS
11:49:45  <frosch123> there is no documentation about the difference :p
11:50:23  <frosch123> ah, it excludes stuff like "regearing"
11:50:31  <frosch123> so, i guess you need FOR_ALL_SORTED_STANDARD_CARGOSPECS then :)
11:51:06  <frosch123> how about a new menu item in the "industry" menu?
11:51:18  <frosch123> it feels weird to click some random industry, and then select whatever cargo
11:53:57  <frosch123> if you use ShowDropDownList instead of ShowDropDownMenu, you don't need "cargo_numbers". the dropdown can translate the strings into any id itself
11:55:00  <Alberth> I did run both, perhaps in the wrong order :)
11:59:05  <Alberth> from the menu, open with the first industry?
11:59:23  <frosch123> industry? you mean cargo?
12:00:02  <Alberth> the code doesn't support that currently, but that would be an alternative
12:00:03  <frosch123> first would be pax then, but i guess the is no correct choice
12:00:31  <frosch123> opening it for an industry imo only makes sense if there is also a dropdown for industrytype :p
12:01:50  <andythenorth> what's the feature?
12:02:13  <Alberth> cargo dropdown in the industry chain window
12:02:46  <frosch123> entering the chain window without having to find a industry which produced the stuff :)
12:03:29  <Alberth> While making coffee, I also pondered about an industry dropdown; could be useful
12:04:27  <frosch123> opening it for the first industry might be nicer then
12:04:50  <frosch123> while there is no right choice, pax is definitely second most useless :)
12:04:53  <frosch123> (after mail)
12:05:29  <Alberth> it also makes slightly more sense in an "industry" menu :)
12:06:10  <andythenorth> I always do chain window - link to minmap :P it's a nice feature
12:07:00  <Alberth> but doing that for a specific cargo, is a pain
12:07:08  <andythenorth> is a map overlay out of the question?  Like another sign layer?
12:07:27  <frosch123> you mean like cargodist connections?
12:08:04  <andythenorth> not sure, havent' seen them.  It's how railroad tycoon handles showing source / destinations for cargo
12:08:11  <andythenorth> directly on the map
12:08:18  <andythenorth> or we could do it on the minimap
12:08:19  <frosch123> well, showing all connections hardly makes sense :)
12:08:47  <frosch123> you would have to select a signle industry, and then only display the closest suppliers or destinations
12:08:52  <andythenorth> I was thinking the map shows points, with icon or label, and arrow for input / output
12:09:04  <andythenorth> I should mockup :P
12:09:12  <frosch123> so plus/minus icons?
12:09:34  <andythenorth> grain > 2,000t
12:09:36  <andythenorth> > grain
12:09:47  <andythenorth> etc
12:10:00  <andythenorth> literally using the existing signs
12:11:53  <Alberth> that sort of means you'd merge the industry chain window into the minimap, imho
12:13:55  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24762 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
12:16:58  <andythenorth> I favour either small icons on the minimap (new view on the minimap, similar to industries, shows cargos, each cargo can be toggled on / off)
12:17:02  <andythenorth> or signs on the actual map
12:17:17  <andythenorth> minimap seems most in tune with rest of game
12:19:58  <frosch123> well, only a mockup can tell
12:20:07  <frosch123> i fear you won't find anything on the minmap anymore :p
12:21:00  <frosch123> independen of that, i might be useful to tell the chain window whether it shall only display the input or output industries on the minmap
12:21:45  <Alberth> I tried that, but I wasn't really happy with the interface, let me try to find the patch
12:23:55  <Alberth>
12:24:38  <Alberth> just for testing
12:34:25  *** MinchinWeb__ has joined
12:41:16  *** MinchinWeb_ has quit IRC
13:06:11  *** andythenorth has quit IRC
14:35:06  *** ntoskrnl has joined
14:51:44  <Alberth>  second attempt
14:52:04  <Alberth> added industry drop-down, and the other remarks
14:52:54  <Alberth>   and a few doc strings, but not sure it is enough for a commit.
14:55:27  <frosch123> hmm, is it possible that there are no industry types at all? :p
14:55:53  <frosch123> maybe turn the assert into a return for that case
14:59:15  <Alberth> if (lst->size() == 0) break;      then :)
14:59:34  <frosch123> maybe also use _sorted_industry_types in ShowIndustryCargoesWindow as well
14:59:48  <frosch123> Alberth: delete lst
15:00:07  <Alberth> when?
15:00:25  <frosch123>  if (lst->size() == 0) { delete lst; break; }
15:00:38  <Alberth> oh!
15:01:44  <Alberth>   hmm, not good :p
15:03:57  <Alberth> used the _sorted_industry_types in the Show function as well
15:04:39  <frosch123> is it necesary that ShowDropDownList gets a valid selected item?
15:04:59  <frosch123> "lst->front()->result" looks weird in game
15:05:10  <frosch123> does -1 work?
15:05:30  <frosch123> or does that need catching in OnDropdownSelect ?
15:06:31  <Alberth> don't know, but not selecting may be better indeed
15:07:56  <Alberth> looks like it, DropdownWindow has nothing special for selected_index < 0
15:08:54  <Alberth> if (index < 0) return;    added in OnDropdownSelect
15:09:40  <frosch123> assert(id < NUM_INDUSTRYTYPES); <- did you also replace that one with a return?
15:09:49  <Alberth> no
15:10:28  <Alberth> hmm, but it may thus crash for selecting a default industry :(
15:11:42  <frosch123> diff looks like a nice feature to me :)
15:12:16  <frosch123> hmm, was the window also resizeable before?
15:12:28  <Alberth> yes
15:12:44  <frosch123> it feels weird that you can resize it horizontally, but the chain display is not centered
15:13:27  <Alberth>  my changes, still need to test the -1
15:16:09  <Alberth> seems to work
15:16:39  <frosch123> \o/
15:16:47  *** andythenorth has joined
15:16:47  *** ChanServ sets mode: +v andythenorth
15:17:41  <Alberth> there is not much point in horizontal resize at all
15:18:09  <frosch123> yeah, forbidding that should also work
15:23:44  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24763 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
15:31:26  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24764 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
15:34:47  <Alberth> added the docs patch to my other doc string fixes
15:35:08  <andythenorth> +1 to the industry chain window changes
15:35:11  <andythenorth> just tested them
15:36:23  *** andythenorth has quit IRC
15:59:53  *** MinchinWeb_ has joined
16:06:58  *** MinchinWeb__ has quit IRC
16:13:11  *** fonsinchen has quit IRC
17:36:43  *** MinchinWeb has joined
17:36:43  *** MinchinWeb_ has quit IRC
18:04:09  *** Alberth has left
18:08:24  *** Sturmi has quit IRC
18:19:31  *** Sturmi has joined
18:42:13  *** andythenorth has joined
18:42:13  *** ChanServ sets mode: +v andythenorth
18:44:50  *** andythenorth has quit IRC
18:45:29  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24765 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
18:49:50  *** andythenorth has joined
18:49:50  *** ChanServ sets mode: +v andythenorth
19:15:52  *** MinchinWeb has quit IRC
19:27:07  *** Belugas has joined
19:27:07  *** ChanServ sets mode: +v Belugas
19:38:35  *** Supercheese has joined
19:41:45  *** ntoskrnl has quit IRC
19:45:11  *** andythenorth has quit IRC
19:47:07  *** andythenorth has joined
19:47:07  *** ChanServ sets mode: +v andythenorth
20:07:04  *** fonsinchen has joined
20:07:04  *** ChanServ sets mode: +v fonsinchen
21:20:28  *** Belugas has quit IRC
21:30:53  *** fonsinchen has quit IRC
21:36:55  *** andythenorth has left
21:40:43  *** Belugas has joined
21:40:43  *** ChanServ sets mode: +v Belugas
22:12:22  *** Sturmi has quit IRC
22:22:08  *** Sturmi has joined
22:24:39  *** frosch123 has quit IRC
23:38:54  *** Sturmi has quit IRC

Powered by YARRSTE version: svn-trunk