Times are UTC Toggle Colours
00:20:15 *** Zuu has quit IRC 01:48:08 *** Supercheese has quit IRC 01:48:39 *** Supercheese has joined #openttd.dev 01:54:57 *** DorpsGek has quit IRC 01:55:29 *** DorpsGek has joined #openttd.dev 01:55:29 *** ChanServ sets mode: +v DorpsGek 03:52:29 *** Knogle has quit IRC 03:55:34 *** Knogle has joined #openttd.dev 04:54:20 *** Knogle has quit IRC 05:20:48 *** Supercheese has quit IRC 06:07:02 *** Sturmi has joined #openttd.dev 06:11:43 *** Knogle has joined #openttd.dev 06:13:28 *** Supercheese has joined #openttd.dev 06:18:31 *** Knogle_ has joined #openttd.dev 06:18:33 *** Supercheese has quit IRC 06:19:05 *** Supercheese has joined #openttd.dev 06:19:46 *** Knogle has quit IRC 06:35:31 *** Sturmi has quit IRC 07:12:02 *** Knogle_ has quit IRC 08:31:12 *** Supercheese has quit IRC 14:07:11 *** ntoskrnl has joined #openttd.dev 14:14:04 <Belugas> hello 15:11:56 *** Hirundo_ has quit IRC 15:11:56 *** welshdragon has quit IRC 15:14:47 *** Hirundo has joined #openttd.dev 15:23:15 *** welshdragon has joined #openttd.dev 15:31:44 *** welshdragon has quit IRC 15:52:59 *** welshdragon has joined #openttd.dev 16:38:37 *** Sturmi has joined #openttd.dev 16:54:49 *** frosch123 has joined #openttd.dev 16:54:49 *** ChanServ sets mode: +v frosch123 17:10:38 *** ntoskrnl has quit IRC 17:38:24 *** FLHerne has joined #openttd.dev 18:40:41 *** Alberth has joined #openttd.dev 18:40:41 *** ChanServ sets mode: +v Alberth 19:18:27 <frosch123> hmm, what do you guess? 19:18:37 <frosch123> did capslock and shift always behave the same in the osk? 19:18:40 <frosch123> i.e. both lock 19:18:52 <frosch123> or was the shift broken some years ago? 19:18:59 <frosch123> with noone complaining ever :p 19:20:15 <frosch123> it works in 0.7 :p 19:20:55 <frosch123> already broken in 1.0 :) 19:25:54 <Alberth> it's not good being able to search that far back :p 19:26:14 <frosch123> pff, i always have them compiled 19:26:19 <frosch123> :p 19:26:44 <Alberth> I have some versions also compiled, but sort of 'when needed' :) 19:26:54 <frosch123> anyway, since i am reworking the osk somewhat to make it work in all cases... 19:27:02 <frosch123> how shall the cursor behave? 19:27:17 <frosch123> shall it stay visible and blinking in the parent window while the osk is open? 19:27:26 <frosch123> it was like that before, but feels a bit weird to me 19:28:04 <Alberth> didn't it echo the typed characters to both windows? 19:28:27 <Alberth> It was years ago that I tried it :) 19:28:43 <frosch123> yes, it does echo them to both 19:29:16 <Alberth> so blink only in the osk, but echo to both instead? 19:29:53 <Alberth> you might get confused what window your typing into 19:31:09 <frosch123> you are always typing in the osk 19:31:19 <frosch123> but, ok, it is a feedback which editbox is selected 19:53:04 *** Eagle_Rainbow has joined #openttd.dev 19:53:04 *** ChanServ sets mode: +v Eagle_Rainbow 19:53:14 <Eagle_Rainbow> good evening. 19:53:31 <Eagle_Rainbow> @frosch: Thanks for committing the network game list filter patch. 19:53:56 <Eagle_Rainbow> Though, I was a bit surprise - I had expected another code review on it, as I had changed a lot in the latest version 19:55:23 <Alberth> hi 19:55:38 <Alberth> svn revert can be arranged if you want :P 19:56:12 <frosch123> Eagle_Rainbow: it only became smaller iirc :) 19:56:48 <Eagle_Rainbow> Thanks :) But I prefer the "forward-patching approach", i.e. improving code quality with additional commits :) 19:57:00 <Eagle_Rainbow> frosch123: yes, I tried hard to do so... :) 19:57:43 <Eagle_Rainbow> can I assist you with the OSK somehow? Testing for example? 20:01:11 <Eagle_Rainbow> Alberth: IIRC you had a collection of typo fixes in prep? 20:01:41 <Alberth> I collect them, and dump them into trunk every now and then 20:01:54 <Alberth> I also collect doxygen comments 20:02:15 <Eagle_Rainbow> great... I have found some further typos... I'll send you along mine to integrate them into your collection,ok ? 20:02:32 <Alberth> sure 20:03:03 <frosch123> Eagle_Rainbow: i am currently working on it 20:03:21 <frosch123> already fixed a dozen of bugs... still counting :p 20:03:36 <Eagle_Rainbow> yeah, I saw it on the irc logs - that's why I am asking :) 20:04:18 <frosch123> anyway, after that i want to add a new adv setting :p 20:04:29 <frosch123> apparently really noone uses the osk 20:04:47 <frosch123> so i think we should add a osk setting: single click, double click, disabled 20:05:06 <frosch123> in case single click is not selected, we can then also add cusor positioning using the mouse 20:05:15 <frosch123> which is also kind of missing :p 20:05:26 <Eagle_Rainbow> Alberth: you got a pm in the forum with my typos 20:05:39 <Alberth> wouldn't removal of the osk be much easier? 20:05:46 <frosch123> not as much fun 20:05:59 <frosch123> also, isn't everyone working on android ports? 20:05:59 <Eagle_Rainbow> what about keyboard-less devices like ipad et al? 20:06:29 <Eagle_Rainbow> frosch123: my words ;) 20:06:39 <Alberth> I would expect that they have generic solutions for that problem ybh 20:06:42 <Alberth> *tbh 20:07:12 <Eagle_Rainbow> well, if you are using the device's default edit boxes, iirc 20:07:19 * Eagle_Rainbow is not an expert on mobile device dev. 20:08:36 <Eagle_Rainbow> So, cursor positioning would be enabled automatically, if osk setting would be set to disabled 20:09:04 <Eagle_Rainbow> (assuming that the osk wouldn't be dropped entirely) 20:11:05 <Alberth> lots of dots in your patch :) 20:11:18 <Alberth> and one typo in the fix :) 20:11:33 <Alberth> thanks for the file 20:11:54 <frosch123> http://devs.openttd.org/~frosch/diffs/oskfixes.diff <- now it seems to behave like i expect it to 20:13:14 <frosch123> i changed the focus behaviour 20:13:14 <frosch123> now the osk is focussed when opening, and closed when it loses focus 20:13:20 <frosch123> previously the osk somehow tried to transfer the focus back to the parent whenever it somehow got it 20:13:26 <frosch123> but that failed in various cases 20:15:07 <Eagle_Rainbow> Alberth: argl... :) 20:15:24 <Eagle_Rainbow> frosch123: I'll give your changes a try and attempt to break it somehow :) 20:15:31 <frosch123> :) 20:16:05 <Alberth> if (w->window_class == WC_OSK) w->InvalidateData(); <-- so much simpler :) 20:19:29 <Alberth> src/osk_gui.cpp, around line 200, just below "virtual void OnInvalidateData" line starts with a space 20:19:47 <Eagle_Rainbow> mmh... Pressing both shift and caps looks inconsistent to me... They appear to behave exactly the same (here) 20:20:48 <Alberth> HEBR_EDITING = 0, <-- drop the "= 0" ? 20:21:42 <frosch123> Eagle_Rainbow: shift is released when pressing a character button 20:21:50 <frosch123> caps is locked and inverts 20:21:56 <frosch123> shift + caps inverts twice 20:22:22 <frosch123> also doxygenized the HEBR constants 20:24:35 <Eagle_Rainbow> ok 20:27:55 <Alberth> I am somewhat wondering about the dynamic_cast, but this is the safest solution 20:28:11 <Alberth> nice patch 20:28:12 <Eagle_Rainbow> More a side-remark: The OSK layout seems to be derived from the system language and not from the OS' keyboard layout: I am having an English Linux here, but with a German keyboard layout - the OSK is then English keyboard layout 20:28:27 <frosch123> well, technically the FindWindowById is no longer needed 20:28:32 <frosch123> since it is always _focused_window 20:29:22 <frosch123> Eagle_Rainbow: the layout depends on the language you selected in ottd 20:29:36 <frosch123> check STR_OSK_KEYBOARD_LAYOUT and STR_OSK_KEYBOARD_LAYOUT_CAPS :) 20:29:43 <frosch123> the layout is "translated" :p 20:30:17 <frosch123> though no idea what the non-latin languages do 20:30:28 <Eagle_Rainbow> let's try :) 20:30:59 <frosch123> greek and hebrew both have the us layout 20:31:12 <Eagle_Rainbow> I'm in arab right now :) 20:31:22 <Eagle_Rainbow> Don't know what I am typing though, but it looks strange 20:31:23 <frosch123> but it is also quite likely that the translators do not understand the meaning of the string, and leave their fingers from it :) 20:31:50 <frosch123> oh, yeah, arabic is translated \o/ 20:31:50 <Eagle_Rainbow> The network filter string there looks quite strange... 20:32:06 <Eagle_Rainbow> but that could be due to the missing translation... 20:32:25 <Eagle_Rainbow> but the edit box of the filter string is writing LTR though I am typing arabic letters .... 20:32:43 <Eagle_Rainbow> sorry - need to correct me: 20:32:55 <Eagle_Rainbow> it's typing it RTL, but left-adjusted... :P 20:33:03 <frosch123> yeah, the osk looks quite wrong for arabic 20:33:11 <frosch123> backspace... ok 20:33:16 <frosch123> but cursor keys are wrong 20:33:20 <frosch123> cursor might also be wrong 20:33:34 <Eagle_Rainbow> well, they are also mirrored ;) 20:34:41 <frosch123> yeah, the buttons are inverted one time too much :p 20:34:45 <Eagle_Rainbow> the server's info box isn't mirrored properly as well (other story than the patch about which we are debating) 20:35:02 <frosch123> anyway, apparently the whole editbox stuff is incorrect for rtl 20:35:24 <Eagle_Rainbow> looks like this is worth an fs? 20:35:39 <Eagle_Rainbow> Do we have an arabic tester in the community who could give us better feedback? 20:36:14 <frosch123> likely not, else someone would have complained :p 20:36:47 <Eagle_Rainbow> We are just one-eyed men amongst the blinds ;) 20:36:48 <frosch123> https://secure.openttd.org/translator/en/status <- hebrew and arabic also have not seen a translator in a year 20:37:19 <Eagle_Rainbow> well, perhaps we just found the reason for that =:-D 20:39:44 <Eagle_Rainbow> Also Croatian seems to have the standard latin keyboard... 20:40:16 <Eagle_Rainbow> But besides all these localization matters, I can't get it to break... 20:40:29 <Eagle_Rainbow> how about the advanced setting then? 20:41:09 <Eagle_Rainbow> Should I have a look to propose a patch for that, or do you want to do that on your own? 20:41:13 <frosch123> ok, i am going to break the diff into logical committable parts then 20:41:58 <frosch123> i doubt i will get to the adv. setting today :) 20:42:21 <Eagle_Rainbow> ok, then I'll invest the next half an hour on that 20:42:28 <Eagle_Rainbow> perhaps I can get far enough until then... 21:10:03 *** Alberth has left #openttd.dev 21:57:23 <Eagle_Rainbow> frosch123: Just sent you a PM via the forum with how far I got + a screenshot 21:58:49 <frosch123> you cannot use a enum in the settings 21:59:08 <Eagle_Rainbow> well, at least it worked here... 21:59:16 <frosch123> SLE_UINT8 uses reinterpret_cast, so it fails on big endian 21:59:30 <Eagle_Rainbow> oh 21:59:31 <frosch123> so, usually we only use uint8 there 21:59:39 <Eagle_Rainbow> will change that 22:00:06 <Eagle_Rainbow> but you then compare it against the enum values? 22:00:59 <frosch123> sometimes we use no enum at all :p sometimes we use some template class which name i cannot remember 22:01:15 <frosch123> sometimes we define the enum with = 0 and so on 22:01:26 <frosch123> and compare int with enum 22:01:45 <frosch123> full = _osk_activation_mode_states <- hmm, is that common? 22:01:51 <frosch123> i do not remember ever using it :p 22:01:52 <Eagle_Rainbow> ok, then let's move the enum definition to osk_gui 22:02:01 <Eagle_Rainbow> me neither -- but that doesn't say much :) 22:02:10 <frosch123> i think you will only need the enum in misc_gui :p 22:02:11 <Eagle_Rainbow> it's mandatory for SDTC_OMANYs anyway... 22:02:51 <frosch123> is SDTC_OMANY the right thing? 22:03:00 <frosch123> isn't it many out of many? 22:03:38 <frosch123> so you can write "disabled|single" or "single|double|disabled" in the config? 22:03:41 <frosch123> like for transparency options 22:04:41 <Eagle_Rainbow> don't think so... 22:04:48 <Eagle_Rainbow> SDTC_OMANY renders as DDB 22:05:16 <frosch123> i would think SGF_MULTISTRING triggers the DDB 22:05:35 <Eagle_Rainbow> So, you then think SDTC_LIST is the right one? 22:06:23 <frosch123> no idea, but OMANY is definitely used more often than i thought 22:06:28 <frosch123> so, it might as well be correct :) 22:06:49 <Eagle_Rainbow> gimme a sec... I'll try the list first... 22:06:54 <Eagle_Rainbow> it sounds more logical to me... 22:07:35 * Eagle_Rainbow should be careful with "logical" when talking about the settings.ini :p 22:07:59 <frosch123> stuff like the roadside also use OMANY 22:08:03 <frosch123> so it's likely correct :) 22:08:27 <Eagle_Rainbow> still if thousands do it right, it doesn't mean that it isn't wrong ;) 22:09:35 <Eagle_Rainbow> nope - it's OMANY... List seems to be for arrays 22:10:08 <Eagle_Rainbow> and then we also need the full = ... statement 22:10:24 <Eagle_Rainbow> BTW: Do you really want to have the enum definition at misc_gui.cpp? 22:10:40 <Eagle_Rainbow> editbox stuff was moved out there, isn't it? 22:10:45 <frosch123> i am quite sure it's the only place you will need it :p 22:11:14 <frosch123> QueryString::ClickEditBox is there 22:11:42 <Eagle_Rainbow> that's an argument 22:12:52 <Eagle_Rainbow> further things I should change? 22:14:22 <frosch123> finish it :) 22:14:26 <Eagle_Rainbow> Then I'll send you the updated version 22:14:33 <Eagle_Rainbow> BTW: "Many out of many" is MMANY :) 22:14:40 <frosch123> i'll guess we'll have some discussion about the helptext when more people are here 22:15:08 <Eagle_Rainbow> for sure... as already said: Just a first shot that there is written at least something 22:16:31 <Eagle_Rainbow> you've got mail 22:17:00 <Eagle_Rainbow> feel free to change anything there :) This patch is just meant for help... 22:17:22 <frosch123> :) 22:18:01 <Eagle_Rainbow> Then, I'll help myself to bed ;) I'll have to get up early tomorrow... 22:19:12 <Eagle_Rainbow> cu! 22:19:18 <frosch123> night 22:19:26 <Eagle_Rainbow> n8 22:19:29 *** Eagle_Rainbow has quit IRC 22:49:29 *** frosch123 has quit IRC 23:00:42 *** Supercheese has joined #openttd.dev 23:39:14 *** FLHerne has quit IRC 23:42:53 *** Sturmi has quit IRC