Times are UTC Toggle Colours
03:17:21 *** fonsinchen has quit IRC 04:54:53 *** Dewin has quit IRC 08:28:40 *** Zuu has joined #openttd.dev 08:28:40 *** ChanServ sets mode: +v Zuu 09:45:06 *** ChanServ sets mode: +o orudge 10:59:12 *** Ristovski has joined #openttd.dev 13:29:28 *** Ristovski has quit IRC 13:35:27 *** Ristovski has joined #openttd.dev 14:00:36 *** ntoskrnl has joined #openttd.dev 16:58:52 *** ChanServ sets mode: +v orudge 17:01:38 *** ntoskrnl has quit IRC 18:15:20 *** Alberth has joined #openttd.dev 18:15:20 *** ChanServ sets mode: +v Alberth 18:43:04 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25113 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 19:27:07 *** frosch123 has joined #openttd.dev 19:27:07 *** ChanServ sets mode: +v frosch123 20:23:16 <frosch123> hmm, sometimes bugfixing is like: 1. remove all nonsense 2. insert the missing parts 20:27:15 <michi_cc> No, it's more like: 1. Start coding with the intention to do A, 2. Notice something tangentially related, 3. End up doing something completely different :p 20:27:47 <frosch123> yeah, or that :) 20:28:54 <Alberth> I often have stacks of such things: do A, notice B should be done first, do B, notice C should be done first, ... :) 20:29:16 <michi_cc> Right now I ended up with looking at the non-UNICODE windows build, which seems to have utterly broken file handling. For some strange ;) reason passing characters in some system code page directly into our utf-8 only internals looks very wrong. 20:30:01 <michi_cc> I can only guess that nobody ever tried that build with non-english file names for saves and such. 20:30:27 <frosch123> isn't there some OTTD2FS in all windows code? 20:30:43 <michi_cc> Noop for the non-unicode build 20:30:59 <michi_cc> So yes, there is, but it is used completely wrong. 20:32:38 <frosch123> Zuu: do you know whether gslibs can have texts and translations? 20:32:43 <frosch123> i suppose they cannot :) 20:33:05 <frosch123> hmm, yeah, clearly they cannot 20:33:19 <michi_cc> And the debug log output is sending utf-8 strings via ANSI functions to a console with a different code page to everything else (and for extra fun fixing that means removing the error output the OTTD2FS functions because we'd have an infinite loop on error otherwise). 20:34:34 <Zuu> gs libs can echo text and use the API to display/set text. But it cannot supply translated content using the OpenTTD translation framework. 20:35:14 <Zuu> Eg. it could try to implement one itself, but I don't know if GS have access to the 'language' setting. 20:35:46 <frosch123> well, first of all, ottd only loads english.txt for the main gs script 20:35:48 <frosch123> not for libs 20:36:11 <frosch123> it would also require "namespaces" for the string identifiers and such :p 20:39:07 <Zuu> I'm in a ticket to ride game, but will devote more attention shortly :-) 20:45:38 <Zuu> While the gs lib cannot provide a english.txt (that OpenTTD reads), I would guess that a lib can do GSText(GSText.STR_SOME_STR) and that will work assuming that the GS have that string. 20:46:49 <Zuu> This is because libraries run in the same global scope as the GSes. So as far as I've understood I wouldn't think that OpenTTD cannot tell if a GSText call was initiated from library or GS code. 20:47:11 <Zuu> hmm one negation too much ... 20:47:26 <Zuu> I don't think that OpenTTD can tell if ... * 20:49:30 <frosch123> dbg: [script] swedish:1: FATAL: Invalid UTF-8 sequence in 'Hej och v�lkommen {COMPANY}!' 20:49:37 <frosch123> your testcase is invalid :p 20:51:49 <Zuu> Yes I know 20:51:56 <frosch123> but the greeting "Hello unknown" is nice 20:52:46 <Zuu> But the nice thing about that is that as soon as you fixed the bug in the report the script will complain that it find string XYZ. :-) 20:53:02 <Zuu> So you get instant feedback :-) 20:53:43 <frosch123> http://devs.openttd.org/~frosch/diffs/fs5509.diff <- works for me 20:54:06 <Zuu> I'll test that. 20:54:10 <frosch123> the most fun part is, that there were various comments about making tars work before, which were all wrong :s 21:04:44 <Zuu> Is FOR_ALL_TARS iterating through an in-memory list of all tar files or will it examinate the content of all tar files found by OpenTTD? 21:05:11 <frosch123> it iterates over a std::map 21:05:27 <frosch123> which contains all filenames inside tars, scanned by ottd on startup 21:05:49 <frosch123> this is the same code as for finding .nut files 21:05:58 <Zuu> So the expansive disk read is already made at startup and iterating this std::map is then quite cheap even if it contains the content of 100 tars. 21:06:17 <frosch123> yes 21:06:25 <frosch123> it can be made better, but that is my other wip 21:06:42 <frosch123> this patch works for 1.3 :) 21:08:46 <Zuu> Your patch works here. 21:09:13 <frosch123> you are on windows? 21:09:17 <Zuu> Yes 21:09:24 <Zuu> Visual Studio 2008 21:09:36 <Zuu> And yes, for this bug its enough to use what is available rather than fixing all tools too. :-) 21:09:37 <frosch123> just wanted to check that i was right with the removed comments being wrong :) 21:10:30 <Zuu> I've tested both the test case and a GS that I have in unpacked form. (although that one exist both in tar + unpacked) 21:10:58 <Zuu> I haven't tested a GS that is only not in a tar, but the code looks good with respect to that. 21:14:24 <frosch123> oh, i should remove my debug printfs :) 21:15:38 <Zuu> That may be good. 21:16:43 <Zuu> I would comment that the "} else {" is for GSes that are not in a tar. Or comment the check. But that might go against "don't comment obvious things" 21:19:42 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25114 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 21:25:10 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25115 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 21:48:17 *** Alberth has left #openttd.dev 22:23:40 *** Ristovski has quit IRC 22:44:44 *** Supercheese has joined #openttd.dev 22:46:52 *** Zuu has quit IRC 23:01:32 *** frosch123 has quit IRC 23:44:05 *** Dewin has joined #openttd.dev