Log for on 13th October 2013:
Times are UTC Toggle Colours
01:13:15  *** Sturmi3 has quit IRC
07:21:39  *** Alberth has joined
07:21:39  *** ChanServ sets mode: +v Alberth
08:09:30  *** Supercheese has quit IRC
08:17:21  *** Ristovski has joined
09:01:43  *** Sturmi3 has joined
09:10:48  <LordAro> planetmaker, you want to continue patch reviewing? :)
09:12:01  *** adf88 has joined
09:18:45  *** adf88 has quit IRC
09:19:15  <planetmaker> Yeah I still have a bit time before I'm about to leave for today
09:19:32  *** adf88 has joined
09:19:46  <planetmaker> so, go ahead, LordAro ;-)
09:20:09  <LordAro> ok :)
09:20:21  <LordAro> 007 still needs a look at
09:21:07  <LordAro> and Zuu stopped at 009/010 because he got a world generation assert, although i couldn't reproduce
09:22:26  *** adf88 has quit IRC
09:22:40  *** adf88 has joined
09:24:52  *** adf88 has quit IRC
09:25:04  <planetmaker> got an URL for me, LordAro ?
09:25:04  *** adf88 has joined
09:25:17  <LordAro>  you forogtten already? :p
09:25:18  <planetmaker> somehow my history lacks the patch list view
09:25:34  *** Sturmi3 has quit IRC
09:25:41  <planetmaker> it's not a link name which is easily remembered or recognized :-)
09:26:05  <LordAro> true :)
09:26:36  *** ntoskrnl has joined
09:28:29  <LordAro> oh, and don't expect too much help from me - i've bee awake for ~24 hours now, and am a bit dead :L
09:30:23  <planetmaker> lol, why do you do that? :-)
09:30:50  <planetmaker> 011 just uses functions we have. So ok
09:31:48  <planetmaker> 012. Dunno. Really dunno. And not sure the compiler doesn't optimize it anyway :-)
09:32:18  *** adf88 has quit IRC
09:33:45  *** adf88 has joined
09:34:58  <planetmaker> @voice adf88
09:34:58  *** DorpsGek sets mode: +v adf88
09:35:17  <planetmaker> connection issues or wondering why you couldn't talk, adf88 ? ;-)
09:35:30  <adf88> Hi
09:35:38  <planetmaker> hi :-)
09:36:06  <adf88> The server didn't wan't to let me chat
09:36:09  <adf88> dont know why
09:36:19  <planetmaker> this channel requires voice.
09:36:25  <planetmaker> which no-one has by default
09:36:40  <adf88> After restarting  irc client for the third time it's OK
09:36:51  <planetmaker> yes... the 3rd time I gave you voice in this channel
09:36:52  <adf88> :)
09:37:44  <planetmaker> ask in #openttd, if you need voice here
09:37:51  <planetmaker> next time :-)
09:39:06  *** Sturmi has joined
09:40:18  <planetmaker> adf88, I've been wondering about FS#5783+5784. I couldn't exactl follow through that the goto button is no more lowered when I re-select a tool there
09:41:44  *** Sturmi has left
09:42:46  <adf88> 1. roll down the "go to" dropdown
09:42:54  <adf88> 2. select "go to"
09:43:01  <adf88> 3. roll down the drop down again
09:43:08  <adf88> 4. select "share orders"
09:43:28  <adf88> is the "Go To" button lowerd or not?
09:44:18  <planetmaker> not lowered :-)
09:45:00  <adf88> The drop down call RaiseButtons or sth when rolling up
09:45:03  <adf88> thus problems
09:48:16  <planetmaker> ah, this is what I wondered about:
09:48:27  <planetmaker> with fs5783, both applied:
09:48:41  <planetmaker> 1. select 'goto'
09:49:00  <planetmaker> 2. select 'conditional jump'
09:49:06  <planetmaker> 3. select 'goto'
09:49:22  <planetmaker> then giving orders became inactive
09:49:43  <planetmaker> let me check that in clean trunk
09:50:30  <adf88> This is the default behaviour
09:50:33  <planetmaker> yes. In unpatched trunk I can then still give orders
09:50:45  <adf88> no
09:50:48  <adf88> you can't
09:50:53  <adf88> wait a minute
09:52:48  <adf88> in clean trunk it's the same
09:53:00  <adf88> "normal" goto is different then other gotos
09:53:52  <adf88> while any goto tool is active and you select the normal goto then the tool turns off
09:54:11  <adf88> i have another patch :)
09:54:29  <adf88> which makes all goto types consistent
09:54:55  <adf88> the tool will turn off if you select the same goto type twice
09:55:15  <adf88> otherwise the tool stays active and other goto type is selected
09:55:44  <planetmaker> eh... for me the goto tool remains active whatever I select in the 'goto' drop down. In trunk
09:55:57  <adf88> hm?
09:56:34  <LordAro> there is a setting for that, somewhere, iirc
09:57:07  <adf88> OK, I know what are you experiencing
09:57:13  <adf88> this is the same bug
09:57:23  <adf88> try this:
09:57:48  <adf88> 1. roll down the drop down (while the tool is inactive)
09:58:06  <adf88> 2. select any goto type (normal/shared/condit)
09:58:12  <adf88> 3. roll down again
09:58:13  <planetmaker> adf88, the goto tool is supposed to stay active in the sequence I stated. It's not that I actually clicked anywhere other than the menu
09:58:18  <adf88> 4. select normal goto
09:58:41  <adf88> do it in clean trunk
09:58:48  <planetmaker> In clean trunk:
09:58:55  <planetmaker> 1) open goto, select goto
09:59:09  <planetmaker> 2) open goto, select conditional jump
09:59:39  <planetmaker> 3) open goto, select goto --> I can send train to station with goto tool
09:59:56  <planetmaker> with patches 10 and 11: --> no goto tool selected anymore
10:00:02  <adf88> yes, the bug affeted things
10:00:12  <adf88> while you were performing step 2
10:00:18  <adf88> try my sequence
10:00:49  <planetmaker> adf88, what I'm telling is: the patches, they disable the goto tools with a certain sequence. Which they shouldn't
10:01:03  <planetmaker> I don't say there's no bug with unselected *button*
10:01:20  <planetmaker> I say that the complete tool is de-selected with the patches with my sequence. Not only the button
10:01:55  <adf88> I'm saying that the bug is something more then just button not being lowered
10:02:19  <adf88> compare your and mine sequence
10:02:40  <adf88> with my sequence, the tool will turn off
10:02:56  <adf88> with our sequence, the tool will stay active
10:03:05  <planetmaker> hm, I see what you mean, yes
10:03:18  <planetmaker> true, you're right
10:06:36  <adf88> like I said, normal goto differs from other gotos - selecting it will turn of the goto tool
10:06:38  <planetmaker> adf88, but I think the patched behaviour is awkward and not consistent, too:
10:06:52  <adf88> yes
10:06:54  <adf88> i agree
10:06:56  <planetmaker> I keep the 'goto' tool active when I do *not* select 'goto', but any other.
10:07:07  <planetmaker> It de-activates the tool when I select 'goto'
10:07:07  <adf88> thus I have another patch to make all gotos consistent
10:07:16  <adf88> yes it is
10:07:19  <adf88> thats because
10:07:44  <planetmaker> same item as the button itself
10:08:01  <planetmaker> ?
10:08:10  <adf88> there is one function which handles both the button clicking (on the text area) and rop down selection
10:08:17  <adf88> OrderClick_GoTo
10:09:05  <adf88> it resets the goto tool if it's active
10:11:10  <planetmaker> hm, who was it who suggested in forums recently a more or less completely new order GUI?
10:12:28  <planetmaker> anyway, ok, you see what I meant. And you say you have a patch / patches to make that better, too?
10:15:15  <adf88> yes
10:15:20  <adf88> wait a minute
10:15:22  <adf88> uploading
10:16:05  <adf88> i have three more patches
10:18:16  <adf88> 1. highlight currently selected goto type while rolling down the drop down (currently always the first item is highlighted)
10:19:09  <adf88> 2. show active drop-down type in the goto button label (currently always "Go To" is shown)
10:19:57  <planetmaker> oh, I like the 2nd :-)
10:19:59  <adf88> 3. unify different goto tools (currently the normal goto is little different like I said)
10:20:48  <adf88> different cursor sprite for different goto type is coming too :)
10:21:03  <planetmaker> hm :-)
10:24:03  <planetmaker> adf88, what about s/OPOS_NONE/OPOS_INVALID/ ?
10:24:38  <planetmaker> not sure whether it should be the last or the first item. Usually the invalid ones are the last in our enums...
10:26:41  <adf88> hmm, maybe...
10:27:01  <adf88> here are the patches
10:27:02  <adf88>
10:27:24  *** frosch123 has joined
10:27:24  *** ChanServ sets mode: +v frosch123
10:28:23  <adf88> I'm preparing to add new alternate goto tools like "goto and transfer" or even custom, user-configurable goto
10:29:45  <planetmaker> adf88, I've been thinking whether a revamp of the order GUI, more thoroughly might be much better
10:30:36  <planetmaker> like adding checkboxes or similar for each order line which indicate
10:30:40  <adf88> whops, wrong URL, this is the right one:
10:31:16  <planetmaker> unload if accepted
10:31:22  <planetmaker> unload if not accepted
10:31:26  <planetmaker> load
10:31:59  <planetmaker> that would cover all load types, if those were boolean buttons
10:32:35  <planetmaker> with default as usual "unload if accepted" and "load"
10:32:50  <adf88> like this:
10:32:51  <adf88> ?
10:32:52  <planetmaker> hm... maybe rename the first two
10:33:03  <planetmaker> see, it was you :D
10:33:35  <planetmaker> yeah, I found the direction of that idea actually quite compelling
10:34:10  <planetmaker> me personally. I can't speak for anyone else :-)
10:34:58  <planetmaker> "deliver" "unload" "load"
10:35:15  <planetmaker> might be better names.
10:35:48  <planetmaker> thus "deliver" + "load" is default. "unload" only is our transfer. And "deliver" + "unload" is our current "unload"
10:36:37  <planetmaker> the bonus with a button interface is that you can re-configure orders with much less clicks and mouse movement
10:37:07  <planetmaker> and if you have pictogramms in the top row, you don't need the lengthy words I just invented :-)
10:37:35  <planetmaker> I actually have in my head an idea on how they could look like... I just need to create a mockup from that mental image :-)
10:41:03  <planetmaker> in 30-show... you could give +static const StringID _order_goto_dropdown_label[] = {
10:41:03  <planetmaker>  a short preceeding doxygen comment
10:42:22  <planetmaker> adf88, can you put the patches unzipped in your dropbox? :D
10:43:00  <adf88> yes
10:43:34  <adf88>
10:44:56  <planetmaker> easier to refer to then :)
10:45:04  <planetmaker> and easier to update
10:45:15  <adf88> BTW, dropbox plagin for nautilus rocks
10:45:20  <adf88> plugin
10:45:57  <planetmaker> yes, that's quite decent
10:46:31  *** Sturmi has joined
10:51:12  <planetmaker> hm, looking at order* files... OPOS_NONE is quite fine, I guess :D
10:51:58  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25855 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
10:52:16  <planetmaker> I wonder whether frosch123 will chew on me, if I commit 10 ... 20 :D
10:52:58  <frosch123> anytime of the day :) everytime i met you there was some cake around
10:53:46  <planetmaker> :D
10:54:01  <frosch123> anyway, i didn't follow the discussion
10:54:38  <planetmaker> <adf88> <-- they fix the somewhat inconsistent order button behaviour FS5783+5784+30-... and 40-...
10:54:58  <frosch123> it seems to be about lowering the goto button, right?
10:55:04  <frosch123> there is an advanced setting about that
10:55:06  <planetmaker> yes, when needed / active
10:55:11  <frosch123> whether it shall stay lowered or not
10:55:24  <frosch123> is that still being respected?
10:55:31  <planetmaker> it should stay lowered when you select the tool
10:55:44  <frosch123> oh, something like that
10:55:55  <planetmaker> *reselect the tool
10:56:46  <frosch123> @voice fonsinchen
10:56:46  *** DorpsGek sets mode: +v fonsinchen
10:57:06  <LordAro> @whoami
10:57:06  <DorpsGek> LordAro: I don't recognize you.
10:57:09  <LordAro> :(
10:57:14  <fonsinchen> Would any of that stuff change the internals of order handling? I.e. new order modifications or something?
10:57:28  <fonsinchen> As then I would have to rethink how to handle them with cargodist.
10:57:54  <LordAro> anyway, i'm packing up here, so i'll see you all later - don't  forget about my patches ;)
10:57:56  <LordAro> bye all
10:58:06  <LordAro> (for about 12 hours :p)
10:58:15  <LordAro> well, 18
10:59:39  <planetmaker> fonsinchen, no, it's just about GUI
10:59:49  <planetmaker> no new order types created
11:00:20  <frosch123> well, fine by me
11:00:31  <fonsinchen> @voice fonsinchen
11:00:51  <fonsinchen> @whoami
11:00:51  <DorpsGek> fonsinchen: fonsinchen
11:04:21  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25856 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
11:05:21  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25857 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
11:06:06  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25858 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
11:06:59  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25859 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
11:07:58  *** LordAro has quit IRC
11:08:18  *** Sturmi has joined
11:13:34  <planetmaker> adf88, I think 40 should work such that the goto tool is never de-selected when choosing from the drop-down list. But only when clicking on the button
11:22:53  <adf88> I think otherwise :)
11:23:16  <adf88> but that's perfectly possible of course
11:28:14  <planetmaker> make it depend on the adv. option about 'quick orders' or how that is called :-P
11:30:42  <planetmaker> or maybe ask forums :D
11:36:00  <adf88> anyway
11:36:05  <adf88> i split the patch
11:36:11  <adf88> wait a minute
11:36:14  <adf88> will upload
11:38:09  <planetmaker> well, 30 is unaffected :-)
11:38:46  <planetmaker> I've to postpone further work on this for now, likely for today though. RL calling :-)
11:39:14  <planetmaker> make sure to drop by occasionally, here and on #openttd :)
11:39:23  <adf88> ready
11:39:38  <planetmaker> And keep up your nice work. I like it. Generally the work you do on openttd
11:39:54  <adf88> glad to hear that
11:47:10  *** Zuu has joined
11:47:10  *** ChanServ sets mode: +v Zuu
11:54:51  <Zuu> The assert that I did hit in 010 (cirdan queue) was not so much in hte map gen as I said but more in unloading of the title save game. With the updated 010 patch without the assert added by LordAro, I no longer hit any assert.
11:59:24  <frosch123> what kind of assert was it?
12:00:05  <Zuu> The assert was on the line that LordAro added (which is no longer included in the patch)
12:00:16  <Zuu> I unfortunately don't have that version of the patch anymore.
12:01:49  <Zuu> His asset line was in the begining of Depot::~Depot() and was possible an attempt to verify that the tile is not a hangar, but I don't remember how the assert line was formulated.
13:13:43  *** zydeco has joined
13:17:08  <frosch123> <- fs#5760
13:28:07  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25860 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
13:44:58  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25861 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
13:49:46  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25862 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
17:37:53  *** Supercheese has joined
17:45:48  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25863 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
19:06:08  *** LordAro has joined
19:06:08  *** ChanServ sets mode: +v LordAro
19:08:03  *** Sturmi has quit IRC
19:18:30  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25864 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
19:25:54  * LordAro gets bored and pokes developers:
19:27:41  <frosch123> everyone is gone or watching starcraft
19:28:36  <LordAro> :p
19:33:57  *** ntoskrnl has quit IRC
19:59:57  *** Ristovski has quit IRC
20:03:19  <Zuu> I've written the commit message for 010, all I need is to hit enter. Although I now possible need to do svn up first.
20:03:42  <LordAro> the wonders of svn :)
20:07:59  <frosch123> oh, i broke win compilation
20:08:03  <LordAro> D:
20:08:33  <frosch123> ah, no, it was wt3
20:08:47  <frosch123> some invalid stuff in arabic
20:09:01  <LordAro> someone should fix wt3 :p
20:09:14  <Zuu> Someone should do a lot of things :-)
20:09:48  <LordAro> i've done a lot of things, now i'm waiting for you lot to do a lot of things :p
20:10:18  <frosch123> pff, just unterminated { breaks it :p
20:10:37  <LordAro> hmm, would it be feasible to extend eints so it can do ottd strings? (not me personally, obviously :p )
20:11:06  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25865 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
20:12:12  *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25866 || Logs: || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking"
20:15:53  <frosch123> no, it is not particulary feasible
20:16:04  <frosch123> ottd website is stuck on only python, only django, old everything
20:18:31  <Alberth> what dies if we throw django away?
20:18:34  <Alberth> everything?
20:18:57  <frosch123> yup :p
20:19:20  <frosch123> anyway, eints has no ldap backend
20:19:37  <frosch123> and it would have to learn about ottd lang files
20:19:43  <frosch123> deal with 4k strings and such
20:19:56  <frosch123> so, all quite far away, and likely not worth the effort
20:20:14  <frosch123> anyway, django is not the problem
20:20:38  <frosch123> it is running on my vm along eints as well
20:21:31  <frosch123> but without an very active sysop, we cannot touch :)
20:22:59  <Rubidium> I don't think the translator needs to run in the same django instance
20:28:16  *** Alberth has left
20:55:26  *** zydeco has quit IRC
21:03:22  *** frosch123 has quit IRC
21:15:43  *** Ristovski has joined
21:36:07  *** Zuu has quit IRC
22:02:31  *** LordAro has quit IRC
22:13:33  *** Ristovski has quit IRC
23:13:02  *** carpii has joined
23:46:00  *** carpii has quit IRC

Powered by YARRSTE version: svn-trunk