Times are UTC Toggle Colours
00:33:03 *** LordAro has quit IRC 06:46:23 *** LordAro has joined #openttd.dev 06:46:23 *** ChanServ sets mode: +v LordAro 09:08:35 *** adf88 has joined #openttd.dev 09:08:35 *** ChanServ sets mode: +v adf88 11:11:29 *** adf88 has quit IRC 11:26:55 *** ntoskrnl has joined #openttd.dev 11:31:04 *** Supercheese has quit IRC 11:31:35 *** Supercheese has joined #openttd.dev 11:35:36 *** Sturmi has joined #openttd.dev 11:54:04 *** adf88 has joined #openttd.dev 11:54:04 *** ChanServ sets mode: +v adf88 11:54:19 <fonsinchen> I finally have a working solution for FS#5677 12:30:51 *** adf88 has quit IRC 12:40:14 *** adf88 has joined #openttd.dev 12:40:14 *** ChanServ sets mode: +v adf88 13:01:31 *** adf88 has quit IRC 13:33:32 *** Ristovski has joined #openttd.dev 14:19:12 *** adf88 has joined #openttd.dev 14:19:12 *** ChanServ sets mode: +v adf88 14:40:39 *** adf89 has joined #openttd.dev 14:43:21 *** adf88 has quit IRC 15:24:14 <fonsinchen> I'd like to commit the fixes for FS#5675 and FS#5677 15:24:25 <fonsinchen> And I have a question regarding the saveload version bump 15:24:47 <fonsinchen> Do we increment the SL version before or after all of its uses are commited? 15:25:49 <fonsinchen> The solution for FS#5677 comes in two parts, both of which save and load things. I don't want to waste two versions on that. 15:26:37 <fonsinchen> And I have some random other stuff that should be fixed: https://github.com/ulfhermann/openttd/commit/bbc24c35376020a1efa722106d372ddee66066e8 and https://github.com/ulfhermann/openttd/commit/7aaf1c1dea79c7a44690004d1c386cd0059538d3 15:27:30 <fonsinchen> (those are pretty trivial) 15:29:20 <planetmaker> to my understanding the version bump is included usually in the same patch which makes it necessary 15:31:39 <fonsinchen> Then I did it right 15:32:20 <fonsinchen> However, if - theoretically - anyone loads a game from in between those versions with a version past the later one, they will get a corrupt game. 15:47:33 <planetmaker> that means each of them makes it necessary :-) 15:52:37 <fonsinchen> Makes what necessary? A new version? I can use 2 versions if that is the right way (TM) ... 15:54:07 *** |sturmi| has joined #openttd.dev 15:55:59 <planetmaker> yes, two version. But I think it might not be necessary. More correct than need be :-) 15:56:26 <planetmaker> probably frosch has an opinion on that, too :-) 15:57:38 *** Sturmi has quit IRC 16:29:45 <fonsinchen> I have to leave for today. 16:29:59 <fonsinchen> bye 16:36:51 *** adf89 has quit IRC 16:40:06 <planetmaker> bye fonsinchen, have fun :-) 16:51:28 *** adf88 has joined #openttd.dev 16:51:28 *** ChanServ sets mode: +v adf88 16:56:38 *** adf88 has quit IRC 17:18:26 *** Sturmi has joined #openttd.dev 17:23:46 *** |sturmi| has quit IRC 17:37:16 *** frosch123 has joined #openttd.dev 17:37:16 *** ChanServ sets mode: +v frosch123 17:45:11 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25895 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:15:35 *** Alberth has joined #openttd.dev 18:15:35 *** ChanServ sets mode: +v Alberth 18:41:17 <frosch123> f27612a4: LinkGraph::Node::AddEdge: The cases in the switch need anoter indentation levelo, the default case needs a "break" 18:42:37 <frosch123> same in Edge::Update 18:45:27 <frosch123> compared to the old behaviour Node::AddEdge does no longer zero "usage" for the speical usage parameters 18:45:36 <frosch123> no idea, whether that is intended 18:46:39 <frosch123> is there an explanation/documentation in the source wrt. what restricted/unrestricted means? 18:49:02 <frosch123> wrt. the savegame version bump 18:49:16 <frosch123> bump it in the last patch which modifies the savegame 18:50:03 <frosch123> anyway, we only care about nightly savegames (and even they break sometimes) 18:51:48 <frosch123> your editor seems to add a lot of arbitrary linebreaks 18:54:52 <frosch123> personally i consider statements across multiple lines a pain, unless it reflects some && and || logic 18:55:19 <frosch123> enforceing a linelength of 80 chars is something i absolutely hate 18:55:36 <frosch123> i am not in favour of breaking any lines < 160 chars just for their length 18:57:13 <frosch123> linewrapping should always be done manually. using automatic linewrapping is almost offensive to me :) 19:12:13 *** ntoskrnl has quit IRC 20:36:16 <fonsinchen> Zeroing of usage is not needed as that's done in Init() 20:37:20 <fonsinchen> I'm not doing automatic line breaking. 20:37:28 <fonsinchen> This is all manual 20:38:13 <fonsinchen> I can make the lines longer, though. 20:40:33 <fonsinchen> I can also add break on default cases, but we've had some argument about that before ... 20:41:16 <frosch123> if you do it manually, and you intend to line break, it's fine. but there was some case which only changed a few chars in a line, but you added a linebreak 20:41:40 <frosch123> what switch has no break in default cases? 20:41:55 <frosch123> isn't it technically invalid to have no break at the end of a switch? 20:42:30 <frosch123> i do not remember any argument about that 20:42:35 <fonsinchen> No, I think on the contrary, you shouldn't have a break at the end, but all compilers accept it. Can't remember the details, though. 20:43:29 <fonsinchen> Where should I write about the restricted/unrestricted thing so that you immediately see it as an "uninitiated" person. 20:43:58 <frosch123> maybe in the enum definition? 20:49:55 *** Alberth has left #openttd.dev 20:51:10 *** frosch123 has quit IRC 21:02:50 <fonsinchen> OK 21:15:27 *** Zuu has joined #openttd.dev 21:15:27 *** ChanServ sets mode: +v Zuu 21:23:08 <fonsinchen> https://github.com/ulfhermann/openttd/commits/frosch 21:23:36 <fonsinchen> There those issues are fixed. If no one objects I'll commit that tomorrow. 21:28:36 *** Ristovski has quit IRC 21:51:44 *** adf88 has joined #openttd.dev 21:51:44 *** ChanServ sets mode: +v adf88 21:51:55 *** adf88 has quit IRC 23:18:49 *** _Sturmi has joined #openttd.dev 23:21:37 *** Sturmi has quit IRC 23:22:04 *** _Sturmi has left #openttd.dev 23:26:56 *** Zuu has quit IRC