Times are UTC Toggle Colours
00:37:35 *** JVassie has quit IRC 01:15:50 *** frosch123 has quit IRC 06:20:15 *** Supercheese has quit IRC 09:08:42 *** adf88 has quit IRC 09:23:37 *** Alberth has joined #openttd.dev 09:23:37 *** ChanServ sets mode: +v Alberth 11:18:48 *** frosch123 has joined #openttd.dev 11:18:48 *** ChanServ sets mode: +v frosch123 12:35:28 <fonsinchen> : https://github.com/ulfhermann/openttd/commit/3a3abae3e7b55f463829bc1fb202a946728ea6ae 12:35:33 <fonsinchen> any objections? 12:38:01 <frosch123> is that fs#5861? 12:41:13 <frosch123> + if (new_cid < NUM_CARGO && new_cid != v_start->cargo_type) { <- v_start->cargo_type or w->cargo_type ? 12:43:07 <frosch123> nvm, it uses v_Start->cargo_type everwhere 12:46:19 <frosch123> that check looks weird to me, shouldn't it rather check for cost.IsSuccess or something? 16:49:53 <frosch123> http://devs.openttd.org/~frosch/diffs/strcodes/ <- some string stuff 17:26:31 <Alberth> looking nice, although I don't get all details 17:26:57 <fonsinchen> cost.Succeeded() wouldn't be enough 17:27:17 <fonsinchen> It also has to re-reserve if the refit fails as it uncoditionally returns before 17:27:59 <fonsinchen> I could declare a new bool "do_refit" if you like that better. 17:32:00 <fonsinchen> Or it could just unconditionally reserve cargo_cap - RemainingCount() and cover all cases. That's probably better 17:40:54 <fonsinchen> https://github.com/ulfhermann/openttd/commit/55dded13e464477ee121bf13ce6bb37b9607b940 then 17:42:51 <frosch123> that looks good 17:44:56 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26236 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 17:59:28 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26237 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 17:59:44 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26238 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:00:03 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26239 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:00:20 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26240 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:00:40 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26241 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:00:56 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26242 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:01:18 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26243 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:01:33 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26244 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:01:52 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26245 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:07:00 *** Alberth has left #openttd.dev 18:45:12 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26246 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 21:53:35 *** adf88 has joined #openttd.dev 21:53:35 *** ChanServ sets mode: +v adf88 22:39:59 *** frosch123 has quit IRC 23:33:47 *** adf88 has quit IRC 23:36:14 *** Supercheese has joined #openttd.dev 23:36:14 *** ChanServ sets mode: +v Supercheese