Times are UTC Toggle Colours
05:25:44 *** Zuu has joined #openttd.dev 05:25:44 *** ChanServ sets mode: +v Zuu 06:46:03 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26784 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 09:00:18 *** Alberth has joined #openttd.dev 09:00:18 *** ChanServ sets mode: +v Alberth 09:30:58 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26785 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 11:05:06 *** frosch123 has joined #openttd.dev 11:05:06 *** ChanServ sets mode: +v frosch123 11:31:39 *** Supercheese is now known as Guest1705 11:31:42 *** Supercheese has joined #openttd.dev 11:31:42 *** ChanServ sets mode: +v Supercheese 11:34:31 *** Supercheese has quit IRC 11:35:02 *** Supercheese has joined #openttd.dev 11:35:02 *** ChanServ sets mode: +v Supercheese 11:37:10 *** Guest1705 has quit IRC 13:36:18 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26786 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 13:52:22 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26787 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 13:53:13 <Alberth> http://devs.openttd.org/~alberth/diffs/hide_vehicles take 2 13:56:23 <Alberth> I failed to fully understand the shading discussion of yesterday. I made 'selected' white+shade now. That is also what the order gui does. The order gui also changes the colour of a selected implicit order to a different grey colour, which I select in white+shade. I think that is correct, as 'hidden' has no semantical meaning 13:58:29 <Alberth> Also, I don't know what bankrupty code was intended, a new company now clears its 'hidden' flags of all engines 14:04:50 <frosch123> i didn't unterstood the shading either :) it behaved differently in-game than in-code :) 14:08:36 <frosch123> i like the uppercase SAVEGAME_VERSION in the filename, i should remember that 14:10:10 <Alberth> :) 14:10:24 <frosch123> i don't think the initialisation in afterload.cpp is needed 14:10:35 <frosch123> everything should be zero by the constructor 14:10:52 <Alberth> k, will remove it 14:12:22 <Alberth> editing patch file is soo useful :p 14:12:40 <frosch123> yup :) 14:15:40 <frosch123> +bool _engine_sort_show_hidden_engines[] = {true, true, true, true}; ///< Last set 'show all engines' setting for each vehicle type. <- i would actually make "false" the default 14:15:59 <frosch123> other opinions? 14:16:15 <Alberth> I thought about that, but if you 'hide' a vehicle then, it disappears 14:16:34 <Alberth> which will cause confusion for new users 14:17:14 <Alberth> on the other hand, experienced users will want 'false' 14:17:17 <frosch123> isn't "not disappearing but just showing 'hidden'" also confusing? :p 14:17:47 <Alberth> perhaps 14:18:19 <Alberth> I am fine with making it false by default, as most users will want that 14:19:22 <frosch123> autoreplace does not seem to use ctrl+click for hiding 14:19:31 <frosch123> is that already used for something else? 14:19:48 <Alberth> you also don't have a 'hide' button 14:20:00 <frosch123> oh, true 14:20:01 <Alberth> it's just display 14:20:02 <frosch123> fine then :) 14:21:17 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26788 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 14:22:51 * Alberth sets the default to false 14:29:04 <LordAro> frosch123, (re r26788) there's an ifdef and an ifndef, is that intentional? 14:29:18 <frosch123> yes 14:29:29 <frosch123> it's an if-else basically 14:29:58 <LordAro> mm, thought it might be 14:30:35 <LordAro> was just checking though, as none of the rest of the commit implied you were adding anything (to the "normal" build) 14:35:24 <frosch123> who uses normal builds? 14:37:54 <frosch123> i totally don't get what is broken with the shadow 14:37:59 <frosch123> it works in other lists 14:43:03 <frosch123> hmm, DrawLayoutLine totally does not handle TC_NO_SHADE 14:46:51 <frosch123> https://paste.openttdcoop.org/pa5u1n4qp <- no idea why that did not trigger in the order list 14:50:14 <Alberth> :O 14:51:12 <Alberth> line->CountRuns() == 0 would be one explanation 14:52:08 <Alberth> hmm, then it exits the function immediately at the top 15:07:23 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26789 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 15:09:06 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26790 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 15:18:59 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26791 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 15:22:59 <frosch123> ah, the order gui didn't work either. i just need to enable 32bpp mode for failure 15:25:12 <Alberth> mystery solved :p 15:25:55 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26792 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 15:41:03 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26793 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 15:44:19 <Alberth> I take it there are no un-addressed problems in the patch queue? 15:44:32 <frosch123> i failed to crash it :) 15:44:59 <Alberth> yeah, it's much less interesting now :p 15:46:18 <Alberth> found that problem though, it didn't check for NULL after conversion, in case of INVALID_ENGINE 15:51:44 *** ChanServ sets mode: +v Rubidium 15:51:49 <Rubidium> regarding the hiding and merging. Would it make sense to AND them together? So vehicles that weren't hidden for one of the companies won't become magically hidden by merging? 15:52:02 <Rubidium> although... when merging with AIs that'll be a nuisance 15:52:20 <Rubidium> so maybe leaving it as-is might be better 15:53:20 <Alberth> I assumed the player taking over the company has settings that work for him, would be bad to mess those up 15:53:31 <Rubidium> fair choice 15:54:05 <Rubidium> show_hidden_engines <- I presume it's engines in the Engine sense, not in the powered units that are at the front of consists, right? 15:54:16 <Alberth> ys 15:54:19 <Alberth> *yes 15:54:48 <Alberth> name is a little confusing in the code as well 15:55:19 <Rubidium> 'coding' style in strings is 'Ctrl+Click' 15:55:51 <Alberth> something like s/Engine/VehicleModel/ would probably be less confusing 15:56:07 <Alberth> +in the code 15:56:13 <Rubidium> definitely 15:56:50 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26794 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 15:59:22 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26795 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:03:04 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26796 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:03:42 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26797 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:08:25 <Alberth> fixed the Ctrl+Click 16:09:49 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26798 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:10:28 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26799 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:11:15 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26800 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:11:59 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26801 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:12:58 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26802 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:13:30 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26803 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:14:07 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26804 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:14:39 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26805 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:35:18 <Alberth> what to do with the todo? 16:37:36 <Alberth> https://paste.openttdcoop.org/pq2cwjjps what doesn't seem addressed is a reliability filter 16:41:33 <frosch123> i don't think that is needed with the manual filtering 16:41:33 *** frosch123 has quit IRC 16:44:59 *** frosch123 has joined #openttd.dev 16:44:59 *** ChanServ sets mode: +v frosch123 16:45:22 <Alberth> wb, deleted the item 16:45:26 <frosch123> [18:38] <frosch123> i don't think that is needed with the manual filtering 16:45:28 <frosch123> [18:39] <frosch123> it would also be hard to say what it should exactly do 16:45:47 <Alberth> second line was lost :) 16:46:58 <Alberth> let's see how it works for a while 17:45:45 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26806 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 19:51:25 *** Alberth has left #openttd.dev 21:28:02 *** Webster has joined #openttd.dev 21:28:02 *** ChanServ sets mode: +v Webster 21:30:51 *** Rubidium_ has joined #openttd.dev 21:31:51 *** Rubidium has quit IRC 21:40:48 *** Zuu has quit IRC 21:46:14 *** Webster has joined #openttd.dev 21:46:14 *** ChanServ sets mode: +v Webster 21:47:25 *** Rubidium has joined #openttd.dev 21:48:12 *** Hirundo has quit IRC 21:50:08 *** planetmaker has quit IRC 21:50:15 *** Rubidium_ has quit IRC 21:50:18 *** fonsinchen has quit IRC 21:51:49 *** fonsinchen has joined #openttd.dev 21:55:19 *** Hirundo has joined #openttd.dev 21:57:24 *** planetmaker has joined #openttd.dev 21:57:24 *** ChanServ sets mode: +v planetmaker 22:01:50 *** frosch123 has quit IRC 22:33:11 *** nickolai has joined #openttd.dev