Times are UTC Toggle Colours
00:08:31 *** Supercheese has joined #openttd.dev 03:31:11 *** Supercheese has quit IRC 06:14:08 *** nickolai has quit IRC 07:57:56 *** nickolai has joined #openttd.dev 15:38:25 *** Alberth has joined #openttd.dev 15:38:25 *** ChanServ sets mode: +v Alberth 16:48:06 *** frosch123 has joined #openttd.dev 16:48:06 *** ChanServ sets mode: +v frosch123 17:34:11 <fonsinchen> So if no one complains - https://github.com/ulfhermann/openttd/commit/dd0813a64941a59e303edde4817341a22f62dc9d for FS#6110 17:36:53 <Alberth> getting cargo stuck at some point is not the solution, this seems nicer to me 17:45:52 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26846 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 17:49:20 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26847 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 17:53:38 <fonsinchen> On top of that https://github.com/ulfhermann/openttd/commit/645a29d77e4adac687bf61e311c92cc6627746b1 - only reserve after refit if the vehicle has a refit order 17:54:03 <fonsinchen> This changes the behaviour of improved loading slightly 17:54:45 <fonsinchen> Vehicles without refit orders can "steal" cargo from vehicles with refit orders like this. But as we don't know if or when the refit will succeed we better do it like this. 17:56:24 <fonsinchen> Oh, actually we should also check for improved loading in the HandleRefit parameter ... 17:57:28 <frosch123> the abort_on_false is not checked between the two parts of dual headed engines, intended? 17:58:59 <frosch123> if the default parameter is supposed to result in the old behaviour, it needs to be true instead of false, intented? 17:59:40 <fonsinchen> 1, not intended 2, intended 18:00:15 <fonsinchen> Having it default to false is nicer for readability and all the other actions always return true anyway 18:07:09 <fonsinchen> https://github.com/ulfhermann/openttd/commit/b3a0500a0d06da566b5ac44b4b37e6d79ca14162 then 18:08:20 <fonsinchen> Now the next interesting thing is getting CT_AUTO_REFIT into the link prediction 18:08:24 * fonsinchen cries 18:50:18 <Alberth> oef :( 19:02:04 <Alberth> FS#6113 - Buy menu - refittable label can be confusing for articulated vehicle. https://paste.openttdcoop.org/pe0nneuny 19:02:18 <Alberth> The src/engine_gui.cpp change is unrelated, and a code change 19:03:47 <Alberth> people seem to confuse parts with cargoes, which I somewhat exploited to reduce the max number of entries :p 19:04:44 <Alberth> not sure I like the gold "(refittable)", shouldn't that be black? 19:10:32 <frosch123> hmm, livery refits 19:11:09 <frosch123> how were capacities of 0 displayed before? 19:11:44 <Alberth> don't know 19:12:41 <Alberth> if (cap[c] == 0) continue; <-- didn't change line 62 19:15:07 <Alberth> if (new_y == y) { <-- maybe line 835 of build_vehicle_gui.cpp handles that? 19:17:50 <frosch123> *refits |= 1 << cargo_type; <- SetBit imho 19:19:21 <frosch123> looks fine otherwise 19:19:24 <Alberth> I somewhat prefer the explicit bit operations, but np, I'll change it 19:19:26 <frosch123> until the next grf breaks it :p 19:20:12 <frosch123> * The refits are linked to a cargo rather than an articulated part to prevent an long list of parts. <- s/an/a/ 19:20:44 <frosch123> * @param cargoes [out] Total amount of units that can be transported, summed by cargo. <- doesn't the [out] need to be between @param and param name? 19:21:19 <Alberth> I thought not, but can test that 19:21:24 <frosch123> oi, there are various places in ottd which do it either way :p 19:21:32 <frosch123> which one does doxygen expect? :p 19:21:49 <Alberth> my output of doxygen doesn't have cargo_type.h for some reason 19:22:57 <Alberth> I thought the one after the name, but can test 19:23:47 <frosch123> http://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmdparam 19:24:31 * Alberth thought wrong, apparently :) 19:24:37 <frosch123> oi, didn't know abuot being able to doc multiple parameters at once 19:27:45 <Alberth> spiffy :) 19:27:49 <frosch123> http://docs.openttd.org/train__cmd_8cpp.html#aea7960ccf7eca1b9ca80d230bd8e687f http://docs.openttd.org/structTrain.html#a60466af01facbcaa37fcdf0c2edd9e41 19:27:55 <frosch123> not a big difference actually :p 19:29:39 <Alberth> in the latter case, the [out] is probably part of the description 19:33:32 <Alberth> indeed it is 19:35:49 <Alberth> https://paste.openttdcoop.org/pgkusdtgb update, SetBit added, an -> a, and moved the [out]s 19:36:45 <frosch123> :) 19:36:59 <Alberth> what do you think about the "(refittable)" colour? http://bugs.openttd.org/task/6113/getfile/9946/combine_car_refit.png 19:37:17 <frosch123> looks fine to me 19:37:27 <frosch123> i think black would look weird 19:37:39 <frosch123> and using a third colour would only fit with nuts :) 19:38:12 <Alberth> yeah, a third colour would be really bad :) 19:39:53 <fonsinchen> We should definitely be careful with adding more weirdness to that part of the newgrf spec 19:40:12 <fonsinchen> Refit to passengers and then half the vehicle carries mail?? wtf? 19:41:09 <Alberth> http://devs.openttd.org/~alberth/black_refittable.png experiment 19:41:20 <Alberth> btw hover timeout is too short 19:42:55 <Alberth> mail is very undervalued as cargo, everybody just transports passengers 19:50:41 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26848 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 19:53:22 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r26849 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 19:54:47 *** Alberth has left #openttd.dev 22:10:04 *** frosch123 has quit IRC