Log for #openttdcoop.devzone on 27th April 2012:
Times are UTC Toggle Colours
00:19:39  <michi_cc> Xotic750: OTTD trunk can also display brighter company colours. Brightness depends on both the palette remap colour and the brightness of the RGB pixel, which you can increase independently of the palette part.
00:22:05  <Xotic750> and that would be done through nml?
00:22:28  <michi_cc> No, through your graphics editor.
00:23:23  <michi_cc> Brightness for the blitter is simply max(R,G,B), with 64 being neutral (i.e. no change to the palette colour).
00:25:10  <Xotic750> aha, I would have to go back to blender for that otherwise the shadows would be altered
00:26:04  <Xotic750> something to tinker with once I get through the templating
00:26:08  <Xotic750> but thanks
00:28:44  *** th_gergo has quit IRC
01:12:00  <Brot6> OpenGFX+ Trains - Revision 437:6edccfa1c1f8: Change adds 32bpp templates for flatbed wagons (Xotic750) @
01:24:42  <Brot6> OpenGFX+ Trains - Revision 438:adc3d224d5ad: Change adds 32bpp TIM and Liveries (Xotic750) @
01:24:42  <Brot6> OpenGFX+ Trains - Revision 439:b2458ca081c7: Change adds 32bpp TIM and Liveries (Xotic750) @
01:38:38  <Brot6> Britrains (BROS based on CETS) - Revision 39:629c7b3f7e65: Fix: Temporarily disable GRFCodec and use... (oberhuemer) @
01:38:38  <Brot6> Britrains (BROS based on CETS) - Revision 40:25f17d2a2e21: some merge (oberhuemer) @
03:08:37  *** Nat_aS has quit IRC
03:08:51  *** Nat_aS has joined #openttdcoop.devzone
03:12:18  <Brot6> OpenGFX+ Trains - Revision 440:6f219d286676: Change adds template tmpl_engine8_42 for simulating 8 v... (Xotic750) @
04:38:59  <Brot6> OpenGFX+ Trains - Revision 441:50540a5c70a5: Re-templates standard engines, fixes switch order, fixe... (Xotic750) @
04:50:34  <Brot6> OpenGFX+ Trains - Revision 442:039b3de96b30: Fixes switch order, fixed Livestock to point to correct... (Xotic750) @
05:41:31  *** NataS has joined #openttdcoop.devzone
05:41:31  *** Nat_aS has quit IRC
05:45:35  *** andythenorth has joined #openttdcoop.devzone
05:57:31  *** andythenorth has quit IRC
07:13:54  *** andythenorth has joined #openttdcoop.devzone
07:29:32  *** th_gergo has joined #openttdcoop.devzone
08:10:42  *** andythenorth has left #openttdcoop.devzone
10:52:15  <planetmaker> moin
12:36:19  <Brot6> FIRS Industry Replacement Set - Revision 2796:ae853de37fd4: Update: French translation (OliTTD) (foobar) @
12:39:53  <Brot6> FIRS Industry Replacement Set - Revision 2797:c098be89fb0f: Feature: Australian English translation ... (foobar) @
13:48:58  <Xotic750> I guess planetmaker is back from his travels?
13:49:23  <planetmaker> yes, kinda :-)
13:49:24  <planetmaker> hi
13:49:35  <Xotic750> hi :)
13:49:57  <planetmaker> drove 2900km in 72 hours :S
13:50:14  <Xotic750> spain?
13:50:24  <planetmaker> vicinity of Rome
13:50:32  <Xotic750> aha :)
13:51:34  <planetmaker> and all that for 2 seconds observation time :-P
13:51:55  <Xotic750> what did you observe then?
13:52:13  <planetmaker> the ocultation of zeta tauri by the moon
13:52:43  <planetmaker> in principle it should give us the star's diameter... Not sure we succeeded, though
13:57:27  <Xotic750> cool :) you like your astronomy then
13:58:18  <planetmaker> that's what pays my bills...
13:58:35  <planetmaker> :-P
13:59:04  <Xotic750> :)
14:00:02  <Xotic750> I hope everything is in order with the nml and templating that I've done? sure you haven't had time to look yet :)
14:00:50  <planetmaker> afraid, I didn't yet
14:00:58  <planetmaker> :-(
14:01:10  <planetmaker> At least not since we last spoke
14:02:08  <Xotic750> well, I'm sure it could all use a review
14:03:02  <Xotic750> trying to find a nice photo of the eurostar and tuv at the moment to see what details can be added to the carriages
14:03:33  <Xotic750> but everything looks quite smooth and featureless in real life
14:11:21  <V453000> use your imagination then :p
14:11:31  <V453000> real life is limited
14:12:51  <Xotic750> I don't think I want to recess the doors and windows like with the original carriages, but I guess I will find something
14:13:01  <planetmaker> indeed. Just adding stuff which looks good ingame is enough
14:13:20  <planetmaker> reality can only be a guide in the best of circumstances :-)
14:13:46  <V453000> I usually end up adding some black/otherCC/yellow stripe or something similar
14:14:01  <V453000> if there is too much space looking uniform
14:14:43  <planetmaker> or probably the wagons could do simply with some micro detail, like small signs (different shade of colour), a hint of a door frame by slightly different colour or so
14:14:52  <planetmaker> hint of wagon number (1 or 2 px)
14:14:56  <planetmaker> stuff like that
14:15:33  *** andythenorth has joined #openttdcoop.devzone
14:16:33  <V453000> yeah
14:16:39  <Xotic750> I just found a good photo that has given some idea about the livery that should improve things a bit, and decals are possible but I was wondering about copyright with using actual decals
14:16:56  <planetmaker> what's "decals"?
14:17:13  <Xotic750> like from GNER, BR or Eurostar etc etc
14:17:13  <planetmaker> ah, nvm
14:17:16  <V453000> stickers?
14:17:28  <planetmaker> you can't properly draw them anyway. So that'll be no issue
14:17:29  <Xotic750> yep, the distinctive symbols
14:17:36  <V453000> well in EZ you can :z
14:17:36  <planetmaker> you can only hint at them. In the approx. colour
14:17:53  <planetmaker> I think even 4x won't resolve it sufficiently?
14:18:08  <V453000> idk not my cup of tea :)
14:18:33  <planetmaker> in any case, I'd not add real logos. It should remain somewhat generic
14:18:57  <Xotic750> I will see if I can find some similar decals
14:19:16  <planetmaker> Just make it illegible, if it's letters. There's pseudo-letters ;-)
14:19:32  <planetmaker> How big can that be? 4px height?
14:20:21  <Xotic750> sure, but the textures will come from real photos
14:20:26  <Xotic750> and as they are sources will need to be published
14:21:03  <planetmaker> the photos?
14:21:24  <Xotic750> yes, that is how you add textures
14:21:35  <andythenorth> replicating the real logos infringes copyright
14:21:49  <andythenorth> replicating anything that is trademarked infringes trademark
14:21:49  <planetmaker> or at least trademarks
14:22:08  <planetmaker> can't the textures simply be drawn?
14:22:17  <Xotic750> I will find something generic, free but simple
14:22:34  <Xotic750> yes, they can be drawn and saved as a jpg or png
14:22:37  <planetmaker> (honest question)
14:22:40  <Xotic750> and then used the same way
14:22:45  <planetmaker> ok
14:23:16  <Xotic750> it's a whole different world from pixel art :)
14:23:37  <planetmaker> :-D
14:23:37  <Brot6> FIRS Industry Replacement Set - Revision 2798:48d3f138bf85: Fix: pluralise 'bales' cargo unit correc... (andythenorth) @
14:24:02  <V453000> :>
14:24:29  <andythenorth> should use a 3D engine]
14:24:42  <planetmaker> what would it help?
14:25:08  <andythenorth> particle effects!
14:25:12  <andythenorth> weather!
14:25:14  <planetmaker> btw, Xotic750, did you encounter any other problems with pushes the time I was offline which needed recovery?
14:25:14  <andythenorth> rotation!
14:25:41  <Xotic750> I've been playing with particle effects, simulating smoke and steam
14:25:56  <Xotic750> all problems gone now using ssh :)
14:26:06  <planetmaker> ah, Ammler installed that?
14:26:08  <planetmaker> good
14:26:12  <Xotic750> yep
14:26:37  <Brot6> FIRS Industry Replacement Set - Revision 2799:d25fd94d278c: Update: Dutch translation. (Alberth) @
14:56:22  <planetmaker> <-- Ammler that looks weired wrt the tags... The 1.2.0 tag is there multiple times and the others don't have their own branch similarily
16:54:45  <Xotic750> planetmaker: can all the warnings be fixed by just replacing refittable_cargo_types with cargo_disallow_refit: [type, type, type]  ?
16:55:21  <planetmaker> that would give a different refit result
16:55:40  <planetmaker> actually... good point... it's been "broken" for too long...
16:56:43  <Xotic750> just wondered if I could fix it while I wait for my asia star models to be re-rendered
16:57:35  <planetmaker> it needs introduction of cargo_allow_refit and cargo_disallow_refit
16:57:56  <planetmaker> <-- like this
16:58:10  <planetmaker> but I never found the time to actually test that properly so that it gives the same result as now
16:58:18  <planetmaker> that's why it's not yet submitted :-)
16:59:32  <planetmaker> it's a tedious process to check whether results are the same for *every* cargo
16:59:47  <planetmaker> and that means for default industries, PBI, ECS and FIRS
16:59:53  <planetmaker> and OpenGFX+Industries
17:00:14  <planetmaker> though the latter should rather be unproblematic, but better give a brief check, too
17:01:11  <andythenorth> why so many disallow checks?
17:01:32  <planetmaker> has another start on the patch.
17:01:42  <planetmaker> which, andythenorth?
17:01:52  <andythenorth> in the cargo_rework.diff
17:01:53  <Brot6> Dutch Trains 2 - Feature #3945 (New): om(B)C series 1900 (Voyager1) @
17:01:54  <planetmaker> you mean explicitly disallowing cargos
17:01:56  <andythenorth> yes
17:01:56  <planetmaker> ?
17:02:13  <planetmaker> easier to do, IMHO. Disallow all known cargos. Except those you explicitly want
17:02:19  <planetmaker> And add those to the allow list
17:02:19  <andythenorth> +0.99
17:02:56  <planetmaker> that's how I created it: list of all cargos and disallow them. Then move cargos to the allow list depending on wagon
17:03:01  <andythenorth> seems overkill for PAX and MAIL classes
17:03:05  <planetmaker> yes
17:03:13  <andythenorth> otherwise makes sense
17:03:52  <planetmaker> but maybe someone creates a cargo which is PASS and FOOD and GOOD (soylent green). I want to exclude that :-P
17:03:58  <planetmaker> or so ;-)
17:04:15  <Xotic750> guess I'll give that a miss :)
17:04:28  <andythenorth> you could always add it later ;)
17:04:34  <Xotic750> also I've introduced a load of warning
17:04:35  <Xotic750> "src/gfx/flatbed/rail_flatbed_refineryproducts_temperate.png" at [x: 0, y: 0]: 80 of 18582 pixels (0%) are pure white
17:04:48  <planetmaker> fix it ;-)
17:04:50  <andythenorth> that'll be white pixels then
17:04:50  <Xotic750> I'm guessing I've accidently replaced a template with the wrong one
17:05:12  <Xotic750> I don't rember them when I originally began
17:05:30  <planetmaker> you either cut wrongly somewhere or you put pure white pixels somewhere - which should rather be 0xFCFCFC
17:05:50  <Xotic750> well, that's an original png
17:06:01  <Xotic750> not 32bpp related
17:06:15  <planetmaker> hm, indeed. But... why ... would they change at all?
17:06:40  <Xotic750> well, when I added the 32bpp sprites, I created some new templates
17:06:45  <Xotic750> or definitions
17:07:04  <Xotic750> and I'm guessing I have copied a wrong template somewher
17:07:10  <planetmaker> yes... but... do they (also) apply to the original 8bpp?
17:07:44  <planetmaker> and if so: why?
17:07:45  <Xotic750> the definitions do, the cpp ones
17:07:51  <planetmaker> hu?
17:08:07  <Xotic750> as they do the old 8bpp definitions plus the new 32bpp stuff
17:08:47  <Xotic750> these ones
17:08:49  <Xotic750> #define ENGINE_GRAPHICS_TROPICAL_SWITCH(name) \
17:08:49  <Xotic750> switch (FEAT_TRAINS, SELF, name ## _switch, CLIMATE_PARAM) { \
17:08:49  <Xotic750>     CLIMATE_TROPICAL: name ## _tropical_group; \
17:08:49  <Xotic750>     name ## _default_group; \
17:08:49  <Xotic750> }
17:08:49  <planetmaker> oh, you mean you created a common template for 8bpp and 32bpp
17:08:53  <Xotic750> yes
17:09:05  <Xotic750> so it does the 8bpp and 32bpp
17:09:19  <planetmaker> ehm, no, that won't introduce white pixel warnings
17:09:25  <planetmaker> Only the real sprite definitions can cause that
17:09:29  <Xotic750> so my guess is I copied the wrong template as a parameter
17:09:47  <Xotic750> for refinery products
17:09:58  <Xotic750> but I don't know what template it should be
17:10:00  <planetmaker> you must have changed somewhere the spriteset definition for that vehicle for 8bpp
17:10:11  <planetmaker> the switch has no business in that
17:11:17  <Xotic750> it may be that those warning were there originally, I don't remember
17:11:32  <planetmaker> test it
17:11:37  <planetmaker> hg up -rXXX is easy ;-)
17:13:13  <planetmaker> I can't guarantee it, but I usually check every sprite commit for that warning to NOT show
17:13:40  <planetmaker> and... I need to switch to using ssh for that repo, too
17:14:28  <Xotic750> :)
17:15:05  <planetmaker> well... that's not a very good thing really.
17:15:16  <planetmaker> It means people will have issues to checkout the repo via http
17:15:31  <planetmaker> and pushing via ssh is kinda a security issue, too :-(
17:15:42  <Xotic750> chechout was always fine, just pushes were a problem for me
17:15:52  <planetmaker> failed twice for me now
17:16:42  <Xotic750> how is pushing by ssh rather than https a security issue
17:18:00  <planetmaker> It allows commits to an arbitrary repo
17:18:24  <planetmaker> while https only allows to those where you're manager
17:19:08  <Xotic750> surely that's a permission configuration issue?
17:20:34  *** ODM has joined #openttdcoop.devzone
17:20:53  <planetmaker> possibly. But it also means more admin work. While the config via redmine permissions needs no work there from our side
17:21:08  <Xotic750> ok
17:21:57  <planetmaker> basically we didn't yet limit ssh to a per-repo access as we know all those who have
17:22:03  <Xotic750> well, if you can fix http/s so that it doesn't break with 200Mb + then we can use it :)
17:22:16  <planetmaker> he, yeah :S
17:22:28  <planetmaker> bah. Still pulling
17:26:48  <planetmaker> you were busy ;-) "Fügte 93 Änderungssätze mit 7705 Änderungen an 7398 Dateien hinzu "
17:28:11  <Xotic750> yep :)
17:31:16  <Xotic750> ok, I went from tmpl_railwagon to tmpl_railwagon42, so I guess the warnings must have already been there
17:31:51  <Xotic750> just more noticeable now because there are more warning than before
17:33:02  <Xotic750> will be uploading the ammended asia star sprites soon, thay have a little more detail and a livery change, so not so solid coloured any more
17:33:15  <planetmaker> more warnings means there are more bugs now?
17:33:23  <planetmaker> every warning is a bug
17:33:50  <Xotic750> no, tmpl_railwagon42 just repeats entires
17:33:57  <Xotic750> so same number of bugs
17:33:58  <Xotic750> :)
17:34:21  <Xotic750> just same bug repeated
17:34:41  <planetmaker> uhm... but with tmpl_railwagon42 you assume that the wagon is symmetric... ?
17:34:49  <planetmaker> that's iirc wrong fo the barrel wagons
17:35:21  <Xotic750> well, I need 8 sprites and that was the best I could think of at the time
17:36:33  <Xotic750> but yes I assumed 4 sprites were symmetric
17:38:18  <planetmaker> yes, 4 sprites are symmetric... I've the feeling we talk past each other and that I might have to refresh my memory first on how things work before I continue to argue ;-)
17:38:34  <planetmaker> also... I don't get a white pixel warning
17:39:04  <planetmaker> hm... why is my grf only 4 MB?
17:39:21  <Xotic750> it shoul be in the range of about 14Mb
17:39:31  <planetmaker> 14 or 140?
17:39:48  <Xotic750> 14Mb
17:40:02  <planetmaker> hm, Xotic750, can you review the style for commit messages please?
17:40:13  <planetmaker> Using a uniform style makes it MUCH easier to generate changelogs
17:40:39  <Xotic750> what style should I use?
17:41:11  <planetmaker> The one I use :-P
17:41:30  <planetmaker> hm..
17:41:58  <planetmaker> Fix #3943: flobber was broken
17:42:16  <planetmaker> Change: Adjusted light settings for model XY
17:42:19  <planetmaker> Codechange: Re-ordered some templates
17:42:26  <Brot6> planetmaker: #3943 is "Code Review #3943: Change template dimensions - Central European Train Set - #openttdcoop Development Zone"
17:42:29  <planetmaker> Feature: Added new sprites for MU XY
17:42:39  *** frosch123 has joined #openttdcoop.devzone
17:42:39  <Xotic750> ball, I just accidently tried to commit over https and broke it :) hg recover needed
17:42:51  <planetmaker> Feature #4003: Add TGV introduced in 2010
17:43:24  <planetmaker> Fix #3913 (r933): Models for TIM were accidentially flipped
17:43:51  <planetmaker> hu, how do you do that accidentially? Don't you have your .hg/hgrc configured?
17:43:57  <Brot6> planetmaker: #3913 is "Support #3913: Templated steamers - Dutch Trains 2 - #openttdcoop Development Zone"
17:44:21  <Xotic750> yes, but I use multple machines :)
17:44:34  <Xotic750> and this one still had the https address in it too, as default
17:44:40  <planetmaker> aye
17:45:29  <Xotic750> I will make sure that commit messages are more standard in future
17:45:38  <Xotic750> now I know about it
17:45:43  <planetmaker> I know, I didn't tell you :-)
17:46:20  <Xotic750> it's all a learning curve
17:46:20  <planetmaker> Basically it's a style very similar to the OpenTTD commit messages themselves. Though not identical
17:46:35  <planetmaker> well, it's nothing critical. But... it breaks my "make_changelog" script ;-)
17:46:56  <planetmaker> which allows me usually to make changelogs meanwhile pretty fast :-P
17:47:23  <Xotic750> just replace everything that I have done with something like add: 32bpp sprites :
17:47:45  <Xotic750> otherwise it's going to be huge anyway :P
17:47:51  <planetmaker> Yes, that's the manual post-process which would be needed anyway
17:47:58  <planetmaker> Users want a concise history. Not a per-commit one
17:48:45  <planetmaker> <-- if you're interested ;-)
17:49:27  <Xotic750> I don't know if you have any say or influence in the matter but ....
17:50:01  <Xotic750> I was thinking it would be nice if we can get the trains onto the openttdcoop welcome server
17:50:31  <planetmaker> We can do that, when we make a release.
17:50:52  <planetmaker> As we have the policy to use bananas-only NewGRFs there
17:51:21  <Xotic750> at what point would you consider the work release worthy? Do we need a full set of everything created and rendered?
17:51:22  <planetmaker> And sure enough, then it can be arranged
17:51:53  <planetmaker> No, we don't need a full set of everything. That'd be work for a too long period of time
17:52:31  <Xotic750> for standard temperate I think we have everything except steamers just now
17:52:45  <planetmaker> In principle we can make a release any time when it's good to get something out
17:52:53  <planetmaker> "release early, release often" :-)
17:53:36  <Xotic750> but yes, the welcome server seems like a nice place to start :)
17:53:44  <planetmaker> very much indeed
17:54:16  <Xotic750> did you hg recover?
17:54:21  <Xotic750> so I can upload?
17:54:35  <planetmaker> yes
17:54:43  <planetmaker> it's finished meanwhile
17:54:54  <planetmaker> it kinda triggered obviously a load warning on the server :S
17:55:33  <planetmaker> something I should consider next time. Maybe some nicing needs to be set
17:56:34  <planetmaker> Xotic750: can you make for the changelog a list of vehicles which got 32bpp?
17:56:57  <Brot6> OpenGFX+ Trains - Revision 443:209195e79383: Added detail and change of livery for Asia Star models (Xotic750) @
17:57:29  <Xotic750> it's the model.lst file :)
17:57:34  <Xotic750> in the scripts dir
17:57:34  <planetmaker> and... when / how do you get the white pixel warnings, Xotic750?
17:57:49  <planetmaker> can you paste the output of your build process?
17:57:49  <planetmaker> ok
17:57:49  <Xotic750> during compile using nmlc
17:58:04  <planetmaker> well, I don't
17:59:15  <Brot6> ogfx-trains: update from r433 to r442 done (115 warnings) -
17:59:24  <Xotic750>
17:59:49  <Xotic750> maybe different nml version?
18:01:00  <planetmaker> maybe, possibly
18:01:21  <Xotic750> I was using 1884 I think
18:01:22  <planetmaker> r1884 (19e523f6f3c5)
18:01:28  <Xotic750> ok
18:01:29  <planetmaker> nmlc --version
18:02:07  <Xotic750> sorry, I was wrong
18:02:08  <Xotic750> r1882 (0f45cdcaba1f)
18:02:29  <planetmaker> PIL 1.1.7 and PLY 3.4
18:03:15  <planetmaker> in any case... the revision difference in NML cannot account for the white pixel difference
18:03:40  <planetmaker> and... interestingly. NOW I do get them, too...
18:05:32  <Brot6> firs: update from r2782 to r2799 done -
18:05:39  <Xotic750> PIL: 1.1.7
18:05:40  <Xotic750> PLY: 3.3
18:05:54  <Xotic750> not that it matter though :)
18:06:09  <Xotic750> well, you have the updated Asia Star now
18:06:19  <Xotic750> I will try to do the same for TIM next week
18:06:37  <Xotic750> and then I will attempt to find the original sources for the steamers
18:06:48  <Xotic750> and see if they can be converted into the new format
18:06:58  <Xotic750> otherwise I will have to draw from scratch
18:09:30  <Xotic750> better finish my drink and go and meet the GF before she gets pissed with me :)
18:10:23  <planetmaker> haha :-) Enjoy
18:11:36  <Xotic750> you too :)
18:14:45  <Brot6> britrains: update from r38 to r40 done (10 warnings) -
18:16:24  <Xotic750> oh, something I just thought of before I go
18:17:11  <Xotic750> is it possible to stop double connecting TIM and Asia Star trains, as they have no buffer system on the fronts of the vehicles?
18:17:47  <Brot6> bandit: compile of r469 still failed (#3900) -
18:17:49  <planetmaker> It would be feasible. But... why should we disallow it?
18:17:58  <planetmaker> ICE trains do double connect
18:18:55  <Xotic750> just in real life they can't do it as they have no buffer/connection system on the front
18:19:04  <Xotic750> that's all
18:19:07  <planetmaker> ICE trains do in RL double connect
18:19:14  <planetmaker> as they do have buffers and connectors there
18:19:18  <andythenorth> planetmaker: can you add any detail to this ticket?
18:19:18  <andythenorth>
18:19:31  <Brot6> make-nml: compile of r0 still failed (#3730) -
18:19:32  <andythenorth> if there's more information, I can fix it next release
18:19:34  <Xotic750> but not on Eurostar and YUV
18:19:48  <Xotic750> on which they are based, not that I have found anyway
18:19:53  <planetmaker> that's why these trains are somewhat generic
18:19:59  <andythenorth> eurostar units connect
18:20:22  <planetmaker> after all, realistic players simply can choose to not connect them, too
18:20:29  <Brot6> metrotrackset: compile of r59 still failed (#3882) -
18:20:49  <Xotic750> sure, just I have not see any photos with buffers on the fronts
18:20:50  <Xotic750>
18:20:56  <Xotic750> they are all without
18:21:11  <Xotic750> and so I have no buffers on the fronts either
18:21:20  <Xotic750> no big stress though
18:21:35  <andythenorth> the front cowl lifts, there is a centre coupler under there
18:21:45  <planetmaker> ^^
18:22:23  <Xotic750> ok :)
18:22:45  <Xotic750> well, I have no graphics for that, if anyone complains :P
18:23:42  <andythenorth> you need one of these ;)
18:23:46  <andythenorth> Eurostar thunderbird
18:25:09  <Brot6> Central European Train Set - Code Review #3943: Change template dimensions (oberhuemer) @
18:26:20  <Xotic750> lol, ok :)
18:27:25  <planetmaker> andythenorth: look at sprites/nml/industries/fruit_plantation:5079 and alike. That is basically computer-generated code
18:27:31  <Brot6> Central European Train Set - Code Review #3943: Change template dimensions (oberhuemer) @
18:27:32  <planetmaker> And that definitely needs a review IMHO
18:27:48  <planetmaker> there's more of that there
18:28:18  <planetmaker> the industry itself seems clean to me on first sight
18:30:36  <andythenorth> so it's code review, not changes?
18:30:40  <planetmaker> also line 3804 and following might need a check whether it does the right thing [TM]
18:30:56  <planetmaker> probably yes. I don't exactly recall what I thought half a year ago :-P
18:31:06  <planetmaker> I guess I should have been clearer back then :-(
18:32:13  <planetmaker> andythenorth: I think you can still keep it open, though. It's not critical in any respect...
18:32:23  <planetmaker> But should be done before the fruit plantation is modified in any way
18:32:30  <planetmaker> or e.g. when trying to add fences
18:33:37  <andythenorth> oh, so that one doesn't seem to use many sprite layout templates?
18:33:44  <andythenorth> which is why it's about 6k lines :P
18:33:59  <planetmaker> it's 100% special or so
18:34:06  <andythenorth> k
18:34:12  <andythenorth> it should work similar to forest iirc
18:34:19  <planetmaker> *should* :-P
18:34:48  <andythenorth> I'll bounce it from 0.7.5
18:34:54  <andythenorth> I'm trying to get ticket count to 0 :P
18:35:21  <andythenorth> or at least <10
18:35:52  <planetmaker> you shouldn't do that with ticket count but with bug count ;-)
18:36:02  <planetmaker> (only their count really matters)
18:36:27  <andythenorth> bug count is currently 0
18:36:29  <andythenorth> afaik
18:36:58  <andythenorth> a lot of recent changes are to fix or reject bugs
18:37:10  <andythenorth> * ticket changes
18:40:52  <andythenorth> closed 50 tickets in April
18:41:13  <andythenorth> same amount as in last 9 months :P
19:02:12  <Brot6> FIRS Industry Replacement Set - Code Review #3352: Callbacks of fruit plantation (andythenorth) @
19:03:58  <planetmaker> :-)
19:19:18  <Brot6> CHIPS Station Set - Revision 182:acc62d60883d: Codechange: suppress warning type 107, seems to be sp... (andythenorth) @
19:19:18  <Brot6> CHIPS Station Set - Bug #3343 (Closed): Compile warning on sprite 15 /!!Warning (107): Label 00 has ... (andythenorth) @
19:19:47  <Brot6> CHIPS Station Set - Feature #2430 (Rejected): Cargo graphics for Sugar Beet (andythenorth) @
19:24:15  <Brot6> HEQS "Heavy Equipment" Set - Feature #1935 (Rejected): Reminder: adjust some vehicle weights if rv-w... (andythenorth) @
19:25:18  <Brot6> HEQS "Heavy Equipment" Set - Feature #3243 (Rejected): Check class masks for unwanted exclusions (andythenorth) @
19:25:58  <Brot6> HEQS "Heavy Equipment" Set - Feature #3292 (Rejected): Enable auto-refit for crawlers (andythenorth) @
19:27:21  <Brot6> HEQS "Heavy Equipment" Set - Feature #3291 (Rejected): Better faking of TE for articulated trucks (andythenorth) @
19:27:21  <Brot6> HEQS "Heavy Equipment" Set - Feature #3240 (Rejected): Convert to grfv8 (andythenorth) @
19:32:44  <Brot6> HEQS "Heavy Equipment" Set - Bug #3312 (Rejected): Model life properties incorrect for mining trucks... (andythenorth) @
19:32:44  <Brot6> HEQS "Heavy Equipment" Set - Bug #3312: Model life properties incorrect for mining trucks etc (andythenorth) @
19:42:03  *** frosch123 has quit IRC
20:22:44  *** th_gergo has quit IRC
21:08:45  *** andythenorth has quit IRC
21:40:17  *** th_gergo has joined #openttdcoop.devzone
22:05:35  <Brot6> OpenGFX+ Trains - Revision 444:b4e238c83825: Fix (r403): White pixels due to faulty offsets of the 8... (planetmaker) @
22:09:19  *** ODM has quit IRC
23:10:19  *** th_gergo has quit IRC

Powered by YARRSTE version: svn-trunk