Log for #openttdcoop.devzone on 4th November 2012:
Times are UTC Toggle Colours
00:38:10  *** MinchinWeb_ has joined #openttdcoop.devzone
00:45:11  *** MinchinWeb has quit IRC
00:46:47  *** MinchinWeb_ has quit IRC
00:47:08  *** MinchinWeb_ has joined #openttdcoop.devzone
01:07:31  *** MinchinWeb_ has quit IRC
01:12:45  *** Zuu has quit IRC
03:09:59  <Brot6> Total Town Replacement Set - Patch #4507 (New): Changing introduction dates for buildings - before 1... XkeozX @
03:50:05  *** Nat_aS has quit IRC
03:55:10  *** Nat_aS has joined #openttdcoop.devzone
04:15:15  *** MinchinWeb_ has joined #openttdcoop.devzone
05:02:21  *** Nat_aS has quit IRC
05:10:51  *** Nat_aS has joined #openttdcoop.devzone
05:19:04  *** Nat_aS has quit IRC
05:20:36  *** Nat_aS has joined #openttdcoop.devzone
05:20:57  *** Nat_aS has quit IRC
05:21:31  *** NataS has joined #openttdcoop.devzone
05:23:49  *** Dr_Tan has joined #openttdcoop.devzone
05:23:49  *** NataS has quit IRC
05:23:59  *** Dr_Tan is now known as Nat_aS
05:34:26  *** MinchinWeb_ has quit IRC
06:14:25  *** Nat_aS has quit IRC
06:16:02  *** Nat_aS has joined #openttdcoop.devzone
07:18:20  *** andythenorth has joined #openttdcoop.devzone
08:08:40  <Brot6> FIRS Industry Replacement Set - Revision 3152:07a9cca75ea3: Codechange: reduce madness in cargo impo... XandythenorthX @
08:10:45  <Brot6> firs: update from r3151 to r3152 done -
08:36:16  <Brot6> FIRS Industry Replacement Set - Revision 3153:3e916951ad2d: Codechange: rename a var for less 'is it... XandythenorthX @
08:37:34  <Brot6> firs: update from r3152 to r3153 done -
08:38:31  <Brot6> FIRS Industry Replacement Set - Revision 3154:63e83d2b67b3: Codechange: remove a redundant declarati... XandythenorthX @
08:39:39  <Brot6> firs: update from r3153 to r3154 done -
08:44:09  <Brot6> FIRS Industry Replacement Set - Revision 3155:59aaf6bae96b: Codechange: make rendering of industries... XandythenorthX @
08:45:10  <Brot6> firs: update from r3154 to r3155 done -
09:15:51  *** Alberth has joined #openttdcoop.devzone
09:33:38  *** Zuu has joined #openttdcoop.devzone
09:36:50  <Brot6> FIRS Industry Replacement Set - Revision 3156:e4ff9fde0e8d: Codechange: rename 'sprites' to 'src' th... XandythenorthX @
09:38:19  <Brot6> firs: update from r3155 to r3156 done -
09:59:00  *** LordAro has joined #openttdcoop.devzone
09:59:05  *** ODM has joined #openttdcoop.devzone
10:10:02  <Brot6> FIRS Industry Replacement Set - Revision 3157:fa8f93d37940: Codechange: rename script that builds py... XandythenorthX @
10:11:28  <Brot6> firs: update from r3156 to r3157 done -
10:41:54  <Brot6> FIRS Industry Replacement Set - Revision 3158:1d2f5520adee: Codechange: restructure repo a bit - mov... XandythenorthX @
10:42:44  <planetmaker> forgotten hg add, andythenorth ?
10:42:55  <andythenorth> probably :P
10:43:23  <Brot6> firs: update from r3157 to r3158 done -
10:44:01  <planetmaker> hm, or not ;-)
10:44:47  <planetmaker> but then I don't understand the commit message really
10:44:57  <planetmaker> as you seem to move stuff into the src folder ;-)
10:45:41  <andythenorth> I have moved some generated code out of the source folder
10:45:52  <andythenorth> it's not really source, and it can cause confusion when grepping :)
10:46:25  <planetmaker> but no file is moved in that commit...
10:47:09  <Brot6> FIRS Industry Replacement Set - Revision 3159:90aecc8dbc7f: Codechange: move to a bett... XandythenorthX @
10:47:23  <andythenorth> which rev? ;o
10:47:28  <planetmaker> 3158
10:48:21  <Brot6> firs: update from r3158 to r3159 done -
10:48:51  <andythenorth> ah
10:49:04  <andythenorth> the generated_pnml is ignored by design
10:49:46  <andythenorth> so it won't show up as moved
10:50:02  <Ammler> shouldn't the build script be outside src?
10:50:15  <Ammler> e.g. in scripts
10:50:24  <andythenorth> maybe
10:50:40  <andythenorth> opinions?
10:51:17  <andythenorth> it's closer to being part of makefile than part of source code
10:51:18  <Ammler> well, why do you have it there?
10:51:36  <andythenorth> because nobody proposed better until now :P
10:52:06  <Ammler> it's not important but because you move things around :-P
10:52:49  <andythenorth> why is firs.pnml not in the scripts dir?
10:53:08  <planetmaker> it's not a build script but part of source code
10:53:54  <planetmaker> scripts dir should only contain build scripts (makefile parts and scripts called by it)
10:54:01  <planetmaker> not any source being compiled
10:54:11  <planetmaker> thus in principle project-independent parts
10:54:37  <andythenorth> so what is correct location for this build script ( ?
10:54:39  <planetmaker> today I wouldn't call it "scripts" anymore but rather "build" or so
10:55:05  <planetmaker> I guess the scripts dir
10:55:23  <planetmaker> but not sure :-)
10:55:25  <andythenorth> me neither
10:55:32  <andythenorth> it's not project independent
10:55:46  <andythenorth> but otoh it could be reused
10:55:48  <andythenorth> :)
10:55:56  <Ammler> if scripts would be project independet, it would be a subrepo ;-)
10:56:13  <planetmaker> looking at how it's supposed to work, I'd put it into scripts
10:56:20  <Alberth> bin
10:56:33  <planetmaker> bin... hm
10:56:39  <Alberth> and the other things in .
10:56:52  <planetmaker> which "other things", Alberth ?
10:56:53  <Alberth> after stripping some of the global bloat
10:56:58  <Alberth> Makefile
10:57:08  <planetmaker> Alberth, all the dozen parts I split it into?
10:57:12  <planetmaker> rather not
10:57:37  <planetmaker> maybe though the splitting is not too good thing to do, though
10:57:42  <Ammler> I always thought, bin stands for binaries, what does it mean really?
10:57:43  <Alberth> a dozen makefiles is not easy to navigate in, imho
10:57:56  <Alberth> Ammler: anything you execute
10:57:58  <planetmaker> executables
10:58:11  <Alberth> so also python scripts
10:58:24  <Ammler> well
10:58:32  <Ammler> python scripts without .py :-P
10:58:42  <andythenorth> hmm is a lie.  It doesn't build, it just runs the python templating
10:58:50  <andythenorth> the makefile does the build
10:58:52  *** frosch123 has joined #openttdcoop.devzone
10:59:04  <Alberth> Ammler: if in bin, that would be a good idea
10:59:14  <Alberth> .py is for files that you run indirectly
10:59:19  <Alberth> quak
10:59:25  <Ammler> python
10:59:42  <frosch123> moin :)
10:59:44  <Alberth> Ammler: indeed
10:59:51  <Ammler> or bin/pyscript
11:01:52  <planetmaker> quak :-)
11:02:59  <andythenorth> so src/ -> scripts/??.py
11:03:02  <andythenorth> what shall I call it?
11:03:17  <Rubidium> snakes
11:03:37  <andythenorth> scripts/ :)
11:03:41  <planetmaker> :D
11:03:55  <planetmaker> scripts/
11:04:01  <andythenorth> yeah fine
11:05:56  <andythenorth> done
11:06:16  <Brot6> FIRS Industry Replacement Set - Revision 3160:c3b224bb33c3: Codechange: rename the scr... XandythenorthX @
11:06:22  <andythenorth> happier with that :)
11:07:40  <Ammler> shouldn't you also variable python in makefile?
11:07:49  <andythenorth> ?
11:08:02  <Brot6> firs: update from r3159 to r3160 done -
11:08:24  <planetmaker> maybe one should be able to define the python binary via variable, yes
11:08:43  <planetmaker> andythenorth, like you define the nml binary via variable etc
11:09:09  <andythenorth> ah
11:09:16  <andythenorth> there are some other vars that might be useful
11:09:32  <andythenorth> FISH and BANDIT python scripts pick up some repo vars via makefile iirc
11:09:45  <andythenorth> and some of the paths are hard-coded into python right now
11:09:48  <andythenorth> bad
11:48:18  <Brot6> zBase - Revision 297:8fc57f008040: Fix: Grass type of arctic maglev tiles. XzephyrisX @
12:07:33  <andythenorth> planetmaker: should the makefile rm the generated_pnml dir on 'make clean'?
12:08:22  <planetmaker> is the generated_pnml in the repo? Then no. If yes, then, yes
12:09:17  <Brot6> FIRS Industry Replacement Set - Revision 3161:4c164f2a1fde: Codechange: restructure how cargos are r... XandythenorthX @
12:10:23  <andythenorth> latter
12:10:25  <Brot6> firs: update from r3160 to r3161 done -
12:12:17  <andythenorth> done
12:12:45  <Brot6> FIRS Industry Replacement Set - Revision 3162:f905f97f74a7: Codechange: 'make clean' will now remove... XandythenorthX @
12:14:24  <Brot6> firs: update from r3161 to r3162 done -
12:15:52  <andythenorth> I'm not massively convinced that the code needs to be nested up in an nml dir
12:15:56  <andythenorth> (firs)
12:28:00  * planetmaker neither
12:28:08  <planetmaker> it originates from the time you wanted to keep nfo ;-)
12:29:06  <andythenorth> I recall :P
12:29:13  * andythenorth was sulking at that point
12:29:20  <andythenorth> oops
12:30:47  <andythenorth> learning hex was very good for my understanding of programming
12:30:53  <andythenorth> but in retrospect, I don't miss it :P
12:33:43  <Yexo> I can't do without it
12:34:27  <andythenorth> he
12:36:20  <andythenorth> so move everything in 'src/nml/' to 'src/' ?
12:39:30  <Yexo> firs.grf.cache and firs.grf.cacheindex should be added .hgignore
12:41:12  <Yexo> andythenorth: mind if I commit?
12:42:09  <andythenorth> go ahead
12:42:47  <Brot6> FIRS Industry Replacement Set - Revision 3163:a4c9f9fb078e: Change: remove .pnfo files from .hgignor... XyexoX @
12:44:31  <Brot6> firs: update from r3162 to r3163 done -
12:52:51  <andythenorth> all the stuff like grf header, checks, parameters etc - what would that be called?
12:53:04  <andythenorth> common?
12:53:06  <andythenorth> singletons?
12:53:08  <andythenorth> grf header?
12:53:10  <andythenorth> master?
12:54:18  <planetmaker> I used to call it grf header and maybe grf checks separately. Depends
12:56:02  <andythenorth> I need to name a method call
12:56:22  <andythenorth> backache, children and codeine are slowing me down :)
12:56:32  <andythenorth> render_header_items() ?
12:58:25  <andythenorth> render_bikeshed() :P
12:58:34  <andythenorth> I need a teddy bear to code with
13:39:44  <Brot6> FIRS Industry Replacement Set - Revision 3164:462b3e863d3f: Codechange: extend python templating to ... XandythenorthX @
13:41:45  <Brot6> firs: update from r3163 to r3164 done -
13:45:18  <Brot6> FIRS Industry Replacement Set - Revision 3165:4787568ffad1: Codechange: 'src/' is a better place tha... XandythenorthX @
13:46:16  <andythenorth> hmm
13:46:26  <andythenorth> station rating stuff is in the cargo graphics file :)
13:46:29  <andythenorth> nvm
13:46:29  <Brot6> firs: update from r3164 to r3165 done -
13:47:31  <andythenorth> planetmaker: Yexo so each economy has a number, corresponding to param setting.  Currently the number is derived only from position in a python list
13:47:40  <andythenorth> which is simple, but fragile if someone moves the list items around
13:47:52  <andythenorth> happy with that, or should I make it more explicit?
13:48:35  <Yexo> no matter how explicit you make it, sometime somebody will ignore all that and break compatibility
13:48:41  <Yexo> so go with whatever you like
13:48:45  <andythenorth> list
13:48:54  <andythenorth> less scaffolding :P
13:48:57  <Yexo> if you keep a python list, make sure to add some clear documentation around it that it should not be shuffled around
13:49:30  <andythenorth> done
13:50:30  <andythenorth> ta
13:51:18  <Brot6> FIRS Industry Replacement Set - Revision 3166:08b24c9b4c20: Codechange: add a note that changing ord... XandythenorthX @
13:52:17  <Brot6> firs: update from r3165 to r3166 done -
13:59:32  <andythenorth> so it looks like nml can assign identifiers to params in action 14?
13:59:40  * andythenorth didn't read docs, just guessing
14:00:08  <Yexo> yes, it can
14:00:21  <andythenorth> no more param[0] for me then :)
14:01:06  <Brot6> FIRS Industry Replacement Set - Revision 3167:b5852991b022: Codechange: python template the action 1... XandythenorthX @
14:02:11  <Ammler> planetmaker: the issue of yesterday is fixed
14:02:13  <Brot6> firs: update from r3166 to r3167 done -
14:02:24  <Ammler> this is acutally a reason to keep rhodecode :-P
14:03:50  <Brot6> FIRS Industry Replacement Set - Revision 3168:2599298a1568: Codechange: refer to 'economy' not 'para... XandythenorthX @
14:05:56  <Brot6> firs: update from r3167 to r3168 done -
14:06:17  <planetmaker> great, Ammler :-) (saw that also in #rhodecode, yes)
14:20:12  <Brot6> FIRS Industry Replacement Set - Revision 3169:dff24d0bde2c: Fix: get_conditional_expressions_for_ena... XandythenorthX @
14:20:12  <Brot6> FIRS Industry Replacement Set - Bug #4509 (New): DevZone compile failed XcompilerX @
14:21:03  <andythenorth> oops
14:22:31  <Brot6> FIRS Industry Replacement Set - Revision 3170:cd959323f07e: Fix: wrong variable name in get_conditio... XandythenorthX @
14:24:28  <Brot6> firs: update from r3168 to r3170 done -
14:34:23  <Brot6> FIRS Industry Replacement Set - Bug #4509 (Closed): DevZone compile failed XcompilerX @
14:34:23  <Brot6> FIRS Industry Replacement Set - Bug #4509 (Closed): DevZone compile failed XandythenorthX @
14:36:35  <Brot6> FIRS Industry Replacement Set - Revision 3171:6940e3713943: Codechange: comment a function XandythenorthX @
14:37:55  <Brot6> firs: update from r3170 to r3171 done -
15:06:27  *** MinchinWeb_ has joined #openttdcoop.devzone
15:07:05  *** MinchinWeb_ has quit IRC
15:48:05  <Brot6> FIRS Industry Replacement Set - Revision 3172:8945a43d992e: Codechange: support disabling cargos on ... XandythenorthX @
15:49:54  <Brot6> firs: update from r3171 to r3172 done -
16:29:29  *** Zuu has quit IRC
17:19:53  <Brot6> firs: update from r3144 to r3172 done -
17:22:49  <Brot6> FIRS Industry Replacement Set - Revision 3173:e2e2c848e4cf: Codechange: auto-docs proof of concept (... XandythenorthX @
17:24:11  <Brot6> firs: update from r3172 to r3173 done -
18:22:29  *** andythenorth has quit IRC
19:03:10  *** andythenorth has joined #openttdcoop.devzone
19:12:07  *** Alberth has left #openttdcoop.devzone
19:31:44  <Brot6> FIRS Industry Replacement Set - Revision 3174:3f95395a1f01: Change: test implementation of a 'basic'... XandythenorthX @
19:33:46  <Brot6> firs: update from r3173 to r3174 done -
19:34:20  <Brot6> FIRS Industry Replacement Set - Revision 3175:8dca3b5b1837: Fix: missing space in docs XandythenorthX @
19:36:08  <Brot6> firs: update from r3174 to r3175 done -
19:44:24  <andythenorth> Yexo: wrt
19:44:30  <andythenorth> I can now set defaults for any property
19:44:50  <andythenorth> if default is 'None' and no other value give, property is omitted
19:45:05  <andythenorth> if default is not 'None', then prop will be set...
19:45:13  <andythenorth> so that issue can be fixed
19:45:28  <andythenorth> any other props I should set defaults for (currently they're all 'None')
19:45:29  <andythenorth> ?
19:45:33  <Yexo> default for spec_flags should be 0
19:47:21  <Yexo> wouldn't it be a better idea to just force all properties to have a value?
19:47:29  <Yexo> ie "if None: error"
19:47:53  <andythenorth> could do
19:48:09  <andythenorth> if that's valid, then it's certainly possible
19:49:55  <Yexo> spec_flags has a sane default (0), but most other values don't
19:49:59  <Yexo> or at least not that I can see
19:50:59  <andythenorth> I know that nmlc doesn't like some being empty :D
19:51:00  <andythenorth> I tried that
19:51:28  <Yexo> that'd leave it to nml to fill in a default (or leave it out)
19:53:45  <Brot6> FIRS Industry Replacement Set - Revision 3176:018327da08b8: Fix: set default for spec_flags to 0 (cl... XandythenorthX @
19:53:45  <Brot6> FIRS Industry Replacement Set - Bug #4415 (Closed): Unwanted Subsidence XandythenorthX @
19:55:38  <Brot6> firs: update from r3175 to r3176 done -
20:06:59  *** Zuu has joined #openttdcoop.devzone
21:08:24  *** andythenorth is now known as Guest4503
21:08:26  *** andythenorth has joined #openttdcoop.devzone
21:15:15  *** Guest4503 has quit IRC
21:16:22  *** ODM has quit IRC
21:46:56  *** andythenorth has quit IRC
22:20:38  *** Zuu has quit IRC
23:08:02  *** LordAro has quit IRC

Powered by YARRSTE version: svn-trunk