Log for #openttdcoop.devzone on 26th June 2013:
Times are UTC Toggle Colours
01:27:23  *** supermop has joined #openttdcoop.devzone
04:54:11  *** supermop has quit IRC
04:56:28  <Brot6> AI-Lib List - Bug #5942 (Closed): GetItemArray return their values instead of items XfaniozX @
04:56:28  <Brot6> AI-Lib List - Revision 34:8afd286aaa59: fix : #5942 XfaniozX @
04:56:28  <Brot6> AI-Lib List - Bug #5942 (Closed): GetItemArray return their values instead of items XfaniozX @
05:00:52  <Brot6> ailib-list: update from v2 to v3 done -
05:00:57  <Brot6> AI-Lib List - Revision 35:4772508c0c55: Added tag v3 for changeset 8afd286aaa59 XfaniozX @
05:01:13  <George> VL60K works in r951 and does not work in r960, but I do not understand what is wrong in the change in r960
05:05:43  <George> tem2* are broken in r982. the same problem - can't understand what is wrong in the change
06:19:34  *** Supercheese has joined #openttdcoop.devzone
06:53:08  *** andythenorth has joined #openttdcoop.devzone
07:18:55  <Brot6> FIRS Industry Replacement Set - Revision 3696:add02c771b91: Fix: set correct labels and classes for ... XandythenorthX @
07:18:55  <Brot6> FIRS Industry Replacement Set - Revision 3697:f6dda083352e: Change: add Trading Post for MISTAH_KURT... XandythenorthX @
07:20:22  <planetmaker> George, could be thus something done in any of r952 to r960
07:20:45  <planetmaker> George, can you find out which is the first version which breaks it?
07:21:07  <planetmaker> for each of the vehicles with issues?
07:21:57  <Brot6> firs: update from r3695 to r3696 done (30 warnings) -
07:22:38  <planetmaker> George, can you also remind me of what 'broken' means? Doesn't the engine appear? Or was it something else?
07:23:39  <andythenorth> props are 0
07:25:06  <Brot6> firs: update from r3696 to r3697 done (30 warnings) -
07:25:25  <planetmaker> andythenorth, know or suspect? It's my suspecion, too, but...
07:25:34  <andythenorth> george told me yesterday
07:25:51  <andythenorth> I had this once I think
07:26:02  <andythenorth> might have been defining the vehicle twice or something silly
07:27:57  <planetmaker> yes. then things go wrong. Been there, too :-)
07:39:36  <planetmaker> George, anyway the purchase_speed callback for vl60k is... weired. It returns no values:
07:39:39  <planetmaker> George, switch (FEAT_TRAINS, SELF, vl60k_purchase_speed, 100) { return; } switch (FEAT_TRAINS, SELF, vl60k_speed, ((bitmask_consist_info & 1) == 1) ? 100 * (100 - speed_penalty_percent) / 100 : 100) { return; }
07:40:31  <planetmaker> and speed callback
07:48:05  *** Supercheese has quit IRC
07:48:10  <Brot6> FIRS Industry Replacement Set - Bug #6023 (New): Check that location restrictions accurate for Cotto... XandythenorthX @
07:49:16  <Brot6> FIRS Industry Replacement Set - Revision 3698:f2d130226a9a: Fix: Coffee Plantation had incorrect loc... XandythenorthX @
07:49:57  <Brot6> FIRS Industry Replacement Set - Revision 3699:e6d5e38c2380: Codechange: template a spriteset ID corr... XandythenorthX @
07:49:57  <Brot6> FIRS Industry Replacement Set - Revision 3700:e16b69db14eb: Change: add Rubber Plantation industry f... XandythenorthX @
07:51:35  <Brot6> firs: update from r3697 to r3698 done (30 warnings) -
07:53:21  <Brot6> FIRS Industry Replacement Set - Revision 3701:bd46bf1dc312: Fix: Rubber Plantation should produce Ru... XandythenorthX @
07:54:56  <Brot6> firs: update from r3698 to r3700 done (30 warnings) -
08:52:27  *** andythenorth has quit IRC
09:27:55  *** andythenorth has joined #openttdcoop.devzone
11:07:14  <Brot6> Industrial Stations Renewal - Revision 206:6e4d77afa3a2: Codechange: Improve comments and code layou... Xmart3pX @
12:07:32  *** andythenorth has quit IRC
12:11:44  *** andythenorth has joined #openttdcoop.devzone
12:12:53  *** andythenorth has quit IRC
12:15:11  *** andythenorth has joined #openttdcoop.devzone
12:20:53  *** andythenorth has quit IRC
12:34:12  *** andythenorth has joined #openttdcoop.devzone
15:52:29  *** ODM has joined #openttdcoop.devzone
16:40:17  <Brot6> Industrial Stations Renewal - Revision 207:3e91faea390a: Codechange: Improve code layout Xmart3pX @
17:18:26  *** frosch123 has joined #openttdcoop.devzone
17:33:46  <Brot6> cets: update from r756 to r760 done (10 warnings) -
17:35:45  <Brot6> xussrset: update from r998 to r999 done (4 warnings) -
17:36:37  <Brot6> ailib-list: update from r33 to r35 done -
17:40:45  <Brot6> firs: update from r3689 to r3701 done (30 warnings) -
17:41:42  <Brot6> isr: update from r205 to r207 done -
18:01:27  *** Jam35 has joined #openttdcoop.devzone
18:10:59  <Brot6> Industrial Stations Renewal - Revision 208:0998116e7d14: Codechange: Move parameter code to separate... Xmart3pX @
18:39:25  *** andythenorth has quit IRC
19:03:08  *** andythenorth has joined #openttdcoop.devzone
19:07:28  <George> planetmaker: shouldn't cb return last computed result (100 here) in case { return; } ?
19:07:58  <planetmaker> should it? I don't know
19:08:17  <andythenorth> source code knows :)
19:08:22  <planetmaker> I would not assume that unless it's spec'ed somewhere
19:08:23  <andythenorth> but I am not wanting to dig
19:08:40  <planetmaker> ^ or that
19:08:57  <planetmaker> I simply think if the CB returns nothing the default property value is used.
19:08:58  <George> there are lots of engines that use the same template, but only 2 engines have the issue
19:09:12  <planetmaker> I don't say that it the issue you try to track down
19:09:27  <planetmaker> But it doesn't look clean to me
19:10:06  <planetmaker> George, what needs doing is finding the exact revision which breaks it
19:10:18  <planetmaker> thus you need to try each revision from known to unknown
19:10:26  <George> I noted it already
19:10:35  <planetmaker> from just looking at the HUGE amount of code, ... I don't see anything
19:10:50  <planetmaker> not even with the 9 revisions you noted between working and non-working
19:10:52  <George> 960 and 982
19:11:04  <planetmaker> 960 works. 982 not?
19:11:09  <planetmaker> what was with 951?
19:11:16  <George> 960 breaks vl60k
19:11:25  <planetmaker> and what does "not work" constitute? Not appear at all? Or just screwed stats
19:11:27  <George> 982 breaks tem2*
19:11:43  <George> wrong stats
19:11:43  <planetmaker> you sure it's rev 960?
19:11:53  <planetmaker> not 959 or earlier?
19:12:08  <George> only 960 changes VL60k
19:12:20  <planetmaker> that's not the question
19:12:29  <planetmaker> I really mean: take the grf. test whether it works
19:12:36  <planetmaker> it can be seemingly totally unrelated
19:13:24  <George> r951 works
19:13:37  <planetmaker> good. And what about 952, 953, ... 959?
19:13:40  <George> I'll try to rebuild r959
19:13:48  <planetmaker> yeah, try 959 first
19:14:09  <planetmaker> I find it hard to navigate... all commit messages are meaningless to me, sadly
19:14:54  <planetmaker> (it's no criticism, it's just... without knowledge of what is said to be done, it's worse than knowing what was supposedly done)
19:15:23  <planetmaker> I can't even guess by the logs of what was changed where
19:16:02  <George> You at least can see the files changed and the diff
19:17:00  <planetmaker> yes
19:22:21  <planetmaker> I looked at all of them without seeing anything obvious
19:23:51  <George> r959 works fine
19:24:13  <George> so r960 breaks vl60k
19:31:23  <andythenorth> so what's in the diff? :)
19:32:41  <George>
19:33:04  <George> in r981 tem2* works, in r982 - broken
19:33:25  <George>
19:33:59  <George> I can't understand what is wrong in the diff
19:34:35  <George> That makes me feel that it should be a very stupid bg :(
19:34:44  <George> bug
19:36:34  <andythenorth> I am stuck too
19:36:52  <andythenorth> could be an nmlc bug....but hard to diagnose
19:39:23  <planetmaker> urgs. it destroys my UI. It replaces the cursor for rail tools :S
19:39:57  <andythenorth> :o
19:40:21  <planetmaker> well. It introduces cursors for tracks and depots. Which match TTD. But not OpenGFX
19:41:13  <George> planetmaker: who made cursors for OpenGFX?
19:41:21  <planetmaker> Zeph, probably
19:41:51  <George> May be he can help to make such cursors for xUSSR set?
19:42:06  <planetmaker> just take them and use them...
19:42:28  <George> OpenGFX is no CC-NC-SA
19:42:30  <planetmaker> well... that might be bad advice.
19:42:33  <planetmaker> yes
19:42:47  <planetmaker> didn't think of that when I said that :-)
19:43:02  <planetmaker> I would by default not replace GUI elements
19:43:10  <planetmaker> it breaks in multiplayer whatever you do, George
19:43:31  <planetmaker> I would only add a parameter which allows to replace them. Optionally
19:43:34  <George> And what to do with our 11 railways?
19:43:51  <planetmaker> look at how I treat it in swedishrails
19:44:11  <George> Ok, I'll have a look
19:44:24  <planetmaker> anyhow... where do I find the VT60k vehicle?
19:44:27  <planetmaker> how is it called?
19:44:50  <planetmaker> is 1990 early enough?
19:46:26  <George> it is called VL60K, available in 1962 - 1967
19:47:31  <planetmaker> I don't see it in 1965 in r959
19:49:04  <planetmaker> for testing, you created every time a completely new game, yes?
19:50:29  <George> yes
19:50:55  <George> I started in 1920 and chaged a year to 2000 with a cheat
19:50:58  <planetmaker> why don't I find it in 1965 then in arctic?
19:51:22  <George> You should choose the right depot
19:51:31  <planetmaker> omg... what type?
19:51:56  <planetmaker> holy shit, you should separate tracks and trains :S
19:52:07  <George> ?
19:52:14  <planetmaker> and learn about rail translation table usage for trains
19:52:31  <George> Electrified AC railroad
19:52:36  <planetmaker> what track type do I look at when trying to build that?
19:52:58  <planetmaker> yes, there it is indeed, thanks
19:53:20  <planetmaker> good lecture on railtype translation table is dutchtrains by foobar
19:53:43  <George> and what is wrong?
19:53:54  <planetmaker> I got way more than I bargained for :-)
19:54:09  <planetmaker> finding tracks replaced all by a vehicle set came as a (to me nasty) surprise
19:54:12  <George> there are non-electrified rails, electrified with AC and with DC
19:54:36  <planetmaker> it should imho be two separate newgrfs
19:54:46  <George> ??
19:54:46  <planetmaker> but, well, not this issue. Just my opinion
19:55:00  <planetmaker> tracks = tracks. trains = trains. Separate stuff ---> separate newgrfs
19:55:26  <planetmaker> that's how I'd structure it :-)
19:55:27  <George> and how would trains would be used on undefined rail types?
19:55:37  <planetmaker> railtype translation table :-)
19:56:00  <George> The train set would disable itself if apropriate tracks are not defined
19:56:38  <planetmaker> basically the RTT allows to define a sequence of (fallback) track types for each track your engines want to use
19:56:50  <George> railtypetable
19:56:50  <George> {
19:56:50  <George>   // стандартные
19:56:50  <George>   RAIL, ELRL,
19:56:50  <George>   RLA1, RLA2, RLA3,
19:56:50  <George>   ERA1, ERA2, ERA3,
19:56:50  <George>   ERD1, ERD2, ERD3,
19:56:52  <George>   ER2S
19:56:52  <George> }
19:56:53  <planetmaker> and disable the engine, if none of the tracks is present
19:57:34  <planetmaker> well, NML allows to be more intelligent there
19:57:52  <George> because of that there is no use for separate grf in case they disable themself when the second GRF is not loaded
19:57:56  <planetmaker>
19:57:58  <George> imho useless
19:58:25  *** ODM has quit IRC
19:59:10  *** gelignite has joined #openttdcoop.devzone
19:59:53  <planetmaker> you would not disable the vehicles... you would simply have them run on the most appropriate track type available
20:00:25  <George> there is no apropriate track type available
20:00:40  <George> other sets do not provide AC/DC
20:00:55  <George> But we are going offtopic
20:00:57  <planetmaker> RAIL or ELRL is always appropriate as last resort
20:01:11  <planetmaker> and "other sets doe not provide AC/DC" is likely wrong
20:01:17  <George> what is with VL60K
20:07:05  <planetmaker> it nearly killed my editor...
20:08:31  <George> I use notepad ++
20:09:49  <planetmaker> loading 133k lines just takes time :D
20:11:22  <andythenorth> which editor? :o
20:11:28  <planetmaker> kate
20:11:30  <planetmaker> not kill
20:11:37  <planetmaker> it just took 2 seconds to load
20:11:46  <planetmaker> 133k lines of NFO
20:11:59  <planetmaker> the action0 in nfo looks identical in r959 and r960
20:12:12  <andythenorth> hmm kate has python autocomplete, interesting
20:14:55  *** Jam35 has quit IRC
20:27:31  <George> sorry, I have to go to sleep. Hope I wake up and a magical solution would be found on the IRC :)
20:28:14  <planetmaker> sleep well, George
20:28:43  <andythenorth> planetmaker: interested in helping me with FIRS then? o_O
20:37:12  <planetmaker> maybe I can shove you in the right direction, andythenorth
20:37:22  <planetmaker> doesn't simple conditionals work like described earlier?
20:37:47  <andythenorth> just need to know how to use a parameter
20:37:52  <andythenorth> conditionals will work
20:37:56  <andythenorth> I am certain
20:38:11  <planetmaker> honestly, though, andythenorth, for testing purposes I probably simply would comment out all industries I'm not interested in and... that's it. A matter of tmwftlb or so :-)
20:38:28  <andythenorth> it's a fair point
20:38:47  <planetmaker> it's two key strokes for me in my editors
20:38:53  <planetmaker> to comment out and to comment in
20:39:54  <andythenorth> ugh
20:39:59  <andythenorth> it's at least 6 for me :P
20:40:14  <planetmaker> hm... or so I thought. ctrl+d doesn't work for me in NML :S
20:40:53  <planetmaker> I need to improve the language support in that editor it seems :-)
20:41:00  <planetmaker> works with c/c++ and makefile
20:41:47  <planetmaker> how did you imagine the conditional compile to work?
20:42:57  <andythenorth> can makefile accept command line vars?
20:43:03  <planetmaker> yes
20:43:11  <planetmaker> make -DPARAM=XX
20:43:25  <planetmaker> it only needs handing over to the gcc call in the makefile
20:43:30  <andythenorth> so a named param, and an industry
20:43:37  <andythenorth> make singleindustry coal_mine
20:43:39  <andythenorth> or something
20:43:45  <andythenorth> with appropriate syntax ;)
20:49:42  <planetmaker> maybe...
20:49:45  <planetmaker> #if !defined(TEST_INDUSTRY) || (TEST_INDUSTRY == "ALUMINUM_PLANT")
20:49:46  <planetmaker> ...
20:49:48  <planetmaker> #endif
20:49:52  <planetmaker> in each industry file
20:50:51  <andythenorth> could work
20:51:42  <planetmaker> in scripts/Makefile_nml
20:52:06  <andythenorth> I'll try it
20:52:49  <andythenorth> hmm
20:52:53  * andythenorth has an idea
20:54:04  <planetmaker> :-)
20:54:34  <andythenorth> I already pass args to python, so I might play with that later
20:54:41  <andythenorth> but first I'm reminding myself how CPP works :P
20:55:38  <planetmaker> :-)
21:00:04  *** frosch123 has quit IRC
21:00:12  <andythenorth> I'm trying to print the value of the parameter somewhere
21:00:50  <andythenorth> ok that works
21:05:15  <andythenorth> ok so:
21:05:16  <andythenorth> <stdin>:37:54: error: invalid token at start of a preprocessor expression
21:05:17  <andythenorth>     #if !defined(TEST_INDUSTRY) || (TEST_INDUSTRY == "aluminium_plant")
21:05:28  <andythenorth> doesn't like the " char
21:06:41  <planetmaker> hm, might only work numeric
21:06:48  <planetmaker> do you know numeric IDs of the industries?
21:07:00  <planetmaker> Then replace "aluminum_plant" by X where X is the numeric ID of it
21:07:36  <andythenorth> I think it works without the " chars
21:07:39  <andythenorth> but not sure yet
21:07:57  <planetmaker> hm, yes, possibly
21:08:05  <planetmaker> yes, should.
21:15:22  *** gelignite has quit IRC
21:30:03  <andythenorth> yair
21:30:05  <andythenorth> that kind of works
21:30:14  <andythenorth> it fails for industries that reference others
21:32:00  <Brot6> FIRS Industry Replacement Set - Revision 3702:b05f0ef1d40e: Codechange: add a TEST_INDUSTRY paramete... XandythenorthX @
21:33:02  <andythenorth> I did it python-wise :)
21:33:08  <Brot6> FIRS Industry Replacement Set - Revision 3703:d25daa81fbbc: Codechange: add a note to remind self ab... XandythenorthX @
21:34:19  <Brot6> firs: update from r3700 to r3702 done (30 warnings) -
21:37:36  <Brot6> firs: update from r3702 to r3703 done (30 warnings) -
21:44:19  *** andythenorth has quit IRC

Powered by YARRSTE version: svn-trunk