Times are UTC Toggle Colours
00:08:11 *** Smedles_ has quit IRC 00:09:26 *** Smedles has joined #openttd 00:13:53 *** joey[m] has joined #openttd 00:19:13 *** grag[m] has joined #openttd 00:20:22 *** ookfof[m] has joined #openttd 00:42:10 *** natmac[m] has joined #openttd 00:50:34 *** HerzogDeXtEr has quit IRC 00:53:41 *** patricia[m] has joined #openttd 00:59:28 *** menelaos[m] has joined #openttd 01:00:43 *** Wormnest has quit IRC 01:08:11 *** natalie[m] has joined #openttd 01:11:35 *** dekeract[m] has joined #openttd 01:15:53 *** josef[m] has joined #openttd 01:16:21 *** spnda has quit IRC 01:24:24 *** Smedles has quit IRC 01:25:39 *** Smedles has joined #openttd 01:27:28 *** pina[m] has joined #openttd 01:28:36 *** yoltid[m] has joined #openttd 01:32:18 *** lapav[m] has joined #openttd 01:32:35 *** jact[m] has joined #openttd 01:42:42 *** fiddeldibu[m] has joined #openttd 01:44:01 *** dude[m]1 has joined #openttd 01:44:59 *** glothit7ok[m] has joined #openttd 01:52:45 *** khavik[m] has joined #openttd 01:58:53 *** fjodor[m] has joined #openttd 01:59:36 *** pothyurf[m] has joined #openttd 02:09:58 *** Wormnest has joined #openttd 02:26:31 <DorpsGek_III> [OpenTTD/OpenTTD] Quipyowert2 updated pull request #8017: Codechange: Limit field width to avoid sscanf crash https://git.io/JvRs5 02:28:11 <DorpsGek_III> [OpenTTD/OpenTTD] Quipyowert2 commented on pull request #8017: Codechange: Limit field width to avoid sscanf crash https://git.io/Jv0ek 02:45:49 *** gelignite__ has joined #openttd 02:53:06 *** gelignite_ has quit IRC 03:18:51 *** D-HUND has joined #openttd 03:22:11 *** debdog has quit IRC 03:25:28 *** glx has quit IRC 03:49:25 *** Wormnest has quit IRC 04:11:16 <DorpsGek_III> [OpenTTD/nml] Andrew350 commented on issue #79: No support for NRT tunnels https://git.io/JedbH 04:17:45 *** gelignite__ has quit IRC 04:29:01 *** Wormnest has joined #openttd 05:34:05 *** Wormnest has quit IRC 06:03:58 *** sla_ro|master has joined #openttd 07:32:08 *** Smedles_ has joined #openttd 07:32:08 *** Smedles has quit IRC 07:43:18 *** sla_ro|master has quit IRC 07:47:49 *** andythenorth has joined #openttd 07:54:02 <andythenorth> coffee I haven't even had 08:00:31 <DorpsGek_III> [OpenTTD/nml] andythenorth commented on issue #79: No support for NRT tunnels https://git.io/JedbH 08:15:59 *** Smedles_ has quit IRC 08:17:29 *** Progman has joined #openttd 08:17:48 *** Smedles has joined #openttd 08:32:58 *** andythenorth has quit IRC 08:37:59 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #8014: Fix f5381798: Docking station tile area was being misused https://git.io/Jv0Th 09:12:46 *** Smedles has quit IRC 09:13:13 *** andythenorth has joined #openttd 09:14:01 *** Smedles has joined #openttd 09:18:48 *** nielsm has joined #openttd 09:18:57 *** Etua has joined #openttd 09:22:06 *** gelignite has joined #openttd 09:26:40 *** arikover has joined #openttd 09:33:50 *** Progman has quit IRC 09:45:43 *** HerzogDeXtEr has joined #openttd 09:47:24 *** Etua has quit IRC 09:55:32 *** Etua has joined #openttd 09:56:28 <andythenorth> moin 09:57:09 *** Etua has quit IRC 10:09:40 *** Samu has joined #openttd 10:12:45 <Samu> hi 10:17:10 *** Wolf01 has joined #openttd 10:31:30 *** andythenorth is now known as Guest17097 10:33:06 *** andythenorth has joined #openttd 10:34:50 *** gelignite has quit IRC 10:37:36 *** Guest17097 has quit IRC 11:02:32 *** Etua has joined #openttd 11:44:40 *** gelignite has joined #openttd 12:07:46 *** andythenorth has quit IRC 12:25:49 <DorpsGek_III> [OpenTTD/OpenTTD] Berbe commented on issue #7957: Add a flag to read banned users from a defined file instead of from openttd.cfg https://git.io/JvqkN 13:05:13 *** Flygon_ has joined #openttd 13:07:13 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #8017: Codechange: Limit field width to avoid sscanf crash https://git.io/Jv0Yr 13:12:01 *** Flygon has quit IRC 13:20:20 *** Flygon_ has quit IRC 13:44:02 *** glx has joined #openttd 13:44:02 *** ChanServ sets mode: +v glx 14:22:19 *** Etua has quit IRC 14:23:26 *** Etua has joined #openttd 14:30:44 *** Etua has quit IRC 14:32:47 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #8010: Fix #7998: Crash when scripts tried to access companies with invalid IDs. https://git.io/Jv4y9 14:32:48 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro closed issue #7998: Assertion failed at line 111 of src\core\pool_type.hpp https://git.io/JvWFY 14:36:33 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro requested changes for pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv031 14:46:51 *** frosch123 has joined #openttd 14:48:40 *** Etua has joined #openttd 14:49:16 <LordAro> quak 14:52:02 <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 merged pull request #8014: Fix f5381798: Docking station tile area was being misused https://git.io/JvBEk 14:52:18 <frosch123> i made the commit message more useful 14:52:32 <LordAro> :+1: 14:53:29 <frosch123> also, hoi :) 14:57:40 *** andythenorth has joined #openttd 15:12:29 *** Wormnest has joined #openttd 15:14:23 *** spnda has joined #openttd 15:15:44 *** TrueBrain is now known as TrueBrain_ii 15:32:47 <andythenorth> yo 15:33:27 *** Smedles has quit IRC 15:34:43 *** Smedles has joined #openttd 15:38:33 *** TrueBrain has joined #openttd 15:39:11 <TrueBrain> yo andy :) 15:39:50 *** TrueBrain has quit IRC 15:40:03 *** TrueBrain has joined #openttd 15:42:38 <TrueBrain> hmm .. Matrix is funny if used properly :) 15:43:52 *** TrueBrain has quit IRC 15:44:01 *** TrueBrain has joined #openttd 15:45:05 <TrueBrain> and now with working mask, w00p :) 15:49:21 <TrueBrain> Even via mobile, w00p 16:09:19 *** WormnestAndroid has quit IRC 16:11:11 *** WormnestAndroid has joined #openttd 16:34:13 *** Etua has quit IRC 16:34:24 *** Wormnest has quit IRC 16:35:34 <andythenorth> so who maintains opengfx? o_O 16:35:37 <andythenorth> pls say it's not me 16:35:44 *** Etua has joined #openttd 16:37:00 <TrueBrain> You! 16:37:08 <TrueBrain> Sorry, I just had to :) 16:39:23 *** Etua is now known as Guest17121 16:39:27 *** Etua has joined #openttd 16:46:39 *** Guest17121 has quit IRC 16:55:59 <andythenorth> seems to be me 16:56:04 <andythenorth> I don't even have it checked out 16:56:26 <andythenorth> I don't know how it works 16:56:34 <andythenorth> or how to release it 16:56:37 <andythenorth> or even build it 16:58:21 <andythenorth> nor do I use it 16:58:31 <andythenorth> classic open source eh 17:00:18 <LordAro> i'll bet you haven't even read the readme 17:03:22 <andythenorth> nope 17:04:09 <frosch123> it lists andy and V as contributors 17:04:23 <frosch123> they are both popular users of it :) 17:04:47 *** tokai has joined #openttd 17:04:47 *** ChanServ sets mode: +v tokai 17:05:58 <andythenorth> I redrew the factory sprites once 17:06:18 <andythenorth> I just want the guilt of this off my plate https://wiki.openttd.org/NewGRF_Specification_Status#OpenTTD_1.10 17:07:31 <andythenorth> wow I have a checkout of ogfx from 2012 17:07:35 <andythenorth> has it changed since then? 17:07:43 <frosch123> can we abuse that to make you cut the tram tracks from the tram depot sprite? 17:07:51 <frosch123> andythenorth: hg? 17:08:09 <andythenorth> yeah, I getting the git version now 17:08:23 <andythenorth> I can't do anything useful today, going afk shortly 17:09:58 <andythenorth> so first thing seems to be, fix opengfx 17:09:59 <andythenorth> https://pastebin.com/raw/XsA0T0QW 17:10:46 <andythenorth> does anything build it currently? 17:11:12 <andythenorth> coop jenkins? https://jenkins.openttdcoop.org/job/opengfx/ 17:11:36 <frosch123> that probably still builds the hg version 17:11:43 *** tokai|noir has quit IRC 17:12:29 <frosch123> anyway, its perfectly normal that coop grfs do not build 17:12:42 *** jinks has joined #openttd 17:12:43 <frosch123> though usually the makefile is broken 17:14:49 <andythenorth> yes 17:14:52 <andythenorth> first thing is to fix it 17:15:10 <andythenorth> if we don't, we get loads of reports about 1.10 missing sprites 17:15:20 <andythenorth> much as I'd rather not bother :P 17:15:33 <andythenorth> so it has version number deps on hg 17:15:37 <andythenorth> and it depends on gimp 17:15:50 <andythenorth> I'm not building gimp locally for this 17:15:54 <LordAro> that's an interesting choice of dependency 17:16:12 <andythenorth> it's an efficiency measure 17:17:50 <frosch123> yes, it composes sprites during compilation, so it needs gimp 17:18:18 <LordAro> ah, i see 17:18:25 <LordAro> i guess that makes sense 17:19:56 <andythenorth> it did at the time 17:20:21 <LordAro> https://github.com/OpenTTD/OpenGFX/pull/8 luckily, this already exists 17:44:07 <glx> btw adding the missing sprites to the source should be easy, even if it doesn't compile 17:46:09 <andythenorth> pull 8 looks very helpful 17:47:39 <TrueBrain> anything we can help with andythenorth? 17:48:15 <andythenorth> I am going afk in 10 minutes 17:48:33 <andythenorth> but we would benefit from having an opengfx that builds 17:48:44 <andythenorth> from the git checkout, not the old devzone hg 17:49:27 <TrueBrain> that ... sounds sane :P 17:49:53 <andythenorth> ideally we'd be building it on GH actions too 17:50:07 <TrueBrain> go big or go home, right? :D 17:50:12 <andythenorth> it doesn't change often, but it's a core dependency for some plaeyrs 17:50:14 <andythenorth> players * 17:50:15 <glx> I hope it's still working with latest nml 17:51:26 <TrueBrain> hmm, and it seems I have to purge a database completely to get Matrix to do something I want it to do ... 17:51:29 <TrueBrain> BUT I DONT WANT TO :( 17:53:17 <TrueBrain> owh, screw it ... bbiab 17:54:08 *** TrueBrain has quit IRC 17:56:32 *** truebrain has joined #openttd 17:56:56 <truebrain> see, now this is better :) 17:57:03 *** truebrain is now known as TrueBrain 18:01:12 <andythenorth> glx: we should release nml 0.5 and find out :D :P 18:02:04 <TrueBrain> so much Makefile ... 18:04:21 <glx> andythenorth: I think it should be ok, basically it's just replacing sprites 18:04:37 <andythenorth> live dangerously :) 18:04:50 <andythenorth> I am sure we will now never change newgrf ever again, also :) 18:04:52 <glx> and I don't think many stuff changed in nml in this area (except the number of sprites) 18:04:58 <TrueBrain> andythenorth: I found the maintainer .. it is pm :) It says so in the README, so it must be true 18:05:18 <andythenorth> who maintains the list of maintainers? :P 18:05:27 <andythenorth> pm probably would do it, time permitting 18:05:33 <andythenorth> but eh :) 18:06:01 <TrueBrain> lol @ SUSE spec file in the repo :) 18:06:05 <TrueBrain> a bit of an odd duck 18:06:11 <TrueBrain> also out-of-date 18:07:07 <TrueBrain> https://github.com/OpenTTD/OpenGFX/tree/master/extra <- where can I find the live HTMLs of this? :D 18:08:33 *** Etua has quit IRC 18:10:23 *** andythenorth has quit IRC 18:12:13 <glx> I think it was http://mz.openttdcoop.org/opengfx/authors/script.php?feature=objectives but it's dead 18:12:25 <TrueBrain> boooo 18:13:18 <TrueBrain> so several PRs, all with partial work 18:13:25 <TrueBrain> well, this does need a bit of love indeed :) 18:13:56 <DorpsGek_III> [OpenTTD/OpenTTD] telk5093 commented on pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv0CL 18:16:33 <glx> nice the config is in the repo (with credentials it seems) 18:17:26 <TrueBrain> what config? 18:17:38 <glx> db 18:18:04 <glx> in config.inc.php 18:18:06 <TrueBrain> ah, yeah ... 18:19:54 *** Etua has joined #openttd 18:23:18 <TrueBrain> glx: https://github.com/OpenTTD/OpenGFX/pull/10 would you mind? :D 18:23:58 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #10: Add: [DorpsGek] announce issues, pull-requests, and tags to IRC https://git.io/Jv0C0 18:24:04 <TrueBrain> ty kind 18:24:04 <glx> and it works :) 18:24:07 <LordAro> \o/ 18:24:21 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #11: Fix: [Makefile] when testing '-q' for unix2dos, ignore the stdout and stderr https://git.io/Jv0Ca 18:24:28 <TrueBrain> ofc it works 18:25:02 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #8: Fixes for building from git https://git.io/Jv0CV 18:25:08 <DorpsGek_III> [OpenTTD/OpenGFX] glx22 approved pull request #11: Fix: [Makefile] when testing '-q' for unix2dos, ignore the stdout and stderr https://git.io/Jv0Cw 18:25:09 <LordAro> everything TrueBrain makes is perfect! 18:25:18 <glx> haha 18:25:20 * LordAro doesn't have write access to ogfx 18:25:25 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #11: Fix: [Makefile] when testing '-q' for unix2dos, ignore the stdout and stderr https://git.io/Jv0Ca 18:25:33 <TrueBrain> poor LordAro 18:25:40 <TrueBrain> ask frosch123 :) 18:25:40 <glx> well you could enable 2FA 18:26:58 <TrueBrain> are those 3 branches in OpenGFX still relevant? 18:28:43 <DorpsGek_III> [OpenTTD/OpenTTD] kiwitreekor updated pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv4id 18:30:30 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #12: Change: rename .hgignore to .gitignore https://git.io/Jv0C6 18:31:15 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #12: Change: rename .hgignore to .gitignore https://git.io/Jv0C6 18:31:19 <TrueBrain> add before commit ... LALALALAAA 18:31:33 <frosch123> TrueBrain: nogfx is valid, though kind of finished 18:32:06 <frosch123> 0.4 is the branch that builds with nml 0.2 iirc (nml 0.2->0.3 was incompatible in various places) 18:32:07 <TrueBrain> frosch123: maybe in another repo? 18:32:12 <TrueBrain> (for nogfx) 18:32:46 *** Etua has quit IRC 18:32:49 <frosch123> nah, if someone wanted to spend more work, they would patch ottd to disable original mapgen, when no graphics are present 18:33:16 <TrueBrain> ghehe, fair 18:33:16 *** Arveen2 has joined #openttd 18:34:32 <TrueBrain> okay, this Makefile is a bit iffy :D Files being included before being used, etc .. :D I hate Makefile .. it is too complicated for a sane human being 18:35:35 <frosch123> no idea what nml2nfo is about, looks like a dev-branch that lived for 2 days 18:35:55 <TrueBrain> all I hear is: remove nml2nfo and 0.4 branch :P 18:36:13 <frosch123> why remove a release branch? 18:36:26 <TrueBrain> it is a release branch? In that case we can rename it as such :) 18:36:34 <TrueBrain> sorry, I did not understood that from what you said :) 18:36:51 <frosch123> well, it's the only release branch, all other tags are directly from master 18:37:03 <TrueBrain> do we need release branches for OpenGFX? 18:37:09 <TrueBrain> do we maintain more than one "minor" version? 18:37:19 <frosch123> no :) 18:37:24 <TrueBrain> so we can remove 0.4 :P 18:37:46 <frosch123> just don't delete the tags 18:37:52 <TrueBrain> ofc not :) 18:38:01 <TrueBrain> and I am not going to remove the branches now; but mentally I did :P 18:40:36 *** Arveen has quit IRC 18:41:15 <TrueBrain> http://bundles.openttdcoop.org/opengfx/releases/0.5.5/ <- which files here are important? 18:41:58 <TrueBrain> are the nml and obg files used like this? 18:47:15 <TrueBrain> " nmlc warning: "sprites/extra/extra-plus-toyland-infrastructure.pnml", line 4: "sprites/png/infrastructure/toyland_buoys_2006TTD.png" at [x: 225, y: 6]: 30 of 1024 pixels (2%) are animated" <- why is this a warning? 18:49:02 <DorpsGek_III> [OpenTTD/OpenTTD] kiwitreekor updated pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv4id 18:49:26 <TrueBrain> okay .. OpenGFX does build .. that was not that difficult .. 18:53:26 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #13: Fix #2: readme.txt renamed to README.md https://git.io/Jv0Wm 18:56:35 <DorpsGek_III> [OpenTTD/OpenTTD] kiwitreekor updated pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv4id 18:58:16 <DorpsGek_III> [OpenTTD/OpenTTD] kiwitreekor commented on pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv0Wz 19:01:39 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv0Wo 19:04:22 <frosch123> TrueBrain: https://pastebin.com/3PXC9Xr9 19:05:12 <TrueBrain> <3 19:08:08 <TrueBrain> the pull-request to change to git seems to mostly work .. cleaned it up a tiny bit .. seems to give sensible output ... 19:08:50 <DorpsGek_III> [OpenTTD/OpenTTD] kiwitreekor updated pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv4id 19:10:26 *** snail_UES_ has joined #openttd 19:11:05 <DorpsGek_III> [OpenTTD/OpenTTD] kiwitreekor commented on pull request #8008: Feature: Double-click to rename vehicle https://git.io/Jv0W7 19:13:39 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #14: Migrate from mercurial to git https://git.io/Jv0Wb 19:14:23 <TrueBrain> okay, these 3 PRs just need reviews; other than that, it seems to "just work" 19:14:32 <TrueBrain> someone with more knowledge of this should validate the result, I guess :P 19:16:38 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #15: Add: [Actions] validate that the commit messages are complying with t… https://git.io/Jv0Wj 19:17:05 <TrueBrain> is this wanted ^^ :) 19:17:32 <TrueBrain> should make it into a real action, avoiding duplication like this I guess 19:19:02 <frosch123> since git the openttd commit style mostly matches the old devzone commit style 19:19:37 <frosch123> so commit message style is the same on all repos now 19:20:03 <frosch123> however, some of ottd's checks of the diff probably apply only to c++ 19:20:15 <frosch123> though i guess it filters on file extension? 19:21:22 <TrueBrain> you wrote it! :D I don't know :P 19:22:59 <TrueBrain> doesn't seem to be the case 19:23:07 <TrueBrain> so possibly that is a bad idea .. fine, I will not do that for now :) 19:23:31 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #15: Add: [Actions] validate that the commit messages are complying with the OpenTTD standard https://git.io/Jv0lL 19:23:31 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain closed pull request #15: Add: [Actions] validate that the commit messages are complying with the OpenTTD standard https://git.io/Jv0Wj 19:23:47 <TrueBrain> https://github.com/TrueBrain/OpenTTD-OpenGFX/runs/462300858?check_suite_focus=true 19:23:49 <TrueBrain> seems to run ... 19:23:52 <TrueBrain> lets see if it finishes 19:24:06 *** Etua has joined #openttd 19:25:53 <frosch123> is_source = (filename.find("3rdparty") < 0) and filename.endswith((".cpp", ".c", ".hpp", ".h")) 19:26:05 <frosch123> so, hooks should be fine for all repositories 19:26:10 <frosch123> they just mostly check nothing :) 19:26:24 <TrueBrain> lol, did I really completely miss that? Omg :D 19:26:28 <TrueBrain> I am running blind :D 19:26:33 <TrueBrain> okay, I will reopen the PR :P 19:26:39 <frosch123> likely openttd is the only project that uses tab for indention, sane projects use spaces :) 19:26:48 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #15: Add: [Actions] validate that the commit messages are complying with the OpenTTD standard https://git.io/Jv0lm 19:26:48 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain reopened pull request #15: Add: [Actions] validate that the commit messages are complying with the OpenTTD standard https://git.io/Jv0Wj 19:26:58 <TrueBrain> indeed :) 19:27:08 <TrueBrain> possibly we should split it in "coding style" and "commit message style" 19:28:04 <TrueBrain> funny, installing "nml" from pip results in a non-working nml :) 19:28:08 <TrueBrain> what is this about ... hmm ... 19:30:14 <LordAro> someone should work out how to push to pip on new releases :) 19:30:27 <TrueBrain> does anyone mind if I pull OpenGFX into the "official" OpenTTD infrastructure? (away from openttdcoop infrastructure) 19:30:53 <LordAro> i thought that was the plan anyway 19:31:01 <LordAro> some of the issues could do with migrating, i guess 19:31:07 <frosch123> i think a lot of people mind, they may kiss your feet 19:32:02 <TrueBrain> lol @ frosch123 :) 19:32:19 <TrueBrain> well, I don't want to steal anyones thunder 19:33:00 <Samu> is there a savegame contest for 1.10? 19:34:54 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lW 19:34:59 <TrueBrain> WTB: reviews :) :D 19:35:11 <TrueBrain> but initial testing shows this is going to work just fine 19:35:18 <TrueBrain> (it doesn't publish it yet; it just builds atm) 19:41:29 <Xaroth> lgtm 19:42:09 <TrueBrain> LordAro: is the next NML release 0.4.6 or 0.5? 19:44:09 <frosch123> 0.5 19:44:30 <frosch123> major incompatibility with 0.4 19:49:43 <TrueBrain> tnx 19:50:12 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #17: Random fixes to README.md, and move some files around https://git.io/Jv0l6 19:51:01 <TrueBrain> http://dev.openttdcoop.org/projects/home/wiki needs migrating; otherwise it seems I found all the old coop-references 19:51:59 <TrueBrain> but okay, with 6 open PRs, it is time to sit on my hands for a bit :D 19:55:06 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #8: Fixes for building from git https://git.io/Jv0l9 19:55:06 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain closed pull request #8: Fixes for building from git https://git.io/Jv0lH 19:55:32 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #3: Change: Tweaks and fixes for moving to git. https://git.io/Jv0lQ 19:55:32 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain closed pull request #3: Change: Tweaks and fixes for moving to git. https://git.io/Jv0l7 19:55:36 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro commented on pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0l5 19:55:49 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #12: Change: rename .hgignore to .gitignore https://git.io/Jv0lF 19:55:57 <LordAro> eh, my approval is useless 19:56:11 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #13: Fix #2: readme.txt renamed to README.md https://git.io/Jv0lb 19:56:24 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lA 19:56:32 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #15: Add: [Actions] validate that the commit messages are complying with the OpenTTD standard https://git.io/Jv0lx 19:57:40 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro commented on pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lh 19:58:23 <TrueBrain> LordAro: Makefile:158: Makefile.vcs: No such file or directory 19:58:23 <TrueBrain> Makefile:256: Makefile.gfx: No such file or directory 19:58:35 <TrueBrain> and they are never included again 19:59:04 <LordAro> interesting 19:59:08 <TrueBrain> it is just a bit messy; and not really worth the time atm I guess :) 19:59:13 <TrueBrain> more something for a rainy day :P 20:00:12 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #13: Fix #2: readme.txt renamed to README.md https://git.io/Jv0Wm 20:00:28 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #12: Change: rename .hgignore to .gitignore https://git.io/Jv0C6 20:01:05 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #15: Add: [Actions] validate that the commit messages are complying with the OpenTTD standard https://git.io/Jv0Wj 20:02:03 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #17: Random fixes to README.md, and move some files around https://git.io/Jv0l6 20:03:10 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lW 20:03:45 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv083 20:03:50 <glx> <TrueBrain> funny, installing "nml" from pip results in a non-working nml :) <-- yeah 0.4.5 is quite old now, and openttd sprite count increased many times since its release 20:04:29 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lW 20:04:52 <TrueBrain> trailing whitespaces, awesome 20:05:02 <TrueBrain> tnx glx :) I fixed it by installing "master" for now 20:05:23 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #14: Migrate from mercurial to git https://git.io/Jv0Wb 20:06:53 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #14: Migrate from mercurial to git https://git.io/Jv08c 20:06:54 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #17: Random fixes to README.md, and move some files around https://git.io/Jv0l6 20:07:20 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv08C 20:08:14 <TrueBrain> curious if this action-run is going to work without the hg->git fix :) 20:08:17 <TrueBrain> it should, I think 20:08:26 <TrueBrain> gimp is SLOW btw, holy crap 20:08:34 <TrueBrain> not sure if there is a reason for that, but okay 20:08:36 <glx> glib warnings everywhere 20:08:47 <LordAro> not exactly surprising 20:08:50 <TrueBrain> yeah ... I have that locally too. Cannot find what it is about 20:10:09 *** gelignite has quit IRC 20:10:24 *** gelignite has joined #openttd 20:11:17 <TrueBrain> 6 minutes and 18 seconds .. lol .. painful 20:11:30 <TrueBrain> "/bin/bash: grfid: command not found" 20:11:32 <TrueBrain> it doesn't fail because of that 20:11:39 <TrueBrain> many minor things wrong with this Makefile :) 20:12:03 <FLHerne> TrueBrain: Would it be practical to run whatever tool was used to OTTD flyspray to Github on the nml and eints trackers? Or is it a bit late now? 20:12:21 <FLHerne> [apropos of nothing much] 20:12:50 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain dismissed a review for pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv08C 20:12:50 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lW 20:13:07 <TrueBrain> FLHerne: did they also use FlySpray? 20:13:16 <TrueBrain> I wrote a very specific Python script to migrate FlySpray to GitHub 20:13:28 <TrueBrain> as in .... it logged in the FlySpray database to fetch the data :) 20:13:33 <TrueBrain> but we can reuse parts if needed 20:14:38 <FLHerne> TrueBrain: Hm, no, devzone's own issues which seem to be Redmine 20:14:41 <frosch123> FLHerne: http://devs.openttd.org/~frosch/redmine2github/ <- feel free to conintue with that 20:14:56 <TrueBrain> lol :) 20:14:56 <frosch123> i gave it to pm last year, no idea whether he improved it 20:15:26 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #14: Migrate from mercurial to git https://git.io/Jv0Wb 20:15:41 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lW 20:16:12 <frosch123> FLHerne: https://github.com/IQSS/redmine2github <- the diff is against that 20:16:57 <TrueBrain> "fatal: No names found, cannot describe anything." <- hmm ... one more error .. hmmm .. 20:17:46 <FLHerne> frosch123: Thanks, will look 20:17:54 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lW 20:18:18 <TrueBrain> so much OpenGFX spam :P Why did I enable DorpsGek? :D 20:18:56 <milek7> does it uses fancy effects? or it could be replaced by imagemagick/vips/something? 20:18:59 <TrueBrain> owh git .. sometimes I hate you 20:19:41 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lW 20:19:46 <TrueBrain> good question milek7 20:20:51 <TrueBrain> there we go 20:21:09 <TrueBrain> now with a lot less errors :) 20:21:12 <TrueBrain> https://github.com/OpenTTD/OpenGFX/runs/462348162?check_suite_focus=true 20:22:01 <TrueBrain> milek7: if you are interested, https://github.com/OpenTTD/OpenGFX/blob/master/scripts/gimpscript 20:26:30 <TrueBrain> "opengfx-HEAD-0.5.5-12-g179bd92.tar" <- still not perfect, but at least it now runs a CI :) 20:26:39 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #17: Random fixes to README.md, and move some files around https://git.io/Jv089 20:26:53 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #17: Random fixes to README.md, and move some files around https://git.io/Jv0l6 20:27:38 <TrueBrain> LordAro: tnx for the reviews :) Last PR you already approved, but I made minor changes to make the result a bit better :P 20:28:25 <TrueBrain> I don't get the nmlc warnings .. they feel bogus 20:29:19 <LordAro> does feel like it should be a verbose message 20:29:31 <TrueBrain> and for sure not a warning ... 20:29:44 <glx> it is if you don't set the right flags IIRC 20:30:04 <TrueBrain> but okay, that for sure is not my department :) 20:30:16 <TrueBrain> at least now andy can't complain anymore; as OpenGFX now just compiles :P 20:31:45 <glx> https://newgrf-specs.tt-wiki.net/wiki/NML:Realsprites <-- I guess missing ANIM in some places 20:32:09 <TrueBrain> "some" ? :D 20:32:28 <TrueBrain> https://github.com/OpenTTD/OpenGFX/runs/462348162?check_suite_focus=true#step:6:474 20:32:29 <glx> or wrong palette conversion in source image 20:32:46 <frosch123> that flag was added in 2017 or so, so after ogfx was active 20:32:58 <TrueBrain> 400-ish warnings :) 20:33:06 <TrueBrain> frosch123: ah :) 20:33:48 <glx> water and level-crossing are definitely missing ANIM :) 20:33:51 <TrueBrain> well, reading that wiki, I cannot rule out it indeed is a bug :P 20:34:01 <TrueBrain> but the warning is not really clear 20:34:08 <TrueBrain> "warning: 2% of the pixels are animated" 20:34:24 <TrueBrain> better: "warning: only 2% of the pixels are animated; was the animated pixel intented?" 20:34:25 <TrueBrain> :D 20:34:33 <glx> I agree the messages are not always the best :) 20:35:05 <TrueBrain> but okay, that also explains why rivers are triggering this hard 20:35:08 <TrueBrain> so it is a bug in OpenGFX :) 20:35:09 <TrueBrain> good 20:38:31 <FLHerne> TrueBrain: There isn't an limit, it assumes any number of animated pixels are a mistake unless described as ANIM 20:38:56 <TrueBrain> FLHerne: ah; well, as said, the warning is not really clear in what the problem is :P 20:39:02 <TrueBrain> so yeah, someone should add a tons of ANIM I guess :D 20:39:42 <glx> that's a good thing to explicitely say you use animated pixels, prevent flashing sprites when non intended :) 20:40:04 <TrueBrain> it wouldnt surprise me if this means we find bugs in OpenGFX :) 20:40:06 <TrueBrain> so yeah ;) 20:40:21 <LordAro> :D 20:40:52 * TrueBrain gives LordAro a cookie as a bribe for the last approval :P 20:41:42 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv04s 20:41:56 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #16: Add: [Actions] test if the repository builds successful https://git.io/Jv0lW 20:42:00 <TrueBrain> tnx LordAro :) 20:42:16 <TrueBrain> I have no clue what the gimp warning is about .. silly gimp 20:42:26 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv04n 20:42:43 <TrueBrain> not many hits when you google on it .. there are bugs about it, but those are closed with: "too old" :P 20:42:55 <LordAro> almost all glib applications output those warnings 20:42:59 <LordAro> everyone ignores them 20:43:02 <glx> it's glib, I guess it's usual 20:43:27 <TrueBrain> annoying ... 20:43:32 <TrueBrain> but okay, using gimp is annoying :D 20:43:43 <TrueBrain> not something that can easily be resolved, so not complaining 20:44:02 <milek7> actually it looks easy 20:44:08 <milek7> I'm looking at it 20:44:18 <TrueBrain> cool :) 20:44:40 <TrueBrain> so ... on tag... what should this do ... publish a version to the CDN, I guess .. 20:45:06 <TrueBrain> an -all.zip and a -source.tar.xz 20:45:54 <TrueBrain> I wonder if it can auto-publish on BaNaNaS :P 20:47:27 *** Etua has quit IRC 20:47:36 <glx> I guess it can use musa 20:48:23 <TrueBrain> I wonder if we can use 'findversion.sh' 20:49:09 <TrueBrain> seems to be the case 20:49:12 <TrueBrain> might be better to do so 20:51:12 <TrueBrain> the whole gimp thing is a bit weird in the Makefile .. it rebuilds always .. that is just a nag :P 20:51:25 <DorpsGek_III> [OpenTTD/nml] FLHerne opened pull request #89: Change: Make sprite encoder warnings more informative https://git.io/Jv04z 20:52:03 <TrueBrain> now that is useful FLHerne :D 20:52:42 <milek7> make: *** Brak reguł do zrobienia obiektu 'license.txt', wymaganego przez 'opengfx-0.5.5-14-gf3f62e2-dirty'. Stop. 20:52:44 <milek7> huh? 20:52:54 <DorpsGek_III> [OpenTTD/nml] LordAro approved pull request #89: Change: Make sprite encoder warnings more informative https://git.io/Jv042 20:53:29 <TrueBrain> milek7: you updated to latest? 20:53:35 <TrueBrain> ah, no, I see 20:54:14 <TrueBrain> just a poor review :P 20:54:36 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #18: Fix: location of LICENSE is now just that https://git.io/Jv04r 20:54:58 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #18: Fix: location of LICENSE is now just that https://git.io/Jv04o 20:55:13 <DorpsGek_III> [OpenTTD/OpenGFX] glx22 approved pull request #18: Fix: location of LICENSE is now just that https://git.io/Jv04K 20:56:21 <LordAro> glx: i win 20:56:41 <glx> but you somehow failed for #17 :) 20:56:54 <TrueBrain> :D 20:57:01 <TrueBrain> poor LordAro :) 20:57:02 <LordAro> :( 20:58:12 <TrueBrain> okay, I am not going to clean up OpenGFX completely; just going to make it work 20:58:38 <TrueBrain> I don't know enough things to not comfortly clean up the things I think we can clean up :) 20:59:05 <TrueBrain> but there are lines like: 20:59:05 <TrueBrain> # The license is set via bananas.ini, do not supply a "custom" license. 20:59:05 <TrueBrain> MUSA_FLAGS ?= -x license.txt 20:59:25 <TrueBrain> contradictions :) 20:59:33 <glx> and it's wrong 20:59:42 <glx> should be LICENCE now :) 20:59:52 <TrueBrain> it was already referencing an invalid file 20:59:57 <TrueBrain> so not sure that was on purpose or not 21:00:26 <michi_cc> TrueBrain: It's not a contradiction, -x is exclude (still wrong now) 21:01:18 <TrueBrain> as said, I don''t understand this enough to touch it :D 21:01:47 <TrueBrain> also part of the hg->git PR was to convert README.md to readme.txt with a very very long script 21:02:04 <TrueBrain> not sure if there can be a README.md in a baseset? :D 21:03:28 <LordAro> not that gets read by the game 21:03:28 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain dismissed a review for pull request #18: Fix: location of LICENSE is now just that https://git.io/Jv04K 21:03:29 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #18: Fix: location of LICENSE is now just that https://git.io/Jv04r 21:03:32 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain dismissed a review for pull request #18: Fix: location of LICENSE is now just that https://git.io/Jv04o 21:04:03 <TrueBrain> did nielsm ever merge his markdown reader for OpenTTD's README.md? :) 21:04:32 <LordAro> nop 21:05:31 <glx> it was not finished 21:08:02 <DorpsGek_III> [OpenTTD/nml] glx22 approved pull request #89: Change: Make sprite encoder warnings more informative https://git.io/Jv0Bf 21:09:10 <DorpsGek_III> [OpenTTD/nml] FLHerne merged pull request #89: Change: Make sprite encoder warnings more informative https://git.io/Jv04z 21:09:27 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #18: Fix: location of LICENSE is now just that https://git.io/Jv0BU 21:09:41 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #18: Fix: location of LICENSE is now just that https://git.io/Jv04r 21:14:02 *** Progman has joined #openttd 21:17:13 <DorpsGek_III> [OpenTTD/OpenGFX] stormcone opened pull request #19: Fix: Fix some misspelling in the credits section. https://git.io/Jv0Bu 21:19:49 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain approved pull request #19: Fix: Fix some misspelling in the credits section. https://git.io/Jv0Bw 21:20:26 *** snail_UES_ has quit IRC 21:23:20 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #19: Fix: Fix some misspelling in the credits section. https://git.io/Jv0Bu 21:23:25 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #19: Fix: Fix some misspelling in the credits section. https://git.io/Jv0BS 21:23:37 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain closed issue #4: README.md still contains errors https://git.io/Jv0B7 21:28:40 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #20: Change: also allow creating a source-tar via git (instead of Mercurial) https://git.io/Jv0RJ 21:28:44 <TrueBrain> found one more :D 21:31:18 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #20: Change: also allow creating a source-tar via git (instead of Mercurial) https://git.io/Jv0RJ 21:31:30 <TrueBrain> okay, the produced source tarball is now as it was for 0.5.5 21:31:42 <LordAro> and probably remove the ifneq($(GIT),) stuff, tbh 21:31:49 <LordAro> no real need to support the build system without it 21:31:55 <TrueBrain> no, it is needed for the source tarball 21:31:59 <TrueBrain> same for OpenTTD btw 21:32:01 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #20: Change: also allow creating a source-tar via git (instead of Mercurial) https://git.io/Jv0RY 21:32:08 <TrueBrain> otherwise you cannot build the source tarballs :) 21:32:18 <LordAro> is it worth supporting that? 21:32:22 <milek7> https://pastebin.com/raw/FC2yfg1V 21:32:27 <TrueBrain> we publish a source-tarball, so yeah, that is worth it 21:32:37 <LordAro> i guess so 21:32:50 <TrueBrain> milek7: are the PNGs identical, happen to know? 21:33:32 <milek7> not tested yet 21:34:05 <TrueBrain> looks good so far :D 21:35:24 <milek7> there might be a problem if xcf2png files list layers in wrong order 21:35:49 <milek7> previously it didn't matter because gimpscript didn't reorder layers, but xcf2png does 21:36:32 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain dismissed a review for pull request #20: Change: also allow creating a source-tar via git (instead of Mercurial) https://git.io/Jv0RY 21:36:33 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #20: Change: also allow creating a source-tar via git (instead of Mercurial) https://git.io/Jv0RJ 21:37:11 <TrueBrain> sorry LordAro :P Dismissing your review like that .... I was a bit annoyed I didn't spotted this earlier .. so it is now part of the CI :D 21:37:25 <LordAro> i did wonder about that 21:37:34 <LordAro> should add it to OTTD as well :p 21:37:50 <TrueBrain> in OpenTTD it is done by azure-pipelines, not by Makefile 21:37:59 <TrueBrain> and a lot more robust tbh ... 21:38:03 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #20: Change: also allow creating a source-tar via git (instead of Mercurial) https://git.io/Jv0R8 21:38:12 <glx> milek7: gimp script seems to use layer names 21:38:40 <TrueBrain> so I can now produce both the binary as the source in the way 0.5.5 did it .. so now it is just a matter of publishing it, I guess 21:38:48 <TrueBrain> the easy part to write .. the hard part to test :P 21:39:31 <milek7> glx: yes, but it just toggles them 21:39:41 <milek7> xcf2png takes names and composes them in specified order 21:42:14 <TrueBrain> awh, the patch doesn't apply to master anymore .. sorry milek7 :P 21:42:33 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #20: Change: also allow creating a source-tar via git (instead of Mercurial) https://git.io/Jv0RJ 21:44:00 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on issue #7: Building from github doesn't work https://git.io/Jv0Ra 21:44:00 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain closed issue #7: Building from github doesn't work https://git.io/Jv0Ra 21:44:33 <nielsm> TrueBrain: there's two big items missing for the "help and manuals window" PR: first is making sure it can find the files on all supported OS, second is figuring out if it's the right place to put this UI 21:47:39 <TrueBrain> nielsm: well, if you figured that out, I have a request: make this work for basesets too :D 21:47:40 <TrueBrain> ghehehehe :) 21:47:56 <TrueBrain> milek7: your patch at least is a lot faster :P Code is now a bit silly, as those 'scm' files are not needed, but those are details :) 21:48:15 <nielsm> TrueBrain it could probably be managed somehow :P 21:49:02 <TrueBrain> milek7: owh, your patch doesn't produce pngs yet :D ghehe :) 21:49:04 <glx> ah yes I see what can go wrong with xcf2png 21:49:42 <milek7> it should produce them 21:49:52 <TrueBrain> ah, no, I mis copy/pasted something 21:49:53 <TrueBrain> nvm 21:50:27 <TrueBrain> nielsm: I would think more and more people will switch to a README.md, so something to keep in mind with your PR :) 21:53:32 <TrueBrain> xcf2png produces slightly larger png files .. not sure why yet :P 21:54:38 <glx> milek7: maybe you can get the right order using xcf2info and some magic 21:55:06 <glx> well xcfinfo 22:02:56 <TrueBrain> size difference seems mostly to have to do with the compression used 22:04:37 *** snail_UES_ has joined #openttd 22:05:22 <milek7> find . -iname '*.gimp.png' -type f | sort | xargs -L1 png2pnm | sha256sum 22:05:30 <milek7> result are different :/ 22:05:58 <LordAro> not entirely surprising? 22:06:02 <milek7> though pngs checked out from repo and generated with gimp doesn't match either. 22:06:08 <glx> pnm is not png ;) 22:06:23 <LordAro> pngs have many possible variations beyond compression 22:06:37 <LordAro> need to actually visually inspect them :p 22:06:45 <TrueBrain> gimp here produces the exact same pngs as are checked in btw 22:07:43 <milek7> LordAro: that's what i wanted to avoid with pnm conversion 22:08:21 <TrueBrain> okay, "compare" is funny (imagemagick tool) 22:08:28 <TrueBrain> it shows that the result is slightly different :P 22:09:07 <TrueBrain> no, I take that back 22:09:09 <TrueBrain> a full white image :P 22:09:15 <glx> reordered layers I guess 22:09:21 <LordAro> heh 22:09:32 <TrueBrain> xcf2png with pngcrush combined gives slightly smaller pngs 22:09:39 <TrueBrain> and identical pixel result,, it seems 22:10:08 <frosch123> just compare the resulting .grf 22:10:10 <TrueBrain> one difference between gimp and xcf2png+pngcrush, is that there is a chunk less in the latter 22:10:22 <TrueBrain> frosch123: you are too clever for us, damn you 22:10:27 <frosch123> png are intermediate files, it does not matter if they differ 22:11:34 <frosch123> don't compare the md5sum in the obg though, that does not include sprite data :) 22:15:13 <DorpsGek_III> [OpenTTD/OpenTTD] Quipyowert2 updated pull request #8017: Codechange: Limit field width to avoid sscanf crash https://git.io/JvRs5 22:17:34 <DorpsGek_III> [OpenTTD/OpenTTD] Quipyowert2 commented on pull request #8017: Codechange: Limit field width to avoid sscanf crash https://git.io/Jv00L 22:17:36 *** Speedy` has quit IRC 22:18:32 <TrueBrain> identical result, except for "ogfxe_extra.grf" 22:18:35 <TrueBrain> frosch123 is smart :P 22:18:59 <frosch123> except? 22:19:16 <TrueBrain> so 6 grfs are binary identical; only that file is not 22:19:17 <frosch123> i would not be surprised if only ogfxe_extra uses the composed sprites :p 22:19:24 <TrueBrain> :( 22:20:04 <TrueBrain> so a clever way to find out which sprite differs? :D 22:20:07 <glx> but difference means different pixels 22:20:55 <TrueBrain> no, "base" also uses xcf2png 22:21:01 <TrueBrain> so many pngs do go right 22:21:04 <TrueBrain> just something in extra does not 22:21:19 <glx> reordered layers probably 22:21:51 <TrueBrain> "coalmine_anim1.gimp.png" for example is in "base", which is binary identical 22:27:22 <TrueBrain> btw milek7 , you might want to change the >> into > around like 260 .. the >> .scm.new you have, kinda bloats the file over time :D 22:27:33 <TrueBrain> well .. not if you are doing things right 22:27:38 <TrueBrain> if you arent like me .. things get weird :D 22:27:39 <TrueBrain> ghehe 22:27:47 *** Samu has quit IRC 22:27:51 <TrueBrain> that was fun :P 22:28:01 <TrueBrain> okay, I have no clue how to figure out what is different :) 22:30:57 *** snail_UES_ has quit IRC 22:33:27 <frosch123> where is actually the source to generate all those xcf2png files... 22:33:55 <TrueBrain> sprites/source/terrain/terrain.xcf 22:33:56 <TrueBrain> for example 22:34:05 <TrueBrain> starts in sprites/graphics_source_lists 22:37:23 <frosch123> hmm, so the source files are names xcf2png, but it does actually not use xcf2png but gimp? 22:37:34 <TrueBrain> yes 22:40:11 <milek7> TrueBrain: yes.. but .new is removed at the end anyway, isn't it? 22:40:35 <TrueBrain> yeah, so it is fine in your patch :) 22:40:39 <TrueBrain> silly, but fine :P 22:41:51 <TrueBrain> grep "\([pP][cCnN][xXgG]\)" <- everytime I read this, it makes me giggle :) 22:43:36 <LordAro> everyone likes pcg files 22:45:17 <frosch123> they are capitalized like PCg 22:45:44 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #21: Remove: [Makefile] unused lines of code, files that don't exist, etc https://git.io/Jv007 22:45:53 <TrueBrain> okay, last commit of the day for me .. seen enough of this Makefile :P 22:48:27 <frosch123> custom_tags is read by nml 22:48:41 <TrueBrain> @#$@^#$$#@ .. this undocumented stuff .... :( 22:48:51 <TrueBrain> and who named the file like that?! :P 22:49:03 <frosch123> yexo or Hirundo 22:49:19 <TrueBrain> it seriously is a really bad name 22:49:19 <frosch123> but only TITLE seems to be used 22:51:10 <TrueBrain> and parsetab.py is generated by nml too or something? :D 22:51:24 <frosch123> i think that was fixed in newer nml 22:51:29 <frosch123> it does no longer leave that behind 22:51:53 <frosch123> but yes, it used to be a nml cache file 22:52:03 <TrueBrain> I was joking ... :P 22:52:05 <TrueBrain> dammit :) 22:54:38 <DorpsGek_III> [OpenTTD/OpenGFX] frosch123 commented on pull request #21: Remove: [Makefile] unused lines of code, files that don't exist, etc https://git.io/Jv0Ef 22:54:58 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #21: Remove: [Makefile] unused lines of code, files that don't exist, etc https://git.io/Jv007 22:55:12 <TrueBrain> I just restored it completely 22:56:00 <milek7> >gimp here produces the exact same pngs as are checked in btw 22:56:03 <milek7> hm.. not for me 22:56:19 <TrueBrain> can be version, etc. But as mentioned,it might not matter :) 22:56:31 <milek7> https://www.diffchecker.com/Hr4yNFmE 22:57:10 <TrueBrain> check if the resulting grfs are the same :) 22:57:33 <milek7> they cannot be if source is different ;p 22:57:41 <TrueBrain> but honestly, this might be the difference with xcf2png 22:57:57 <DorpsGek_III> [OpenTTD/OpenGFX] frosch123 commented on pull request #21: Remove: [Makefile] unused lines of code, files that don't exist, etc https://git.io/Jv0EL 22:58:37 <milek7> funnily enough, xcf2png is more consistent with repo.. 22:58:38 <milek7> https://www.diffchecker.com/t5dLZNnW 22:58:49 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #21: Remove: [Makefile] unused lines of code, files that don't exist, etc https://git.io/Jv0Em 23:00:46 <DorpsGek_III> [OpenTTD/OpenGFX] frosch123 commented on pull request #21: Remove: [Makefile] unused lines of code, files that don't exist, etc https://git.io/Jv0EZ 23:01:07 <TrueBrain> frosch123: the thing is, you need indepth knowledge of nml to understand "lng" reference 23:01:50 <frosch123> what is the target audience of the makefile? 23:02:06 <TrueBrain> this is output, so who-ever compiles OpenGFX 23:02:35 <TrueBrain> it now outputs: "[NML] custom_tags.txt" 23:03:17 <TrueBrain> NML-DEP ? 23:04:21 <TrueBrain> this really has grown too complex for an outsider to understand :D 23:04:58 <frosch123> custom_tags.txt is the same as src/rev.cpp in ottd 23:05:19 <TrueBrain> except that you can grep src/rev.cpp in the same repository as it is generated in :) 23:05:25 <frosch123> would you annotate generating src/rev.cpp with [LINKING]? 23:05:43 <TrueBrain> I fully understand why you think NML is wrong; I am looking for a better word 23:05:49 <TrueBrain> LNG confused the fuck out of me :P 23:05:58 <TrueBrain> it is doing something for NML to work properly 23:06:03 <TrueBrain> I was looking for a reference towards that 23:06:35 <frosch123> change nml to take it via command line, instead of implicitly looking for it 23:06:43 <frosch123> but for now, just leave LNG 23:06:58 <TrueBrain> compromise: NML-LNG? 23:07:01 <frosch123> it makes most sense, thinking of it as generating lng files 23:07:19 <frosch123> fine :) NML-LNG 23:07:22 <TrueBrain> and indeed, a command line option would solve it ;) 23:07:43 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #21: Remove: [Makefile] unused lines of code, files that don't exist, etc https://git.io/Jv007 23:07:56 <TrueBrain> made the comment even more clear; tnx for all that info :) 23:09:43 <TrueBrain> okay, I fucked this up now, let me fix this ... :P 23:09:50 <frosch123> i still don't get this PR 23:09:58 <TrueBrain> because it is a mess :P 23:10:01 <frosch123> why does REPO_MODIFIED no longer exist? 23:10:08 <TrueBrain> it got removed a while ago 23:10:17 <frosch123> what it deleted on purpose? usually we put an "M" into the version string 23:10:43 <TrueBrain> seems "REPO_VERSION" now has -dirty as postfix 23:10:54 <milek7> either i'm comparing wrong files, or there is something odd going on.. 23:10:58 <TrueBrain> I would rather replace it with "findversion.sh" 23:10:59 <TrueBrain> but alas 23:11:32 <milek7> xcf2png differs from PNGs on repo only on riverbank_arctic_snow14 23:11:47 <frosch123> TrueBrain: i think it is too early for this PR 23:11:47 <milek7> and it's because of that, wrong mask order: https://i.imgur.com/LGGUU0r.png 23:12:01 <TrueBrain> frosch123: yeah, hence the simply cleaning up for now 23:12:05 <frosch123> it removes things that need fixing 23:12:11 <TrueBrain> owh, like that 23:12:14 <TrueBrain> hmm .. 23:12:23 <frosch123> like the removal of readme.txt 23:12:43 <frosch123> when it was converted to .md, people likely did not think about readme.txt displayed in ottd 23:12:43 <TrueBrain> the removal of the .gitignore entry? 23:13:02 <TrueBrain> so, we need issues to fix problems :) 23:13:29 <frosch123> yes, you remove docs/readme.txt because it does no longer exist. but "it does no longer exist" is a bug :) 23:13:52 <TrueBrain> (btw, we haven't used M for a long time :P We have -g, -m, and -u postfixes these days) 23:14:07 <TrueBrain> well, in that location it will never exist 23:14:09 <TrueBrain> but I get what you mean 23:15:34 <milek7> but, repo and gimp differs in subtle ways: https://milek7.pl/.stuff/pnm_WTH.png 23:15:48 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #21: Remove: [Makefile] unused lines of code, files that don't exist, etc https://git.io/Jv007 23:15:49 <milek7> top is repo and xcf2png, bottom is gimp 23:16:07 <TrueBrain> frosch123: minimized the PR for now 23:16:14 <frosch123> TrueBrain: ok, i did not notice the -m and -u yet 23:16:45 <TrueBrain> you want to keep the broken stuff so we fix it, I was removing the broken stuff so I can replace it with newer stuff :) Both work, but I am fine with this :) 23:17:21 <frosch123> milek7: did you check the actual sprites? opengfx may as well be broken, and you are fixing things 23:17:47 <TrueBrain> milek7: what is odd to me, is that locally for me gimp generates the exact same pngs as checked in :) 23:17:55 <TrueBrain> $ gimp --version 23:17:55 <TrueBrain> GNU Image Manipulation Program version 2.8.22 23:18:12 <milek7> GNU Image Manipulation Program version 2.10.16 23:18:29 <milek7> 2.8 is quite old 23:18:33 <TrueBrain> ubuntu 16.04 23:18:36 <TrueBrain> or 18.04? 23:18:39 <TrueBrain> either one of the two 23:18:44 <TrueBrain> (WSL1 Ubuntu) 23:18:58 <TrueBrain> bionic 23:19:03 <DorpsGek_III> [OpenTTD/OpenGFX] frosch123 approved pull request #21: Various of minor stuff https://git.io/Jv0Ei 23:22:52 *** snail_UES_ has joined #openttd 23:23:34 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened issue #22: OpenTTD (ingame) can only show readme.txt, which no longer exists https://git.io/Jv0ED 23:24:12 <TrueBrain> frosch123: guess the question is, do we want OpenGFX to follow OpenTTD, or to follow its own? (regarding -m, -u, ...) 23:25:07 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #21: Various of minor stuff https://git.io/Jv007 23:25:33 <frosch123> you can use the same of the string things, but you need some extra for REPO_DAYS_SINCE_2000 23:25:46 <TrueBrain> yeah, that is fine 23:25:56 <TrueBrain> also a nice thing for OpenTTD btw, to fake the NewGRF version :P 23:25:59 <frosch123> the latter is used for integer-versioning of the grf file, which ottd uses to decide what grf is newer 23:26:23 <TrueBrain> so tomorrow or so I will make OpenGFX more like OpenTTD in terms of version detection 23:26:35 <TrueBrain> after that, I can create the release scripts easy enough 23:27:26 <TrueBrain> the readme issue is more a matter of deciding what we want to do; but we had similar talk about OpenTTD 23:27:34 <TrueBrain> left or right, that is something easy to change later on too 23:27:42 <TrueBrain> right, this should make andy a bit happier :P 23:27:49 <TrueBrain> tnx for the help and info etc, and good night :) 23:27:59 <frosch123> night 23:28:01 <glx> if a .txt is really required, a rename is enough 23:28:16 <glx> markdown is human readable 23:28:31 <TrueBrain> leave your opinion here please: https://github.com/OpenTTD/OpenGFX/issues/22 :) 23:28:31 <LordAro> github will render it as markdown anyway, i think? 23:28:38 <frosch123> can pandoc convert something? 23:28:51 <frosch123> LordAro: bananas and openttd only accept .txt 23:28:52 <LordAro> pandoc seems massive overkill 23:29:13 <frosch123> bananas even removes files it does not know iirc 23:29:17 <LordAro> frosch123: yeah, so name it .txt but use markdown format - i think github will render it as markdown anyway 23:29:26 <TrueBrain> LordAro: we can do that when packing 23:29:32 <TrueBrain> no need to change it in the repo itself :) 23:30:59 <DorpsGek_III> [OpenTTD/OpenGFX] glx22 commented on issue #22: OpenTTD (ingame) can only show readme.txt, which no longer exists https://git.io/Jv0ED 23:32:07 <glx> and nobody reads readme anyway ;) 23:32:28 <frosch123> #6 tried 23:34:59 <milek7> http://milek7.pl/.stuff/terrain.xcf 23:35:12 <milek7> could somebody screenshot how it looks in gimp 2.8? 23:36:01 <milek7> it looks that here: https://milek7.pl/.stuff/gimp210terrain.png 23:44:41 *** WormnestAndroid has quit IRC 23:44:59 *** WormnestAndroid has joined #openttd 23:46:34 *** frosch123 has quit IRC 23:48:14 <milek7> https://pastebin.com/raw/sE9J7UfK 23:48:39 <milek7> this gives pixel-perfect compared to png commited on repo 23:49:04 <milek7> with xcf2png - Xcftools 1.0.7 23:50:04 <milek7> but gimp 2.10 blends is subtly differently, I don't know why