Times are UTC Toggle Colours
00:03:26 *** nielsm has quit IRC 00:08:44 *** Wolf01 has quit IRC 00:22:31 *** WormnestAndroid has quit IRC 00:22:55 *** WormnestAndroid has joined #openttd 00:27:01 *** Progman has quit IRC 01:14:41 *** spnda has quit IRC 01:15:41 *** Flygon has joined #openttd 01:19:32 *** Smedles has quit IRC 01:20:53 *** Smedles has joined #openttd 01:23:26 *** arikover has quit IRC 01:29:48 *** Wormnest has joined #openttd 02:03:34 <DorpsGek_III> [OpenTTD/OpenGFX] Andrew350 commented on pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv0g7 02:22:26 *** Wormnest has quit IRC 02:44:51 *** gelignite_ has joined #openttd 02:52:11 *** gelignite has quit IRC 03:18:01 *** debdog has joined #openttd 03:21:21 *** D-HUND has quit IRC 03:22:07 *** Wormnest has joined #openttd 03:24:46 *** snail_UES_ has quit IRC 03:57:17 *** glx has quit IRC 03:59:25 *** snail_UES_ has joined #openttd 04:12:20 *** Smedles has quit IRC 04:14:59 *** Smedles has joined #openttd 04:49:05 *** gelignite_ has quit IRC 05:54:26 *** Smedles has quit IRC 05:56:42 *** Smedles has joined #openttd 06:45:51 *** Wormnest has quit IRC 07:08:59 *** andythenorth has joined #openttd 07:29:11 <andythenorth> o/ 07:35:39 *** Smedles has quit IRC 07:36:11 <TrueBrain> andythenorth : OpenGFX compiles. Your turn :p 07:36:22 <andythenorth> I just pulled 07:36:34 <andythenorth> been reading the github notifications 07:37:25 <andythenorth> hmm, I'd better fork it, my clone of official repo is no good eh 07:37:43 <TrueBrain> Smart :) 07:37:53 *** Smedles has joined #openttd 07:38:03 <andythenorth> would be smarter if I did it right first time, instead of wrong :P 07:41:30 * andythenorth looks for a makefile target that doesn't require gimp 07:43:31 <andythenorth> shall I just install GIMP and edit README to specify GIMP as required, not optional? 07:47:23 *** Progman has joined #openttd 07:51:45 <TrueBrain> It is optional 07:52:13 <TrueBrain> So that would be a weird thing to do :) 07:52:45 <TrueBrain> 'make nml' should work btw 07:58:11 <TrueBrain> ah, I see what they did .. 07:58:15 <TrueBrain> andythenorth: GIMP= make 07:58:15 <TrueBrain> works 07:58:43 <andythenorth> make nml works, I just missed it in the docs 07:58:56 <TrueBrain> the above also produces a tarball 07:59:08 <andythenorth> I should read the docs harder 07:59:18 <andythenorth> although make nml isn't mentioned so eh :) 07:59:19 <TrueBrain> no, this really is not you 07:59:32 <TrueBrain> building OpenGFX requires additional courses :P 08:01:30 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #23: Fix: [Makefile] autodetect if GIMP is installed https://git.io/Jv0Kq 08:01:34 <dwfreed> make GIMP= also works :) 08:01:37 <TrueBrain> there, that should help too :) 08:02:47 <dwfreed> the difference is that make GIMP= sets the make variable, GIMP= make sets an env variable; the latter of which will be inherited by programs run by make, the former won't 08:07:24 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth commented on pull request #23: Fix: [Makefile] autodetect if GIMP is installed https://git.io/Jv0KY 08:09:30 <andythenorth> I appear to be able to build ogfx tar bundle 08:11:05 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #24: Fix: [Makefile] make sure that filenames in the tarball are as OpenTTD expects https://git.io/Jv0KO 08:14:47 <TrueBrain> and that even works :o 08:14:51 <TrueBrain> shocked 08:17:02 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #24: Fix: [Makefile] make sure that filenames in the tarball are as OpenTTD expects https://git.io/Jv0KE 08:18:16 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #23: Fix: [Makefile] autodetect if GIMP is installed https://git.io/Jv0Ku 08:19:20 <LordAro> reviewing PRs over breakfast is fun 08:19:28 <TrueBrain> especially these small ones :P 08:19:37 <TrueBrain> what is odd about the gimp detection thingy? 08:20:00 <LordAro> dunno, just haven't really seen that method of autodetection used before 08:20:08 <TrueBrain> ah .. it is all over this Makefile 08:20:16 <LordAro> fair enough 08:20:16 <TrueBrain> it is an old dirty cheap way of "autodetecting" :P 08:20:33 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #23: Fix: [Makefile] autodetect if GIMP is installed https://git.io/Jv0Kq 08:20:47 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain closed issue #22: OpenTTD (ingame) can only show readme.txt, which no longer exists https://git.io/Jv0ED 08:20:47 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #24: Fix: [Makefile] make sure that filenames in the tarball are as OpenTTD expects https://git.io/Jv0KO 08:23:05 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on issue #6: Make readme/changelog/license button clickable. https://git.io/Jv0Kr 08:23:06 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain closed issue #6: Make readme/changelog/license button clickable. https://git.io/Jv0Kr 08:24:17 * andythenorth wonders if the sprite warnings should be fixed 08:24:25 <andythenorth> I don't like that many errors just being normal 08:24:56 <TrueBrain> they really should 08:29:05 <LordAro> andythenorth: you should fix them! 08:29:21 <andythenorth> I'll look in a bit 08:33:46 <TrueBrain> from what glx said yesterday, mostly it is missing ANIM tags 08:37:03 <andythenorth> that makes sense 08:37:24 *** Progman has quit IRC 08:45:49 *** sla_ro|master has joined #openttd 08:51:05 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0Kx 08:51:14 <TrueBrain> there, that should normalize OpenGFX in terms of OpenTTD versioning schema 08:51:24 <TrueBrain> makes releasing a lot easier :) (more of the same == easier) 08:51:48 * andythenorth should eat breakfast 08:51:56 <TrueBrain> I agree 08:56:14 *** nielsm has joined #openttd 08:58:57 <andythenorth> moin nielsm 09:00:44 <nielsm> morn 09:12:20 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0Kx 09:13:52 *** Smedles_ has joined #openttd 09:14:23 *** Smedles has quit IRC 09:16:21 *** gelignite has joined #openttd 09:22:48 *** Smedles_ has quit IRC 09:24:03 *** Smedles has joined #openttd 09:28:42 *** snail_UES_ has quit IRC 09:29:25 *** tokai|noir has joined #openttd 09:29:25 *** ChanServ sets mode: +v tokai|noir 09:36:11 *** tokai has quit IRC 09:36:52 *** Samu has joined #openttd 09:41:19 <Samu> hi 09:41:35 *** Wolf01 has joined #openttd 09:41:46 <andythenorth> hi 09:43:09 <Wolf01> o/ 09:48:44 *** andythenorth is now known as Guest17190 09:48:54 *** andythenorth has joined #openttd 09:53:26 *** Guest17190 has quit IRC 10:29:13 <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick updated pull request #7937: Build on competitor canal https://git.io/JvUIQ 10:32:00 <Samu> who can look at https://github.com/OpenTTD/OpenTTD/pull/7947 10:49:31 *** Speedy` has joined #openttd 11:04:11 <milek7> TrueBrain: http://webster.openttdcoop.org/index.php?channel=openttd&date=1582329600#1582414499 11:15:31 *** frosch123 has joined #openttd 11:21:20 <Samu> i cant run regression, failed to find a graphic set message popup :( 11:29:14 <Samu> i used to be able to run regression test, now it errors :( 11:31:45 <andythenorth> hmm 11:31:53 <DorpsGek_III> [OpenTTD/OpenGFX] frosch123 commented on pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0X6 11:32:11 <andythenorth> I'm not checking if every single one of these water sprites needs the animated flag set (or not) 11:32:22 * andythenorth blanket sets the flag for certain cases 11:32:46 <frosch123> if the name says "water" it's plausible :) if the name says "house", I would check 11:33:27 <frosch123> [ad] are you using ttdviewer? 11:33:54 <Samu> aha, regression fails to find a graphic set because the installer put it in the wrong folder 11:34:04 <andythenorth> I am not using ttdviewer 11:34:17 <andythenorth> but yes, I'm setting anim falg for all of waterfeatures.png etc 11:34:21 <andythenorth> and not other things 11:34:26 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0XD 11:34:38 <andythenorth> if we eliminate the junk warnings, then we can attend to the actual warnings :P 11:39:24 <andythenorth> hmm 11:40:42 * andythenorth wonders if opengfx realsprites can't have the flags set 11:41:00 <TrueBrain> frosch123: suggestions to make it more clear are always welcome ofc :) The fact I have to explain tells me the code is not obvious, so any suggestions really are welcome :) 11:41:56 <TrueBrain> although it might be the diff that is confusing .. I change the use of Makefile.vcs .. possibly another name would make it more clear .. dunno 11:43:17 <andythenorth> nmlc ERROR: "./sprites/extra/extra-plus-rivers.pnml", line 158: Unrecognized identifier 'ANIM' encountered 11:43:25 <andythenorth> dunno what I'm missing :) 11:43:33 <TrueBrain> using the latest nmlc? :) 11:43:37 <TrueBrain> (as in, "master") 11:43:42 <andythenorth> I don't really write nml, I'm going by the docs 11:43:55 <andythenorth> yes I have absolute latest nml 11:44:10 <andythenorth> docs suggest this should be ok 11:44:11 <andythenorth> [ 338, 904, 19, 9, 14, 11, "sprites/png/terrain/waterfeatures.png", ANIM] 11:44:13 <frosch123> TrueBrain: is Makefile.vcs used at all? 11:44:14 <TrueBrain> just checking :) I also know nothing about how to write NML :) 11:44:22 <TrueBrain> frosch123: yes ... as dependency to know when to rebuild targets 11:44:26 <frosch123> i see that it is created, but i do not see where it is read 11:44:28 <TrueBrain> (as the comment mentions :P) 11:44:41 <frosch123> i see that .ottdrev is created, and used 11:44:45 <TrueBrain> "custom_tags.txt: Makefile.vcs" 11:44:46 <TrueBrain> for example 11:44:59 <TrueBrain> and 11:45:00 <TrueBrain> "%.obg: $(GFX_FILES) $(GRF_FILES) $(LNG_FILES) Makefile.vcs" 11:45:08 <TrueBrain> I see your grep-foo is failing on you :D <3 11:45:50 <frosch123> that's because i have not figured out how to view the whole file on gh, i only get a diff 11:46:08 <frosch123> i found the "..." 11:46:12 <TrueBrain> iles changed -> go to file -> click dots -> View file 11:46:34 <andythenorth> flags before filename maybe 11:46:37 * andythenorth tries 11:46:37 <TrueBrain> and really this is not you; this Makefile is just a bit oddly written. But I don't want to rebuild it completely :) 11:46:59 <TrueBrain> Makefile.vcs was always used to retrigger builds ... and help out for source-tarballs 11:47:11 * andythenorth is now an nml genius 11:47:18 <andythenorth> simply by reading docs, I was able to fix my error 11:47:27 <TrueBrain> .makefile_cache might be a better name? 11:47:34 <TrueBrain> andythenorth: gratz :) 11:48:08 <Samu> the installer installs the graphics set in the wrong folder 11:48:13 <frosch123> does the "Makefile.vcs not modified" work? I would expect make to rebuild everything everytime 11:48:33 <TrueBrain> read the Makefile.vcs: part careful: 11:48:34 <TrueBrain> $(_V) cmp -s $@.new $@ || cp $@.new $@ 11:48:34 <TrueBrain> $(_V) -rm -f $@.new 11:48:36 <TrueBrain> took me a while :P 11:48:38 <frosch123> since everything depends via "Makjefile.vcs" on "FORCE" 11:48:56 <TrueBrain> so it really does work :) 11:49:09 <frosch123> make is magical sometimes 11:49:20 <TrueBrain> yes; and this type of make is even a special category of magic :) 11:49:35 <TrueBrain> so tempted to rewrite to CMake :P 11:49:37 <TrueBrain> but .. I am not 11:49:40 <frosch123> ok, next question: you remove .version from .gitignore, do you want to add .ottdrev? 11:49:51 <TrueBrain> .ottdrev is only created in a folder that is already ignored 11:49:55 <TrueBrain> so no :) 11:50:05 <milek7> so.. i should make that xcf2png PR? 11:50:09 <TrueBrain> but good question, as I wondered about that too :) 11:50:12 <TrueBrain> milek7: yes 11:50:53 <DorpsGek_III> [OpenTTD/OpenGFX] frosch123 approved pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0Xj 11:50:59 <frosch123> out of questions to ask 11:51:11 <TrueBrain> not sure that is a good thing or not, but tnx for looking into this :) 11:51:17 <TrueBrain> I did my best to test it every way I could 11:51:40 <frosch123> well, the makefile looked like it uses directories as dependencies 11:51:50 <frosch123> many coop makefiles use that, and it is completely broken :) 11:52:09 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0Kx 11:52:10 <TrueBrain> it really is, yes 11:52:19 <TrueBrain> when CMake hits OpenTTD, we should revisit this 11:52:26 <TrueBrain> as it can share CMake files at that point, making this all a bit easier 11:53:26 <TrueBrain> but now first, lets make opengfx nightlies and releases :) 11:54:33 <TrueBrain> milek7: don't forget to change "xcf2png" into $(XCF2PNG) btw :) 11:56:27 <TrueBrain> milek7: with https://pastebin.com/raw/sE9J7UfK "ogfxe_extra.grf" still generates a different result btw 11:56:44 <milek7> hm 11:57:48 <TrueBrain> and I cannot start GIMP UI here, so I cannot test the thing you asked 11:59:21 <TrueBrain> if you want me to test anything, let me know :) 11:59:22 <Samu> it tries to load TRG1R.GRF, says it can't find it, then it crashes openttd on exit 11:59:38 <TrueBrain> (other than the UI thing .. :P) 11:59:41 <Samu> what the hell happened? 11:59:48 <Samu> i wasn't having problems building openttd 11:59:59 <Samu> suddenly, I am 12:01:50 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv013 12:04:56 <Samu> okay, i think i got it 12:05:11 <Samu> it's a problem related to where you install these files 12:05:39 <Samu> you are installing in C:\Program Files\OpenTTD\baseset 12:05:50 <Samu> but the config is somewhere else 12:06:04 <Samu> C:\Users\dj_sa\Documents\OpenTTD 12:06:51 <andythenorth> ok so opengfx compile doesn't support the nml realsprite flags 12:07:09 *** andythenorth has quit IRC 12:07:27 *** andythenorth has joined #openttd 12:07:27 <Samu> why is my username dj_sa? 12:07:30 <Samu> stupid windows 12:07:36 <TrueBrain> I have no idea what that means andythenorth :) 12:07:41 <Samu> ruining my good name 12:07:54 <andythenorth> TrueBrain: this is why we have docs :) 12:08:10 <andythenorth> TL;DR there are warnings in nml about bad things 12:08:18 <andythenorth> but sometimes the bad things are desirable 12:08:24 <andythenorth> so we have flags to suppress the warnings 12:08:38 <andythenorth> but opengfx compile is incompatible with the flags 12:08:52 <TrueBrain> how are they incompatible? :) 12:08:54 <andythenorth> for extra fun, this isn't discoverable if only using make 12:08:55 <frosch123> so you have an ancient nml in your path? how do you compile firs? 12:09:22 <andythenorth> but the problem occurs when make is run after make clean 12:09:25 *** HerzogDeXtEr has quit IRC 12:09:40 <andythenorth> there's a parser somewhere to generate png deps for make 12:09:46 *** HerzogDeXtEr has joined #openttd 12:09:56 <andythenorth> and it's position based, adding the flags makes it choke 12:10:11 * andythenorth hasn't looked more, running out of laptop battery :( 12:10:15 <frosch123> ah, more broken makefiles :) 12:10:28 <andythenorth> I'd complain, but have you seen mine? :P 12:10:44 <TrueBrain> so where should this ANIM be added normally? 12:11:03 <andythenorth> flags https://newgrf-specs.tt-wiki.net/wiki/NML:Realsprites 12:11:11 <TrueBrain> I am not asking about the specs 12:11:16 <TrueBrain> where were you trying to add ANIM that fails :) 12:11:24 <TrueBrain> I want to help you; not learn NML :) 12:11:37 <andythenorth> oh you want an example that fails? 12:11:47 <TrueBrain> that would help, yes 12:12:00 <andythenorth> I deleted all my changes trying to diagnose the issue 12:12:06 <andythenorth> I shall make redo and make a diff 12:13:27 <andythenorth> https://gist.github.com/andythenorth/4e15b007084838dd378ffee145a17b0d 12:13:31 <andythenorth> TrueBrain: ^ 12:13:55 <andythenorth> make clean, then make 12:14:02 <andythenorth> will fail with 12:14:02 <andythenorth> make: *** No rule to make target `ANIM,', needed by `ogfxe_extra.grf'. Stop. 12:14:46 <andythenorth> oops, I am supposed to be doing something else, BRB 12:15:01 <milek7> TrueBrain: no, result is the same 12:15:27 <milek7> except that building on clean repo gives '1 * 6454 14 "CINFOTNAME\" OpenGFX 0.5.5-17-g2c58f17" 00' 12:15:35 <milek7> and with patch '1 * 6460 14 "CINFOTNAME\" OpenGFX 0.5.5-17-g2c58f17-dirty" 00' 12:15:42 <TrueBrain> milek7: not sure where you are referencing too, sorry :( 12:15:48 <frosch123> haha, the rule for Makefile.gfx is funny 12:16:05 <frosch123> it scans for pcx or png, drops the fileextension, and readds png 12:16:09 <milek7> that new ogfxe_extra.grf is different 12:16:26 <TrueBrain> milek7: ah .. so it is expected to be different 12:16:31 <TrueBrain> fair enough 12:16:35 <TrueBrain> any way for me to validate that easily? 12:17:10 <TrueBrain> andythenorth: your patch works for me :o 12:17:14 <milek7> though this is weird it only comes up in extra grf 12:17:40 <TrueBrain> milek7: no, that is correct .. I remember only one NML file needing the NEWGRF_VERSION 12:17:45 <TrueBrain> so that is expected, now I come to think of it 12:18:51 <andythenorth> hmm 12:18:56 <andythenorth> mac specific make failures? 12:19:06 <TrueBrain> I also don't see how that error could happen 12:19:12 <TrueBrain> you sure you don't have any other pending changes? 12:19:30 <andythenorth> the diff is all of 'git diff' locallly 12:19:39 <TrueBrain> and git status doesn't show untracked files? 12:19:48 <andythenorth> nope 12:20:27 <andythenorth> it didn't manifest until I ran 'make clean' 12:20:59 <TrueBrain> can you upgrade to latest master, and try again? 12:21:18 <TrueBrain> owh, and remove your Makefile.gfx 12:22:00 <TrueBrain> given you run with GIMP=, there is a bug in Makefile that can cause shit like this :) 12:22:10 * andythenorth crosses fingers 12:22:18 <andythenorth> oof no same shit 12:22:39 <TrueBrain> make clean && rm -f Makefile.gfx && GIMP= make 12:23:13 * andythenorth crosses toes 12:23:22 <andythenorth> meh 12:23:29 <andythenorth> same shit 12:24:00 <andythenorth> it was pm and ammler who taught me that 'no errors may happen in compile' 12:24:12 <andythenorth> but this is probably why they never fixed the warnings 12:24:19 <TrueBrain> does Makefile.gfx have any content? 12:26:44 <TrueBrain> milek7: confirmed, with NEWGRF_VERSION set to 0, both GIMP and xcf2png result in the same grf with your patch 12:26:47 <TrueBrain> so PR it, and lets go :) 12:28:03 <TrueBrain> andythenorth: with your patch, I cannot find a path that results in that error. Not sure if anyone else can reproduce it? 12:28:13 <TrueBrain> the only reason I can think of, is if Makefile.gfx is not empty 12:28:45 <TrueBrain> and even than, you need to have more changes for this to happen .. not sure .. 12:29:34 <andythenorth> TrueBrain: re. Makefile.gfx, using the command you pasted above, it isn't generated locally 12:29:54 <TrueBrain> hmm, nothing is cleaning up .dep files 12:29:56 <TrueBrain> so that might be a reason too 12:30:06 <TrueBrain> rm -f *.dep 12:30:08 <TrueBrain> and try again 12:30:29 <TrueBrain> if at any point nml produced invalid dep files, it will remain broken, basically 12:30:50 <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick opened issue #8018: Visual Studio/OpenTTD Baseset installation folder vs Regression build https://git.io/Jv017 12:30:54 <andythenorth> TrueBrain: sorted 12:30:59 <TrueBrain> that fixed it? 12:31:02 <Samu> i think this was not worth reporting, but... 12:31:06 <andythenorth> removing .deps fixed it 12:31:17 <TrueBrain> k; so it was because of your earlier attempts :) 12:31:24 <TrueBrain> lets see why 'clean' doesnt remove those files .. 12:31:32 * andythenorth GTG 12:31:34 <andythenorth> but thx 12:31:36 <TrueBrain> np 12:31:44 <andythenorth> I'll come back later and fix more warnings 12:31:47 *** andythenorth has quit IRC 12:35:47 <DorpsGek_III> [OpenTTD/OpenGFX] Milek7 opened pull request #26: Change: Use xcf2png instead of GIMP https://git.io/Jv0MU 12:37:37 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #27: Fix: [Makefile] make sure 'make clean' cleans all generated files https://git.io/Jv0Mk 12:37:45 <TrueBrain> and that should fix andy's issue for good 12:39:25 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #26: Change: Use xcf2png instead of GIMP https://git.io/Jv0MY 12:39:42 <TrueBrain> I guess we really should fix up that Makefile.gfx :P 12:40:18 <TrueBrain> it is so silly and unneededly slow 12:40:29 <TrueBrain> but that is something for another PR :) 12:40:44 <TrueBrain> do I dare to merge that PR ... do I know enough about this stuff ... it "looks okay" :P 12:42:43 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #28: Remove: [Makefile] documentation is now supplied, no longer generated https://git.io/Jv0Mn 12:44:09 <DorpsGek_III> [OpenTTD/OpenGFX] Milek7 updated pull request #26: Change: Use xcf2png instead of GIMP https://git.io/Jv0MU 12:44:44 <DorpsGek_III> [OpenTTD/OpenGFX] Milek7 updated pull request #26: Change: Use xcf2png instead of GIMP https://git.io/Jv0MU 12:44:58 <TrueBrain> was about to ask about the README :) 12:45:06 <TrueBrain> nice :) 12:45:33 <milek7> uh.. does xcf2png exists on windows? 12:45:45 <TrueBrain> oh-oh ..... 12:46:54 <TrueBrain> fucking windows :P 12:47:08 <TrueBrain> mingw? 12:47:31 <TrueBrain> its in cygwin 12:48:33 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #26: Change: Use xcf2png instead of GIMP https://git.io/Jv0M0 12:48:34 <milek7> xcftools sources contains "# FIXME: the MSVC++ port hasn't been tested in a loooong time" 12:48:51 <TrueBrain> yeah, but cygwin has it in its package list, so that should be fine I guess 12:50:19 <TrueBrain> you should ask glx when he comes online to check it out :) 12:51:52 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #28: Remove: [Makefile] documentation is now supplied, no longer generated https://git.io/Jv0Mn 12:53:57 <milek7> also when saving these .xcf in gimp 2.10 it is necessary to uncheck "Save this XCF file with better compresson" 12:54:03 <milek7> it probably should go into readme too 12:54:13 <TrueBrain> please do :) 12:56:08 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #28: Remove: [Makefile] documentation is now supplied, no longer generated https://git.io/Jv0Mn 13:00:59 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #29: Fix: [Makefile] tell the user he needs to install grfcodec if grfid is not found https://git.io/Jv0Mx 13:01:09 <TrueBrain> okay, these PRs should fix the andy-factor :) 13:01:46 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #29: Fix: [Makefile] tell the user he needs to install grfcodec if grfid is not found https://git.io/Jv0Mp 13:02:02 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #28: Remove: [Makefile] documentation is now supplied, no longer generated https://git.io/Jv0Mh 13:02:05 <TrueBrain> LordAro: stop tempting me to rewrite this shit in CMake :P 13:02:09 <LordAro> ^^ 13:02:51 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #28: Remove: [Makefile] documentation is now supplied, no longer generated https://git.io/Jv0Mn 13:03:10 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #27: Fix: [Makefile] make sure 'make clean' cleans all generated files https://git.io/Jv0De 13:03:23 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #27: Fix: [Makefile] make sure 'make clean' cleans all generated files https://git.io/Jv0Mk 13:07:26 <TrueBrain> milek7: https://github.com/j-jorge/xcftools/ seems to be the new source for xcftools 13:07:29 <TrueBrain> at least Debian switched to there 13:08:25 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #29: Fix: [Makefile] tell the user he needs to install grfcodec if grfid is not found https://git.io/Jv0Mx 13:21:02 <milek7> xcftools is neither in homebrew or macports 13:32:57 *** APTX_ has quit IRC 13:41:39 * _dp_ played with firs and cargodist yesterday, remembered why I don't like either of them 13:42:21 *** blathijs has joined #openttd 13:42:51 <TrueBrain> milek7: that might be a bit of a problem :( 13:43:12 <blathijs> TrueBrain: LordAro: milek7: Are you guys coding as crazy on OpenGFX today, or are all those PRs migrated from somewhere? 13:43:42 <TrueBrain> blathijs: you sound surprised :P 13:43:51 <TrueBrain> but yeah, I wrote all of those in the last 24 hours :) 13:44:01 <TrueBrain> there was a bit of dust on top of it :P 13:44:17 <TrueBrain> now the real work can start ... 13:44:19 <blathijs> Nice :-) 13:44:49 <TrueBrain> copyright still reads 2016 .. think that says it all :D 13:45:11 <blathijs> It just seems like a lot more than I can usually get done in 24h, so kudos :-p 13:45:26 <TrueBrain> it really is not that much tbh .. just Makefile shit 13:46:17 <TrueBrain> but tnx :) 13:46:26 <TrueBrain> hopefully I didn't break any of your debian magic :D 13:51:57 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on issue #8018: Visual Studio/OpenTTD Baseset installation folder vs Regression build https://git.io/Jv017 13:54:04 *** APTX has joined #openttd 13:56:14 *** sla_ro|master has quit IRC 13:57:16 *** glx has joined #openttd 13:57:16 *** ChanServ sets mode: +v glx 13:58:33 *** sla_ro|master has joined #openttd 14:17:39 <Samu> _dp_ https://www.tt-forums.net/viewtopic.php?f=33&t=73469&start=2620 have you figured the problem? 14:18:13 <_dp_> Samu, nope 14:18:37 <_dp_> I can imagine few ways it could go wrong in jgr's patchpack but not in vanilla 14:18:37 <Samu> if only that savegame was useful 14:18:46 <Samu> oh 14:20:14 <_dp_> either amount > 256 or owner > OWNER_NONE can break it 14:20:31 <_dp_> but doesn't seem to be the case in vanilla 14:21:04 <_dp_> though adding those as asserts is probably not a bad idea 14:23:08 <Samu> more than 256, hmm some big industry? 14:23:34 <_dp_> afaict it's capped at 255 everywhere 14:24:01 <Samu> gonna test 14:24:09 <Samu> with the cheat menu 14:25:04 <Samu> what about those industries that transform cargo 14:25:29 <Samu> if i deliver 9000 at once how it's transforming it? 256 capped? I doubt it 14:26:25 <_dp_> it's probably capped even more on unload 14:27:27 <_dp_> typical cargo packet is like 5 units only 14:28:32 <Samu> hmmm let me set up a scenario 14:47:19 *** Flygon has quit IRC 14:54:23 <Samu> im so bad at setting up train networks :p 15:12:49 <Samu> trying my best to make that assert trigger, seems like it won't 15:14:15 <Samu> jgr says he was able to look at the savegame 15:14:19 <Samu> hmm :( 15:15:53 <Samu> but i couldn't 15:24:10 <Samu> okay, scenario is set up 15:24:30 <Samu> i could get some forest to produce 255 units 15:24:48 <Samu> i wanted to get the lumber mill instead 15:28:06 <Samu> ok 430 15:28:17 <Samu> but it splits to a min of 255 15:28:22 <Samu> so, you're right 15:36:44 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #30: Add: [Actions] publish on new tag (release) and every night (nightly) https://git.io/Jv09m 15:37:06 <TrueBrain> I think this is it ^^ .. but it currently is being tested on a schedule of every 5 minutes ... this is going to take a while to verify :D 15:39:49 <TrueBrain> cache is not supported with schedule .. wtf .. lol 15:41:16 *** APTX_ has joined #openttd 15:43:40 <glx> as xcf2png doesn't seem to be available on windows I tried to use imagemagick, but it seems imagemagick doesn't support indexed gimp files 15:45:16 *** APTX has quit IRC 15:47:24 <TrueBrain> glx: seems cygwin does have a version available; but I believe milek7 said OSX also doesn't have it 15:47:28 <TrueBrain> so it might not be a good fit after all :( 15:48:04 <TrueBrain> right, so caching only works for 'push' and 'pull_request'... so how do I know if we already build an OpenGFX version .. hmmmmmmmm 15:49:47 <Samu> what's the maximum value of uint 15:50:30 <glx> 2^16-1 15:50:31 *** gelignite_ has joined #openttd 15:51:05 <Samu> @calc 255*256*255*255 15:51:05 <DorpsGek> Samu: 4244832000 15:51:15 <glx> silly me uint is 32 bits 15:51:24 <glx> so 2^32-1 :) 15:51:27 <Samu> @calc 2 ** 32 -1 15:51:27 <DorpsGek> Samu: Error: Something in there wasn't a valid number. 15:51:33 <Samu> @calc 2 ** 32 - 1 15:51:33 <DorpsGek> Samu: 4294967295 15:52:10 <Samu> so it fits 15:52:16 <Samu> barelly, but still fits 15:52:54 <TrueBrain> facepalm 15:53:17 <LordAro> funnily enough, just less than 2**16 * 4 is less than 2**32 15:53:19 <TrueBrain> lets pretend we did not see someone calculate that 255 256255*255 fits in a 32bit unsigned integer .. 15:53:40 <TrueBrain> without the typos, ofc 15:54:11 *** gelignite has quit IRC 15:54:26 <Samu> I'm checking for overflow 15:54:32 <Samu> it doesn't overflow 15:54:52 <Samu> @calc 256*256*255*255 15:54:52 <DorpsGek> Samu: 4261478400 15:55:01 <Samu> @calc 257*256*255*255 15:55:01 <DorpsGek> Samu: 4278124800 15:55:15 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #30: Add: [Actions] publish on new tag (release) and every night (nightly) https://git.io/Jv09m 15:55:33 <TrueBrain> you are seriously surprised that 255**3 * 256 doesn't overflow 256 ** 4 ? Really? :) 15:55:52 <dwfreed> Samu: 255 is an 8 bit unsigned integer; 4 8 bit unsigned integers multiplied together will always fit within a 32 bit unsigned integer 15:55:52 <LordAro> TrueBrain: ah, but this is 255*2 * 256 * 257 15:55:55 <LordAro> totally different 15:56:01 <dwfreed> not really 15:56:02 <LordAro> ** * 15:56:55 <Samu> @calc 258*256*255*255 15:56:55 <DorpsGek> Samu: 4294771200 15:57:04 <Eddi|zuHause> (256+1)*(256-1) = (256)^2 - 1 (binomial rule) 15:57:07 <TrueBrain> please take this in a private message with DorpsGek 15:57:11 <TrueBrain> I have no interest in you cracking math 15:58:01 <Samu> 258 is the maximum amount before it overflows 15:58:05 <Samu> _dp_ 15:58:19 <Samu> if you want to add an assert there 15:59:15 <TrueBrain> okay, this GitHub Actions PR is tested as good as I could .... now it is up to real-world testing :P 15:59:20 <TrueBrain> testing Actions in forks remains difficult 15:59:39 <TrueBrain> upload to S3 works, files are what I expect, all triggers work 15:59:57 <TrueBrain> fingers crossed 16:02:22 <Samu> i could get an industry produce 430 cargo, but it then goes over a min(430, 255), so the amount is 255 16:02:43 <Samu> maybe the problem can come from houses producing passengers? 16:06:26 <TrueBrain> if this PR is merged, OpenGFX is very similar to website in the way GitHub works. And very similar to OpenTTD binaries in the way it rebuilds the website etc. The only thing that is not fixed, is the NSIS installer. That still needs manual love and care 16:06:42 <TrueBrain> hopefully I didn't miss anything :D 16:06:51 *** snail_UES_ has joined #openttd 16:07:03 *** APTX_ has quit IRC 16:07:41 <Samu> town_houses have this: uint amt = GB(callback, 0, 8); 16:07:50 <Samu> that's a max of 255 too 16:08:03 <glx> yes it's 8 bits :) 16:09:20 <TrueBrain> owh, hmm ... a new tagged OpenGFX won't also be uploaded to BaNaNaS automagically 16:09:38 <TrueBrain> things for later additions, I am sure :P 16:09:52 <TrueBrain> ugh .. I really have to move BaNaNaS before 1st of April ... hmmmmmmmm 16:09:53 *** APTX has joined #openttd 16:10:05 <glx> yeah shoul be doable to use musa in this case 16:10:30 <Samu> headquarters code: uint amt = GB(r, 0, 8) / 8 / 4 + 1; 16:10:40 <TrueBrain> I should have used deployments, I now realise .. would make things a bit easier .. 16:10:49 <glx> Samu: clearly < 255 16:11:43 <TrueBrain> owh well, that too, for later updates :) 16:12:11 <TrueBrain> can't fix it all at once 16:13:52 <Samu> that's 8 16:14:03 <DorpsGek_III> [OpenTTD/OpenGFX] glx22 commented on pull request #26: Change: Use xcf2png instead of GIMP https://git.io/Jv09P 16:14:05 <Samu> well, then, it's jgr's fault :p 16:18:12 *** andythenorth has joined #openttd 16:20:09 <andythenorth> o/ 16:22:43 <Samu> who can decipher this code, line 581 town_cmd.cpp, can u check whether amt is always 258 or less? 16:23:16 <Samu> before MoveGoodsToStation is called 16:23:27 *** Wormnest has joined #openttd 16:23:48 *** Wormnest has quit IRC 16:26:10 *** Wormnest has joined #openttd 16:29:38 <milek7> TrueBrain: it seems it was rejected in homebrew because it was unmaintained 16:29:40 <milek7> https://github.com/Homebrew/homebrew-core/pull/1216 16:29:52 <milek7> maybe we could retry with j-jorge fork 16:47:04 <andythenorth> hmm opengfx has me puzzled 16:47:18 <andythenorth> nvm 16:47:57 *** snail_UES_ has quit IRC 16:57:57 <frosch123> hmm, this graphql query is an escaping hell 16:58:04 <frosch123> i should just ban users with " in their name 16:59:22 <frosch123> hmm, graphql seems to have its own variable stuff 17:05:25 <Samu> okay, 32 is max value 17:05:48 <Samu> with linear passenger 17:06:12 <Eddi|zuHause> frosch123: just base64-encode all names? 17:08:49 <Samu> it's also 32 with quadratic 17:09:46 <Samu> only newgrf houses can set this value all the way to 255 17:11:17 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 updated pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/fhbqc 17:14:08 <_dp_> Samu, do you realize you just wasted two screens of chat just to repeat what I said in a single sentence? ;) 17:14:11 <_dp_> <_dp_> afaict it's capped at 255 everywhere 17:14:38 <Samu> oh, I realise now 17:27:03 <andythenorth> how do I mark a PR as draft? 17:27:24 <nielsm> click the arrow next to the create button 17:27:42 <andythenorth> thx 17:29:46 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth opened pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 17:30:52 <Samu> i just got a case where amount == moving, perfect round numbers 17:31:54 <Samu> @calc 1564*91*91/91/161 17:31:54 <DorpsGek> Samu: 884 17:32:25 <Samu> @calc 1564*91*70/91/161 17:32:25 <DorpsGek> Samu: 680 17:33:32 <Samu> @calc 884+680 17:33:32 <DorpsGek> Samu: 1564 17:35:27 <Samu> I wonder if a*b*c/d/e is different than a*b*c/(d*e) 17:35:28 <TrueBrain> Last time Samu, take this in a PM with DorpsGek 17:35:31 <Samu> in integer 17:37:01 *** Wolf01 has quit IRC 17:38:12 *** tokai has joined #openttd 17:38:12 *** ChanServ sets mode: +v tokai 17:42:03 <glx> it may be different with roundings 17:43:06 <_dp_> glx what? no 17:43:16 <_dp_> probably even true for negative numbers 17:44:14 <Samu> they're uint 17:44:41 <Samu> well, not quite, but they're all positive 17:45:11 *** tokai|noir has quit IRC 17:46:29 <Samu> c is a byte 17:54:03 <andythenorth> oh 17:54:07 <andythenorth> airports have animated pixels eh? 17:54:17 <glx> yeah the lights andythenorth 17:54:21 * andythenorth has to play with full animation off 17:54:25 <andythenorth> I never see all this stuff 17:57:14 <Eddi|zuHause> there are four lights. 17:57:25 <glx> andythenorth: and you could use a task list instead of a bulleted list 17:58:18 <andythenorth> hurrah 17:58:22 <andythenorth> done that now thx 18:01:32 <Eddi|zuHause> things with animated pixels include, but not limited to: airport, steel works, theatre, modern stadium, lighthouse, water 18:01:49 <glx> level crossings 18:02:05 <andythenorth> FIRS! 18:02:08 <andythenorth> HEQS! 18:02:15 <andythenorth> all the ships I've drawn (animated wake) 18:04:35 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 18:05:59 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 18:16:28 *** Wormnest has quit IRC 18:19:36 *** WormnestAndroid has quit IRC 18:21:15 *** WormnestAndroid has joined #openttd 18:26:16 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 18:28:16 <Samu> doing something crazy as this https://pastebin.com/fPZWVGLG 18:28:48 <Samu> now i'm starting 14 AIs and gonna dinner, waiting for a possible assert 18:29:48 <Samu> probably it will never come 18:30:13 <Samu> oh, still early for dinner 18:35:50 <TrueBrain> so who wants to review some GitHub Actions code? https://github.com/OpenTTD/OpenGFX/pull/30 ? Before 2100 pretty please? :D (no clue what timezone 2100 :P) 18:36:07 <TrueBrain> ah, UTC 18:36:15 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 18:37:17 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #30: Add: [Actions] publish on new tag (release) and every night (nightly) https://git.io/Jv077 18:37:27 <Samu> TrueBrain, this branch shouldn't exist, or should it? https://github.com/OpenTTD/OpenTTD/tree/improve-buildveh-doc 18:37:51 <TrueBrain> LordAro: that was either a very quick review, or a .. dunno what that was :P 18:37:52 <TrueBrain> tnx 18:37:52 <Samu> it's in the upstream 18:38:02 <LordAro> Samu: yes, that can be deleted now 18:38:10 <LordAro> i created a PR with it accidentally 18:38:10 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #30: Add: [Actions] publish on new tag (release) and every night (nightly) https://git.io/Jv09m 18:38:17 <andythenorth> this has a lot of animated pixels in it https://github.com/OpenTTD/OpenGFX/blob/master/sprites/png/gui/highscore.png 18:38:18 <LordAro> TrueBrain: bit of both :p 18:38:26 <andythenorth> from y =1264 onwards (colour newspaper) 18:38:29 <Samu> it's on your side 18:38:32 <andythenorth> not sure why that would be, might be a bug? 18:38:38 <TrueBrain> and now we wait to see if it works ... I AM SO EXCITED 18:38:40 <TrueBrain> I JUST CANT HIDE IT 18:38:46 * andythenorth back to fixing the other 50 or so warnings 18:38:53 <andythenorth> I've done a few hundred now 18:38:59 <TrueBrain> nice andythenorth :) 18:39:04 <Samu> i can't delete stuff in the upstream LordAro 18:39:05 <TrueBrain> and yeah, you would not expect them in highscore :P 18:39:13 <andythenorth> nobody reported it? 18:39:18 <LordAro> Samu: i wasn't suggesting you should :p 18:39:27 <TrueBrain> who has full animation on anyway :P 18:39:59 <LordAro> i do, but i've never spotted any animation when the highscore appears before 18:41:49 <Samu> ah, it's gone, thx LordAro 18:42:56 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 18:43:20 <frosch123> the animation looks fancy 18:43:32 <frosch123> fireworks on the daily news 18:43:47 <TrueBrain> animated gif? :D 18:43:59 <frosch123> hmm, is that sprite even used? 18:44:10 <frosch123> i only remember the newspaper and the highscore screen 18:44:16 <LordAro> i was wondering about the second news paper... 18:44:19 <frosch123> but the anim pixels are in the third picture 18:44:47 <frosch123> let's start a game in 2050 18:45:13 <TrueBrain> andythenorth: "template tmpl_level_ground_file(x, y, ANIM_FLAG, file) {" <- is that really ANIM_FLAG, or just FLAG? (question out of curiosity) 18:45:15 <andythenorth> we could make nml report which palette indexes are animated 18:45:27 <andythenorth> TrueBrain: it could be FLAG 18:45:29 <andythenorth> strictly 18:45:38 <andythenorth> or FLAGS 18:45:49 <DorpsGek_III> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/Jv05Z 18:45:49 <DorpsGek_III> - Update: Translations from eints (by translators) 18:46:01 <TrueBrain> ty eints 18:46:02 <andythenorth> it's a potato / potato type situation 18:46:13 <TrueBrain> it reads a bit funky now, ANIM_FLAG 18:46:20 <TrueBrain> like it isn't the flag, but it looks like it, or something :) 18:46:43 <andythenorth> wow the toyland statue sprite 18:46:53 * andythenorth has to restrain 'wtf' 18:47:05 <TrueBrain> animated gif or it didn't happen! :P 18:48:42 <Samu> this integer math is still not asserting! assert(a*b*c/d/e == a*b*c/d*e); 18:48:53 <Samu> afk dinner 18:49:02 <andythenorth> https://github.com/OpenTTD/OpenGFX/blob/master/sprites/png/houses/toyland_statue_sprite270.png TrueBrain 18:49:05 *** tokai|noir has joined #openttd 18:49:05 *** ChanServ sets mode: +v tokai|noir 18:49:32 <frosch123> ah, you only get the third newspaper if you have max score 18:49:42 <frosch123> so, noone ever got max score :) 18:49:45 <TrueBrain> lol @ andythenorth , that is nice :) 18:49:54 <TrueBrain> pfft, max score is for the weak 18:50:46 <LordAro> aha 18:50:52 <LordAro> andythenorth: that is certainly a thing 18:51:24 <frosch123> andythenorth: hard to tell whether intentional :) 18:51:37 <frosch123> the eyes use the water cycle 18:51:47 <andythenorth> wow 18:52:00 <frosch123> unnoticeable without zooming in 18:52:06 <andythenorth> seeing that would require me to (1) use ogfx (2) play toyland (3) use 4x zoom :P 18:52:12 <andythenorth> (4) actually care :P 18:52:15 <LordAro> would suggest unintentional 18:52:26 <frosch123> i vote for "keep as easteregg" 18:52:38 <LordAro> for sure 18:52:40 <LordAro> :) 18:52:52 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 18:53:54 <Eddi|zuHause> frosch123: as in "wait until someone actually reports it as a bug"? :p 18:53:59 <andythenorth> ok 18:54:14 <andythenorth> https://github.com/OpenTTD/OpenGFX/pull/31 LordAro 18:54:39 <DorpsGek_III> [OpenTTD/workflows] TrueBrain opened pull request #5: Add: [CDN] opengfx-nightlies is now also published on the CDN https://git.io/Jv05u 18:55:20 <DorpsGek_III> [OpenTTD/workflows] LordAro approved pull request #5: Add: [CDN] opengfx-nightlies is now also published on the CDN https://git.io/Jv05z 18:55:22 <frosch123> http://devs.openttd.org/~frosch/toyland_statue.mp4 <- it's not the fire cycle 18:55:30 <DorpsGek_III> [OpenTTD/workflows] TrueBrain merged pull request #5: Add: [CDN] opengfx-nightlies is now also published on the CDN https://git.io/Jv05u 18:55:39 <TrueBrain> damn you are quick this weekend LordAro :) Tnx again 18:55:58 *** tokai has quit IRC 18:56:07 <LordAro> TrueBrain: simple stuff is easy :p 18:56:18 <LordAro> and i'm only otherwise watching youtube 18:57:45 <TrueBrain> I finished youtube; the end is a bit meh 18:59:26 <DorpsGek_III> [OpenTTD/website] TrueBrain opened pull request #151: Add: opengfx-nightlies is now available as binaries too https://git.io/Jv05o 18:59:38 <TrueBrain> well, "now" .. when ever 2100 UTC hits :P 19:00:01 <frosch123> sell stocks? now? 19:00:11 <TrueBrain> wait, we have stocks?! 19:00:29 <DorpsGek_III> [OpenTTD/website] LordAro approved pull request #151: Add: opengfx-nightlies is now available as binaries too https://git.io/Jv056 19:00:55 <frosch123> we have foreign currencies 19:01:04 <TrueBrain> I did not expect that I had to change so many places to add a new type of download; that needs improving :) 19:01:05 <frosch123> brittish pounds and such 19:01:31 <andythenorth> toyland sugar mine, the sugar stockpile tiles have animated (puddles of water?) 19:01:35 <andythenorth> intentional we think? 19:01:38 <Eddi|zuHause> how long until we need a feature to switch away from €? 19:01:45 <LordAro> TrueBrain: requiring adding a file containing "--\n--\n" does seem a bit unnecessary 19:01:57 <TrueBrain> LordAro: I agree; but otherwise Jekyll will bark 19:02:03 <TrueBrain> pretty sure that should be solvable :P 19:02:07 <LordAro> mm 19:02:28 <TrueBrain> {{ "No download-meta entry found for " | append: raw_type | raise_error }} 19:02:46 <TrueBrain> guess it is a safe-guard for: DONT FUCK UP NOW 19:02:54 <TrueBrain> owh well, adding new types is not a common thing 19:03:02 <DorpsGek_III> [OpenTTD/website] TrueBrain merged pull request #151: Add: opengfx-nightlies is now available as binaries too https://git.io/Jv05o 19:03:35 * andythenorth decides sugar mine can stay animated 19:03:57 <andythenorth> probably a decision better made by someone who cares, but eh :) 19:03:59 <andythenorth> I have the code open :P 19:04:12 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #8017: Codechange: Limit field width to avoid sscanf crash https://git.io/Jv059 19:04:37 <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #8017: Codechange: Limit field width to avoid sscanf crash https://git.io/JvRs5 19:04:58 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 19:05:19 <DorpsGek_III> [OpenTTD/website] TrueBrain created new tag: 1.3.3 https://git.io/Jv05Q 19:05:29 <frosch123> TrueBrain: do ogfx releases also publish to the location where the installer downloads them? 19:05:36 <TrueBrain> frosch123: no 19:05:50 <TrueBrain> two things that are currently not automated: NSIS and BaNaNaS 19:06:29 <frosch123> ok, tasks for future people :) 19:06:56 <TrueBrain> yeah ... BaNaNaS should be easy 19:06:59 <TrueBrain> NSIS .... it really is a pain 19:07:17 <TrueBrain> so I think we have to make a small nginx docker listening on installer.openttd.org, redirecting the installers to the right OpenGFX or something 19:07:28 <TrueBrain> or, maybe even better ..... drop NSIS installing OpenGFX 19:07:31 <TrueBrain> and let the bootstrap do it 19:07:48 <TrueBrain> it is a shitty solution for a shitty problem tbh :P 19:07:52 *** Progman has joined #openttd 19:08:01 <LordAro> bootstrap is there for a reason, seems reasonable to me 19:08:22 <TrueBrain> guess bootstrap also needs to kick in on startup of a new version, or something 19:08:41 <TrueBrain> as that is now a bit iffy, when you start, say, 1.10, it still runs on your older OpenGFX .. when are you going to notice :) 19:08:41 <LordAro> ? 19:08:51 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 19:08:54 <TrueBrain> not everyone updates all the BaNaNaS files all the time 19:08:57 <LordAro> bootstrap (afaik) kicks in whenever it detects no graphics set at all 19:09:01 <TrueBrain> yes 19:09:10 <LordAro> if you have a graphics set, you can use content download to update it 19:09:11 <TrueBrain> so the diference with NSIS is, that if you install 1.10, you get OpenGFX 0.5.6 too 19:09:15 <TrueBrain> otherwise .. you might still run 0.5.2 19:09:35 <TrueBrain> so how do people that don't know about the content download stuff know what to do :) 19:10:07 <LordAro> change the "missing sprites" warning to make it more obvious? 19:10:18 <LordAro> perhaps even highlight the button 19:10:20 <TrueBrain> or make the "missing sprites" warning more like the bootstrap :) 19:10:37 <TrueBrain> but if we can solve that tiny puzzle, we can just kick this functionality out of NSIS 19:10:41 <TrueBrain> that would make many things a lot better :P 19:11:19 <TrueBrain> "We noticed there are missing sprites; this can most likely be fixed by downloading the latest OpenGFX. Downloads yes / no?" 19:12:00 <TrueBrain> or possibly even better, when you startup: there are 19 updates. Do you want to download them? 19:12:04 <TrueBrain> yes / no / ignore 19:12:11 <andythenorth> nobody ever reported the bad animated pixels in toyland ships :) 19:14:00 <LordAro> TrueBrain: not sure i like the idea of making OGFX "special" in that way 19:14:12 <TrueBrain> I didn't mean special in any way 19:14:16 <LordAro> "there are x updates" could be good 19:14:22 <TrueBrain> just: missing sprites? baseset has update? allow updating 19:14:26 <TrueBrain> no need to special case OpenGFX :) 19:14:33 <LordAro> ok yes, that would be fine :) 19:15:34 <TrueBrain> but I guess best would be: did OpenTTD version change since last time? Are there any online updates? Ask to update! 19:15:35 <frosch123> andythenorth: i played a lot of ogfx toyland, but i also did not notice the sugar mine 19:15:41 <frosch123> it's not that easy to spot 19:15:50 <andythenorth> it's probably intended I think? 19:15:57 <LordAro> "did OTTD version change since last time" could be tricky to do in a cross platform way... 19:16:14 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 19:16:27 <TrueBrain> LordAro: "openttd.cfg" entry? :) 19:16:33 <andythenorth> this ogfx fixing is dull, but very satisfying 19:16:44 <TrueBrain> anyway .. not something I will be working on :D 19:16:56 <TrueBrain> my next focus really is going to be: port BaNaNaS .... :) 19:17:01 <TrueBrain> owh, no: teams! 19:17:02 <TrueBrain> for eints :) 19:17:18 <FLHerne> andythenorth: I don't think anyone knows or cares what Toyland vehicles look like? 19:17:31 <andythenorth> can't argue with that :) 19:17:50 <TrueBrain> you can at least try!!! :( 19:18:15 <frosch123> andythenorth: toyland ships do not look intentional 19:18:21 <FLHerne> "the bizarre toyland statue with animated eyes" <- lol 19:18:22 <frosch123> it's way to irregular 19:18:25 <andythenorth> frosch123: they're not :) 19:18:27 <andythenorth> I fixed 19:20:11 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 19:24:28 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 19:28:20 <LordAro> not clear why the commit checker is failing... 19:28:45 <LordAro> unless there's a leading space on one of the commits? 19:29:03 <TrueBrain> pretty sure he did something weird :P 19:29:05 <LordAro> would be good to get the commit checker to output the failing commit 19:29:21 <TrueBrain> the last one in this case; the one before passed :P 19:29:28 <TrueBrain> but I agree :) 19:29:44 <LordAro> https://github.com/OpenTTD/OpenGFX/commit/56fe3d44bcc7debcab6d7121ca9db6cb33fad75c.patch 19:29:46 <andythenorth> nobody reported the flashing skyscraper in Tropic either 19:29:47 <LordAro> yeah, leading space 19:29:47 <andythenorth> lol 19:29:59 <frosch123> i think there are some PRs for the commit-checker 19:30:02 <TrueBrain> fixing bugs, nice work andythenorth :) 19:30:14 <andythenorth> boom boom 19:30:20 <LordAro> andy "animation overload" thenorth 19:30:25 <LordAro> overlord* 19:30:33 <LordAro> actually, the first is better 19:33:11 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 19:33:57 <andythenorth> LordAro: you subtly edited the issue I see :P 19:34:19 <LordAro> andythenorth: *whistles* 19:34:26 <andythenorth> I guess I slandered you, sorry :) 19:34:37 <LordAro> :p 19:36:48 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 19:39:17 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 19:39:45 <andythenorth> ready for review ^ 19:39:51 <andythenorth> the remaining errors are genuine afaict 19:39:56 <andythenorth> I've fixed the trivial ones 19:39:58 <Samu> i have a suggestion for 1.10 19:40:12 <andythenorth> there's a skyscraper which is just broken, and needs redrawn 19:40:19 <Samu> station.serve_neutral_industries defaulted to off for 1.10 19:40:22 <andythenorth> and there's the weird max score newspaper annual thing 19:41:54 <andythenorth> not sure how you'll review it but eh :O 19:41:56 <frosch123> some toyland houses are well animated 19:42:00 <andythenorth> I picked the easy job 19:42:09 <andythenorth> frosch123: the one with the 'BAR' sign? 19:42:17 <andythenorth> and there's COLA 19:42:22 <frosch123> yep, TOY COLA 19:42:49 <andythenorth> this is good https://github.com/OpenTTD/website/pull/151 19:43:17 <andythenorth> so I still haven't done the actual nrt sprites in ogfx :P 19:45:50 <frosch123> ah, the scyscraper is in tropical 19:45:54 <frosch123> not toyland 19:46:07 <peter1138> Hmm, I really need to get myself a shot measure. 19:46:22 <peter1138> "I'll finished that bottle off, there's not much left." 19:46:50 <andythenorth> I don't mind fixing the skyscraper, but it might be a separate commit 19:57:26 <Samu> peter1138, can you station.serve_neutral_industries defaulted to off for 1.10 19:57:56 <Samu> or is it too late 20:12:34 <LordAro> peter1138: oh no 20:16:53 <glx> no it defaults to on for a good reason 20:18:09 <glx> it also removes the ugly "let's walk a train station to the oil platform" hack 20:20:09 <Samu> that's when it's off 20:20:37 <glx> yes that's why it's on :) 20:20:57 <Samu> uh? I'm confused 20:21:36 <glx> when it's on you don't need to walk the train station, as the train station won't get anything 20:23:34 <Samu> train stations don't get anything if the setting is off 20:23:47 <Samu> i think it's the opposite 20:29:10 <peter1138> LordAro, I accidentally a bottle of Drambuie, in 2 weeks, I think. I hope. O_o 20:29:43 <peter1138> (That's too short, but the alternative is, er, just this weekend, which I find unlikely but you never know...) 20:30:10 <LordAro> how much of this weekend can you remember? 20:30:31 <glx> Samu: ah right default is true, I think it should be false 20:31:17 <glx> when loading a game it's true, but that's expected to not break existing games 20:31:45 <_dp_> there are bunch of "wrong" defaults 20:33:00 <_dp_> like 90deg turns 20:36:13 <Samu> savegames are converted to have it on with afterload 20:38:23 <peter1138> LordAro, all of it, heh. 20:38:33 <LordAro> peter1138: probably not just this weekend then :p 20:39:51 <andythenorth> reddit has declared 90deg turns to be wrong 20:40:11 <andythenorth> if you want trains stuck in terminus stations, go ahead, turn off 90deg turns :P 20:40:27 <Samu> for (byte c = 1; c <= 255; c++) { bla; } 20:40:34 <Samu> weird stuff with byte stuff 20:40:39 <LordAro> andythenorth: for new saves, i don't think it's an issue 20:40:52 <Samu> when c is 255, it doesn't interrupt the for 20:41:01 <Samu> it continues with c = 0 20:41:22 <_dp_> Samu, welcome to C++ :p 20:41:27 <LordAro> Samu: that does seem wrong 20:41:45 <dwfreed> yeah, the break condition will never trigger 20:41:46 <_dp_> Samu, it needs 256 to break but byte can't 256 20:42:04 <Samu> ah 20:42:08 <nielsm> the comiler should really be warning about that 20:42:13 <Samu> c < 255 then? 20:42:30 <_dp_> Samu, depends on what you want to do 20:42:33 <dwfreed> I mean, the loop probably needs c to be 255 to function correctly 20:42:50 <_dp_> Samu, changing it to go from 0 to 254 is definitely and option 20:42:54 <dwfreed> but in order to use a byte value for this purpose, you'll need to design the loop differently 20:43:08 <dwfreed> yeah, go 0 to 254 and add 1 when using c is one way 20:44:04 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] glx22 updated pull request #5: Improve diagnostics from commit checker https://git.io/Jv0b0 20:44:06 *** WormnestAndroid has quit IRC 20:45:29 *** WormnestAndroid has joined #openttd 20:45:31 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] glx22 updated pull request #5: Improve diagnostics from commit checker https://git.io/Jv0b0 20:46:32 <Samu> if c == 255 break; 20:46:36 <Samu> let's see nwo 20:46:58 <Samu> or continue? 20:46:59 <Samu> hmm 20:47:09 <_dp_> rofl 20:48:05 <glx> if (c == 0) break; would make more sense 20:48:23 <Samu> i have it after doing the stuff 20:48:29 <Samu> so, at the end of it 20:48:29 <_dp_> glx, in a loop from 1 to 255? no, just no :p 20:49:13 <glx> it's ugly, and very bad, but it should work ;) 20:49:44 <_dp_> glx, well, yeah, work, but not make sense :p 20:49:44 <glx> but yeah the good way is to rewrite the loop 20:50:06 <DorpsGek_III> [OpenTTD/OpenGFX] Andrew350 dismissed a review for pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv04n 20:50:06 <DorpsGek_III> [OpenTTD/OpenGFX] Andrew350 updated pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv0ba 20:50:26 <Samu> for (byte c = 1; c <= 255 && c != 0; c++) { 20:50:32 *** Wormnest has joined #openttd 20:50:55 <LordAro> Samu: that's terrible 20:51:12 <glx> go from 0 to <255 and use c+1 20:51:37 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 20:51:54 <nielsm> go the wrong way if you can get away with it 20:52:03 <nielsm> for (byte c = 255; c > 0; c--) 20:52:19 <glx> valid option too 20:52:54 <Samu> im learning new stuff 20:53:35 <LordAro> andythenorth: can you rebase to remove that leading space from the commit message? 20:53:37 <andythenorth> oh I broke the compile 20:53:48 <andythenorth> missing newline somewhere 20:54:21 <andythenorth> we require newline at end of file, or ban it? 20:54:29 <LordAro> andythenorth: require 20:54:39 <andythenorth> in which case I don't understand :P 20:54:41 <DorpsGek_III> [OpenTTD/OpenGFX] Andrew350 commented on pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv0bi 20:54:42 <andythenorth> there is a newline 20:54:50 <Samu> this is my test code 20:54:51 <Samu> https://pastebin.com/387VG9eP 20:54:51 <andythenorth> it's not something I've intentionally edited 20:54:56 <Samu> just experimenting 20:55:31 *** Wormnest_ has joined #openttd 20:55:34 <_dp_> Samu, lol, you know you could've proved it like 10 times in the time you've wasted coding it? ;) 20:55:48 <Samu> I wish I knew how 20:55:57 <LordAro> _dp_: Samu is not good at maths 20:56:44 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] LordAro commented on pull request #5: Improve diagnostics from commit checker https://git.io/Jv0b1 20:57:06 <LordAro> andythenorth: you might not have done intentionally, it's just if it appears in the diff 20:57:35 <LordAro> ...but no, it does look like you've done it correctly... 20:57:36 *** WormnestAndroid has quit IRC 20:57:43 <LordAro> https://github.com/OpenTTD/OpenGFX/pull/31/files#diff-092d8aa0feb0c5a8e1ac3aa871e5bfe7L295 20:57:43 <_dp_> Samu, https://math.stackexchange.com/questions/2557458/is-a-b-c-equal-to-a-bc-for-integer-division 20:57:52 *** WormnestAndroid has joined #openttd 20:58:18 <_dp_> Samu, also https://en.wikipedia.org/wiki/Floor_and_ceiling_functions#Nested_divisions 20:58:32 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv0bM 20:58:43 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro merged pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv0ba 20:59:43 *** Wormnest has quit IRC 21:00:37 <andythenorth> oof 21:00:38 <andythenorth> https://github.com/OpenTTD/OpenGFX/pull/31/files#diff-092d8aa0feb0c5a8e1ac3aa871e5bfe7 21:00:43 <andythenorth> shows the newline deleted 21:00:50 <andythenorth> but it's in my local repo 21:01:05 <FLHerne> andythenorth: "pixels that were TMWFTLB to set the flag for" <- why? 21:01:13 <LordAro> andythenorth: no, that shows the newline as being added 21:01:33 <andythenorth> FLHerne: templates 21:01:34 <FLHerne> (what makes it harder to add `ANIM, ` to those sprite definitions than the others?) 21:01:35 <FLHerne> Ah 21:01:46 <andythenorth> it's not hard, it's just not worth fragmenting the template 21:01:57 <andythenorth> for pixels that will almost never be seen 21:03:08 <LordAro> andythenorth: yeah, this looks like a bug in the git hooks 21:03:34 <LordAro> https://github.com/OpenTTD/OpenTTD-git-hooks/blob/master/hooks/check-diff.py#L47 + https://github.com/OpenTTD/OpenGFX/commit/7e2ab7c6054634f912db4744c2535fcdb5516a8e.patch 21:04:25 <andythenorth> which commit has the leading space? 21:04:39 <LordAro> andythenorth: the first one that has the red cross on it, i think 21:04:46 <LordAro> toyland cola 21:05:10 <LordAro> https://github.com/OpenTTD/OpenTTD-git-hooks/pull/8 ah, lol 21:05:24 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] LordAro approved pull request #8: Fix: Allow fixing files with missing newline at end https://git.io/Jv0bb 21:05:30 <LordAro> glx: ^ pls 21:06:21 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] glx22 approved pull request #8: Fix: Allow fixing files with missing newline at end https://git.io/Jv0bx 21:07:02 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] glx22 merged pull request #8: Fix: Allow fixing files with missing newline at end https://git.io/Jv0bp 21:07:30 <Samu> thx dp 21:07:36 <LordAro> i don't know if GH actions will actually pick that up... 21:07:50 <andythenorth> I'm also not seeing what's wrong with the commit messages, sorry 21:08:28 <LordAro> andythenorth: there's a leading space 21:08:34 <LordAro> you won't see it on GH, it trims them 21:08:50 <andythenorth> ah ok 21:08:52 <andythenorth> yes it's in log 21:08:56 <andythenorth> got it 21:08:58 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] glx22 commented on pull request #5: Improve diagnostics from commit checker https://git.io/Jv0NJ 21:09:03 <LordAro> :) 21:09:12 <andythenorth> oh rebase -i also trims them 21:09:13 <andythenorth> lol 21:09:18 <LordAro> heh 21:09:21 <andythenorth> that was the first place I looked 21:09:43 <TrueBrain> okay, 1 bug in the release script .. dammit :P 21:09:48 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth updated pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 21:10:17 <andythenorth> frosch123: I fixed the skyscraper :P 21:11:36 <frosch123> \o/ 21:12:10 <frosch123> did you keep it, or did you replace it with a firs tower? 21:12:16 <TrueBrain> https://cdn.openttd.org/opengfx-nightlies/20200223-master-g80a20cb147/ <- who wants to test this out? (the -all.zip contains the tar you are looking for) 21:12:28 <andythenorth> I somewhat just repainted the sea that had been drawn in it :P 21:12:32 <andythenorth> not very interesting 21:12:44 <LordAro> ha 21:12:48 <andythenorth> people used to do this often, using sea colour for windows 21:13:00 <andythenorth> quite common in train sprites I've seen 21:13:33 <andythenorth> if we can merge 31, I can finally do the NRT sprites :) 21:13:45 * andythenorth waiting for checks to finish though 21:13:49 <FLHerne> I guess that's why the flag exists... 21:14:31 <glx> yeah the flag is to be sure the author wants animation 21:14:50 <frosch123> andythenorth: i liked the fire in the top floor 21:15:01 <andythenorth> the burning billboard? 21:15:12 <andythenorth> you can always restore it :) 21:15:17 <andythenorth> or reject the PR :P 21:15:31 <frosch123> nah, the building was a twin-tower, so it was inappropiate 21:16:48 <andythenorth> so can we build non-track station tiles on corner slopes yet? :) 21:18:09 <TrueBrain> https://www.openttd.org/downloads/opengfx-nightlies/latest.html <- w00p :) 21:18:21 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #32: Fix: postfix binary bundles with "-all", as they work on all systems https://git.io/Jv0Ni 21:18:26 <TrueBrain> ^^ the only bug :) 21:18:28 <TrueBrain> not bad ;) 21:19:04 *** supermop_Home has joined #openttd 21:19:08 <supermop_Home> yo 21:19:40 <DorpsGek_III> [OpenTTD/OpenGFX] glx22 approved pull request #32: Fix: postfix binary bundles with "-all", as they work on all systems https://git.io/Jv0NX 21:19:57 <frosch123> TrueBrain: tar works fine 21:20:16 <andythenorth> 31 checks have passed 21:20:20 <andythenorth> https://github.com/OpenTTD/OpenGFX/pull/31 21:20:39 <TrueBrain> frosch123: w00p :D :D :D 21:20:39 <TrueBrain> tnx 21:20:50 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #33: Remove: by switching to GitHub, the '.devzone' code is no obsolete https://git.io/Jv0N1 21:21:01 <TrueBrain> no obsolete? Lol .. oops 21:21:16 <andythenorth> rebase! 21:21:24 <andythenorth> or just GH :P 21:21:26 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #33: Remove: by switching to GitHub, the '.devzone' code is no obsolete https://git.io/Jv0N1 21:21:40 <TrueBrain> both! 21:24:06 <TrueBrain> pretty sure that tagging in OpenGFX now works too as you would expect if you know 'website' :) 21:24:07 <TrueBrain> sweet :) 21:26:06 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #32: Fix: postfix binary bundles with "-all", as they work on all systems https://git.io/Jv0Ni 21:26:52 <TrueBrain> andythenorth: fixed all but 10 warnings? Damn, dat is impressive :) Nice! 21:27:52 <andythenorth> NP 21:28:10 <andythenorth> I have a twitch about warnings :P 21:28:38 <TrueBrain> well, I guess we raised OpenGFX from the dead in a weekend ;) 21:28:42 <andythenorth> and turns out some were genuine, and we weren't attending to them :) 21:28:46 <andythenorth> yes, thanks everybody 21:28:58 <andythenorth> and soon we can release nml as well :) 21:29:01 <TrueBrain> productive weekend like this :) 21:29:11 <andythenorth> winner winner 21:30:17 <Samu> hmm _dp_ using % modulo i can get into finer details 21:30:48 <Samu> studying a possible alternative to what we have 21:31:23 <Samu> instead of sorting by best rating, we sort by this modulo 21:31:32 * andythenorth wonders about composable road vehicles, like train wagons 21:33:51 *** sla_ro|master has quit IRC 21:41:23 <Samu> we need to store this % value somewhere 21:41:31 <Samu> is there a p.third ? 21:42:33 *** WormnestAndroid has quit IRC 21:43:12 *** WormnestAndroid has joined #openttd 21:43:12 <_dp_> Samu, third element in a pair? ;) 21:43:35 <Samu> well, something where i can store this, per station 21:43:43 *** Wormnest_ has quit IRC 21:43:47 <_dp_> Samu, though question here is not what or how but why 21:43:58 *** frosch123 has quit IRC 21:44:06 *** andythenorth has quit IRC 21:44:25 <Samu> i can calculate this difference, then sort it by highest 21:44:33 <Samu> it's sort of like decimal points 21:44:40 <_dp_> it's already somewhat pointless to even count those rounded out bits 21:44:43 <Samu> the one with highest decimal, gets the extra 21:45:19 <_dp_> giving them to stations with higher rating is already reasonable enough 21:45:42 <_dp_> and if you want to make absolutely perfect division it should be randomized by reminder, not sorted 21:47:22 <Samu> uint difference = amount * company_best[owner] * p.first->goods[type].rating % (best_sum * company_sum[owner]); 21:47:23 <Samu> p.third = 65535 * difference / best_sum / company_sum[owner]; 21:47:28 <Samu> but there is no p.third 21:47:33 <_dp_> but again, rather than worry about some 1/256ths of cargo it would be much better to fix rouding in payments that wastes like 1/20 21:49:13 *** andythenorth has joined #openttd 21:59:45 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0xU 22:00:34 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] LordAro commented on pull request #5: Improve diagnostics from commit checker https://git.io/Jv0xL 22:01:03 <andythenorth> hurrah 22:01:29 <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth merged pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm 22:04:22 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] LordAro approved pull request #11: Fix: GIT_DIR is no longer set in git >= 2.18.0 https://git.io/Jv0xC 22:15:00 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #33: Remove: by switching to GitHub, the '.devzone' code is now obsolete https://git.io/Jv0N1 22:15:39 <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #33: Remove: by switching to GitHub, the '.devzone' code is now obsolete https://git.io/Jv0xr 22:16:15 <LordAro> andythenorth: feel like adding the 5 new sprites to complete the day? :p 22:16:29 <andythenorth> saving it for Monday 22:16:43 <andythenorth> I'd have to figure out where they go 22:18:27 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] glx22 merged pull request #11: Fix: GIT_DIR is no longer set in git >= 2.18.0 https://git.io/Jv0xP 22:18:59 *** erkan has joined #openttd 22:20:39 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] glx22 commented on pull request #5: Improve diagnostics from commit checker https://git.io/Jv0xS 22:20:52 <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #33: Remove: by switching to GitHub, the '.devzone' code is now obsolete https://git.io/Jv0N1 22:21:05 <TrueBrain> well, I guess that commit makes it official :) 22:21:09 <TrueBrain> good night all! 22:22:20 *** erkan has quit IRC 22:23:37 <Samu> hmm 22:24:40 <andythenorth> fanks everybody 22:25:01 <Samu> i have 2 lists of stations, I sorted 1 of the list, how do i mirror the sorting results to the other list? 22:25:21 *** andythenorth has quit IRC 22:36:10 *** gelignite_ has quit IRC 22:36:16 *** HerzogDeXtEr has quit IRC 22:53:20 *** Progman has quit IRC 22:57:01 *** WormnestAndroid has quit IRC 22:57:48 *** WormnestAndroid has joined #openttd 23:02:07 <DorpsGek_III> [OpenTTD/OpenTTD] skrzyp opened issue #8019: AppImage support https://git.io/Jv0hG 23:06:06 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on issue #8019: AppImage support https://git.io/Jv0hG 23:11:27 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] glx22 updated pull request #5: Improve diagnostics from commit checker https://git.io/Jv0b0 23:12:39 <DorpsGek_III> [OpenTTD/OpenTTD-git-hooks] glx22 commented on pull request #5: Improve diagnostics from commit checker https://git.io/Jv0hw 23:13:31 *** Wormnest_ has joined #openttd 23:17:03 <LordAro> well they've put a lot of thought into that issue 23:17:16 <LordAro> i do dislike container formats though 23:17:17 *** skrzyp has joined #openttd 23:18:06 *** nielsm has quit IRC 23:19:00 <skrzyp> nielsm: In regard to #8019, CMake doesn't have native suport for AppImages in CPack, but it would be definitely easier to integrate if you don't want to. 23:19:19 <skrzyp> Though I'm a bit more scared about your Azure CI pipelines… 23:20:16 <LordAro> skrzyp: you just missed him 23:20:21 <skrzyp> oh 23:20:32 <LordAro> what scares you? :p 23:21:28 <skrzyp> LordAro: the "yet another pipeline workflow" compared to GitLab CI (my "goto" one), Travis, Bamboo, and so on. YAML is nice, but all of them might profit from some standarization… 23:21:40 <LordAro> heh 23:21:46 <skrzyp> And M$ attribution too, I try to stay from everything what has "Microsoft" on it 23:21:53 <skrzyp> except maybe Microsoft BOB 23:22:38 <Samu> _dp_ i did it! ugly as hell, but here it is 23:22:40 <glx> hehe and we actually mix azure and github actions :) 23:22:54 <Samu> https://pastebin.com/bPsFv9fs 23:23:22 <Samu> line 9, 15 and 26 23:23:30 <Samu> 1 variable, able to store 2 values :p 23:24:34 <skrzyp> glx: isn't GA only for "automating" housekeeping in GH repos? 23:25:08 <glx> commit checker used to be on azure, we recently moved it to GA 23:25:19 <Samu> the intro game already makes a difference, 2 stations, 2 ammounts, instead of 146, 172, now it's 147, 171 23:25:24 <glx> for easier access of logs 23:26:42 <LordAro> i imagine the rest of it will be moved at some point soon 23:28:13 <Samu> hmm gotta go sleep 23:28:15 <Samu> take care 23:28:19 *** Samu has quit IRC 23:40:56 *** Flygon has joined #openttd