Times are UTC Toggle Colours
00:13:43 <_dp_> ^^ #8998 dupe 00:16:06 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #9173: Can't zoom minimap in any further when at 1x scale https://git.io/J3WAH 00:16:09 <DorpsGek> [OpenTTD/OpenTTD] glx22 closed issue #9173: Can't zoom minimap in any further when at 1x scale https://git.io/J3WAH 00:17:45 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on issue #9167: Linkgraphs don't show direction of each link https://git.io/J3CKD 00:18:41 <glx> hehe I like James :) 00:25:28 *** Progman has quit IRC 00:26:34 <_dp_> would be really nice if openttd could draw antialiased lines 00:26:42 <_dp_> for charts as well 00:32:22 <didac> hi there! frosch has been helping out a lot with #9043, but if anyone here knows well about sprite sorting, bounding boxes etc and want to help me out, please let me know! I am really struggling with this. happy to jump into a call or something if you are wanting to help *that much* :) 00:34:48 *** HerzogDeXtEr has quit IRC 00:36:04 <peter1138> Oh is it that late already? 00:37:27 <didac> not in my timezone :) are you PeterN in github? if so thank you for your responses 00:40:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #9174: Fix: Update text effect size when font zoom is changed. https://git.io/J3lvr 00:42:04 <peter1138> Yeah, but it is actually 1:40am here and I need sleep. Sorry. 00:45:02 <didac> haha 00:45:06 <didac> have a good night! 00:45:42 *** didac has quit IRC 01:09:35 *** didac has joined #openttd 01:17:27 *** didac has quit IRC 01:29:21 <DorpsGek> [OpenTTD/OpenTTD] Andrew350 commented on discussion #9162: Features needed for New Bridges https://git.io/J3cM2 01:36:04 *** Beerbelott has quit IRC 02:56:56 *** Wormnest has quit IRC 03:00:36 *** D-HUND has joined #openttd 03:03:53 *** debdog has quit IRC 03:17:59 *** glx has quit IRC 03:42:50 *** Kitrana1 has joined #openttd 03:42:51 *** Kitrana has quit IRC 03:59:09 *** Flygon has joined #openttd 05:16:20 <DorpsGek> [OpenTTD/OpenTTD] kiwitreekor commented on discussion #9162: Features needed for New Bridges https://git.io/J3cM2 05:24:56 *** Gustavo6046 has quit IRC 05:29:26 *** snail_UES_ has quit IRC 05:31:59 *** Gustavo6046 has joined #openttd 05:41:31 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #9172: Cleanup: Use std::vector is xxxSpriteGroups. https://git.io/J3lbV 05:48:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #9174: Fix: Update text effect size when font zoom is changed. https://git.io/J3lNA 05:49:01 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #9128: Codechange: use std::string exclusively for settings https://git.io/J3TEL 06:25:45 *** andythenorth has joined #openttd 06:32:17 <andythenorth> yo 06:43:17 <Rubidium> oi 06:43:23 <andythenorth> :) 07:15:18 *** Wolf01 has joined #openttd 07:19:52 *** sla_ro|master has joined #openttd 07:32:58 *** EER has joined #openttd 07:45:38 *** Progman has joined #openttd 07:49:57 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on discussion #9162: Features needed for New Bridges https://git.io/J3cM2 08:08:49 <peter1138> Hmm, hitting the sprite cache size limit still sucks :/ 08:11:51 <andythenorth> oof 08:13:33 <peter1138> Show me how to change the code to use a texture atlas ;) 08:13:49 <peter1138> I have 11GB GPU memory, should be enough 08:15:16 <peter1138> Maybe if we scaled on the fly instead of prescaling... 08:15:31 <peter1138> Blitters would need major love to allow that. 08:15:58 <peter1138> But would use 20 times less memory :p 08:19:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #9172: Cleanup: Use std::vector is xxxSpriteGroups. https://git.io/J3WN7 08:24:12 *** nielsm has joined #openttd 08:30:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #9169: Fix #9147: Asynchronously do screenshots during draw tick. https://git.io/J384A 08:34:07 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #9172: Cleanup: Use std::vector is xxxSpriteGroups. https://git.io/J38BK 08:40:57 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on discussion #9162: Features needed for New Bridges https://git.io/J3cM2 08:41:05 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #9172: Cleanup: Use std::vector in xxxSpriteGroups. https://git.io/J3WN7 08:51:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #9175: Fix: Crash when extra viewport height is zero with sign in view. https://git.io/J38EP 08:53:44 *** WormnestAndroid has quit IRC 08:53:56 *** WormnestAndroid has joined #openttd 08:59:35 <peter1138> Okay, so what's best, explicit member initialization, or let ZeroedMemoryAllocator handle it? 09:05:06 <peter1138> length*number bytes of tile types, one platform after another, only 00, 02, 04 or 06 are allowed as values 09:05:13 <peter1138> Hmm, we don't check for that. 09:16:59 <peter1138> andythenorth, what's all this "choice list" noise when loading FIRS? :D 09:17:00 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #9176: Fix: [Network] Reading beyond the length of the server's ID when hashing passwords https://git.io/J382h 09:17:23 <andythenorth> peter1138 o_O ? 09:17:36 <andythenorth> I did what now? 09:17:43 <peter1138> debug_level grf=1 09:17:44 <andythenorth> goes it awful? 09:17:53 <peter1138> "choice lists can't be stacked, it's going to get messy now..." 09:18:00 <peter1138> "duplicate choice list string,ignoring" 09:18:05 <peter1138> "choice list next marker found when not expected" 09:18:24 <nielsm> well technically ZeroedMemoryAllocator just makes sure the memory representing the object is zero bytes, I guess there are some guarantees that basic numeric types are initialised to zero by that, but technically nullptr could be represented something other than zero bytes 09:18:30 <nielsm> I think...? 09:18:49 <peter1138> In that case we have major issues ;D 09:19:03 <andythenorth> peter1138 some kind of plural string thing? 09:19:21 <peter1138> I have no idea, the error doesn't mention what action or anything. 09:19:25 <andythenorth> case 0x15: 09:19:36 <andythenorth> TranslateTTDPatchCodes 09:19:50 <peter1138> Also IndustryMapSpriteGroup: Industry 3 undefined, skipping 09:19:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #9175: Fix: Crash when extra viewport height is zero with sign in view. https://git.io/J38aK 09:19:59 <andythenorth> such quality 09:20:16 <peter1138> Doesn't NML protect against such larks? 09:20:26 <andythenorth> ha ha ha ha 09:20:32 <peter1138> o 09:20:39 <andythenorth> nml does a lot of things, but perfection is not achieved 09:20:55 <andythenorth> it does get better, people make improvements 09:21:02 <DorpsGek> [OpenTTD/OpenTTD] kiwitreekor commented on discussion #9162: Features needed for New Bridges https://git.io/J3cM2 09:21:09 <andythenorth> FIRS doesn't have industry 3, so I think that's ok 09:21:19 <andythenorth> the TTDPatchCodes....errr NFI 09:21:30 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #9175: Fix: Crash when extra viewport height is zero with sign in view. https://git.io/J38EP 09:22:00 <peter1138> ^ one for LordAro when he's finished killing his legs. 09:22:01 * andythenorth goes it car carrying wagons in Horse 09:28:34 <peter1138> Anyway, those choice list warnings are on lines 1239, 1241, 1243, 1257 and 1259. In FIRS 4.0.1. 09:28:43 *** erle- has joined #openttd 09:29:09 <peter1138> Why do I have FIRS v1, v2, v3 and v4 installed? :/ 09:29:20 <peter1138> The content download needs a delete button :p 09:29:54 <peter1138> I like the NewGRF called "FIXES" 09:30:48 *** frosch123 has joined #openttd 09:31:51 <andythenorth> FIXES is the best 09:32:01 <peter1138> Rectal FIRS. Hm. 09:32:03 <andythenorth> there's a FIRS fork with an offensive name somewhere I think 09:32:06 <andythenorth> yes that one 09:32:34 <andythenorth> such choice list warnings 09:32:50 <_dp_> nielsm, not sure if nullptr value is defined but it kinda have to be that nullptr == (void*)0 for compatibility 09:33:07 <_dp_> also nullptr is defined to be falsy iirc 09:34:28 <peter1138> https://twitter.com/thingskatedid/status/1293476425454895105 09:35:12 <nielsm> (void*)0 converts to nullptr, but if you store nullptr to something and memcpy() the bytes of that storage out to a char array the value is implementation defined 09:35:22 <peter1138> Exactly 09:36:08 <nielsm> and there can be many representations that compare equal to nullptr 09:38:21 * andythenorth renames 'vehicles' to 'automobiles' when it's about cargo sprites on trains 09:38:27 <andythenorth> that was a lot of confusion for a while 09:38:31 <andythenorth> vehicle, vehicle 09:38:49 <andythenorth> much vehicle.foo stuff in Horse code 09:39:31 <peter1138> "automobiles"... are you from the US? 09:39:56 <andythenorth> well 09:40:03 <andythenorth> the train cars are called cars 09:40:08 <andythenorth> so that would be confusing 09:40:16 <andythenorth> but your question would remain valid 09:41:00 <andythenorth> I could find and replace Car to Wagon 09:41:02 <andythenorth> or Coach 09:41:15 <andythenorth> or some conditional on Wagon || Coach 09:41:28 * andythenorth lost in trivia 09:43:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #9174: Fix: Update text effect size when font zoom is changed. https://git.io/J3lvr 09:44:30 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #9176: Fix: [Network] Reading beyond the length of the server's ID when hashing passwords https://git.io/J38Kn 09:51:32 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #9176: Fix: [Network] Reading beyond the length of the server's ID when hashing passwords https://git.io/J382h 10:06:50 *** HerzogDeXtEr has joined #openttd 10:07:22 <andythenorth> hmm 10:10:43 <andythenorth> got car carrying wagons 10:10:50 <andythenorth> which refit pax because motorail 10:10:54 <andythenorth> goes it refit mail also or not? 10:11:01 <andythenorth> postman pat on a train? 10:13:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #9177: Cleanup: Use vectors for station platform and sprite layouts https://git.io/J38Xn 10:14:17 <peter1138> car carrying wagons which refit to passengers... uhm. 10:14:24 <peter1138> Is that a good feature? 10:14:30 <andythenorth> no 10:14:31 <andythenorth> BAD 10:14:36 <peter1138> Correct. 10:14:53 <peter1138> Hmm, strange, I used Cleanup everywhere else, but Codechange here. 10:14:56 <peter1138> Consistency eh? 10:14:59 <andythenorth> imagine sitting in your mini metro London->Penzance 10:15:02 <andythenorth> can't open the doors 10:15:05 <andythenorth> not allowed 10:15:59 <andythenorth> the nice thing is that the cargo subtypes are working 10:17:28 <peter1138> Is this the new norm? 10:17:53 <Rubidium> andythenorth: I found Paddington -> Reading already very long and very cramped. Though, arguably if you have your own car in the train, you have more space in that train than you normally have during peak hours 10:18:19 <andythenorth> cargo subtypes are great! 10:18:45 <andythenorth> Rubidium that train is quite horrible, Paddington -> Bristol is usually 'stand up' until Reading 10:19:02 <andythenorth> and Bristol->Bath the other direction 10:20:07 <andythenorth> oof I can't put the motorail wagons after the DVT, it has magic 10:20:09 <andythenorth> meh 10:23:06 <Rubidium> I must say the only time I did Bristol -> Bath it was not that bad, though it was a Saturday 10:25:46 <andythenorth> yeah it's a Monday-Friday thing :) 10:39:51 *** EER has quit IRC 10:47:12 <peter1138> How does Simutrans manage to look so bad? :D 10:49:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on issue #9117: New game fails to start after upgrading FluidSynth to version 2.2.0 https://git.io/JOxCI 10:49:34 <andythenorth> years of work :) 10:49:37 <andythenorth> oof catty 10:49:48 <andythenorth> I tried it once 10:50:27 <Rubidium> too many base sets? 10:54:39 <Rubidium> OpenTTD must have been doing things good if you find things like "For most libraries you will easily find binaries. A quick start for some of" 10:54:42 <Rubidium> them is the bundle used for OpenTTD: 10:55:05 <Rubidium> (source: the simutrans readme) 10:56:05 <andythenorth> :) 10:56:37 <peter1138> Oh, it doesn't even start for me. "loadsave_t::rdwr_xml_number() - expected "<i8>", got "</u>" Aborting program execution ... 10:56:40 <peter1138> Nice. 10:57:22 <peter1138> I guess something changed in their config and they don't handle it gracefully. 10:58:23 <peter1138> Simutrans version 122.0, based on Simutran 84.22.1. Huh. 10:58:53 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #9177: Cleanup: Use vectors for station platform and sprite layouts https://git.io/J387v 10:59:46 <peter1138> Argh signedness :( 11:03:37 <peter1138> Oh god. 11:05:51 <peter1138> https://cdn.discordapp.com/attachments/337701432230805505/838370642041634836/Screenshot_2021-05-02_120401.png 11:06:42 <peter1138> Oh I see, that list is that short because that is the number of compatible servers listed. 11:07:21 <peter1138> I clicked on one of the servers and it gave a similar error as above and then aborted :D 11:07:42 <peter1138> I guess Tron is no longer helping them out. 11:12:10 <LordAro> peter1138: can confirm, legs killed 11:12:15 <peter1138> \o/ 11:19:10 <peter1138> Urgh, making it unsigned breaks :D 11:21:51 <michi_cc> Casts to the rescue! 11:22:06 <peter1138> It's the CreateMulti() loop that fails. 11:22:38 <peter1138> Alternative solution, as layouts is incremented is to ensure that layouts is before the end of the array. 11:28:36 *** gelignite has joined #openttd 11:28:50 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #9177: Cleanup: Use vectors for station platform and sprite layouts https://git.io/J38Xn 11:40:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #9177: Cleanup: Use vectors for station platform and sprite layouts https://git.io/J38pI 11:48:47 *** gelignite has quit IRC 12:16:15 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #9039: Codechange: refactor File I/O slot functions to be object oriented and pass references instead of indices https://git.io/JOGDX 12:16:18 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #9128: Codechange: use std::string exclusively for settings https://git.io/J3TEL 12:20:24 *** Samu has joined #openttd 12:45:46 <DorpsGek> [OpenTTD/OpenTTD] LordAro merged pull request #9088: Fix: [NewGRF] industry variables 65 and 66, object variable 46 https://git.io/JOD6Q 12:48:56 <LordAro> hmm, backporting #9148... 12:50:23 *** iSoSyS has joined #openttd 12:52:19 *** iSoSyS has quit IRC 12:56:16 <frosch123> no idea, i am just annoyed about the whining in IRC. otherwise it's also good for next year :) 12:57:27 <Rubidium> you could also consider backporting it for 1.11.3 13:00:51 <frosch123> yep, i would expect noone tested it, except me with 4 newgrf :p 13:01:08 <frosch123> for 3 minutes each 13:02:26 <peter1138> Ah that. 13:05:43 <LordAro> and backporting #9146 is difficult without #9112 13:06:23 <LordAro> well, not super difficult 13:08:25 <Rubidium> I'll happily backport it for 1.11.3 if needed 13:11:42 <LordAro> as long as i can get it to compile, it'll probably be good 13:17:08 *** glx has joined #openttd 13:17:08 *** ChanServ sets mode: +v glx 13:22:36 <LordAro> https://github.com/OpenTTD/OpenTTD/commit/67063ceeb3832a7e0f608859ccbd5e79214e9853 what happened here..? 13:23:58 <glx> weird 13:24:14 <LordAro> peter1138: backport #9174 ? 13:25:33 <glx> oh there are 2 commits, and one is empty 13:25:44 <glx> double merge ? 13:26:38 <peter1138> LordAro, can do, it's minor 13:26:43 <LordAro> the GH interface did do something weird when i merged it 13:27:35 <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #9160: Prepare for 1.11.2 release https://git.io/J3cGn 13:28:48 <LordAro> so, just #9169 & #9140, assuming they get merged 13:28:51 <peter1138> Damn, lots of fixes in this :D 13:29:04 <LordAro> #9148 should wait imo, or possibly not be backported at all 13:29:40 <peter1138> Yes, bit much for a point release I think. 13:31:30 <LordAro> both the others are well beyond my ability to properly review 13:32:18 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #9169: Fix #9147: Asynchronously do screenshots during draw tick. https://git.io/J34Zi 13:33:10 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #9160: Prepare for 1.11.2 release https://git.io/J34Z7 13:33:18 <glx> so it's not forgotten ;) 13:33:32 <DorpsGek> [OpenTTD/OpenTTD] auge8472 commented on discussion #9162: Features needed for New Bridges https://git.io/J3cM2 13:33:38 <LordAro> at what point? 13:33:46 <LordAro> after release? before? 13:33:50 <glx> before release 13:34:20 <glx> it's used to set internal version during build 13:35:05 <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #9160: Prepare for 1.11.2 release https://git.io/J3cGn 13:35:16 <LordAro> i amended your backported commit :) 13:35:24 <LordAro> but plausibly it should be a separate commit i suppose 13:35:39 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9169: Fix #9147: Asynchronously do screenshots during draw tick. https://git.io/J34nO 13:36:04 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #9177: Cleanup: Use vectors for station platform and sprite layouts https://git.io/J34nZ 13:37:23 <TrueBrain> LordAro: 9147 looks fine to me, it is about the C++ people were arguing about I didn't understand :p 13:37:59 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #9177: Cleanup: Use vectors for station platform and sprite layouts https://git.io/J34nZ 13:38:01 <LordAro> TrueBrain: give JGR a poke to see if he can think of a less std::function-ish solution? 13:38:03 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #9177: Cleanup: Use vectors for station platform and sprite layouts https://git.io/J38Xn 13:38:34 <TrueBrain> LordAro: go for it; I don't even understand what it does :p 13:41:01 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #9167: Linkgraphs don't show direction of each link https://git.io/J3CKD 13:42:55 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #9177: Cleanup: Use vectors for station platform and sprite layouts https://git.io/J34c1 13:42:57 <glx> <LordAro> but plausibly it should be a separate commit i suppose <-- maybe with changelog update, as it's a mandatory update before release 13:43:23 <TrueBrain> LordAro: but wasn't the talk about std::bind? I dunno .. either way, PR is fine by me, up to you C++ nerds to find an agreement :D 13:44:07 <LordAro> TrueBrain: that too 13:44:17 <LordAro> i don't think there's any issues with std::bind personally 13:44:27 <LordAro> there were some pre-C++11 stuff that got deprecated, but that's not being used here 13:45:15 <TrueBrain> shrug 13:45:16 <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #9160: Prepare for 1.11.2 release https://git.io/J3cGn 13:46:13 <LordAro> ¯\_(ツ)_/¯ 13:46:17 <peter1138> It would be nice to fix the FFWD issue. 13:46:37 <LordAro> yeah, i don't think there's a question of getting them merged & backported 13:46:46 <LordAro> just what exactly their form is :p 13:46:51 <peter1138> Haha 13:48:15 <peter1138> So the screenshot called uses a lambda(?) construct? 13:48:21 <peter1138> -ed 13:50:29 <peter1138> Or is it the std::function that's... hmm 13:50:43 <peter1138> Alternative to that seems to be a template, which seems not ideal. 13:52:01 <peter1138> @TrueBrain TrueBrain requested review from TrueBrain and removed request for TrueBrain 10 minutes ago 13:52:04 <peter1138> What does that mean? :D 13:52:17 <LordAro> really difficult store templated functions in a container too ;) 13:52:27 <LordAro> which is mostly why they're necessary - could easily template it otherwise 13:53:57 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #9161: Feature: NewGRF Bridges without overriding https://git.io/J34WO 13:57:30 <TrueBrain> peter1138: LordAro requested my review, and I tried to remove myself.. interface on mobile is weird :p 13:57:42 <TrueBrain> But tnx for the highlights :D 13:59:20 <peter1138> Yes ;) 13:59:28 <TrueBrain> :D 14:00:44 <LordAro> TrueBrain: TrueBrain 14:01:22 <TrueBrain> LordAro: yes darling? :) 14:01:38 <TrueBrain> Wasn't it peter1138 with a question? :p 14:01:47 <TrueBrain> Owh, this is so annoying :D 14:02:20 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #9161: Feature: NewGRF Bridges without overriding https://git.io/J34lj 14:02:25 <glx> hmm I'm looking at #9172 (I know it's merged), but it seems the new version (as the old one) never deletes the create SpriteGroup 14:02:51 <glx> *created 14:04:31 <peter1138> It's a pool. 14:04:54 <glx> ah of course, I didn't follow all the indirections :) 14:05:05 <peter1138> We gave up trying to keep track individually :-) 14:10:01 *** sla_ro|master has quit IRC 14:16:44 *** andythenorth has quit IRC 14:35:44 *** erle- has quit IRC 14:49:50 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on discussion #9162: Features needed for New Bridges https://git.io/J3cM2 15:15:47 * peter1138 ponders revisiting docks. 15:29:06 *** EER has joined #openttd 15:38:34 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #9169: Fix #9147: Asynchronously do screenshots during draw tick. https://git.io/J34DL 15:40:52 <TrueBrain> michi_cc: I don't know anything to balance it, so personally I do not care; just asking as one is a Lambda and the other not. That is all fine and dandy etc? 15:41:27 <michi_cc> The whole point of using std::function is that it can take anything that is callable in any way. 15:41:54 <michi_cc> Templating pointer-to-lambda isn't really possible as each lambda is its own type, even if they have the exact same signature. 15:42:40 <michi_cc> As a lambda, the line would read "VideoDriver::GetInstance()->QueueOnMainThread([repl_blitter]() { RealChangeBlitter(repl_blitter); });" Pure personal preference what is better. 15:42:49 <TrueBrain> Cool; my OCD triggered, so just double checking it wasn't an oversight :D 15:44:24 <TrueBrain> I leave the style debate for people who know what they are talking about :p 15:45:21 <michi_cc> I can change it if lambdas are cool and bind is not :) 15:45:48 <glx> so MakeScreenshot could also use std::bind or is the scoping an issue in this case ? 15:46:06 <michi_cc> Return type is also an issue. 15:46:08 <TrueBrain> I have no opinion on the matter; just as long as it works :p 15:46:56 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #9169: Fix #9147: Asynchronously do screenshots during draw tick. https://git.io/J34S3 15:47:17 <DorpsGek> [OpenTTD/OpenTTD] michicc dismissed a review for pull request #9169: Fix #9147: Asynchronously do screenshots during draw tick. https://git.io/J34S3 15:47:19 <peter1138> Hehe :) 15:47:20 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #9169: Fix #9147: Asynchronously do screenshots during draw tick. https://git.io/J3Ch8 15:47:22 <TrueBrain> Crazy how many ways we have in C++ to pass function pointers, bound or not 15:47:26 <michi_cc> peter1138: Sorry, but the commit message was indeed wrong :) 15:49:06 <michi_cc> Crashlog looks at the return of MakeScreenshot, so I can't just drop it. And bind will not change return types. 15:49:24 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9169: Fix #9147: Asynchronously do screenshots during draw tick. https://git.io/J34S5 15:49:59 <glx> @return true iff the screenshot was successfully made. <-- but if it's queued it's not made ;) 15:49:59 <michi_cc> A lambda can do everything std::bind can, I just don't think it it always easier to read. 15:50:27 <michi_cc> Everything except crashlog doesn't care anyway. 15:51:29 <glx> yeah c++ can be hard to read very easily :) 15:51:58 <TrueBrain> It's a magic place 15:57:01 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #9177: Cleanup: Use vectors for station platform and sprite layouts https://git.io/J34H4 15:57:28 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #9169: Fix #9147: Asynchronously do screenshots during draw tick. https://git.io/J3Ch8 15:57:31 <DorpsGek> [OpenTTD/OpenTTD] michicc closed issue #9147: MakeScreenshot locking is broken when called from outside of VideoDriver::Tick https://git.io/J3GgU 15:58:35 <DorpsGek> [OpenTTD/OpenTTD] kiwitreekor commented on pull request #9161: Feature: NewGRF Bridges without overriding https://git.io/J34Hy 16:02:17 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #9161: Feature: NewGRF Bridges without overriding https://git.io/J34QP 16:15:31 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #9177: Cleanup: Use vectors for station platform and sprite layouts https://git.io/J38Xn 16:16:48 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #9178: Add: std::string support to Packet https://git.io/J34FU 16:18:10 *** gelignite has joined #openttd 16:23:31 *** snail_UES_ has joined #openttd 16:43:18 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #9160: Prepare for 1.11.2 release https://git.io/J34jW 16:43:37 *** sla_ro|master has joined #openttd 16:47:39 *** EER has quit IRC 16:49:39 <DorpsGek> [OpenTTD/OpenTTD] kiwitreekor updated pull request #9161: Feature: NewGRF Bridges without overriding https://git.io/J3cPO 16:52:47 <DorpsGek> [OpenTTD/OpenTTD] kiwitreekor commented on pull request #9161: Feature: NewGRF Bridges without overriding https://git.io/J3Bvr 16:55:50 *** Flygon has quit IRC 17:00:15 <DorpsGek> [OpenTTD/OpenTTD] kiwitreekor updated pull request #9161: Feature: NewGRF Bridges without overriding https://git.io/J3cPO 17:00:51 <DorpsGek> [OpenTTD/OpenTTD] kiwitreekor commented on pull request #9161: Feature: NewGRF Bridges without overriding https://git.io/J3BJR 17:07:39 *** Remix has joined #openttd 17:19:12 *** sla_ro|master has quit IRC 17:31:52 *** Wormnest has joined #openttd 17:37:33 *** erle- has joined #openttd 17:45:49 *** andythenorth has joined #openttd 17:50:33 *** WormnestAndroid has quit IRC 17:50:36 *** WormnestAndroid has joined #openttd 17:51:19 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on pull request #9161: Feature: NewGRF Bridges without overriding https://git.io/J3BOx 17:54:24 <LordAro> right, shall we release 1.11.2? 17:54:55 <LordAro> dammit, #9140 conflicting 17:55:04 <LordAro> milek7: you about enough to update it, or shall i look at it? 17:55:51 <LordAro> or maybe even michi_cc, given i don't understand it 17:57:44 <DorpsGek> [OpenTTD/OpenTTD] michicc dismissed a review for pull request #9140: Codechange: Acquire video buffer before taking game state lock to prevent erratic fast forward behaviour https://git.io/J3mwk 17:57:47 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #9140: Codechange: Acquire video buffer before taking game state lock to prevent erratic fast forward behaviour https://git.io/J3mu6 17:57:50 <LordAro> <3 17:58:17 <michi_cc> Damnit, GitHub makes a real merge out of it. No idea if that is still squashable. 18:00:36 <LordAro> yeah, i'll force-squash 18:00:46 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #9140: Codechange: Acquire video buffer before taking game state lock to prevent erratic fast forward behaviour https://git.io/J3Bso 18:01:28 <michi_cc> I don't think you can, a local rebase conflicts again. I'll force push a proper rebase. 18:01:38 <LordAro> :/ 18:02:07 <DorpsGek> [OpenTTD/OpenTTD] michicc dismissed a review for pull request #9140: Codechange: Acquire video buffer before taking game state lock to prevent erratic fast forward behaviour https://git.io/J3Bso 18:02:10 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #9140: Codechange: Acquire video buffer before taking game state lock to prevent erratic fast forward behaviour https://git.io/J3mu6 18:05:22 <andythenorth> so shall I do 32bpp sprites, so I can use partial-alpha pixels for the side screens on these car transporters? https://PaulBartlett.zenfolio.com/stvamatautic/e18bb2bb 18:06:07 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #9140: Codechange: Acquire video buffer before taking game state lock to prevent erratic fast forward behaviour https://git.io/J3BG7 18:06:38 <LordAro> haven't been any eints commits in a couple of days, is it still working? 18:08:57 <TrueBrain> GitHub scheduler is so far out of whack 18:09:06 <TrueBrain> that the CE(S)T correction fails 18:09:30 <LordAro> oh dear 18:09:42 <TrueBrain> it is scheduled for :30 18:09:46 <TrueBrain> it executed at :03 18:09:48 <TrueBrain> 34 minutes lag 18:09:57 <TrueBrain> I am .. lost for words 18:10:01 <TrueBrain> but you can manually start one if you like 18:10:11 <DorpsGek> [OpenTTD/OpenTTD] LordAro merged pull request #9140: Codechange: Acquire video buffer before taking game state lock to prevent erratic fast forward behaviour https://git.io/J3mu6 18:10:19 <LordAro> so i can 18:11:05 <LordAro> maybe change it to run every hour, then if it happens to run within the correct hour, actually do something :p 18:11:45 <TrueBrain> or, you know, stop doing it in CE(S)T, and just use UTC :P 18:11:52 <TrueBrain> (also for nightlies) 18:11:58 <LordAro> that too 18:12:00 <LordAro> why does it? 18:12:40 <TrueBrain> we used to disallow commits between 1945 and 2000 CE(S)T 18:12:55 <TrueBrain> to give the translator the time, and to avoid the endless "owh no, I just committed and now the nightly will break" commits 18:13:00 <TrueBrain> which was happening more than you might think 18:13:04 <TrueBrain> so timezone was important 18:13:09 <TrueBrain> now ... a lot less important :P 18:14:13 <TrueBrain> having a strong CI and PRs really prevent master from breaking 18:14:21 <TrueBrain> the only one breaking it, ironically, is eints :P 18:16:01 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/J3BnS 18:16:02 <DorpsGek> - Update: Translations from eints (by translators) 18:16:06 <LordAro> \o/ 18:16:32 <TrueBrain> I also wonder how often nightlies are not produced because of this :P But nightlies are not as important as they used to be anyway .. meh 18:16:40 <TrueBrain> I will look at this next week if nobody beats me to it :) 18:17:39 <LordAro> no new relevant changes by the looks of things anyway 18:18:01 <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #9160: Prepare for 1.11.2 release https://git.io/J3cGn 18:18:34 <LordAro> would be good if someone else can actually test it 18:18:43 <LordAro> i have had to do a fair bit of manual backporting 18:19:53 <LordAro> but other than that, ready \o/ 18:20:04 <peter1138> Motivation / Problem 18:20:05 <peter1138> Keep getting reports for OGL related crashes 18:20:06 <peter1138> :D 18:20:19 <TrueBrain> LordAro: can't help you with that tonight, but hopefully someone else can :D 18:20:27 <LordAro> i should list them all in the PR so they all get closed when it gets merged :D 18:20:54 <LordAro> actually, i think i might 18:20:57 <LordAro> the spam will be amazing 18:21:07 <LordAro> haven't yet managed to get DorpsGek kicked for spamming, have we? :p 18:21:57 <TrueBrain> it should not be possible; it just might take a really long time ;) 18:23:04 <LordAro> hmm, #8979 related do you think? can't see intel drivers in the dll list 18:23:15 *** WormnestAndroid has quit IRC 18:23:18 *** WormnestAndroid has joined #openttd 18:23:45 <LordAro> same for #9005 18:24:04 <TrueBrain> unless you are sure a crash-on-startup isn't fixed, close them after release 18:24:08 <TrueBrain> under the assumption they are 18:24:25 <LordAro> mm 18:24:52 <LordAro> Fine, i'll do them nicely with a comment when it's actually released 18:25:37 <LordAro> peter1138: feel like writing a news post? :p 18:29:28 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on discussion #9162: Features needed for New Bridges https://git.io/J3cM2 18:35:37 *** sla_ro|master has joined #openttd 18:48:00 <nielsm> actually, do anyone know if bridges do have any significant performance impact? they're only searched for during drawing and construction underneath them I suppose? 18:54:39 <DorpsGek> [OpenTTD/OpenTTD] Ufiby commented on discussion #9162: Features needed for New Bridges https://git.io/J3cM2 19:01:48 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #9161: Feature: NewGRF Bridges without overriding https://git.io/J3BEz 19:05:06 <DorpsGek> [OpenTTD/OpenTTD] Ufiby commented on discussion #9162: Features needed for New Bridges https://git.io/J3cM2 19:08:11 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on discussion #9162: Features needed for New Bridges https://git.io/J3cM2 19:23:15 *** jottyfan has joined #openttd 19:24:10 *** jottyfan has quit IRC 19:43:44 <DorpsGek> [OpenTTD/OpenTTD] rexxars opened issue #9179: "Input lag" on MacOS long-click since 1.11.0-beta2 https://git.io/J3BrE 19:48:40 *** didac has joined #openttd 19:52:50 <DorpsGek> [OpenTTD/OpenTTD] andythenorth commented on issue #9179: "Input lag" on MacOS long-click since 1.11.0-beta2 https://git.io/J3BrE 19:53:03 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on issue #9179: "Input lag" on MacOS long-click since 1.11.0-beta2 https://git.io/J3BrE 19:59:57 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #9179: "Input lag" on MacOS long-click since 1.11.0-beta2 https://git.io/J3BrE 20:05:00 *** erle- has quit IRC 20:06:45 *** vincentkoevoets has joined #openttd 20:14:10 <DorpsGek> [OpenTTD/OpenTTD] rexxars commented on issue #9179: "Input lag" on MacOS long-click since 1.11.0-beta2 https://git.io/J3BrE 20:20:55 *** vincentkoevoets has left #openttd 20:21:12 *** JohnnyB has joined #openttd 20:21:48 *** JohnnyB is now known as Guest2843 20:23:22 *** Guest2843 is now known as JohnnyB 20:26:04 *** JohnnyB has quit IRC 20:26:08 *** JohnnyB has joined #openttd 20:26:35 *** JohnnyB has left #openttd 20:27:36 <DorpsGek> [OpenTTD/OpenTTD] perezdidac commented on pull request #9043: Feature: ability to build overlapping bridges on different axes (WIP) https://git.io/J3BMO 20:28:25 <DorpsGek> [OpenTTD/OpenTTD] rexxars commented on issue #9179: "Input lag" on MacOS long-click since 1.11.0-beta2 https://git.io/J3BrE 20:29:39 <frosch123> lol... i thought the newbridge-stuff looked very similar to stations. turns out there are copy&pasted comments from stations :p 20:32:19 <LordAro> ha 20:46:37 *** HerzogDeXtEr has quit IRC 20:49:09 <Timberwolf> Giant ships a go-go! https://i.imgur.com/pBDGZs1.png 20:50:03 <TrueBrain> How are we to derive size from that image? :D 20:50:28 <TrueBrain> And please don't get them stuck in canals .. much appreciated, tnx :p 20:50:32 <Timberwolf> It's using MagicaVoxel's scene graph thing to stitch together multiple 256x256x256 voxel cubes. 20:50:53 <Timberwolf> Before the limit of what could be produced and rendered was one of those cubes only. 20:57:02 *** Samu has quit IRC 20:59:24 <Timberwolf> I think if I altered the render settings to capture all of it, that would be about 300 pixels long in the side view. 20:59:41 <Timberwolf> Safe to say the ships don't need to be *quite* that big. 21:00:17 <Timberwolf> But all of the technical challenges are in adding the second cube. 21:00:40 <Timberwolf> I keep telling my boss, "1 to 2 is the biggest scaling challenge" 21:01:39 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #9180: Codechange: Remove FOR_ALL_CHUNK_HANDLERS https://git.io/J3B9h 21:06:59 <glx> of course I didn't check with clang 21:08:23 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #9180: Codechange: Remove FOR_ALL_CHUNK_HANDLERS https://git.io/J3BHF 21:12:39 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #9161: Feature: NewGRF Bridges without overriding https://git.io/J3BQC 21:13:56 <frosch123> i like the irony of: everyone is compaining how awful the newstation specs are. but yet, the two open PRs which want to add new features (road stops, bridges) are both based on the newstations concept :p 21:14:45 <glx> but newstations don't follow the 1,2,3 rule 21:14:55 <frosch123> they do 21:15:06 <glx> in a weird form ;) 21:15:28 <frosch123> they put a layout into action 0, and then use action 1,2,3 to fill in the blanks with sprites 21:15:29 *** gelignite has quit IRC 21:15:29 <nielsm> industry layouts would be a better starting point? 21:15:37 <frosch123> the bridge PR does exactly the same 21:16:20 <frosch123> nielsm: industry/object layouts expose bounding boxes. exposing them had been the biggest mistake in NewGRF history, you don't want that when vehicles are involved 21:16:21 *** Progman has quit IRC 21:16:35 <frosch123> rail/road/tram types are the best example 21:16:44 <frosch123> ottd decides where to draw the sprites 21:17:13 <frosch123> the newgrf decides which sprites to draw in a single place (action 3-2-1), and not split across two places (action 3-2-1 and action 0) 21:17:53 <frosch123> this leaves the bounding boxes in the control of ottd, and gives all the freedom of the sprites to the newgrf 21:21:19 <nielsm> read your long comment now, very much agree on the "not flexible enough" part 21:21:58 <nielsm> it's a better way of explaining what I mean by "being ambitious" in my earlier comment 21:22:46 <nielsm> of course a minimum viable product can have value, but it shouldn't be so minimal you can never expand it 21:23:00 <frosch123> i would not mind if it was a "not flexible enough yet". but I have a problem with enforcing the logic of the original bridges :) 21:23:54 <frosch123> so I do not see it as "too minimal", but rather as "not minimal enough". it includes things that should not be there 21:26:46 <Timberwolf> Heh. Multiboat does not work very well when the renderer still assumes it can cast things to uint8. 21:29:51 *** sla_ro|master has quit IRC 21:32:07 <TrueBrain> https://steamcommunity.com/app/1536610/discussions/0/3130541756148720679/ <- sometimes I just hate gatekeepers enough that I want to reply .. thinking setting up port forwarding is simple means you are out of touch with reality :P 21:34:01 <frosch123> hmm, how does "Steam's relay network" abbreviate to "SDR" :p 21:35:24 <TrueBrain> it stands for Steam Datagram Relay 21:35:57 <TrueBrain> but even that won't mean anything to most, so hence the explanation what it really is :P 21:36:30 <TrueBrain> (and no, it does support TCP-like behaviour, despite being UDP :P) 21:36:50 *** nielsm has quit IRC 21:40:39 <frosch123> night 21:40:42 *** frosch123 has quit IRC 21:56:12 <andythenorth> fireworks.start() for GS when 21:56:13 <andythenorth> ? 21:56:20 <andythenorth> procedural shader or something 22:08:03 <Timberwolf> Enough code, time for rollercoasters. 22:08:29 * andythenorth played a server game 22:08:34 <andythenorth> bedtime now though 22:10:30 *** andythenorth has quit IRC 22:15:15 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #9180: Codechange: Remove FOR_ALL_CHUNK_HANDLERS https://git.io/J3Bxx 22:18:00 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #9181: Fix #9117, 04ce1f07: [Fluidsynth] Infinite wait when stopping song https://git.io/J3Bpt 22:39:41 *** Wolf01 has quit IRC 22:42:43 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on pull request #9180: Codechange: Remove FOR_ALL_CHUNK_HANDLERS https://git.io/J3Rer 23:35:07 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #9180: Codechange: Remove FOR_ALL_CHUNK_HANDLERS https://git.io/J3B9h 23:41:57 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #9180: Codechange: Remove FOR_ALL_CHUNK_HANDLERS https://git.io/J3RIA 23:57:29 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #9180: Codechange: Remove FOR_ALL_CHUNK_HANDLERS https://git.io/J3RtE