Times are UTC Toggle Colours
05:59:57 *** Ox7C5 has joined #openttd 06:25:26 *** Leopold_ has quit IRC 06:26:34 *** Leopold has joined #openttd 06:36:25 *** Leopold has quit IRC 06:37:43 *** Leopold has joined #openttd 06:42:39 <LordAro> i quite like the look of zorg's mockups in #12197 tbh 06:43:10 <LordAro> no idea if it's feasible to overlay text like that though 06:43:22 <LordAro> and it'd need some new icons which is always a pain 06:49:05 <andythenorth> we overlay signs elsewhere with no background (town names) 06:49:24 <andythenorth> and there will be edge cases, mockups of this kind tend to present things in the best light 14:10:46 <truebrain> upgrading dibridge; we will be right back! (on IRC) 14:13:00 *** DorpsGek has quit IRC 14:13:18 *** DorpsGek has joined #openttd 14:13:18 *** ChanServ sets mode: +o DorpsGek 14:13:28 *** ahyangyi has quit IRC 14:13:28 *** khanterwinters has quit IRC 14:13:28 *** georgevb has quit IRC 14:13:28 *** j_n has quit IRC 14:13:28 *** _zephyris has quit IRC 14:13:28 *** tony_pixel has quit IRC 14:13:28 *** klote[d] has quit IRC 14:13:28 *** chucky76 has quit IRC 14:13:28 *** ajmiles has quit IRC 14:13:28 *** sinas128 has quit IRC 14:13:28 *** janciothor has quit IRC 14:13:28 *** gwyd4016 has quit IRC 14:13:28 *** _glados_ has quit IRC 14:13:28 *** brickblock19280 has quit IRC 14:13:28 *** nanapipirara has quit IRC 14:13:28 *** kamnet has quit IRC 14:13:28 *** andythenorth has quit IRC 14:13:28 *** _jgr_ has quit IRC 14:13:28 *** wensimehrp has quit IRC 14:13:28 *** jfs has quit IRC 14:13:28 *** johnfranklin has quit IRC 14:13:28 *** necroprimata has quit IRC 14:13:28 *** frosch123 has quit IRC 14:13:28 *** alfagamma7 has quit IRC 14:13:28 *** merni has quit IRC 14:13:28 *** xarothbrook has quit IRC 14:13:28 *** michi_cc[d] has quit IRC 14:13:28 *** xarick has quit IRC 14:13:28 *** j0anjosep has quit IRC 14:13:28 *** talltyler has quit IRC 14:13:28 *** rau117 has quit IRC 14:13:28 *** belajalilija has quit IRC 14:13:28 *** locosage has quit IRC 14:13:28 *** truebrain has quit IRC 14:13:28 *** emperorjake has quit IRC 14:13:28 *** reldred has quit IRC 14:13:28 *** peter1138 has quit IRC 14:13:28 *** _glx_ has quit IRC 14:13:28 *** DorpsGek_vi has quit IRC 14:13:28 *** _rei4122 has quit IRC 14:13:28 *** kuhnovic has quit IRC 14:13:38 *** DorpsGek_vi has joined #openttd 14:15:35 *** truebrain has joined #openttd 14:15:35 <truebrain> right ... most things are up-to-date again, and no longer failing CI etc đ How lovely 14:16:48 *** Ox7C5 has joined #openttd 14:18:47 <LordAro> \o/ 14:20:05 <truebrain> the bananas-api upgrade PR is a bit in a limbo state ... dependabot keeps claiming it is still rebasing it, but nothing is really happening đ 14:24:56 *** nielsm has joined #openttd 14:38:37 *** _glx_ has joined #openttd 14:38:37 <_glx_> Exception levĂ©e Ă 0x00007FF9BC3F5B0C dans openttd.exe : exception Microsoft C++ : fmt::v10::format_error Ă l'emplacement de mĂ©moire 0x00000042161FD3E8. 14:38:37 <_glx_> Exception levĂ©e Ă 0x00007FF9BC3F5B0C dans openttd.exe : exception Microsoft C++ : [rethrow] Ă l'emplacement de mĂ©moire 0x0000000000000000. 14:38:37 <_glx_> Exception levĂ©e Ă 0x00007FF9BC3F5B0C dans openttd.exe : exception Microsoft C++ : fmt::v10::format_error Ă l'emplacement de mĂ©moire 0x00000042161FD3E8. 14:38:37 <_glx_> Exception levĂ©e Ă 0x00007FF9BC3F5B0C dans openttd.exe : exception Microsoft C++ : [rethrow] Ă l'emplacement de mĂ©moire 0x0000000000000000. 14:38:37 <_glx_> Exception levĂ©e Ă 0x00007FF9BC3F5B0C dans openttd.exe : exception Microsoft C++ : fmt::v10::format_error Ă l'emplacement de mĂ©moire 0x00000042161FD3E8. 14:38:39 <_glx_> clientcore\windows\advcore\ctf\uim\tim.cpp(800)\MSCTF.dll!00007FF9BDD465D9: (caller: 00007FF9BDD4720C) LogHr(3) tid(89ec) 8007029C Un Ă©chec dâassertion sâest produit. 14:38:39 <_glx_> clientcore\windows\advcore\ctf\uim\tim.cpp(800)\MSCTF.dll!00007FF9BDD465D9: (caller: 00007FF9BDD4720C) LogHr(4) tid(89ec) 8007029C Un Ă©chec dâassertion sâest produit. 14:38:41 <_glx_> ``` the NOT_REACHED in start thread is so annoying, I can see what could be wrong, but not where 14:39:35 <_glx_> (might be my debug expressions) 14:40:46 <truebrain> remove the NOT_REACHED, and let the exception just happen! đ 14:42:12 <truebrain> but at least you know it is fmt that is throwing an exception here đ 14:43:58 <_glx_> yeah but it's used a lot, I partially know the area as I'm doing GS string tests 14:55:50 *** xarick has joined #openttd 14:55:50 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1213137621803470879/Captura_de_ecra_2024-03-01_143513.png?ex=65f46174&is=65e1ec74&hm=1bb83ca9fa8d84c8565836efc035ccc4481f5dfb6b7f9077e71a61e4b9d245d6& 14:55:50 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1213137622336278578/Captura_de_ecra_2024-03-01_143733.png?ex=65f46174&is=65e1ec74&hm=ab8e78a80b2ef867c2591c45d15005aeb1642cc1750a70ab52bbc8b65eb1c583& 14:55:50 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1213137622629621771/Captura_de_ecra_2024-03-01_144015.png?ex=65f46174&is=65e1ec74&hm=51dd1b2f266deed3782adbf2b12f8184d80b67fb17685823ce0ace34b4cf8785& 14:55:50 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1213137622935937105/Captura_de_ecra_2024-03-01_144220.png?ex=65f46174&is=65e1ec74&hm=83841d9399addca29afda7c90c4c2814f9403271ec7d87e78fd9e4466b7dab55& 14:55:50 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1213137623183392808/Captura_de_ecra_2024-03-01_144347.png?ex=65f46174&is=65e1ec74&hm=a368e9a3bdf1c4093feffec132e863a6b83c86d6f6b27ae034156c0f2e9b765c& 14:55:52 <xarick> meanwhile 14:57:55 <xarick> any of these savegame statistics interest you for your testings, peter1138 ? 14:59:10 <_glx_> ok removing the try/catch I get a better view, but the dmp just point to a try/catch block in SQVM 14:59:38 <xarick> GSString? 15:00:07 <_glx_> I know it's related to GSText as that's what I'm working on đ 15:00:52 <_glx_> but tracking exceptions in scripts is a pain 15:01:32 <_glx_> it's full of `catch (...)` 15:04:03 <_glx_> it's fine to handle our expected exceptions used to control script run, but not for real errors 15:06:46 <_glx_> hmm I think I know what is my error 15:08:15 *** Flygon has joined #openttd 15:08:28 <_glx_> yeah fmt doesn't like printing nullptr 15:09:28 *** ufo-piloot has joined #openttd 15:11:18 <truebrain> `fmt::ptr(nullptr)` đ 15:11:22 <truebrain> it does't like printing any pointer btw 15:14:16 <_glx_> yeah but I wanted to print a const char* string đ 15:14:51 <_glx_> at least we know the most likely cause to trigger the NOT_REACHED is fmt 15:15:24 <_glx_> as we don't fire too many exceptions, and we usually handle our own 15:16:12 <_glx_> it's just impossible to trace as soon a `catch (...)` intercepts it 15:29:47 *** _jgr_ has joined #openttd 15:29:47 <_jgr_> _glx_: You could replace those with a `catch (std::exception &ex)` 15:30:33 <_jgr_> Then feed ex.what into FatalErrorI or whatever 15:41:59 <_glx_> but that won't help to know where it was thrown 15:51:51 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1213151728359186452/image.png?ex=65f46e97&is=65e1f997&hm=4b116c3084a5199473f6adae2bf971a9243a3c36a4f74078cba7706fffdd8e01& 15:51:51 <_glx_> yeah a little more informative than NOT_REACHED 15:52:36 <_glx_> still impossible to trace, but at least it gives some details 15:58:02 *** nielsm has quit IRC 15:58:24 *** ebla71 has joined #openttd 16:03:21 <truebrain> Not a way to retrieve the file and linenumber of an exception? 16:06:36 <_jgr_> You can subclass std::exception to add stuff like that but it doesn't capture anything along those lines out of the box 16:17:38 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #12199: Codechange: Don't use NOT_REACHED() when catching thread exceptions https://github.com/OpenTTD/OpenTTD/pull/12199 16:28:18 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #12199: Codechange: Don't use NOT_REACHED() when catching unhandled thread exceptions https://github.com/OpenTTD/OpenTTD/pull/12199#pullrequestreview-1911536955 16:36:36 <xarick> I created a commit on a detached head... đŠ 16:36:49 <xarick> how do I fix this 16:37:21 <xarick> I don't want to lose it 16:37:28 <LordAro> git checkout -b my-branch-name 16:38:32 <xarick> hmm which branch should I use? 16:38:43 <xarick> master? 16:38:54 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #12199: Codechange: Don't use NOT_REACHED() when catching unhandled thread exceptions https://github.com/OpenTTD/OpenTTD/pull/12199#pullrequestreview-1911559785 16:38:58 <LordAro> no 16:39:06 <LordAro> the above command creates a branch 16:51:20 *** Wormnest has joined #openttd 17:12:56 *** ahyangyi has joined #openttd 17:12:56 <ahyangyi> Oh 17:13:03 <xarick> thx 17:13:04 <ahyangyi> I don't use jgrpp-0.57.1 17:13:14 <ahyangyi> I use jgrpp-0.57.1-H5E83286A 17:13:54 <ahyangyi> Where would my statistics go 17:14:30 <_glx_> H ? 17:14:33 <_jgr_> They won't go anywhere without a survey key compiled into your build 17:15:12 <xarick> ```for (const TileIndex &tile : ta) { 17:15:12 <xarick> for (const TileIndex tile : ta) { 17:15:12 <xarick> for (TileIndex tile : ta) { 17:15:12 <xarick> for (TileIndex &tile : ta) {``` 17:15:12 <xarick> which one should I use? ta is a TileArea 17:15:32 <_glx_> first one looks fine 17:15:47 <xarick> oh, the last one doesn'twork 17:15:57 <Ox7C5> 1 17:16:01 <_glx_> you don't expect to modify the tile, and you don't want a copy 17:16:43 <xarick> so, it's the first? 17:17:05 <_glx_> yes always use const references where possible 17:17:17 <xarick> gonna const everything from now on 17:17:34 <xarick> ah, references is the & symbol right? 17:17:47 <_glx_> yes 17:18:12 <LordAro> *except for basic types like int and bool and things 17:18:22 <LordAro> just going to get ahead of the inevitable there 17:18:41 <xarick> const TileArea &ta = st->docking_station; 17:20:16 *** kuhnovic has joined #openttd 17:20:16 <kuhnovic> And be very careful with accidential copies. They can be hard to spot if you're not used to taking them into account. They can cause a performance hit, or worse: you end up modifying a copy instead of the original, and then you wonder why the damn thing doesn't work 17:20:45 <_glx_> you're not supposed to modify a const đ 17:20:48 <kuhnovic> It's a rite of passage of becoming a C++ developer đ 17:21:31 <_glx_> but yeah references are less explicit than pointers 17:21:35 <kuhnovic> _glx_: I wasn't talking about const here đ 17:22:02 <_glx_> so it's easy to make a copy when you actually wanted a reference 17:22:08 <kuhnovic> We'll have that conversation when we see him pull out the good old const_cast sledgehammer 17:23:59 <_glx_> `type a = b; a.field = x;` is not the same as `type &a = b; a.field = x;` 17:25:30 <_glx_> second does like `type *a = &b; a->field = x;` 17:34:25 *** peter1138 has joined #openttd 17:34:25 <peter1138> LordAro: And TileIndex... 17:35:00 <LordAro> true. 17:36:41 *** locosage has joined #openttd 17:36:41 <locosage> _jgr_: iirc technically they'll still go to survey server but then will be discarded 17:38:28 <_jgr_> I turned off sending them at all if there's no survey key 17:40:46 <xarick> error C2338: static_assert failed: 'The C++ Standard forbids containers of const elements because allocator<const T> is ill-formed.' 17:40:59 <xarick> english pls 17:42:02 <_jgr_> Just remove the const 17:42:25 <xarick> oh ok 17:43:45 <kuhnovic> Items in std containers must be assignable, and you can't assign to something that's const 17:45:36 <locosage> _jgr_: ah, I was thinking vanilla 17:53:29 <DorpsGek> [OpenTTD/OpenTTD] 1f5 opened pull request #12200: Codechange: Replace custom rounded square root logic with standard library functions https://github.com/OpenTTD/OpenTTD/pull/12200 17:54:55 <LordAro> đ€ 17:55:38 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #12200: Codechange: Replace custom rounded square root logic with standard library functions https://github.com/OpenTTD/OpenTTD/pull/12200#issuecomment-1973635353 17:56:06 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #12200: Codechange: Replace custom rounded square root logic with standard library functions https://github.com/OpenTTD/OpenTTD/pull/12200#issuecomment-1973636516 17:56:33 *** merni has joined #openttd 17:56:33 <merni> Also, why retain the function as an alias instead of just using the standard function> 17:57:25 <LordAro> well because you'd have to do round(sqrt(x)) every time 17:57:29 <LordAro> which would get irritating 17:57:45 <merni> I guess 18:05:32 <DorpsGek> [OpenTTD/OpenTTD] frosch123 closed pull request #12200: Codechange: Replace custom rounded square root logic with standard library functions https://github.com/OpenTTD/OpenTTD/pull/12200 18:05:35 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #12200: Codechange: Replace custom rounded square root logic with standard library functions https://github.com/OpenTTD/OpenTTD/pull/12200#issuecomment-1973657772 18:06:12 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #12200: Codechange: Replace custom rounded square root logic with standard library functions https://github.com/OpenTTD/OpenTTD/pull/12200#issuecomment-1973659678 18:06:29 *** frosch123 has joined #openttd 18:06:29 <frosch123> faster :p 18:06:36 <LordAro> oof. 18:07:47 <LordAro> looks like it's only used for infrastructure costs 18:07:51 <_glx_> and we rely on int being 32bit everywhere đ 18:08:08 <peter1138> Heh 18:08:32 <_glx_> but there's a static assert somewhere about that IIRC 18:08:47 <_jgr_> _glx_: Changing the size of int would break so many projects that's all but ossified into stone now 18:09:16 <LordAro> unless you're in the embedded world