Config
Log for #openttd on 26th April 2025:
Times are UTC Toggle Colours
00:59:50  *** WormnestAndroid has quit IRC
00:59:51  *** WormnestAndroid has joined #openttd
01:00:30  *** akimoto has quit IRC
01:56:04  *** Wormnest has quit IRC
02:11:45  <DorpsGek> [OpenTTD/OpenTTD] vitoyucepi started discussion #14106: How can I adjust the scaling of different UI elements without affecting the other elements? https://github.com/OpenTTD/OpenTTD/discussions/14106
02:32:18  *** gnu_jj_ has joined #openttd
02:35:45  *** gnu_jj has quit IRC
02:50:07  <DorpsGek> [OpenTTD/OpenTTD] vitoyucepi opened issue #14107: [Bug]: Sometimes text may get corrupted when changing https://github.com/OpenTTD/OpenTTD/issues/14107
04:08:03  <DorpsGek> [OpenTTD/OpenGFX2] PeterN opened issue #191: Magenta pixels in road tunnel entrances https://github.com/OpenTTD/OpenGFX2/issues/191
04:12:06  *** keikoz has joined #openttd
04:44:20  <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/bb1d5613690e82d62271259ae0a5c6f1e8506dd6
04:44:21  <DorpsGek>   - Update: Translations from eints (by translators)
05:21:01  *** reldred has joined #openttd
05:21:01  <reldred> damn, folks are really enjoying the house picker feature
05:21:24  *** keikoz has quit IRC
05:25:11  *** keikoz has joined #openttd
05:29:03  *** nielsm has joined #openttd
05:40:40  <DorpsGek> [OpenTTD/OpenTTD] Release workflow was not successful https://github.com/OpenTTD/OpenTTD/actions/runs/14678115240
07:20:40  <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on discussion #14106: How can I adjust the scaling of different UI elements without affecting the other elements? https://github.com/OpenTTD/OpenTTD/discussions/14106
08:09:30  *** Wolf01 has joined #openttd
08:41:34  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #14108: Codechange: use std::string_view for console command callbacks https://github.com/OpenTTD/OpenTTD/pull/14108
08:42:33  <DorpsGek> [OpenTTD/OpenTTD] vitoyucepi commented on discussion #14106: How can I adjust the scaling of different UI elements without affecting the other elements? https://github.com/OpenTTD/OpenTTD/discussions/14106
08:46:12  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on discussion #14106: How can I adjust the scaling of different UI elements without affecting the other elements? https://github.com/OpenTTD/OpenTTD/discussions/14106
08:50:00  <peter1138> Well, urgh, overslept :(
09:01:14  <peter1138> And the coffee is weak :(
09:03:41  <kuhnovic> Did you use the instant stuff again?
09:09:28  *** Flygon has quit IRC
09:15:06  <andythenorth> overslept is an odd concept
09:15:12  <andythenorth> sleeping happens when it happens
09:25:19  <peter1138> No, it's not instant.
09:28:21  <DorpsGek> [OpenTTD/OpenGFX2] PeterN commented on pull request #188: Feature: Clearer NewGRF download list checkmark https://github.com/OpenTTD/OpenGFX2/pull/188#issuecomment-2831990196
09:34:08  <xarick> hi
09:36:04  <reldred> I get a massive headache if I oversleep
09:37:11  <andythenorth> "dehydration"
09:37:15  <andythenorth> or boredom
09:37:23  <reldred> nah not dehydration
09:37:39  <peter1138> And overslept is just "I have a thing I needed to do before X o'clock but I woke up after X o'clock"
09:38:36  <andythenorth> oof
09:52:48  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #14109: Codechange: use std::string_view over const char * https://github.com/OpenTTD/OpenTTD/pull/14109
09:57:25  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14091: Fix: [NewGRF] For animation-triggers which do not supply a cargo-type in var18, the var18 bits should remain empty. https://github.com/OpenTTD/OpenTTD/pull/14091#pullrequestreview-2795873897
09:59:38  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14089: Change: [NewGRF] Animation-trigger 'construction stage changed' of houses and industries now also triggers at construction start. https://github.com/OpenTTD/OpenTTD/pull/14089#pullrequestreview-2795874239
10:01:41  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14080: Add: [NewGRF] Station/roadstop animation-triggers 'tile loop' (bit 7) and 'path reservation' (bit 8). https://github.com/OpenTTD/OpenTTD/pull/14080#pullrequestreview-2795875260
10:07:20  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14110: Fix #14107: Invalidate all shared vehicle windows when changing group. https://github.com/OpenTTD/OpenTTD/pull/14110
10:08:35  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14111: Codechange: Defer refreshing company finance windows. https://github.com/OpenTTD/OpenTTD/pull/14111
10:11:41  <peter1138> andythenorth, so not cycling with the group today, as they leave at 9am. And becuase I'm lazy that just means I don't bother.
10:14:53  <andythenorth> I didn't get up and go swimming
10:16:53  <jfkuayue> Andy swimming 😮
10:19:50  <peter1138> In the Avon.
10:20:05  <andythenorth> unlikely
10:24:01  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14110: Fix #14107: Invalidate all shared vehicle windows when changing group. https://github.com/OpenTTD/OpenTTD/pull/14110#pullrequestreview-2795890519
10:29:27  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14111: Codechange: Defer refreshing company finance windows. https://github.com/OpenTTD/OpenTTD/pull/14111#pullrequestreview-2795900265
10:49:46  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14110: Fix #14107: Invalidate all shared vehicle windows when changing group. https://github.com/OpenTTD/OpenTTD/pull/14110
10:49:49  <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #14107: [Bug]: Sometimes text may get corrupted when changing https://github.com/OpenTTD/OpenTTD/issues/14107
10:50:55  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14111: Codechange: Defer refreshing company finance windows. https://github.com/OpenTTD/OpenTTD/pull/14111
11:00:11  *** WormnestAndroid has quit IRC
11:00:23  *** WormnestAndroid has joined #openttd
11:14:06  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14112: Fix #14107: Mark the company value in the company view window dirty when it changes. https://github.com/OpenTTD/OpenTTD/pull/14112
11:21:07  *** SigHunter has quit IRC
11:22:49  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14112: Fix #14107: Mark the company value in the company view window dirty when it changes. https://github.com/OpenTTD/OpenTTD/pull/14112#pullrequestreview-2795937459
11:24:03  *** SigHunter has joined #openttd
11:28:33  <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #14108: Codechange: use std::string_view for console command callbacks https://github.com/OpenTTD/OpenTTD/pull/14108#pullrequestreview-2795938352
11:49:40  <peter1138> Bah, things like GetRailDepotFrontTile annoy me ;(
11:54:33  <_jgr_> What's wrong with it?
11:54:52  <peter1138> Makes my ideas more difficult to implement :)
11:56:16  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14112: Fix #14107: Mark the company value in the company view window dirty when it changes. https://github.com/OpenTTD/OpenTTD/pull/14112
11:57:55  <DorpsGek> [OpenTTD/team] glx22 commented on issue #629: [hi_IN] Translator access request https://github.com/OpenTTD/team/issues/629
12:02:40  <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #14096: Change: [Script] Reject scripts using negative version https://github.com/OpenTTD/OpenTTD/pull/14096
12:04:36  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14109: Codechange: use std::string_view over const char * https://github.com/OpenTTD/OpenTTD/pull/14109#pullrequestreview-2795944438
12:15:13  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #14108: Codechange: use std::string_view for console command callbacks https://github.com/OpenTTD/OpenTTD/pull/14108
12:15:58  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 closed pull request #14093: Codechange: make IConsoleCmdExec use C++ strings internally https://github.com/OpenTTD/OpenTTD/pull/14093
12:17:10  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #14109: Codechange: use std::string_view over const char * https://github.com/OpenTTD/OpenTTD/pull/14109
12:28:13  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #14113: Codechange: use std::string_view for town name generation https://github.com/OpenTTD/OpenTTD/pull/14113
12:29:34  <xarick> how do i test an area contains an area
12:29:41  <xarick> Intersects?
12:31:19  <_glx_> fully inside another area or partially ?
12:31:51  *** Wolf01 has quit IRC
12:34:37  <DorpsGek> [OpenTTD/OpenGFX2] zephyris commented on issue #191: Magenta pixels in road tunnel entrances https://github.com/OpenTTD/OpenGFX2/issues/191
12:34:48  *** Wolf01 has joined #openttd
12:35:01  <xarick> fully inside
12:39:05  <frosch123> Two months ago we banned someone from bananas for uploading other people's content. Now they sent some anime girl mspaint picture to us and some other game studio support mails :p
12:42:03  <_glx_> fully inside is easy, you just need to check limits of contained area are inside limits of containing area
12:42:53  <DorpsGek> [OpenTTD/OpenTTD] frosch123 closed issue #12986: [Bug]: Setting house property 16 to > 0 prevents callback 1B from running at the start of the game. https://github.com/OpenTTD/OpenTTD/issues/12986
12:42:56  <DorpsGek> [OpenTTD/OpenTTD] frosch123 closed pull request #14078: Add: [NewGRF] House animation-trigger 'built' (callback 0x164). https://github.com/OpenTTD/OpenTTD/pull/14078
12:42:59  <DorpsGek> [OpenTTD/OpenTTD] frosch123 closed pull request #14077: Add: [NewGRF] Industry animation-trigger 'built' (bit 5). https://github.com/OpenTTD/OpenTTD/pull/14077
12:43:02  <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14089: Change: [NewGRF] Animation-trigger 'construction stage changed' of houses and industries now also triggers at construction start. https://github.com/OpenTTD/OpenTTD/pull/14089
12:43:30  *** squirejames has joined #openttd
12:43:30  <squirejames> frosch123: weebs gonna weeb
12:44:10  <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14091: Fix: [NewGRF] For animation-triggers which do not supply a cargo-type in var18, the var18 bits should remain empty. https://github.com/OpenTTD/OpenTTD/pull/14091
12:44:58  <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14080: Add: [NewGRF] Station/roadstop animation-triggers 'tile loop' (bit 7) and 'path reservation' (bit 8). https://github.com/OpenTTD/OpenTTD/pull/14080
12:48:33  <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14092: Fix: [NewGRF] Cargo-types for airport-tile animation-triggers were not properly translated. https://github.com/OpenTTD/OpenTTD/pull/14092
12:49:07  <reldred> peter1138: 👀
12:51:16  <reldred> talltyler: you know me so well
12:52:22  <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14095: Add: [NewGRF] Provide random bits in var10 of house callback 1C 'construction stage changed'. https://github.com/OpenTTD/OpenTTD/pull/14095
12:57:41  <talltyler> Me too 😛
12:58:10  <talltyler> You can tell because we’ve both memorized the PR number
12:58:53  <reldred> Yup
13:05:13  <reldred> https://cdn.discordapp.com/attachments/1008473233844097104/1365675084135665786/9s09ou.jpg?ex=680e2b89&is=680cda09&hm=861a5cd3e242da9db5721966d16434c490e808258cd5bbe127e38ad5c8bf6ef2&
13:05:38  <reldred> okay probably one of the more obscure memes I've made
13:20:59  <peter1138[d]> Yea, related
13:33:30  <DorpsGek> [OpenTTD/OpenGFX2] zephyris merged pull request #188: Feature: Clearer NewGRF download list checkmark https://github.com/OpenTTD/OpenGFX2/pull/188
13:36:29  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14105: Fix #14104, 67a0fcc: Don't base timetable timing decisions on client settings. https://github.com/OpenTTD/OpenTTD/pull/14105#pullrequestreview-2796005210
13:37:09  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14092: Fix: [NewGRF] Cargo-types for airport-tile animation-triggers were not properly translated. https://github.com/OpenTTD/OpenTTD/pull/14092#pullrequestreview-2796006067
13:37:56  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14095: Add: [NewGRF] Provide random bits in var10 of house callback 1C 'construction stage changed'. https://github.com/OpenTTD/OpenTTD/pull/14095#pullrequestreview-2796007435
13:38:44  *** WormnestAndroid has quit IRC
13:42:19  <truebrain> frosch123: I was wondering what that was about 😛
13:46:04  *** WormnestAndroid has joined #openttd
13:47:24  <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14114: Fix: Road vehicle blocking and train collissions used slightly inconsistent distance thresholds. https://github.com/OpenTTD/OpenTTD/pull/14114
13:47:35  <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14103: Codechange: Replace FindVehicleOnPosXY + callbacks with iterator VehiclesNearTileXY + loop. https://github.com/OpenTTD/OpenTTD/pull/14103
13:48:00  <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14103: Codechange: Replace FindVehicleOnPosXY + callbacks with iterator VehiclesNearTileXY + loop. https://github.com/OpenTTD/OpenTTD/pull/14103#pullrequestreview-2796011270
13:58:03  <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14114: Fix: Road vehicle blocking and train collissions used slightly inconsistent distance thresholds. https://github.com/OpenTTD/OpenTTD/pull/14114
13:58:34  <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14092: Fix: [NewGRF] Cargo-types for airport-tile animation-triggers were not properly translated. https://github.com/OpenTTD/OpenTTD/pull/14092
13:58:48  <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14095: Add: [NewGRF] Provide random bits in var10 of house callback 1C 'construction stage changed'. https://github.com/OpenTTD/OpenTTD/pull/14095
13:59:55  <LordAro> frosch123: there's a few collision related issues floating around, does #14114 fix any of them?
14:01:37  <frosch123> I am not aware of any issues floating around. But 14114 is minor, I doubt anyone noticed  those
14:03:10  <LordAro> #8424 & #10493 were what i had in mind
14:06:31  <DorpsGek> [OpenTTD/OpenGFX2] zephyris opened pull request #192: Fix: Protect special magenta shades in building shape processing https://github.com/OpenTTD/OpenGFX2/pull/192
14:08:25  <peter1138> Those two are not related to an incorrect distance check.
14:09:03  <LordAro> very good
14:09:04  <peter1138> It might potentially fix the disconnecting road vehicles issue, but.
14:14:21  <reldred> I need to learn some more about how articulated vehicles work at some point
14:14:29  <reldred> so I can revisit that silly little road experiment
14:15:52  <reldred> articulated vehicles disconnecting was the main issue that had
14:16:54  <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #14109: Codechange: use std::string_view over const char * https://github.com/OpenTTD/OpenTTD/pull/14109#pullrequestreview-2796047187
14:18:38  <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #14113: Codechange: use std::string_view for town name generation https://github.com/OpenTTD/OpenTTD/pull/14113#pullrequestreview-2796049377
14:25:50  * peter1138 mumbles about side-quests.
14:26:39  <reldred> sigh I was supposed to start printing off another army today
14:26:49  <reldred> but likewise, sidequests
14:30:20  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #14109: Codechange: use std::string_view over const char * https://github.com/OpenTTD/OpenTTD/pull/14109
14:30:34  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #14113: Codechange: use std::string_view for town name generation https://github.com/OpenTTD/OpenTTD/pull/14113
14:36:56  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #14115: Codefix: checking unsigned int >= 0 is pointless, check before subtraction https://github.com/OpenTTD/OpenTTD/pull/14115
14:44:48  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14103: Codechange: Replace FindVehicleOnPosXY + callbacks with iterator VehiclesNearTileXY + loop. https://github.com/OpenTTD/OpenTTD/pull/14103#pullrequestreview-2796102937
14:45:03  <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #14115: Codefix: checking unsigned int >= 0 is pointless, check before subtraction https://github.com/OpenTTD/OpenTTD/pull/14115#pullrequestreview-2796103886
14:45:06  <peter1138> Whoops.
14:47:10  <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #14115: Codefix: checking unsigned int >= 0 is pointless, check before subtraction https://github.com/OpenTTD/OpenTTD/pull/14115#pullrequestreview-2796113620
14:55:00  <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14103: Codechange: Replace FindVehicleOnPosXY + callbacks with iterator VehiclesNearTileXY + loop. https://github.com/OpenTTD/OpenTTD/pull/14103
14:55:43  <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14114: Fix: Road vehicle blocking and train collissions used slightly inconsistent distance thresholds. https://github.com/OpenTTD/OpenTTD/pull/14114
15:00:19  <frosch123> Grep says number of char* matches went down from ~800 to 511 in last two weeks. Thanks rubidium :)
15:00:35  *** zanooda2000 has quit IRC
15:02:42  <xarick> my rail station placement code is horrendous
15:03:42  <xarick> i mean... not horrendous, it's just slow
15:04:03  <xarick> it's actually quite decent
15:04:19  <xarick> but 60 days to find a spot... that's bad
15:05:14  <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1365705286446481649/image.png?ex=680e47a9&is=680cf629&hm=b85b308578084af87819efee9149ddbe15d67124dbca8e1156554a1140aa5b49&
15:05:14  <andythenorth> hmm this is a bug, but maybe it should be a feature 😛
15:05:27  <andythenorth> mask layer was rendered and used a spritelayer 😛
15:05:35  <andythenorth> "look inside the vehicle"
15:05:39  <andythenorth> "see the cargo"
15:08:16  <Rubidium> frosch123: excluding only 3rdparty/opengl/glext.h ?
15:10:01  <frosch123> Excluding all of 3rdparty
15:10:43  *** zanooda2000 has joined #openttd
15:10:43  <zanooda2000> andythenorth: Well... even if you don't take it as a joke, this could be useful in newgrf debugging. Well at least in xussr cargo is also drawn as a layer so, easier to fix misaligment for example
15:13:30  <Rubidium> I can't get a grep that shows 511 except when only excluding opengl/glext.h
15:15:07  <Rubidium> but then I'm assuming HEAD, in src etc.
15:16:25  <Rubidium> in the end it doesn't really matter, as long as numbers for char* are going down. Getting to 0 is going to be a tough cookie
15:18:18  <peter1138[d]> 625, including CODINGSTYLE.md, .xpm files etc...
15:24:33  <truebrain> Take the compliment! Lol ...
15:41:58  <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14116: Codechange: Move usage of ResolverObjects to newgrf_xxx.cpp https://github.com/OpenTTD/OpenTTD/pull/14116
15:43:07  <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14116: Codechange: Move usage of ResolverObjects to newgrf_xxx.cpp https://github.com/OpenTTD/OpenTTD/pull/14116
16:04:52  *** WormnestAndroid has quit IRC
16:07:15  *** WormnestAndroid has joined #openttd
16:15:33  <DorpsGek> [OpenTTD/OpenTTD] zephyris updated pull request #12131: Fix: Scale graph gridlines and axes with GUI scale https://github.com/OpenTTD/OpenTTD/pull/12131
16:31:40  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #14115: Codefix: checking unsigned int >= 0 is pointless, check before subtraction https://github.com/OpenTTD/OpenTTD/pull/14115
16:37:26  *** WormnestAndroid has quit IRC
16:39:48  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14116: Codechange: Move usage of ResolverObjects to newgrf_xxx.cpp https://github.com/OpenTTD/OpenTTD/pull/14116#pullrequestreview-2796264107
16:51:22  *** WormnestAndroid has joined #openttd
16:52:47  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #14114: Fix: Road vehicle blocking and train collissions used slightly inconsistent distance thresholds. https://github.com/OpenTTD/OpenTTD/pull/14114#pullrequestreview-2796271557
17:01:36  *** WormnestAndroid has quit IRC
17:02:04  *** WormnestAndroid has joined #openttd
17:03:25  *** Flygon has joined #openttd
17:18:58  *** WormnestAndroid has quit IRC
17:19:00  *** WormnestAndroid has joined #openttd
17:27:25  <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1365741068292984954/image.png?ex=680e68fc&is=680d177c&hm=e1e535c8a3ac04384a6023f1afc587d1d20808c1a7af85bb3e75ceccfa09f7ac&
17:27:25  <peter1138[d]> Too weird of a UI?
17:27:37  <peter1138[d]> "Is it a window or a menu..."
17:27:40  <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14117: Codechange: Use enums as keys to spritegroups in GRFFileProps. https://github.com/OpenTTD/OpenTTD/pull/14117
17:29:11  <andythenorth> it's a filter panel 😛
17:29:19  <andythenorth> they're always weird
17:32:00  *** alpapilus has joined #openttd
17:32:00  <alpapilus> peter1138[d]: It’s ok.
17:33:02  <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14114: Fix: Road vehicle blocking and train collissions used slightly inconsistent distance thresholds. https://github.com/OpenTTD/OpenTTD/pull/14114
17:34:30  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14117: Codechange: Use enums as keys to spritegroups in GRFFileProps. https://github.com/OpenTTD/OpenTTD/pull/14117#pullrequestreview-2796291901
17:34:32  <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14102: Add: Limit height of settings description, and add scrollbar. https://github.com/OpenTTD/OpenTTD/pull/14102#issuecomment-2832460867
17:36:53  <frosch123> Actions are broken again in 14116
17:38:01  *** belajalilija has joined #openttd
17:38:01  <belajalilija> peter1138[d]: Could you swap the reset/close buttons on the grf params menu or add an are you sure window when reset is pressed?
17:38:45  <peter1138[d]> Swap? What close button?
17:39:47  <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14116: Codechange: Move usage of ResolverObjects to newgrf_xxx.cpp https://github.com/OpenTTD/OpenTTD/pull/14116
17:40:21  <belajalilija> peter1138[d]: The one to the left of reset
17:40:49  <belajalilija> I often hit reset by mistake when expanding the window and its pretty annoying
17:42:11  <_zephyris> Drag and drop to reorder?
17:42:34  <_zephyris> (prssumably that's not consistent across various lists)
17:42:58  <_zephyris> Hmm. Still odd in a filter panel.
17:52:58  <peter1138> belajalilija, something is wrong because that isn't a close button.
17:53:37  <peter1138> And the Reset option is not anywhere near the resize button.
17:55:01  <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14117: Codechange: Use enums as keys to spritegroups in GRFFileProps. https://github.com/OpenTTD/OpenTTD/pull/14117
17:55:16  <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14117: Codechange: Use enums as keys to spritegroups in GRFFileProps. https://github.com/OpenTTD/OpenTTD/pull/14117#pullrequestreview-2796316382
17:57:00  <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #14117: Codechange: Use enums as keys to spritegroups in GRFFileProps. https://github.com/OpenTTD/OpenTTD/pull/14117
17:58:00  <belajalilija> peter1138: On the grf params window?
17:58:36  <peter1138> Oh.
17:59:02  <peter1138> So I posted a picture of the badge configuration and you decided to reply about something completely different. Gotcha.
17:59:39  <belajalilija> Kinda, i replied because they both relate to UI
18:02:59  *** honza_ has joined #openttd
18:02:59  <honza_> a little question. Is the thing, that it's not possible for user to unpause the game when paused by game script intended feature?
18:08:29  *** nielsm has quit IRC
18:29:19  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14118: Change: Use same padding as NewGRF parameters for AI/GS parameter lists. https://github.com/OpenTTD/OpenTTD/pull/14118
18:33:41  <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #14118: Change: Use same padding as NewGRF parameters for AI/GS parameter lists. https://github.com/OpenTTD/OpenTTD/pull/14118#issuecomment-2832512928
18:41:11  *** WormnestAndroid has quit IRC
18:42:16  *** WormnestAndroid has joined #openttd
18:42:17  *** nielsm has joined #openttd
18:43:43  <talltyler> honza_: Yes, that’s intended.
18:44:37  <peter1138> I...
18:44:50  <alpapilus> It’s Peter again!
18:45:17  <talltyler> You must be new. Peter is always here. 😄
18:45:25  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14118: Change: Use same padding as NewGRF parameters for AI/GS parameter lists. https://github.com/OpenTTD/OpenTTD/pull/14118#issuecomment-2832519693
18:45:35  <squirejames> Peter is eternal
18:45:49  <alpapilus> talltyler: I don’t visit Discord channel #openttd-development that much.
18:45:57  <alpapilus> But whenever I visit.
18:46:03  <alpapilus> Theres Peter.
18:46:28  <alpapilus> Who’s Peter? I’ll never know.
18:47:29  <LordAro> peter1138: are you going to make me get off the sofa and draw it?
18:47:39  <peter1138> Yes, because I don't get what you mean.
18:47:59  <peter1138> Like, WWT_MATRIX lists have defined element padding.
18:48:08  <peter1138> And each item is fixed height.
18:48:41  <LordAro> i mean the window as a whole - just above "Engine: All" in this particular case
18:48:47  <LordAro> +s
18:48:50  <peter1138> So if you mean give each element each vertical space, that's possible but is weird for a WWT_MATRIX.
18:49:13  <LordAro> yeah, the individual rows are fine
18:49:19  <peter1138> What space would go there?
18:49:34  <LordAro> dunno, something equal to the left side indent?
18:49:35  <peter1138> It would just move the list down, looking like a separate widget?
18:49:57  <LordAro> to me it looks too close to the title bar, is all
18:50:09  <LordAro> (obviously it was like that before too, but..)
18:50:33  <alpapilus> How do they even communicate
18:51:33  <alpapilus> I’m fascinated.
18:52:19  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14118: Change: Use same padding as NewGRF parameters for AI/GS parameter lists. https://github.com/OpenTTD/OpenTTD/pull/14118#issuecomment-2832525143
18:52:48  <alpapilus> How did they even gain sentience?
18:53:45  <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #14118: Change: Use same padding as NewGRF parameters for AI/GS parameter lists. https://github.com/OpenTTD/OpenTTD/pull/14118#issuecomment-2832526080
18:53:53  <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14116: Codechange: Move usage of ResolverObjects to newgrf_xxx.cpp https://github.com/OpenTTD/OpenTTD/pull/14116
18:54:04  <LordAro> alpapilus: beep boop
18:54:35  <alpapilus> I should bring a nature documentary crew here.
18:54:38  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14118: Change: Use same padding as NewGRF parameters for AI/GS parameter lists. https://github.com/OpenTTD/OpenTTD/pull/14118#issuecomment-2832526821
18:54:57  <alpapilus> It’s some thrilling content.
18:56:02  <talltyler> Oh, this channel is bridged to Openttd’s IRC channel. Anyone marked as a bot is using an IRC client instead of Discord and the bot is bridging their messages back and forth.
18:56:52  <truebrain> spoilers!
18:57:07  <talltyler> The only bot around here is DorpsGek, but he doesn’t say much 🙂
18:57:20  <truebrain> on Discord he says nothing even 😛
18:57:23  <truebrain> on IRC however ......
18:57:45  <peter1138> truebrain, he speaks a different language. It looks the same, but the subtlies are lost on him.
18:57:57  <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #14118: Change: Use same padding as NewGRF parameters for AI/GS parameter lists. https://github.com/OpenTTD/OpenTTD/pull/14118#issuecomment-2832529894
18:58:13  <peter1138> Subtleties, even.
18:59:10  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14118: Change: Use same padding as NewGRF parameters for AI/GS parameter lists. https://github.com/OpenTTD/OpenTTD/pull/14118#issuecomment-2832530566
18:59:48  <alpapilus> talltyler: I have to google that.
19:00:59  *** WormnestAndroid has quit IRC
19:03:34  *** WormnestAndroid has joined #openttd
19:19:05  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #14118: Change: Use same padding as NewGRF parameters for AI/GS parameter lists. https://github.com/OpenTTD/OpenTTD/pull/14118#pullrequestreview-2796364529
19:21:00  <alpapilus> Ok so.
19:21:02  <alpapilus> I guess
19:21:19  <alpapilus> I’m too young to know what irc means.
19:22:00  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #14102: Add: Limit height of settings description, and add scrollbar. https://github.com/OpenTTD/OpenTTD/pull/14102#pullrequestreview-2796365014
19:22:55  <talltyler> https://en.m.wikipedia.org/wiki/IRC
19:23:35  *** nielsm has quit IRC
19:23:59  <alpapilus> talltyler: Yeah I’m too young for that.
19:28:01  *** WormnestAndroid has quit IRC
19:28:25  <peter1138> When/why should a window have a labelled "Close" button, in addition to the regular "X" button?
19:29:20  <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14119: Codechange: Simplify usage of GRFFileProps by adding some common helper methods. https://github.com/OpenTTD/OpenTTD/pull/14119
19:30:01  *** WormnestAndroid has joined #openttd
19:30:12  <alpapilus> peter1138: Probably never.
19:30:15  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14117: Codechange: Use enums as keys to spritegroups in GRFFileProps. https://github.com/OpenTTD/OpenTTD/pull/14117#pullrequestreview-2796373193
19:30:18  <alpapilus> Or like
19:30:34  <alpapilus> When you have too much space.
19:36:41  <talltyler> Never. GRF parameter window should have a spacer to fill the extra space, like the Settings menu
19:37:58  <frosch123> Oh, I made the title game crash in master, and noone noticed yet
19:40:31  <talltyler> Oops
19:42:32  *** tokai has joined #openttd
19:42:32  *** ChanServ sets mode: +v tokai
19:45:26  <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14120: Fix 5575379: Crash with default airports. https://github.com/OpenTTD/OpenTTD/pull/14120
19:52:54  <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #14120: Fix 5575379: Crash with default airports. https://github.com/OpenTTD/OpenTTD/pull/14120#pullrequestreview-2796389113
19:55:43  <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #14121: Add: [NewGRF] Add purchase list Action3 CID for houses, industries, industry tiles, airports and airport tiles. https://github.com/OpenTTD/OpenTTD/pull/14121
19:57:18  *** WormnestAndroid has quit IRC
19:57:22  *** WormnestAndroid has joined #openttd
19:58:06  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #14122: Codechange: use std::string_view for scripts https://github.com/OpenTTD/OpenTTD/pull/14122
20:02:08  *** Wormnest has joined #openttd
20:03:51  <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14102: Add: Limit height of settings description, and add scrollbar. https://github.com/OpenTTD/OpenTTD/pull/14102#pullrequestreview-2796405375
20:05:54  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14123: Change: Draw info headers as shade of window colour instead of pixel colour. https://github.com/OpenTTD/OpenTTD/pull/14123
20:08:33  <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #14102: Add: Limit height of settings description, and add scrollbar. https://github.com/OpenTTD/OpenTTD/pull/14102#pullrequestreview-2796406962
20:10:00  <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #14102: Add: Limit height of settings description, and add scrollbar. https://github.com/OpenTTD/OpenTTD/pull/14102#pullrequestreview-2796407426
20:21:03  <DorpsGek> [OpenTTD/nml] frosch123 opened pull request #375: Add: Constants for (new) station and roadstop animation and random triggers. https://github.com/OpenTTD/nml/pull/375
20:22:23  <_zephyris> frosch123: Ohhh, mystery solved!
20:25:19  <DorpsGek> [OpenTTD/nml] frosch123 updated pull request #375: Add: Constants for (new) station and roadstop animation and random triggers. https://github.com/OpenTTD/nml/pull/375
20:25:32  <peter1138> When does it crash...
20:26:41  <peter1138> talltyler, oops, I missed your response. Probably another side-quest :S
20:29:05  <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14120: Fix 5575379: Crash with default airports. https://github.com/OpenTTD/OpenTTD/pull/14120
20:31:19  <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #14123: Change: Draw info headers as shade of window colour instead of pixel colour. https://github.com/OpenTTD/OpenTTD/pull/14123#pullrequestreview-2796424339
20:33:22  <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #14122: Codechange: use std::string_view for scripts https://github.com/OpenTTD/OpenTTD/pull/14122
20:33:45  <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #14102: Add: Limit height of settings description, and add scrollbar. https://github.com/OpenTTD/OpenTTD/pull/14102#pullrequestreview-2796424941
20:34:21  <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #14102: Add: Limit height of settings description, and add scrollbar. https://github.com/OpenTTD/OpenTTD/pull/14102
20:38:24  <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1365789129752969246/image.png?ex=680e95bf&is=680d443f&hm=c9792e26e53f63c3cec40f5f3c1f5b9a5f5ff4be99c9219a1cdf23356fc37b79&
20:38:24  <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1365789130050633818/image.png?ex=680e95bf&is=680d443f&hm=ccca0daf532c9cca315018b7cd23d2b2b867996617a3698785a725bebb8fead2&
20:38:24  <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1365789130302296094/image.png?ex=680e95bf&is=680d443f&hm=f908397658563289fb28ed5386f8bbe4ced6c14cea006ae27154094d173837c2&
20:38:24  <_zephyris> If we're doing colour inconsistencies, frame title string colour in different setting/option windows...
20:39:11  <peter1138> Yes.
20:39:27  <_glx_> someone mentioned colour schemes
20:39:28  <peter1138> I put the constants in the wrong place and forgot to move them :(
20:39:48  <peter1138> _glx_, yeah, I have an idea for that too, but didn't want to start it before 15.0 release.
20:40:23  <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1365789630162538537/image.png?ex=680e9636&is=680d44b6&hm=5c210ff03398bee2e873ea1be7cfd79d474861b46039d0a2704691588e145c98&
20:40:35  <peter1138> That reset button is probably far enough from the resize button to not need a confirmation popup.
20:40:42  <_glx_> window colours are in the same world spacing used to be
20:40:59  <peter1138> They're actually not that bad at all.
20:41:09  <peter1138> Minor inconsistencies.
20:41:17  <peter1138> But still, specificied exactly everywhere, yeah.
20:41:28  <alpapilus> https://cdn.discordapp.com/attachments/1008473233844097104/1365789902507348019/IMG_8974.jpg?ex=680e9677&is=680d44f7&hm=5d7fbf2cd9528655ac70ba114dffcb8586c7a0a7df1d2245c573a2eaa484e918&
20:41:33  <peter1138> I have a branch... but it's out of date.
20:43:15  <_zephyris> Oh, wow, Discord integration really works. Got a @ message notification.
20:43:19  <peter1138> So I could make the reset button be half the window width, but that's just as arbitrary as making it just fit the text label.
20:47:21  *** FUEJJJO has joined #openttd
20:48:48  <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1365791747300659270/image.png?ex=680e982f&is=680d46af&hm=506a40fcef95ed70616ead59a3577325510ec442c0454b8ec0a0739c4f722fc5&
20:48:48  <_zephyris> Switch to a yellow button, like "reset all values" for advanced options?
20:49:11  <_zephyris> More recent layouts avoid the buttons in the footer appearance
20:49:28  <peter1138> No, precisely because it's that different window style.
20:49:41  <peter1138> Which is actually "not-TTD-style"
20:51:09  <peter1138> Now, if we do a redesign so that the parameters are not in a separate window, that might work.
20:51:24  <peter1138> Game Script style.
20:51:32  <peter1138> Although that Reset button is way too large as well.
20:55:03  <peter1138[d]> What else can we stuff in the Game Options window...
20:55:37  <peter1138> Oops.
20:55:46  <peter1138> In a way that also works for the World Generation screen.
20:55:55  <peter1138> Pom te pom. What a whole.
20:57:49  <peter1138> Hole.
21:02:17  <_zephyris> Yeah, I see what you mean about window styles
21:03:33  <_zephyris> Hmm, why does GS and AI selection use a purchase menu-like list, when newgrf settings dont't, though online content does.
21:03:36  <_zephyris> Rabbit holes...
21:05:20  <peter1138[d]> So there are two styles.
21:05:36  <peter1138[d]> WWT_MATRIX, which is the traditional style of listing thigns.
21:05:52  <peter1138[d]> But also, there's the file list style, as used in the file windows, which is what the NewGRF window uses.
21:06:27  <peter1138[d]> NewGRF uses the file style because, uh, they're files, I guess.
21:06:59  <peter1138[d]> Except it doesn't have the hover-highlight that the actual file windows have for some reason.
21:07:13  <peter1138[d]> (Does not add anything.)
21:09:43  <peter1138> I think the two window styles are kinda necessary at this point.
21:10:05  <peter1138> But should be consistent.
21:10:25  <peter1138> I think in the code I settled on the term "sparse" for these 'new' style windows.
21:10:45  <peter1138> They are quite rare in TTD, but do exist.
21:10:52  <peter1138> Error window!
21:13:31  <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1365797971068846220/image.png?ex=680e9dfb&is=680d4c7b&hm=9224825e71f893a521ccaf1357b0b60707d2dcab75f25b04fd841123c18ff417&
21:13:53  <peter1138> So original game options had the frames, but with not much in them. And the spacing was different.
21:14:17  <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1365798163830804571/image.png?ex=680e9e29&is=680d4ca9&hm=4ad67e745c0788b701f1fccac4c8a17e9b2cb32ccb17911e46ca73747d284c13&
21:14:47  <peter1138> This one is a bit of mix. Difficulty buttons are very much like our Game Options tabs.
21:15:09  <peter1138> But it has the hi-score button as a normal TTD-style button (and hence it's the same mauve colour)
21:16:42  <peter1138> Oh, and the Company window also has buttons on top of a panel.
21:17:20  <honza_> talltyler: I see, but why is that? For example I have a savegames from server, where GS pauses at the end and when I open them in single player, I can't unpause. Why is there no maybe command to unpause even GS, at least in single player
21:19:21  <_zephyris> Interesting
21:19:30  <_zephyris> Well, I guess content first, window style next
21:19:33  <peter1138> _zephyris, oh, and I forgot about all the build windows, which do use different colours. Grey on green.
21:19:53  <peter1138> Anyway.
21:20:48  <peter1138> The current disparity between AI settings and GS settings bugs me.
21:21:05  <peter1138> The change from a single window to separate windows is arguably the wrong way.
21:21:20  <_zephyris> Yeah
21:21:33  <_zephyris> Odd as NewGRF is, it's arguably better in some ways.
21:22:28  <peter1138> Well, configuring NewGRF is different to configuring scripts.
21:22:53  <peter1138> Scripts are "pick one per slot", NewGRF is "pick a load"
21:23:29  <peter1138> GS is always "pick one", of course.
21:24:32  <peter1138> Mocking up is not my forté... I tend to just implement things instead.
21:25:28  <_zephyris> Mm, but picking _from_ a file-like list is consistent for both of them.
21:28:05  <peter1138> I can see "pick game script" bringing up a more file-list type window.
21:28:15  <peter1138> Scripts on the left, details on the right.
21:28:18  <peter1138> Instead of top & bottom.
21:28:28  <peter1138> Same for AI.
21:28:59  <peter1138> For NewGRF the built-in list avoids lots of back and forth that a separate window would require.
21:31:51  <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #14124: Change: Remove extra close buttons from some windows. https://github.com/OpenTTD/OpenTTD/pull/14124
21:32:12  <_zephyris> Current AI gives a lot of back-forward
21:32:19  <peter1138> Yes.
21:32:32  <peter1138> I have ideas, too.
21:32:47  <_zephyris> Uh oh, those are dangerous
21:35:51  <talltyler> Good stuff happens when Peter has ideas
21:36:06  <talltyler> honza_: Dunno, I don't touch scripts 🙂
21:37:17  <peter1138> I like to avoid duplicating all this code as well :S
21:38:28  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14123: Change: Draw info headers as shade of window colour instead of pixel colour. https://github.com/OpenTTD/OpenTTD/pull/14123
21:39:04  <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #14105: Fix #14104, 67a0fcc: Don't base timetable timing decisions on client settings. https://github.com/OpenTTD/OpenTTD/pull/14105
21:39:07  <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #14104: [Bug]: Desync using Timetable Autofill https://github.com/OpenTTD/OpenTTD/issues/14104
21:54:13  *** keikoz has quit IRC
21:56:32  <xarick> oopsie
21:56:52  <xarick> defining the number of trains on a route by counting number of signals placed
21:56:57  <xarick> bad idea
21:57:44  <xarick> 60 trains
21:58:37  <_zephyris> Can OTTD do right-to-left pixel fonts?
22:04:24  <peter1138> NFO sprites, no.
22:10:45  <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1365812370747691008/image.png?ex=680eab64&is=680d59e4&hm=2676d068df0fad370c6aaaef301949eaf1f2b205928f63af068066a4e7489f4e&
22:10:45  <xarick> it had 500 trains at some point
22:36:42  *** Wolf01 has quit IRC
22:52:58  *** D-HUND has joined #openttd
22:56:21  *** debdog has quit IRC
22:57:38  *** Smedles_ has joined #openttd
22:58:21  *** Smedles has quit IRC

Powered by YARRSTE version: svn-trunk