Times are UTC Toggle Colours
04:35:10 *** LSky` has joined #openttdcoop.devzone 05:40:09 *** andythenorth has joined #openttdcoop.devzone 05:56:16 <LSky`> V453000 , http://dev.openttdcoop.org/issues/7068 06:17:57 *** andythenorth has quit IRC 06:45:28 *** Supercheese has quit IRC 10:20:16 *** erlehmann has joined #openttdcoop.devzone 15:47:10 *** efess has quit IRC 15:52:53 *** Alberth has joined #openttdcoop.devzone 16:40:44 <DevZone> Project road-hog build #272-nightlies: FAILURE in 43 sec: https://jenkins.openttdcoop.org/job/road-hog/272/ 16:48:27 <DevZone> Yippee, build fixed! 16:48:27 <DevZone> Project road-hog build #273-push: FIXED in 42 sec: https://jenkins.openttdcoop.org/job/road-hog/273/ 16:50:47 <DevZone> Project 2ccts build #271-push: SUCCESS in 2 min 20 sec: https://jenkins.openttdcoop.org/job/2ccts/271/ 17:08:57 *** gelignite has joined #openttdcoop.devzone 17:09:32 *** frosch123 has joined #openttdcoop.devzone 17:40:44 *** efess has joined #openttdcoop.devzone 17:48:55 *** Supercheese has joined #openttdcoop.devzone 17:56:29 *** ODM has joined #openttdcoop.devzone 18:37:23 *** andythenorth has joined #openttdcoop.devzone 18:48:06 <DevZone> Project yeti build #10-push: SUCCESS in 2 hr 0 min: https://jenkins.openttdcoop.org/job/yeti/10/ 18:50:09 <frosch123> planetmaker: the commit hook did not catch V comitting yeti.nfo :p 18:51:03 <frosch123> hmm, is yeti.nml generated? 18:51:38 <planetmaker> no, I don't think so. V uses no pre-processing 18:51:46 <planetmaker> and nfo files are valid source files in general 18:51:58 <planetmaker> just not in the presence of equally-named nml files 18:52:06 <frosch123> V453000: your spritelayouts say x/y/z extent = 64/32/0 18:52:18 <frosch123> those extents are not in pixels, but in world coorindates 18:52:26 <frosch123> xextent and yextent should be 16 18:52:30 <planetmaker> did I thank you for your update to the commit hook yet? If not: thanks a bunch :) 18:52:36 <frosch123> zextent should be something sane, line 30 or 50 or so 18:52:49 <frosch123> planetmaker: you're welcome :) 18:54:04 <planetmaker> ah, I guess the x- and y-extend are not well or clearly enough explained :) 18:54:16 *** Alberth has left #openttdcoop.devzone 18:54:19 <planetmaker> or V453000 simply did not look it up :) 18:54:43 <planetmaker> hm, haven't heard of V453000 in a few days :) 18:55:44 <frosch123> maybe we should write in the docs, that xoffs=yoffs=zoffs=0, xextent=yextent=16, zextent=50 (you will need a really really good reason to pick different values) 18:55:52 <frosch123> :p 18:56:09 <frosch123> no need to explain it, just give required values :p 18:56:09 <planetmaker> yeah, probably a good idea 19:04:21 <planetmaker> http://newgrf-specs.tt-wiki.net/wiki/NML:Spritelayout#Positioning 19:05:44 <frosch123> oh, there are default values in mml? 19:06:33 <planetmaker> seems so 19:06:48 <planetmaker> they're nml default, not grf default? 19:07:30 <frosch123> you cannot skip the values in the grf, so there are no defaults 19:07:36 <planetmaker> ok 19:08:09 <frosch123> anyway, we can then as well recommend to not set those values at all :p 19:08:33 <planetmaker> hm, true :) 19:11:43 <planetmaker> unit for zextent is pixels, right? 19:11:49 <frosch123> yes 19:12:06 <planetmaker> units for the offsets are also 1/16 of tile border? Or what's their unit? 19:12:17 <frosch123> yup, 1/16 tile 19:12:21 <frosch123> same as vehicle length 19:12:36 <planetmaker> and zoffset is again pixels? 19:12:43 <frosch123> yup :) 19:12:59 <planetmaker> ok. I'll add that info. And bold-face the recommendation to not change defaults :) 19:14:46 <frosch123> hmm, so yeti needs a truely smatz-ian fix: only removing lines :) 19:14:59 <planetmaker> :) 19:19:27 <DevZone> Project World Airliner Set build #313-push: FAILURE in 34 sec: https://jenkins.openttdcoop.org/job/worldairlinersset/313/ 20:03:06 *** ODM has quit IRC 20:43:17 <frosch123> i wonder what's wrong with manpower-industries 20:43:26 <frosch123> it fails to upload to eints 20:43:32 <frosch123> but i cannot fint a proper error either 20:43:50 <planetmaker> eints-translator not member of project? 20:44:13 * planetmaker checks 20:44:29 <frosch123> it created the project successfully 20:44:31 <planetmaker> hm, no 20:44:35 <frosch123> then it claims to upload english 20:44:38 <frosch123> and then fails to upload russian 20:44:44 <frosch123> but in the translator english does not show 20:45:00 <frosch123> so, maybe english is rejected due to syntax or something 20:45:20 <planetmaker> I created that repo actually by using 'fork' on rhodecode... wonder whether that might have changed something 20:46:12 <planetmaker> hm... doesn't seem like. Normal repo path 20:47:17 <frosch123> oh, i see it 20:47:31 <frosch123> english.lng line 151 - 154 are commented out using // 20:47:36 <frosch123> is that valid in nml? 20:49:57 <planetmaker> not in lang files, I think 20:50:12 <planetmaker> comment symbol there is # 20:50:33 <planetmaker> same syntax as OpenTTD lang files really 20:51:04 <frosch123> well, does compilation fail? or does nml ignore the // ? or does it include them into the stringid? :p 20:52:26 <frosch123> well, i open an issue 20:52:31 <frosch123> for manpower 20:52:39 * planetmaker compiles 20:53:53 <planetmaker> nml did not complain at least :) 20:56:16 <frosch123> https://dev.openttdcoop.org/issues/7073 20:56:52 <planetmaker> and it seems to not include the commented-out strings 20:57:25 <frosch123> intentional? :) 20:57:36 <planetmaker> if I knew :P 21:00:08 <frosch123> nml source looks like it would include // into the string name 21:01:52 <frosch123> it does not check for spaces either or similar 21:01:58 <frosch123> it just search for the ":" 21:02:05 <frosch123> then strips whitespace and BOM 21:02:17 <frosch123> and then possibly separates the case at an "." 21:03:03 <frosch123> so "4#d$ . 7" would be stringid "4#d$ " and case " 7" 21:05:22 <planetmaker> hm... well... 21:06:56 <planetmaker> ah, there it is :D 21:07:39 <planetmaker> well, my suggested fix is: change documentation, keep code :) 21:09:29 <frosch123> https://paste.openttdcoop.org/ptuojbjwz <- does that help? 21:11:41 <planetmaker> that throws an error on that lang file, yes 21:12:28 *** gelignite has quit IRC 21:12:37 <planetmaker> but we should also at least allow small letters 21:12:45 <planetmaker> nmlc ERROR: "lang/english.lng", line 8: Invalid string name "aSTR_PARAM_OIL_REFINERY_DISTANCE_VALUE_0" 21:13:32 <frosch123> string_pat = re.compile('^([A-Za-z_0-9]+)(\.[A-Za-z0-9]+)?[ \t]*:(.*)$') <- i guess we just use the one from eints :p 21:13:45 <planetmaker> :P 21:16:07 <planetmaker> be my guest with that :) 21:16:17 <frosch123> pushed 21:17:40 <planetmaker> :) 21:17:52 <planetmaker> time for bed now. Good night :) 21:18:31 *** andythenorth has left #openttdcoop.devzone 21:20:12 <DevZone> Project opengfx-mars build #146-push: SUCCESS in 2 min 31 sec: https://jenkins.openttdcoop.org/job/opengfx-mars/146/ 21:20:23 <DevZone> Project Townnames - German build #94-push: SUCCESS in 10 sec: https://jenkins.openttdcoop.org/job/german-townnames/94/ 21:20:24 <DevZone> Yippee, build fixed! 21:20:25 <DevZone> Project NML - NewGRF Meta Language build #359-push: FIXED in 4 min 10 sec: https://jenkins.openttdcoop.org/job/nml/359/ 22:14:00 *** frosch123 has quit IRC 23:03:16 *** erlehmann has quit IRC