Times are UTC Toggle Colours
00:28:48 *** thexa4 has quit IRC 00:36:29 *** thexa4 has joined #openttd 00:43:02 *** thexa4 has quit IRC 01:04:24 <DorpsGek_III> [OpenTTD/OpenTTD] Wormnest opened issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd 01:16:29 *** Flygon has joined #openttd 01:36:51 *** snail_UES_ has joined #openttd 01:50:33 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd 01:53:13 *** Lejving has joined #openttd 02:02:45 <DorpsGek_III> [OpenTTD/OpenTTD] Wormnest commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd 02:13:23 *** Wormnest_ has quit IRC 03:00:02 *** D-HUND has joined #openttd 03:01:09 *** snail_UES_ has quit IRC 03:03:22 *** debdog has quit IRC 03:13:36 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd 03:15:52 *** glx has quit IRC 04:09:57 *** sla_ro|master has joined #openttd 04:28:23 *** sla_ro|master has quit IRC 04:59:01 *** WormnestAndroid has quit IRC 05:27:08 *** WormnestAndroid has joined #openttd 05:53:28 *** nielsm has quit IRC 06:13:19 *** Etua has joined #openttd 08:55:59 *** Samu has joined #openttd 08:56:34 <Samu> hi 09:00:18 *** Etua has quit IRC 09:19:04 *** thexa4 has joined #openttd 09:39:10 *** D-HUND is now known as debdog 09:50:47 *** juzza1 has quit IRC 09:51:15 *** juzza1 has joined #openttd 10:28:58 *** dih has joined #openttd 11:30:35 *** WormnestAndroid has quit IRC 11:30:49 *** WormnestAndroid has joined #openttd 11:44:51 *** andythenorth has joined #openttd 11:46:47 <AquaFiX> dbg: [net] Map generated, starting game 11:46:50 <AquaFiX> and that is all 11:46:58 <AquaFiX> nothing happens after this line, and i'm not sure why. 11:48:30 <AquaFiX> im running debian 9 stretch 11:48:49 <AquaFiX> running 1.9.2 openttd -D 11:49:40 <LordAro> AquaFiX: are you expecting anything else to happen? 11:50:50 <AquaFiX> yes im expecting the master server to query it, and all sorts of other magic 11:51:39 <LordAro> are you sure it isn't, and just not outputting anything? 11:51:56 <LordAro> (disclaimer: no experience running servers dedicated or otherwise) 11:53:57 <AquaFiX> yeah its not outputting anything 12:34:30 *** snail_UES_ has joined #openttd 12:50:25 *** snail_UES_ has quit IRC 13:00:57 <AquaFiX> Anybody time to help me troubleshoot? 13:03:06 <Samu> is it advertised? 13:03:57 <Samu> maybe it's dedicated but not advertised 13:04:02 *** Etua has joined #openttd 13:06:23 <AquaFiX> lan setting is 0 so it should be, i cant even connect via ip 13:09:20 <Samu> lan_internet = 0 ? 13:09:27 <Samu> should be 1 13:11:47 *** andythenorth has quit IRC 13:28:34 <LordAro> AquaFiX: won't connect to the master server if it's not advertised 13:28:42 <LordAro> but i don't know why you can't connect via IP 13:28:43 <LordAro> @ports 13:28:43 <DorpsGek> LordAro: OpenTTD uses TCP and UDP port 3979 for server <-> client communication, UDP port 3978 for masterserver (advertise) communication (outbound), and TCP port 3978 for content service, a.k.a. BaNaNaS (outbound) 13:28:48 <LordAro> ^ i presume that's not relevant 13:33:51 *** sla_ro|master has joined #openttd 13:36:19 <AquaFiX> meh it all of sudden started working 13:41:39 *** andythenorth has joined #openttd 13:44:38 *** thexa4 has quit IRC 14:02:13 *** thexa4 has joined #openttd 14:06:59 *** cHawk has quit IRC 14:10:42 *** cHawk has joined #openttd 14:17:22 *** nielsm has joined #openttd 14:18:19 <nielsm> morn 14:18:23 <andythenorth> hi 14:18:32 *** supermop_work has joined #openttd 14:18:53 *** Etua has quit IRC 14:42:31 <DorpsGek_III> [OpenTTD/OpenTTD] Honza1987 commented on issue #7644: Mysteriously poor performance on macOS https://git.io/fjii3 14:43:45 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on issue #7644: Mysteriously poor performance on macOS https://git.io/fjii3 14:45:23 <DorpsGek_III> [OpenTTD/OpenTTD] Honza1987 commented on issue #7644: Mysteriously poor performance on macOS https://git.io/fjii3 14:49:29 <DorpsGek_III> [OpenTTD/OpenTTD] Honza1987 commented on issue #7644: Mysteriously poor performance on macOS https://git.io/fjii3 14:50:48 <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on issue #7644: Mysteriously poor performance on macOS https://git.io/fjii3 14:54:00 *** Etua has joined #openttd 14:55:14 <peter1139> ^^ yeah, andy's "normal" colours are way overbright... 14:55:38 <peter1139> The muted colours are not quite the same either, but seem to match a bit better. 14:56:51 <andythenorth> color matching is a sad story :P 14:58:55 <peter1139> Another OS X failure ;p 14:59:06 <supermop_work> I'm doing it with tile and terrazzo right now 14:59:19 *** Arveen has quit IRC 15:00:08 <andythenorth> it's a frigging disaster without a colormeter 15:00:20 <andythenorth> or even a colorimeter 15:01:24 *** Wormnest_ has joined #openttd 15:02:41 <peter1139> Just check the hex values :p 15:03:10 *** sla_ro|master has quit IRC 15:04:48 <milek7> it doesn't end at the monitor; should everybody load color profiles calibrated for their own eyes? ;P 15:05:43 <andythenorth> my left eye and right eye are differently calibrated 15:05:49 <andythenorth> one is more yellow, the other is more blue 15:05:52 <andythenorth> not even trolling 15:06:00 <andythenorth> measurable difference 15:06:53 <LordAro> impressive 15:12:06 <andythenorth> probably just pigment or something dunno 15:12:18 * andythenorth back to GDPR 15:12:22 <andythenorth> always there waiting for me 15:12:30 <andythenorth> even Brexit won't help me there 15:17:39 <Eddi|zuHause> are we even still having a brexit? 15:18:32 <Eddi|zuHause> and if the brexit never happens, what colour does it have? 15:18:58 <milek7> according to ishihara plates i have deuteranomaly 15:21:37 *** Etua has quit IRC 15:25:11 *** Flygon has quit IRC 15:40:18 *** thexa4 has quit IRC 15:41:27 *** HerzogDeXtEr has joined #openttd 15:42:42 *** Samu has quit IRC 16:01:39 *** glx has joined #openttd 16:01:39 *** ChanServ sets mode: +v glx 16:01:41 *** thexa4 has joined #openttd 16:01:58 <DorpsGek_III> [OpenTTD/OpenTTD] Wormnest commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd 16:05:48 <DorpsGek_III> [OpenTTD/OpenTTD] SoothedTau commented on issue #7644: Mysteriously poor performance on macOS https://git.io/fjii3 16:26:57 *** thexa4 has quit IRC 16:52:20 *** Samu has joined #openttd 17:05:57 *** andythenorth has quit IRC 17:06:05 *** thexa4 has joined #openttd 17:06:08 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd 17:09:38 <glx> my fast forward is too slow to trigger it I think 17:09:54 *** Wolf01 has joined #openttd 17:10:51 <Eddi|zuHause> sounds like a missing invalidation call? 17:11:37 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd 17:11:48 <Eddi|zuHause> also, might that have been my fault? 17:12:48 <DorpsGek_III> [OpenTTD/OpenTTD] Eddi-z commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd 17:14:42 <glx> not via the cheat GUI 17:16:30 <DorpsGek_III> [OpenTTD/OpenTTD] Eddi-z commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd 17:17:34 <Eddi|zuHause> glx: i seem to remember that money cheat going both ways 17:17:48 <milek7> seems to happen for any news, not just company trouble 17:17:58 <milek7> and reverting afbf6a5 fixes it 17:18:19 <Eddi|zuHause> dangit :/ 17:22:51 *** WormnestAndroid has quit IRC 17:23:54 *** WormnestAndroid has joined #openttd 17:28:27 <milek7> Error: Assertion failed at line 538 of /home/milek7/OpenTTD/src/news_gui.cpp: this->ni->reftype1 == NR_ENGINE 17:28:27 <glx> I think the checks in DoCommand() prevent money cheat to create a negative bank amount 17:29:27 <Eddi|zuHause> trying to read DeleteNewsItem but i don't see where i would have made a mistake 17:34:48 <glx> maybe MoveToNextTickerItem() doesn't close the window when it should 17:35:32 <Eddi|zuHause> but that should be handled by MoveToNextNewsItem()? 17:39:40 <DorpsGek_III> [OpenTTD/DorpsGek] TrueBrain updated pull request #3: Many small and some bigger things https://git.io/fjpmT 17:40:46 *** Progman has joined #openttd 17:41:11 <Eddi|zuHause> hm, in MoveToNext*Item() i changed a "return" to a "continue"... not sure why 17:41:20 *** Wolf01 has quit IRC 17:41:33 <Eddi|zuHause> "if (_date - _news_type_data[type].age > ni->date) return;" 17:42:34 <glx> because you introduced a while loop 17:43:32 <Eddi|zuHause> right 17:44:20 *** gelignite has joined #openttd 17:44:27 *** Wolf01 has joined #openttd 17:46:29 <DorpsGek_III> [OpenTTD/DorpsGek] TrueBrain updated pull request #3: Many small and some bigger things https://git.io/fjpmT 17:46:32 <glx> if there's something wrong it's not obvious 17:46:53 <Eddi|zuHause> might also be a bug in the original code that i just exposed 17:47:56 <Eddi|zuHause> could use a replay of what happened right before the crash... 17:49:08 <glx> I can't make it crash, so it's hard to debug for me :) 17:49:40 <Eddi|zuHause> well, if your FF can't trigger it, i don't see how it would for me :p 17:50:26 <glx> at most I get 1500 images/s 17:50:35 <glx> less during autosave 17:50:56 <glx> and that's with release build 17:51:27 <glx> but I was testing on 512² 17:52:26 *** Etua has joined #openttd 17:53:04 <glx> hmm I could play with _settings_client.gui.news_message_timeout 17:53:06 <SpComb^> a global variable for ignoring merges to master? Maybe I'll stick to Jenkins :P 17:53:33 <Eddi|zuHause> if i make the window small i get about 1000 pictures and 2000 simulation rate 17:53:52 <Eddi|zuHause> on a 64^2 map 17:55:04 <milek7> i have graphics 800fps, simulation fps counter goes off scale 17:55:07 <milek7> crashes in ~10s 17:56:00 <Eddi|zuHause> and game is making weird noises if i resize while news is shown 17:56:04 <milek7> (with off scale i mean 9999,99) 17:56:28 <Eddi|zuHause> oh it crashed... 17:57:23 <nielsm> (I'm still amazed nobody thought to put an fps meter into the game before) 17:58:04 <Eddi|zuHause> why would you put an fps meter in a game that runs at fixed 30/33fps? :p 17:58:39 <SpComb^> competitive OpenTTD definitely needs 120fps 17:58:59 <SpComb^> https://www.tt-forums.net/viewtopic.php?t=41041 this reminded me 17:58:59 <Eddi|zuHause> https://paste.openttdcoop.org/pqy5rdmlo <-- not sure if this makes any sense 18:06:08 *** Wormnest_ has quit IRC 18:08:10 *** cHawk has quit IRC 18:08:23 *** cHawk has joined #openttd 18:10:49 *** thexa4 has quit IRC 18:13:47 <Eddi|zuHause> no crash :/ 18:14:11 *** sla_ro|master has joined #openttd 18:21:08 *** WormnestAndroid has quit IRC 18:21:19 *** WormnestAndroid has joined #openttd 18:23:58 <milek7> https://paste.openttdcoop.org/ptc8yax97/y9fwrf/raw 18:24:26 *** frosch123 has joined #openttd 18:34:14 <Eddi|zuHause> milek7: can you get to (NewsWindow*)w->ni? 18:35:45 <milek7> it's freed already 18:39:37 <milek7> after `delete ni;` i inserted: NewsWindow *w = (NewsWindow*)FindWindowById(WC_NEWS_WINDOW, 0); if (w) assert(w->ni != ni); 18:39:57 <milek7> and this assert triggers 18:44:01 <Eddi|zuHause> right, that's the reason why it then goes on crashing, but it doesn't explain how it gets into this situation 18:47:37 <Eddi|zuHause> milek7: can you track _current_news vs. (NewsWindow*)w->ni? 18:51:02 *** andythenorth has joined #openttd 18:57:39 <Eddi|zuHause> i'm still drawing a blank here on what goes wrong when 18:58:23 <milek7> track? just printf two pointers? 18:58:45 <Eddi|zuHause> something like that 19:00:27 <milek7> printf("_current_news: %p, w->ni: %p\n", _current_news, w ? w->ni : nullptr); 19:00:35 <milek7> inserted at end of DeleteNewsItem 19:00:37 <milek7> https://paste.openttdcoop.org/p9ij5a1gv 19:00:51 <Eddi|zuHause> milek7: maybe also in NewsLoop() 19:01:12 <Eddi|zuHause> (might be spammy) 19:03:22 <Eddi|zuHause> assumption would be w->ni is either null, _current_news or _forced_news 19:04:04 <milek7> https://paste.openttdcoop.org/pg97jjllg 19:04:11 <milek7> piped through uniq for brevity 19:04:34 <Eddi|zuHause> hm... 19:11:24 *** thexa4 has joined #openttd 19:14:12 *** Etua has quit IRC 19:14:33 *** WormnestAndroid has quit IRC 19:15:10 *** WormnestAndroid has joined #openttd 19:17:24 <Samu> can you make engines reliability a bit more diversified 19:17:30 <andythenorth> ? 19:18:55 <Samu> doesn't feel random atm, 92%, 93%, 97%, 98% 19:19:02 <Samu> 8 aircraft models 19:19:06 <Samu> all over 90% 19:20:43 <Samu> all road vehicles 97 or 98% 19:21:12 <Samu> what happened, it used to be more varied 19:25:13 <andythenorth> probably random 19:25:22 <Eddi|zuHause> i have a suspicion 19:25:52 <milek7> below ShowNewspaper(ni); 19:25:59 <milek7> that break shouldn't be return? 19:26:13 <Eddi|zuHause> in ShowLastNewsMessage it might need to update _current_news 19:26:27 <milek7> because it's switch, it's essentialy noop 19:27:07 <milek7> and i guess it was meant to break while loop 19:27:37 <Eddi|zuHause> hum, yeah, that seems off 19:28:01 <Samu> when i watch youtube videos on chrome, I get 0 ads during video playback 19:28:16 <Samu> when i watch on internet explorer, ads during playback 19:28:24 <Samu> fishy... 19:28:42 <milek7> it doesn't crash with return 19:30:34 <Samu> I had an idea for town growth - upgrade bridges 19:31:09 <Samu> existing town owned bridges 19:31:46 <Eddi|zuHause> yeah, i don't see it diverging anymore either 19:31:51 <DorpsGek_III> [OpenTTD/OpenTTD] Milek7 commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd 19:32:42 <DorpsGek_III> [OpenTTD/OpenTTD] Eddi-z commented on issue #7737: Crash of OpenTTD master gf81cb0a90d possibly after trying to sell the default human user https://git.io/Jemyd 19:37:37 *** Wormnest_ has joined #openttd 19:37:46 <Eddi|zuHause> so the assumption that was violated was that there's only one news window 19:38:14 <Eddi|zuHause> also, why does ShowNewsMessage() delete the window twice? 19:39:26 <milek7> seems unnecessary 19:40:11 <Eddi|zuHause> anyway, ShowLastNewsMessage should probably set _forced_news 19:41:15 <Eddi|zuHause> ah no, it does that by calling ShowLastMessage 19:45:22 <DorpsGek_III> [OpenTTD/OpenTTD] Milek7 opened pull request #7738: Fix #7737: Replace invalid breaks with returns in news_gui.cpp https://git.io/JeYUf 19:45:49 <Eddi|zuHause> aw, i was just about to commit :p 19:48:28 *** nielsm has quit IRC 19:49:57 <milek7> sorry ;P 19:51:48 *** WormnestAndroid has quit IRC 19:52:17 *** WormnestAndroid has joined #openttd 19:53:19 *** sla_ro|master has quit IRC 19:53:33 <Eddi|zuHause> just noticed: there's a return after the switch in the first function, which makes it correct, but it's missing in the second one 19:54:41 <glx> yes it's just missing a return after the switch in the while loop 19:56:55 <DorpsGek_III> [OpenTTD/OpenTTD] Milek7 updated pull request #7738: Fix #7737: Replace invalid breaks with returns in news_gui.cpp https://git.io/JeYUf 19:57:30 <Eddi|zuHause> i'm too slow for this world :/ 19:57:33 <DorpsGek_III> [OpenTTD/OpenTTD] Milek7 updated pull request #7738: Fix #7737: Replace invalid breaks with returns in news_gui.cpp https://git.io/JeYUf 19:59:05 <DorpsGek_III> [OpenTTD/OpenTTD] Eddi-z opened pull request #7739: Fix #7737, afbf6a5: missing return https://git.io/JeYUg 19:59:10 <Eddi|zuHause> there, fight me :p 19:59:45 <milek7> ;) 20:02:22 <Samu> to keep a town growing, i need to pay it £606k 20:02:35 <Samu> not sure if it's worth it 20:02:53 <Samu> £606k per year 20:03:55 <Samu> with what the AI earns, i could keep 10 towns growing 20:03:56 <glx> oh using 64² I can trigger a crash 20:05:38 <Eddi|zuHause> glx: it'll crash when more than 1 news message window is open, and the news times out quicker than the news closes 20:06:03 <glx> I'm still on the unmodified source :) 20:06:17 <Eddi|zuHause> yes 20:06:25 <Eddi|zuHause> the missing return causes more than 1 news message to open 20:06:37 <Eddi|zuHause> which violates assumptions elsewhere that there's only 1 20:07:52 <glx> and as the previous news is supposed to be unshown it's deleted 20:07:59 <Wolf01> https://www.humblebundle.com/store/endless-space-collection-free-game if anyone interested 20:10:09 <Eddi|zuHause> ... but i have endless space already 20:11:42 <Eddi|zuHause> "playtime: 11 minutes"... i think it didn't run properly 20:12:15 <Samu> Requires subscription to our newsletter. 20:12:25 <Samu> Requires spamming your email 20:12:26 <Samu> fixed 20:12:38 <glx> they don't spam that much 20:13:01 *** gelignite has quit IRC 20:13:15 <Samu> i doubt i can run it here 20:15:37 <Wolf01> <glx> they don't spam that much <- let's talk about this.. XD 20:15:40 <Eddi|zuHause> ... you can unsubscribe from the newsletter... 20:15:47 <Wolf01> 3 mails at day 20:16:09 <Eddi|zuHause> Wolf01: you can forward them to /dev/null :p 20:16:29 <Wolf01> Yeah, I could, but the next day I need to subscribe again to get the new stuff :P 20:17:07 <Wolf01> I already have a folder filter, all the *bundle newsletter go there 20:17:48 <glx> I got 2 newsletter in august 20:18:59 <glx> but most categories are unchecked in the settings 20:19:04 <Samu> data collection practices 20:19:33 <Wolf01> Oh, there are settings? I think I have everything enabled XD 20:20:26 <Wolf01> Yes, 6 items selected 20:25:05 <DorpsGek_III> [OpenTTD/OpenTTD] bedrich-schindler commented on issue #7644: Mysteriously poor performance on macOS https://git.io/fjii3 20:27:36 <Samu> the chance that it will even offer something that interests me is probably 0% 20:27:42 <Samu> for free 20:30:46 <Samu> https://github.com/OpenTTD/OpenTTD/pull/7730, i think only Terron does this, but I'm not sure 20:30:53 <Samu> Rondje does 20:31:06 <Samu> but Rondje cheats in more ways than that 21:12:18 *** SpComb^ has quit IRC 21:14:02 *** andythenorth has left #openttd 21:27:40 *** Wolf01 has quit IRC 21:36:00 <DorpsGek_III> [OpenTTD/OpenTTD] Honza1987 commented on issue #7644: Mysteriously poor performance on macOS https://git.io/fjii3 21:43:22 *** Progman has quit IRC 21:48:26 *** Samu has quit IRC 21:56:30 *** frosch123 has quit IRC 22:25:45 *** tokai|noir has joined #openttd 22:25:45 *** ChanServ sets mode: +v tokai|noir 22:28:55 *** Thedarkb has joined #openttd 22:32:51 *** tokai has quit IRC 23:00:38 *** SpComb has joined #openttd 23:07:01 *** Thedarkb has quit IRC 23:12:44 *** HerzogDeXtEr has quit IRC 23:29:12 *** Thedarkb-X40 has joined #openttd 23:32:12 *** thexa4 has quit IRC 23:59:11 *** Wormnest_ has quit IRC