Times are UTC Toggle Colours
00:31:59 *** tokai has joined #openttd 00:31:59 *** ChanServ sets mode: +v tokai 00:32:42 <milek7> blob:https://imgur.com/fff50d25-709d-49f8-ae78-42aea40dcaac 00:32:46 <milek7> https://i.imgur.com/EVXbFGa.png 00:35:10 <DorpsGek> [OpenTTD/nml] TheDude-gh commented on issue #209: Cargo callback "profit" probably broken https://git.io/JODbP 00:38:54 *** tokai|noir has quit IRC 01:31:11 *** HerzogDeXtEr has quit IRC 02:10:45 *** D-HUND has joined #openttd 02:12:22 *** Wormnest has quit IRC 02:14:14 *** debdog has quit IRC 02:31:44 *** glx has quit IRC 04:17:04 *** lobstarooo has joined #openttd 04:18:30 <DorpsGek> [OpenTTD/OpenTTD] perezdidac updated pull request #9043: Feature: bridges over bridges (WIP) https://git.io/JOWU8 04:22:25 *** lobster has quit IRC 04:22:25 *** lobstarooo is now known as lobster 04:43:44 *** didac has joined #openttd 04:49:12 <DorpsGek> [OpenTTD/OpenTTD] perezdidac commented on pull request #9043: Feature: bridges over bridges (WIP) https://git.io/JOH7U 04:50:29 <DorpsGek> [OpenTTD/OpenTTD] perezdidac updated pull request #9043: Feature: bridges over bridges (WIP) https://git.io/JOWU8 05:08:46 *** Flygon has joined #openttd 05:28:17 *** didac has quit IRC 05:37:12 *** snail_UES_ has quit IRC 05:53:14 *** Progman has joined #openttd 06:12:54 *** Gustavo6046 has quit IRC 06:44:18 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 started discussion #9101: Which strings in english.txt should be renamed or moved before 1.12? https://git.io/JOQOA 06:46:55 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #8986: Fix: Missing 'Town names:' colon in map gen GUI https://git.io/JOQ3R 06:47:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #8986: Fix: Missing 'Town names:' colon in map gen GUI https://git.io/JOQ3E 06:47:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #8986: Fix: Missing 'Town names:' colon in map gen GUI https://git.io/JOfRa 06:49:16 *** andythenorth has joined #openttd 07:16:44 *** nielsm has joined #openttd 07:28:16 *** gelignite has joined #openttd 07:46:55 *** Wolf01 has joined #openttd 07:48:37 *** tokai|noir has joined #openttd 07:48:37 *** ChanServ sets mode: +v tokai|noir 07:55:18 *** tokai has quit IRC 08:10:50 *** sla_ro|master has joined #openttd 08:15:51 <DorpsGek> [OpenTTD/OpenTTD] Hezkore commented on issue #9009: Feature: mouse cursor scale https://git.io/JOTCH 08:20:59 *** jottyfan has joined #openttd 08:21:39 *** jottyfan has quit IRC 08:27:14 *** jottyfan has joined #openttd 08:37:23 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on issue #9009: Feature: mouse cursor scale https://git.io/JOTCH 08:41:09 *** Speedy` has quit IRC 08:41:31 *** tokai has joined #openttd 08:41:31 *** ChanServ sets mode: +v tokai 08:48:29 *** tokai|noir has quit IRC 09:05:49 <Wolf01> https://img-9gag-fun.9cache.com/photo/agBQmMv_460sv.mp4 interesting... it could be a good addition with NRT to make a ropeway bridge for vehicles 09:12:20 <peter1138> yikes 09:40:07 <peter1138> https://user-images.githubusercontent.com/639850/115988641-948d9300-a5b2-11eb-8850-dad392b27fb3.png 09:41:10 <peter1138> Scalable, but... I've no idea if I can, or if I should :p 09:57:23 *** EER has joined #openttd 09:58:56 <peter1138> Hmm, is it possible to make a sprite that adds additional zoom levels without touching the original sprite? 10:02:32 <DorpsGek> [OpenTTD/team] liulitchi opened issue #202: [zh_CN] Translator access request https://git.io/JOQyN 10:06:53 *** Samu has joined #openttd 10:12:31 <TrueBrain> https://gist.github.com/TrueBrain/d430a5f0e7e4312b895278f092067495 <- I think this is all I need to do for STUN to work .. most is already, give or take, in my PR, but none of it is reviewable :P 10:12:36 <Wolf01> https://www.youtube.com/watch?v=STWgdOegS_w hmmmm 10:12:42 <TrueBrain> in good news, all these headers should be a PR on their own 10:14:01 *** frosch123 has joined #openttd 10:15:24 <nielsm> peter1138: I don't think the system support adding sprite zoom levels like that right now, no... what might be more reasonable is actually having a TTF distributed with the game that can supply the glyphs for those graphic icons 10:16:25 <nielsm> they can even just be placed in the private use area on the codepoints that already encode them in the strings 10:18:24 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9099: "Feature": Bigger packets in network protocols https://git.io/JOQQv 10:19:22 <peter1138> They can, but making the font system choose to use a different font for different glyphs is not something support right now, I believe. 10:20:06 <nielsm> well it already queries a different source to mix the bitmap icons into truetype rendered strings 10:20:18 <nielsm> yes it'd be special cased, but it already is 10:20:51 <peter1138> Based on the range, right? 10:20:59 <nielsm> I think so 10:21:00 <peter1138> E000 or soimething 10:21:06 <peter1138> I should I know, I probably wrote it :) 10:22:29 <_dp_> font system already can switch fonts just fine 10:23:22 <_dp_> also we can choose default font(s) that just has all necessary icons 10:25:08 <DorpsGek> [OpenTTD/team] frosch123 commented on issue #202: [zh_CN] Translator access request https://git.io/JOQyN 10:31:26 <peter1138> Well most window icons are drawn as sprites now. But these ones are handled differently because they are part of text. 10:34:20 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #9102: Fix: Use width of tiny arrow string instead of scaled pixels in ship/aircraft list. https://git.io/JOQd4 10:34:28 <DorpsGek> [OpenTTD/bananas-frontend-cli] erenes opened pull request #24: Allow connecting to developer-endpoint of bananas api https://git.io/JOQdR 10:41:04 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on discussion #9101: Which strings in english.txt should be renamed or moved before 1.12? https://git.io/JOQOA 10:42:11 *** WormnestAndroid has quit IRC 10:42:29 *** WormnestAndroid has joined #openttd 10:42:51 <DorpsGek> [OpenTTD/OpenTTD] James103 opened issue #9103: Typo in bug report template from #9092 https://git.io/JOQF7 10:48:18 <DorpsGek> [OpenTTD/bananas-api] erenes updated pull request #88: Change: Follow redirect convention for login also for developer flow https://git.io/JOBxj 10:59:02 *** lobstarooo has joined #openttd 11:02:32 *** HerzogDeXtEr has joined #openttd 11:06:09 *** sla_ro|master has quit IRC 11:06:16 *** lobster has quit IRC 11:06:22 *** lobstarooo is now known as lobster 11:26:27 <peter1138> https://github.com/memononen/nanosvg 11:26:28 <peter1138> Oof 11:37:07 <Timberwolf> Warmup exercise complete. https://i.imgur.com/CrIFXAg.png 11:37:12 <Timberwolf> So, what sort of boats are there? 11:37:52 <peter1138> small, large, wet, dry 11:47:40 <peter1138> https://www.youtube.com/watch?v=Q-44KECp-xQ 11:47:46 <peter1138> Them of course 11:53:04 <peter1138> Quite wobbly today 12:41:00 *** erle- has joined #openttd 12:48:16 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #9087: Update window scaling https://git.io/JODEJ 12:51:12 *** jottyfan has quit IRC 12:58:10 *** WormnestAndroid has quit IRC 12:58:23 *** WormnestAndroid has joined #openttd 13:00:57 *** glx has joined #openttd 13:00:57 *** ChanServ sets mode: +v glx 13:06:02 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #9104: Fix typo and improve bug report instructions https://git.io/JO7GB 13:07:29 *** iSoSyS has joined #openttd 13:07:32 *** WormnestAndroid has quit IRC 13:07:45 *** WormnestAndroid has joined #openttd 13:08:37 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #9104: Fix typo and improve bug report instructions https://git.io/JO7GB 13:09:32 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9104: Fix typo and improve bug report instructions https://git.io/JO7ZI 13:09:51 *** iSoSyS has quit IRC 13:10:17 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #9104: Fix typo and improve bug report instructions https://git.io/JO7GB 13:13:50 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #9104: Fix typo and improve bug report instructions https://git.io/JO7Zh 13:14:36 *** Beerbelott has joined #openttd 13:15:58 <peter1138> Alright 13:16:04 <Beerbelott> Hello! Lol Rubidium I saw #9080 landed in master the exact same week I was tackling the problem of "Player"-named users filling servers. I had already patched my instances forbiding such prefix, but I leveraged the "kick" function on connection with the username was deemed invalid 13:16:13 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9104: Fix typo and improve bug report instructions https://git.io/JO7n0 13:16:31 <Beerbelott> It is then that I noticed sometimes username came with a leading NUL character... 13:17:04 <peter1138> Hovercraft drifting out of Ryde... 13:18:54 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #9104: Fix typo and improve bug report instructions https://git.io/JO7cQ 13:20:07 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #9104: Fix typo and improve bug report instructions https://git.io/JO7GB 13:22:10 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9104: Fix typo and improve bug report instructions https://git.io/JO7Cr 13:48:26 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #9094: Electric train waits for free path when track is not electrified https://git.io/JOSrh 14:08:21 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #9099: "Feature": Bigger packets in network protocols https://git.io/JO7Ez 14:09:00 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #9099: "Feature": Bigger packets in network protocols https://git.io/JO9Ix 14:10:37 <TrueBrain> Rubidium: there are two cases of that :D 14:10:44 <Rubidium> yeah, I just noticed that 14:11:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #9099: "Feature": Bigger packets in network protocols https://git.io/JO9Ix 14:12:38 <TrueBrain> I wonder how much we need our custom window-code with this (in the transfer of the map) 14:12:43 <TrueBrain> but that is not for this PR 14:13:22 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9099: "Feature": Bigger packets in network protocols https://git.io/JO7u8 14:13:34 <Rubidium> it effectively makes the window about 22.5 times larger 14:13:45 <TrueBrain> I meant more, if we cannot remove it now :) 14:13:54 <Rubidium> @calc (32767-3)/(1460-3) 14:13:54 <DorpsGek> Rubidium: 22.487302676733012 14:16:28 <TrueBrain> I mean, doing something TCP is already doing, is not the most fruitful thing to do :P :D 14:18:11 <DorpsGek> [OpenTTD/OpenTTD] Berbe opened pull request #9105: Improve server logs for administration https://git.io/JO7zZ 14:19:47 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on pull request #9017: WIP: allow multiplayer without port forwarding (using STUN) https://git.io/JO7g2 14:19:58 *** Progman has quit IRC 14:20:25 <Rubidium> I don't know why the window was added, I could imagine it was to not saturate an uplink. After all, if I dump 2 MB of data onto a slow uplink and then send more smaller packets. I would expect those smaller packets being delivered to the OS later, so they get sent later. However, in MP you want to be able to sent you sync messages while uploading the game to someone else 14:22:40 <TrueBrain> I will have to look into the code again, but what I remember it was kinda the reverse 14:22:45 <TrueBrain> it helped to saturate fast uplinks 14:22:54 <TrueBrain> as otherwise it would only send N packets per game-tick 14:23:09 <TrueBrain> but my memory is not the best, so I can be completely wrong :D 14:23:36 <Rubidium> I could imagine the window size "management" was added to achieve that, but then it would have probably sent a lower amount before 14:24:22 <TrueBrain> something to put on a list to check :) 14:25:21 *** jottyfan has joined #openttd 14:26:09 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9105: Improve server logs for administration https://git.io/JO72o 14:27:24 <Rubidium> TrueBrain: should I summon the person who merged that code into trunk back in the day? ;) 14:27:37 <TrueBrain> its either you or me, I would guess, so .. :P 14:27:53 <Rubidium> as it is from before I was involved with OpenTTD 14:27:59 <TrueBrain> so me :P 14:28:07 <Rubidium> @log b8f6d414 14:28:51 <Rubidium> has DorpsGek lost its ability to tell something about a commit message, or did I misremember the command for it? 14:29:01 <TrueBrain> lost long ago :) 14:29:08 <TrueBrain> never had it for GitHub I think :) 14:29:09 <nielsm> there was a command for that? 14:30:01 <TrueBrain> yeah, I added that code, right .. guess I will look into what it solved some day :) 14:30:32 <peter1138> Probably helped with map downloading for 56k users ;) 14:30:36 <Rubidium> that must be some archeological dig in some very old logs 14:30:56 <TrueBrain> well, first I can just check if my suspicion is correct, that it is to send more than 1 packet per game tick :P 14:31:11 <TrueBrain> that is just a code-wise evaluation :D 14:31:35 <Rubidium> it's definitely achieves sending more than 1 packet, but whether it ever was just sending one packet I do not know 14:35:41 *** sla_ro|master has joined #openttd 14:37:32 <Rubidium> before that it seems to have always sent 20 packets each tick, though of 250 bytes 14:38:12 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9105: Improve server logs for administration https://git.io/JO7VP 14:38:36 <TrueBrain> yeah .. so with your change now, it might well be that we don't really need it anymore 14:38:42 <TrueBrain> as we let TCP find a good value 14:38:45 <Rubidium> so the change was made in the network branch of late 2004 14:38:47 <TrueBrain> still limits the max bandwidth, ofc 14:39:26 <peter1138> I played a game of OpenTTD again, but had to stop and fix something. 14:39:33 <TrueBrain> peter1138: lol :) 14:40:17 <DorpsGek> [OpenTTD/OpenTTD] Berbe commented on pull request #9105: Improve server logs for administration https://git.io/JO7wI 14:42:43 <Rubidium> TrueBrain: the windowing code is to solve the slow transfer on fast links issue with the code before, though why did they not remove the limit from it all together? Because if it was that it was slow to transfer on fast links, then removing the limit would solve that and offload the handling to the OS. However, that it did something itself implies that there is some alterior motive behind implementing 14:42:49 <Rubidium> windowing over just dumping everything onto the OS stack as fast as possible 14:43:03 <Rubidium> I'm just not sure what/why that would be, except my previously shared hypothesis 14:43:07 <TrueBrain> Rubidium: I think you are overthinking that reasoning :D 14:43:08 *** Progman has joined #openttd 14:43:27 *** jottyfan has quit IRC 14:43:38 *** jottyfan has joined #openttd 14:43:40 <TrueBrain> originally, saveload wasn't threaded or anything 14:43:44 <TrueBrain> so the full blob was available 14:44:01 *** jottyfan has quit IRC 14:44:02 <Rubidium> why would you implement windowing, if just dumping all packets onto the network buffer would suffice? 14:44:03 <TrueBrain> so I think what I couldn't figure out how to back off nicely 14:44:08 <TrueBrain> when the OS reported: cannot send 14:44:17 <TrueBrain> so I think this is the workaround for that 14:44:47 <TrueBrain> (as on most transfers, you cannot just dump the full savegame into the OS buffer, especially back in the day :D) 14:44:50 <DorpsGek> [OpenTTD/OpenTTD] Berbe commented on pull request #9105: Improve server logs for administration https://git.io/JO7wi 14:44:51 <Rubidium> if the OS could not send, the packet queue would just become longer 14:45:06 <TrueBrain> hmm, have to look into it a bit more 14:45:16 <TrueBrain> but this just might be silly me not fully grasping reality :) 14:46:10 <TrueBrain> and this, ladies and gentlemen, is why we leave comments in code :P 14:46:11 <TrueBrain> :D :D 14:47:14 <milek7> eh, all that legacy fullscreen handling in win32 driver only interferes with dxgi model 14:50:34 <Rubidium> TrueBrain: though it might be that this code has become somewhat moot with the threaded savegame stuff... let me do some tests 14:51:01 <michi_cc> TrueBrain: You could look at the commits of the old branch: http://www.icosahedron.de/openttd/git/svn_mirror.git/shortlog/refs/heads/network 14:51:35 <TrueBrain> Rubidium: I really think it is :) 14:51:45 <TrueBrain> michi_cc: NICE! I was about to get my svn archive from storage, but that is easier :D 14:57:28 <Rubidium> -Fix: [New Network] Sending over the map is redone, this way it won't hang the server while sending (also tnx go to Tron ;)) 14:58:37 <Rubidium> http://www.icosahedron.de/openttd/git/svn_mirror.git/commitdiff/8769c618f8a982787b627e2b5ed2f4a7d9cbc311#patch4 15:00:07 <TrueBrain> okay, so partially what I was thinking .. sending everything was bad 15:00:10 <TrueBrain> sending 1 packet was bad too 15:00:26 <TrueBrain> so this was back-pressure from the OS send(), I guess 15:01:01 <TrueBrain> OS doesn't accept all packets (as buffers are not that big), so the server was freezing up till the OS did have room 15:01:12 <TrueBrain> changed into send just enough to the buffer till the OS says: NO 15:01:24 <TrueBrain> I guess that means it is still valid :) 15:09:47 <TrueBrain> just with your change we now put more in the buffer, which in this day and age might actually improve transfer speeds :P 15:10:30 <TrueBrain> guess the code could be a bit more elegant .. send-packet, OS still okay? send-next-packet, etc, till OS says: STOP 15:10:32 <TrueBrain> dunno 15:10:46 <TrueBrain> we keep finding random rabbit holes in the network code, maybe I shouldn't have mentioned it :D 15:11:11 <Rubidium> well, with my debug build and a small savegame I get to sent_packets of >= 128, though it will not be able to sent as many as not enough are coming from the save game compression 15:15:33 <Rubidium> though if the save game is big enough and the compressed packets were coming slow enough it might even hit a larger threshold. In the packet writer there, by the way, is a queue of packets still to send (before the windowing code) that gives the map size a higher priority in that queue, though it is quite likely that is only send as the second-to-last packet unless the link is really slow 15:16:23 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9105: Improve server logs for administration https://git.io/JO7is 15:20:12 <TrueBrain> well, I would say .. if increasing the packets with 22 times doesn't make the situation worse, lets pin it for now. At least, I have bigger fish the fry for networking :D 15:27:10 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9105: Improve server logs for administration https://git.io/JO7XA 15:28:05 <Rubidium> @calc 32*1.5*30 15:28:05 <DorpsGek> Rubidium: 1440 15:30:06 <Rubidium> So 32K packets of ~1.5 KiB 30 times a second => ~ 1400 MiB/s... I guess that would be an acceptable upload speed limit 15:30:58 <TrueBrain> why would there only be 1.5 KiB in a packet? 15:32:45 <TrueBrain> (just curious btw :P) 15:33:11 <nielsm> do our TCP sockets run with Nagle's Algorithms enabled or disabled? 15:33:37 <nielsm> since that probably makes a difference for transfer speeds if the send() calls are small 15:34:01 <nielsm> just one algorithm there 15:34:03 <TrueBrain> TCP_NODELAY is enabled on all sockets, if I am not mistaken 15:34:32 <TrueBrain> I am not mistaken :P 15:34:46 <nielsm> can it be toggled on the fly? it might make sense to disable NODELAY while doing bulk transfers 15:35:13 <TrueBrain> currently it cannot, but that is just because the function is called SetNoDelay() 15:35:14 <TrueBrain> :D 15:35:22 <TrueBrain> I doubt there is any other reason :P 15:35:37 <TrueBrain> why is this code so full of rabbit holes :D 15:35:53 *** snail_UES_ has joined #openttd 15:36:05 <TrueBrain> (as doing that would require some benchmarking on an Internet simulated network namespace I guess .. and down we go :D ) 15:36:25 <TrueBrain> benchmarking that over loopback interface might not give a real indication :D 15:36:33 <Rubidium> @calc 32768*(32767-3)*33 15:36:33 <DorpsGek> Rubidium: 35429154816 15:36:52 <Rubidium> TrueBrain: the ~1.5 is the 1460 that it is now in master 15:37:05 <TrueBrain> Rubidium: owh, you meant now, sorry .. that explains :) 15:37:08 <TrueBrain> I was thinking after your PR :P 15:37:28 <Rubidium> with bigger packets that the limit be 35 GiB/s 15:37:37 <TrueBrain> the limit is never so much the problem ;) 15:37:48 <TrueBrain> the time it takes to get to that limit however .. 15:38:20 <TrueBrain> we start with 4, how cute :) 15:38:36 <TrueBrain> @calc 4 * 1460 * 33 / 1024 15:38:37 <DorpsGek> TrueBrain: 188.203125 15:38:49 <Rubidium> with you could hit that limit after ~300 ms 15:38:50 <TrueBrain> 188 KiB/s I guess 15:39:27 <TrueBrain> @calc 4 * 32768 * 33 / 1024 15:39:27 <DorpsGek> TrueBrain: 4224 15:39:34 <Rubidium> alternatively is a limit of 2.2 PiB/s which I think is a bit excessive, and with a bit more logic could make that 4.4 PiB/s 15:39:35 <TrueBrain> 4.2 MiB/s after your PR :D 15:40:09 <TrueBrain> what might be worth a try some day (not now), is what happens if we make "SendPacket" directly send it to send() 15:40:10 <Rubidium> is savegame compression going to beat that any time soon? 15:40:13 <TrueBrain> and based on that feedback, send more 15:40:23 <TrueBrain> removes a lot of this code, I would guess 15:40:55 <TrueBrain> but okay, my original question was: can we remove it now 15:40:58 <TrueBrain> the answer is: nope 15:41:13 <TrueBrain> the next was: does going to 32k hurt anything .. I guess the answer is: not really 15:47:32 <DorpsGek> [OpenTTD/OpenTTD] Berbe updated pull request #9105: Improve server logs for administration https://git.io/JO7zZ 15:48:54 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9017: WIP: allow multiplayer without port forwarding (using STUN) https://git.io/JO7y4 15:49:33 <DorpsGek> [OpenTTD/OpenTTD] Berbe commented on pull request #9105: Improve server logs for administration https://git.io/JO7yz 15:50:31 <Beerbelott> TrueBrain: I feel refactoring the log levels shall be addressed in its own PR 15:50:36 <TrueBrain> ofc 15:50:53 <TrueBrain> it still feels your PR outputs the IP in the chat messages now too btw, but I have to check out the code in more detail for that :) 15:50:59 <Beerbelott> I won't tackle that in this one. Btw; pushed changes.. which made me touch language strings. No choice :( 15:51:10 <TrueBrain> still not fully sure what you try to do there, honestly :D 15:51:30 <TrueBrain> but now first: dinner! 15:51:53 <Beerbelott> TrueBrain: Look at the trick in NetworkTextMessage definition :) 15:52:03 <Beerbelott> Enjoy 15:53:50 <Beerbelott> Associating client name & hostname. It is never done anywhere in the logs. Also, have automated log analysis in mind. :P 15:56:33 *** jottyfan has joined #openttd 16:05:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #9106: Fix: [Network] Under certain circumstances the 'sent_packets' could overflow... https://git.io/JO796 16:28:15 *** Wormnest has joined #openttd 16:28:42 <DorpsGek> [OpenTTD/OpenTTD] Berbe updated pull request #9105: Improve server logs for administration https://git.io/JO7zZ 16:32:55 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #9102: Fix: Use width of tiny arrow string instead of scaled pixels in ship/aircraft list. https://git.io/JO7FI 16:42:40 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9106: Fix: [Network] Under certain circumstances the 'sent_packets' could overflow... https://git.io/JO7bH 16:44:45 *** Gustavo6046 has joined #openttd 16:44:52 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9105: Improve server logs for administration https://git.io/JO7NL 16:45:00 <TrueBrain> Beerbelott: an image says a thousand words :) 16:48:25 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on pull request #9105: Improve server logs for administration https://git.io/JO7No 16:48:47 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9105: Improve server logs for administration https://git.io/JO7NP 16:51:03 <TrueBrain> Beerbelott: this is why I was thinking about a DEBUG() statement instead, so a GUI host can still set it to -dnet=4 or what-ever to see these things 16:51:07 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #9102: Fix: Use width of tiny arrow string instead of scaled pixels in ship/aircraft list. https://git.io/JOQd4 16:52:09 <milek7> why Paint is called before releasing video buffer? 16:52:22 <milek7> it just adds extra frame of latency, right? 16:53:38 *** jottyfan has joined #openttd 16:54:22 <jottyfan> I know there are a lot of issues in github, but after one week, I hoped that my issue would be at least tagged with some labels... does anyone care? https://github.com/OpenTTD/OpenTTD/issues/9056 16:55:29 <TrueBrain> both me and nielsm solved that issue for you :) 16:55:38 <TrueBrain> don't mistake "lack of labels" for "interest" :) 16:55:41 <jottyfan> how that? 16:55:48 <TrueBrain> some bugs are just so trivially explained, that it just requires someone picking it up 16:55:51 <michi_cc> milek7: Yes, but if you don't have time where the GPU can do the work in the background, you just block the drawing thread. 16:55:59 <TrueBrain> jottyfan: we labeled it now :D 16:56:03 <jottyfan> thx 16:56:04 <jottyfan> :) 16:56:19 <TrueBrain> it really didn't need labels, as it is an excellent written ticket :) 16:56:21 <jottyfan> you call it a bug? 16:56:33 <TrueBrain> if you cannot read information on a window, that is a bug, yes :) 16:56:45 <jottyfan> I think if I switch off the 2x zoom, that is not a bug any longer 16:57:21 <TrueBrain> still a bug :P A low-prio one, granted, but a bug nevertheless :) 16:57:30 <TrueBrain> well, a "missing feature" 16:57:36 <TrueBrain> also a fine way to describe it :D 16:57:37 <jottyfan> however, thanks for adding the tag 16:57:44 <jottyfan> I'm looking forward to that solution :) 16:58:05 <jottyfan> If I could code in C, I'd try to solve that and make a pull request 16:58:07 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9105: Improve server logs for administration https://git.io/JO7A7 16:58:14 <jottyfan> but I'm simply a Java developer... 16:58:19 <TrueBrain> jottyfan: many of us started by fixing issues like this 16:58:26 <TrueBrain> it is small, it is contained 16:58:31 <TrueBrain> excellent place to start 16:58:49 <jottyfan> well, i could spend one our today 16:59:00 <jottyfan> if you give me a hand which classes to look after for examples? 16:59:02 <TrueBrain> only if you like to learn C++, ofc :) 16:59:32 <milek7> michi_cc: well it's drawing *thread*, so who cares if it is blocked 16:59:35 <Xaroth> I'd say just have a go at it. I pretty much only do python, but I still manage to get TrueBrain facepalm at my PRs :P 17:00:15 <jottyfan> so - where to start? 17:00:22 <TrueBrain> checkout the code 17:00:25 <TrueBrain> get a compiler and editor 17:00:26 <TrueBrain> :D 17:00:31 <TrueBrain> make sure you can build OpenTTD 17:00:32 <jottyfan> using linux, should be easy 17:00:35 <michi_cc> Drawing is in the main thread, which also handles e.g. everything caused by user input. 17:00:35 <TrueBrain> and I think this is the window: https://github.com/OpenTTD/OpenTTD/blob/9fa38f5d0f3b1bd67028a8d9d5ff06eed1a31cdf/src/company_gui.cpp#L1717 17:00:42 <nielsm> make sure you can build a working copy of the game from an unmodified checkout 17:00:43 <TrueBrain> it is missing a vscrollbar 17:01:10 <nielsm> (don't begin making modifications until you're sure you can build an unmodified version) 17:01:16 <peter1138> Some idiot's spent most of his week off working on GUI scaling stuff... it's not been ignored :) 17:01:24 <TrueBrain> what is a bit tricky, that you need to figure out when to draw and when not .. but as you know Java, programming itself shouldn't be difficult 17:01:53 <TrueBrain> do we have a nice example of a window with a vscrollbar? Hmm 17:02:09 <nielsm> framerate window maybe? 17:02:31 <TrueBrain> https://github.com/OpenTTD/OpenTTD/blob/9fa38f5d0f3b1bd67028a8d9d5ff06eed1a31cdf/src/company_gui.cpp#L1054 has one, in the same file 17:02:40 <nielsm> town or industry lists 17:02:44 <peter1138> My gripe is that not all the lines are the same height, so it makes scrolling a bit more complex 17:02:53 <TrueBrain> and it is just basically creative copy/pasting from there jottyfan :) 17:03:15 <jottyfan> yes, looks like this 17:03:20 <jottyfan> I give it a try 17:03:28 <TrueBrain> it is not 100% trivial 17:03:30 <jottyfan> thanks for your quick help 17:03:37 <TrueBrain> so it will take you some time , at least, it would take me some time :P 17:03:44 <TrueBrain> but yeah, first make sure you can build OpenTTD without modifications 17:03:47 <TrueBrain> and that it runs etc 17:03:51 <TrueBrain> really important! 17:03:52 <jottyfan> so it will take for me 17:04:12 <jottyfan> let's see what I have after one hour 17:04:25 <peter1138> Took me longer than that to set up VS Code :( 17:04:25 <TrueBrain> worst case, you learnt a bit more about C++ :D 17:04:31 <jottyfan> when I'm done, simply making a pull request is enough? Or better using diffs? 17:04:37 <TrueBrain> PR is fine :) 17:04:40 <peter1138> PR is prefered. 17:04:46 <jottyfan> great 17:04:52 <TrueBrain> but, if you like, you can print it and email it to Xaroth 17:04:57 <TrueBrain> he will type it in and PR it :P 17:05:00 <Xaroth> I do like fanmail. 17:05:02 <TrueBrain> email -> post 17:05:03 <milek7> michi_cc: you worry about user input but *this* is the cause of most user input delays 17:05:06 <milek7> sorry, but I don't agree :P 17:05:08 <glx> oh and work inside a branch, not directly in master 17:06:17 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #9106: Fix: [Network] Under certain circumstances the 'sent_packets' could overflow... https://git.io/JO7xQ 17:06:48 <jottyfan> ok, so I fork the project, make a branch, push that branch to my fork and make a pull request? 17:06:58 <glx> exactly 17:07:03 <jottyfan> if it is on my own fork, why not developing in the main branch? 17:07:09 <jottyfan> I know how to use git 17:07:16 <dwfreed> because it gets messy 17:07:17 <peter1138> Because when you need to update your copy of master... 17:07:45 <peter1138> Always best to avoid working on master. 17:07:48 <jottyfan> ok 17:09:10 <jottyfan> anyone using debian linux: is it just make to compile, or do I need cmake or sth. other? 17:09:20 <glx> you need cmake 17:09:34 <glx> to configure 17:09:44 <glx> then make should work 17:09:49 <DorpsGek> [OpenTTD/OpenTTD] Berbe commented on pull request #9105: Improve server logs for administration https://git.io/JO7pR 17:10:10 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #9107: Fix: Count engine details text in lines rather than pixels. https://git.io/JO7pu 17:12:26 <jottyfan> looks like I need libsdl-dev also 17:12:34 <Beerbelott> TrueBrain: I agree with you: in case of GUI-started server, the host will still see this piece of information in his game, which might be indeed seen as suboptimal. It all boils down to what use are the debug facilities meant for... bu as you pointed out, it seems to be a bit foggy these days. 17:13:22 <TrueBrain> well, if you don't mind, we might just as well fix it now :D 17:13:35 <TrueBrain> been annoying me for a long time already, so I would really like that :) 17:13:52 <jottyfan> are you talking to me? 17:14:02 <TrueBrain> no :) 17:18:55 <TrueBrain> Beerbelott: especially if I think about Steam support, then I guess people want this to be SteamIDs instead of IPs .. GUI uses shouldn't have to see nor know that :D 17:19:03 <TrueBrain> that is all just "advanced" user stuff, in my book :) 17:21:18 <Beerbelott> I already had a look at levels 2-4 before I decided to move the connection level 1 to 2. I might have a look at all net facilities levels in the coming days, unless it itches too much :D 17:23:27 <Beerbelott> the baseline is... probably not today (: 17:23:30 <jottyfan> building the sources worked out of the box; mkdir build; cd build; cmake ..; make - only it took a while 17:24:36 <Beerbelott> jottyfan: Required libraries are documented here: https://github.com/OpenTTD/OpenTTD/blob/master/COMPILING.md 17:25:37 <jottyfan> a pity that there is no cmake option like -DCMAKE_USE_CPU=8 or such 17:26:41 <TrueBrain> make -j9 17:27:31 <jottyfan> ok, noted, thx 17:27:33 <Beerbelott> https://manpages.debian.org/buster/make/make.1.en.html 17:27:38 <Beerbelott> -j or -l 17:28:13 <TrueBrain> well, never use "make -j" ofc :) That will blow up your computer :D 17:28:31 <TrueBrain> always put a number behind it :P 17:28:56 <Beerbelott> Well, RTFM: "If the -j option is given without an argument, make will not limit the number of jobs that can run simultaneously." (o: 17:29:28 <Beerbelott> Particularly nasty when your CI breaks and the number following "-j" ends up being an empty string 17:29:30 * Beerbelott sighs 17:31:17 <TrueBrain> reading manuals ... lol .. NEVAH! :D 17:32:57 <peter1138> Hmm, I was meant to look into Azure for CI at some point. Totally forgot about it. 17:33:29 <TrueBrain> kinda similar to GHA :P 17:34:04 <peter1138> For closed work stuff, where some of Azure is already available, but I don't think GH is. 17:35:36 <Beerbelott> peter1138: Provisioning with Terraform is quite seamless. I'll leave "cloud" as work tasks, though. Erk. 17:35:59 <peter1138> I am in favour of not self-hosting things these days, if it saves me having to adminstrate... 17:36:23 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #9106: Fix: [Network] Under certain circumstances the 'sent_packets' could overflow... https://git.io/JO796 17:37:14 <peter1138> Previously used Jenkins at $job-1 but that was a nightmare. 17:38:44 *** Flygon has quit IRC 17:40:52 <jottyfan> what is that SetPIP(WD_FRAMERECT_TOP, 4, WD_FRAMETEXT_BOTTOM) about? 17:41:21 <TrueBrain> SetPIP sets the padding between objects: before, between, after 17:41:29 <TrueBrain> every function has a doxygen comment, explaining what it does 17:41:34 <peter1138> "every" 17:41:35 <TrueBrain> most editors show this if you hover over them 17:41:40 <TrueBrain> "every", yes, sorry :) 17:42:00 <jottyfan> ok, thx 17:43:42 <peter1138> Oof, I see. That window is split up into separate widgets for each bit of data. That isn't going to work well with a scrollbar. 17:43:52 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #9106: Fix: [Network] Under certain circumstances the 'sent_packets' could overflow... https://git.io/JO796 17:44:17 <peter1138> OpenTTD scrollbars (currently) only deal with 1 widget. 17:44:47 <jottyfan> so the chunks need to be encapsulated to scroll them all at once? 17:45:05 <peter1138> I don't think there's a way to do that with the UI system currently. 17:45:55 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #9106: Fix: [Network] Under certain circumstances the 'sent_packets' could overflow... https://git.io/JO796 17:46:09 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9106: Fix: [Network] Under certain circumstances the 'sent_packets' could overflow... https://git.io/JO5JW 17:48:20 <jottyfan> maybe I have a look at the subsidies window as an example... 17:51:15 <jottyfan> seems to be much easier to understand :) 17:53:26 <peter1138> Yeah, sorry, this window is a lot harder to just add a scrollbar to. 17:54:25 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #9106: Fix: [Network] Prevent stalling save game transfer when compression is slow https://git.io/JO796 17:57:14 <TrueBrain> frosch123: https://github.com/OpenTTD/workflows/runs/2432607317?check_suite_focus=true 17:57:34 <TrueBrain> by pure chance/luck/badluck, Rb merged when eints wanted to do its thing 17:57:35 <TrueBrain> lol 17:57:52 <TrueBrain> we can just retrigger this, right? 17:58:07 <frosch123> yes, it reclones every time 17:58:23 <frosch123> it's not efficient :p 17:58:27 <TrueBrain> what are the odds :D 17:59:02 <glx> main issue is we can't really declare a "no merge time" GHA timer is weird :) 17:59:15 <frosch123> TrueBrain: i think there is a window of 5 minutes 17:59:42 <TrueBrain> yeah ... happens once now in .. how much time 17:59:46 <TrueBrain> I am completely fine ignoring this :D 18:00:11 <frosch123> 17:49:41 - 17:55:28 <- that was the window :) 18:04:30 <Rubidium> so, when should I push to get an inconsistent nightly? 18:04:48 *** virtualrandomnumber has joined #openttd 18:04:54 *** virtualrandomnumber has quit IRC 18:05:02 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/JO5Tr 18:05:03 <DorpsGek> - Update: Translations from eints (by translators) 18:12:42 *** erle- has quit IRC 18:14:26 <frosch123> Rubidium: noone knows, the time varies by 30 minutes every day, or so 18:24:24 <jottyfan> being confused... 18:24:26 <jottyfan> https://github.com/OpenTTD/OpenTTD/blob/9fa38f5d0f3b1bd67028a8d9d5ff06eed1a31cdf/src/company_gui.cpp#L1935 18:24:53 <jottyfan> this check should be obsolete as e are in the switch (widget) case WID_CI_TOTAL 18:25:04 <jottyfan> or am I missing sth? 18:27:34 <DorpsGek> [OpenTTD/OpenTTD] LordAro closed issue #9103: Typo in bug report template from #9092 https://git.io/JOQF7 18:27:37 <DorpsGek> [OpenTTD/OpenTTD] LordAro merged pull request #9104: Fix typo and improve bug report instructions https://git.io/JO7GB 18:29:26 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #9107: Fix: Count engine details text in lines rather than pixels. https://git.io/JO5td 18:30:29 <peter1138> jottyfan, thare a 6 case labels that follow that code path. 18:30:34 <peter1138> ... 18:30:35 <peter1138> * 18:30:37 <peter1138> there are 18:31:35 <jottyfan> this is a combined case? 18:31:49 <peter1138> Yes. Because the UI system doesn't actually support grids, it works out the minimal width for ALL of those widgets and sets it to the same. 18:31:53 <jottyfan> so all 18:31:55 <jottyfan> case WID_CI_RAIL_COUNT: 18:31:55 <jottyfan> case WID_CI_ROAD_COUNT: 18:31:55 <jottyfan> case WID_CI_TRAM_COUNT: 18:31:55 <jottyfan> case WID_CI_WATER_COUNT: 18:31:55 <jottyfan> case WID_CI_STATION_COUNT: 18:31:56 <jottyfan> case WID_CI_TOTAL: 18:32:02 <jottyfan> belong to the last block? 18:32:18 <peter1138> Yup 18:32:22 <jottyfan> ough 18:32:37 <LordAro> i'll be honest, i missed that 18:32:41 <jottyfan> nvm 18:32:43 <jottyfan> my time is up 18:32:52 <LordAro> i was just assuming it was just something left over from refactoring 18:32:56 <jottyfan> I could add the scrollbar and the resize button, but without functionaliry 18:33:20 * LordAro is too tired to be doing code review 18:33:21 <jottyfan> but I think this must be reworked differently 18:33:38 <jottyfan> I wonder if my changes should be rescued 18:33:55 <peter1138> I think this window is a tricky one, and that's why it wasn't done yet. 18:34:06 <jottyfan> looks that way 18:34:19 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #9107: Fix: Count engine details text in lines rather than pixels. https://git.io/JO7pu 18:34:21 <jottyfan> but it is similiar to the subsidies window 18:34:35 <jottyfan> at least in general 18:34:42 <peter1138> Subsidies will be just one widget that is scrollled. 18:34:46 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #9108: Change: [Network] Remove now defunct save game transfer packet limiter https://git.io/JO5qi 18:35:27 <peter1138> I'm currently "incidentally" working on patch that can scroll a container... 18:36:05 <jottyfan> so I just quit the developing here, but thanks for taking over of that problem 18:36:26 *** Beerbelott has quit IRC 18:36:30 <jottyfan> this is currently the only thing that is sad on playing OpenTTD 18:36:34 <jottyfan> :/ 18:36:36 <jottyfan> however 18:36:54 <Rubidium> no nightly tonight I reckon 18:37:03 <LordAro> /home/runner/work/OpenTTD/OpenTTD/src/lang/japanese.txt:2405: FATAL: Unwanted UTF-8 character U+200B in sequence '{BLACK}道路の種類を変更/アップグレードします.Shiftは、コスト見積もりの作成/表示を切り替えます' 18:37:07 <peter1138> Only thing? Plenty :D 18:37:07 <LordAro> well that's fun 18:37:09 <jottyfan> thanks for all the help, at least, I learned a bit of coding openttd (yet I can compile it :)) 18:38:01 <LordAro> zero-width space, apparently 18:40:15 <peter1138> jottyfan, you might find other itches though :) 18:40:34 <jottyfan> yes, maybe 18:41:27 <jottyfan> but in the end I would need a senior developer to check my code (style) and the way how I solve things - as unexperienced as I am in c++ 18:43:56 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9108: Change: [Network] Remove now defunct save game transfer packet limiter https://git.io/JO5mz 18:44:02 *** jottyfan has quit IRC 18:44:06 *** Wormnest has quit IRC 18:44:59 <TrueBrain> lovely, eints lets in invalid utf-8? :D 18:45:06 <_dp_> hm, does #9108 need any previous network prs? 18:45:21 <_dp_> as I'm tempted to just merge in on citymania server and see what happens 18:47:50 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on pull request #9108: Change: [Network] Remove now defunct save game transfer packet limiter https://git.io/JO5mH 18:48:43 *** WormnestAndroid has quit IRC 18:48:46 <Rubidium> _dp_: you need at least two to merge this. #9106 which is practically a no-op as #9108 removes that change completely, and the rewrite of the packet logic. Though a light variant of the patch could be made 18:48:46 *** WormnestAndroid has joined #openttd 18:51:37 <_dp_> yeah, that's fine 18:51:46 <DorpsGek> [OpenTTD/eints] LordAro opened issue #43: eints allows submitting strings with disallowed UTF8 characters https://git.io/JO5Y8 18:51:50 <_dp_> I was more worried if it needs larger packets to work properly 18:52:07 <Rubidium> no, larger packets have not been merged yet 18:54:02 <DorpsGek> [OpenTTD/eints] LordAro commented on issue #43: eints allows submitting strings with disallowed UTF8 characters https://git.io/JO5Y8 18:55:26 <DorpsGek> [OpenTTD/OpenTTD] James103 opened issue #9109: Malformed string in Japanese language causes all builds to fail https://git.io/JO5YS 18:58:20 <DorpsGek> [OpenTTD/OpenTTD] LordAro opened pull request #9110: Fix #9109: Malformed STR_ROAD_TOOLBAR_TOOLTIP_CONVERT_ROAD in Japanese lang https://git.io/JO5OZ 18:58:48 <LordAro> i was in the process of writing the commit message when James opened the issue ^^ 19:00:39 <TrueBrain> You can't say he isn't on top of things :D 19:01:09 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9110: Fix #9109: Malformed STR_ROAD_TOOLBAR_TOOLTIP_CONVERT_ROAD in Japanese lang https://git.io/JO5OV 19:01:16 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on pull request #9110: Fix #9109: Malformed STR_ROAD_TOOLBAR_TOOLTIP_CONVERT_ROAD in Japanese lang https://git.io/JO5Ow 19:03:08 <LordAro> saved me having to look up the commit hash, anyway 19:05:25 <nielsm> so ZWS is explicitly named as an "unwanted character" in strgen, not just as part of a range or a class, but as an individual codepoint 19:05:35 <nielsm> but why? there must be some reason for that 19:05:41 <LordAro> nielsm: see the eints issue :) 19:06:54 <Rubidium> it being used in languages such as Danish 19:07:17 <LordAro> mildly flawed reasoning to ban it from all languages, but eh 19:07:27 <nielsm> yeah that's a bad reason 19:07:35 *** Soni has quit IRC 19:07:35 <LordAro> differentiating it per-language would be weirder 19:07:44 <nielsm> better would be to ignore space characters in checking font support 19:07:59 <Rubidium> and what wikipedia's source tells me that it's mainly used as "token" where space could be added when justifying text 19:08:00 <nielsm> "if the languages requires TTF to render anyway" 19:08:15 <LordAro> no? font is still required to "render" the space char 19:08:19 <LordAro> even if it's invisible 19:08:23 <LordAro> we can't know that 19:09:48 <nielsm> https://0x0.st/-mVy.png how the rejected string renders with the strgen limitation hacked out 19:10:19 <Rubidium> and without the zero-width-spaces? 19:10:25 <nielsm> let me just try 19:10:41 <LordAro> and does anyone know Japanese well enough to know if there's an issue with line breaks? 19:11:01 <LordAro> the fact that there were 2 together suggests it was just a mistake to me 19:11:18 <LordAro> c&p from somewhere, likely 19:12:03 <DorpsGek> [OpenTTD/OpenTTD] LordAro merged pull request #9110: Fix #9109: Malformed STR_ROAD_TOOLBAR_TOOLTIP_CONVERT_ROAD in Japanese lang https://git.io/JO5OZ 19:12:06 <DorpsGek> [OpenTTD/OpenTTD] LordAro closed issue #9109: Malformed string in Japanese language causes all builds to fail https://git.io/JO5YS 19:12:07 <Rubidium> as far as I remember Japanese is quite forgiving; it actually ought to be written from top to bottom and then left to right 19:12:18 <nielsm> https://0x0.st/-mVv.png with the ZWS removed 19:12:18 <LordAro> you can rebase now :) 19:12:24 <nielsm> (no difference in line breaking) 19:12:49 <LordAro> ...will eints replace it with the broken version again tomorrow? 19:12:55 <LordAro> how much state does it retain? 19:13:24 <nielsm> meanwhile, two buttons to the left, there is an instance of line breaking that is definitely incorrect: https://0x0.st/-mVx.png 19:13:31 <nielsm> there's a line break just before a fullstop 19:13:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 dismissed a review for pull request #9108: Change: [Network] Remove now defunct save game transfer packet limiter https://git.io/JO5mz 19:13:55 <nielsm> (that small circle at the start of second line is a japanese full width fullstop) 19:13:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #9108: Change: [Network] Remove now defunct save game transfer packet limiter https://git.io/JO5qi 19:15:35 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on pull request #9110: Fix #9109: Malformed STR_ROAD_TOOLBAR_TOOLTIP_CONVERT_ROAD in Japanese lang https://git.io/JO5sv 19:16:51 <Rubidium> the tooltips are pixel-for-pixel identical 19:16:52 <LordAro> nielsm: there is a newline character that can be specified in the strings, right? {} or so? 19:17:15 <nielsm> yes {}, I think strgen just encodes that to \n 19:20:04 <Rubidium> it might also be a mishandling of that character by the paragraph layout engine, or whatever it is called now 19:23:42 *** Wormnest has joined #openttd 19:23:55 <nielsm> otoh this was just with windows/uniscribe, maybe ICU or macOS handle it different 19:25:19 *** jottyfan has joined #openttd 19:27:58 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #9099: "Feature": Bigger packets in network protocols https://git.io/JO9Ix 19:28:57 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9108: Change: [Network] Remove now defunct save game transfer packet limiter https://git.io/JO5ZZ 19:29:26 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #9108: Change: [Network] Remove now defunct save game transfer packet limiter https://git.io/JO5qi 19:30:32 *** EER has quit IRC 19:55:26 *** andythenorth has joined #openttd 19:57:28 <andythenorth> yo 19:59:12 <Rubidium> oy 20:16:16 *** Wormnest has quit IRC 20:16:33 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #9099: "Feature": Bigger packets in network protocols https://git.io/JO5WS 20:22:40 <peter1138> Oh 20:22:47 <peter1138> nested_array isn't built yet :/ 20:22:58 <peter1138> And FillNestedArray is marked as expensive. 20:23:47 *** Soni has joined #openttd 20:31:19 *** frosch123 has quit IRC 20:37:19 *** lobstarooo has joined #openttd 20:40:49 *** Wormnest has joined #openttd 20:42:27 <peter1138> Pom te pom. What a wasted evening :p 20:43:45 *** lobster has quit IRC 20:43:50 *** lobstarooo is now known as lobster 20:45:02 <peter1138> Oh, actually it worked. Unexpected. 20:47:21 *** WormnestAndroid has quit IRC 20:47:52 *** WormnestAndroid has joined #openttd 20:51:28 *** nielsm has quit IRC 20:51:46 <peter1138> Oh right, scrollbar capacity is 'manually' adjusted. Hmm. 20:56:54 *** Samu has quit IRC 21:12:04 *** sla_ro|master has quit IRC 21:19:11 * andythenorth wonders if houses have a produce cb 21:19:13 * andythenorth looks 21:20:23 <andythenorth> CB 2E :D 21:28:05 *** Wolf01 has quit IRC 21:32:03 *** gelignite has quit IRC 21:37:10 <peter1138> Check there's no weird NML scaling :p 21:39:33 <peter1138> Alright, separate widget type then. 21:51:57 <DorpsGek> [OpenTTD/OpenTTD] Razmirus commented on pull request #9067: Feature: rework in-game Network GUI https://git.io/JO5z6 21:53:54 *** andythenorth has quit IRC 22:01:08 *** HerzogDeXtEr has quit IRC 22:02:21 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9067: Feature: rework in-game Network GUI https://git.io/JO52l 22:05:06 <_dp_> hm, if you remove money transfer will every second noob stop asking for money I wonder :p 22:06:08 <_dp_> so far it being disabled on a server do not seem to stop them in the slightest 22:15:33 *** Progman has quit IRC 22:20:18 <TrueBrain> It was a fun idea but it terribly sucks in reality :p 22:20:43 <TrueBrain> Especially as money is not all that important in the game after N years ;) 22:31:13 <peter1138> Oh, widgets are hard. 22:31:39 <DorpsGek> [OpenTTD/OpenTTD] LordAro opened pull request #9111: Fix 8a95fee4: Missing initialiser in constructor https://git.io/JO5rU 22:32:16 <peter1138> in constructor of what... 22:33:07 <TrueBrain> How did that work ... 22:33:09 <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #9111: Fix 8a95fee4: Missing initialiser in Packet constructor https://git.io/JO5rU 22:33:14 <peter1138> When things work only when you assign a widget index to your widget, otherwise they seem to work but not exactly... 22:42:36 <peter1138> DrawPixelInfo is pretty powerful.