Times are UTC Toggle Colours
00:47:43 <johnfranklin> Why can’t I play loop in Spotify now? What happened? 00:50:17 <wensimehrp> use Spotube then 😛 02:32:06 *** Flygon has joined #openttd 03:03:05 *** Wormnest has joined #openttd 03:13:15 *** gnu_jj_ has joined #openttd 03:16:54 *** gnu_jj has quit IRC 03:48:54 *** godbed has joined #openttd 03:49:13 *** Zathras has joined #openttd 03:52:36 *** debdog has quit IRC 04:16:28 *** Zathras is now known as debdog 04:46:24 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/95d22bac89dd8a592a9fbf401f598030d1b32a71 04:46:25 <DorpsGek> - Update: Translations from eints (by translators) 05:05:03 *** keikoz has joined #openttd 06:25:04 *** keikoz has quit IRC 07:18:08 <DorpsGek> [OpenTTD/survey-web] survey-summary[bot] pushed 1 commits to main https://github.com/OpenTTD/survey-web/commit/0b90dad4dff5651e76ab6cc19acdc6b3f8f9ceed 07:18:09 <DorpsGek> - Add: summary for week 49 of 2024 (by OpenTTD Survey) 07:31:12 <andythenorth> wensimehrp: I will merge the FIRS lang PR, but I have to read every line first 🙂 https://github.com/andythenorth/firs/pull/36/files 07:31:34 <andythenorth> translations are quite labour intensive 07:43:56 <wensimehrp> gehehe 07:44:34 <wensimehrp> andythenorth: sure I won't do cocks 😄 07:47:01 <peter1138> Eints doesn't validate either. 07:55:25 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13161: Fix: Scenario climate selection buttons shouldn't include size of (unset) integer. https://github.com/OpenTTD/OpenTTD/pull/13161 07:56:00 <peter1138> Oof, a codefix that. 08:16:05 <peter1138> Hmm, why is the NewGRF debug window not translatable? 08:20:37 <andythenorth> hmm wonder if something could validate translation files 😛 08:21:08 <peter1138> Yup, other humans. 08:23:31 *** tokai|noir has joined #openttd 08:23:31 *** ChanServ sets mode: +v tokai|noir 08:24:49 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13161: Codefix: Scenario climate selection buttons shouldn't include size of (unset) integer. https://github.com/OpenTTD/OpenTTD/pull/13161#pullrequestreview-2488081025 08:27:56 *** tokai has quit IRC 08:35:42 <andythenorth> peter1138: I get all these github dependabot alerts nagging me about vulnerable jquery in ancient tags 08:35:56 <andythenorth> can't that validate for `eval(malware)` 08:36:00 <andythenorth> 😛 09:14:28 <LordAro> why's it bothering to notify about existing tags? 09:14:31 <LordAro> that seems silly 09:17:35 <andythenorth> because they have vulns 09:17:48 <andythenorth> I have live code deployed on the web with vulnerable jquery in it 09:18:04 <LordAro> sure, but they're tags 09:18:08 <LordAro> tags don't get changed 09:18:10 <andythenorth> addressing that means either rewriting the tag, or pulling the version 09:18:29 <LordAro> exactly 09:18:42 <LordAro> seems silly to suggest that by default 09:20:05 <andythenorth> might be a dependabot setting I need to tune 09:20:27 <andythenorth> vulns in tags is a bit 'rock', 'hard place' 09:20:42 <andythenorth> but I suspect security wins 09:20:48 <LordAro> nice to know about perhaps 09:20:57 <LordAro> but repeated messages... eh 09:21:23 <andythenorth> it's weird to pull a tag for a grf because the html docs for the grf include a vulnerable jquery, for stuff I don't think I execute any code paths for 09:21:35 <andythenorth> with xss vulns on a static website served on S3 09:21:50 <andythenorth> not sure this internet thing is going to be 2024-12-09T22:47:29 <_jgr_> The language byte is FF, so a feature byte of 0 is ignored in that case 22:47:42 <_jgr_> It just goes into the normal AddGRFString path 22:49:55 <andythenorth> wensimehrp: the diff looks fine, I am confused why FIRS is declaring STR_COLOUR_GOLD etc 22:50:03 <andythenorth> but that's not really related to the PR 22:50:12 <andythenorth> but you don't need to translate those 22:51:35 <andythenorth> I can't see those strings used anywhere, they might be legacy stuff 22:51:42 <FLHerne> I've just finished reading and being puzzled at the argument above :p 22:53:32 <LordAro> look what i just found: https://laurent.le-brun.eu/blog/an-overview-of-starlark - "Hermetic execution. During the execution, the code cannot access the file system, network, or even look at the current date. You may be able to execute untrusted code." 22:53:38 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1315813639290224722/image.png?ex=6758c672&is=675774f2&hm=51fdffbf376f519cda3ecc4f909fa55084a8df4e0d0de3b4f77b4e5e26c32ad4& 22:53:38 <andythenorth> this is definitely weitd 22:53:38 <LordAro> FLHerne: best leave it at that 22:53:47 <FLHerne> anything capable of producing malicious code execution in a reasonably well-tested parser library of a well-defined format is not going to look like real text 22:54:37 <andythenorth> it's a policy issue that limits me 22:54:38 <FLHerne> so as long as you're making a cursory check that it looks like a genuine translation and not a string of obscenities I don't really see the concern 22:54:55 <FLHerne> but ultimately it's your project and your computer :p 22:55:13 <andythenorth> the devices are governed by policy 22:55:23 <LordAro> who's policy? 22:55:24 <andythenorth> unless I want to airgap and isolate them 22:55:49 <andythenorth> it relates to competence 22:56:14 <andythenorth> if I, or someone else trusted, is competent to assess the risk of the PR, then the policy covers it 22:56:17 <andythenorth> I am not 22:56:50 <LordAro> that's a perfectly reasonable way of doing things 22:57:20 <LordAro> what's not perfectly reasonable is ignoring the many people who are explaining why it's fine 22:57:41 <andythenorth> well I was reading the PR again and considering a validator...then things got...weird 22:57:51 <andythenorth> which reminded my why I hate newgrf translations full stop 🙂 22:58:40 <andythenorth> anyway, I don't know why FIRS is declaring strings for string codes 22:58:44 <andythenorth> that seems bizarre 22:59:45 <peter1138> God's sake. 22:59:51 <peter1138> Another biscuit gone 😦 23:00:02 <LordAro> peter1138: i've run out :( 23:00:31 <LordAro> andythenorth: does seem a bit odd, but many of OTTD's strings do that too 23:00:34 <peter1138> That seems careless. 23:00:55 <andythenorth> dunno if I can be bothered to read blame 😛 https://github.com/andythenorth/firs/blob/main/src/lang/english.lng#L573 23:01:01 <andythenorth> but these strings don't seem to be used 23:01:36 <andythenorth> they're not referenced in firs.nml 23:02:04 <andythenorth> and firs.gs has its own lang 23:02:43 <_glx_> well you have <https://github.com/andythenorth/firs/blob/v5-release-track/bin/remove_dead_lang_strings.py> 23:02:50 <peter1138> You can't even trust your own code now 😄 23:03:06 <andythenorth> I never did 23:03:33 <_glx_> but it seems to not really check if a string is used or not 23:04:25 <andythenorth> I just removed them and ran make 23:04:27 <andythenorth> no failures 23:05:23 <_glx_> maybe you need a script reading the toml, then search for each string in source 23:05:32 <peter1138> Hmm 23:05:56 <andythenorth> does nml report unused strings? 23:06:07 <andythenorth> I might have suppressed an existing warning 23:06:19 <andythenorth> it does check string use for lang translations 23:07:17 <_glx_> nml doesn't list unused strings, it just doesn't put them in the grf 23:07:26 <andythenorth> fair 23:08:23 <andythenorth> wensimehrp: the toml has changed 😛 23:08:46 <andythenorth> https://github.com/andythenorth/firs/commit/abb36a6674287f1d3ba49864f8a8f1a942ed5967 23:09:03 <andythenorth> remind me about the grf name another day also 😛 23:09:07 <andythenorth> time for sleep 23:15:50 <_glx_> I think it should be possible to report unused strings 23:16:44 <_glx_> I'll probably add it behind a flag 23:29:22 *** Wolf01 has quit IRC 23:36:04 <peter1138> Hmm, slightly better. 23:40:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13162: Codechangex: A transparent FrameRect doesn't care about colours. https://github.com/OpenTTD/OpenTTD/pull/13162 23:42:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13161: Codefix: Scenario climate selection buttons shouldn't include size of (unset) integer. https://github.com/OpenTTD/OpenTTD/pull/13161 23:42:59 <peter1138> The things I find when refactoring something else... 23:43:09 <DorpsGek> [OpenTTD/dibridge] poVoq opened issue #255: Latest version fails to start with: No module named 'audioop' https://github.com/OpenTTD/dibridge/issues/255 23:48:27 <DorpsGek> [OpenTTD/dibridge] TrueBrain commented on issue #255: Latest version fails to start with: No module named 'audioop' https://github.com/OpenTTD/dibridge/issues/255 23:52:23 <DorpsGek> [OpenTTD/dibridge] poVoq commented on issue #255: Latest version fails to start with: No module named 'audioop' https://github.com/OpenTTD/dibridge/issues/255 23:54:48 <peter1138> Audio stuff, weird. 23:58:10 <DorpsGek> [OpenTTD/dibridge] LordAro commented on issue #255: Latest version fails to start with: No module named 'audioop' https://github.com/OpenTTD/dibridge/issues/255 23:58:43 *** jlx__ has quit IRC 23:59:23 *** jlx__ has joined #openttd 2024-12-10T072024-12-10T22:44:07 <andythenorth> I think block signals are a meta game