Times are UTC Toggle Colours
08:00:11 *** Belugas has quit IRC 08:03:06 *** Belugas has joined #openttd.dev 08:03:06 *** ChanServ sets mode: +v Belugas 08:24:56 *** Supercheese has quit IRC 13:33:57 *** MTs-iPad_ has joined #openttd.dev 13:34:41 *** MTs-iPad has quit IRC 15:09:03 *** Alberth has joined #openttd.dev 15:09:03 *** ChanServ sets mode: +v Alberth 16:55:46 *** frosch123 has joined #openttd.dev 16:55:46 *** ChanServ sets mode: +v frosch123 16:58:17 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r27026 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 17:20:39 *** Klanticus has joined #openttd.dev 17:48:02 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r27027 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:15:04 *** Alberth has quit IRC 18:31:52 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r27028 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:33:25 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r27029 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:45:57 <Rubidium> http://rbijker.net/openttd/ownernone_station_list_crash.diff <- initial issue was the crash for buoys (and probably oil rigs), but is spiralled a bit out of control. 18:46:42 <Rubidium> * why, on invalid owners of stations switch to the local company? It's a buoy or oil rig, for which you open the window/list with the owner of the station 18:47:15 <frosch123> the idea was, that when you select a buoy or oilrig, you see *your* vehicles in the vehicle list 18:47:18 <Rubidium> * why not allow OWNER_NONE as "window" owner? 18:47:40 <frosch123> we changed that intentionally to how it is now :p 18:47:52 <Rubidium> now it shows all, right? 18:49:59 <frosch123> what case is crashing now btw? 18:50:38 <Rubidium> make buoy, order ship to buoy, open buoy window and then buoy vehicle list, destroy buoy... wait... SIGSEGV 18:53:34 <frosch123> i think you patch reverts some of the old fixes 18:53:49 <Rubidium> "fixes" 18:53:55 <frosch123> the list should not show vehicles of different companies, otherwise send to depot fails 18:54:05 <frosch123> the window needs a owner, otherwise switch-company fails 18:54:13 <Rubidium> then the current behaviour is broken 18:54:41 <frosch123> what is the current behaviour? i expected it to show only *your* vehicles 18:54:46 <frosch123> that's also waht fs#5319 says 18:59:00 <Rubidium> http://rbijker.net/openttd/current.png 19:00:37 <Rubidium> for both station and waypoint the vehicle list is opened with the owner of the station/waypoint, thus with OWNER_NONE for oil rigs and buoys 19:01:03 <Rubidium> that's exactly what FS#5319 does; it shows ALL vehicles of waypoints 19:03:16 <frosch123> hmm, ok, i was dreaming, 1.3 does not do what i thought either 19:03:43 <frosch123> but then i wonder what was even the effect of that _local_company? 19:03:53 <frosch123> window captions were grey for me 19:04:35 <Rubidium> frosch123: the effect of _local_company is causing the bug 19:05:04 <frosch123> but what was it's original intention? 19:05:21 <Rubidium> probably to only show "your" vehicles 19:07:44 <frosch123> @commit 19956 19:07:44 <DorpsGek> frosch123: Commit by smatz :: r19956 /trunk/src (3 files) (2010-06-10 23:52:09 UTC) 19:07:45 <DorpsGek> frosch123: -Fix: close list of vehicles with given oil rig in orders when the oil rig is deleted 19:07:46 <DorpsGek> frosch123: -Fix (r19952): close the list when it is not sticky 19:09:26 <frosch123> hmm, so it was introduced to fix exactly the same bug? 19:10:29 <Rubidium> possibly the unification of waypoints and stations caused some issues 19:11:21 <Rubidium> by unifying the behaviour and such 19:11:35 <frosch123> well, the diff makes the code at least a lot easier :) 19:13:08 <Rubidium> hmm... should I split the patch into two... the widget change and the rest? 19:13:26 <Rubidium> backport wise one should definitely not forget the widget change when backporting the rest 19:13:52 <frosch123> the changes belong together, i would not split 19:14:07 <frosch123> the widget thingie is not used by something else, is it? 19:14:11 <frosch123> and vice versa 19:14:21 <Rubidium> not at the moment, but it could in the future 19:16:50 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r27030 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 19:34:02 *** IcyPalm has joined #openttd.dev 22:09:57 *** frosch123 has quit IRC 22:21:32 *** IcyPalm has quit IRC