Times are UTC Toggle Colours
00:16:39 *** remy^ has quit IRC 00:20:08 *** sim-al2 has quit IRC 00:21:53 *** Wormnest has quit IRC 00:30:34 *** triolus has joined #openttd 00:40:26 *** wodencafe has quit IRC 01:13:35 *** Wormnest has joined #openttd 01:30:31 *** Wormnest has quit IRC 02:00:30 *** Samu has quit IRC 02:30:16 *** yellyFish has quit IRC 02:40:19 *** triolus has quit IRC 02:54:34 *** cHawk has quit IRC 03:27:59 *** glx has quit IRC 04:40:39 *** Gustavo6046 has quit IRC 06:29:04 *** mindlesstux has quit IRC 06:46:47 *** nielsm has joined #openttd 07:00:12 *** andythenorth has joined #openttd 07:09:00 *** andythenorth has quit IRC 08:24:38 *** glavinics has joined #openttd 08:36:52 *** glavinics has quit IRC 09:01:10 *** glavinics has joined #openttd 09:19:37 *** APTX has quit IRC 09:22:48 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh approved pull request #6904: Add: AI/GS GetMonthlyMaintenanceCost https://git.io/fx5KZ 09:57:29 <nielsm> uhm, wtf is going on here? https://0x0.st/sIrk.png 09:57:48 <nielsm> an AI has managed to build two tiles that can't render 09:57:54 <Xaroth> The train's asleep. 09:57:57 <Xaroth> clearly. 09:58:47 <ST2> I can hear the driver snoring 09:59:08 <nielsm> and I get HoM effects like this when zooming in: https://0x0.st/sIrd.png 09:59:34 <nielsm> tiny rail depot driving out of a smaller rail depot, also driving out of a normal rail depot 10:01:11 <peter1138> Railtype issue? 10:01:29 <nielsm> this is vanilla, no newgrfs loaded 10:01:35 <peter1138> Yeah so? 10:02:00 <nielsm> I'm testing this: https://github.com/OpenTTD/OpenTTD/pull/6906 10:02:04 <peter1138> Some issue with the bit-shuffling I did, I wonder? 10:02:06 <nielsm> and neede a second player 10:02:22 <nielsm> yeah I suspect it might be something with the map array extensions done recently 10:02:25 <peter1138> Oh you're testing with a patch, not vanilla. 10:03:39 <nielsm> let's try it with the PR rebased onto current master 10:04:00 <nielsm> but well the map array is already broken in this save, of course... 10:06:06 *** matt21347 has joined #openttd 10:11:28 <nielsm> okay could dynamite those tiles just fine after using switch company cheat 10:16:41 <nielsm> just going to test the same AI on a non-patched build 10:18:16 <nielsm> yeah it keeps building broken stations 10:21:24 <nielsm> yep it looks like a bug in master 10:21:45 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh requested changes for pull request #6906: Fix #6742: Only possible to build station next to competitor by using CTRL+click https://git.io/fx51D 10:23:49 <peter1138> Is it a station tile or something else? 10:24:01 <nielsm> it's supposed to be railroad 10:24:38 <nielsm> with or without overhead wires 10:24:47 <nielsm> (the Zzz seems to be intended to be the wires) 10:29:13 <nielsm> yep same AI in 1.8.0 does not produce broken stations 10:31:30 <peter1138> Check which bits are set and what's being read for those tiles. Could be a write bug or a read bug. 10:36:47 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh opened issue #6951: AI builds impossible/broken tiles https://git.io/fx5D3 10:39:49 <peter1138> In theory it's possible for a player to do it too. Same commands. 11:11:47 <planetmaker> o/ 11:13:43 *** Gustavo6046 has joined #openttd 11:19:38 <nielsm> let's try out git bisect! 11:20:20 <nielsm> (and spend ages compiling and recompiling) 11:38:41 <peter1138> Why? It'll be one of two and it doesn't really matter. 11:40:16 <nielsm> found a state here where it doesn't build broken tiles, but it fails finding valid routes at all so it never builds 12:07:33 *** wodencafe has joined #openttd 12:51:55 *** wodencafe has quit IRC 13:05:09 <nielsm> sleepy refinery: https://0x0.st/sIsp.png 13:07:41 <LordAro> :D 13:07:49 <LordAro> narrowed it down yet? 13:08:06 <nielsm> not yet 13:09:17 <nielsm> however I just set a breakpoint in rail_cmd.cpp:484 (CmdBuildSingleRail first line inside if(flags & DC_EXEC)) and game screen looks like this when it breaked: https://0x0.st/sIsO.png 13:09:23 <nielsm> so somehow it's correct for a little bit? 13:17:32 <nielsm> huh no, it actually built this route without errors 13:27:30 <nielsm> it seems somehow m8 (railtype) gets set to 0x21 when there isn't any valid railtype with that value 13:29:36 <peter1138> So... railtype getting corrupted before writing to map, or something else modifying the map railtype later. 13:30:05 <nielsm> trying to set an assert in MakeRailNormal now 13:33:50 <nielsm> yep here is railtype==32 inside CmdBuildSingleRail 13:43:50 <nielsm> okay ScriptStorage::rail_type is set to 32 13:43:57 <nielsm> in the AI 13:45:00 <peter1138> CmdBuildSingleRail should fail if the railtype is invalid. 13:45:23 <peter1138> I guess I broke that check, or it was never there? 13:46:02 <nielsm> yeah 13:46:08 <nielsm> it's supposed to validate it 13:46:14 <nielsm> but somehow succeeds 13:47:35 <nielsm> hmm I think the logic here is wrong: https://0x0.st/sIsU.png 13:47:48 <nielsm> or...? 13:47:53 <nielsm> right no, it's correct 13:48:07 <nielsm> but some integer width issues 13:48:28 <nielsm> question is, why does it set railtype to something invalid 13:48:32 <nielsm> (the AI) 13:51:45 <peter1138> If it's testing for available railtypes, then maybe it also sees 32 as being valid. 14:06:09 <nielsm> looks like explicitly selecting the HasBit template parameter at least avoids the bug 14:06:09 <nielsm> HasBit<uint64>(Company::Get(company)->avail_railtypes, railtype); 14:10:04 <peter1138> o_O 14:10:29 <peter1138> I guess I never tested this. I did test > 32 but not all cases. Damn it. 14:10:39 <peter1138> May also be compiler specific I suppose. 14:10:56 <peter1138> Need to check any other railtype HasBit occurrence :/ 14:27:27 *** andythenorth has joined #openttd 14:27:31 *** andythenorth has left #openttd 14:43:37 *** TheMaster has joined #openttd 14:50:34 *** Unit193 has quit IRC 14:52:11 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on issue #6951: AI builds impossible/broken tiles https://git.io/fxdmb 14:55:24 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh opened pull request #6952: Fix #6951: Explicitly use uint64 when testing for available railtypes https://git.io/fxdY9 14:57:50 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh opened pull request #6953: Fix: Missing m8 data in console when using Query tool https://git.io/fxdOO 15:12:22 *** WWacko1976-work has quit IRC 15:13:59 *** Wormnest has joined #openttd 15:17:14 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #6952: Fix #6951: Explicitly use uint64 when testing for available railtypes https://git.io/fxdsR 15:25:59 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN approved pull request #6953: Fix: Missing m8 data in console when using Query tool https://git.io/fxdGo 15:33:16 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh merged pull request #6953: Fix: Missing m8 data in console when using Query tool https://git.io/fxdOO 15:35:19 <nielsm> any way to re-run the CI test that failed for non-code reasons? 15:35:41 <nielsm> (looks like it failed to connect to github or something) 15:36:10 <LordAro> not without TB 15:37:22 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #6952: Fix #6951: Explicitly use uint64 when testing for available railtypes https://git.io/fxdY9 15:37:31 <nielsm> maybe this works... rebased it on the new master and force pushed 15:38:22 <nielsm> eh 15:38:26 <nielsm> Error response from daemon: received unexpected HTTP status: 503 Service Unavailable 15:41:24 <peter1138> o_O 15:41:47 <peter1138> Can be rerequested within Jenkins too but I don't know who has logins on that. 15:42:37 *** frosch123 has joined #openttd 15:50:08 <LordAro> maybe jenkins is broke 16:03:42 <nielsm> well, it passed the other PR 16:10:00 <SpComb> jenkins issues eh 16:14:36 <frosch123> nielsm: what is the exact problem in 6952? integer promotion? 16:14:56 <nielsm> truncation 16:14:59 <frosch123> is there some way to change HasBit instead of changing how it is called in one place? 16:15:29 <nielsm> 64 bit railtypes bitfield gets truncated to 32 bit 16:15:37 <frosch123> like replacing the "(T)1U" with "1ull" or somezhing 16:15:44 <nielsm> might also work 16:19:59 <peter1138> That'd make it 64bit for everything, no? 16:20:21 <nielsm> yeah that would make every usage of it be 64 bit 16:20:26 <frosch123> yes 16:20:30 <nielsm> invoke 64 bit alu* 16:20:39 <frosch123> but what to do when enums are undefined 16:20:50 <frosch123> well, actually, we can also do c++1 enum classes :) 16:21:08 <frosch123> enum class RailtTypes : uint64 16:21:25 <nielsm> would def. prefer that :) 16:21:48 *** dvim has joined #openttd 16:22:35 <nielsm> though I do wonder why RailTypes is not treated as uint64 already when the enum does have a UINT64_MAX value 16:23:03 <frosch123> yes, i also wondered that 16:23:08 <peter1138> If that fixes it then that's the correct solution. And my mistake, missing it. 16:23:14 <peter1138> Well, my mistake whatever :p 16:23:27 <nielsm> might also depend on compiler, really 16:23:30 <peter1138> Maybe. 16:23:33 <nielsm> I should test it on my linux machine 16:27:08 <nielsm> no bug on linux with g++ 8.2.1 16:27:18 <nielsm> so it's a VC++ thing 16:29:17 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on issue #6951: AI builds impossible/broken tiles https://git.io/fxdRm 16:30:37 <nielsm> ah right, there's more locations using HasBit<> with Company::avail_railtypes 16:30:41 <nielsm> need to fix those too 16:31:04 <nielsm> not sure whether to change HasBit as frosch123 suggests 16:31:35 <frosch123> does the c++11 method work? 16:32:26 <frosch123> if it's a compiler bug, maybe (T)1ull fixes it :p 16:32:53 <frosch123> i think we had some msvc issues in the past, where it ignored types of function parameters when they were inlined 16:32:59 <frosch123> so casts got lost 16:33:00 <nielsm> it breaks DECLARE_ENUM_AS_BIT_SET(RailTypes) 16:33:06 <peter1138> enum RailTypes : uint64 16:33:12 <peter1138> Oh. 16:33:24 <nielsm> ah, enum class does not break it 16:33:28 <nielsm> wrong 16:33:45 <nielsm> enum class breaks it, enum RailTypes : uint64 seems to be acceptable 16:34:17 <frosch123> enum class adds namespace stuff, so many things need changing 16:34:21 <peter1138> "enum classes - enumerator names are local to the enum and their values do not implicitly convert to other types (like another enum or int)" 16:34:24 <peter1138> Yeah 16:34:32 <peter1138> Safer if you designed it that way from the start :-) 16:37:44 <nielsm> enum RailTypes : uint64 also does fix the bug, but I'm not sure if that's legal C++03 16:37:53 <LordAro> it's not 16:38:13 <peter1138> Does it need to be? 16:38:16 <frosch123> yes, it's not, but lordaro already added c++11 stuff in other places 16:38:32 <frosch123> so, ottd is no longer c++03 16:38:46 <LordAro> only one place... 16:38:55 <LordAro> and it could be easily removed :p 16:39:18 <frosch123> didn't you add tons of inline struct constructors? 16:39:21 <nielsm> so, which fix is it? change the two call sites, or change the enum type? 16:39:45 <frosch123> definitely change the num type 16:39:53 <frosch123> Railtypes is not the only 64bit enum we have 16:40:25 <frosch123> ok, CargoTypes is actually no enum 16:40:29 <frosch123> so maybe it is :p 16:40:45 <frosch123> but still, having to touch every place just ask for more issues 16:41:43 <peter1138> CargoTypes is a bit weird. 16:42:00 <peter1138> It feels like it should be an enum, but there's already a separate type for it. 16:42:40 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #6952: Fix #6951: Explicitly use uint64 when testing for available railtypes https://git.io/fxdY9 16:42:50 <nielsm> there, changed i t 16:43:04 <nielsm> maybe jenkins will succeed this time too 16:43:48 <frosch123> the comment is in the wrong place 16:43:54 <nielsm> oops 16:44:07 <peter1138> It was "easier" when I did it with std::bitmask. 16:44:17 <peter1138> All the HasBits and stuff had to go. 16:45:27 <peter1138> Hmm, don't think these overshoes are going to last long, they're very tight :/ 16:46:15 <nielsm> let's try that again 16:46:17 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #6952: Fix #6951: Explicitly use uint64 when testing for available railtypes https://git.io/fxdY9 16:46:41 <peter1138> I had some bigger ones once but the ankle part was way too big. 16:50:17 <peter1138> LordAro, gotta love the clock change for suddenly requiring lots of lights :/ 17:00:58 <LordAro> ikr 17:01:12 <LordAro> peter1138: nice ride the other day btw, much impressive 17:29:34 *** yellyFish has joined #openttd 17:46:28 <LordAro> nielsm: have you tried with another version of VS, ooi? might be 2015 specific 17:52:08 <nielsm> I don't have any other versions at hand right now 18:33:52 *** andythenorth has joined #openttd 18:34:17 <andythenorth> o/ 18:41:30 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #6946: Doc: More notes for developers adding new PerformanceElements https://git.io/fxHY1 18:50:26 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #6946: Doc: More notes for developers adding new PerformanceElements https://git.io/fxHY1 18:51:24 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #6946: Doc: More notes for developers adding new PerformanceElements https://git.io/fxdS6 18:52:53 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #6948: Doxygen improvements and various scan-build findings https://git.io/fxdSD 19:09:29 *** Progman has joined #openttd 19:31:02 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #6754: Don't automatically deactivate the vehicle clone tool after cloning a vehicle https://git.io/vp8bd 19:31:17 <nielsm> I did it 19:31:23 <nielsm> I pushed to someone else's branch 19:31:27 <nielsm> on purpose! 19:32:07 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #6754: Don't automatically deactivate the vehicle clone tool after cloning a vehicle https://git.io/fxd5n 19:32:35 <LordAro> :o 19:44:14 <DorpsGek_II> [OpenTTD/OpenTTD] Hemaolle updated pull request #6906: Fix #6742: Only possible to build station next to competitor by using CTRL+click https://git.io/fxddd 19:46:21 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh approved pull request #6906: Fix #6742: Only possible to build station next to competitor by using CTRL+click https://git.io/fxddj 19:48:57 <DorpsGek_II> [OpenTTD/OpenTTD] Hemaolle commented on pull request #6906: Fix #6742: Only possible to build station next to competitor by using CTRL+click https://git.io/fxdF8 19:53:28 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #6948: Doxygen improvements and various scan-build findings https://git.io/fxdFQ 19:54:55 <DorpsGek_II> [OpenTTD/OpenTTD] michicc approved pull request #6754: Don't automatically deactivate the vehicle clone tool after cloning a vehicle https://git.io/fxdFj 19:56:15 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #6948: Doxygen improvements and various scan-build findings https://git.io/fxdbk 19:56:59 <DorpsGek_II> [OpenTTD/OpenTTD] alexanderweiss commented on pull request #6754: Don't automatically deactivate the vehicle clone tool after cloning a vehicle https://git.io/fxdbY 19:57:22 <LordAro> LOUD NOISES 19:58:02 *** glx has joined #openttd 19:58:02 *** ChanServ sets mode: +v glx 19:58:25 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh dismissed a review for pull request #6754: Don't automatically deactivate the vehicle clone tool after cloning a vehicle https://git.io/fxdbR 20:01:44 <yellyFish> does anyone now where i can find NARS 2.51 source code? i would like to examine why is it making so many calls to var 0x61 even though it is not implemented 20:06:24 *** Wolf01 has joined #openttd 20:06:56 <Wolf01> o/ 20:07:21 <andythenorth> much flooded Wolf01 ? 20:07:25 <Wolf01> Yes 20:07:33 <andythenorth> yellyFish: just decompile it 20:09:09 <nielsm> looks like Pikka doesn't release the source for his things 20:10:16 <andythenorth> it might be in forums somewhere 20:10:23 <andythenorth> but I just decompile it 20:10:29 <andythenorth> but then it's uncommented nfo :P 20:10:50 <andythenorth> dunno if grf2html still works :P https://dev.openttdcoop.org/projects/grf2html 20:12:29 <Wolf01> http://messaggeroveneto.gelocal.it/udine/cronaca/2018/10/29/news/tagliamento-minaccioso-a-latisana-notte-d-ansia-in-attesa-della-maxi-piena-1.17404761 there are some albums if you want to see some photos :P 20:14:49 <andythenorth> oof 20:18:26 *** glavinics has quit IRC 20:18:34 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro updated pull request #6948: Doxygen improvements and various scan-build findings https://git.io/fxHhE 20:18:55 * andythenorth can't keep up with the pull requests :P 20:18:57 <andythenorth> so much 20:19:28 <yellyFish> that means that some work is getting done :D 20:19:38 <LordAro> andy prefers dead 20:20:55 <DorpsGek_II> [OpenTTD/OpenTTD] michicc approved pull request #6952: Fix #6951: Ensure RailTypes bitfield is always treated as 64 bit https://git.io/fxdAd 20:21:29 <Wolf01> http://messaggeroveneto.gelocal.it/polopoly_fs/1.17407729.1540901425!/httpImage/image.JPG_gen/derivatives/gallery_978/image.JPG <- on the top right there is my town 20:22:28 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro opened pull request #6954: Doxygen update and warning fixes https://git.io/fxdxf 20:22:38 <nielsm> did someone spill a train full of milk into the river? 20:22:54 <Wolf01> Yep, chocolate milk 20:24:06 <yellyFish> wow. valgrind + kcachegrind is p cool. it show all calls with source code and even assembly, not like i understand all of it tho :D 20:25:37 <Wolf01> This time it was the worst flood since I remember, luckily the wind changed so the sea was able to receive, or I wouldn't be here to tell it but in the cellar to drain the water 20:26:04 <LordAro> Wolf01: doesn't look so bad from that picture, it's not burst its banks yet :p 20:26:07 <yellyFish> Wolf01: does that river ever spill over? 20:26:10 <LordAro> York floods almost every year 20:26:35 <Wolf01> We raised and reinforced the banks :P 20:26:38 <yellyFish> nvm. 20:27:05 <Wolf01> It spilled over on the town at the left like 40 years ago 20:27:36 <yellyFish> time to deepen the river bank or something 20:28:05 <yellyFish> where i live there is also a main river that got flooded years ago 20:28:12 <Wolf01> Nah, we are near the sea, the only hope is the low tide 20:28:37 <yellyFish> or move the town ;^) 20:29:26 <yellyFish> nature really doesn't give a F about where we set houses 20:31:25 <LordAro> "look at this lovely flat land near the river, that's excellent for building houses on" 20:31:32 <LordAro> "what do you mean it's only flat because it floods a lot?" 20:32:09 <yellyFish> ChadBeaver vs VirginEnginner 20:32:16 <Wolf01> :D 20:32:28 <yellyFish> Engineer* 20:32:40 <Wolf01> Wasn't ChuckBeaver? 20:33:03 <yellyFish> lol 20:33:12 *** Happpy has joined #openttd 20:33:22 *** Happpy has left #openttd 20:34:52 <yellyFish> The future is gonna be like Waterworld lol 20:35:22 <Wolf01> You mean like Venice? 20:41:07 <nielsm> I chuckled: https://0x0.st/sI-D.png 20:41:54 <yellyFish> do we have animals in the game? 20:42:09 <LordAro> nielsm: ikr :) 20:42:24 <yellyFish> maybe add some monkeys hanging from trees in jungles 20:42:44 <nielsm> well there is the NUTS train set 20:42:56 <nielsm> and some sets have horse-drawn carriages? 20:42:59 <nielsm> :) 20:43:11 <yellyFish> lol 20:43:40 <nielsm> (play a game with NUTS if you haven't) 20:45:28 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #6954: Doxygen update and warning fixes https://git.io/fxFeA 20:46:31 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh merged pull request #6952: Fix #6951: Ensure RailTypes bitfield is always treated as 64 bit https://git.io/fxdY9 20:46:37 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh closed issue #6951: AI builds impossible/broken tiles https://git.io/fx5D3 20:52:25 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #6954: Doxygen update and warning fixes https://git.io/fxFvr 20:54:53 <LordAro> interestingly, the doxygen docs only mention "[in,out]", not "[inout]" 20:55:15 <nielsm> whichever works :P 20:55:25 <LordAro> i don't know, i didn't check :p 20:55:49 <LordAro> guess i should :p 20:56:29 <LordAro> seems inout works just fine 20:56:47 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #6954: Doxygen update and warning fixes https://git.io/fxFfU 20:57:47 * LordAro finds some parameters to fix 21:00:37 <frosch123> i have only seen "in, out" 21:01:30 <LordAro> there are actually slightly more results for [in,out] 21:01:51 <LordAro> but it's 11 to 8 :p 21:02:42 <LordAro> i can standardise, if you like 21:08:04 <LordAro> it's also 43 to 67 for "@param [..]" vs "@param[..]" 21:08:05 <LordAro> :p 21:09:43 <frosch123> i think one of my editors only properly colored @param[] 21:09:55 <LordAro> i prefer that style too 21:10:11 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro updated pull request #6954: Doxygen update and warning fixes https://git.io/fxdxf 21:14:38 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro updated pull request #6954: Doxygen update and warning fixes https://git.io/fxdxf 21:18:31 <andythenorth> oof 21:18:36 <andythenorth> so close to 80% done on Horse 21:19:09 *** Wolf01 is now known as Guest1828 21:19:11 *** Wolf01 has joined #openttd 21:19:24 *** Guest1828 has quit IRC 21:21:25 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro updated pull request #6954: Doxygen update and warning fixes https://git.io/fxdxf 21:21:28 <LordAro> ...i went ahead and "fixed" all of them 21:32:53 <andythenorth> :D 21:33:00 <andythenorth> hmm 21:33:10 <andythenorth> am I still using LordAro's fork of OpenTTD? :P 21:33:16 <andythenorth> with configure flags? 21:33:18 <andythenorth> yes I am :P 21:34:52 <LordAro> ono 21:35:31 <yellyFish> what's standard way of writing multi line comma separated fields? commas end of line or at the start? 21:36:45 <LordAro> commas at the start of the line is for broken people 21:37:11 <yellyFish> D: i write it like that in haskell but don't how it is in C++ 21:37:30 <LordAro> i know what i said :p 21:37:53 <LordAro> it is quite common is haskell, and basically nowhere else 21:38:22 <yellyFish> it looks nice tho 21:39:11 <nielsm> I write multiline initializer lists in C++ constructors with commas (and the initial colon) aligned at the start of lines 21:40:10 <LordAro> ono 21:41:12 <nielsm> https://github.com/Aegisub/Aegisub/blob/master/src/audio_display.cpp#L546-L550 21:42:11 <yellyFish> but the indentation D: 21:44:20 <frosch123> it is common for the same reason as why you put a comma also for the last value of an enum 21:44:39 <frosch123> to be able to extend/insert stuff without having to change another line by adding/removing a cmoma 21:45:27 <frosch123> ottd probably does not have a style for that though, too little c++ :p 21:55:16 <andythenorth> 171 trains drawn, 44 not drawn 21:55:18 <andythenorth> such stats 21:55:49 <andythenorth> done by Christmas? 21:56:10 <peter1138> nielsm, thanks for sorting that issue out earlier. 21:56:20 <peter1138> Nice that it wasn't the map array being wrong though :D 21:58:41 <nielsm> the other instance of avail_railtypes being checked with HasBit was in the UI building the build railroad button dropdown 21:59:19 <nielsm> it might have caused problems down the road if someone managed to load newgrfs getting over 32 railtypes 21:59:42 <nielsm> even if I wouldn't want to see the menu that long 22:02:00 *** andythenorth has quit IRC 22:03:16 *** andythenorth has joined #openttd 22:07:56 <peter1138> I've seen it full ;) 22:08:07 <andythenorth> hmm 22:08:18 <peter1138> It gets to the point where the UI enhancements would be useful. 22:08:19 <andythenorth> I have between 1 and 3 sizes for each wagon 22:08:37 <andythenorth> so they have, e.g. 'Flat Car (Small)' suffixes 22:08:44 <peter1138> Ok? 22:08:46 <andythenorth> 'Flat Car (Medium)' 22:08:47 <andythenorth> etc 22:08:56 <andythenorth> what about when there's only one? 22:09:01 <andythenorth> is that small, medium, or large? 22:09:05 <andythenorth> or drop the suffix? 22:09:09 <andythenorth> kind of odd 22:09:21 <andythenorth> it's all obviously a BAD FEATURE, but that's a given 22:11:01 <andythenorth> nah I don't know either 22:11:10 <andythenorth> I just leave it as 'small' when there's only one :P 22:12:27 <andythenorth> maybe 'small', 'medium', 'large' are stupid 22:12:40 <andythenorth> what about 'Flat Car (20t)', 'Flat Car (30t)', 'Flat Car (40t)'? 22:12:45 <andythenorth> oh, units though :( 22:18:12 <andythenorth> nvm :) 22:18:13 <andythenorth> bed 22:18:14 *** andythenorth has left #openttd 22:19:16 <nielsm> ugh, wanted to try fluidsynth on windows, and their build system really gets in the way 22:19:34 <nielsm> cmake, and somehow it fails with a "could not find C compiler" error 22:19:46 <LordAro> heh 22:20:05 <nielsm> (when being told to output projects for visual studio, in which you do not specify the path to your compiler) 22:24:36 *** Wormnest has quit IRC 22:48:40 *** nielsm has quit IRC 22:59:01 *** matt21347 has quit IRC 23:00:56 *** Wolf01 has quit IRC 23:25:14 *** Progman has quit IRC 23:40:21 *** Laedek has quit IRC 23:44:57 *** NGC3982 has quit IRC 23:46:57 *** frosch123 has quit IRC