Times are UTC Toggle Colours
00:00:05 *** Thedarkb2-T60 has quit IRC 00:00:16 *** Thedarkb2-T60 has joined #openttd 00:00:41 *** Thedarkb-X40 has joined #openttd 00:17:41 *** wodencafe has joined #openttd 00:19:39 *** Wolf01 has quit IRC 00:22:16 <Samu> Authentication failed. You may not have permission to access the repository 00:22:32 <Samu> can't push to someone's repository? 00:23:14 <Samu> can i fork forks? 00:24:02 <Samu> how do i make a fork of someone's into my own fork? 00:24:10 <Samu> in a branch that is 00:24:15 <Samu> bah i fail at explaining 00:24:47 <peter1138> Add their fork as a remote, then checkout the branch. 00:26:36 <Samu> no comprendo 00:28:05 <Samu> i created a repository of nielsm on my system, but when i try to push stuff to it, i get authentication failed 00:28:09 <Samu> no permission bla bla 00:28:34 <peter1138> yes you need to push to your own repo 00:29:06 <Samu> hmm but it's on my system? this is so confusing 00:29:15 <Samu> how to push it to mine then? 00:31:13 *** Progman has quit IRC 00:31:15 <milek7> https://help.github.com/articles/adding-a-remote/ 00:34:57 <milek7> (you could do either way, add somebody fork as remote to your repo dir, or add your remote and push to it in somebody repo dir) 00:38:05 <Samu> i miss svn patches 00:38:10 <Samu> it was so much simple 00:39:28 <Samu> gonna copy paste nielsm openttd files into mine 00:39:33 <Samu> should do what i want 00:39:40 <Samu> then i just have to create a branch 00:39:57 <peter1138> Ew 00:40:08 <peter1138> adding a remote is very simple. 00:40:53 <Samu> ok, hope i dont ruin my own git bash here 00:41:43 <Samu> do i git bash nielsm's or mine? 00:41:49 <Samu> git bash here 00:42:01 <Samu> before doing the remote 00:42:26 <peter1138> you only need one. 00:42:30 <peter1138> use the one you normally work in 00:45:53 <Samu> git remote add origin https://github.com/nielsmh/OpenTTD.git 00:45:56 <Samu> like this? 00:46:05 <peter1138> not quite 00:46:16 <peter1138> replace "origin" with some other identifier 00:46:30 <peter1138> that is your name for the remote 00:46:40 <peter1138> git remote add nielsm ... would make sense 00:47:30 <Samu> but the branches, am i gonna get all his crap on mine? :( 00:47:42 <Samu> im only interested in ship-depot-pathfinding 00:48:02 <peter1138> you only get what you checkout 00:49:14 <Samu> git remote add nielsmh https://github.com/nielsmh/OpenTTD.git 00:51:20 <Samu> i dont know what's a checkout 00:51:26 <Samu> sec 00:51:39 *** HerzogDeXtEr has quit IRC 00:51:51 <Samu> https://imgur.com/TdYpu2L 00:51:55 <Samu> does this look good? 00:52:05 <peter1138> git fetch nielsmh 00:52:33 <peter1138> git checkout nielsmh/whatever 00:59:17 <Samu> Failed to delete the branch from the remote repository. See the Output window for more details. 00:59:30 <Samu> was trying to delete the branches i'm not interested in 00:59:40 <peter1138> you can't, they're his branches 01:02:51 <Samu> remote: Permission to nielsmh/OpenTTD.git denied to SamuXarick. 01:02:51 <Samu> fatal: unable to access 'https://github.com/nielsmh/OpenTTD.git/': The requested URL returned error: 403 01:02:59 <Samu> i fail at this 01:04:02 <Samu> isn't it on my repository now? 01:04:19 <Samu> what was the point of git remote add then, :| 01:04:46 <glx> the remote is to get the data on your local copy 01:05:31 <milek7> you need to explictly push branch to your remote 01:08:46 <Samu> right click, New Local Branch From... ? 01:08:49 <Samu> gonna try 01:09:31 <Samu> A branch with the name "ship-depot-pathfinding" already exists. 01:10:19 <milek7> git push origin 01:10:30 <milek7> if origin is your own remote 01:12:39 <Samu> $ git push --force 01:12:39 <Samu> fatal: The current branch ship-depot-pathfinding2 has no upstream branch. 01:12:39 <Samu> To push the current branch and set the remote as upstream, use 01:12:39 <Samu> git push --set-upstream origin ship-depot-pathfinding2 01:13:40 <milek7> do it 01:17:25 <Samu> does this look ok? https://imgur.com/kdHeqEE 01:21:49 <Samu> https://github.com/SamuXarick/OpenTTD/tree/ship-depot-pathfinding2 01:21:50 <Samu> aha 01:21:56 <Samu> it's my branch 01:22:03 <Samu> i can edit stuff in it now 01:22:06 <Samu> thx 01:25:39 <peter1138> You don't need to push it to github to edit it locally, of course 01:29:19 *** snail_UES_ has joined #openttd 01:57:39 *** Speedy` has quit IRC 02:00:25 *** Speedy` has joined #openttd 02:02:54 <Samu> error C2440: 'initializing': cannot convert from 'FindDepotData' to 'const Depot *' 02:03:12 <Samu> can't combine nielsmh code with mine 02:03:15 <Samu> bah 02:07:27 <Samu> how do I "convert" 02:28:11 <Samu> const Depot *depot = (const Depot *)GetDepotIndex(FindClosestShipDepot(v, 0, &failed_depots).tile); 02:37:02 <Samu> nope, doesn't work 02:37:52 *** snail_UES_ has quit IRC 02:41:42 <Samu> const Depot *depot = Depot::GetByTile(FindClosestShipDepot(v, 0, &failed_depots).tile); 02:49:05 *** glx has quit IRC 02:57:20 <Samu> how do I delete the remote now? 02:57:25 <Samu> no longer need it 03:00:45 <Samu> https://help.github.com/articles/removing-a-remote/ 03:02:27 <Samu> aha, it's gone, thx 03:13:54 *** snail_UES_ has joined #openttd 03:14:49 *** Thedarkb-X40 has quit IRC 03:56:44 *** debdog has joined #openttd 04:00:07 *** D-HUND has quit IRC 04:30:52 *** snail_UES_ has quit IRC 04:40:56 <Samu> https://imgur.com/1YTH4t7 04:40:59 <Samu> :) 04:53:25 *** snail_UES_ has joined #openttd 04:56:24 *** Samu has quit IRC 05:00:33 *** snail_UES_ has quit IRC 05:53:10 *** HerzogDeXtEr has joined #openttd 07:50:16 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7072: Change: Add path cache for ships https://git.io/fh0Yl 07:50:17 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #7072: Change: Add path cache for ships https://git.io/fh03F 07:50:57 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7072: Change: Add path cache for ships https://git.io/fhEPu 08:12:29 *** nielsm has joined #openttd 08:13:39 *** andythenorth has joined #openttd 08:13:43 <andythenorth> o/ 08:16:07 <nielsm> morning 08:17:29 *** sla_ro|master has joined #openttd 08:21:33 <peter1138> Hi 08:22:54 <andythenorth> so shall I use duck tape? 08:22:59 <peter1138> Yes. 08:23:00 <andythenorth> or shall I stop doing python wrong? 08:23:09 <peter1138> Time to get ready for bike ride. 08:23:36 * andythenorth testing some random ship patch 08:27:42 <andythenorth> so does it cache dir until the next project turn point? 08:27:46 * andythenorth didn't read the code 08:28:03 <andythenorth> I'm just bulldozing tiles in front of hovercraft to see how it reacts 08:30:19 <peter1138> No, it caches up to 32 tiles. 08:32:25 <peter1138> I just drank a soft drink with 145 kcal in it o_O 08:33:15 <peter1138> Should give me a boost for starting the ride at least, until I crash have way through. 08:33:20 <andythenorth> :P 08:38:42 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #7072: Change: Add path cache for ships https://git.io/fhEXF 08:39:30 <andythenorth> so....manually refactor 75 .py files? 08:39:38 <andythenorth> to do things correctly 08:39:51 <andythenorth> or plaster some more @property methods into a single module? 08:40:19 *** Wolf01 has joined #openttd 08:40:22 <andythenorth> I think we know the answer :( 08:40:28 <Wolf01> o/ 08:46:27 <peter1138> andythenorth, oh, and michi_cc already approved it but I decided to fix some comments ;p 08:46:39 <andythenorth> ok 08:47:03 <andythenorth> so is deleting OPF next? :P 08:47:44 <peter1138> :D 08:47:48 <peter1138> I'm off, see you. 08:49:45 <andythenorth> @seen alberth 08:49:45 <DorpsGek> andythenorth: alberth was last seen in #openttd 2 days, 13 hours, 4 minutes, and 1 second ago: <Alberth> o/ 08:55:33 *** Progman has joined #openttd 09:07:47 <TrueBrain> that moment that the Azure Pipelines changelog says something is changed, but it isn't .. hmmm 09:08:37 <andythenorth> yo TrueBrain 09:09:44 <TrueBrain> hi 09:10:17 <andythenorth> today might be tax return filing day 09:10:20 <andythenorth> such glamour 09:10:58 <TrueBrain> \o/ 09:11:08 <TrueBrain> hmm .. more changes from that changelog are not available .. so .. how do I know when it is .. hmm 09:13:27 <TrueBrain> "These features will roll out over the next two to three weeks." 09:13:33 <TrueBrain> so yeah .. that is a useless changelog :D 09:13:44 <andythenorth> :| 09:14:00 <TrueBrain> one of the improvements is that GitHub will deny any Pull Request to work, I think :P 09:14:04 <TrueBrain> so that will be interesting :D 09:20:24 <TrueBrain> meh; wanted to work to publish a nightly ... but I need orudge again to press a button :( 09:20:28 <TrueBrain> annoying Marketplaces 09:28:29 *** tokai has joined #openttd 09:28:29 *** ChanServ sets mode: +v tokai 09:31:24 <andythenorth> oof I already wrapped 50% of these files in main() :P 09:31:37 * andythenorth rediscovers previous mistakes 09:31:47 <TrueBrain> :D History tends to repeat itself 09:31:57 <andythenorth> I should have fixed 100% of them last time :P 09:35:14 *** tokai|noir has quit IRC 09:38:53 <TrueBrain> so why didnt you? :P 09:47:28 <TrueBrain> meh; guess that means I should solve the 2 remaining items for the website 09:47:29 <TrueBrain> bah :P 09:59:34 <andythenorth> oof 09:59:46 <andythenorth> also can we close some issues? :P 09:59:49 <andythenorth> and maybe some PRs 10:08:36 <DorpsGek_II> [OpenTTD/OpenTTD] michicc approved pull request #7072: Change: Add path cache for ships https://git.io/fhEyL 10:09:46 <andythenorth> \o/ 10:10:10 * andythenorth has fewer python modules doing magic on import 10:10:14 <andythenorth> probably better 10:11:16 <andythenorth> meh, doesn't actually fix my problem :P 10:11:33 <LordAro> moin 10:12:56 <nielsm> nice! got timing to work in my reworked ttd dos music player (that drives the original driver code) 10:14:09 <andythenorth> :) 10:15:52 <Wolf01> https://www.commitstrip.com/wp-content/uploads/2019/01/Strip-Daily-meeting-english650-finalV2.jpg totally what is ottd now :P 10:16:27 <andythenorth> except there's no risk committee 10:16:44 <andythenorth> we should totally get one 10:31:06 <andythenorth> TrueBrain: think I'm closing these, unless you say not https://github.com/OpenTTD/OpenTTD/pull/7071 https://github.com/OpenTTD/OpenTTD/pull/7070 10:31:28 <DorpsGek_II> [OpenTTD/website] TrueBrain commented on issue #10: Auto-detect most likely download https://git.io/fhEyh 10:31:52 <TrueBrain> andythenorth: something for frosch to judge; I have no clue what the state of the PFs are 10:31:58 <andythenorth> k 10:32:03 <andythenorth> I'll wait 10:32:39 <nielsm> imo OPF should be "as close to original behaviour as possible, warts and all" 10:32:46 <nielsm> and the new ones can be extended and improved 10:33:00 <TrueBrain> one more dev to agree, and close them up :) 10:33:05 <TrueBrain> so LordAro, you agree? :P 10:33:48 <LordAro> probably, yes 10:33:57 <LordAro> i'd be tempted to remove OPF entirely, tbh 10:34:02 <andythenorth> so is peter 10:34:14 <andythenorth> I think we should bonfire a few things 10:34:17 <andythenorth> not everything 10:34:20 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7070: Feature: Forbid 90 degrees for OPF https://git.io/fhESU 10:34:39 <LordAro> andythenorth: like aircraft 10:34:42 <LordAro> no one uses them 10:34:47 <andythenorth> well 10:34:52 <andythenorth> maybe in your patchpack :P 10:34:54 <TrueBrain> so close them up andythenorth 10:35:06 <TrueBrain> clearly this is the new rule now :) 10:35:56 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed pull request #7071: Change: Make OPF check reverse only when exiting depot https://git.io/fhRNP 10:35:57 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #7071: Change: Make OPF check reverse only when exiting depot https://git.io/fhESL 10:36:00 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #7070: Feature: Forbid 90 degrees for OPF https://git.io/fhESt 10:36:01 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed pull request #7070: Feature: Forbid 90 degrees for OPF https://git.io/fhRwt 10:36:18 <andythenorth> LordAro: mergy mcmergeface? https://github.com/OpenTTD/OpenTTD/pull/7072 10:36:36 <LordAro> i feel coerced 10:36:50 <LordAro> but once i've looked at it, sure :P 10:37:02 <andythenorth> TrueBrain: do we have a sufficient GDPR declaration for UA parsing? 10:37:05 <andythenorth> should I read it? 10:37:08 <nielsm> andythenorth, copying my comments! INFRINGEMENT!!! 10:37:13 <nielsm> ;) 10:37:25 <TrueBrain> GDPR for UA parsing .. that is a first :P 10:37:30 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7072: Change: Add path cache for ships https://git.io/fhESO 10:37:44 <TrueBrain> are we a data processor now? :D 10:37:49 <andythenorth> we're a controler 10:37:53 <andythenorth> controller * 10:38:07 <TrueBrain> anyway, fully client-side 10:38:07 <andythenorth> UA parsing is a proper issue, possibly more so than cookies 10:38:19 <andythenorth> anyway, I read privacy policy, I think we're ok 10:38:29 <andythenorth> legitimate purpose, already declared 10:38:34 <TrueBrain> it is fully client-side; so are we the controller? :) 10:38:41 <andythenorth> we're causing it to happen 10:38:47 <TrueBrain> what to happen? 10:38:52 <andythenorth> processing 10:38:57 <andythenorth> blah blah no case law 10:39:05 <nielsm> but not collecting 10:39:08 <TrueBrain> this is really stretching the idea of GDPR :P 10:39:11 <andythenorth> yeah ok, client side risk is tin foil 10:39:15 <TrueBrain> like .. realllllyyyyyy stretching :D 10:39:26 <andythenorth> but we know what binary we served them? 10:39:30 <nielsm> as far as I know, if the data (or a derivative of it) is not being collected it's not an issue 10:39:32 <andythenorth> so we can deduce the result of UA 10:39:44 <andythenorth> so we can infer personal details in combination 10:39:51 <TrueBrain> nooooo? 10:39:54 <andythenorth> ok 10:39:56 <andythenorth> tinfoil even over 10:39:58 <andythenorth> event * 10:39:59 <TrueBrain> you smoking too much paranoia today? :P 10:40:07 <andythenorth> no just checking 10:40:12 <nielsm> https://0x0.st/shIc.webm it works! 10:40:17 <TrueBrain> yes, we store how often which binary is downloaded 10:40:23 <TrueBrain> but we only count 10:40:25 <TrueBrain> so .. yeah .. no 10:40:32 <andythenorth> no IP addresses in logs? 10:40:35 <TrueBrain> in logs, sure 10:40:41 <TrueBrain> but that is a completely different thing 10:40:46 <andythenorth> onwards! 10:40:56 <TrueBrain> we store logs for debugging purposes for a very limited amount of time 10:41:07 <andythenorth> there's a specific recital in GDPR for that 10:41:29 <andythenorth> 2018 about 30% of my time was spent in GFDPR :P 10:41:37 <andythenorth> the F is not a typo 10:41:39 <TrueBrain> you are not alone, no worries :) 10:42:24 <andythenorth> at the end of that work, zero had changed about the data we process or control, but there was a lot of papework completed :P 10:42:41 <andythenorth> i.e. we weren't doing anything we shouldn't, but lots of trees died 10:43:34 <TrueBrain> I think it is really good companies took a good look internally how they process data 10:43:42 <TrueBrain> we took it too much for granted we could do what-ever-the-fuck-we-wanted with data 10:43:57 <TrueBrain> I have seen many companies that had no way to scrub data 10:44:01 <TrueBrain> or had no retention 10:44:05 <TrueBrain> and all that kind of shit 10:44:19 <TrueBrain> (like seriously .. they had customers that left their company 10 years ago still on record) 10:44:44 <TrueBrain> "but if they come back we still have their data" .. yeah .. exactly 10:45:17 <DorpsGek_II> [OpenTTD/website] TrueBrain opened pull request #20: Add: detect based on User-Agent which download the user wants most likely https://git.io/fhESC 10:47:02 <DorpsGek_II> [OpenTTD/website] TrueBrain opened issue #21: Staging doesn't support IPv6 https://git.io/fhESR 10:49:54 <TrueBrain> guess the rest of my day will be SysOp'ing to fix IPv6 and server-listing .. 10:49:56 <TrueBrain> ALMOST there 10:50:32 <LordAro> hype 10:51:36 <TrueBrain> just that the IPv6 issue is kinda annoying to fix :D 10:52:12 <TrueBrain> IPv4 is served via a LoadBalancer, and downloads will be edge-cached via a CDN 10:52:26 <andythenorth> interesting https://github.com/OpenTTD/OpenTTD/pulls?utf8=%E2%9C%93&q=is%3Apr+review%3Aapproved+is%3Aopen 10:52:26 <TrueBrain> and IPv6? It will enter a single machine, that forwards to the IPv4 infrastructure :P 10:52:47 <LordAro> that's not great 10:53:33 <TrueBrain> I have no other idea how to solve it currently :) 10:53:42 <TrueBrain> our current IPv6 is the same btw, as is our current IPv4 10:53:51 <TrueBrain> so I guess I am improving 90% of the visits :P 10:53:55 <TrueBrain> and I should not worry about the 10% :D 11:03:32 <DorpsGek_II> [OpenTTD/website] andythenorth approved pull request #20: Add: detect based on User-Agent which download the user wants most likely https://git.io/fhES9 11:04:16 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7072: Change: Add path cache for ships https://git.io/fhESH 11:16:06 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7072: Change: Add path cache for ships https://git.io/fhE93 11:18:25 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7072: Change: Add path cache for ships https://git.io/fhE9n 11:19:45 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7072: Change: Add path cache for ships https://git.io/fhE9u 11:24:08 *** Arveen2 has joined #openttd 11:27:42 <nielsm> nice, my silly toy also works with other music drivers (e.g. general midi/mpu-401 one) and TTO 11:29:09 *** Arveen has quit IRC 12:11:22 <TrueBrain> tnx orudge` 12:15:13 <DorpsGek_II> [OpenTTD/website] TrueBrain merged pull request #20: Add: detect based on User-Agent which download the user wants most likely https://git.io/fhESC 12:15:14 <DorpsGek_II> [OpenTTD/website] TrueBrain closed issue #10: Auto-detect most likely download https://git.io/fhOML 12:15:14 * andythenorth wonders about drawing a tech tree with graphviz 12:15:37 <andythenorth> based on the 'role' here http://bundles.openttdcoop.org/iron-horse/push/LATEST/docs/html/trains.html 12:17:54 <TrueBrain> that moment you are being asked for a code that will be emailed to you, but that ends up in greylisting 12:17:58 <TrueBrain> "account security" 12:17:59 <TrueBrain> ugh 12:18:02 *** frosch123 has joined #openttd 12:19:21 <TrueBrain> morning frosch123 12:19:44 <frosch123> hoi 12:19:53 <frosch123> i converted the eints repo 12:20:21 <frosch123> not sure what to call the repository on github: eints, webtranslator, WebTranslator? 12:20:42 <TrueBrain> its eints, not? 12:20:47 <TrueBrain> I am fine with what-ever btw :) 12:23:33 <milek7> greylisting should die 12:25:48 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7072: Change: Add path cache for ships https://git.io/fhEHA 12:26:17 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7072: Change: Add path cache for ships https://git.io/fhEHp 12:28:16 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7072: Change: Add path cache for ships https://git.io/fhEQU 12:30:16 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7072: Change: Add path cache for ships https://git.io/fhEQk 12:30:24 <peter1138> Oops, spam. 12:30:53 <LordAro> there's no way around it, when replying to individual review comments 12:30:53 <TrueBrain> https://openttd.ams3.cdn.digitaloceanspaces.com/openttd-nightlies/20190118-master-g07a40df9/changelog.txt 12:30:57 <LordAro> peter1138: how was cycling? 12:31:02 <TrueBrain> slowly getting there .. 12:32:41 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7072: Change: Add path cache for ships https://git.io/fhEQq 12:33:20 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh merged pull request #6990: Fix: Correct display of industry requires/produces in Build Industry window https://git.io/fhTef 12:36:05 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh dismissed a review for pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fxbLs 12:36:25 <frosch123> andythenorth: planetmaker: https://github.com/frosch123/eints <- any comments before i move it to openttd? note: there are two branches "master" and "openttd" 12:37:06 <nielsm> (I will not approve that PR, someone else will have to do that if anyone wants it) 12:38:11 *** snail_UES_ has joined #openttd 12:40:58 <TrueBrain> frosch123: possibly you constantly want to squash the changes in the openttd branch 12:41:01 <TrueBrain> so it is one or two commits 12:41:05 <TrueBrain> making it clear what the diff is 12:41:26 <frosch123> rebase instead of merge? 12:41:41 <TrueBrain> no, rebase instead of multiple commits 12:41:53 <TrueBrain> and you need to rebase the openttd branch on master btw :) It is missing a README now :P 12:42:15 <TrueBrain> frosch123: what I mean, you have master, and 'openttd', which is master with a few adjustments, right? 12:42:40 <TrueBrain> I suggest to have openttd as close as possible to master; so squash as many as you can 12:42:48 <frosch123> yes, but up to now there are no history changes in "openttd", lots of merge commits 12:43:11 <TrueBrain> yeah; those will be gone with that too :D 12:43:25 <TrueBrain> it is because I do not think the history of the openttd branch is really important 12:43:39 <TrueBrain> but that is just my 2 cents here :) 12:44:17 <frosch123> all your contributions were to that branch :p 12:45:12 <peter1138> LordAro, cold! 12:49:28 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #7072: Change: Add path cache for ships https://git.io/fhEyL 12:49:29 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7072: Change: Add path cache for ships https://git.io/fh0Yl 12:54:06 *** snail_UES_ has quit IRC 12:55:51 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7072: Change: Add path cache for ships https://git.io/fhEQx 12:56:15 <andythenorth> frosch123: no comments from me 👍 12:57:58 <planetmaker> moin 12:58:06 <planetmaker> frosch123, I've no objection moving that repo to github 12:59:06 <planetmaker> actually... its description is outdated. It's not only NewGRF translations. It's the main translation service for this whole community 12:59:28 <planetmaker> but that is not a repo issue :) 13:00:24 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7072: Change: Add path cache for ships https://git.io/fhE7m 13:00:44 <peter1138> "error pulling image configuration: received unexpected HTTP status: 502 Bad Gateway." 13:00:47 <peter1138> :/ 13:25:52 *** Flygon has quit IRC 13:29:49 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7072: Change: Add path cache for ships https://git.io/fhEFv 13:30:08 *** andythenorth is now known as Guest1125 13:30:18 *** andythenorth has joined #openttd 13:31:39 *** Guest1125 has quit IRC 13:43:33 <TrueBrain> andythenorth: https://www.staging.openttd.org/downloads/openttd-nightlies/latest.html < -does it autoselect OSX for you? 13:44:33 <andythenorth> TrueBrain: yes 13:44:38 <andythenorth> want me to try windows? 13:45:16 <TrueBrain> nah; I tested win64, that looks fine 13:51:16 <TrueBrain> okay, I can now set content-type on my uploads ... getting there :D 13:58:59 <TrueBrain> https://openttd.ams3.cdn.digitaloceanspaces.com/openttd-nightlies/20190118-master-g07a40df9/openttd-20190118-master-g07a40df9-macosx.zip <- long ass URL :D 13:59:12 <TrueBrain> next step ... make this available via the website 13:59:12 <TrueBrain> hmm 14:07:40 <TrueBrain> now I remember why we had media.openttd.org .. as multiple subdomains uses the same CSS etc 14:07:42 <TrueBrain> interesting 14:07:56 <TrueBrain> andythenorth: how are we going to solve that part? 14:08:26 <TrueBrain> guess a submodule used by everything that has the same style or something 14:08:55 <andythenorth> absolute css paths? 14:09:06 <andythenorth> or vendor in the css to the repo 14:09:08 <andythenorth> or a subrepo 14:09:09 <TrueBrain> so back to media.openttd.org :P 14:09:17 <andythenorth> overkill imo :P 14:09:18 <andythenorth> but eh 14:09:29 <TrueBrain> currently I want to add an index.html to the CDN 14:09:39 <TrueBrain> so if you go there, you can see in pretty ways the files available 14:09:48 <TrueBrain> but ... I have no real way to reference the CSS atm :) 14:09:53 <andythenorth> I would just treat that as subsidiary to the website, and absolute url to the website css url 14:10:18 <TrueBrain> the nice thing about putting the CSS and images on the CDN too, that it is a lot faster 14:10:22 <andythenorth> all the available ways are fine 14:10:22 <TrueBrain> (edge caching ftw) 14:10:47 <andythenorth> I honestly just copy-paste css around for this situation, if left to solve it alone 14:11:01 <TrueBrain> the images are more the issue; have you seen how many we have :P 14:11:02 <andythenorth> there are usually so few cases, it's not worth much engineering for 14:11:07 <TrueBrain> and LordAro is not fixing it any time soon I am afraid :P 14:11:09 <andythenorth> oof, images :P 14:11:27 <andythenorth> ok so the downside of CDN is that it makes dev fricking hard 14:11:39 <andythenorth> cos the css isn't trivially changed 14:11:49 <TrueBrain> and they need to be versionized 14:11:57 <andythenorth> but eh, let's not over-engineer it, whatever we do :P 14:12:26 <andythenorth> only 44 images, mostly junk 14:12:33 <TrueBrain> most can be replaced with CSS 14:12:38 <LordAro> oh, that thing 14:12:48 <LordAro> i could look at PRing it this weekend 14:13:15 <LordAro> TrueBrain: did we not decide on "OpenTTD YYYYMMDD" for nightlies? or is the above link just temporary? 14:13:18 <andythenorth> I copy-paste a UI library for other similar situations, but I rely on me knowing to do that 14:13:26 <TrueBrain> LordAro: we decided on what is on the CDN 14:13:27 <andythenorth> not everyone is me :P 14:14:09 <TrueBrain> LordAro: the final conclusion was that 'master' is just a branch. If you want a nightly of any other branch, that should be possible too 14:14:33 <LordAro> hrm 14:14:44 <LordAro> not sure i agreed with that 14:14:49 <LordAro> ¯\_(ツ)_/¯ 14:14:52 <TrueBrain> we are NOT going to open this debate again :) 14:16:00 <LordAro> :/ 14:16:02 <TrueBrain> (as if OpenTTD ever only moved if things were unanimous, we never moved at all :P) 14:17:16 <TrueBrain> andythenorth: it is a bit of a pickle .. embedding images/CSS is also not really simplistic :D 14:17:27 <andythenorth> this one is never easily solved 14:17:36 <andythenorth> meanwhile, I hate this github dashboard 14:17:44 <andythenorth> the LinkedIn-ification has started 14:17:57 <andythenorth> 'discover repositories you might be interested in' 14:17:58 <andythenorth> 'nope' 14:21:56 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on issue #7062: Ship pathfinders ignore the max order distance https://git.io/fhEb6 14:25:41 <TrueBrain> LordAro: https://irclogs.thegrebs.com/openttd/2019/01/06#15:07 <- for your readback pleasure; feel free to rechallenge this in a few weeks ;) 14:26:50 <TrueBrain> this is ANNOYING .. stupid CSS/images 14:27:01 <TrueBrain> how else am I going to do this .. hmm 14:27:19 <andythenorth> all the available routes are compromised 14:27:28 <andythenorth> I would do the one with least change 14:27:47 <TrueBrain> so, just to summarize what I am trying to do: 14:27:50 <TrueBrain> I now publish the binaries on the CDN 14:27:58 <TrueBrain> the CDN has no dir-listing; only bucket-listing 14:28:12 <TrueBrain> so there is a manifest.yaml per release that tells which files are there 14:28:24 <TrueBrain> currently, 'website' loads those manifest.yaml, and generate the HTML for it 14:28:32 <TrueBrain> that is now possible, as I can list all the releases that exist 14:28:36 <TrueBrain> on the CDN, not so much 14:28:49 <TrueBrain> so I was thinking of generating the html file while uploading to the CDN 14:28:52 <TrueBrain> as it will never change anyway 14:29:12 <TrueBrain> now the 'website' only needs to point to there, and we are done (which is easy, as the URLs are predictable) 14:29:19 <TrueBrain> but ... css/images are annoying there 14:29:27 <TrueBrain> soooooooooo ... what else is there 14:30:17 <andythenorth> - inline all the css and images (convert to inline styles, I am serious) 14:30:26 <TrueBrain> we can put the static files in a submodule, and publish every commit there under 'media.openttd.org' based on the 'git describe' 14:30:58 <TrueBrain> or even publish the static files from 'website' on the CDN every commit 14:31:43 <TrueBrain> I can add .txt files with the needed content to harvest all information 14:31:52 <TrueBrain> but that means I first need to download a file, amend to it, upload again 14:31:55 <TrueBrain> which .. I prefer not to 14:32:24 <TrueBrain> regenerate all the html files on the CDN every time a new 'website' commit happens :D 14:33:02 <andythenorth> regenerating seems fine 14:33:06 <andythenorth> if it's not loads of engineering 14:33:41 <TrueBrain> ~5000 files need regeneration 14:33:54 <TrueBrain> that is not out of the question 14:34:03 <TrueBrain> just a bit of bandwidth, but also not crazy 14:34:32 <andythenorth> sounds like it might scale horribly 14:34:57 <TrueBrain> 1 new file every day 14:34:59 <TrueBrain> so meh 14:35:23 <andythenorth> hmm 14:35:28 * andythenorth must kill some mice 14:35:33 <andythenorth> need to buy poison and traps 14:35:34 <andythenorth> BBL 14:35:35 <TrueBrain> lol 14:35:39 <TrueBrain> that is .. random :D 14:35:45 <andythenorth> mouse in my house 14:35:47 <andythenorth> at least one 14:35:49 <andythenorth> if not more 14:36:02 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7066: Add: [NewGRF] Airport animation trigger for plane landing (#6334, patch by Supercheese) https://git.io/fhENJ 14:36:08 <andythenorth> \o/ 14:36:12 <nielsm> I had mice in my 3rd floor apartment last winter and the two winters before that as well 14:36:18 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro merged pull request #7066: Add: [NewGRF] Airport animation trigger for plane landing (#6334, patch by Supercheese) https://git.io/fhliz 14:36:22 <andythenorth> mice are unwanted 14:36:25 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro closed issue #6334: Airports: add new airport tile animation trigger AAT_STATION_AIRPLANE_LAND https://git.io/fhENU 14:37:01 <TrueBrain> do we keep stats who is doing to most merges? :P 14:38:21 <TrueBrain> hmm, custom domains doesn't work yet for DigitalOcean spaces 14:39:36 *** andythenorth has quit IRC 14:44:20 *** Thedarkb2-T60 has quit IRC 14:44:39 *** Thedarkb2-T60 has joined #openttd 14:51:06 <TrueBrain> LordAro: did you have plans to use SaSS instead of CSS, or will it still be plain CSS? 14:51:17 <LordAro> plain css, as i recall 14:51:56 <TrueBrain> works for me 14:53:55 *** Samu has joined #openttd 14:54:36 <TrueBrain> hmm .. Jekyll doesn't see a difference between 'static' files and generated ones 14:54:43 <TrueBrain> so you cannot move static files to a CDN, for example 14:54:48 <TrueBrain> at least, not what I can find :( 15:00:16 *** andythenorth has joined #openttd 15:04:11 <DorpsGek_II> [OpenTTD/website] TrueBrain opened pull request #22: Minor cleanups https://git.io/fhEAr 15:04:17 *** Progman has quit IRC 15:04:23 <TrueBrain> ha, found a way :D 15:09:51 <Samu> oh no, my stuff was closed 15:12:06 <Samu> not even the 90 degrees 15:13:49 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #22: Minor cleanups https://git.io/fhEAr 15:14:00 * andythenorth wants a scriptable UI :P 15:14:13 <andythenorth> for newgrf dev, I want the defaults: 15:14:18 <andythenorth> - give me £100m 15:14:30 <andythenorth> - let me toggle expiring vehicles on/off, and reload_newgrfs 15:14:37 <andythenorth> - let me see the base vehicles :P 15:14:56 <andythenorth> OTOH I never use the scriptable UI in *any* of the apps I have that support it :P 15:18:06 <TrueBrain> lol 15:21:04 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #22: Minor cleanups https://git.io/fhEAr 15:21:23 <TrueBrain> this is one hard change to test before pushing it to staging :D 15:32:43 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #22: Minor cleanups https://git.io/fhEAr 15:33:16 <HeyCitizen> https://imgur.com/a/7q3CDYV 15:33:55 *** Borg has joined #openttd 15:35:14 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #22: Minor cleanups https://git.io/fhEAr 15:38:45 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #22: Minor cleanups https://git.io/fhEAr 15:38:46 <TrueBrain> last one, I think :) 15:38:56 <TrueBrain> tnx for the nice image HeyCitizen :) 15:40:12 <HeyCitizen> :) 15:46:30 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #22: Minor cleanups https://git.io/fhEAr 15:46:47 <TrueBrain> yippie, works :D 15:47:42 <andythenorth> :D 15:47:46 <TrueBrain> andythenorth: what do you think about this solution? 15:48:33 <andythenorth> makes sense to me 15:48:53 <andythenorth> go to prod with it, we can find out what we regret 15:49:09 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #22: Minor cleanups https://git.io/fhEAr 15:49:15 <TrueBrain> I tested it as much as I could; seems to work fine 15:49:35 <TrueBrain> as in: https://openttd-media.ams3.cdn.digitaloceanspaces.com/static-0.0.0-93-g371466d/css/base.css 15:49:36 <TrueBrain> works :) 15:50:54 <TrueBrain> andythenorth: if you can give it a review, just to look for very obvious mistakes, that would be good :) 15:51:02 <andythenorth> sure 15:51:38 <TrueBrain> local development is unchanged; it is just the CI/CD that do tricks now :) 15:51:39 <TrueBrain> I like that 15:53:00 *** Wormnest has joined #openttd 15:55:04 <TrueBrain> hmm .. we should run minimizers over static files :D 15:55:09 <TrueBrain> but that is something for another day :P 15:57:12 <TrueBrain> owh, bah 15:57:15 <TrueBrain> this is not going to work :( 15:57:19 <TrueBrain> no IPv6 support on the CDN 15:57:20 <TrueBrain> dammit 15:57:21 <TrueBrain> ugh 15:57:43 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #22: Minor cleanups and move static files to CDN https://git.io/fhEAr 15:58:15 <DorpsGek_II> [OpenTTD/website] andythenorth approved pull request #22: Minor cleanups and move static files to CDN https://git.io/fhEpC 15:59:17 *** Thedarkb2-T60 has quit IRC 15:59:45 <Samu> I'm sad 15:59:54 <TrueBrain> till DO fixes IPv6 on Spaces, I cannot do these kind of tricks 16:00:01 <TrueBrain> guess I have to go a bit more old-fashion .. 16:02:00 <DorpsGek_II> [OpenTTD/website] TrueBrain merged pull request #22: Minor cleanups https://git.io/fhEAr 16:02:16 <TrueBrain> tnx andythenorth 16:02:49 <Samu> what to do now? :( 16:03:51 <LordAro> Samu: last i checked several of your other PRs needed work/responses 16:05:51 <Samu> hmm, which ones 16:06:47 <Samu> https://github.com/OpenTTD/OpenTTD/pulls/SamuXarick 16:16:57 <Samu> I need help here, but I guess nobody understood yet what I'm trying to fix 16:17:08 <Samu> so, hmm I am waiting 16:22:21 <Samu> in sum, i need an order expert 16:22:26 <TrueBrain> https://openttd.ams3.cdn.digitaloceanspaces.com/openttd-nightlies/listing.txt <- lowtech it is :D 16:24:45 <Samu> someone who knows how to determine which location the vehicles goes next and the location the vehicle was before that 16:25:30 <Samu> I didn't look at the case of conditional orders, I'm too scared to even try 16:28:31 *** glx has joined #openttd 16:28:31 *** ChanServ sets mode: +v glx 16:34:15 <Samu> https://github.com/OpenTTD/OpenTTD/pull/6926 16:34:25 <Samu> on that one, i disagree with nielsmh 16:35:19 <Samu> because, why not? 16:36:20 <TrueBrain> 2 choices: convince him (in that Pull Request) otherwise, or remove that part of the PR 16:36:31 <TrueBrain> he does not have to convince you; you him :) 16:37:40 <TrueBrain> andythenorth: the new version number doesn't fit in the box in the top of the website :D 16:38:17 <andythenorth> url, or it didn't happen :P 16:38:31 <TrueBrain> no URL yet :P 16:38:45 <andythenorth> pedal faster 16:38:53 <andythenorth> I guess I could pull :P 16:39:08 <andythenorth> I'm drawing pixels and arguing with children currently though 16:40:49 <TrueBrain> nothing to pull :) 16:41:35 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6926: Change: Allow dock to be constructed in more locations https://git.io/fhEjR 16:42:04 <TrueBrain> Samu: that is NOT convincing anyone of anything 16:42:10 <TrueBrain> doing something "because" is never a good argument 16:42:17 <TrueBrain> explain why you want that change, why you think it is important 16:42:26 <Samu> because it's bugged 16:42:27 <TrueBrain> "because" is the worst argument, and one you can never win :) 16:42:31 <TrueBrain> tell that in the pull request! 16:42:39 <TrueBrain> and not just that, why YOU think it is bugged 16:42:40 <TrueBrain> be more verbose 16:42:45 <TrueBrain> help others help you 16:42:59 <Samu> you try to place a dock on those places and you are denied, even though there's water there 16:43:13 <Samu> why do I have to explain 16:43:15 <TrueBrain> tell that in the pull request. And adding pictures really helps 16:43:21 <TrueBrain> because you want the change 16:43:24 <TrueBrain> you have to do the work 16:43:29 <TrueBrain> don't expect others to do the work for you 16:44:27 <Samu> i thought it was implied with the title i gave 16:44:57 <TrueBrain> clearly it was not; otherwise it wouldnt have been an issue ;) 16:45:09 <TrueBrain> but here a picture can really help you out; showing what you mean exactly, can help others to understand 16:45:24 <Samu> ok 16:45:51 <glx> yes pictures showing exactly the denied places 16:46:26 <glx> text is not enough for cases like this 16:48:44 <andythenorth> before and after ideally 16:49:02 <andythenorth> I did read the PR and the code, but I have no idea how I would even test it 16:49:08 <andythenorth> so I didn't fetch it 16:49:17 <glx> because the diff doesn't help to visualise 16:52:14 <TrueBrain> awh, .md files are not shown inline in browsers 16:52:14 <TrueBrain> hmm 16:53:00 <glx> you need a md to html parsing I guess 16:53:42 <TrueBrain> that would be nice :D 16:53:58 <TrueBrain> for now I just rename it to .txt :) 16:55:32 <TrueBrain> owh, the .txt is also not shown inline 16:55:34 <TrueBrain> why not .. hmm 16:55:47 <TrueBrain> https://openttd.ams3.cdn.digitaloceanspaces.com/openttd-nightlies/20190118-master-g07a40df9/README.txt <- any clue anyone? 16:56:07 <TrueBrain> too large, I guess 16:56:55 <glx> doesn't seem very large too me 16:57:19 <andythenorth> MIME? 16:57:20 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6926: Change: Allow dock to be constructed in more locations https://git.io/fhueq 16:57:24 <glx> Text Document (38,3 Ko) 16:57:31 <TrueBrain> andythenorth: text/plain 16:57:37 <TrueBrain> just no explicit inline 16:57:39 <andythenorth> http://bundles.openttdcoop.org/firs/push/LATEST/changelog.txt 16:57:40 <TrueBrain> because ... that is annoying 16:57:47 <glx> maybe it's the way how browsers handle it 16:57:55 <andythenorth> https? 16:58:01 <andythenorth> nope 16:58:08 <andythenorth> https://bundles.openttdcoop.org/firs/push/LATEST/changelog.txt renders in browser for me 16:58:19 <andythenorth> something DO are setting? 16:58:27 * andythenorth hasn't read any headers or anything 16:58:39 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6926: Change: Allow dock to be constructed in more locations https://git.io/fhues 16:58:44 <Samu> done 16:59:13 <TrueBrain> I really have no idea why it makes that difference .. 16:59:19 <TrueBrain> browsers are weird 16:59:51 <TrueBrain> Samu: so much more clear 17:00:45 <glx> now it's clear indeed 17:00:47 <Samu> some AIs aren't prepared for the one corner raised cases closing a water connection, they think that by building a dock, the passage still remains 17:00:58 <Samu> it can now close passage 17:02:29 <DorpsGek_II> [OpenTTD/website] TrueBrain opened pull request #23: Add: support binary distribution via our new infrastructure https://git.io/fhuer 17:02:40 <TrueBrain> andythenorth: please do pull this and test it; no rush, but this really needs validation :) 17:02:52 <TrueBrain> if you can run those magic "check-if-links-are-all-valid" scripts over them, would be awesome 17:03:10 <andythenorth> 404 checker? 17:03:24 <DorpsGek_II> [OpenTTD/website] andythenorth commented on pull request #23: Add: support binary distribution via our new infrastructure https://git.io/fhuei 17:03:26 <andythenorth> might not be today 17:03:39 <andythenorth> is it blocker? 17:03:39 <TrueBrain> andythenorth: no rush 17:03:59 <TrueBrain> without it, we cannot go live, no; but I wont have much time either, so no worries 17:04:06 <TrueBrain> have to fix 2 other things first anyway 17:04:10 <TrueBrain> which ... will take time .. 17:04:47 <DorpsGek_II> [OpenTTD/website] TrueBrain commented on pull request #23: Add: support binary distribution via our new infrastructure https://git.io/fhue9 17:04:55 <TrueBrain> images to look at :D 17:06:06 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #23: Add: support binary distribution via our new infrastructure https://git.io/fhuer 17:06:23 <TrueBrain> having nightlies is creeping up on us :D 17:06:24 <TrueBrain> w00p 17:06:54 <andythenorth> :D 17:07:30 <TrueBrain> hmm ... IPv6 issue is back .. that CDN does not work on IPv6 .. but if I do not give the direct link, CDN is useless 17:07:37 <TrueBrain> and custom domains are not supported yet, so I cannot fake it with a CNAME 17:07:40 <andythenorth> :P 17:07:44 <TrueBrain> welllllllllll .... that is a nice blocker 17:07:53 <andythenorth> push 17:07:56 <andythenorth> posh 17:07:59 <andythenorth> pish 17:08:23 <LordAro> TrueBrain: any idea of what "yet" is? 17:08:47 <TrueBrain> "yet"? 17:08:54 <LordAro> custom domains 17:09:01 <TrueBrain> owh, time-wise 17:09:02 <TrueBrain> lol 17:09:04 <LordAro> is there any sort of eta, or is it just a "coming soon" ? 17:09:08 <TrueBrain> I was about to contact them for that :) 17:09:17 <TrueBrain> from what I read, it is in private-beta 17:12:59 <LordAro> alternatively, IPv6 support :p 17:17:54 <TrueBrain> basically, that is what I asked 17:18:19 <TrueBrain> "So I either must route all the traffic via a Droplet (losing edge-caching) or not have IPv6 support (not an option)." 17:18:23 <TrueBrain> the sumnary :P 17:18:38 <andythenorth> ugh 17:18:56 <TrueBrain> the worst is, if they cannot do either, I really have to look into GCP/AWS/Azure 17:19:02 <TrueBrain> and those are so freakinglish unclear 17:19:08 <TrueBrain> I really really don't want to do that :P 17:19:21 <TrueBrain> but okay, ticket sent 17:19:28 <TrueBrain> tonight hopefully I can fix server listing 17:19:38 <TrueBrain> and those are the only 3 remaining things, I think 17:19:41 <TrueBrain> \o/ :D 17:20:22 <TrueBrain> (btw, nightlies are being build every night already; and published. Just not easy to get access to yet) 17:20:23 <Samu> https://github.com/OpenTTD/OpenTTD/pull/6927 for this one, andythenorth and I have talked already, and it appears it's not going anywhere 17:20:53 <TrueBrain> time to feed myself :D 17:21:10 <andythenorth> Samu: it's unlikely to be merged 17:21:16 <andythenorth> it's a boil-the-ocean task 17:21:19 <michi_cc> TrueBrain: https://www.ovh.de/cdn/ ? 17:21:38 <Samu> it's a change that only makes sense if it's pursued further 17:21:44 <Samu> to make it global 17:21:50 <Samu> not just for docks 17:22:16 <andythenorth> Samu: I'd close that PR and focus on others 17:22:16 *** Borg has left #openttd 17:22:42 <Samu> hmm ok, i'm not in the mood to pursue it further, sorry 17:22:55 <andythenorth> e.g. this is a real issue, and it looked like you started making progress https://github.com/OpenTTD/OpenTTD/pull/6931 17:23:23 <Samu> i think it was Wolf01 that incentivated me to do it 17:23:32 <Samu> the concept of Docking Tile 17:24:12 <Samu> oh, that one is finished, unless you find problems 17:26:23 <Samu> regarding where to place the checks, I have placed where I think it's best 17:26:45 <Samu> not 100% sure of it 17:26:53 <Samu> but, for me it seems to work 17:32:48 <Samu> https://github.com/OpenTTD/OpenTTD/pull/6933 - that one is for consistency purposes 17:33:27 <Samu> screw realism 17:33:33 <Samu> I prefer consistency 17:46:56 <Samu> https://github.com/OpenTTD/OpenTTD/pull/6935 - hmm, this one had the title changed 17:48:00 <Samu> it's not any ordinary block, but the block that makes the ship dead-locked, with no means to get out of there 17:48:06 <Samu> that type of block 17:50:13 <Samu> I better type it in 17:53:22 <Samu> I need more pictures? 17:53:25 <Samu> :( 17:54:10 <Samu> https://user-images.githubusercontent.com/43006711/46670365-e4113c80-cbc9-11e8-8dd9-f817366b41be.png 17:54:16 <Samu> imagine that ship is not blue 17:54:33 <Samu> that ship would be dead-locked 17:54:36 <LordAro> Samu: stop explaining things here 17:54:40 <Samu> :( 17:54:45 <LordAro> things here get lost or just not seen 17:54:47 <LordAro> put it in the PR 17:55:28 <Samu> hm ok 17:56:19 <nielsm> if you don't feel confident in long-form writing, keep in mind it's a skill that requires practise 17:56:47 <nielsm> explaining technical things concisely and accurately _is_ hard, and you need to do it a lot to get good at it 17:57:06 <nielsm> but it's also a very valuable skill 18:03:12 <andythenorth> 89% 18:03:14 <andythenorth> oof 18:05:18 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6935: Prevent water construction where it could block nearby ships https://git.io/fhufp 18:05:28 <Samu> I suck at explaining, I really do :( 18:06:25 <Samu> I know what's wrong, I see what's wrong, but then I fail at explaining it to others 18:07:15 *** Thedarkb2-T60 has joined #openttd 18:09:36 <Samu> https://github.com/OpenTTD/OpenTTD/pull/6928 - this one is awaiting review again 18:10:19 <Samu> not gonna get approved I guess 18:11:15 <Samu> and that's it 18:13:11 <Samu> yesterday's PRs were closed, I really didn't expect it 18:13:48 <Samu> i combined them together, and today I combined them with the find ship depot 18:14:15 <Samu> it further reduced the stall that happens when ordering 5000 ships to depots 18:14:18 <Samu> for opf 18:14:29 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #6935: Prevent water construction where it could block nearby ships https://git.io/fhuJY 18:14:33 <Samu> was making progress in that front 18:14:48 <nielsm> the problem is that you're using OPF 18:15:03 <glx> OPF is dead 18:15:14 <glx> well more like a zombie ;) 18:15:20 <nielsm> OPF exists to mimic the behavior of 1994 TTD, not to be good 18:18:48 <glx> maybe it's possible to allow non moving ships to do 90° turns while moving ones can't 18:18:50 *** Wormnest has quit IRC 18:19:34 <andythenorth> I commented here multiple times the OPF is dead 18:20:24 <nielsm> don't build your game like this: https://i.imgur.com/1cVG7Ch.jpg 18:20:33 <nielsm> it's only going to cause trouble later on 18:22:03 <glx> hmm someone mismeasured something ;) 18:26:33 <Samu> eh, so will yapf find ship depots one day? 18:26:49 <Samu> it's where the stall is minimal 18:28:03 <Samu> by minimal, it's still a 2.7 seconds stall 18:28:10 <Samu> but considering 5000 ships 18:28:13 <Samu> it's okaysh 18:29:33 <Samu> and only happens once, it's not a check that's done every tile, only done when requested 18:30:59 <Samu> then of course, the ships will be pathfinder later on for the resulting dest-tile 18:31:08 <Samu> but that doesn't involve stalls 18:32:40 <Samu> if petern patch is approved, the path will be cached 18:34:05 <Samu> have to combine petern's cache into my combined stuff for testing 18:34:34 <Samu> peter1138 sorry, by bad 18:35:42 <Samu> but the stall for npf is another different story 18:35:47 <Samu> it's huuuge 18:35:51 <Samu> 14 seconds 18:36:39 <Samu> haven't timed opf stall at the moment, brb 18:39:19 *** Thedarkb2-T60 has quit IRC 18:42:51 <andythenorth> I don't recognise the case where 5000 ships all need to find a depot simultaneously 18:43:07 <andythenorth> what do I miss? 18:46:54 <Samu> the worst case scenario 18:50:02 <Samu> wow, 2.069 ms 18:50:13 <Samu> opf beats yapf in stall 18:50:36 <Samu> oh well, it was a nice experiment :| 18:54:21 <Samu> 3.456 ms stall with 90 deg allowed 18:54:38 <Samu> still better than my previous 4.7 19:13:22 <Samu> hmm wasn's the 3x3 roads alignment to happen between towns? 19:13:50 <Samu> some towns dont align with others 19:14:17 <Markk> 2x2 does at least 19:15:07 <Samu> oops im using random roads, nevermind 19:22:30 <Samu> where do i have the generate friendly rivers patch 19:25:18 <frosch123> do we need different "teams" with merge-permission for openttd/nml/eints/website/compilefarm/dorpsgek/..., or should we continue with a single team? do people want more badges? :p 19:25:31 * peter1138 returns. 19:26:38 <LordAro> frosch123: if the need arises, imo 19:29:20 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7072: Change: Add path cache for ships https://git.io/fhuT1 19:34:16 <Samu> peter1138 what happens to cache when switching 90 degrees on and off 19:34:53 <nielsm> why would that matter, nobody does that during normal play 19:34:54 <Samu> or change to other pf and back? 19:35:40 <peter1138> Nothing. 19:35:59 <peter1138> I guess I consider the path is still valid? ;) 19:36:43 <peter1138> I guess switching could clear the path. 19:38:46 <m1cr0man> Does openttd load configs and such from it's install directory or the working directory? 19:39:23 <LordAro> m1cr0man: readme section 4.2 19:39:28 <m1cr0man> perfect :) 19:39:30 <LordAro> (both) 19:39:40 <m1cr0man> ty, I actually forgot how good the readme is 19:39:45 <peter1138> Hmm, need to find my laptop power supply. 19:41:31 <peter1138> https://github.com/OpenTTD/OpenTTD/pull/7056 19:41:38 <peter1138> ^ LordAro, approved, no commit? 19:42:12 <andythenorth> nielsm: horse EMUs done ;) https://www.tt-forums.net/viewtopic.php?p=1217564#p1217564 19:44:05 <LordAro> peter1138: i wanted someone else to look at/approve it, i think 19:45:50 *** Gabda has joined #openttd 19:45:51 <nielsm> coal! 19:46:14 <Gabda> o/ 19:46:32 <andythenorth> every time I get to 90% I ship Horse 19:46:36 <andythenorth> then I add more stuff :P 19:48:25 *** Thedarkb2-T60 has joined #openttd 19:48:42 <peter1138> Ship early, ship often. 19:48:54 <peter1138> Did I see emails earlier about binaries and nightlies? 19:48:55 <nielsm> but those aren't ships. 19:48:58 <nielsm> train early, train often 19:49:41 <peter1138> o_O 19:49:47 <peter1138> Well played. 19:49:50 <andythenorth> horse early, horse often 19:50:00 <peter1138> NRT? 19:50:15 <andythenorth> you should yes 19:50:19 <andythenorth> currently it conflicts 19:50:25 <LordAro> again? 19:50:33 <andythenorth> https://github.com/OpenTTD/OpenTTD/pull/6811 19:50:33 <LordAro> or wait, when was it last fixed? 19:50:42 <andythenorth> fixed before we changed road pathfinder 19:50:45 <andythenorth> so eh 19:51:00 <andythenorth> long-running fork, merge hell 19:51:35 <peter1138> I'll take a look tomorrow. 19:51:53 <LordAro> there doesn't look like an awful lot of conflicts 19:51:56 <peter1138> Currently I'm at the M-i-L's house, on tethered Internet. 19:51:56 <andythenorth> there aren't 19:51:58 <LordAro> nothing scary looking anyway 19:52:09 <andythenorth> no, just above my knowledge to resolve 19:52:17 <andythenorth> I don't want to guess, and introduce subtle bugs 19:52:27 <andythenorth> or even unsubtle ones 19:52:56 <peter1138> Samu, any other configuration settings you can spot which might want the path caches to be invalidated? 19:53:16 <Samu> hmm tile height 19:53:19 <andythenorth> right mexican food time 19:53:20 *** andythenorth has quit IRC 19:53:31 <peter1138> Tile height? 19:53:45 <Samu> it could change costs 19:54:17 <Samu> stuff that alters the cost 19:54:21 <Samu> of the path 19:54:39 <nielsm> are there configuration settings that do that? 19:54:52 <peter1138> I don't see a setting to do that. 19:55:06 <Samu> no, not that 19:55:09 <Samu> sorry 19:55:24 <peter1138> There's max map height but that can't be changed. 19:55:40 <Samu> canals make some ships move slower, at least i saw some code there 19:55:41 <nielsm> adding checks during landscape manipulation for obstructing any cached ship paths would probably negate any advantage gained by the caching 19:55:46 <LordAro> peter1138: not again :p 19:56:34 <peter1138> Again? 19:56:43 <LordAro> More Height Levels took so long to get implemented :p 19:57:03 <peter1138> Eh, I mean the setting can't be changed mid-game, therefore there's nothing to invalidate. 19:57:25 <Samu> your code doesn't compare costs? 19:57:39 <peter1138> Why would it? The pathfinder does all that. 19:57:40 <Samu> at least i would check if the path cost is still the same as before 19:58:06 <peter1138> Why? 19:58:17 <peter1138> You'd need to... run the pathfinder again to see if it changed. 19:58:22 <peter1138> And that would be utterly pointless. 19:58:40 <nielsm> path caching might make ships take less optimal routes in some cases where the landscape changes around it 19:58:49 <nielsm> that's the tradeoff for the performance improvement 19:58:53 <Samu> only retrieve the costs of the cached cache and check if it still matches 19:58:59 <Samu> oh, ok 19:59:29 <peter1138> nielsm, yup, that's why I set a fairly low limit to the cached path length. Actually 32 is quite high. 19:59:41 <peter1138> But I figured we don't need Yet Another Option. 20:00:05 <Samu> only 32 tiles? :( i thought it was caching the whole path 20:00:06 <Eddi|zuHause> but the same thing happens for trains that have long path reservations 20:00:18 <peter1138> Indeed. 20:00:20 <Samu> well i didn't really look at the code in full 20:00:26 <Samu> maybe i should 20:01:28 <peter1138> 32 tiles means up to 32x less pathfinder calls. 20:01:39 <peter1138> Which is significant. 20:03:14 <Eddi|zuHause> so we allow 6 times longer routes and have 6^2 longer pathfinder calculations :p 20:04:05 <peter1138> Heh, well, I'm wondering now about that earlier patch that refuses to pathfind over max order distance. Would be worth seeing if this cache makes that unnecessary. 20:04:17 <peter1138> Heck maybe max order distance becomes unnecessary. 20:04:40 <Eddi|zuHause> that would be ideal 20:04:52 <peter1138> Now that I think about it... shared path cache... 20:05:02 <peter1138> Maybe this PR is a bit premature :p 20:05:22 <Eddi|zuHause> introduce the concept of routes? :p 20:05:30 <Eddi|zuHause> TF-style 20:05:52 <Eddi|zuHause> the route is a complete path, and each ship only needs to follow that path 20:06:39 <glx> shared patch cache seems like a good idea 20:06:46 <peter1138> Cache a complete path, indexed by start and end, and then look that up when finding a path to follow. 20:07:33 <peter1138> Damn. And this patch was approved at two points! 20:07:33 <glx> but a change in the middle of the route can be a problem 20:08:27 <peter1138> glx, just invalidate the cache if a ship encounters an obstruction, and maybe add a lifetime to each path. 20:08:57 <peter1138> How common is 100 ships sharing a route? 20:09:45 <glx> cache between 2 orders and not the full list 20:10:17 <peter1138> Well yes. 20:10:58 <peter1138> I'm thinking lookup a cache by start/end tiles, so that non-shared orders still benefit. 20:11:24 <peter1138> Or where orders partially follow the same route. 20:12:07 <glx> ah yes a global cache instead an individual cache 20:12:43 <peter1138> Could have a LRU as well. 20:14:14 <peter1138> Hmm, less optimal for not-found paths. 20:19:00 <peter1138> Sadface. I don't have the proper base graphics installed on this laptop :/ 20:22:22 <Gabda> would it help in the ship path finding, if the water domains were indexed? 20:23:04 <Gabda> if the 256 largest individual water surfaces were numbered 20:23:08 <peter1138> Not really. 20:23:26 <peter1138> What would help is know if start -> end is unreachable. 20:23:27 <Eddi|zuHause> <peter1138> How common is 100 ships sharing a route? <-- i could imagine some people actually do that :p 20:23:34 <Gabda> you wouldn't need to search for most of the path not founds 20:24:09 <Gabda> if you can check at the begining that they are in different water domains 20:24:18 <peter1138> Yeah but "256 largest" isn't that useful. 20:24:38 <peter1138> Find isolated areas and flag them as such, yeah. 20:24:47 <peter1138> Could be tons though :( 20:24:55 *** Thedarkb1-T60 has joined #openttd 20:25:09 <Eddi|zuHause> you don't really know how large an area is when you start indexing it 20:25:13 <peter1138> Yeah. 20:25:15 <Gabda> if one is numbered, the other is nit, there is no route 20:25:19 <peter1138> 256 may or may not be enough. 20:25:32 <peter1138> 65535 may not be enough on a 4096x4096 map. 20:25:38 <Gabda> it none of them is numbered, t 20:26:02 <Gabda> it means that it is one or two, but small ponds 20:26:19 <peter1138> I guess you could mark really small areas the same, and always exclude them. 20:26:32 <Gabda> and in small ponds, it is easier to tell if there is no route 20:26:36 <peter1138> Like an area that's too small to contain a multiple docks. 20:26:58 <LordAro> you'd have to invalidate the cache on almost every terraform action though 20:27:10 <Eddi|zuHause> no 20:27:27 <Eddi|zuHause> you can update the indexing on clearing/flooding 20:28:15 <Eddi|zuHause> we discussed this a few days ago, it's a relatively simple flood-fill operation 20:28:22 <Gabda> it might be tricky if you cut a surface into two 20:29:04 <Gabda> but you can find that on the first path not found "error" 20:30:11 <Gabda> but I don't know how often this problem comes up that someone wants to send a ship where it clearly cannot go 20:30:36 <Eddi|zuHause> you just have to loop around the cleared area, and start a new flood-fill action (with a new index) from each tile that still has the old index number 20:30:55 <peter1138> Just :D 20:31:04 *** Thedarkb2-T60 has quit IRC 20:31:29 <Eddi|zuHause> peter1138: i mean, it's not gonna be that much code 20:32:16 <Eddi|zuHause> Gabda: i think the more common case is that a route that was once possible gets cut by some unrelated thing 20:32:50 <glx> and sometimes a longer route may exist too 20:40:18 <peter1138> Gabda, so yeah, if you can make a patch for it... ;) 20:41:11 <Gabda> for the numbering 20:41:21 <peter1138> There's loads of space on plain water tiles. 20:41:33 <Gabda> or detecting if a route gets cut? 20:46:47 <Gabda> with a 2 byte indexing it is possible to number each separate water surface above the size of 128 tiles, even on the 4096x4096 map 20:48:28 <peter1138> I think m2 is free, that's 2 bytes. 20:49:48 <Gabda> ships can only go to a different hight if there is a lock build at the transition? 20:50:31 <peter1138> Yup. 20:53:59 <TrueBrain> https://servers.openttd.org <- that working for everyone as they would expect? (spot any odds things?) 20:54:20 <glx> m2 is not free for ship depots 20:54:56 <glx> but m8 is free for all water tiles 20:55:43 <Gabda> m3 and m4 is free for dock and bouy and depot 20:55:57 <glx> TrueBrain: seems ok for me (and IPv6) 20:56:02 <TrueBrain> tnx 20:56:20 <Gabda> and oilrig (if the ship can go under it) 20:56:49 <peter1138> Well, there's m8 too, yes. 20:57:32 <glx> but m3 and m4 are short 20:57:34 <Samu> hi 20:57:37 <Gabda> can a ship sail on oilrig tiles? 20:57:47 <Samu> no 20:57:56 <DorpsGek_II> [OpenTTD/website] TrueBrain opened pull request #24: Fix: also redirect serverlisting pages to their own subdomain https://git.io/fhuLD 20:58:15 <Gabda> but m3 << 8 + m4 can work 20:58:30 <glx> but that's 2 accesses 20:58:32 <Samu> what are you discussing? 20:58:57 <glx> plus math 20:59:22 <Samu> indexing routes? 20:59:49 <Samu> no, indexing water bodies? 20:59:51 <Gabda> but only for a few tiles 21:00:04 <Gabda> yes, water bodies 21:00:24 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7072: Change: Add path cache for ships https://git.io/fh0Yl 21:01:29 <Gabda> well, m8 seems easier, but it is nice to see it so free :) 21:01:29 <peter1138> TrueBrain, looks okay but I don't look at it often enough to know if something is different. 21:01:44 <TrueBrain> tnx 21:01:53 <TrueBrain> if nothing obvious is broken, it should be working, right? :D 21:01:56 <peter1138> Hmm, so global path cache? 21:02:03 <peter1138> TrueBrain, ship it :D 21:02:31 <Samu> what are we caching now? 21:03:07 <Gabda> it seems like everything 21:03:19 <LordAro> TrueBrain: train it :D 21:03:19 <peter1138> Full path between orders, I think. 21:03:21 <Samu> how will the water bodies help? 21:03:43 <Samu> oh but costs? 21:03:43 <TrueBrain> right .. how to setup a ipv6 to ipv4 gateway ... 21:03:53 <peter1138> What about costs? 21:04:05 <peter1138> haproxy/nginx? 21:04:07 <Samu> it's... hmm let me find 21:04:57 <TrueBrain> natpt I guess? 21:05:01 <Samu> https://github.com/OpenTTD/OpenTTD/blob/master/src/pathfinder/yapf/yapf_ship.cpp#L180 21:05:07 <TrueBrain> would be nice if it works for TCP and UDP I guess 21:05:12 <Samu> that cost can decide different routes for different ships 21:05:19 <peter1138> Oh, UDP necessary too. 21:05:32 <peter1138> Samu, okay. 21:05:47 <TrueBrain> yeah, Master Server ... 21:05:48 <Gabda> water bodies could help to find "no routes" faster, if it is possible to implement it well 21:07:59 <LordAro> TrueBrain: remind me how to start/build the website? 21:08:03 <TrueBrain> owh, naptd is not in debian .. hmm 21:08:04 <LordAro> there's no readme :( 21:08:14 <TrueBrain> LordAro: docker build, for sure 21:08:21 <TrueBrain> looking in there should for sure help you out :D 21:08:28 <TrueBrain> but install Jekyll, and run 'jekyll serve' 21:08:31 <TrueBrain> or use a Jekyll docker 21:08:53 <TrueBrain> https://hub.docker.com/r/jekyll/builder/ 21:09:01 <LordAro> i'll have a look 21:09:34 <DorpsGek_II> [OpenTTD/website] LordAro approved pull request #24: Fix: also redirect serverlisting pages to their own subdomain https://git.io/fhut8 21:09:36 <TrueBrain> I will add stuff in the README soon-ish 21:09:40 <DorpsGek_II> [OpenTTD/website] LordAro closed issue #13: Server-listing cannot be on www.openttd.org https://git.io/fhOxr 21:09:41 <DorpsGek_II> [OpenTTD/website] LordAro merged pull request #24: Fix: also redirect serverlisting pages to their own subdomain https://git.io/fhuLD 21:10:08 <TrueBrain> hmmm .. I forgot to change the URL in the menu, I guess 21:10:23 <TrueBrain> ah, no :) 21:12:27 <Samu> caching between shared orders may not work well if the ship models differ 21:12:39 <Samu> because of those costs 21:13:34 <DorpsGek_II> [OpenTTD/website] LordAro commented on pull request #23: Add: support binary distribution via our new infrastructure https://git.io/fhutP 21:14:45 <DorpsGek_II> [OpenTTD/website] TrueBrain commented on pull request #23: Add: support binary distribution via our new infrastructure https://git.io/fhutD 21:15:04 <DorpsGek_II> [OpenTTD/website] TrueBrain commented on pull request #23: Add: support binary distribution via our new infrastructure https://git.io/fhuty 21:15:43 <DorpsGek_II> [OpenTTD/website] TrueBrain opened issue #25: Many hardcoded URLs https://git.io/fhutS 21:16:25 <DorpsGek_II> [OpenTTD/website] TrueBrain opened issue #26: Update README https://git.io/fhutH 21:16:36 <TrueBrain> why fixing things if you can make a bug ticket out of it :D 21:17:27 <TrueBrain> okay, an IPv6 is more complex than I assumed 21:17:43 <TrueBrain> guess we have a bit of an unique situation, where we only want to convert a single IPv6 to a single IPv4 :) 21:17:46 <peter1138> Samu, could make that cost part of the cache index. 21:18:41 <LordAro> TrueBrain: :p 21:21:26 <peter1138> Maybe best to stick with the caching we have for now. It's still a massive improvement. 21:22:10 <peter1138> Anyone want to approve it? ;) 21:22:31 <peter1138> Before I decide to change anything else. 21:24:25 <Samu> me? I approve :o 21:25:07 <Samu> i don't know how to approve 21:25:13 <peter1138> You can't. 21:25:22 <Samu> ok 21:26:54 *** Gustavo6046 has joined #openttd 21:28:04 *** Thedarkb1-T60 has quit IRC 21:28:34 *** gelignite has joined #openttd 21:29:29 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7072: Change: Add path cache for ships https://git.io/fhuqW 21:32:08 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened pull request #7073: Feature: Generate lock ready rivers upon world generation https://git.io/fhuqz 21:34:16 *** Gabda has quit IRC 21:34:33 <Samu> lock ready or lock friendly 21:35:11 <Samu> probably needs a revise 21:35:25 <Samu> it's not ready for forbiden 90 degrees 21:40:29 <DorpsGek_II> [OpenTTD/website] TrueBrain opened pull request #27: Update: README.md is now more verbose and even contains a FAQ https://git.io/fhuqd 21:40:31 <TrueBrain> LordAro will be so proud :D 21:40:37 <LordAro> TrueBrain: `Pagination Error: Detected invalid url "/news" for "pages/news_archive.html" xpected "/" or "/index.html"` any ideas? 21:40:40 <LordAro> TrueBrain: :> 21:40:56 <TrueBrain> none; never seen that 21:41:01 <LordAro> hmm 21:41:03 <TrueBrain> https://github.com/TrueBrain/OpenTTD-website/tree/readme for a pretty view of the README btw 21:41:09 * peter1138 attempts to remove path_dest 21:41:33 *** wodencafe has quit IRC 21:42:07 <TrueBrain> LordAro: which version of Jekyll? 21:42:16 *** Speedyn has joined #openttd 21:42:25 <LordAro> TrueBrain: 3.8.5 21:42:40 <peter1138> Can someone go for a pee for me? 21:42:51 <TrueBrain> hmm, I have the same LordAro .. 21:43:12 <TrueBrain> LordAro: you did install the Gemfile.lock deps? 21:43:21 <TrueBrain> especially the jekyll-feed and jekyll-paginate-v2 ? 21:44:19 *** Speedy` has quit IRC 21:44:37 <LordAro> TrueBrain: pretty sure i have 21:46:31 <LordAro> oh hang on, i've updated, rather than installed 21:46:55 <LordAro> mayhaps jekyll-paginate-v2 2.1 has changed something 21:47:10 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #27: Update: README.md is now more verbose and even contains a FAQ https://git.io/fhuqd 21:47:19 <TrueBrain> I updated the README to show what you should do 21:47:23 <TrueBrain> 'bundle install' 21:47:31 <TrueBrain> should used the pinned versions 21:47:55 <TrueBrain> not completely sure, because ruby 21:48:30 <LordAro> yeah, got it running now 21:49:09 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #27: Update: README.md is now more verbose and even contains a FAQ https://git.io/fhuqd 21:49:10 <TrueBrain> good :) 21:49:27 <TrueBrain> README is not perfect yet, but it is a start :) 21:49:51 <TrueBrain> this 'website' became pretty .. huge :D 21:50:15 <LordAro> heh 21:50:33 <LordAro> yeah, definitely seems to be something to do with 2.1 - https://github.com/sverrirs/jekyll-paginate-v2/issues/147 21:50:47 <LordAro> not that that's a particularly useful bug report 21:51:17 <TrueBrain> will check it out when I bump the versions .. cant be arshed atm :D 21:55:12 <Samu> generating 13k towns when there's more water than land is tooo slow 21:55:31 <peter1138> :D 21:58:04 <Samu> why doesn't the world editor allow me to generate random rivers? 21:58:11 <Samu> scenario editor* 21:59:18 <peter1138> Because you didn't add that feature yet? :D 22:03:52 <TrueBrain> "2a03:b0c0:2:d0::dc6:7000 - 2a03:b0c0:2:d0::dc6:700f" <- LOL @ IPv6 space that DO assigns to a droplet .. that is ... cute? 22:04:22 <glx> wow big range :) 22:05:14 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7072: Change: Add path cache for ships https://git.io/fhumP 22:05:16 <TrueBrain> I think they are scared they run out 22:06:14 *** Samu has quit IRC 22:06:26 <glx> I have a lot more for just a home connection 22:07:23 *** gelignite has quit IRC 22:07:31 <peter1138> I think I have a /48 for home, although it's not all routed there. 22:07:35 *** Samu has joined #openttd 22:09:02 <Samu> @logs 22:09:03 <DorpsGek> Samu: https://webster.openttdcoop.org/index.php?channel=openttd 22:09:34 <glx> I think I have a /64 22:10:39 <milek7> scaleway is even more lol, /128... 22:11:16 <Samu> i wish i could drag and drop branches onto each other to combine patches 22:12:44 <peter1138> You could make a tool that lets you do that :p 22:13:57 <LordAro> https://i.imgur.com/PAP2yac.png progress! 22:15:10 <TrueBrain> but but buttttttt OMG 22:15:50 <Samu> Rebase Onto... 22:15:56 <Samu> hope this is it 22:19:16 <Samu> https://github.com/OpenTTD/OpenTTD/pull/7073 + https://github.com/OpenTTD/OpenTTD/pull/6931 = happy ships! 22:19:23 <TrueBrain> okay, this IPv6 stuff is more of an issue than I expected; if I had spend a few more brain-cycles, I would have realized ithat :D 22:19:40 <peter1138> :/ 22:20:26 <TrueBrain> IPv4 to IPv6 is easier, as an IPv4 fits in an IPv6 :P 22:21:45 *** sla_ro|master has quit IRC 22:22:46 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7072: Change: Add path cache for ships https://git.io/fhuY3 22:24:39 <LordAro> https://i.imgur.com/4sXhdy8.png closer... 22:25:02 <milek7> maybe this? looks simple https://github.com/wojtekka/6tunnel 22:25:38 <milek7> ah, but probably doesn't do udp 22:26:03 <TrueBrain> yeah, but if you look in the code, there is one minor issue :D 22:26:09 <TrueBrain> you can fork-bomb that very very quickly 22:26:23 <TrueBrain> nice LordAro :) 22:27:14 <TrueBrain> 6tunnel has a global connection limit, instead of a per IP or something 22:27:40 <TrueBrain> guess nginx will have to do .. (not the HTTP part, but nginx can also route TCP and UDP) 22:31:35 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7072: Change: Add path cache for ships https://git.io/fhuYV 22:34:39 <milek7> hard to have meaningful per-IP limit on ipv6 ;D 22:35:07 <TrueBrain> nginx does this pretty well 22:35:15 <TrueBrain> right .. now I need an IPv6 enabled host .. hmm 22:37:11 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7072: Change: Add path cache for ships https://git.io/fhuY7 22:39:23 *** Progman has joined #openttd 22:44:42 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7072: Change: Add path cache for ships https://git.io/fhuOk 22:45:08 <TrueBrain> glx (or anyone else with IPv6): can you check that http://www.staging.openttd.org and https://www.staging.openttd.org as simply working (over IPv6) 22:45:51 <glx> http is redirected to https 22:46:07 <TrueBrain> I guess that means it works :P 22:46:34 <glx> firefox says ipv6 but the openttd icon doesn't ;) 22:46:44 <TrueBrain> no, the icon will no longer change :) 22:46:50 <TrueBrain> I forgot we added that gimmick :) 22:46:51 <TrueBrain> lol 22:47:06 <TrueBrain> tnx glx! 22:47:23 <TrueBrain> okay ... so I now have a DigitalOcean LoadBalancer which is configured automatically via kubernetes, which is awesome 22:47:35 <TrueBrain> and ... an IPv6 LoadBalancer I had to setup myself and manually sync with kubernetes :P 22:47:38 <TrueBrain> this will NEVER go wrong! 22:47:39 <TrueBrain> :D 22:47:44 <peter1138> No IPv6 on my tethered ghetto connection :/ 22:48:27 <TrueBrain> but for now this allows us to have IPv6 as before, so I can continue the migration .. means only the CDN issues are left .. hmm 22:48:48 <TrueBrain> I guess I can add a redirector there, which splits IPv4 from IPv6 22:49:00 <TrueBrain> sub-optimal, but at least means we can go live with the new stuff 22:50:26 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7072: Change: Add path cache for ships https://git.io/fhuOY 22:50:35 <TrueBrain> getting there :D 22:50:54 <milek7> it seriously needs loadbalancer? one machine for simple site is not enough? 22:51:51 <DorpsGek_II> [OpenTTD/website] TrueBrain commented on issue #21: Staging doesn't support IPv6 https://git.io/fhuOO 22:52:13 <TrueBrain> I think you heavily underestimate how busy OpenTTD is, and especially can be :D 22:52:27 <TrueBrain> and many parts of the OpenTTD services are far from 'simple' 22:52:38 <TrueBrain> the 'website' project is just the first and simplest :) 22:53:34 <TrueBrain> but also, LB is common practice, and as we are running k8s, also simplistic to add :) 22:58:44 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7072: Change: Add path cache for ships https://git.io/fh0Yl 23:00:09 <Samu> I can't make terragenesis generate the kind of terrain that would showcase best my PRs 23:00:21 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7072: Change: Add path cache for ships https://git.io/fhuOg 23:00:30 <Samu> either single level rivers with tons of sea water 23:00:45 <Samu> or multi-level rivers with too little sea water 23:00:58 *** HerzogDeXtEr has quit IRC 23:02:56 <Samu> terragenesis showcases #7073 best, original generator showcases #6931 best 23:03:26 <Samu> i wanted to showcase both changes applied in a single screenshot 23:04:35 <DorpsGek_II> [OpenTTD/OpenTTD] michicc approved pull request #7072: Change: Add path cache for ships https://git.io/fhuOK 23:08:13 *** snail_UES_ has joined #openttd 23:11:20 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN merged pull request #7072: Change: Add path cache for ships https://git.io/fh0Yl 23:11:34 <LordAro> \o/ 23:15:14 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7072: Change: Add path cache for ships https://git.io/fhuOx 23:15:51 <LordAro> yes, too late :p 23:16:07 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7072: Change: Add path cache for ships https://git.io/fhuOj 23:18:19 <LordAro> peter1138: if you're going to be doing extra stuff - how much extra effort would it be to make dest_tile a private variable? would protect against future abuses 23:18:51 <peter1138> Not sure, it's read from quite a lot. 23:19:25 <peter1138> C#'s accessors make that easy, heh. 23:19:42 <glx> yeah get and set are easy 23:22:54 * LordAro slepify, in an attempt to go cycling tomorrow 23:24:06 <peter1138> LordAro, is #7040 still needing changes? 23:24:08 <peter1138> Oh. Good night. 23:24:10 <nielsm> argh, visual studio keeps insisting that strgen and settingsgen need to be relinked, and the OPL emulator code I imported needs to rebuild all the time 23:24:13 <nielsm> despite no changes 23:24:34 <peter1138> I'm having a day off tomorrow, given that I'm in the wrong town without a bike (nor cycle clothing) 23:24:42 <nielsm> I've tried dleting all things I can find that seem to relate to the project data, and it's still happening 23:25:01 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #7040: Fix: Round up deltas for smooth scrolling, so that target will eventually be reached https://git.io/fhnl2 23:25:55 <LordAro> peter1138: :) 23:27:03 <peter1138> Bought a Graze "oat millionaire" bar. Totally not worth it. 23:27:14 <peter1138> Very disappointing for £1.99! 23:27:27 <peter1138> (Hospital shop, may be more expensive than normal.) 23:33:49 <nielsm> most ceral bar type stuff seems massively overpriced for what it's supposed to be 23:34:19 <nielsm> unless it's half coated in chocolate then it sells for cheap 23:34:27 <nielsm> but leaving out the chocolate makes it expensive, somehow 23:36:53 <glx> maybe try a rebuild all 23:37:48 <nielsm> I've deleted the entire obj directory, all .vs directories, the project database (intellisense and stuff), and anything else I could find being generated by opening/building it 23:38:06 <glx> intellisense seems broken to me 23:38:28 <nielsm> maybe I should just go ahead and install a newer VS version anyway 23:38:36 <nielsm> (currently using 2015) 23:38:37 <glx> it doesn't like some comments (says broken XML) 23:38:37 <peter1138> It had chocolate on it, but yes. 23:38:55 <peter1138> Should really be not-lazy and try making my own. Or just do without. 23:39:09 <glx> doesn't find definition for static inline functions in .h 23:39:57 <glx> I switched to VS2017 recently 23:40:50 <nielsm> https://0x0.st/shRJ.txt <- result of doing a regular build after just finishing one :( 23:42:01 <peter1138> Do the files somehow have a weird modified date on them? 23:42:52 <nielsm> last modified 9 hours ago according to my system clock 23:43:51 *** Wolf01 has quit IRC 23:44:01 <glx> relinking exe without having recompiled anything is weird 23:45:23 <glx> I knew I should not start the vs2017 update, it now wants me to reboot 23:45:55 <glx> ok launching 2015 instead :) 23:48:29 *** Flygon has joined #openttd 23:48:52 <glx> but 2015 is so slow to launch 23:50:56 *** snail_UES_ has quit IRC 23:54:01 <glx> trying a rebuild all then build to compare 23:58:08 *** frosch123 has quit IRC