Times are UTC Toggle Colours
10:30:59 <Xaroth> Also, would it not be easier to have the PR removing the string, remove them from all the languages? rather than changing it in two commits. (i.e. fix the tool, rather than the person) 10:46:13 <petern> Just follow the simple-but-hard-to-find rules and it'll be fine 😉 11:01:41 <DorpsGek> [OpenTTD/OpenTTD] btzy commented on pull request #8425: Feature: Contextual actions for vehicles grouped by shared orders https://github.com/OpenTTD/OpenTTD/pull/8425#issuecomment-1307023030 11:08:46 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #10114: Feature: Variable interface scaling https://github.com/OpenTTD/OpenTTD/pull/10114#issuecomment-1307032990 11:09:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10114: Feature: Variable interface scaling https://github.com/OpenTTD/OpenTTD/pull/10114#issuecomment-1307034270 11:11:29 <DorpsGek> [OpenTTD/OpenTTD] LordAro merged pull request #9901: Fix: Improve performance when calculating company value https://github.com/OpenTTD/OpenTTD/pull/9901 11:13:20 <DorpsGek> [OpenTTD/OpenTTD] LordAro merged pull request #9781: Change: Automatic screenshot numbering https://github.com/OpenTTD/OpenTTD/pull/9781 11:15:51 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #10141: Fix #10140: [SDL2] Lock mouse while moving viewport https://github.com/OpenTTD/OpenTTD/pull/10141#issuecomment-1307043249 11:18:48 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #10114: Feature: Variable interface scaling https://github.com/OpenTTD/OpenTTD/pull/10114#issuecomment-1307047727 11:29:59 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10114: Feature: Variable interface scaling https://github.com/OpenTTD/OpenTTD/pull/10114#issuecomment-1307062271 11:34:58 <reldred> petern: vote for keep chunky bevels 11:35:18 <reldred> It looks good on high dpi displays 11:35:32 <petern> I wasn't going to remove them. It's whether to make them optional or not. 11:35:35 <reldred> Esp with original TTD icons scaled up 11:35:38 <reldred> Ahh, 11:35:42 <petern> But yeah, some people may like the old way... 11:35:53 <reldred> Yeah make it mandatory tbh 11:35:55 <reldred> 😛 11:35:58 <petern> Hah 11:36:08 <reldred> **** em 😛 13:03:14 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10114: Feature: Variable interface scaling https://github.com/OpenTTD/OpenTTD/pull/10114#issuecomment-1307181575 14:13:37 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #9912: Fix #9908: Close company windows only after all its infrastructure is removed https://github.com/OpenTTD/OpenTTD/pull/9912#pullrequestreview-1172200920 14:17:14 <TallTyler> dP: No, not asking the player, I mean looking for the conditions you’re trying to fix (blocked grid intersections, NewGRF roads which don’t allow houses) and explicitly continuing the search when it finds such conditions. 14:21:24 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #8425: Feature: Contextual actions for vehicles grouped by shared orders https://github.com/OpenTTD/OpenTTD/pull/8425#issuecomment-1307299082 14:44:22 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler closed pull request #9912: Fix #9908: Close company windows only after all its infrastructure is removed https://github.com/OpenTTD/OpenTTD/pull/9912 14:44:25 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler closed issue #9908: [Crash]: order backup https://github.com/OpenTTD/OpenTTD/issues/9908 14:57:37 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #9727: Feature #9059: Add buttons to toggle music in the Game Options menu. https://github.com/OpenTTD/OpenTTD/pull/9727#pullrequestreview-1172285890 15:01:02 <TallTyler> For the record, I'm being quite lenient about messy commit histories on PRs where the contributor opened it a long time ago and are still willing to fix/rebase/update it, as a gesture of appreciation. 15:03:23 <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #9727: Feature #9059: Add buttons to toggle music in the Game Options menu. https://github.com/OpenTTD/OpenTTD/pull/9727 15:03:42 <LordAro> trouble is with that one it's so old that the commit checker couldn't find the origin point 15:03:54 <LordAro> should rebase cleanly though 15:04:19 <TallTyler> Oh, OK 15:04:24 <LordAro> in general though, yeah, messy commit histories can be ignored 15:04:34 <LordAro> unless it's the sort of PR where multiple commits are actually wanted 15:05:02 <LordAro> and obviously it's got to *only* be the commit message - commit checker also does whitespace checks too 15:06:37 <TallTyler> Can you explain or point me to a guide for how to update other people's PRs from the desktop command line? I tried to fix #9034 yesterday but it pushed to a new branch in my repo. I did confirm with the contributor that they checked the "maintainers can edit" box. 15:07:14 <LordAro> generally you've got to check out their remote explicitly 15:07:23 <LordAro> the pull/NN/head remote is read-only 15:07:41 <LordAro> i.e. git@github.com:LordAro/OpenTTD.git etc 15:08:49 <TallTyler> Ah, I checked out the pull directly 15:08:56 <TallTyler> Thanks 15:20:43 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #8895: Feature: let AI developers edit non-editable AI/Game Script Parameters https://github.com/OpenTTD/OpenTTD/pull/8895#pullrequestreview-1172333891 15:21:33 <TallTyler> Also, how do I force CI checks to re-run, in cases like #8895 where some checks were added after the PR was opened? 15:22:26 <LordAro> two separate questions :p 15:22:52 <LordAro> CI checks can be rerun via the checks tab 15:22:55 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #10110: Feature: Hotkey to honk a vehicle's horn https://github.com/OpenTTD/OpenTTD/pull/10110#pullrequestreview-1172338449 15:23:30 <LordAro> however, as far as #8895 is concerned, it's old enough such that it has no idea what windows-2019(?) is, so can't run it (its copy of .github/workflows doesn't include it) 15:23:38 <LordAro> so needs rebasing 15:24:36 <TallTyler> Let's see if the button works or if I screw it up 😛 15:24:53 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #8895: Feature: let AI developers edit non-editable AI/Game Script Parameters https://github.com/OpenTTD/OpenTTD/pull/8895 15:25:52 <petern> ^ That does seem a pretty obvious thing to allow 🙂 15:26:12 *** WormnestAndroid has joined #openttd 15:33:45 <TallTyler> How do we feel about #10058 duplicating code with questionable magic numbers (AI GUI to the new GS GUI) and not fixing them? Out of scope or a good time to fix them? (Look at my open review items: https://github.com/OpenTTD/OpenTTD/pull/10058) 15:34:20 <LordAro> this is why i want 10114 merged asap :) 15:35:04 <TallTyler> Oh, does that problem go away with 10114? 15:36:35 <TallTyler> I agree with your reasoning to merge 10114 and get people using it. Should we consider a beta2 release then, to get it in front of people sooner than the RC release at the end of this month? 15:37:15 <LordAro> not a terrible idea 15:37:56 *** Smedles has quit IRC 15:38:06 *** Smedles has joined #openttd 15:38:24 <LordAro> i'm not actually sure whether the problem goes away, but petern's separately fixed most of the "why is this spacing here?" issues 15:38:32 <Rubidium> maybe wait a few days in master to get the most obvious issues out, but doing another beta after such a big change (and quite a few others I must admit) sounds like a reasonable plan 15:41:05 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler requested changes for pull request #10058: Feature: [UI] Split AI/Game Script configuration windows and add them to world gen window https://github.com/OpenTTD/OpenTTD/pull/10058#pullrequestreview-1172372749 15:41:36 <petern> There's quite a lot of duplication of GUI stuff in 10058. My stuff resolves the "what is this 2 pixels here?" by using named dimensions (hsep_normal, hsep_wide, etc...) but there's bound to be some left over. 15:42:01 <petern> But! Those can always be resolved later. 15:43:56 <petern> Anything using WD_ will break, by intention, but I can't make literal numbers break unfortunately. 15:50:03 <petern> Well, not without making it all use special types, I guess. 16:26:47 <glx[d]> LordAro: Rerun is only valable when the CI failed internally, not when workflow needs to be updated first 16:28:37 *** Flygon has quit IRC 16:31:48 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #10148: Codechange: Fix improperly named Sea Level mapgen string https://github.com/OpenTTD/OpenTTD/pull/10148 16:35:06 <LordAro> glx[d]: read the next line :p 16:35:25 <glx[d]> Yeah I saw 16:36:44 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #10148: Codechange: Fix improperly named Sea Level mapgen string https://github.com/OpenTTD/OpenTTD/pull/10148#pullrequestreview-1172476669 16:40:56 <DorpsGek> [OpenTTD/OpenTTD] ldpl commented on pull request #10004: Fix: Don't stop growth attempt if house is not allowed https://github.com/OpenTTD/OpenTTD/pull/10004#issuecomment-1307507775 16:42:59 <petern> Hmm, starting to get cold indoors 17:12:19 <andythenorth> slippers 17:22:30 <DorpsGek> [OpenTTD/OpenTTD] btzy updated pull request #8425: Feature: Contextual actions for vehicles grouped by shared orders https://github.com/OpenTTD/OpenTTD/pull/8425 17:24:40 <DorpsGek> [OpenTTD/OpenTTD] btzy commented on pull request #8425: Feature: Contextual actions for vehicles grouped by shared orders https://github.com/OpenTTD/OpenTTD/pull/8425#issuecomment-1307570127 17:35:17 <petern> I bought some slipper-socks but they don't fit 😦 17:36:16 <petern> Where do I need to declare my global variable so that I can use it in `misc_settings.ini`? _gui_scale works, I guess via the jungle of header dependencies... 17:37:37 <Rubidium> petern: shouldn't it be in the GUISettings objects (settings_type.h)? 17:37:57 <Rubidium> at least if you're talking about bunky chezels 17:40:09 <petern> Perhaps. Should I move `_gui_scale_cfg` there too? Though `_gui_scale` is separate as the config option doesn't have to be the actual value. 17:44:45 <andythenorth> I had slipper socks for a bit 17:44:47 <andythenorth> they're weird 17:44:56 <andythenorth> then I fell down the stairs because of them 17:44:59 <andythenorth> slippery socks 17:45:05 *** Wormnest has joined #openttd 17:48:11 <petern> These have the little non-slip dots. 17:51:40 * petern builds 17:59:07 <petern> Okay, that's... interesting. The initial NewGRF scan is done before settings are loaded, so that window has unscaled bevels. Then the bevels are scaled for the intro menu. 18:01:03 <petern> The misc_settings are loaded earlier. 18:06:13 <supermop_toil> andythenorth: the socks with rubber on the bottom? 18:06:49 <supermop_toil> never seemed to work that well for me 18:08:31 <andythenorth> yeah 18:08:38 <andythenorth> they grip the floor, but not your feet 18:08:47 <andythenorth> such life discussions 18:09:19 <petern> Well I can't take them back because in the microsecond after I had brought them into the house, they acquired a shit-ton of dog hairs... 18:12:18 <DorpsGek> [OpenTTD/O