Times are UTC Toggle Colours
10:42:00 <TrueBrain> michi_cc[d]: I can see what I can do to resolve that issue today. Given I have no additional input, I am just going to spin the wheel and pick what-ever 😛 10:42:28 <andythenorth[d]> 1 in 3 chance 10:43:05 * andythenorth[d] wonders if this is a Monty Hall game 10:43:16 <TrueBrain> but let's first make a nice little place for the backport stuff .. new repo? I guess that is best .. 10:43:31 <andythenorth[d]> oof I am supposed to be doing chores, but I want to nap 10:43:45 <TrueBrain> sounds like a you problem 😛 10:43:49 <andythenorth[d]> very 10:49:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #10420: Backport master into release/13 https://github.com/OpenTTD/OpenTTD/pull/10420#issuecomment-1407372190 11:01:51 <TrueBrain> michi_cc[d]: : so you just wanted to check if there is a label "backport squash" in the list, right? 11:03:11 <michi_cc[d]> Yeah, if the label is present, just pick the one commit, not the amount indicated in the PR itself. 11:03:14 <TrueBrain> you were like really close with a proper solution 🙂 The `next()` part only is a bit silly 😉 11:03:20 <TrueBrain> `if any(True for node in pr["node"]["labels"]["nodes"] if node["name"] == "backport squash"):` or something would be more readable 🙂 11:03:45 <michi_cc[d]> I think I tried any first, but I couldn't get it to do what I want 11:04:03 <TrueBrain> you now return a list, and with `next()` check if the first element is not None 11:04:14 <TrueBrain> with `any` you check if the returning list contains anything 'true-ish' 11:04:29 <michi_cc[d]> But I think I didn't try your line, because neither Google nor SO had it :p 11:05:09 <TrueBrain> odd 🙂 Pretty common ... 😛 11:05:35 <michi_cc[d]> There was something with any, but it looked slightly different and didn't work 🙂 11:06:47 <michi_cc[d]> (Can you tell I don't do Python? :p ) 11:06:59 <TrueBrain> you got pretty far for someone who doesn't 11:07:09 <TrueBrain> most don't get even close to such list statements 😛 11:07:30 <andythenorth[d]> can't chatGPT write it? 😛 11:08:41 <michi_cc[d]> I searched for "python find element in list of dicts" and <https://stackoverflow.com/questions/8653516/python-list-of-dictionaries-search> is the first hit 🙂 11:09:35 <andythenorth[d]> lots of python golf in that SO 11:09:47 <TrueBrain> oof, such a weird suggestion for that use-case .. but what-ever floats people's boat 😛 11:10:03 <andythenorth[d]> black ruins some python golf games 11:11:07 <TrueBrain> still surprised that backport script actually works in so many cases 😄 11:14:20 <michi_cc[d]> One thing still missing in my script is that it should probably remove the "backport squash" as well when updating that tags for --mark-done. 11:14:57 <TrueBrain> https://github.com/OpenTTD/scripts/pull/2 11:15:04 <TrueBrain> I now at least put it at a place where we can PR things 🙂 11:16:40 <michi_cc[d]> Ah, no appropriate permission 🙂 11:17:40 <TrueBrain> you are now a backend horse 😛 11:19:22 <TrueBrain> right, now for the release flow ... did we ever do a vote on whether to keep those pesky linux distros? 11:19:32 <TrueBrain> I should check how often they are downloaded I guess .. 11:19:39 <TrueBrain> they also break a lot ... 11:22:38 *** WormnestAndroid has quit IRC 11:24:37 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #10420: Backport master into release/13 https://github.com/OpenTTD/OpenTTD/pull/10420#issuecomment-1407378147 11:25:44 <michi_cc[d]> TrueBrain: I privmsg orudge for #10301 and he just said he'd have a look. 11:25:55 <TrueBrain> cheers 11:26:05 <TrueBrain> one downside of Discord .. no privmsg on IRC 😛 11:26:20 <michi_cc[d]> Well, even worse, I used tt-forums 🙂 11:26:24 <Rubidium> TrueBrain: just remove the EOL ones (i.e. Buster and Bionic), and next cycle or the one after it the other two are EOL and they're gone ;) 11:26:24 <TrueBrain> haha 11:26:43 <TrueBrain> I mainly need to know what his intentions are btw; the work we can do just fine 🙂 11:29:00 <TrueBrain> lol, the access-logs are stored in a single directory .. I assumed AWS would put them in sub-folders 11:29:02 <TrueBrain> it didn't 😛 11:29:27 <TrueBrain> few years of files in a single folder ... lovely 😄 11:31:07 <andythenorth[d]> chores done, nap or tanks or make GS minigames? 😛 11:33:09 <TrueBrain> lol, so in April last year, people actually downloaded OpenTTD 0.1.1 etc 😛 11:34:10 <TrueBrain> 23k Windows downloads, 3k MacOS downloads, and 3k Linux .deb downloads 11:34:14 <TrueBrain> people actually download those files 11:34:18 <TrueBrain> I am a bit surprised 😛 11:35:09 <DorpsGek> [OpenTTD/OpenTTD] orudge commented on issue #10301: [Bug]: GitHub Actions Release workflow publishes too many files to the CDN https://github.com/OpenTTD/OpenTTD/issues/10301 11:36:10 <TrueBrain> good; that is an easy fix 11:38:44 <Eddi|zuHause> how does that compare to steam download numbers? 11:54:43 <petern> Morning 11:55:30 <TonyPixel> Wow, orudge 12:09:45 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #10421: Codechange: pass large objects by reference instead of value https://github.com/OpenTTD/OpenTTD/pull/10421 12:14:44 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #10422: Remove: Ubuntu/Debian release binaries (instead, use the Generic) https://github.com/OpenTTD/OpenTTD/pull/10422 12:16:47 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #10422: Remove: Ubuntu/Debian release binaries (instead, use the Generic) https://github.com/OpenTTD/OpenTTD/pull/10422 12:20:23 <michi_cc[d]> I guess for Linux something like Flatpak would be more useful than various distro-specific releases. 12:20:35 <TrueBrain> the Generic version also works very well, from what I can tell 12:21:14 <TrueBrain> it is a manylinux2014 12:21:21 <TrueBrain> so any OS newer than 2014, works, basically 12:21:56 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #10421: Codechange: pass large objects by reference instead of value https://github.com/OpenTTD/OpenTTD/pull/10421#pullrequestreview-1273912524 12:23:11 <michi_cc[d]> The advantage would be if we'd publish to Flathub. 12:23:40 <TrueBrain> similar could be said about snap, and the tons of other eco-systems that have been created over the last few years 12:24:02 <TrueBrain> we tried flatpack a while back; it was a bit of a nightmare in more than one way 😛 12:25:25 <TrueBrain> ah, yes, flatpack builds for specific Linux OSes, that was the annoying part there 12:25:34 <TrueBrain> so still something for us to visit every release, to see if things have changed 12:28:35 <petern> Odd, I thought part of the point of flatpak was to avoid that. 12:29:08 <TrueBrain> used for the "testing" part in the flatpack definition in the last PR we got from it 12:29:52 <TrueBrain> but in fairness, that was a while ago 12:30:04 <TrueBrain> it also only build for x86_64, so that is a bit dated anyway 😛 12:33:43 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #10422: Remove: Ubuntu/Debian release binaries (instead, use the Generic) https://github.com/OpenTTD/OpenTTD/pull/10422 12:43:26 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #10421: Codechange: pass large objects by reference instead of value https://github.com/OpenTTD/OpenTTD/pull/10421 13:04:21 <TrueBrain> pff, making changes to the release workflow is tricky .. hard to test 😛 13:04:28 <TrueBrain> and slow to test ... 13:27:46 <andythenorth[d]> https://tenor.com/view/hug-gif-25569675 13:27:53 <andythenorth[d]> inappropriate? probs 13:28:13 <TrueBrain> is it okay if I don't click that? 😛 13:29:08 <andythenorth[d]> oh it's clickable? 13:29:18 <andythenorth[d]> yeah it just lightboxes 13:29:30 <Merni> lightboxes? 13:29:39 <andythenorth[d]> expands the image 13:33:21 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #10422: Remove: [Actions] Ubuntu/Debian release binaries (instead, use the Generic) https://github.com/OpenTTD/OpenTTD/pull/10422#issuecomment-1407400211 13:33:55 <TrueBrain> "duplicate dep", well, that is lovely cryptic 😛 13:34:17 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #10406: Codechange: add annotation to selectively force inlining in debug build https://github.com/OpenTTD/OpenTTD/pull/10406 13:34:42 <TrueBrain> but yeah, for sure not for that PR 😛 Lol 🙂 13:34:49 <TrueBrain> I randomly triggered glx[d] 😛 😄 13:36:44 <TrueBrain> but yes, will remove the duplicated dependency thingy in the apt-get in my next PR 😉 13:57:45 *** TROILUS has quit IRC 13:58:40 <TrueBrain> takes ~20 minutes per attempt to make Windows Store work the way I want .. lol 13:59:05 <Merni> Do people actually use windows store? 14:00:04 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #10420: Backport master into release/13 https://github.com/OpenTTD/OpenTTD/pull/10420 14:01:44 <michi_cc[d]> I'd assume there are stats somewhere, but probably only accessible by orudge. 14:02:26 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #10423: Fix several cases where global pointer outlives stack reference https://github.com/OpenTTD/OpenTTD/pull/10423 14:04:29 <TrueBrain> it does detect crashes 😛 14:05:02 <TrueBrain> ~100 downloads a week on Windows Store 14:05:05 <TrueBrain> so better than GOG 😛 14:05:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #10414: Codechange: use RAII to automatically restore _cur_dpi after use https://github.com/OpenTTD/OpenTTD/pull/10414 14:05:47 <TrueBrain> ~150 active sessions per day via Windows Store 14:06:19 <TrueBrain> vs 600 on Steam 14:06:27 <TrueBrain> well, no, Steam is peak 14:06:31 <TrueBrain> Windows Store is total 14:11:49 *** Soni has quit IRC 14:13:04 *** Soni has joined #openttd 14:19:47 <TrueBrain> michi_cc[d]: PS: you can access those stats too 😉 Login details are in 1password 🙂 14:21:34 *** Soni has quit IRC 14:23:26 *** Soni has joined #openttd 14:28:32 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #10423: Fix several cases where global pointer outlives stack reference https://github.com/OpenTTD/OpenTTD/pull/10423 14:29:36 *** D-HUND is now known as debdog 14:30:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #10380: Hide Tile and TileExtended implementation details inside Map structure https://github.com/OpenTTD/OpenTTD/pull/10380 14:33:09 <michi_cc[d]> TrueBrain: Nope, you only gave me the Socials vault. 14:33:18 <TrueBrain> I did?! 😮 14:33:19 <TrueBrain> I suck 14:36:11 <TrueBrain> right, seems windows-store will now work fine .. guess I should add automated GOG upload too .. 14:36:36 <TrueBrain> just how to test it .. long waiting times ahead .. 😛 14:48:38 <TrueBrain> an installer that asks to accept the license, which uses a `read` ... eeeuuuhhh .. that is tricky to automate 😛 14:53:21 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #10380: Hide Tile and TileExtended implementation details inside Map structure https://github.com/OpenTTD/OpenTTD/pull/10380 14:59:13 <DorpsGek> [OpenTTD/OpenTTD] github-code-scanning[bot] commented on pull request #10423: Fix several cases where global pointer outlives stack reference https://github.com/OpenTTD/OpenTTD/pull/10423#pullrequestreview-1273938127 15:02:50 *** Soni has quit IRC 15:05:13 *** Soni has joined #openttd 15:06:14 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #10422: Change: [Actions] several improvements for the release workflow https://github.com/OpenTTD/OpenTTD/pull/10422 15:06:41 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #10422: Change: [Actions] several improvements for the release workflow https://github.com/OpenTTD/OpenTTD/pull/10422 15:08:52 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #10423: Fix several cases where global pointer outlives stack reference https://github.com/OpenTTD/OpenTTD/pull/10423#pullrequestreview-1273940587 15:10:07 <michi_cc[d]> Soooo, 13.0-RC2 or 13.0??? 15:11:08 <TrueBrain> okay, doing some final testing on the release workflow .. I -think- it mostly works 15:11:14 <TrueBrain> but it is really hard to actually test without making a release 15:12:23 <TrueBrain> as in, I cannot just publish a new version on GOG to "test it out" 😛 That would be a bit weird, for people to receive some random master version out of nowhere 😄 15:17:09 <Rubidium> sounds like RC2 15:18:03 <Rubidium> and if everthing's working right and whne no major issues show up a release on say the first that is just retagging 13.0-RC2 as 13.0 15:18:14 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #10422: Change: [Actions] several improvements for the release workflow https://github.com/OpenTTD/OpenTTD/pull/10422#pullrequestreview-1273942351 15:18:46 <TrueBrain> hmm, one minor issue with GOG at least ... 15:19:55 <TrueBrain> let's just download 13.0-RC1 for testing GOG flow .. instead of my current attempts 😛 15:20:21 <TrueBrain> why does OpenTTD take so long to build again? 🙂 15:20:51 <TrueBrain> having a password with a `>` in it, turns out to be somewhat nasty for CLIs 😛 15:20:54 <glx[d]> 3 windows binaries, 2 macos 15:21:49 <michi_cc[d]> Okay, Rb volunteered to run the proper release run next weekend :p 15:25:11 <Rubidium> if only I would be near home and would actually know how to ;) 15:25:38 <TrueBrain> good news! The "how to" is extremely easy; even documented on the wiki! 15:27:26 <glx[d]> a lot of magic is done with just a button on github 🙂 15:29:51 <TrueBrain> okay .. GOG upload for Linux works 15:29:52 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #10422: Change: [Actions] several improvements for the release workflow https://github.com/OpenTTD/OpenTTD/pull/10422#pullrequestreview-1273942351 15:29:56 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #10422: Change: [Actions] several improvements for the release workflow https://github.com/OpenTTD/OpenTTD/pull/10422 15:29:57 <TrueBrain> didn't test the rest, but .. pretty sure it works too 😛 15:31:03 <TrueBrain> nevertheless, will do a test-run 15:31:16 <TrueBrain> will take an hour .. going out for dinner .. so if it works, will merge the above PR later tonight 😄 15:34:01 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #10301: [Bug]: GitHub Actions Release workflow publishes too many files to the CDN https://github.com/OpenTTD/OpenTTD/issues/10301 15:34:27 <TrueBrain> owh, and it might be that the next release breaks some of our tooling; either the CDN generator or our website