Times are UTC Toggle Colours
00:34:03 *** Soni has quit IRC 00:37:54 *** Soni has joined #openttd 00:38:23 *** Wormnest has quit IRC 01:05:57 *** Wormnest has joined #openttd 01:42:36 *** WormnestAndroid has quit IRC 01:42:41 *** WormnestAndroid has joined #openttd 01:58:38 *** Wormnest has quit IRC 02:15:46 *** Wormnest has joined #openttd 02:46:45 *** D-HUND has joined #openttd 03:31:48 *** keikoz has joined #openttd 03:41:29 *** D-HUND is now known as debdog 06:58:01 *** gelignite has joined #openttd 07:05:06 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #10618: Change: Allow overbuilding station and waypoint tiles https://github.com/OpenTTD/OpenTTD/pull/10618#pullrequestreview-1386714658 07:05:09 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler merged pull request #10618: Change: Allow overbuilding station and waypoint tiles https://github.com/OpenTTD/OpenTTD/pull/10618 07:33:25 *** sla_ro|master has joined #openttd 07:54:08 <dwfreed> is there a reason the windows release process signs twice? 07:54:56 <dwfreed> or maybe I'm not reading this quite right? I guess the CMake one is the actual game exe and the one in GH Actions is actually the installer part 08:12:16 <LordAro> dwfreed: does seem to be very duplicatey 08:14:02 <Rubidium_> well, the main question is whether openttd.exe is signed. The github workflow does not seem to extract and repackage files, just sign the bundle results that are executables (i.e. the installers) 08:14:43 <Rubidium_> so, if openttd.exe is signed, then the other signing is for the actual game executable. Otherwise you'd be signing the installer twice, so I hope it's the former 08:14:43 <LordAro> ah yes, of course 08:15:01 <dwfreed> the cmake signing appears to be for openttd.exe 08:15:26 <dwfreed> the signing in the GH workflow thus appears to be the installers 08:16:01 <dwfreed> https://github.com/OpenTTD/OpenTTD/blob/master/cmake/InstallAndPackage.cmake#L144-L149 08:17:18 <Rubidium_> yes, both openttd.exe and the installer are signed. So it is indeed for the game and installer executables 08:25:16 *** nielsm has joined #openttd 08:29:22 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on issue #10646: [Bug]: Console Doesn't Close on multiplayer games https://github.com/OpenTTD/OpenTTD/issues/10646 08:39:02 <DorpsGek> [OpenTTD/OpenTTD] LordAro opened pull request #10659: Codechange: Reduce number of seprintf calls in FormatNumber https://github.com/OpenTTD/OpenTTD/pull/10659 08:47:57 <LordAro> ha 08:48:16 <LordAro> forced opntitle to use YAPF instead of NPF - runtime drops from 3.5s to 2.4s 08:48:50 <Eddi|zuHause> is that a thing we need to optimize? 08:49:22 <Eddi|zuHause> and shouldn't we optimize that by throwing out NPF? 08:49:38 <LordAro> probably, yes 08:50:11 <jfs-> the main criticism against YAPF is probably that it's hard to follow because of all the templates and stuff 08:50:30 <Eddi|zuHause> and that affects like 3 people? 08:50:49 <jfs-> as long as it works, it only matters for developers yes 08:51:41 <JGR> The YAPF code is well written and not significantly harder to follow than the NPF code really 08:52:36 <Rubidium_> less is more, and removing NPF removes some 'local variable address stored in non-local memory' warnings 08:57:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #10659: Codechange: Reduce number of seprintf calls in FormatNumber https://github.com/OpenTTD/OpenTTD/pull/10659#issuecomment-1510200226 09:02:54 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on pull request #10659: Codechange: Reduce number of seprintf calls in FormatNumber https://github.com/OpenTTD/OpenTTD/pull/10659#issuecomment-1510204136 22:45:16 <petern> Yup, it is 22:48:20 <glx[d]> https://github.com/OpenTTD/OpenTTD/compare/master...glx22:OpenTTD:str_fmt <-- good idea or does it first require more char* to std::string conversion in BaseSet struc ? 22:53:17 <petern> Oh, I see the difference. 22:53:57 *** audigexJon has quit IRC 22:54:47 <petern> Redefining the same house ID no longer copies over the substitute type after the one definition. Oops. 22:55:14 <TrueBrain> bad reviewers 😛 22:55:15 <TrueBrain> 😄 22:57:17 <petern> Bad developer 22:59:50 <petern> For all the other newgrf features, it only copies on the initial definition, just houses it was different. 23:00:16 <glx[d]> there's always a feature doing things differently 23:00:48 <glx[d]> (like stations defining layout in action 0) 23:00:50 <petern> otoh, it's a unique_ptr, so I can just remove the nullptr check. 23:01:01 <petern> Yeah, that was designed before all the rest 23:04:39 <petern> I'm not convinced this isn't a bug either. 23:06:43 <petern> > Only the first property 08 setting copies properties; if you later change it, properties will stay. 23:06:46 <petern> Well no. 23:07:31 <petern> We can do that too. 23:11:02 <petern> > House flags 40 and 80 are exceptions; these flags are never set automatically. 23:11:09 <petern> We don't clear those either. 23:11:19 <DorpsGek> [OpenTTD/OpenTTD] nielsmh updated pull request #9984: Add various user folders to the file browser windows https://github.com/OpenTTD/OpenTTD/pull/9984 23:13:35 <petern> So my change is wrong, but the original code is not to spec either. 23:15:24 <jfs-> so why did I stay up to 1 am on a sunday night to code a parser for a boring file format 23:16:44 <jfs-> I at least hope it won't crash anyone 23:17:32 <jfs-> oh, looks like emscripten also needs special treatment for this 23:19:55 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on pull request #9984: Add various user folders to the file browser windows https://github.com/OpenTTD/OpenTTD/pull/9984#issuecomment-1510515951 23:25:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #10669: Fix #10627: Houses subsitute specs should only be copied on first definition. https://github.com/OpenTTD/OpenTTD/pull/10669 23:25:38 <petern> jfs-: it's "fun" 23:26:12 *** sla_ro|master has quit IRC 23:27:25 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10669: Fix #10627: Houses subsitute specs should only be copied on first definition. https://github.com/OpenTTD/OpenTTD/pull/10669 23:27:35 <petern> Some of my reindenting went wrong 🙂 23:31:59 *** nielsm has quit IRC 23:49:55 <DorpsGek> [OpenTTD/OpenTTD] github-code-scanning[bot] commented on pull request #9984: Add various user folders to the file browser windows https://github.com/OpenTTD/OpenTTD/pull/9984#pullrequestreview-1387100209 23:57:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #10669: Fix #10627: Houses subsitute specs should only be copied on first definition. https://github.com/OpenTTD/OpenTTD/pull/10669#issuecomment-1510524137 23:57:56 <petern> I keep reading reindenting as reindeering... :/