Times are UTC Toggle Colours
00:07:30 *** Wolf01 has quit IRC 00:09:01 <_glx_> digitalsoma: I'm not sure how to do it in vscode, but you set cmake variable in configuration file for openttd (I do it in CMakePresets.json, but it can be done with CMakeSettings.json too) 00:43:20 *** Flygon has quit IRC 00:53:06 <digitalsoma> I'll look into those for vscode, thanks! 01:46:53 <digitalsoma> Ok, with Visual Studio 2022, I was able to get it to find the libraries listed under compiling.md. However, Cmake "Could NOT find Grfcodec (missing: GRFCODEC_EXECUTABLE GRFID_EXECUTABLE NFORENUM_EXECUTABLE)". 01:46:53 <digitalsoma> Also, in the CMake output, it says it found zlib and the package is compatible with the targets, but in the CMakeSettings.json, under variables, the "name": "zlib_include_dir" has "value": "zlib_include_dir-notfound" and the CMAKE_TOOLCHAIN_FILE has a "property name not allowed by schema" warning. Are these issues I have to resolve? 02:21:16 <_glx_> grfcodec and nforenum are not required, unless you want to modify openttd.grf (you don't want 😉 ) 02:27:16 <digitalsoma> Thank you 02:32:28 *** tokai|noir has joined #openttd 02:32:28 *** ChanServ sets mode: +v tokai|noir 02:39:08 *** tokai has quit IRC 04:48:33 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/5b02f51e1796d85611c30566857e1b874966254a 04:48:34 <DorpsGek> - Update: Translations from eints (by translators) 05:06:26 *** keikoz has joined #openttd 06:17:29 *** keikoz has quit IRC 06:58:36 <DorpsGek> [OpenTTD/OpenTTD] Kuhnovic approved pull request #13122: Fix #13121: Crash when clicking on scrollbar if contents don't need scrolling. https://github.com/OpenTTD/OpenTTD/pull/13122#pullrequestreview-2457365598 07:17:37 <DorpsGek> [OpenTTD/survey-web] survey-summary[bot] pushed 1 commits to main https://github.com/OpenTTD/survey-web/commit/ea7a84c4a25b0cb02b935393032474fa1a29cfc1 07:17:38 <DorpsGek> - Add: summary for week 47 of 2024 (by OpenTTD Survey) 07:37:51 *** D-HUND has quit IRC 08:20:25 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13122: Fix #13121: Crash when clicking on scrollbar if contents don't need scrolling. https://github.com/OpenTTD/OpenTTD/pull/13122 08:20:28 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #13121: [Crash]: Clicking on scrollbars and other scrollbar-related actions crash since #13119 https://github.com/OpenTTD/OpenTTD/issues/13121 09:30:51 *** Flygon has joined #openttd 10:18:16 <peter1138> [2024-11-25 10:17:54] dbg: [sprite:3] ReserveSpriteCache: Reserved capacity for 557594 sprite cache entries (22303760 bytes) 10:18:27 <peter1138> [2024-11-25 10:18:01] dbg: [sprite:1] 554287 total sprites, 1248 extra sprites, 93 from baseset, 1155 from fallback 10:18:38 <peter1138> Close. 10:44:29 <xarick> hi 10:46:40 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1310557261751652422/image.png?ex=6745a710&is=67445590&hm=58cb21789902fd1eb6878baa6516f41f8e2d7e1bf73bc0f5dbf473355c8d6a31& 10:46:40 <xarick> almost there 10:56:35 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1310559759216279592/Captura_de_ecra_2024-11-25_105539.png?ex=6745a963&is=674457e3&hm=a834fe09da802a21de8ce609c3a0d2768a2c1f0c9a47d91c77d0979d40e314e6& 10:56:36 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1310559759510016032/Captura_de_ecra_2024-11-25_105553.png?ex=6745a963&is=674457e3&hm=45932f5a89f408d28d75ba8e9d6f3b11cda39c7a0f0cc4137b5a5f335f06f963& 10:56:36 <xarick> the widening is not widening enough 11:00:06 <xarick> im bad at this 11:01:03 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1310560880726904844/image.png?ex=6745aa6f&is=674458ef&hm=076b0c415163731bfa9a095fc8341c847c8c8c59dce111bb8f1b17613d805e09& 11:01:03 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1310560881087877120/image.png?ex=6745aa6f&is=674458ef&hm=cf0e85cb122d25e8c99a2dafcaa0028b264f5e226580c41db080c1f738b3ac69& 11:01:03 <xarick> talltyler: would be disappointed 11:10:08 *** keikoz has joined #openttd 11:14:14 <xarick> ah, fixed it 11:50:14 *** XYZ has quit IRC 11:51:25 <peter1138> What about your crash? 11:54:48 <xarick> it was me 11:55:05 <xarick> i was getting the tile height of the wrong thing 11:55:28 *** XYZ has joined #openttd 12:18:48 <exceptik> ah, reminds me of road ownerships with 500 companies 😆 when using already existing bits in tile data aint a great idea 12:23:12 <peter1138> "Just change MAX_COMPANIES" 12:23:28 <xarick> i got a small problem 12:24:04 *** SigHunter has quit IRC 12:24:15 <xarick> tropic generator needs to look for water to know whether to set a tile rainforest 12:24:36 <xarick> but at this stage, with my changes, there is no sea 12:25:14 <xarick> GetTileZ(tile) == 0 does the same thing, but it costs a lot of performance 😦 12:25:23 <xarick> what alternatives do i have? 12:26:43 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1310582441962111056/image.png?ex=6745be83&is=67446d03&hm=e781f5bd4158b2e5d93fdbc47b60f3e53d4902b94aab8c49e5d586bf4072da21& 12:26:44 *** SigHunter has joined #openttd 12:27:23 <peter1138> Do the tropic generator later. 12:28:05 <xarick> hmm, might try that 12:48:42 *** merni has joined #openttd 12:48:42 <merni> xarick: What a dystopian world 12:58:46 *** XYZ has quit IRC 13:05:53 <xarick> it is a strategy I found to counteract terraforming on water tiles 13:06:37 *** XYZ has joined #openttd 13:13:48 <xarick> bad news 13:14:33 <xarick> can't postpone desert/rainforest generation after river generation because river generation needs to know where are the rainforest to place a spring 13:19:47 <peter1138> Ooh, chicken & egg 13:25:35 *** asymptotically2 has quit IRC 13:30:23 <xarick> I have a tendency to make unneeded changes 13:30:31 <xarick> just because it would look better 13:37:47 <xarick> something akin to... "if IsTileFlat can return the height of the tile and there is another TileHeight on the tile, why not change the code so the height is only done once?". 13:38:07 <xarick> then this inflates the diff 13:38:39 <xarick> then ppl complain about "irrelevant" change 13:38:55 *** toktik has quit IRC 13:39:11 *** toktik has joined #openttd 13:39:57 *** asymptotically2 has joined #openttd 13:57:28 *** keikoz has quit IRC 14:08:00 <peter1138> Maybe you need to set dependabot up properly? 14:09:42 <peter1138> I know nothing about it, but it should only be running against your main branch. 14:10:04 <peter1138> (In my limited understanding of what it does) 14:12:30 <_glx_> yeah only current version should be checked, and if upgrade is needed on release then you do a new release 14:33:00 <peter1138> Back to fighting Bootstrap's grid system. 14:34:05 <peter1138> I want 3 columns, "a, b, c", unless the screen is too narrow, in which case I want two columns, with c below b, "a, b/c" 14:34:50 <peter1138> But also "a" may not exist, in which case "b, c" is good unless the screen is very narrow. 14:37:36 *** keikoz has joined #openttd 14:42:09 *** nielsm has joined #openttd 14:46:42 <xarick> there is no GetTileSlopeMaxZ 😦 14:52:29 <xarick> not sure I invent it 14:56:03 <peter1138> Hmm, I need col-md-6 or col-md-4 depending on what else is visible. This system sucks. 15:04:35 <xarick> there are stalls during town generation 15:04:48 <LordAro> peter1138: css grid clearly 15:04:57 <peter1138> Yes. 15:12:02 <peter1138> Yeah, already working much better. 15:12:50 <peter1138> Although I think I still need two layouts for the optional column a. 15:14:46 <xarick> what is the official english word for river connection to the sea? 15:14:54 <xarick> enters the sea 15:15:20 <xarick> inclined slope of river with tile height 0 15:15:36 <merni> xarick: estuary? 15:15:47 <xarick> oh ok might be it 15:15:51 <merni> mouth? 15:16:09 <merni> mouth is more general 15:17:16 <kuhnovic> Delta? 15:20:28 <xarick> > Change: Postpone sea conversion to after river generation 15:20:28 <xarick> > 15:20:28 <xarick> > To ensure that rivers get properly widened at the mouth via a terraforming command that can't destroy water, postpone conversion of the tiles at level 0 to after river generation. 15:20:49 <xarick> something's missing 15:23:14 <xarick> Copilot for the rescue 15:23:18 <xarick> > Change: Postpone sea conversion to after river generation 15:23:18 <xarick> > 15:23:18 <xarick> > To ensure that rivers are properly widened at the mouth using a terraforming command that doesn't affect water, postpone the conversion of land tiles at height level 0 to sea tiles until after river generation. This change ensures that the river widening process is not disrupted by premature sea conversion. 15:23:59 <xarick> sounds good 15:24:36 <xarick> I'm surprised it kept the word "terraforming" 15:28:58 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13120: Fix #10452: Disconnection of rivers https://github.com/OpenTTD/OpenTTD/pull/13120 15:30:26 *** XYZ has quit IRC 15:33:35 <xarick> generating tropic is now slower, enjoy 15:36:18 <xarick> trying to figure a way to make it not slower 15:41:19 <xarick> 1 check was no successful 15:41:55 <_glx_> it's the usual stuff, you add more "details" which implies more things to do, so it's slower 15:48:35 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13120: Fix #10452: Disconnection of rivers https://github.com/OpenTTD/OpenTTD/pull/13120 16:04:35 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1310637269681573989/image.png?ex=6745f193&is=6744a013&hm=2bbd2354b5fae9120d98a6bf41569700c2373c3424ca6b6ce6da5d10c8e24ed4& 16:04:35 <xarick> that's bad... 16:05:14 <xarick> 3 times slower at CreateDesertOrRainForest 16:10:32 <xarick> hmm it's not even doing a 100% match 16:10:38 <xarick> without any river 16:10:42 <xarick> i failed 16:12:29 <xarick> oh, only the tropic isn't 16:12:32 <xarick> less bad 16:14:29 <peter1138> We've never really focused on making sure game seeds produce the same world. 16:17:03 <kuhnovic> Self-imposed requirements 16:19:09 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1310640934840438875/image.png?ex=6745f4fd&is=6744a37d&hm=06de8f798b79796e96fabb1aada8d20aca7be91a5122ace783dfd64ebd35bee7& 16:19:09 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1310640935213994115/image.png?ex=6745f4fd&is=6744a37d&hm=7e47031ffc4b35e56999d1c6d3e2fe891b04e9585a8ee0f5fc1e7487289d577c& 16:19:09 <xarick> hmm yeah, there are differences 16:23:33 *** benjaminv has joined #openttd 16:24:53 <peter1138> The TGP tropical zone selection is actually really bad anyway. 16:51:36 <peter1138> The original generator's strategy of making the map half rain forest, half desert worked fine. At 256x256. 17:06:12 <mnhebi> I mean if you really wanted to model how deserts form in real life you'd take a year to generate a map :3 17:09:33 <mnhebi> https://en.wikipedia.org/wiki/Atacama_Desert is the place to look at if you want to make a simplified model 17:26:51 <DorpsGek> [OpenTTD/OpenTTD] JGRennison opened pull request #13123: Codefix: Avoid divide by 0 in div/mod type varaction2 adjusts https://github.com/OpenTTD/OpenTTD/pull/13123 17:36:58 *** Wolf01 has joined #openttd 17:40:08 <xarick> I have a suspicion trees are getting in the way 17:41:52 <xarick> ah, no, actually not 17:43:05 <xarick> I solved the problem with brute force 17:43:17 <xarick> or brute checking 17:44:44 <xarick> probably an even slower tropic gen as a result, but now it 100% matches 17:49:38 <xarick> yep... 0.4 seconds more required 17:56:29 <xarick> now I am wondering which tiles were not matching GetTileZ != 0 18:00:36 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1310666464600129637/image.png?ex=67460cc4&is=6744bb44&hm=b225802cf148b3ac43e5702b1696963943166cf8d840a7c510905154a182c6f8& 18:04:53 <xarick> oh crap void tiles 18:05:02 <xarick> why was it so obvious?... 18:05:11 <xarick> why didn't I think of them 18:12:50 <xarick> hmm apparently there's more 18:12:54 <xarick> it's not just void 18:25:06 <xarick> oh, I see... 18:25:27 <xarick> it's one of those 3 corner raised slopes 18:25:57 <xarick> special casing 18:26:29 <xarick> it may or may not be converted to sea depending on the slopes surrounding it 18:27:49 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1310673314867445851/image.png?ex=67461325&is=6744c1a5&hm=d2c9b37882bdbd58b898cbfd5b8044045331bc77060306b5fc1d5a6fdcf0e2d4& 18:28:06 <xarick> it's at sea level, but it's not sea 18:28:13 <xarick> and is not converted to sea 18:28:41 <xarick> GetTileZ however gives me a 0 18:34:03 *** nielsm has quit IRC 18:34:15 *** gelignite has joined #openttd 19:59:34 <peter1138> IMHO, EndSegmentReason and EndSegmentReasonBits are reversed. 20:05:54 <xarick> can I edit "table/genland.h" 20:06:12 <xarick> I have an "optimization" idea 20:09:03 <xarick> it the diffs become ordered, then on Map::Iterate(), i only need to iterate the diffs once. the next tile from map::iterate would only be requiring to check the last item on those diffs 20:09:29 <xarick> or i might be wrong 20:10:54 <xarick> I think I'm wrong 20:11:28 <xarick> the last item of a X coordinate, or all X items if I switch to the next Y 20:22:43 <xarick> what's cheaper, faster? Tile(t) or t.base()? 20:28:20 *** Wormnest has joined #openttd 20:36:46 <_glx_> check assembly output 20:49:12 <xarick> ^_^ 20:49:18 <xarick> don't know how to use that 20:50:05 <xarick> I'm in the process of removing redundant code from RiverMakeWider 20:50:43 <xarick> there was a lot of care about water tiles which I believe DC_NO_WATER solves, so some code needs clean up 20:59:28 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13120: Fix #10452: Disconnection of rivers https://github.com/OpenTTD/OpenTTD/pull/13120 21:31:55 <xarick> i found a very strange assert 21:34:16 <xarick> oohhhh... I forgot that edge tiles actually flood during map gen 21:34:50 <xarick> makedesert stuff runs a tile loop for a bit, enough to create sea 21:34:59 <xarick> dang 21:35:39 <xarick> what an annoyance 21:54:34 <peter1138> Hmm, this station thing is annoying. 22:04:55 <xarick> im gonna turn this into a 22:05:03 <xarick> draft 22:05:24 <xarick> there's more than meets the eye 22:06:36 *** gelignite has quit IRC 22:07:42 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13120: Fix #10452: Disconnection of rivers https://github.com/OpenTTD/OpenTTD/pull/13120 22:16:24 *** Wolf01 has quit IRC 22:19:07 *** Wormnest has quit IRC 22:21:28 *** keikoz has quit IRC 22:22:36 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1310732398450704436/image.png?ex=67464a2c&is=6744f8ac&hm=f5f7a911930de2630ed278167368c7c98c3c91443f0cbbc2e99789d332d74eb6& 22:22:36 <peter1138> Hmm 22:24:33 <peter1138> Also, where did the limping behaviour come from? 22:24:54 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1310732977977950248/Screencast_from_2024-11-25_22-24-11.webm?ex=67464ab6&is=6744f936&hm=abc27c7cb57e8f241ea5972c24980fa3f45efeb16163f772561f3a69acb253de& 22:26:50 <peter1138> Hmm, 14.1 does it as well, I never noticed before. 22:30:32 <xarick> is that with some newgrf? 22:30:54 <xarick> maybe the rail type? engine? 22:31:33 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1310734652511879249/image.png?ex=67464c45&is=6744fac5&hm=4d4861004005c62a65441a6e14a3369958e5c1cbb4055104a75b28f725cfa4c6& 22:31:33 <xarick> my asserts are awesome! 22:33:08 <peter1138> Nope, all baseset. 22:33:28 <xarick> try a clean openttd.cfg 22:35:07 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1310735549014736956/image.png?ex=67464d1b&is=6744fb9b&hm=6656c6eca248cf0770561b4fa74edda02e902e8aecf611a53bd7d6e6579b0c89& 22:35:07 <xarick> hmm 🙂 22:35:58 <xarick> interesting dilema 22:37:22 <xarick> or not 22:38:55 <xarick> previously it was sacrificing other non inclined river tiles 22:39:03 <xarick> with terraform 22:39:30 <xarick> and it's not sea here, i made sure there was no sea on the map, only rivers 22:50:36 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1310739446424932362/image.png?ex=674650bc&is=6744ff3c&hm=2a19320fc2b602ab77212a48e57e290523d6b6a81c10c392b7187a4b65b6fd4d& 22:51:16 <xarick> wants to raise East Corner of 547937 22:51:24 <xarick> that would touch water 22:51:31 <xarick> terraform doesn't touch water 22:51:36 <xarick> in my code 22:53:14 <xarick> previous code would make this look more elegant indeed 22:53:40 <xarick> the river would have 2 inclined slopes 22:53:53 <xarick> and that dead end tile would disappear 22:55:47 <xarick> 547937 would likely also be turned into a river tile once flat 22:56:08 <xarick> hmm... disappointing what my code do 22:58:14 <xarick> wish there was a way to forward forbidden tiles to terraform command 23:10:28 <_glx_> xarick: you always open PR way too early