Times are UTC Toggle Colours
01:33:33 <peter1138> > Time between catastrophic damage got as low as 95.000km on average!! and several engines didn't even make it out of the manufacturers yard. 01:33:54 <peter1138> OpenTTD breakdowns are realistic, and you can't convince me otherwise 😉 02:32:50 *** tokai|noir has joined #openttd 02:32:50 *** ChanServ sets mode: +v tokai|noir 02:39:34 *** tokai has quit IRC 03:51:57 *** Flygon has quit IRC 04:02:25 *** D-HUND has joined #openttd 04:05:49 *** debdog has quit IRC 04:49:33 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/e7c63de55d58002ce32f3319a0d3851deec843f6 04:49:34 <DorpsGek> - Update: Translations from eints (by translators) 05:06:44 *** keikoz has joined #openttd 06:19:49 *** keikoz has quit IRC 07:30:54 *** Extrems has quit IRC 07:36:41 *** Extrems has joined #openttd 07:40:16 *** XYZ_ has joined #openttd 07:43:45 *** XYZ__ has joined #openttd 07:43:46 *** XYZ_ has quit IRC 07:45:19 *** XYZ has quit IRC 09:07:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13126: Codechange: Replace FontMap's std::map with std::vector. https://github.com/OpenTTD/OpenTTD/pull/13126 09:11:41 <peter1138> Ah, Mac OS code does different things. 09:17:00 *** XYZ has joined #openttd 09:17:35 *** XYZ has joined #openttd 09:19:26 *** XYZ__ has quit IRC 09:21:03 <peter1138> Weird, it uses upper_bound. There is of course a std::upper_bound I could use instead. 09:21:34 <peter1138> But it feels like upper_bound is incorrect here. 09:21:44 *** XYZ_ has joined #openttd 09:22:13 *** XYZ has quit IRC 09:22:19 <peter1138> There is an end-of-run entry so it's valid entry. 09:22:20 *** XYZ has joined #openttd 09:25:01 *** XYZ_ has joined #openttd 09:25:07 *** XYZ has quit IRC 09:45:52 *** D-HUND is now known as debdog 09:50:04 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13082: Codechange: Store animated tile state in map to improve performance. https://github.com/OpenTTD/OpenTTD/pull/13082#pullrequestreview-2464489410 10:10:16 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13111: Codechange: Cache callback spritegroups. https://github.com/OpenTTD/OpenTTD/pull/13111#pullrequestreview-2464556788 10:15:24 <peter1138> Hmm, can I do a projection involving decltype & value_type. 10:23:14 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13078: Codechange: Use vector for town's persistent storage list. https://github.com/OpenTTD/OpenTTD/pull/13078#pullrequestreview-2464603900 10:27:15 <peter1138> Very fails. 10:31:02 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13126: Codechange: Replace FontMap's std::map with std::vector. https://github.com/OpenTTD/OpenTTD/pull/13126 10:34:35 *** Xaroth92328 has joined #openttd 10:45:59 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13126: Codechange: Replace FontMap's std::map with std::vector. https://github.com/OpenTTD/OpenTTD/pull/13126#pullrequestreview-2464657817 10:55:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13117: Codechange: Sort Engine ID mapping for fast lookups https://github.com/OpenTTD/OpenTTD/pull/13117#pullrequestreview-2464632402 11:04:01 <xarick> hi 11:07:05 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1311287173563289610/image.png?ex=67484ed8&is=6746fd58&hm=4d4ec71c2e0091c8f432249eacaf04cc67c2eca8f862b95419aa16632f8f81e9& 11:07:05 <xarick> I wish there was an easier way to visualize the path result of a pathfinder 11:12:17 <kuhnovic> You can always follow the chain of parents and put them in a vector, 11:22:06 *** XYZ has joined #openttd 11:28:44 *** XYZ_ has quit IRC 11:32:00 *** keikoz has joined #openttd 11:38:01 <peter1138> When do we get to use ⋘ and ⋙ in our code? 11:42:03 <LordAro> wait, that's not just a ligature 11:47:15 <Rubidium> why would you want to use them? 11:48:14 <exceptik> xarick: well, irl it'd get eroded 11:51:14 <xarick> fontMapping ? why not font_mapping 11:51:20 <peter1138> For testing if something is MUCH less or greater than. 11:51:21 <Rubidium> irl rivers would also follow Lane's balance equation 11:51:56 <peter1138> xarick: Because whoever wrote it forgot the code-style conventions. 11:52:34 <Rubidium> s/wrote/wrote or reviewed/ 11:56:03 * xarick ~ 11:56:31 <peter1138> It's pre-git, so probably not 🙂 11:56:52 <peter1138> Remember when git was difficult to use? 11:58:32 <Rubidium> yes, I do remember (vaguely) 12:00:19 <xarick> I don't know what to do 12:00:28 <xarick> I'm out of ideas for solving rivers 12:01:26 <peter1138> bazaar, git and mercurial were all initially released with a month of each other. 12:01:41 <xarick> i remember using tortoisesvn 12:24:16 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1311306599725535263/image.png?ex=674860f0&is=67470f70&hm=a081b798d36221585e5c2367a5d2e02619424e07ea1ba35c3babff73b98d9e1a& 12:24:16 <xarick> I'm excusing it too much 12:27:24 <xarick> what if the adjacent_tile isn't connected to anything?.. omg aaaaaaaa 12:35:32 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13078: Codechange: Use vector for town's persistent storage list. https://github.com/OpenTTD/OpenTTD/pull/13078 12:35:35 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13055: Add: Implement support for loading sounds in Ogg Opus format. https://github.com/OpenTTD/OpenTTD/pull/13055#pullrequestreview-2464823015 12:37:00 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13126: Codechange: Replace FontMap's std::map with std::vector. https://github.com/OpenTTD/OpenTTD/pull/13126 13:31:39 *** Flygon has joined #openttd 13:32:11 <peter1138> There's also reinterpret_cast going on in mixer.cpp. 13:33:23 <peter1138> I had one iteration that treated sample data as floats, allowing the mixer to be much simpler, at the expense of each sample using more memory. 13:36:56 <peter1138> Of course everything then needs converting back to the native buffer again when doing that. 15:16:09 *** merni has quit IRC 15:34:26 <xarick> oops, there's more AyStarStatus to do 15:37:18 <xarick> also... CheckIgnoreFirstTile no longer exists but has declaration 15:44:35 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13127: Codechange 8e9603b: Replace int32_t with AyStarStatus https://github.com/OpenTTD/OpenTTD/pull/13127 15:47:46 <xarick> I'm not sure about the includes in aystar.h 16:11:04 <peter1138> The first four don't seem to be needed. 16:20:54 <xarick> wow, I actually found a disconnected river 16:21:09 <xarick> I mean, another 16:21:15 <xarick> which my fix doesn't fix 16:22:26 <xarick> the river widening algorithm tries to care, but ultimately fails 16:24:23 <xarick> even with a canal there 16:25:50 <xarick> seems to be, as it tries to widen the entrance to sea, it closes the other nearby 16:26:36 <xarick> must verify if this is what really happens, i'm just theorizing 16:51:10 *** Smedles has quit IRC 17:24:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13128: Codechange: Use unique_ptr instead of raw pointer for string layouts. https://github.com/OpenTTD/OpenTTD/pull/13128 17:38:12 <xarick> okay... i found a problem 17:38:44 <xarick> remember terraform leaves tiles needing to be flooded? 17:39:37 <xarick> FlowRiver checking where the sea is just happened to fail because of that 17:42:34 <xarick> I'm uncovering so many unexpected bugs 17:52:09 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13127: Codechange 8e9603b: Replace int32_t with AyStarStatus https://github.com/OpenTTD/OpenTTD/pull/13127#pullrequestreview-2465670442 18:18:12 <xarick> I need to change the terraform command 18:43:05 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13128: Codechange: Use unique_ptr instead of raw pointer for string layouts. https://github.com/OpenTTD/OpenTTD/pull/13128 18:48:28 <xarick> i made terraform "smarter" 18:49:40 <xarick> on terraform, immediately convert dirty tiles to water during world generation 18:49:59 <xarick> let's hope i don't break other stuff with this change 18:53:22 <xarick> wondering if this solves disconnecting one of the rivers if they both end at the sea in the same spot 18:56:16 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1311405247700402276/image.png?ex=6748bccf&is=67476b4f&hm=e0dca8d39fa2aaa88390af85f97305ff5e55ea52bd48e0d914530d763687d0d5& 18:56:16 <xarick> hmm 😦 18:57:54 <xarick> i do a pathfinding inside a pathfinder 18:58:04 <xarick> this is slow now 18:58:09 <xarick> but it's for debugging 18:58:42 <xarick> the first pathfinder builds and widens the river, the second pathfinder tests river connection 19:00:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13128: Codechange: Use unique_ptr instead of raw pointer for string layouts. https://github.com/OpenTTD/OpenTTD/pull/13128 19:00:24 <peter1138> Third time lucky? 19:34:14 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13082: Codechange: Store animated tile state in map to improve performance. https://github.com/OpenTTD/OpenTTD/pull/13082 19:35:29 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13111: Codechange: Cache callback spritegroups. https://github.com/OpenTTD/OpenTTD/pull/13111 19:46:40 *** gelignite has joined #openttd 19:48:53 <xarick> this is becoming worse, not better... 😦 19:48:57 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1311418505706475520/image.png?ex=6748c928&is=674777a8&hm=d71a6ef7396df9b3a5b68a29c1b923a86496ff00c46f2f92dfbf1f6bb794f94b& 19:55:49 <xarick> oh, i see , i was converting too early 19:56:16 <xarick> tiles must be in the final state of terraform, with their heights already updated 19:56:29 <xarick> otherwise... stuff like that in the image happens 19:59:47 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13117: Codechange: Sort Engine ID mapping for fast lookups https://github.com/OpenTTD/OpenTTD/pull/13117#pullrequestreview-2465866346 20:07:14 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1311423109013704847/image.png?ex=6748cd72&is=67477bf2&hm=1714c7af3fe82fb62959adaa971161817e42fdc81a9383dbd2ce0162c064e4e3& 20:07:14 <xarick> yay! problem solved 20:07:50 <xarick> no assert and no broken river 20:18:42 *** Wolf01 has joined #openttd 20:34:55 <xarick> why do I insist on testing tropic 20:35:03 <xarick> it's super slow 21:03:13 <peter1138> <https://qdb.tt-forums.net/index.cgi?id=27> And we never saw him since... 21:05:25 <xarick> found something strange with lake generation 21:06:02 <xarick> the height variable is that of the begin, maybe it's fine nvm... 21:21:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13117: Codechange: Sort Engine ID mapping for fast lookups https://github.com/OpenTTD/OpenTTD/pull/13117 21:26:06 <peter1138> Oh, I left an unused variable in there. 21:26:30 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13117: Codechange: Sort Engine ID mapping for fast lookups https://github.com/OpenTTD/OpenTTD/pull/13117 21:34:55 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13120: Fix #10452: Disconnection of rivers https://github.com/OpenTTD/OpenTTD/pull/13120 21:41:44 <peter1138> Urgh, wireless mouse batteries fail me 😦 21:44:34 <xarick> GitHub Actions 21:44:34 <xarick> / Mac OS (arm64 - Release) / CI 21:44:34 <xarick> unused function 'TestRiverConnection' [-Wunused-function] 21:44:45 <xarick> why does it say that? I'm using it 21:47:07 *** xarothbrook has joined #openttd 21:47:07 <xarothbrook> Clearly, GitHub disagrees with you 21:52:01 <xarick> https://github.com/OpenTTD/OpenTTD/pull/13120/files#diff-578266c8c75b8543c3d724834f1ed634626651d6a9446c9fa02073a80c67d3caR1344 22:02:14 *** gelignite has quit IRC 22:04:36 <xarick> new goal: find a river that is broken halfway 22:06:10 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1311453038442971156/image.png?ex=6748e951&is=674797d1&hm=0fe4a19f3a2d1ff8493ab1be6dbf0925718694f24ff80e923d37bbccbeaf2683& 22:06:10 <xarick> excelent debugging skills 22:07:06 <xarick> wow, that was fast 22:07:11 <xarick> it found one immediately 22:11:22 <xarick> why do i always get asserts after i post 22:20:08 <xarick> oh, seems that the 10000 search nodes is too short for long rivers 22:20:26 <xarick> let's try 0 22:21:04 *** keikoz has quit IRC 22:22:00 <xarick> why do I keep finding problems... 22:22:44 <xarick> when I think "oh this must be the last issue I found about xyz"... and then it isn't 22:29:19 <_glx_> xarick: it's used in a assert, so release build without assert doesn't use it 22:34:00 <xarick> oh, that makes sense 22:34:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13082: Codechange: Store animated tile state in map to improve performance. https://github.com/OpenTTD/OpenTTD/pull/13082#pullrequestreview-2466042225 22:34:24 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1311460143116058734/image.png?ex=6748efef&is=67479e6f&hm=7e0414b64a50b112201560850dfe19b62945c31fd48dbc27fc9bd34369aacf2d& 22:34:24 <xarick> i can't find a proper fix 22:34:57 <xarick> the test did indeed find a disconnected river 22:35:12 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13111: Codechange: Cache callback spritegroups. https://github.com/OpenTTD/OpenTTD/pull/13111#pullrequestreview-2466043028 22:36:07 <xarick> btw the console is printing many lines with 22:36:07 <xarick> FormatString: Attempt to read string parameter as integer 22:38:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13117: Codechange: Sort Engine ID mapping for fast lookups https://github.com/OpenTTD/OpenTTD/pull/13117#pullrequestreview-2466045511 22:48:12 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1311463615936594011/image.png?ex=6748f32b&is=6747a1ab&hm=6e95f7b565e333aff56ab04c37f7633a096071fd8b315242cc6944f94e11ebca& 22:48:12 <xarick> how is this possible 22:48:27 <xarick> there are 2 issues in here 22:48:42 <xarick> 1 is obvious, the river doesn't end at sea 22:49:33 <xarick> 2 breadth first search end point was that tile at the right, but aystar went another direction 22:49:40 <xarick> a bit north 22:49:50 <xarick> we have mismatching pathfinders 22:51:39 <xarick> i need to understand how's the inclined slope demolished 22:51:46 <xarick> I still didn't figure that out 22:52:59 <peter1138> Where's the best place for a helper functions that work on containers... container_func.hpp? 22:53:16 <peter1138> It always felt more like a compatibility layer for the old custom containers. 23:04:57 *** gnu_jj has joined #openttd 23:10:16 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13117: Codechange: Sort Engine ID mapping for fast lookups https://github.com/OpenTTD/OpenTTD/pull/13117 23:12:15 <peter1138> Oh, it conflicts somehow. 23:13:33 <peter1138> Silly me, changing too much stuff 23:21:35 *** Wolf01 has quit IRC 23:22:05 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1311472143900348466/image.png?ex=6748fb1d&is=6747a99d&hm=6cca6f9c63287ad696dc3559534415e8d45b156912aac5ee05b003434969e40c& 23:22:05 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1311472144542339072/image.png?ex=6748fb1d&is=6747a99d&hm=f664b754f66c8664c2ed0693997404b45d6ef7d520720e64dd949bdd73a498a2& 23:22:05 <peter1138> Nice algorithms, more efficient. 23:22:16 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13117: Codechange: Sort Engine ID mapping for fast lookups https://github.com/OpenTTD/OpenTTD/pull/13117 23:23:08 <peter1138> Beats my original method of erase (moving everything below) and reinsert (...moving everything below again...) 23:24:50 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13123: Codefix: Avoid divide by 0 in div/mod type varaction2 adjusts https://github.com/OpenTTD/OpenTTD/pull/13123 23:25:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13111: Codechange: Cache callback spritegroups. https://github.com/OpenTTD/OpenTTD/pull/13111 23:26:10 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13127: Codechange 8e9603b: Replace int32_t with AyStarStatus https://github.com/OpenTTD/OpenTTD/pull/13127 23:28:30 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13129: Codechange: Make AyStarStatus an enum class. https://github.com/OpenTTD/OpenTTD/pull/13129 23:30:47 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13124: Codechange: Reimplement engine sort order with std::rotate. https://github.com/OpenTTD/OpenTTD/pull/13124#pullrequestreview-2466085501 23:32:34 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13129: Codechange: Make AyStarStatus an enum class. https://github.com/OpenTTD/OpenTTD/pull/13129#pullrequestreview-2466086790 23:35:12 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13129: Codechange: Make AyStarStatus an enum class. https://github.com/OpenTTD/OpenTTD/pull/13129#pullrequestreview-2466088448 23:36:34 <peter1138> Hehe, I didn't realise how much of a QOL change the minimum scollbar slider size would be. 23:36:44 <peter1138> It totally doesn't matter, until it does. 23:38:30 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13128: Codechange: Use unique_ptr instead of raw pointer for string layouts. https://github.com/OpenTTD/OpenTTD/pull/13128#pullrequestreview-2466090537 23:39:00 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13128: Codechange: Use unique_ptr instead of raw pointer for string layouts. https://github.com/OpenTTD/OpenTTD/pull/13128 23:39:10 <peter1138> Spammy McSpamface. 23:42:26 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13117: Codechange: Sort Engine ID mapping for fast lookups https://github.com/OpenTTD/OpenTTD/pull/13117#pullrequestreview-2466091674 23:56:09 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13117: Codechange: Sort Engine ID mapping for fast lookups https://github.com/OpenTTD/OpenTTD/pull/13117 23:58:40 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #13117: Codechange: Sort Engine ID mapping for fast lookups https://github.com/OpenTTD/OpenTTD/pull/13117#pullrequestreview-2466102592