Times are UTC Toggle Colours
00:00:15 <wensimehrp> peter1138: I had the exact same problem with vscode terminal 03:23:38 *** akimoto has joined #openttd 03:29:21 *** akimoto has quit IRC 03:30:29 *** Wormnest has quit IRC 03:39:45 *** D-HUND has joined #openttd 03:43:09 *** debdog has quit IRC 03:53:32 *** akimoto has joined #openttd 04:45:06 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/9a8d9e4e483918d896c7348b4447ed3f7a32356b 04:45:07 <DorpsGek> - Update: Translations from eints (by translators) 05:16:44 *** keikoz has joined #openttd 05:26:11 *** akimoto has quit IRC 05:29:27 *** akimoto has joined #openttd 05:34:54 <DorpsGek> [OpenTTD/OpenTTD] Release workflow was not successful https://github.com/OpenTTD/OpenTTD/actions/runs/13469940703 06:09:03 *** keikoz has quit IRC 06:28:06 *** keikoz has joined #openttd 06:32:22 *** akimoto has quit IRC 06:37:36 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13633: Codechange: Use parameterised-GetString() for vehicle related windows. https://github.com/OpenTTD/OpenTTD/pull/13633#pullrequestreview-2634725188 06:38:48 *** akimoto has joined #openttd 06:41:32 *** akimoto has quit IRC 06:43:41 *** akimoto has joined #openttd 06:46:37 *** akimoto has quit IRC 07:06:02 *** akimoto has joined #openttd 07:07:07 *** akimoto_ has joined #openttd 07:14:26 *** akimoto has quit IRC 07:41:35 *** Emru has quit IRC 07:55:08 *** akimoto_ has quit IRC 07:55:43 *** Emru has joined #openttd 07:57:32 *** akimoto has joined #openttd 07:58:08 *** Emru has joined #openttd 08:02:16 *** Emru has quit IRC 08:04:43 *** akimoto has quit IRC 08:11:20 *** Emru has joined #openttd 08:12:53 <wensimehrp> peter1138: I see the Makefile for `grfbadges` 08:12:53 <wensimehrp> ifndef DST 08:12:53 <wensimehrp> $(error DST must be set to openttd source directory) 08:12:53 <wensimehrp> endif 08:12:53 <wensimehrp> all: 08:12:54 <wensimehrp> python3 badges.py 08:12:54 <wensimehrp> grfcodec -d -p1 badges.grf 08:12:56 <wensimehrp> sed -i '1,/0C "Default Badges"/d' sprites/badges.nfo 08:12:56 <wensimehrp> cat tool.txt sprites/badges.nfo > $(DST)/media/baseset/openttd/badges.nfo 08:12:58 <wensimehrp> cp sprites/badges*.png $(DST)/media/baseset/openttd/ 08:12:58 <wensimehrp> Clearly there is a line that copies badges image to another directory. peter1138[d] I'm not certain about your intention but does that mean you plan to move the GRF code & graphics into OpenTTD/OpenTTD? 08:13:00 <wensimehrp> If so, please don't include any more country flags in the repo. We are no longer using country flags for languages, and including them again is certainly not a good idea. The GRF would not cause minimal troubles if you keep it in your own repository rather than the organization's repository. 08:17:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13630: Fix 8f14894024: Badge widths were not updated on interface scale change. https://github.com/OpenTTD/OpenTTD/pull/13630#pullrequestreview-2634747429 08:22:12 *** nielsm has joined #openttd 08:29:05 <andythenorth> coffee time? 08:43:22 <_zephyris> Coffee badge? 08:43:34 <_zephyris> Hmm, refittable badge? 08:43:53 <_zephyris> Refittability always seemed a bit hidden to me. 08:44:09 <_zephyris> Are the flags still needed in the baseset BTW, or can they be removed? 08:47:48 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13625: Fix 11a8b71: Set direction and rotation of ships upon building https://github.com/OpenTTD/OpenTTD/pull/13625#pullrequestreview-2634754925 08:49:10 <michi_cc> wensimehrp: Country flags for languages are inappropriate, but why are country flags for countries inappropriate? 08:49:22 <andythenorth> politics 08:50:32 <Rubidium> well... how period correct do people want the flags to be? 08:50:38 <andythenorth> if the train nerds would just stop with realism sets, this would stop being an issue 08:50:54 <andythenorth> it's a game, we could have just invented nations 08:51:08 <andythenorth> players could have a great time making up lore 08:51:21 <andythenorth> but because autism, we have to import IRL problems 08:51:42 <ahyangyi> andythenorth: I do like the fake names in Iron Horse 08:51:46 <ahyangyi> and vanilla 08:52:20 <_zephyris> But can't people define badge icons anyway? Isn't that the point? 08:52:21 <andythenorth> taking escapism and importing the thing some of us are wanting to escape from 08:52:23 <andythenorth> is silly 08:52:32 * andythenorth clearly stuck in a grump 08:53:14 <andythenorth> maybe I should go back to bed and try again 😛 08:53:25 <ahyangyi> Well, I make the fakest heightmaps... 08:53:30 <_zephyris> (I agree, just in a less grumpy way ;)) 08:53:47 *** Wolf01 has joined #openttd 08:55:25 <ahyangyi> Oh, and I want to learn to draw trees in the OpenGFX2 style 08:55:57 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13610: Fix: [Script] Set DummyAI Api version to last available https://github.com/OpenTTD/OpenTTD/pull/13610#pullrequestreview-2634756138 08:57:54 <wensimehrp> _zephyris: I think they are used nowhere now 08:58:56 <_zephyris> wensimehrp: I know they're unused, but can they be removed without missing sprite warnings? 08:59:12 <wensimehrp> hmm, I don't think so 09:17:11 <peter1138> LordAro, I tried :/ 09:24:11 <peter1138> michi_cc, propaganda machines are effective. 09:27:09 <wensimehrp> yes 09:40:36 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13633: Codechange: Use parameterised-GetString() for vehicle related windows. https://github.com/OpenTTD/OpenTTD/pull/13633#pullrequestreview-2634762866 09:41:31 <peter1138> Hmm, I need a different font, in this one : and ; are too similar. 09:41:47 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13633: Codechange: Use parameterised-GetString() for vehicle related windows. https://github.com/OpenTTD/OpenTTD/pull/13633 09:43:59 <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1342794008430247966/image.png?ex=67baeddf&is=67b99c5f&hm=3366dc34055a6cbd9d251f0b11d8a6e4a8b81c3baf6b2123ce71cf2c27cd1931& 09:45:43 <peter1138> Hmm. 09:46:54 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1342794739036192779/image.png?ex=67baee8d&is=67b99d0d&hm=6df3bf694d4b9275a31755629be8d5b0825a0aa5063a5dfbe0504684e57e8372& 09:50:36 <wensimehrp> is it a programming font? 09:51:07 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13633: Codechange: Use parameterised-GetString() for vehicle related windows. https://github.com/OpenTTD/OpenTTD/pull/13633#pullrequestreview-2634764378 09:52:29 <peter1138> _zephyris, those old flags were an Action 05 block, so can be completely removed. 10:05:51 <peter1138> OpenTTD Mono is a coding font if I'm using it for coding. 10:10:09 <_zephyris> Curlz MT is a coding font if I'm using it for coding 10:18:07 <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1342802595378364476/openttd_originalgraphics_rocksprites_verysnow_lessnoisy_gridprotect.png?ex=67baf5de&is=67b9a45e&hm=35c459ff05af2f23321a4f1fb4ec2d6a0750b78a629ddb2f7f2bf01b068c0ba4& 10:18:07 <_zephyris> With tweaked tile edges? 10:21:56 <peter1138> Hmm, VS Code has a letter spacing setting, so I bring it closer together. 10:28:44 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on issue #13631: [Bug]: Infinite money by transfer to nowhere https://github.com/OpenTTD/OpenTTD/issues/13631 10:33:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13633: Codechange: Use parameterised-GetString() for vehicle related windows. https://github.com/OpenTTD/OpenTTD/pull/13633 10:36:40 <ahyangyi> https://cdn.discordapp.com/attachments/1008473233844097104/1342807266864398337/font_rend.png?ex=67bafa38&is=67b9a8b8&hm=ac590e7bdca6999fc0ef2bc365d5972d780a433bd0f878df61a4012e75715f99& 10:36:41 <ahyangyi> _zephyris: 10:37:11 <truebrain> please don't 10:40:27 <ahyangyi> No harm is done to my code editors, I did it in the myfonts preview 😛 10:40:36 <truebrain> pfew 😄 10:42:29 <truebrain> can you just imagine, a colleague asks for help, and you walk in on that 10:42:34 <truebrain> I think I would just walk away 😛 10:42:44 <truebrain> "you are on your own, bye now!" 10:52:15 <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1342811185942237224/image.png?ex=67bafdde&is=67b9ac5e&hm=bb5753aebaa7a2422f720ecb2df3e7e32f532c66a40f51ea4092802d0f7e3023& 10:52:15 <_zephyris> Oh wow 10:53:33 <truebrain> look at what you did ahyangyi ... why do you make me suffer 😛 10:53:34 <ahyangyi> https://cdn.discordapp.com/attachments/1008473233844097104/1342811518537830530/computer_problems.png?ex=67bafe2e&is=67b9acae&hm=bee606a084235861ac5570d328406bce2989968fcee39714a55e2e2bf7774370& 10:53:34 <ahyangyi> truebrain: I often feel my "help" is suggesting "try pressing more buttons!" 10:53:54 <ahyangyi> Oh, and I definitely pressed the wrong button this time 😛 11:06:12 <peter1138> Urgh. Stupid shoulder. 11:07:56 <peter1138> _zephyris, ew, a proportional-width font! 11:15:36 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13634: Codechange: remove ZeroedMemoryAllocator from NWidgetBase https://github.com/OpenTTD/OpenTTD/pull/13634 11:19:18 <DorpsGek> [OpenTTD/OpenTTD] nielsmh commented on pull request #13467: Codechange: Null video driver: End on game exit https://github.com/OpenTTD/OpenTTD/pull/13467#issuecomment-2676153633 11:20:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13635: Codechange: Use parameterised GetString() in network-related windows. https://github.com/OpenTTD/OpenTTD/pull/13635 11:24:06 <DorpsGek> [OpenTTD/OpenTTD] JGRennison opened pull request #13636: Cleanup: Adjustments to comments to match code changes https://github.com/OpenTTD/OpenTTD/pull/13636 11:26:24 <peter1138> "recent" :p 11:30:32 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13634: Codechange: remove ZeroedMemoryAllocator from NWidgetBase https://github.com/OpenTTD/OpenTTD/pull/13634 11:35:27 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13637: Codechange: remove ZeroedMemoryAllocator from GRFFile https://github.com/OpenTTD/OpenTTD/pull/13637 11:35:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13634: Codechange: remove ZeroedMemoryAllocator from NWidgetBase https://github.com/OpenTTD/OpenTTD/pull/13634#issuecomment-2676158586 11:38:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13637: Codechange: remove ZeroedMemoryAllocator from GRFFile https://github.com/OpenTTD/OpenTTD/pull/13637 11:42:25 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13634: Codechange: remove ZeroedMemoryAllocator from NWidgetBase https://github.com/OpenTTD/OpenTTD/pull/13634 11:42:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13634: Codechange: remove ZeroedMemoryAllocator from NWidgetBase https://github.com/OpenTTD/OpenTTD/pull/13634#issuecomment-2676160720 11:44:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13637: Codechange: remove ZeroedMemoryAllocator from GRFFile https://github.com/OpenTTD/OpenTTD/pull/13637 11:45:23 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #13625: Fix 11a8b71: Set direction and rotation of ships upon building https://github.com/OpenTTD/OpenTTD/pull/13625#pullrequestreview-2634781470 11:46:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13636: Cleanup: Adjustments to comments to match code changes https://github.com/OpenTTD/OpenTTD/pull/13636#pullrequestreview-2634781607 11:46:41 <xarick> hi 11:53:41 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13625: Fix 11a8b71: Set direction and rotation of ships upon building https://github.com/OpenTTD/OpenTTD/pull/13625#pullrequestreview-2634782615 11:55:39 *** D-HUND has quit IRC 11:58:33 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13610: Fix: [Script] Set DummyAI Api version to last available https://github.com/OpenTTD/OpenTTD/pull/13610 12:01:39 <Rubidium> truebrain: in #13635 I stumbled upon an assumption of ~10 MiB savegames for network games near WID_NJS_PROGRESS_TEXT in network_gui.cpp. Is that reasonable according to the surveys? Or are savegames close to 100 MiB already a reality? 12:03:07 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13635: Codechange: Use parameterised GetString() in network-related windows. https://github.com/OpenTTD/OpenTTD/pull/13635#pullrequestreview-2634782983 12:05:17 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13625: Fix 11a8b71: Set direction and rotation of ships upon building https://github.com/OpenTTD/OpenTTD/pull/13625 12:07:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13635: Codechange: Use parameterised GetString() in network-related windows. https://github.com/OpenTTD/OpenTTD/pull/13635#pullrequestreview-2634785282 12:07:50 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13625: Fix 11a8b71: Set direction and rotation of ships upon building https://github.com/OpenTTD/OpenTTD/pull/13625#pullrequestreview-2634785294 12:07:56 <truebrain> Rubidium: https://survey.openttd.org/summaries/2024/q4/14#savegame 12:08:11 <truebrain> Average is ~3MiB 12:08:50 <Rubidium> truebrain: yeah, that I know... it's setting the size of the window so the maximum is of importance and that's not in the public statistics 12:09:32 <Rubidium> also it might be that local games and network games have vastly different sizes 12:10:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13635: Codechange: Use parameterised GetString() in network-related windows. https://github.com/OpenTTD/OpenTTD/pull/13635 12:10:49 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13635: Codechange: Use parameterised GetString() in network-related windows. https://github.com/OpenTTD/OpenTTD/pull/13635#pullrequestreview-2634785804 12:10:50 <peter1138> If it's just for maximum width then upping from 10MiB to 100MiB should be no problem. 12:11:00 <xarick> median savegame size instead of average 12:12:17 *** debdog has joined #openttd 12:15:14 <xarick> @rubidium I looked into `SLV_SHIP_ROTATION` conversion, which also initializes `v->rotation_x_pos`and `v->rotation_y_pos`. I thought to myself, "hmm maybe this should also be the case just for sake of completion" 12:18:25 <Rubidium> also the average savegame size is likely weighted by the number of hours played 12:21:02 <Rubidium> peter1138: well with the 8 digits, it's already good until almost 100 MiB, so I think it's fine. I was just looking whether we might have a better estimate available now with the survey that 'this feels about right' 12:24:14 <xarick> wow, ship still crashing... what the heck 12:24:19 <xarick> ah 12:24:26 <xarick> it's a bad save, nevermind 12:24:33 <peter1138> Rubidium, ah fair. 12:27:01 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #13625: Fix 11a8b71: Set direction and rotation of ships upon building https://github.com/OpenTTD/OpenTTD/pull/13625#issuecomment-2676176724 12:28:47 *** akimoto has joined #openttd 12:31:09 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #13625: Fix 11a8b71: Set direction and rotation of ships upon building https://github.com/OpenTTD/OpenTTD/pull/13625#pullrequestreview-2634792277 12:32:04 <peter1138> Technically it shouldn't matter here. The ship should be hidden, etc... (Although the hidden flag is set after, and not actioned on anyway.) 12:34:41 <Rubidium> and for real fun by {BYTES} and widths... imagine the 8 being widest, and the 1 and 0 just one narrower. Then a narrow decimal separator and a wide M and narrow G. 1000MiB might be wider than 8.88GiB. And doing things perfectly right here's going to be tricky (or very code-duplicatey) because the divisions by 1024 happening repeatedly in FormatBytes. 12:35:31 <Rubidium> ... please don't make that your next side-quest 12:36:35 <peter1138> GetBroadestDigit() is meant to handle some of that. 12:43:23 *** Flygon has quit IRC 12:45:15 *** virtualrandomnumber has joined #openttd 12:48:55 *** virtualrandomnumber has quit IRC 13:15:04 <truebrain> Rubidium: No, the average savegame is not weighted against time played; it is just the average of all games transmitted. 13:16:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13635: Codechange: Use parameterised GetString() in network-related windows. https://github.com/OpenTTD/OpenTTD/pull/13635 13:19:49 <peter1138> > 96 files changed, 1703 insertions(+), 2173 deletions(-) 13:19:52 <peter1138> Still a bit to go. 13:19:55 *** tony_pixel has joined #openttd 13:19:55 <tony_pixel> Is it an issue that a train flipped has different bounding boxes? 13:21:15 <tony_pixel> A train consisting out of 8/8 pieces is fine, but anything else moves around when flipped 13:22:02 <tony_pixel> If i have something like 7/8 + 2/8 + 7/8, it somehow preserves position, but 7/8 + 1/8 + 1/8 + 7/8 doesn't 13:23:54 <peter1138> It's because vehicle positions are actually at the centre of each part, and with odd-numbered lengths that's not in the same place. 13:24:29 <peter1138> Middle parts are moved, but the end parts cannot be moved. 13:25:49 <peter1138> (If it did, the end part could end up on a different tile and track piece, without necessary things like path finding and reservations being taken into account.) 13:28:39 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13636: Cleanup: Adjustments to comments to match code changes https://github.com/OpenTTD/OpenTTD/pull/13636 13:29:19 <tony_pixel> So correct way to do so would be something like x + y + x for odd length cars? 13:29:56 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13630: Fix 8f14894024: Badge widths were not updated on interface scale change. https://github.com/OpenTTD/OpenTTD/pull/13630 13:30:48 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13634: Codechange: remove ZeroedMemoryAllocator from NWidgetBase https://github.com/OpenTTD/OpenTTD/pull/13634#pullrequestreview-2634805614 13:33:14 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13638: Codechange: remove ZeroedMemoryAllocator from OpenGLBackend https://github.com/OpenTTD/OpenTTD/pull/13638 13:34:25 <truebrain> https://cdn.discordapp.com/attachments/1008473233844097104/1342851998638149682/image.png?ex=67bb23e1&is=67b9d261&hm=f33f3352b755b27965c342210d4e6edcdcc3a5b6f043e0966f46acf2912f2cd1& 13:34:25 <truebrain> Rubidium: last week no savegame was above 40 MiB, and 99% was below 10 MiB (14.1 savegames) 13:35:20 <truebrain> JGRPP biggest one was 300 MiB, but those too are rare 13:36:11 <Rubidium> thanks truebrain, so the comment and assumption are right within basically half an order of magnitude for vanilla 13:38:07 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13632: Codechange: use std::allocator over malloc/free for Squirrel memory management https://github.com/OpenTTD/OpenTTD/pull/13632 13:38:36 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13634: Codechange: remove ZeroedMemoryAllocator from NWidgetBase https://github.com/OpenTTD/OpenTTD/pull/13634 13:40:15 <truebrain> Or worded different, JGRPP is: 13:40:16 <truebrain> 50.0%: 4750000 13:40:16 <truebrain> 90.0%: 35450000 13:40:16 <truebrain> 95.0%: 54720000 13:40:16 <truebrain> 99.0%: 128890000 13:40:16 <truebrain> 99.9%: 288230000 13:40:46 <truebrain> and 14.1 is: 13:40:48 <truebrain> ```50.0%: 700000 13:40:48 <truebrain> 90.0%: 7650000 13:40:48 <truebrain> 95.0%: 22920000 13:40:49 <truebrain> 99.0%: 29590000 13:40:49 <truebrain> 99.9%: 32690000``` 13:40:58 <truebrain> in bytes 13:41:14 <truebrain> owh, and I used a bucket of 10k, explaining the four zeros 😛 13:42:23 <tony_pixel> Peter, I don't quite understand the "Middle parts are moved, but the end parts cannot be moved.". What does stay at the same position, the middle rounded down? 13:42:40 <tony_pixel> Of the end parts? 13:52:24 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13637: Codechange: remove ZeroedMemoryAllocator from GRFFile https://github.com/OpenTTD/OpenTTD/pull/13637#pullrequestreview-2634808749 13:52:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13638: Codechange: remove ZeroedMemoryAllocator from OpenGLBackend https://github.com/OpenTTD/OpenTTD/pull/13638#pullrequestreview-2634808829 13:55:42 *** debdog has quit IRC 13:55:54 *** debdog has joined #openttd 13:57:21 <peter1138> Vehicle position is the centre of the part. That does not get moved for the end parts when flipping a train, but the parts in between the ends can be moved. 13:57:55 <peter1138> The bounding box relative position depends on the direction of the part. 13:58:31 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13637: Codechange: remove ZeroedMemoryAllocator from GRFFile https://github.com/OpenTTD/OpenTTD/pull/13637 13:59:13 <tony_pixel> So for odd-sized end parts this is more of luck than of calculation? 13:59:23 <peter1138> A 7/8ths part will have the centre point at 3/8ths (or 4/8ths, it doesn't matter) from the front. 13:59:26 <_glx_> hmm going from .hpp.sq to .sq.hpp is a pain 13:59:56 <_glx_> would be simpler to do .hppsq.hpp 14:00:02 <peter1138> When flipping this means the part does move, even though it's internal position is actually the same. 14:00:12 <peter1138> *does appear to move. 14:01:07 <tony_pixel> Will using 6/8 + 1/8 for 7/8 traincar fix that? 14:01:59 <peter1138> I wouldn't worry about it. It's basically normal. Every set that uses odd-length parts will have the same thing. 14:02:54 <peter1138> I've thought about ways to fix it properly but they always get side-tracked and side-quested. 14:03:46 <tony_pixel> So if I am just to align it via realsprite offsets to bounding boxes, that basically counts as correct? 14:03:48 <andythenorth> in soviet russia, does side quest watch you? 14:04:09 <peter1138> It's not a sprite alignment issue. 14:04:52 <peter1138> (Unless your 7/8 parts are actually a Multi-head engine, in which case it does still need special handling) 14:05:37 <tony_pixel> Well yes. My main concern is that sprites are aligned to bounding boxes, and boxes move when the train is flipped on stations. Since I am working on a push-pull "support" for my set, this is a bit of a downer, as I wanted to keep position as constant as possible 14:05:41 <truebrain> Okay, I added the percentile savegame sizes to the survey; it now needs to recalculate all of them, but after that, I will publish the result. Should make you able to answer that question again in a few months/years Rubidium, by looking at the table 😄 14:05:53 <peter1138> But as you haven't provided any pictures of the problem then I don't know. 14:06:50 <tony_pixel> https://cdn.discordapp.com/attachments/1008473233844097104/1342860154173001799/cf6116d3c4960122.png?ex=67bb2b79&is=67b9d9f9&hm=743136e7f05cb01e6a9a5fa221b4d0d091a040b2d77f857911cea61d387316e2& 14:06:50 <tony_pixel> https://cdn.discordapp.com/attachments/1008473233844097104/1342860154479312946/a883fdc638aa6b10.png?ex=67bb2b79&is=67b9d9f9&hm=9223cff2a751e57372e1c195aeace130afff1302dc4e9f528588fc44f5e3f96d& 14:06:50 <tony_pixel> This mostly 14:06:50 <peter1138> Okay, in that case, you should not try to 'fix' it. 14:07:07 <tony_pixel> Oh that's a bit wrong 14:07:27 <peter1138> Since you didn't take the screenshot in the same position it's hard to see. 14:07:43 <peter1138> The train IS moving. 14:07:51 <tony_pixel> One second 14:08:03 <tony_pixel> It appears to keep positions when I use 7+1+8 combo 14:08:23 <peter1138> Therefore no amount of sprite-offset twiddling is correct. 14:08:24 <tony_pixel> And for 8+1+8 14:08:59 <peter1138> As I said, best not to worry about it, it's normal, and it's just the behaviour of the game. 14:09:09 <tony_pixel> Ok then, thanks anyway! 14:09:09 <peter1138> It's not a bug in your setl. 14:09:16 <peter1138> -l 14:12:45 <peter1138> What it needs to fix it: the game needs to store the front position (x/y, tile and track) of the front part, and the rear position (x/y, tile and track) of the rear part. It will then be able to properly re-position the train when it's flipped. 14:13:18 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13473: Change: [Script] Replace ScriptDate with ScriptEconomyDate and ScriptCalendarDate https://github.com/OpenTTD/OpenTTD/pull/13473#pullrequestreview-2634812050 14:13:42 <peter1138> Caveat with that is depending on where the train is stopped, some parts my appear to change angle (not just direction) when flipped. 14:13:42 <tony_pixel> Will that be a valid fix or a graphic fix? Which variant is more convenient for managing it under the hood? 14:14:20 <peter1138> The issue is nothing to do with graphics. 14:14:31 <peter1138> Therefore the fix is not a graphical fix. 14:14:49 <tony_pixel> I guess that most of my custom logic will go away anyway when we implement consists 14:15:25 <tony_pixel> I would love to take a part in it but university and work-seeking is siphoning away all my free time :/ 14:19:42 <peter1138> Ah shit, sneezed :( 14:21:15 <tony_pixel> What so bad about that? 14:21:52 <peter1138> Back hurts. 14:21:57 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1342863961011519630/image.png?ex=67bb2f05&is=67b9dd85&hm=6db76f7206e72080dbd76cca24abb8ecf9b92a31c3663238bb6778ef53cf7c4a& 14:22:19 <peter1138[d]> See that rear wagon, what track is it on... 14:22:48 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13638: Codechange: remove ZeroedMemoryAllocator from OpenGLBackend https://github.com/OpenTTD/OpenTTD/pull/13638 14:23:16 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1342864284727775284/image.png?ex=67bb2f52&is=67b9ddd2&hm=be5977ee20e8674ca9546c98e7416564ce1c05203079411dbb41550b3801f4b9& 14:23:16 <peter1138[d]> What about now 🙂 14:23:49 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1342864429850820689/image.png?ex=67bb2f75&is=67b9ddf5&hm=5c6084e37f7fb092bfa7358490b925ff2eba23b8a84a3d695cf782e05b7c7aa9& 14:23:49 <peter1138[d]> Hmm, derailed... 14:24:43 <Rubidium> ... and then there was only "one" use of ZeroedMemoryAllocator 14:25:04 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1342864745958735912/image.png?ex=67bb2fc0&is=67b9de40&hm=d045dd81ef185e6f58150e0e1999e5573bcd0cef231a0a7776d43dd6b28fbb25& 14:25:19 <peter1138[d]> Train on the left is in an 'illegal' position. 14:25:35 <peter1138[d]> And this is with standard 8/8 parts. 14:25:49 <peter1138> Hence why I say: don't try to fix this with offsets or part-splitting. 14:26:19 <peter1138> Rubidium, it's only one simple little class... 14:28:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13607: Codechange: explicitly initialise NewGRF-pool-object member variables https://github.com/OpenTTD/OpenTTD/pull/13607#pullrequestreview-2634823217 14:28:18 <tony_pixel> That I do know yes 14:28:20 <Rubidium> though I thought you had a patch for that, right? 14:31:22 <andythenorth> should I add running cost parameter to Iron Horse? 14:31:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13628: Codechange: use std::vector/std::span over MallocT for NewGRF bridge sprites https://github.com/OpenTTD/OpenTTD/pull/13628#pullrequestreview-2634826503 14:31:54 <andythenorth> why are we so against cost parameters for grfs? 👀 14:32:04 <andythenorth> is it because there's already a cost setting? 14:32:09 <andythenorth> and base cost grfs 14:32:32 <andythenorth> if two methods aren't working, third one's the charm? 14:32:33 <peter1138> Rubidium, I had a patch that made ZeroedMemoryAllocator fill the memory with something other than Zeroes, so I could find out what was missing... 14:33:09 <andythenorth> peter1138: have you got phrenic nerve pain? 14:33:17 <peter1138> My patch to remove ZeroedMemoryAllocator didn't fix all the windows, which is one reason I never PRd it. 14:33:41 <peter1138> andythenorth, I've got "I woke up this morning and my shoulderblade/back aches a little bit" pain. 14:34:06 <peter1138> I then tried to go on a bike ride and gave up after half a mile. 14:34:35 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13628: Codechange: use std::vector/std::span over MallocT for NewGRF bridge sprites https://github.com/OpenTTD/OpenTTD/pull/13628 14:34:47 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13607: Codechange: explicitly initialise NewGRF-pool-object member variables https://github.com/OpenTTD/OpenTTD/pull/13607 14:35:01 <peter1138> Some of my patches for removing ZMA were PRd and merged. 14:35:12 <peter1138> Often inconsequential things like changing C-array to std::array. 14:35:37 <peter1138> But the bigger things always ended up side-questing :S 14:36:23 <andythenorth> hmm https://www.youtube.com/watch?v=TGfQu0bQTKc 14:41:21 <xarick> https://youtube.com/shorts/Ioi7DPTHG6A?si=mml6IunLJOYMqCTW 14:41:59 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13595: Codechange: explicitly initialise Company member variables https://github.com/OpenTTD/OpenTTD/pull/13595#pullrequestreview-2634838092 14:47:15 <andythenorth> pithy 🙂 14:47:40 <andythenorth> although the concept of AI => no senior engineers seems a bit malthusian 14:48:24 *** nielsm has quit IRC 14:50:37 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13639: Codechange: remove C-style memory management https://github.com/OpenTTD/OpenTTD/pull/13639 14:57:06 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13595: Codechange: explicitly initialise Company member variables https://github.com/OpenTTD/OpenTTD/pull/13595#pullrequestreview-2634854883 15:05:27 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13595: Codechange: explicitly initialise Company member variables https://github.com/OpenTTD/OpenTTD/pull/13595#pullrequestreview-2634864751 15:07:52 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13595: Codechange: explicitly initialise Company member variables https://github.com/OpenTTD/OpenTTD/pull/13595#pullrequestreview-2634867851 15:33:08 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13595: Codechange: explicitly initialise Company member variables https://github.com/OpenTTD/OpenTTD/pull/13595 15:38:19 <peter1138> Hmm. 15:44:36 *** kuka_lie has joined #openttd 15:50:35 <DorpsGek> [OpenTTD/survey-web] TrueBrain opened pull request #60: Add: also show the 50/90/95/99/99.9 percentile of savegame sizes https://github.com/OpenTTD/survey-web/pull/60 15:52:36 *** Alkel_U3 has quit IRC 15:54:10 *** Alkel_U3 has joined #openttd 15:58:39 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13640: Codechange: remove C-style memory management from pools https://github.com/OpenTTD/OpenTTD/pull/13640 15:59:12 <truebrain> lol, GitHub is unable to show the diff of that PR 15:59:13 <truebrain> sad 15:59:53 <truebrain> ` Oops, something went wrong.` 15:59:54 <truebrain> lol 16:01:09 <truebrain> even based on the commit, it can't get past wk14.json 16:01:10 <truebrain> wtf 😄 16:02:55 <truebrain> would this work better? 16:02:56 <DorpsGek> [OpenTTD/survey-web] TrueBrain updated pull request #60: Add: calculate the 50/90/95/99/99.9 percentile of savegame sizes https://github.com/OpenTTD/survey-web/pull/60 16:03:32 <truebrain> nope; but at least the code is visible now 🙂 16:08:28 <DorpsGek> [OpenTTD/survey-web] TrueBrain merged pull request #60: Add: calculate the 50/90/95/99/99.9 percentile of savegame sizes https://github.com/OpenTTD/survey-web/pull/60 16:10:08 *** Wormnest has joined #openttd 16:14:10 <truebrain> https://survey.openttd.org/summaries/2024/q4/14#savegame_size 16:14:10 <truebrain> There we go! More numbers! 😄 16:14:18 <truebrain> 50% of the users have a savegame of less than 1MiB .. nice 😄 16:17:53 <peter1138> This probably helps with the "we need a new savegame compression system because it's too large / slow / old" 16:18:18 <peter1138> (Hmm, can we record how long it takes to make a save...) 16:38:16 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1342898266186055752/image.png?ex=67bb4ef8&is=67b9fd78&hm=061c6ae81681bb9fc470bf84c028308e778cfebf6bcc9eac43ce82cda5113542& 16:38:16 <peter1138[d]> Improved? 16:39:00 <talltyler> Perfect 16:41:28 *** tokai|noir has quit IRC 16:42:36 *** tokai has joined #openttd 16:42:36 *** ChanServ sets mode: +v tokai 16:44:54 <johnfranklin> https://cdn.discordapp.com/attachments/1008473233844097104/1342899935607001200/IMG_7601.mov?ex=67bb5086&is=67b9ff06&hm=3838d279ee03ba36b8383e47b21ce9f12d3d378d2fa9576b697785672a1156f2& 16:44:54 <johnfranklin> Bus departure on e-ink? 16:52:37 <_glx_> it's efficient 16:53:38 <_glx_> low power, no issue to read with sun 16:54:59 <peter1138> Oh, perhaps it's a substring in a GRFString :S 16:55:50 <_glx_> sprites look grf-y 16:59:02 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1342903490950729820/image.png?ex=67bb53d6&is=67ba0256&hm=3e93eacfec108619efcc7e0e05e5085e00f33ba374b0d12cc728f778801ca3af& 16:59:12 <peter1138> Handling the substring properly seems to have fixed it. 17:10:48 <peter1138> Hmm, so the refactoring is also less code :o 17:13:28 <peter1138> Just need to find a NewGRF that uses the Location callback to prevent building. 17:22:04 <talltyler> Industry set or house set? ITL Houses and Improved Town Industries both have callback-based placement rules. 17:22:54 <peter1138> Any set that I can see an error message returned. 17:23:07 <peter1138> And that error message needs to use the text ref stack. 17:23:21 <_glx_> hmm didn't I made a test grf for that ? 17:23:29 <peter1138> I don't know :-) 17:23:50 <peter1138> NML regression test? 17:25:29 <xarick> I'm having a difficult time setting up the proper condition to display an icon in the ai configuration 17:25:33 <talltyler> Try funding an ITI factory far away from a town, it should give you a NewGRF-provided error string (if that’s what you’re looking for) 17:25:41 <_glx_> example_station.grf from december I think 17:26:20 <talltyler> I don’t believe I’ve used string parameters for any error messages though, my only use of the text stack is in ITI’s industry windows 17:26:23 <_glx_> but not sure it used text stack 17:26:37 <peter1138> talltyler, okay, I can test that too. 17:27:50 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1342910738037084253/image.png?ex=67bb5a96&is=67ba0916&hm=6db16795aaa3bcbec999ae921f5c13277c64a4941c9468713e879dda44b2e380& 17:27:51 <talltyler> Oh, actually, try loading ITI and FIRS at the same time, I think both return errors naming the incompatible GRF. 17:27:55 <peter1138[d]> Interesting generation... 17:28:24 <talltyler> Flat terrain around industry strikes again, in the opposite direction to the usual plateaus:D 17:28:38 <peter1138[d]> Flat terrain is normal. It spawning at sea-level is not. 17:28:43 <xarick> I got this so far.<https://gist.github.com/SamuXarick/98a6fe3f1ce38d09047fcff0f1b7ea4a> 17:29:01 <talltyler> Sea level?? That’s very strange indeed 17:29:02 <ahyangyi> Looks cute though 17:29:06 <talltyler> That should be flooded 17:29:20 <ahyangyi> Would it help if I make most of my industries work on slopes? 17:29:22 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1342911125339242517/image.png?ex=67bb5af2&is=67ba0972&hm=01d9b417aba862d9b7c94e79fad058fb221f9fd533cf448fdbb8d6e06ae6f11a& 17:29:22 <peter1138[d]> I tried it. It did... 17:29:33 <talltyler> RIP forest 17:29:48 <talltyler> But I mean, it should be ocean during map generation 17:29:50 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13641: Codechange: explicitly initialise member variables of Windows 1 of N https://github.com/OpenTTD/OpenTTD/pull/13641 17:30:11 <_glx_> `04 00 FF 01 00 "ÐError test { {" 00` seems it does 17:31:40 <xarick> condition on line 7 is insuficient 😦 17:32:17 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1342911859790975058/image.png?ex=67bb5ba1&is=67ba0a21&hm=66e9a149420d7878c76001a1a981f1531e40ffd234f951f8b1959bebe71c6bcc& 17:32:54 <_glx_> seems right 17:32:57 <peter1138[d]> talltyler: I wonder if it was a 1-corner hole, not a full tile. 17:33:29 <xarick> remember when I came up with 17:33:36 <xarick> "farms digging a hole" 17:33:55 <xarick> and i was trying to fix it and got the door shut? 17:34:24 <xarick> let me find the PR 17:36:58 <xarick> https://github.com/OpenTTD/OpenTTD/pull/7877 17:39:03 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13642: Codechange: Preprocess text ref stack parameters. https://github.com/OpenTTD/OpenTTD/pull/13642 17:39:47 <peter1138> Yeah, the difference is, I found it mildly interesting enough to share. 17:42:00 <peter1138> Your PR was also obviously wrong, as it was climate specific on a climate I'm not using. 17:42:42 <peter1138> This doesn't need fixing IMHO. 17:44:32 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13642: Codechange: Preprocess text ref stack parameters. https://github.com/OpenTTD/OpenTTD/pull/13642#issuecomment-2676323611 17:48:00 <peter1138> Oh yeah, comments would be good :D 17:54:35 <cu-kai> hi, i have a strange issue where scroll behaviour is different between xwayland and wayland modes 17:55:17 <cu-kai> i have tested with SDL event logging, and in xwayland the scrolling event seems to use integer values like so: 17:55:17 <cu-kai> INFO: SDL EVENT: SDL_EVENT_MOUSE_WHEEL (timestamp=3774461179 windowid=5 which=0 x=0 y=1 direction=normal) 17:55:41 <cu-kai> however when using wayland (SDL_VIDEODRIVER=wayland env var) the scrolling is like this: 17:55:41 <cu-kai> INFO: SDL EVENT: SDL_EVENT_MOUSE_WHEEL (timestamp=2800579856 windowid=4 which=0 x=0 y=0.732031 direction=flipped) 17:56:12 <cu-kai> the problem here is that i cannot zoom in our out in wayland mode, unless i scroll my mousewheel extremely fast (thus creating an event where the Y value is >=1) 17:56:31 <cu-kai> in xwayland, single movements of my scrollwheel create an event which is exactly =1 so zooming works fine 17:57:23 <cu-kai> i don't recall this being an issue previously with openttd, but i am not sure if a recent system update broke this or if it's on openttd's end as i cannot reproduce it on my desktop 17:58:59 <cu-kai> i currently don't have access to my desktop to test this either 18:01:08 <Rubidium> what version are you using? 18:06:52 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13642: Codechange: Preprocess text ref stack parameters. https://github.com/OpenTTD/OpenTTD/pull/13642 18:08:24 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13642: Codechange: Preprocess text ref stack parameters. https://github.com/OpenTTD/OpenTTD/pull/13642 18:12:02 <peter1138> Wayland being baffling, quelle surprise. 18:17:45 <andythenorth> amusing https://www.youtube.com/watch?v=qeUAHHPt-LY 18:18:02 <andythenorth> I thought it would be actually audio programmed, but no, it's Audacity 18:35:02 <xarick> I think I did it! <https://gist.github.com/SamuXarick/98a6fe3f1ce38d09047fcff0f1b7ea4a> 18:35:12 <xarick> that first human company is so much trouble 18:38:15 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1342928459042918480/image.png?ex=67bb6b17&is=67ba1997&hm=cafd998efdee40d29f10f98e982c672a2d8b77d969f60ae7deeb2b9064c29d32& 18:38:15 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1342928459277533296/image.png?ex=67bb6b17&is=67ba1997&hm=c9e3e90c4b42cb0e7040a1e9637af8aea708207c517693bf0824185574038945& 18:39:32 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1342928783065350245/image.png?ex=67bb6b64&is=67ba19e4&hm=b3a9767401ff9d1c7b593c79903305f02f80db4c3bb848b4709d5d305809a679& 18:39:32 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1342928783383990273/image.png?ex=67bb6b64&is=67ba19e4&hm=4d5558a7b86cd7a593588aaf15a17162bbe1b6181c41a03b3e32e55ad0bd6560& 18:48:48 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1342931114410512425/image.png?ex=67bb6d90&is=67ba1c10&hm=2e9cc503335f046847479eab36b6abd1d7fef4bfba708b0b6794a6bd7deaa5cf& 18:48:48 <xarick> fantastic! 18:49:20 *** tokai|noir has joined #openttd 18:49:20 *** ChanServ sets mode: +v tokai|noir 18:49:54 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #13642: Codechange: Preprocess text ref stack parameters. https://github.com/OpenTTD/OpenTTD/pull/13642#pullrequestreview-2635159307 18:56:22 *** tokai has quit IRC 19:00:03 *** propvp has joined #openttd 19:00:03 <propvp> 50$ gift https://steamnscommnunity.com/1042914095 19:00:08 <cu-kai> Rubidium: i tried latest master, and 15.0 beta 19:02:41 <Rubidium> so the fractional scrolling thing added the 13th of December did not help with that, too bad 19:04:48 <peter1138> There's a multiplier somewhere, maybe that has an effect. 19:05:05 <peter1138> Okay, most of the time no EncodedString is needed. Hmm. 19:05:42 * peter1138 checks 19:06:32 <talltyler> propvp: Discord Moderator 19:06:42 <truebrain> now they have pings in at least 4 channels! 😄 19:08:08 <truebrain> I dont get why Discord doesn't figure out this spam and mutes it instantly 19:08:17 <truebrain> I mean, it isn't that hard .. multiple channels .. money .. url ... 19:09:47 <cu-kai> there was an option in settings i tried changing, it didn't seem to have any effect 19:10:06 <cu-kai> "map scrollwheel speed" 19:13:17 <peter1138> Hmm, for any string that is pre-mapped (via AddStringForMapping) does it make sense that it couldn't be using the text ref stack. 19:13:58 <peter1138> If it's pre-mapped, it's not via a callback, therefore there's no temporary registers for the stack. 19:17:06 <peter1138> Been confused by the error message window using the text ref stack for all of the 3 different strings of the error. 19:19:44 *** gelignite has joined #openttd 19:20:06 <frosch123> Callback could include a builtin string as substring? 19:21:13 <frosch123> Error message shows result of industry location check etc 19:21:29 <cu-kai> Rubidium: is the fractional scaling change specific to wayland? 19:21:48 <cu-kai> s/scaling/scrolling/ 19:21:57 <cu-kai> (sorry, too many rants about fractional scaling, lol) 19:32:54 <peter1138> frosch123, substrings are already handled. 19:33:18 <peter1138> (In that case we are already processing the stack.) 19:34:48 <peter1138> Damn it, I was too lazy to do rice, so decided to have left over curry with a naan bread. 19:35:03 <peter1138> The naan bread is mouldy. So, uh... simple meal :S 19:38:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13643: Codechange: Simplify some calls to DrawStringMultiLine(). https://github.com/OpenTTD/OpenTTD/pull/13643 19:52:24 *** geertop has quit IRC 19:59:46 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13643: Codechange: Simplify some calls to DrawStringMultiLine(). https://github.com/OpenTTD/OpenTTD/pull/13643#pullrequestreview-2635226413 20:01:02 *** akimoto has quit IRC 20:02:57 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #13643: Codechange: Simplify some calls to DrawStringMultiLine(). https://github.com/OpenTTD/OpenTTD/pull/13643#pullrequestreview-2635226413 20:03:00 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13643: Codechange: Simplify some calls to DrawStringMultiLine(). https://github.com/OpenTTD/OpenTTD/pull/13643 20:03:01 <peter1138> Oops. 20:03:14 <peter1138> Just moved a comment to where it's applicable. 20:04:40 <peter1138> Will a whisky help my shoulder? 20:04:50 <peter1138> I'm not sure but I'm willing research. 20:05:49 <cu-kai> Rubidium: i reverted the commits in that PR (#13169) and scrolling is still rubbish with the wayland driver 20:07:40 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13642: Codechange: Preprocess text ref stack parameters. https://github.com/OpenTTD/OpenTTD/pull/13642 20:08:37 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13644: Codechange: remove ZeroedMemoryAllocator https://github.com/OpenTTD/OpenTTD/pull/13644 20:08:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13642: Codechange: Preprocess text ref stack parameters. https://github.com/OpenTTD/OpenTTD/pull/13642#issuecomment-2676375669 20:09:17 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13643: Codechange: Simplify some calls to DrawStringMultiLine(). https://github.com/OpenTTD/OpenTTD/pull/13643#pullrequestreview-2635234046 20:10:40 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1342951715560882186/Several-possible-etiologies-in-the-diagnosis-of-chronic-shoulder-pain.png?ex=67bb80bf&is=67ba2f3f&hm=327a90ea5a6c89d1407e2064c1e4f6ca975eee9183259001752cc7c9f7321cbf& 20:10:40 <andythenorth> peter1138: shoulder pain isn't always in the shoulder 20:11:33 <andythenorth> referral from other nerves, if it's diaphragm, might be why sneezing made it hurt 20:12:03 <peter1138> That hurt because my whole body jerked. 20:13:13 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1342952360338657390/wOefAcH0SC0AwAAAABJRU5ErkJggg.png?ex=67bb8159&is=67ba2fd9&hm=a153f3fc9cc90c742b28268d4abf7bdd48459ac565c1f3764f5ffa56a7f8ebf7& 20:16:57 *** reldred has quit IRC 20:22:23 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13642: Codechange: Preprocess text ref stack parameters. https://github.com/OpenTTD/OpenTTD/pull/13642#pullrequestreview-2635239093 20:22:56 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13639: Codechange: remove C-style memory management https://github.com/OpenTTD/OpenTTD/pull/13639 20:29:24 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13642: Codechange: Preprocess text ref stack parameters. https://github.com/OpenTTD/OpenTTD/pull/13642#pullrequestreview-2635250309 20:29:53 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13642: Codechange: Preprocess text ref stack parameters. https://github.com/OpenTTD/OpenTTD/pull/13642#pullrequestreview-2635250681 20:41:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13643: Codechange: Simplify some calls to DrawStringMultiLine(). https://github.com/OpenTTD/OpenTTD/pull/13643 20:53:24 <cu-kai> so interestingly on my system, with mx master 3 mouse, my vertical scrollwheel generates float movement values in SDL in wayland mode, but integer values otherwise. but my horizontal scrollwheel always generates an integer movement value. 20:53:42 <cu-kai> is there a way to tell openttd to zoom in/out regardless of the Y value being >1? i can't find anything obvious in the code. 20:53:50 <cu-kai> i think this would solve the issue 20:54:31 *** Flygon has joined #openttd 20:54:33 <cu-kai> i also think this behaviour might partially be a KDE issue 20:55:12 <cu-kai> but increasing the scroll speed doesn't really help as it's not linear anyway (the faster i scroll the wheel, the higher the float value) 21:00:08 <peter1138> As far as the SDL API is concerned, the scroll wheel argument is integer. 21:00:21 <peter1138> Sint32 y; /**< The amount scrolled vertically, positive away from the user and negative toward the user */ 21:00:27 <_glx_> <https://github.com/OpenTTD/OpenTTD/blob/master/src/video/sdl2_v.cpp#L407-L425> might use float depending on version 21:00:41 <_glx_> though the version check feels wrong 21:01:06 <_glx_> `float preciseX; /**< The amount scrolled horizontally, positive to the right and negative to the left, with float precision (added in 2.0.18) */` 21:01:46 <cu-kai> yeah.. i'm using the SDL_EVENT_LOGGING env var and it's showing floats 21:02:25 <cu-kai> for example: INFO: SDL EVENT: SDL_EVENT_MOUSE_WHEEL (timestamp=3349135512 windowid=4 which=0 x=0 y=0.380469 direction=flipped) 21:03:04 <cu-kai> anyway, i reverted the commit for this and i still have issues 21:03:25 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13642: Codechange: Preprocess text ref stack parameters. https://github.com/OpenTTD/OpenTTD/pull/13642 21:04:12 <_glx_> x and y are definitely int in the doc 21:04:20 <peter1138> INFO: SDL EVENT: SDL_MOUSEWHEEL (timestamp=8775 windowid=1 which=0 x=0 y=1 preciseX=0.000000 preciseY=1.000000 direction=normal) 21:04:23 <peter1138> INFO: SDL EVENT: SDL_MOUSEWHEEL (timestamp=10458 windowid=1 which=0 x=0 y=-1 preciseX=0.000000 preciseY=-1.000000 direction=normal) 21:04:26 <peter1138> INFO: SDL EVENT: SDL_MOUSEWHEEL (timestamp=11258 windowid=1 which=0 x=0 y=1 preciseX=0.000000 preciseY=1.000000 direction=normal) 21:04:29 <peter1138> INFO: SDL EVENT: SDL_MOUSEWHEEL (timestamp=11859 windowid=1 which=0 x=0 y=-1 preciseX=0.000000 preciseY=-1.000000 direction=normal) 21:05:26 <_glx_> `float x; /**< The amount scrolled horizontally, positive to the right and negative to the left */` <-- in sdl3 doc 21:05:34 <peter1138> https://wiki.libsdl.org/SDL3/SDL_MouseWheelEvent 21:05:40 <peter1138> SDL 3 changes things, but we are SDL 2. 21:06:06 <_glx_> yeah an no preciseX 21:06:08 <peter1138> Your diagnostics suggests you've got SDL 3. 21:06:14 <peter1138> But that would be weird. 21:06:41 <_glx_> looks like your openttd is using SDL3 while we only support SDL2 21:07:38 <peter1138> I would expect it to fail to build without other changes. 21:07:46 <_glx_> me too 21:08:53 <peter1138> There exists an SDL2 to SDL3 compatiblity layer. 21:08:57 <peter1138> https://github.com/libsdl-org/sdl2-compat 21:09:22 <peter1138> So kinda smells of that. 21:10:32 <_glx_> really looks like a bad idea 21:12:35 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13642: Codechange: Preprocess text ref stack parameters. https://github.com/OpenTTD/OpenTTD/pull/13642#pullrequestreview-2635293985 21:15:46 <Rubidium> funnily enough their latest commit as of writing this is "Accumulate fractional mouse data", so I guess that if you're using sdl2-compat you're using a version that's essentially broken 21:23:52 <cu-kai> peter1138: i'm on arch and the sdl package got upgraded to sdl3, and now i have an sdl2-compat package 21:25:00 <cu-kai> checking my cmake config, i see this: SDL2_DIR /usr/lib/cmake/SDL2 21:32:06 <peter1138> Yeah, you're out of luck, sorry. 21:32:29 <cu-kai> np, thx anyway. do i just wait for arch to update their package? 21:32:52 <peter1138> You could report the issue to arch, in case they are not aware of sdl2-compat being broken. 21:38:09 <cu-kai> flagging it as broken won't help, will need to wait for them to make another release with the fix, then one can flag the package as out of date. 21:38:19 <cu-kai> anyway, appreciate the help and info. 21:39:12 <peter1138> The first step is making sure they know it's broken. What happens after is up to them. 21:43:59 <cu-kai> i guess this is the downside to being on a bleeding-edge distro :) 21:44:25 <cu-kai> i see a similar issue has already been reported anyway, https://gitlab.archlinux.org/archlinux/packaging/packages/sdl2-compat/-/issues/?sort=created_date&state=closed&first_page_size=20 21:44:45 <cu-kai> specifically #1 on that tracker 21:58:08 <peter1138> Heh, icculus mispelled his name on the arch gitlab. 22:01:52 <xarick> what to do 22:01:55 <peter1138> Well, good luck getting it fixed... as a closed issue because it's "too political" 22:03:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13642: Codechange: Preprocess text ref stack parameters. https://github.com/OpenTTD/OpenTTD/pull/13642 22:03:44 <peter1138> Yolo :D 22:04:57 *** Tirili has joined #openttd 22:06:31 <xarick> can you yolo 13625 too? 22:07:37 <peter1138> I can onlky yolo PRs that are approved. 22:08:16 <xarick> before it's too late 22:08:28 <xarick> and a savegame fixing is required 22:08:36 <xarick> unless it is already required 22:09:40 <xarick> has there been night builds after 11a8b71 already? 22:14:58 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #13625: Fix 11a8b71: Set direction and rotation of ships upon building https://github.com/OpenTTD/OpenTTD/pull/13625#pullrequestreview-2635333344 22:16:22 <xarick> alright, gonna remove those 2 lines 22:18:38 <peter1138> > 96 files changed, 1674 insertions(+), 2165 deletions(-) 22:18:43 <peter1138> Hmm, that didn't help all that much... 22:21:49 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13625: Fix 11a8b71: Set direction and rotation of ships upon building https://github.com/OpenTTD/OpenTTD/pull/13625 22:24:49 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13565: Add #13519, e4c511d: [Script] Saveload and config file support for handpicked configs https://github.com/OpenTTD/OpenTTD/pull/13565 22:27:04 <cu-kai> peter1138: yeah, i'm not sure i'll even bother with that issue tracker. building openTTD against "real" SDL2 fixes the problem 22:27:17 <cu-kai> now i see: INFO: SDL EVENT: SDL_MOUSEWHEEL (timestamp=9946 windowid=1 which=0 x=0 y=0 preciseX=0.000000 preciseY=0.133333 direction=normal) 22:28:20 <cu-kai> specifically using this tag: https://github.com/libsdl-org/SDL/releases/tag/release-2.32.0 22:30:14 <xarick> oops, i merely rebased 13565 22:30:18 <xarick> no changes 22:44:09 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened issue #13645: [Bug]: "Follow vehicle" button stays lowered when not following https://github.com/OpenTTD/OpenTTD/issues/13645 22:53:20 <peter1138> I knew about that one, and forgot about it. 22:53:38 <peter1138> I might have a commit or stash for it. 23:01:36 <peter1138> > STR_ORDER_TEXT :{STRING4} {STRING2} {STRING} {STRING} 23:01:42 <peter1138> Okay, this one is a pain... 23:05:02 *** locosage has quit IRC 23:08:12 <talltyler> Yeah, not to side quest you, but… 23:08:12 <talltyler> https://github.com/OpenTTD/OpenTTD/issues/12267 23:08:36 <peter1138> Sure. 23:08:45 <peter1138> I think I'm going to cheat. 23:32:05 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #13625: Fix 11a8b71: Set direction and rotation of ships upon building https://github.com/OpenTTD/OpenTTD/pull/13625#pullrequestreview-2635351412 23:33:29 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13625: Fix 11a8b71: Set direction and rotation of ships upon building https://github.com/OpenTTD/OpenTTD/pull/13625 23:33:29 <peter1138> Yolo 23:33:42 <peter1138> Hmm, what is this {STRING1} for... 23:33:58 <peter1138> I have a suspicion it's for including another optional part of the string... 23:35:11 *** keikoz has quit IRC 23:37:38 <peter1138> {DEPOT} eats two parameters, right? 23:38:30 *** Wolf01 has quit IRC 23:38:35 * peter1138 tries again. 23:48:51 <_glx_> yup vehicle type and depot id 23:49:22 <_glx_> or station id for aircraft 23:50:57 *** kuka_lie has quit IRC 23:52:50 <_glx_> station id is forwarded to the real string for aircraft, while other types translate to 2 args (town id and counter) 23:54:31 *** HerzogDeXtEr has quit IRC 23:57:21 *** Tirili has quit IRC 23:59:27 <peter1138> Yeah, the code being {DEPOT1} would have saved me some brain.