Times are UTC Toggle Colours
01:19:22 <peter1138[d]> Hmm, scripts failing because a setting doesn't exist is an awkward one 01:19:43 <reldred> huh, bunch of the old C&C games gpl'd 01:41:58 *** Extrems has quit IRC 01:42:34 *** Extrems has joined #openttd 01:50:33 *** HerzogDeXtEr has quit IRC 02:58:37 *** Flygon has joined #openttd 03:00:05 *** herms has quit IRC 03:03:45 *** herms has joined #openttd 03:06:50 *** Wormnest has quit IRC 03:22:36 *** D-HUND has joined #openttd 03:25:54 *** debdog has quit IRC 04:08:31 <talltyler> Yeah, it’s problematic that scripts can access OpenTTD settings directly instead of through an API where we could provide fallback values for depreciated settings. 04:10:07 <talltyler> Similarly, scripts being able to access GUI elements (see: we will never have a tutorial GS that’s stable unless it gets actively maintained alongside the codebase) 04:42:40 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/6afde6787216b303158f9fe168aa7f2be532f593 04:42:41 <DorpsGek> - Update: Translations from eints (by translators) 05:11:34 *** keikoz has joined #openttd 06:25:24 *** keikoz has quit IRC 06:40:05 *** keikoz has joined #openttd 07:17:46 *** D-HUND is now known as debdog 07:26:54 *** Wolf01 has joined #openttd 07:49:14 *** nielsm has joined #openttd 08:09:21 <andythenorth> coffee? 08:11:25 <Rubidium_> no thanks 08:30:41 <truebrain> I see Rubidium is still being followed by a `_` 😄 08:31:24 <Rubidium_> you keep underscoring that... 08:31:31 <truebrain> LordAro: lol, I also noticed OpenMSX 0.4.2 was released, but Steam had 0.4.0 ... as it turns out, BaNaNaS too only has 0.4.0 08:31:32 <truebrain> lol 08:33:14 <truebrain> ironicly, 0.4.2 reads: `Fix: Issue preventing BaNaNaS upload due to a lack of any checksum changes` 08:33:26 <truebrain> but it seems whoever made that release, never actually got to uploading it again 😄 08:34:05 <truebrain> Not pointing fingers, but it was you 😛 Joking around, something you might want to look into again 🙂 08:34:38 <truebrain> owh, in-game 0.4.2 reports as 0.4.0 .. that is also weird 08:36:36 <truebrain> ah, no, Steam hasn't processed my change yet 08:37:06 <truebrain> there we go! 08:37:41 <truebrain> Anyway, LordAro: updated testing/nightly on Steam with OpenSFX 0.7.3 and OpenMSX 0.4.2. I will push this to release a bit later. 08:53:21 <LordAro> \o/ 09:40:55 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345329950697197579/image.png?ex=67c427a7&is=67c2d627&hm=579f94029c346fd2c61e9135c76f71913a25d8e62637a16d4bd384eb1373081f& 09:40:55 <xarick> wow. No AI has crashed! 10:12:47 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13675: Codechange: Pass single rect to DrawString calls instead of separate parameters. https://github.com/OpenTTD/OpenTTD/pull/13675 10:21:38 <peter1138> LordAro, overslept ;( 10:21:44 <peter1138> (But also it's icy) 10:29:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13676: Codechange: Use parameterised GetString() for various build windows. https://github.com/OpenTTD/OpenTTD/pull/13676 10:32:49 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13676: Codechange: Use parameterised GetString() for various build windows. https://github.com/OpenTTD/OpenTTD/pull/13676#pullrequestreview-2652379953 10:37:22 <xarick> AIAI didn't do anything this whole time 😦 10:37:27 <xarick> strange 10:38:58 <xarick> hmm I have my suspicions 10:39:17 <xarick> he used to place signs near his headquarters 10:39:42 <xarick> he didn't this time 10:39:54 <xarick> and he's stuck... probably string Text related? 10:45:21 <xarick> oh... this thing is making use of a library 10:46:08 <peter1138> > 1.1.1 BUUUUUUURN! 10:46:13 <peter1138> Useful dianogistic. 10:46:24 <peter1138> Or, indeed, diagnostic. 10:47:42 <peter1138> 4 of them suicided. 1 built an HQ but nothing else. 10:48:34 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345346974286745630/image.png?ex=67c43782&is=67c2e602&hm=7decba9cbdbc537272aafc182a3b01473cd8bb9fb07c5fee398b537596b9b2b3& 10:48:37 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13677: Codechange: Use parameterised GetString for NetworkTextMessage https://github.com/OpenTTD/OpenTTD/pull/13677 10:48:54 <xarick> I don't see these signs on the map 10:51:13 <xarick> I have a breakpoint in ScriptSign::BuildSign and it's not reached 10:57:01 <xarick> if (type(text) == "string") return text; shouldn't it be typeof? 10:57:24 <xarick> in the compat_14.nut 11:00:02 *** kuka_lie has joined #openttd 11:01:44 *** HerzogDeXtEr has joined #openttd 11:02:25 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 updated pull request #13677: Codechange: Use parameterised GetString for NetworkTextMessage https://github.com/OpenTTD/OpenTTD/pull/13677 11:04:31 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345350989393301545/image.png?ex=67c43b3f&is=67c2e9bf&hm=ea76cdc875ee531b4c98829ef1605b9da3c5c914bca6b9f9c8a5841502fd004b& 11:04:31 <xarick> well, it's stuck somewhere in the vm 11:04:47 <xarick> and going nowhere? 11:08:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13676: Codechange: Use parameterised GetString() for various build windows. https://github.com/OpenTTD/OpenTTD/pull/13676 11:22:33 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13677: Codechange: Use parameterised GetString for NetworkTextMessage https://github.com/OpenTTD/OpenTTD/pull/13677#pullrequestreview-2652393661 11:23:10 <xarick> it's looping over and over again, going nowhere 11:29:09 <xarick> Summon _glx_ ! 11:40:47 <peter1138> Hmm 11:42:59 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13677: Codechange: Use parameterised GetString for NetworkTextMessage https://github.com/OpenTTD/OpenTTD/pull/13677 11:43:38 <peter1138> "Oh no! Conflicts!" </paraphrasing> 11:43:56 <andythenorth> I am conflicts 11:44:37 <Rubidium_> talking about those few conflicts 13285 has? 11:45:44 <peter1138> Yeah :) 11:46:19 <peter1138> I'm also joking and taking the mick out of "someone". 11:46:26 <peter1138> My local copy of the branch is up to date. 11:46:45 *** akimoto has joined #openttd 11:54:27 *** akimoto has quit IRC 11:55:45 <_glx_> xarick: `type()` and `typeof()` are similar, but `typeof()` calls `_typeof` metamethod for tables and instances 11:57:45 <_glx_> xarick: It actually built the HQ and the setting for contact info is correct ? 11:58:44 <xarick> I think, not sure, it's stuck inside `type(text) == "string"`, looping over and over without a result 11:59:23 <xarick> with the occasional script suspend 12:00:20 <_glx_> Script suspend is when opcode limit is reached 12:00:42 <xarick> yeah, it's consuming ops, but the operations end up being repeated 12:03:31 <peter1138> Hmm, should I use push/pop colour, or just use the original colour code again? 12:04:18 <peter1138> Something like `{WHITE}A {PUSH_COLOUR}{RAW_STRING}{POP_COLOUR} B` vs `{WHITE}A {RAW_STRING}{WHITE} B` 12:04:52 *** nielsm has quit IRC 12:10:41 <Rubidium_> push/pop shows the intent more clearly, though... should we allow the colour of a substring to spill into the main string at all? In other words, should 'push'/'pop' maybe be implicit? 12:11:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13678: Fix: NewGRF text with colour codes affects text in error window. https://github.com/OpenTTD/OpenTTD/pull/13678 12:11:46 <peter1138> Rubidium_, hmmm, reasonable point. 12:12:47 <Rubidium_> though push/pop will work for now. It'd be easy to find later on 12:12:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13678: Fix: NewGRF text with colour codes affects text in error window. https://github.com/OpenTTD/OpenTTD/pull/13678#issuecomment-2692174984 12:13:37 <peter1138> Of course, it's also possible for the substring to push a different colour... 12:14:21 <Rubidium_> please main-quest the SetDParam stuff :D 12:22:01 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345370493888499794/image.png?ex=67c44d69&is=67c2fbe9&hm=afe8b53a7456d0f2fc04e3161faea3b9c4266a6bedddb777d1d31284ada456ef& 12:22:02 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345370494207004784/image.png?ex=67c44d69&is=67c2fbe9&hm=ed4c94643993f5a707e3650e9ed507bba30a76b46e6f152986909a8ee2ac7cc9& 12:22:53 <xarick> so I was wrong 12:24:27 <xarick> what is this telling me? 12:24:45 <xarick> that the return text isn't working well? 12:24:58 <xarick> ScriptSign.BuildSign isn't reached 12:25:11 <xarick> i have a breakpoint there, and it's not triggered 12:33:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13678: Fix: NewGRF text with colour codes affects text in error window. https://github.com/OpenTTD/OpenTTD/pull/13678#pullrequestreview-2652404109 12:37:32 <_glx_> xarick: Maybe put a breakpoint in `Param<Text *>::Get()` 12:39:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13679: Codechange: Use parameterised GetString() for town windows. https://github.com/OpenTTD/OpenTTD/pull/13679 12:51:53 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13678: Fix: NewGRF text with colour codes affects text in error window. https://github.com/OpenTTD/OpenTTD/pull/13678 12:52:41 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13679: Codechange: Use parameterised GetString() for town windows. https://github.com/OpenTTD/OpenTTD/pull/13679#pullrequestreview-2652409994 13:05:46 <peter1138> Hmm, maybe it's time to throw out my old PC. 13:07:47 <peter1138> (The one I made in 2008 and replaced in 2018-ish) 13:10:21 <xarick> Param<Text *>::Get(), where is that? 13:20:09 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13679: Codechange: Use parameterised GetString() for town windows. https://github.com/OpenTTD/OpenTTD/pull/13679 13:23:42 <_glx_> anyway I can confirm the weird behaviour, it works fine in beta, it doesn't in master 13:26:57 <_glx_> oh I have an idea about what could be the issue 13:28:47 <xarick> ) 13:34:11 <_glx_> ah no it's not that 14:00:42 <_glx_> I don't understand, when I run regression as 14 it's fine, but AIAI seems locked 14:04:20 <xarick> regression builds signs? 14:05:09 <xarick> oh, it does 14:05:41 <xarick> wondering if AIAI has a <- Text or something 14:08:32 <xarick> it has SuperLib 14:09:48 <xarick> ah! found something 14:10:01 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345397672734883972/image.png?ex=67c466b9&is=67c31539&hm=4e87ffd0ab15666bcfc855c87a5e677575b97c75ac0c62d222136548424567ca& 14:10:07 <xarick> what is Helper 14:10:18 <xarick> Helper <- SuperLib.Helper 14:11:52 <xarick> dang, i need to load superlib, i have no idea what version 14:12:33 <xarick> 39 14:20:49 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345400390614777888/image.png?ex=67c46941&is=67c317c1&hm=6a9d1116ad6cbdd52ebf8e531e90236c7d17083d5a7a4bd7fbc9c91a3df6d227& 14:20:49 <xarick> nothing out of the ordinary 14:23:20 <xarick> oh 14:23:43 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345401120239128586/image.png?ex=67c469ef&is=67c3186f&hm=4b1bb1fe1115c3178e61c6981b17a8b59bcd62bc0f03e2a707c08ae56f7341f0& 14:23:43 <xarick> this might be it 14:24:07 *** Smedles has quit IRC 14:24:23 *** Smedles has joined #openttd 14:26:08 <_glx_> oh indeed, could create an infinite loop 14:26:52 <_glx_> stupid authors 14:26:58 <xarick> hehah 14:27:33 <xarick> return returned 14:28:28 <_glx_> redefining _BuildSign, which is used in BuildSign 14:28:48 <_glx_> do BuildSign will actually call itself 14:29:36 <xarick> I'm not sure, never tried 14:30:20 <xarick> gonna add some Log Info around 14:33:51 <_glx_> https://gist.github.com/glx22/741c5688e87a0ea9263fc54c48d56370 <-- for the fun 14:34:00 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345403705461182554/image.png?ex=67c46c57&is=67c31ad7&hm=dc40f3edbc6b73d940a96713e712e8e6ce30d84b953baa878ccfa0b0ff6b9396& 14:34:01 <_glx_> same behaviour 14:34:27 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1345403820598886460/image.png?ex=67c46c73&is=67c31af3&hm=efe11d8c89f1b4897bbb5b809d8558089daa9023a5ff6bb31dc801d58c398fdd& 14:34:27 <_glx_> it's stuck 14:35:51 <_glx_> so we need a work around authors doing stupid things 14:37:19 <xarick> im not understanding why it gets stuck 14:38:02 <peter1138> Instead of compat defining _BuildSign, we could define something more unique, _BuildSignCompat14 or whatever 14:38:30 <_glx_> it's stuck because _BuildSign is now BuildSign, and BuildSign calls _BuildSign, so BuildSign calls BuildSign 14:39:07 <xarick> ah, i guess i see the problem 14:39:12 <_glx_> peter1138: yeah that's what I'm starting to do 14:44:30 <xarick> it's the compat that's calling itself, i got it now 14:44:59 <xarick> with its return 14:45:06 <peter1138> It's a AISign._BuildSignCompat14 <- AISign.BuildSign; 14:45:06 <peter1138> AISign.BuildSign <- function(id, name) { return AISign._BuildSignCompat14(id, AICompat14.Text(name)); } 14:45:09 <peter1138> Er.. 14:45:12 <peter1138> -It's a 14:45:27 <peter1138> With that, the AI gets further. So we just need to tweak all the existing compat to work around it. 14:45:41 <peter1138> This has been a potential issue all the time. 14:46:01 <peter1138[d]> 🙂 14:46:01 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1345406733400674385/image.png?ex=67c46f29&is=67c31da9&hm=017e9aa1bbfaf56d6528eb7317597e62aae34a87823a635040c781b21e0d35e8& 14:47:05 <_glx_> I have a patch ready 🙂 14:47:17 <xarick> thx for looking into it 14:47:47 <xarick> wouldn't this end up in an overflow ? 14:48:02 <xarick> its recursively calling itself 14:48:24 <peter1138> _glx_, yes, I just wanted to confirm it, I'm not doing anything else :-) 14:53:52 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #13680: Fix: [Script] Make compat layers fool proof https://github.com/OpenTTD/OpenTTD/pull/13680 14:54:39 <_glx_> oh I should do it for GS too 14:57:12 <xarick> some kind of hash replacing function name? 14:57:26 <xarick> meh... probably fine 14:58:15 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13680: Fix: [Script] Make compat layers fool proof https://github.com/OpenTTD/OpenTTD/pull/13680 15:00:56 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened issue #13681: [Bug]: GRFs without parameters show error string in GRF Settings window https://github.com/OpenTTD/OpenTTD/issues/13681 15:02:28 <_glx_> so it was actually my idea about the issue, but I could not find evidences 🙂 15:03:31 <_glx_> kinda luck we didn't encounter it before 15:09:39 *** jinks has quit IRC 15:34:04 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13682: Fix #13681: Missing unused string parameter for NewGRF parameter string. https://github.com/OpenTTD/OpenTTD/pull/13682 15:39:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13682: Fix #13681: Missing unused string parameter for NewGRF parameter string. https://github.com/OpenTTD/OpenTTD/pull/13682#pullrequestreview-2652499933 15:44:14 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13680: Fix: [Script] Make compat layers fool proof https://github.com/OpenTTD/OpenTTD/pull/13680#pullrequestreview-2652500785 15:51:28 <xarick> so, that means... 15:51:40 <xarick> more conflicts to solve 16:05:51 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13680: Fix: [Script] Make compat layers fool proof https://github.com/OpenTTD/OpenTTD/pull/13680 16:08:49 *** Open has joined #openttd 16:09:18 *** Open has quit IRC 16:12:56 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13682: Fix #13681: Missing unused string parameter for NewGRF parameter string. https://github.com/OpenTTD/OpenTTD/pull/13682 16:12:59 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #13681: [Bug]: GRFs without parameters show error string in GRF Settings window https://github.com/OpenTTD/OpenTTD/issues/13681 16:13:15 *** Wormnest has joined #openttd 16:17:13 <peter1138> Hmm. 16:19:09 <andythenorth> I have not had much coffee 16:19:34 <andythenorth> hmm Horse side quest 16:19:44 <andythenorth> should I add a cost adjustment parameter to Horse 16:22:42 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13556: Add: [Script] Framework for loading/saving selected ScriptObject https://github.com/OpenTTD/OpenTTD/pull/13556 16:43:48 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13683: Codechange: Use parameterised GetString() for graph windows. https://github.com/OpenTTD/OpenTTD/pull/13683 16:47:33 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13683: Codechange: Use parameterised GetString() for graph windows. https://github.com/OpenTTD/OpenTTD/pull/13683#pullrequestreview-2652524731 16:50:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13684: Codechange: Use parmeterised GetString() for smallmap window. https://github.com/OpenTTD/OpenTTD/pull/13684 16:53:29 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13684: Codechange: Use parmeterised GetString() for smallmap window. https://github.com/OpenTTD/OpenTTD/pull/13684#pullrequestreview-2652525501 16:59:26 <peter1138> Hmm, I think that bit of window needs redesigning too. 17:04:32 *** Flygon has quit IRC 17:10:07 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13684: Codechange: Use parameterised GetString() for smallmap window. https://github.com/OpenTTD/OpenTTD/pull/13684 17:10:28 <peter1138> (In case anyone is wondering, this is why I'm doing these as lots of small PRs) 17:18:06 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13684: Codechange: Use parameterised GetString() for smallmap window. https://github.com/OpenTTD/OpenTTD/pull/13684#pullrequestreview-2652532470 17:18:14 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13683: Codechange: Use parameterised GetString() for graph windows. https://github.com/OpenTTD/OpenTTD/pull/13683#issuecomment-2692325783 17:20:07 <peter1138> Hmm, that was the wrong PR to comment on :-) 17:20:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13684: Codechange: Use parameterised GetString() for smallmap window. https://github.com/OpenTTD/OpenTTD/pull/13684#pullrequestreview-2652533426 17:22:23 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13683: Codechange: Use parameterised GetString() for graph windows. https://github.com/OpenTTD/OpenTTD/pull/13683 17:23:34 *** tokai|noir has joined #openttd 17:23:35 *** ChanServ sets mode: +v tokai|noir 17:28:05 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13457: Change: [Script] Remove IsValidBaseStation https://github.com/OpenTTD/OpenTTD/pull/13457 17:30:35 *** tokai has quit IRC 17:32:58 *** jinks has joined #openttd 17:55:19 *** kuka_lie has quit IRC 18:10:22 <_zephyris> Idle thought: Lack of flat docks, docks not on slopes, isn't a problem... Rivers not in valleys is the problem. 18:11:00 <talltyler> Flat docks would be useful on canals though 18:14:42 <_zephyris> Yeah, fair point. 18:16:01 <talltyler> I do want rivers in valleys, though, if only to make bridges over rivers look better 18:16:24 <talltyler> Hump bridges for railways never look right to me 18:18:13 *** bigyihsuan has joined #openttd 18:18:13 <bigyihsuan> andythenorth: Yes please 18:19:38 <andythenorth> ok, and to all my other grfs? 18:19:46 <andythenorth> what should the values be? 18:20:31 <andythenorth> and should the parameter apply a multiplier before or after any base costs grf? 18:24:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13684: Codechange: Use parameterised GetString() for smallmap window. https://github.com/OpenTTD/OpenTTD/pull/13684 18:26:28 <peter1138> Oops. I had to nap. 18:26:53 <Rubidium_> those are the best ones ;) 18:43:20 <DorpsGek> [OpenTTD/OpenGFX] jayaddison opened pull request #96: Script-Fu: update to GIMP3-compatible implementation https://github.com/OpenTTD/OpenGFX/pull/96 18:46:31 <DorpsGek> [OpenTTD/OpenGFX] jayaddison commented on issue #94: gimpscript: GIMP3 compatibility problem(s) https://github.com/OpenTTD/OpenGFX/issues/94 18:55:21 <peter1138> Does FIRS5 stockpile? 18:55:40 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345469556352880792/image.png?ex=67c4a9ab&is=67c3582b&hm=6b96464b7baa23bb18aad9c93402e7a01141c4332f2c5b27272a3d33274946cf& 18:55:40 <xarick> uh oh... there's more... 18:57:48 <xarick> AIVehicle.SetName(vehicle_id, "new vehicle from " + depot_tile) 18:58:41 <xarick> he also has a custom SetName 18:58:54 <xarick> and a custom build vehicle 18:59:21 <_glx_> But it's properly using compat stuff now 18:59:32 <_glx_> As the trace shows 18:59:46 <xarick> why aren't integers converted to string? 19:00:05 <xarick> I have a vague memory about it and I think it used to do that automaticaly 19:00:43 <xarick> but... let me try 1.15 19:00:59 <xarick> gonna rename his misappropriated functions 19:01:12 <xarick> oh, dinner time, will do it after 19:09:55 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1345473143795486851/image.png?ex=67c4ad03&is=67c35b83&hm=61f9b32992ffeed2704670c54f9fa98250ac5513280ad69a23266ea495f91ab9& 19:09:55 <peter1138[d]> Hmm 19:10:13 <peter1138> Well I guess accepts isn't requires. 19:10:50 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13685: Codechange: Use parameterised GetString() for industry window. https://github.com/OpenTTD/OpenTTD/pull/13685 19:17:58 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13685: Codechange: Use parameterised GetString() for industry window. https://github.com/OpenTTD/OpenTTD/pull/13685#pullrequestreview-2652563790 19:20:19 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13685: Codechange: Use parameterised GetString() for industry window. https://github.com/OpenTTD/OpenTTD/pull/13685 19:21:16 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13685: Codechange: Use parameterised GetString() for industry window. https://github.com/OpenTTD/OpenTTD/pull/13685#pullrequestreview-2652564628 19:39:58 *** soylent_cow[m] has joined #openttd 19:39:59 <soylent_cow[m]> found this nice newgrf: Raise landscaping costs - awesome design, super easy and exactly what one would want for tempering landscape artists 19:51:13 <xarick> `if (AIVehicle.SetName_(vehicle_id, string + " [" + vehicle_id + "]")) {` 19:51:47 <xarick> this version of SetName_ is the one in compat_14 19:51:55 <xarick> he's doing string operations 19:52:15 <andythenorth> peter1138: It does not 19:55:21 <xarick> vehicle_id is 28, string is actualy integer 19:55:27 <xarick> it's the depot tile 19:57:43 <xarick> difficult to make sense of his stuff 19:59:47 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13685: Codechange: Use parameterised GetString() for industry window. https://github.com/OpenTTD/OpenTTD/pull/13685 20:02:02 <xarick> ```AIVehicle.SetName(vehicle_id, "new vehicle from " + depot_tile) 20:02:02 <xarick> // Calls AIAI's SetName version with "new vehicle from 7079137" 20:02:02 <xarick> if (AIVehicle.SetName_(vehicle_id, string + " [" + vehicle_id + "]")) { 20:02:02 <xarick> // Calls compat_14's SetName version with "new vehicle from 7079137 [28]" 20:02:02 <xarick> // crashes``` 20:04:34 <xarick> attempt to call 'integer' 20:13:29 <xarick> <https://github.com/OpenTTD/OpenTTD/blob/master/src/3rdparty/squirrel/squirrel/sqvm.cpp#L853> 20:13:37 <xarick> what failed 20:15:07 <xarick> it is considering "new vehicle from 7079137 [28]" as integer? 20:15:27 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13556: Add: [Script] Framework for loading/saving selected ScriptObject https://github.com/OpenTTD/OpenTTD/pull/13556 20:18:14 <_glx_> oh maybe it's "type" 20:18:47 <_glx_> as it's the only call in Text() 20:23:03 <_glx_> the error points to ` if (type(text) == "string") return text;` so somehow `type` became an integer 20:31:00 <xarick> //hard core spaghetti code(reissues the OP_CALL to invoke the constructor) 20:31:10 <xarick> hmm something gone bad? 20:31:34 <_glx_> OP_CALL is a function call, so type() 20:32:08 <_glx_> but myAPIPatch.nut:156 redefines `type` 20:32:44 <_glx_> (it misses a `local`) 20:37:33 <peter1138> Isn't type a keyword? 20:37:38 <peter1138> Kinda. 20:38:20 <peter1138> Having to define a alias for everything just in case a script messes up... :/ 20:40:19 <_glx_> no it's a standard lib function 20:41:11 <xarick> oh really? 20:42:07 <xarick> i see now 20:42:18 <xarick> the integer is 3, that's aircraft, right? 20:44:28 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345496939285975214/image.png?ex=67c4c32c&is=67c371ac&hm=7ba86222b7755077d1ff7388a64e48d9fc8d4c57d0ba80b1596d811d96598037& 20:44:45 <xarick> let me try adding local 20:45:36 <xarick> ahmm... 20:45:45 <xarick> it's a member apparently? 20:45:54 <xarick> this.type 20:49:39 <_glx_> no it's `CheckBuildVehiclePreconditions()` doing `type = AIEngine.GetVehicleType(engine_id)` which overwrites the stdlib `type` 20:50:59 <xarick> that's strange, shouldn't that just error out instead? 20:51:06 <xarick> why it works in 1.15? 20:52:42 <_glx_> because 15 doesn't need any compat layer 20:54:15 <xarick> I mean `type` instead of `local type` 20:54:35 <xarick> if it's not erroring out, then type must already exist somehow 20:54:59 <xarick> i think it's a class member... 20:55:13 <_glx_> type exists, it's an stdlib in root table 20:55:45 <_glx_> like array 20:56:46 <_glx_> or assert or print 20:57:21 <xarick> ah 20:57:47 <_glx_> but I'll switch to typeof operator, easier 20:58:08 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345500379600654427/image.png?ex=67c4c660&is=67c374e0&hm=fb5930aed21a4ff01967f62cb25dc5586f4262d8e768475a01b8bc44bb21b959& 20:58:27 <xarick> gonna test some stuff 20:59:02 <_glx_> it's not this one 20:59:17 <_glx_> this "type" is a class member 21:01:08 <xarick> look like you're on the right track 21:03:42 <xarick> local type works indeed 🙂 21:04:10 <xarick> AIAI really is... something! 21:08:16 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #13686: Fix: [Script] "type" std function might be redefined by scripts https://github.com/OpenTTD/OpenTTD/pull/13686 21:10:41 <xarick> twice AIAI's fault 21:12:44 <xarick> meanwhile I'm renaming Route.type to Route.route_type over here 21:13:44 <_glx_> oh it's nice when AI does unexpected stuff showing bugs in our code 21:18:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13687: Codechange: prepare replacing SetStringParameters with GetWidgetString https://github.com/OpenTTD/OpenTTD/pull/13687 21:20:57 <xarick> it still suffers from cpu evaluation 21:21:01 <xarick> oh well 21:27:44 <peter1138> I thought you tried typeof before and that had other issues? 21:28:22 <_glx_> it had issues with _typeof metamethod, but I reverted that 21:28:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13285: Codechange: Remove global string parameters. https://github.com/OpenTTD/OpenTTD/pull/13285 21:28:55 <_glx_> mostly it was _typeof metamethod affecting scripts using typeof operator 21:31:58 <peter1138> (Just to prove it is updated...) 21:35:37 <_glx_> now I understand why most std function are actually disabled via EXPORT_DEFAULT_SQUIRREL_FUNCTIONS 21:39:14 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13688: Codechange: Use parameterised GetString() for framerate window. https://github.com/OpenTTD/OpenTTD/pull/13688 21:40:10 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13689: Codechange: Use parameterised GetString() for world generation window. https://github.com/OpenTTD/OpenTTD/pull/13689 21:40:52 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13690: Codechange: Use parameterised GetString() for company windows. https://github.com/OpenTTD/OpenTTD/pull/13690 21:41:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13691: Codechange: Use parameterised GetString() for depot window. https://github.com/OpenTTD/OpenTTD/pull/13691 21:41:54 <peter1138> spam de spam, glorious spam... 21:43:17 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13688: Codechange: Use parameterised GetString() for framerate window. https://github.com/OpenTTD/OpenTTD/pull/13688#pullrequestreview-2652585004 21:43:31 <johnfranklin> Is “DD51 JNR” a legal-formated car plate in the UK? 21:43:49 <peter1138> Yes. 21:44:48 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13691: Codechange: Use parameterised GetString() for depot window. https://github.com/OpenTTD/OpenTTD/pull/13691#pullrequestreview-2652585176 21:46:05 <johnfranklin> Maybe it is already used… I don’t expect to find that car. 21:46:46 <johnfranklin> But OPEN TTD is not legal. 21:47:11 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13689: Codechange: Use parameterised GetString() for world generation window. https://github.com/OpenTTD/OpenTTD/pull/13689#pullrequestreview-2652585457 21:52:03 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13690: Codechange: Use parameterised GetString() for company windows. https://github.com/OpenTTD/OpenTTD/pull/13690#pullrequestreview-2652586103 21:53:06 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13686: Fix: [Script] "type" std function might be redefined by scripts https://github.com/OpenTTD/OpenTTD/pull/13686#pullrequestreview-2652586238 21:59:55 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13556: Add: [Script] Framework for loading/saving selected ScriptObject https://github.com/OpenTTD/OpenTTD/pull/13556#pullrequestreview-2652586580 22:01:17 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13686: Fix: [Script] "type" std function might be redefined by scripts https://github.com/OpenTTD/OpenTTD/pull/13686 22:04:01 <peter1138> Hm. 22:05:40 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13556: Add: [Script] Framework for loading/saving selected ScriptObject https://github.com/OpenTTD/OpenTTD/pull/13556 22:07:18 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #13285: Codechange: Remove global string parameters. https://github.com/OpenTTD/OpenTTD/pull/13285#pullrequestreview-2652588102 22:16:39 <talltyler> This is an interesting challenge. We should make the music play faster when fast-forwarding 😛 22:16:39 <talltyler> https://www.youtube.com/watch?v=ddpXbIB4_2g 22:17:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13688: Codechange: Use parameterised GetString() for framerate window. https://github.com/OpenTTD/OpenTTD/pull/13688 22:18:40 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13689: Codechange: Use parameterised GetString() for world generation window. https://github.com/OpenTTD/OpenTTD/pull/13689 22:25:15 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13690: Codechange: Use parameterised GetString() for company windows. https://github.com/OpenTTD/OpenTTD/pull/13690 22:26:19 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13692: Codechange: Use parameterised GetString() for station view. https://github.com/OpenTTD/OpenTTD/pull/13692 22:27:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13691: Codechange: Use parameterised GetString() for depot window. https://github.com/OpenTTD/OpenTTD/pull/13691 22:36:26 <peter1138> Well. 22:37:41 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13692: Codechange: Use parameterised GetString() for station view. https://github.com/OpenTTD/OpenTTD/pull/13692#pullrequestreview-2652591630 22:41:53 *** Wolf01 has quit IRC 22:45:00 *** keikoz has quit IRC 22:46:15 <xarick> conflicts! 22:46:31 <xarick> I'm now used to them 22:58:19 <peter1138> Great, you can avoid complaining about them then. 23:03:27 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13693: Codechange: Use parameterised GetString() for group window. https://github.com/OpenTTD/OpenTTD/pull/13693 23:04:55 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13692: Codechange: Use parameterised GetString() for station view. https://github.com/OpenTTD/OpenTTD/pull/13692 23:06:14 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #13693: Codechange: Use parameterised GetString() for group window. https://github.com/OpenTTD/OpenTTD/pull/13693#pullrequestreview-2652595045 23:42:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13693: Codechange: Use parameterised GetString() for group window. https://github.com/OpenTTD/OpenTTD/pull/13693 23:45:11 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13694: Codechange: Use parameterised GetString() for remaining windows. https://github.com/OpenTTD/OpenTTD/pull/13694 23:47:36 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13695: Codechange: Use parameterised GetString() for settings window. https://github.com/OpenTTD/OpenTTD/pull/13695 23:55:33 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13695: Codechange: Use parameterised GetString() for settings window. https://github.com/OpenTTD/OpenTTD/pull/13695#pullrequestreview-2652600489 23:58:22 *** negi has joined #openttd