Times are UTC Toggle Colours
01:43:58 *** Supercheese has joined #openttd.dev 02:01:26 *** LordAro has quit IRC 03:09:17 *** JGR_ has joined #openttd.dev 03:11:52 *** JGR has quit IRC 07:08:59 *** LordAro has joined #openttd.dev 07:08:59 *** ChanServ sets mode: +v LordAro 07:26:26 *** Supercheese has quit IRC 09:10:16 *** frosch123 has joined #openttd.dev 09:10:16 *** ChanServ sets mode: +v frosch123 09:33:00 *** Sturmi has joined #openttd.dev 12:18:40 *** Ristovski has joined #openttd.dev 15:55:02 *** Zuu has joined #openttd.dev 15:55:02 *** ChanServ sets mode: +v Zuu 16:38:35 <Zuu> When OpenTTD decode received JSON from the admin port it fails on decoding an empty array. This patch fixes this: http://devs.openttd.org/~zuu/json_decode.patch 16:39:50 <frosch123> isn't just "SKIP_EMPTY(p);" enough? 16:40:05 <frosch123> so the "while" catches he ] ? 16:40:36 <Zuu> The problem is that this->ReadValue will return an error code without my patch. 16:40:47 <frosch123> ah, it skips the first char then 16:40:55 <Zuu> Because ReadValue will start at ']' 16:41:23 <frosch123> weird loop actually 16:41:59 <Zuu> It is possible with fewer lines to at the beginning of the loop do a SKIP_EMPTY(p); and if (p == ']') break; 16:42:20 <Zuu> However, then you do checks thate are only useful in the first loop at every iteration of the loop. 16:43:36 <frosch123> yeah, diff looks fine 16:43:41 <Zuu> One can possible try to re-write the loop to make a prettier solution while hopefully not breaking any feature of the current solution. 16:46:53 <Zuu> But as the loop is not that straight forward, I fear that I would easily break something. 16:47:26 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25809 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:56:13 *** Supercheese has joined #openttd.dev 17:36:29 <Zuu> Hmm ScriptEventAdminPort::ReadString do not bail out on \" in a string, but it doesn't remove the \ in the string pushed into Squirrel. 17:37:52 <Zuu> http://paste.openttdcoop.org/show/2693/ <-- ScriptEventAdminPort::ReadString 17:40:38 <Zuu> I guess one could allocate a buffer and make a copy just before sq_pushstring. On this buffer we could run find-and-replace \" => " and then use the buffer as input to sq_pushstring 17:45:21 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25810 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 17:49:58 *** Alberth has joined #openttd.dev 17:49:58 *** ChanServ sets mode: +v Alberth 19:24:21 *** andythenorth has joined #openttd.dev 19:24:21 *** ChanServ sets mode: +v andythenorth 19:24:22 *** andythenorth has left #openttd.dev 19:25:25 *** andythenorth has quit IRC 21:10:55 *** Alberth has left #openttd.dev 22:08:28 *** Ristovski has quit IRC 22:14:20 *** Zuu has quit IRC 22:18:27 *** frosch123 has quit IRC 23:35:18 *** LordAro has quit IRC