Log for #openttd on 8th October 2009:
Times are UTC Toggle Colours
00:01:16  *** KritiK [] has quit [Quit: Leaving]
00:13:10  *** Zuu [] has quit [Quit: Leaving]
00:20:44  *** Chris_Booth [] has quit [Quit: ChatZilla 0.9.85 [Firefox 3.5.3/20090824101458]]
00:21:40  *** Zahl [] has quit [Quit: *schiel*]
00:29:50  *** dartagnan [] has joined #openttd
00:39:40  *** Rubix`` [~wrqwer@] has joined #openttd
00:42:57  *** KenjiE20|LT [] has joined #openttd
00:43:23  *** KenjiE20 [~KenjiE20@] has quit [Quit: WeeChat 0.3.0]
01:17:03  *** dartagnan [] has quit [Remote host closed the connection]
01:17:56  *** Dred_furst [] has joined #openttd
01:21:19  *** Rubix`` [~wrqwer@] has quit [Read error: Connection reset by peer]
01:21:36  *** Rubix`` [~wrqwer@] has joined #openttd
01:27:43  *** Dred_furst [] has quit [Quit: Leaving]
01:48:33  *** KenjiE20|LT [] has quit [Quit: Leaving]
01:54:33  *** Chruker [] has quit []
02:03:00  *** Rubix`` [~wrqwer@] has quit [Read error: Connection reset by peer]
02:03:13  *** Rubix`` [~wrqwer@] has joined #openttd
02:13:31  *** Dred_furst [] has joined #openttd
02:15:11  *** Dred_furst [] has quit []
02:22:12  *** Fuco [] has quit [Ping timeout: 480 seconds]
02:44:11  *** Rubix`` [~wrqwer@] has quit [Read error: Connection reset by peer]
02:44:56  *** Rubix`` [~wrqwer@] has joined #openttd
03:03:14  *** glx [glx@2a01:e35:2f59:c7c0:972:6243:da38:cc4d] has quit [Quit: bye]
03:07:17  *** Rubix`` [~wrqwer@] has quit [Quit: Ping timeout: 540 seconds]
03:42:25  *** Pikka [PikkaBird@] has joined #openttd
03:58:37  *** Pikka [PikkaBird@] has quit [Ping timeout: 480 seconds]
04:14:57  *** Pikka [PikkaBird@] has joined #openttd
04:23:45  *** Splex [~splex@] has quit [Quit: Leaving]
04:24:52  *** Splex [~splex@] has joined #openttd
04:54:43  *** lugo [] has joined #openttd
05:44:34  <Pikka> huzzah, I made OTTD asplode
05:48:26  <Pikka> hmm
05:48:35  <Pikka> I think it may be that it objects to vehicles with no weight :o
05:49:47  <Eddi|zuHause> a missing sanity check is clearly a bug
05:50:45  <Pikka> yes, 0 weight was indeed the problem
05:50:48  *** XeryusTC is now known as Xeryus|bnc
05:50:55  * Prof_Frink checks for sanity... none found.
06:15:10  *** Cybertinus [] has joined #openttd
06:15:35  *** andythenorth [] has joined #openttd
06:19:54  *** zachanima [] has quit [Ping timeout: 480 seconds]
06:29:06  <Pikka> hmm
06:30:08  <andythenorth> mmm hmmm
06:33:56  <Pikka> I see
06:34:10  <Pikka> train lengths < 3/8 don't work in the stable...
06:35:06  *** zachanima [] has joined #openttd
06:38:43  <Pikka> oh well... makes the coding easier, even if the end result is slightly off. :)
06:53:14  *** Phoenix_the_II [] has quit [Read error: Connection reset by peer]
07:01:10  *** boekabart [] has joined #openttd
07:11:31  *** thepalm [~chatzilla@] has joined #openttd
07:19:34  *** Xaroth_ [~Xaroth@] has joined #openttd
07:20:55  *** Terkhen [~terkhen@] has joined #openttd
07:22:52  <Terkhen> good morning
07:23:03  <andythenorth> morning Terkhen
07:23:10  <andythenorth> new acceleration patch :)
07:25:16  <Terkhen> not many new features for road vehicles... and I hope that there are not new bugs either
07:26:21  *** Xaroth [~Xaroth@] has quit [Ping timeout: 480 seconds]
07:29:07  <andythenorth> I'll compile and test soon
07:30:08  <Terkhen> great, thanks :)
07:30:32  <Terkhen> I'll have to make more testing soon too
07:38:23  *** guru3 [~guru3@2002:4e69:a155::1] has quit [Read error: Connection reset by peer]
07:38:32  *** guru3 [~guru3@2002:4e69:a155::1] has joined #openttd
07:40:03  *** welshdragon [~markjones@] has joined #openttd
07:47:46  <dihedral> morningses
07:48:07  *** welshdragon [~markjones@] has quit [Ping timeout: 480 seconds]
07:51:47  *** Doorslammer [] has joined #openttd
08:02:22  *** andythenorth [] has quit [Quit: andythenorth]
08:08:42  *** Bergee [] has quit [Ping timeout: 480 seconds]
08:12:49  *** Bergee [] has joined #openttd
08:16:37  *** Pikka [PikkaBird@] has quit [Ping timeout: 480 seconds]
08:17:49  *** fonsinchen [] has joined #openttd
08:26:52  *** Muxy [] has joined #openttd
08:32:51  *** Pikka [PikkaBird@] has joined #openttd
08:33:28  <Pikka> hmmmm
08:34:52  *** Xaroth [~Xaroth@] has joined #openttd
08:36:15  <Pikka> here's a fun-time bug
08:36:48  <Pikka> callback 36 for cargo capacity (prop 14) only works if the train vehicle is carrying its original cargo type
08:41:14  *** Xaroth_ [~Xaroth@] has quit [Ping timeout: 480 seconds]
08:43:06  <Sacro> sigh, this lecture is so boring
08:43:12  * Sacro just wants to get on and build a compiler
08:46:17  <dihedral> if you have a computer infront of you Sacro... then nothing should stop you &&
08:46:19  <dihedral> ^
08:46:27  <FauxFaux> Our compiler module had no practical stuff in at all.
08:46:41  <dihedral> if you need an editor, have a look at mozilla's bespin project ;-)
09:01:40  *** andythenorth [] has joined #openttd
09:08:02  *** Terkhen [~terkhen@] has quit [Quit: ...]
09:17:52  *** Chris_Booth [] has joined #openttd
09:55:38  *** Pikkaa [PikkaBird@] has joined #openttd
09:56:44  <Yexo> <Pikka> callback 36 for cargo capacity (prop 14) only works if the train vehicle is carrying its original cargo type <- indeed, that's what the code tells me too
09:57:15  <Muxy> Hi Yexo. i have fix my stuff
09:57:20  <Yexo>  /* Set cargo capacity if we've not been refitted */ <- with that comment
09:57:43  <Yexo> Muxy: great (although I can't really remember what it was about, sorry)
09:57:59  <TrueBrain> dihedral: "coming soon!"
09:58:02  <TrueBrain> dihedral: sounds not that useful
09:58:20  <Pikkaa> yexo: why? :P
09:58:22  *** Pikka [PikkaBird@] has quit [Ping timeout: 480 seconds]
09:58:45  *** Pikkaa is now known as Pikka
09:59:16  <Yexo> no idea
09:59:39  <dihedral> TrueBrain,
09:59:45  <dihedral> you can register, and use it online
09:59:46  <dihedral> :-)
09:59:52  <TrueBrain> dihedral: read: "coming soon!" at the most important place
10:00:16  <dihedral> odd, i can login (and could for like a year now)
10:00:20  <dihedral> and use what they have online
10:00:24  <TrueBrain> you can't read :(
10:00:32  *** StM [] has joined #openttd
10:00:36  <dihedral> the online version is 0.4.4
10:01:03  <dihedral> i see no coming soon, that must be the text on the mozilla labs page
10:01:17  <Pikka> yexo, fancy changing it? :P  alternatively, who coded it in the first place, and why did they make it only apply to unrefitted vehicles (I think I know the answer to that already, though)?
10:01:18  <dihedral> oh that one
10:01:21  <dihedral> you silly!!
10:01:29  <TrueBrain> you need glasses
10:01:31  <TrueBrain> big time
10:01:35  <Yexo> Pikka: that's what I'm trying to found out now
10:01:42  <dihedral> that part is for a new feature
10:01:51  <dihedral> you can still, inside bespin, tell it to checkout openttd :-)
10:01:52  <TrueBrain> REALLY?! But as I said: the most important one
10:02:02  <dihedral> that aint the most important one
10:02:07  <TrueBrain> YES
10:02:09  <dihedral> why?
10:02:19  <TrueBrain> because I say so .. dah
10:02:22  <dihedral> ...
10:02:26  <Muxy> yexo: wax a link problem
10:02:36  <TrueBrain> the dir-browser is a bit ... annoying
10:02:37  <Yexo> ah, that one :)
10:02:44  <dihedral> yep, that is true
10:02:56  <TrueBrain> click on open file, enter to really open it
10:02:58  <dihedral> however, one does not need that one feature to work on a project
10:02:58  <TrueBrain> whoho
10:04:05  <Yexo> Pikka: it was changed in r9875
10:04:10  <Yexo> @commit 9875
10:04:10  <DorpsGek> Yexo: Commit by peter1138 :: r9875 trunk/src/train_cmd.cpp (2007-05-19 10:29:51 UTC)
10:04:11  <DorpsGek> Yexo: -Fix (r9828): Only set carriage capacity if the wagon has not been refitted.
10:05:04  <Pikka> :o
10:05:28  <Yexo> r9828 was the revision cb36 was first called for carriage capacity
10:05:45  <Pikka> hmm
10:06:12  <Pikka> I guess that was to stop cb 15 being automatically overriden by cb36 setting the default... :o
10:06:15  <Pikka> ?
10:06:16  <Yexo> that doesn't tell me why it behaves like this
10:06:27  *** boekabart [] has left #openttd []
10:07:10  <Yexo> that is most likely the reason yes
10:07:41  *** Belugas [~belugas@] has quit [Ping timeout: 480 seconds]
10:07:55  <Pikka> how about using 36 for the refitted capacity if the bit for cb 15 is not set in property 1E?
10:08:40  <Yexo> I'm not going to change that
10:08:45  <Yexo> maybe frosch will
10:08:47  <Pikka> ok
10:09:57  *** tokai [] has quit [Ping timeout: 480 seconds]
10:10:13  *** Belugas [~belugas@] has joined #openttd
10:10:16  *** mode/#openttd [+o Belugas] by ChanServ
10:10:26  <Pikka> maybe Belugas will!
10:12:27  *** tokai [] has joined #openttd
10:12:30  *** mode/#openttd [+v tokai] by ChanServ
10:16:02  *** Xeryus|bnc is now known as XeryusTC
10:31:01  *** Muxy [] has quit [Quit: Back to the Goulp]
10:36:36  *** Muxy [] has joined #openttd
10:44:47  <Pikka> maybe Belugas won't...
10:58:59  *** tokai [] has quit [Ping timeout: 480 seconds]
11:01:09  *** tokai [] has joined #openttd
11:01:12  *** mode/#openttd [+v tokai] by ChanServ
11:01:43  *** KenjiE20 [~KenjiE20@] has joined #openttd
11:17:30  <CIA-4> OpenTTD: rubidium * r17744 /extra/masterserver_updater/src/ (5 files in 2 dirs): [MSU] -Change: automatically remove servers that haven't advertised for a while
11:39:15  *** thepalm [~chatzilla@] has quit [Quit: ChatZilla 0.9.85 [Firefox 3.5.3/20090824101458]]
11:43:06  *** zachanima [] has quit [Ping timeout: 480 seconds]
12:09:06  *** Zahl [] has joined #openttd
12:09:42  <Pikka> maybe Rubidium will!
12:11:47  *** glx [glx@2a01:e35:2f59:c7c0:f8d0:93e:8533:84c8] has joined #openttd
12:11:50  *** mode/#openttd [+v glx] by ChanServ
12:12:34  <Pikka> maybe glx will!
12:13:01  <glx> what?
12:13:40  <TrueBrain> Rubidium: why not directly remove servers that haven't been online for, say, a month?
12:13:52  <Pikka> nothing, sorry. :)
12:27:19  <Rubidium> maybe Pikka will
12:28:18  <Rubidium> TrueBrain: that isn't really a priority :)
12:28:37  <TrueBrain> Rubidium: given r17744, that is just a simple copy/paste and a few extra letters
12:28:39  <TrueBrain> 10 minutes :p
12:28:39  <Rubidium> getting those massively duplicated ex servers out was the reason
12:28:48  <TrueBrain> I figured as much ;)
12:28:52  <TrueBrain> I hope it helps ..
12:28:59  <Rubidium> TrueBrain: yes, 10 minutes I didn't have at that time
12:29:12  <Rubidium> testing took longer than expected
12:29:14  * TrueBrain gives Rubidium 10 minutes :)
12:29:19  <TrueBrain> as always ...
12:30:24  <Pikka> Rubidium: but, but...
12:34:11  <Pikka> what has become of petern?
12:46:21  *** andythenorth [] has quit [Quit: andythenorth]
13:07:13  <Belugas> hello
13:07:28  <Belugas> do what Pikka?
13:07:57  <planetmaker> some callback 15/36 stuff
13:08:03  <planetmaker> and hello :-)
13:09:54  <Muxy> hi, wet or dry in canada ?
13:10:22  <glx> or snowy ;)
13:16:17  <Belugas> it's cloudy, around 15 celcius
13:16:29  <Belugas> so far.. it's nice
13:16:47  <Belugas> in the office, it's another story
13:17:10  <Belugas> at least, coffee is freely flowing
13:18:04  <Pikka> Belugas:  <Pikka> how about using 36 for the refitted capacity if the bit for cb 15 is not set in property 1E?
13:18:25  <Pikka> currently cb 36 for capacity only works for the unrefitted cargo :)
13:18:33  <Belugas> hmmm...
13:18:36  <Belugas> is it allowed?
13:18:48  <Belugas> would it break things here and there?
13:19:21  <Belugas> and.. oh my god... vehicles callback!
13:19:24  <Pikka> well, it currently doesn't work for refitted vehicles because it would conflict with cb15
13:19:49  * Belugas shivers and shakes and swallows
13:19:53  <Pikka> :P k
13:23:20  <Pikka> there's already a 36 for capacity, btw, it's just a question of when it applies it. :}
13:23:55  <Pikka> it's all petern's doing, anyhow...
13:28:13  *** Fuco [] has joined #openttd
13:39:21  <fonsinchen> It's always funny to watch the discussions about those piles of ugliness nfo is made of ...
13:39:57  <Belugas> Pikka, honestly, i don't have a clue on that stuff
13:40:08  <Belugas> i can give it a look, even ask petern about it
13:40:47  <Belugas> mmh... is it me or even Lakie is against that stuff?
13:40:50  <Belugas> got to ask him
13:46:45  <Muxy> hot patatoe ?
13:49:56  <Belugas> potatoe
13:50:01  <Belugas> i think
13:50:17  <Pikka> only if you're a vice-presidential candidate
13:50:18  <Belugas> not really... just..  i've not done much on vehicles
13:50:21  <Pikka> otherwise it's potato
13:50:27  <Belugas> :)
13:55:38  *** Coco-Banana-Man [] has joined #openttd
14:02:22  <Sacro> it's all goood
14:05:57  *** George3 [~George@] has quit [Ping timeout: 480 seconds]
14:10:08  *** andythenorth [] has joined #openttd
14:13:54  *** Zahl [] has quit [Quit: *schiel*]
14:14:59  *** Fast2 [] has joined #openttd
14:22:01  *** Mark [] has quit [Remote host closed the connection]
14:24:10  *** Mark [] has joined #openttd
14:24:36  *** ecke [~ecke@] has joined #openttd
14:27:49  *** andythenorth [] has quit [Quit: andythenorth]
14:29:50  *** andythenorth [] has joined #openttd
14:33:11  *** Progman [] has joined #openttd
14:44:41  <Pikka> Yexo: where in the source is that comment? :)
14:45:08  <Pikka> oh wait
14:45:13  <Pikka> nm, stupid... ^^;
14:45:26  <Yexo> train_cmd.cpp:320
14:47:41  <Pikka> yep, you posted the changelog which had it right there, sorry. :)
14:53:53  <Pikka> hmm, I guess I could make the change myself, but I know what my chances of getting it accepted into trunk (and/or 0.7.4) are... :/
14:54:22  <Pikka> *don't* know, even
14:56:29  <Pikka> perhaps I should post about it in the graphics forum, see if anyone would object to the change... :)
14:56:57  <Eddi|zuHause> what does the spec say should happen, and what happens in TTDPatch?
14:57:41  <Pikka> the spec doesn't say that it only applies for the default cargo.  it's not implemented in TTDPatch.
14:58:33  * Belugas fears some desynchs
14:59:03  <Pikka> why?  it's no different from any other callback 36 var (and indeed no different from the current callback 36 for capacity)
15:00:33  <Belugas>   -> /* Cache wagon override sprite group. NULL is returned if there is none */
15:00:36  <Belugas> one of the reasons
15:01:39  <Pikka> eh?  I'm not sure what that has to do with it...  the only change I (think) I want is on line 319
15:01:48  <Pikka> u->cargo_type == e_u->GetDefaultCargoType() && u->cargo_subtype == 0
15:01:50  <Pikka> replaced with
15:01:54  <Pikka> !HasBit(e->info.callback_mask, CBM_VEHICLE_REFIT_CAPACITY)
15:02:03  <Pikka> as far as I can tell :P
15:02:19  <Belugas> well... two ways of knowing
15:02:26  <Pikka> mmhm
15:02:32  <Belugas> 1) dig the history of that line, and all related commits
15:02:45  <Pikka> guess I'll have to get my compiling shoes on
15:02:52  <Belugas> 2) create a patch, a few builds and test live
15:03:36  <Yexo> Belugas: relevant commits are 9875 and r9828
15:04:40  <Yexo> change Pikka described above looks ok codewise, but I don't know if it's ok as it changes the spec
15:06:31  *** Fast2 [] has quit [Ping timeout: 480 seconds]
15:06:33  *** worldemar [~woldemar@] has quit [Read error: Connection reset by peer]
15:07:04  <Pikka> the ttdpatch wiki doesn't go into the nuances of it.. just says that cb36 works for train capacity in ottd.
15:12:47  *** fonsinchen [] has quit [Remote host closed the connection]
15:15:22  <Belugas> thanks Yexo
15:17:28  *** Splex [~splex@] has quit [Remote host closed the connection]
15:21:45  *** andythenorth [] has quit [Quit: andythenorth]
15:22:24  *** worldemar [~woldemar@] has joined #openttd
15:31:31  *** tokai [] has quit [Ping timeout: 480 seconds]
15:33:45  *** tokai [] has joined #openttd
15:33:48  *** mode/#openttd [+v tokai] by ChanServ
15:34:26  *** Zuu [] has joined #openttd
15:40:09  *** tux_mark_5 [] has joined #openttd
15:40:17  *** Lakie [~Lakie@] has joined #openttd
15:41:09  <Pikka> uhoh :)
15:43:00  <Lakie> Hmm?
15:44:28  *** frosch123 [] has joined #openttd
15:44:38  <Pikka> just been talking about some changes to cb36, Lakie
15:44:52  <Lakie> ... what kind of changes
15:46:19  <frosch123> oh, cb36 and cb15, i discussed that with george some time ago
15:46:32  <Pikka> yes frosch123
15:47:40  <frosch123> <- i partly lost track of it though
15:48:10  <Belugas> Pikka, it seems that originally, it was free of constraint
15:48:47  <Belugas> last commit of peter1138 (9875) fixed something that broke it by adding the check
15:48:54  <Belugas> -Fix (r9828): Only set carriage capacity if the wagon has not been refitted.
15:49:01  <Belugas>
15:49:24  <Belugas> so i guess looking back in irc logs will be the proper wayy to go
15:49:25  <frosch123> i changed lots wrt. refitting and capacity around r16000
15:49:30  <frosch123> what is the current problem?
15:50:17  <Pikka> cb36 doesn't work if the vehicle is fitted to a different cargo, and I want it to
15:50:35  <Pikka> perhaps we could have both checks?
15:50:37  <Yexo> from your document: TrainsRefitted capacity:       - If that fails, use callback 36 and apply capacity multipliers relative to the default cargo.<- callback 36 is ignored
15:51:47  <frosch123> 				amount = e->u.rail.capacity; <- yeah CB36 is not called at all
15:52:51  <Yexo> 20 lines below that, in TrainConsistChanged CB36 is called
15:53:01  <frosch123> yup, just looking at that one
15:53:24  <frosch123> but it does not call cb15 there :p
15:55:59  <Zuu> Should fixes/code changes to the core of the window system be labled "core" or "interface" at FS?
15:56:23  <Pikka> I just want the current cb36 to work in a way that doesn't conflict with cb15 ^^;
15:56:25  <Yexo> interface I think
15:56:28  <Zuu> Okay
15:56:35  <Pikka> how does this look for a new line 319:
15:56:42  <Zuu> Even if users will never see any change.
15:56:48  <Pikka> if (e_u->CanCarryCargo() && ((u->cargo_type == e_u->GetDefaultCargoType() && u->cargo_subtype == 0) || (!HasBit(e->info.callback_mask, CBM_VEHICLE_REFIT_CAPACITY))) ) {
15:57:05  <frosch123> Pikka: me and george want cb15 to be always called (even when not refitted) and if it fails then cb36 to be called
15:57:16  <Yexo> Zuu: pick whatever you think best,it can always be changed later if needed
15:57:22  <Zuu> Sure
15:57:40  <Pikka> frosch: why?
15:58:06  <frosch123> to work for both known an unknown cargos
15:58:11  <Zuu> I just learned that bug fixes that contain patches probably should be labled as "bug" since SmartZ changed a patch task to bug that contained a bug fix.
15:58:17  <Pikka> that...
15:58:21  <Pikka> makes no sense...
15:58:29  <Lakie> unknown cargos?
15:58:32  <frosch123> and to work sane if default cargo is "first refittable"
15:58:40  <Pikka> hmm
15:58:42  <frosch123> Lakie: not part of translation table
15:59:18  <frosch123> known cargos use cb15, and default cargos use cb36 with some multipliers
15:59:29  *** thingwath [] has joined #openttd
15:59:34  <Pikka> why not just use callback 36 in that case?  what can you do with a callback 15 that's called on build that you can't do with callback 36?
16:00:18  <frosch123> cb15 returns the exact capacity, cb36 returns some value that is multiplied depending on passenger, mail, goods or other cargo
16:00:41  <Pikka> cb36 returns an exact capacity
16:00:51  <frosch123> not for all vehicles
16:00:54  <Pikka> oh
16:01:07  <frosch123> see my documentation :)
16:01:46  <Pikka> well... it should :P
16:02:00  <frosch123> no, property14 does not either
16:03:22  <frosch123> you want a 350 passenger plane refittable to 350 tons coal?
16:03:45  *** Progman [] has quit [Remote host closed the connection]
16:03:54  <Pikka> I want it refittable to however many units I tell it to be refittable to
16:04:09  <frosch123> then use cb15
16:04:29  <Pikka> rather than however many units I tell it to be refittable to * some pointless multiplier
16:05:05  <Pikka> hmm
16:05:39  <frosch123> "Unlike regular refitted capacities, the return value is not subject to the usual division of capacities for cargoes other than passengers on trains and planes, instead the capacity is used exactly as returned by the callback." <- that is the central point of cb15, the central point of cb36 is to behave exactly like the properties
16:06:04  <frosch123> (though currently cb 15 is not called always, and was we learned today cb 36 neither)
16:06:31  *** th1ngwath [] has quit [Ping timeout: 480 seconds]
16:06:49  <Pikka> hmm
16:07:53  <Pikka> (btw, in case it's not obvious, my current problem is trying to change capacities on events other than building and refitting)
16:08:32  <frosch123> will be a nice desyncer
16:09:22  <Pikka> hmm
16:09:23  *** Biolunar [] has joined #openttd
16:09:28  <frosch123> capacity is only updated in depots and when joining game
16:09:36  <frosch123> if the capacity changes outside, they will differ
16:09:44  <Pikka> it's still in the depot
16:10:00  <Pikka> on rearranging in the depot
16:10:07  <frosch123> then it is fine
16:10:45  <Pikka> except it doesn't work, except with the default cargo, thanks to line 319. ;)
16:11:19  *** Terkhen [] has joined #openttd
16:12:42  <Terkhen> hello
16:12:52  <Yexo> hello Terkhen
16:16:35  *** welshdragon [~markjones@] has joined #openttd
16:19:36  *** fonsinchen [] has joined #openttd
16:21:06  *** Polygon [] has joined #openttd
16:22:47  *** Chruker [] has joined #openttd
16:23:24  *** andythenorth [] has joined #openttd
16:37:58  <Zuu> 4 focus-related patches in 2 days :-) And one more idea..
16:38:27  <Zuu> Mostly small code changing/fixing patches though.
16:40:01  <Zuu> Im also thinking about writing a wiki page with some information about the focus system.
16:40:24  <Yexo> Zuu: about FS#3257, I think it's better to introduce a new function like GetWidgetOfType that returns the widget index
16:41:05  <Yexo> or alternativly somethinglike SetFocusedWigetByType
16:41:08  <Zuu> You mean instead of wi - this->parent->widget?
16:41:11  <Yexo> yes
16:42:25  <Zuu> The widget index minus start pointer method is used elsewhere I think.
16:42:46  <Zuu> I can agree it is not really beutifull though.
16:42:57  <Pikka> night all
16:42:58  *** Pikka [PikkaBird@] has quit []
16:43:13  <Yexo> when reading that diff it's not really obvious to me that both pointers are from the same array, and as such I don't like the code
16:44:34  <Zuu> Actually I vaguly remember that I coded a GetWidgetIndex function that got rejected because of the pointer aremetics that you can use instead. But I'm not sure if it was really rejected or if it was just opinions thrown around.
16:45:11  <Yexo> oh, better ask Alberth in that case
16:45:27  <Yexo> before I advise you to rewrite your patch in a way that'll be rejected by him
16:45:47  <Zuu> Yea, I haven't seen him around since I started to tip on the widget code lately. But I should probably get his opinion on stuff before doing to much.
16:47:32  <Zuu> FS#3257 I just stumbled across when I was making FS#3256 and was looking for places in trunk where the introduced UnfocusFocusedWidget function could be used.
16:49:23  <Yexo> about FS#3256: if (this->focused_widget) { <- misses != NULL
16:49:44  <Yexo> and you could move the this->*_widget = NULL; in the if-block so it isn't set when already NULL
16:50:43  <Zuu> hmm, yea != NULL is missing. I guess it should be there just for clearaty. Or is there a difference in execution with having != NULL also?
16:50:55  <Yexo> no, it's just code style
16:50:59  <Zuu> Ok
16:51:06  <Zuu> But I'll sure add it.
16:51:42  <Yexo> and personally I'd change "if (this->nested_array != NULL) {" to "assert(this->nested_array != NULL);" and thus leave out the NOT_REACHED() at the end
16:52:07  <Yexo> that makes it more clear what code is required for nested widgets and which code is temporary to support the old widget system (the first if-block)
16:53:15  <Zuu> I just copied how Alberth(?) did it for SetFoculedWidget.
16:53:24  <Zuu> SetFocusedWidget*
16:53:37  <Zuu> So that it is concistent with that.
16:53:50  <Yexo> I see, it's fine then
16:54:20  <Zuu> But i'll move the = NULL part so no assignment is done if the variable is already NULL.
16:57:42  <Zuu> Yexo: I've added an update:
16:58:04  <Zuu> Maybe a blank line between ...SetDirty() and the NULL assignment?
16:58:48  <Yexo> possible, not necesary
16:59:17  *** Doorslammer [] has quit [Ping timeout: 480 seconds]
16:59:17  <Zuu> Ok, then I'll leave it as it is untill someone demands me to add it. ;-)
16:59:45  <Yexo> "In trunk I don't see anywhere this function will be used" <- that however is a major reason not to include the function
17:00:42  <Zuu> I realize that. So maybe it is better to just include it in the sign list patch for now.
17:01:13  *** Doorslammer [] has joined #openttd
17:01:25  <Yexo> that makes me wonder if the first part of the function (for non-nested widgets) is actually useful
17:01:31  <Zuu> Even though, not having the function make it quite hard to figure out how to unfocus widgets as it is now.
17:01:55  <Yexo> since new windows should only have nested widgets, and old windows don't need it (or at least don't use it currently)
17:01:56  <Zuu> Why would it not be usefull?
17:02:34  <Zuu> The reason why it is not used currently is that no window currently want to unfocus a widget. Or at least noone have found out how to do it.
17:03:12  *** worldemar [~woldemar@] has quit [Ping timeout: 480 seconds]
17:03:39  <Yexo> that no window currently want to unfocus a widget <- _if_ that is true, then the first part is useless, because as I said, new windows should only use nested widgets
17:04:49  <Zuu> Except for modifications to old windows.
17:05:14  <Zuu> Though I guess a patch to an old window has low chance of getting accepted before the window gets converted.
17:05:23  <Yexo> if that's needed,just update the window first to nested windows
17:05:36  <Yexo> so yes
17:06:38  <Zuu> True, but if we would add the UnfocusFocusedWidget, it seams strange to make it only work with nested widgets just because implicitly old widget windows wont use it.
17:07:50  <Zuu> Arguing that one should use "this->nested_focus->SetDirty(); this->nested_focus = NULL;" I could understand though.
17:08:43  <Yexo> the old widget system will be removed as soon as all windows are converted, so why add code that won't be used and will be removed 'soon'?
17:09:53  <Zuu> I don't have a good answer to that other than 'soon' might be not very soon.
17:11:44  <Zuu> The best argumnet I could give is that adding a UnfocusFocusedWidget() function will make it more clear how to unfocus a widget. And then adding a function that does not work with the old widget system when it is just a matter of a few more lines seams strange to me. Especially if the idea with the function is to make things more understandable.
17:12:00  <Zuu> This argument is not very strong I understand though.
17:14:44  <Yexo> I understand your point
17:15:12  <Yexo> for me it's all part of the bigger "don't add code that isn't used"
17:15:34  *** Muxy [] has quit [Quit: Back to the Goulp]
17:15:38  <Zuu> Okay, I'll buy that.
17:16:59  *** worldemar [~woldemar@] has joined #openttd
17:17:18  <Zuu> That said if the action "unfocus focused widget" would be performed, I think that should be absracted as a function so that only the Widget System should deal with how that action is performed. But I guess my only opinion is to make use of that action and have that peice of code accepted to trunk. ;-)
17:19:24  <Yexo> opinion? Did you mean option?
17:19:40  <Zuu> yea, it should be option.
17:19:47  <Belugas> or oignon?
17:23:24  <Zuu> Belugas: You mean onion?
17:24:01  <Eddi|zuHause> opium?
17:24:13  <Belugas> hem... onion
17:24:17  <Belugas> gaaaa
17:24:31  <Zuu> ... probably not then ...
17:25:53  *** thisismyname [~chatzilla@] has joined #openttd
17:26:19  *** Dred_furst [] has joined #openttd
17:30:53  *** frosch123 [] has quit [Remote host closed the connection]
17:36:36  *** Chris_Booth [] has quit [Ping timeout: 480 seconds]
17:39:11  *** andythenorth [] has quit [Quit: andythenorth]
17:39:43  *** thisismyname [~chatzilla@] has quit [Remote host closed the connection]
17:45:55  <CIA-4> OpenTTD: translators * r17745 /trunk/src/lang/ (9 files in 2 dirs): (log message trimmed)
17:45:55  <CIA-4> OpenTTD: -Update from WebTranslator v3.0:
17:45:55  <CIA-4> OpenTTD: simplified_chinese - 1 changes by Gavin
17:45:55  <CIA-4> OpenTTD: dutch - 1 changes by habell
17:45:55  <CIA-4> OpenTTD: finnish - 1 changes by jpx_
17:45:56  <CIA-4> OpenTTD: french - 1 changes by glx
17:45:56  <CIA-4> OpenTTD: german - 1 changes by planetmaker
17:48:31  *** Progman [] has joined #openttd
17:49:56  <Sacro> So there's open source theme hospital now
17:54:43  <Zuu> Oh, nice
17:55:05  <Zuu> But I kind of have lost my interest of it. Even though I played it a lot when I was younger.
17:55:08  <Sacro>
17:56:52  * Zuu wonders why they on the video hires a lot of staff without building any rooms. But I guess building rooms is not implemented yet...
17:57:01  <Zuu> Oh, now they build a room. :-)
17:57:36  <Eddi|zuHause> hm... theme hospital... is that something like Biing?
17:57:47  <Zuu> Biing?
17:58:18  <Eddi|zuHause>!
17:58:29  *** Hirundo_ is now known as Hirundo
18:00:48  <Zuu> The patients in CorsixTH at least seams to be good at standing in formations. :-)
18:02:48  <Ammler> Eddi|zuHause: looks like "Der Planer"
18:07:26  *** fonsinchen [] has quit [Remote host closed the connection]
18:10:11  <Eddi|zuHause> hm, what's the magic incantation to gcc that makes "cc1plus: warnings being treated as errors" disappear?
18:10:30  *** PierreW [] has quit [Remote host closed the connection]
18:11:05  *** Fast2 [] has joined #openttd
18:11:47  <Yexo> -Werror ?
18:18:43  *** Terkhen [] has quit [Quit: ...]
18:23:11  *** Terkhen [] has joined #openttd
18:25:07  <Zuu> I've just created which documents a little bit on the focus system.
18:26:22  <Zuu> I hope it fit in the OpenTTDDevBlackBook.
18:29:35  <Zuu> How do I edit the DevDoc template so it includes a link to the page in the yellow menu box?
18:30:25  <Zuu> Oh, it is.
18:33:16  *** George [~George@] has joined #openttd
18:45:21  *** Chris_Booth [] has joined #openttd
18:51:26  *** ecke_ [~ecke@] has joined #openttd
18:51:26  *** ecke [~ecke@] has quit [Read error: Connection reset by peer]
19:08:32  *** andythenorth [] has joined #openttd
19:12:36  *** HerzogDeXtEr1 [~Flex@] has joined #openttd
19:19:32  *** HerzogDeXtEr [~Flex@] has quit [Ping timeout: 480 seconds]
19:22:13  *** andythenorth [] has quit [Quit: andythenorth]
19:34:56  *** Biolunar [] has quit [Quit: brb]
19:35:54  *** Biolunar [] has joined #openttd
19:38:45  *** Seberoth [] has joined #openttd
19:40:21  *** codl [] has joined #openttd
19:42:36  <Seberoth> hi
19:45:50  <Yexo> hello Seberoth
19:55:39  *** andythenorth [~andy@] has joined #openttd
19:55:53  <Zuu> Hi Seberoth
19:57:16  *** fonsinchen [] has joined #openttd
20:12:35  *** KritiK [] has joined #openttd
20:14:08  *** Dred_furst` [] has joined #openttd
20:15:22  *** Dred_furst [] has quit [Ping timeout: 480 seconds]
20:17:54  *** frosch123 [] has joined #openttd
20:21:35  *** Doorslammer [] has quit []
20:25:13  *** helb_ [~helb@] has joined #openttd
20:29:55  *** Splex [~splex@] has joined #openttd
20:30:40  *** codl [] has quit [Quit: codl]
20:31:51  *** ecke_ [~ecke@] has quit [Quit: ecke_]
20:35:43  *** helb_ [~helb@] has quit [Quit: ZNC -]
20:42:14  *** Rubix`` [~wrqwer@] has joined #openttd
20:42:59  <Terkhen> good night
20:43:01  *** Terkhen [] has quit [Quit: ...]
20:43:08  <Belugas> night
20:53:11  *** boekabart [] has joined #openttd
20:54:07  *** tux_mark_5 [] has quit [Quit: KVIrc Insomnia 4.0.0, revision: , sources date: 20090115, built on: 2009/03/07 00:45:02 UTC]
21:00:58  *** Rubix`` [~wrqwer@] has quit [Quit: Ping timeout: 540 seconds]
21:01:55  *** boekabart_ [] has joined #openttd
21:07:55  *** Seberoth [] has quit [Quit: get satisfied! • :: ««« (Gamers.IRC) »»» ::]
21:08:45  *** boekabart [] has quit [Ping timeout: 480 seconds]
21:14:40  *** frosch123 [] has quit [Remote host closed the connection]
21:17:02  *** Biolunar [] has quit [Quit: gn8]
21:27:37  *** thepalm [~chatzilla@] has joined #openttd
21:30:07  *** Progman [] has quit [Remote host closed the connection]
21:32:15  <andythenorth> large trucks are brutally effective on a short feeder route to a dock.  Industry production goes up, I can't get the ships in fast enough :P
21:32:20  <andythenorth> maybe I need bigger boats...
21:33:39  *** Chrill [~chrischri@] has joined #openttd
21:41:06  <Zuu> Oneplatform secondary stations are a bit challenging.
21:41:59  <andythenorth> is there any chance that the rv offsets got shifted by mistake (or intention)?  Both HEQS and eGRVTS are driving over the center line in certain angles...
21:42:10  <andythenorth> ....  Thought it was my mistake in the grf, but would Zephyris make the identical mistake?
21:42:18  <Zuu> I have a secondary cargo train that I have set up the orders so that it goes to its unload station if it has some cargo on it, else it goes to a delay station where it sits around and waits a 20 days and then try again.
21:43:14  <Zuu> So that trains with the source cargo for the industry can access the industry station.
21:43:28  <Eddi|zuHause> why the hell do you do that?
21:43:53  <Zuu> Because the town refuses me to expand the industry station.
21:44:15  <Zuu> And I do not want it to run over my mainline all the time.
21:44:18  <Eddi|zuHause> that is unfortunate planning, i'd say ;)
21:45:02  <Zuu> Also I like setting up advanced systems :-)
21:45:36  <Eddi|zuHause> well, but your "advanced" system is not really good on the ratings ;)
21:46:05  <Zuu> Sure, but it gets the goods from the station without blocking the inflow to it.
21:46:24  <Zuu> And the ratings are still 45% at the moment.
21:47:55  <Eddi|zuHause> 45% != 67%
21:48:13  <Eddi|zuHause> (67% is about "always a train waiting")
21:48:47  <Zuu> But if there would be a train always waiting then there will be no sources incomming to the industry..
21:50:04  *** Fast2 [] has quit [Remote host closed the connection]
21:50:22  *** StM [] has quit []
22:05:00  *** PierreW [] has joined #openttd
22:05:01  *** Nite_Owl [] has joined #openttd
22:05:20  <Nite_Owl> Hello all
22:17:47  *** Coco-Banana-Man [] has quit [Quit: Joyful it seems - but then suddenly - by one false move it's blown away]
22:18:17  *** andythenorth [~andy@] has quit [Quit: andythenorth]
22:25:53  <Eddi|zuHause> aaah... my eyes... i just saw Belugas rejecting a feature because it is NOT realistic
22:28:27  *** welshdragon [~markjones@] has quit [Ping timeout: 480 seconds]
22:41:31  *** thepalm [~chatzilla@] has quit [Quit: ChatZilla 0.9.85 [Firefox 3.5.3/20090824101458]]
22:42:57  *** nicfer1 [~Usuario@] has joined #openttd
22:44:55  *** Cybertinus [] has quit [Remote host closed the connection]
22:45:27  *** Rubix`` [~wrqwer@] has joined #openttd
22:54:35  *** fonsinchen [] has quit [Remote host closed the connection]
22:57:00  *** Nite_Owl [] has quit [Quit: Read You Soon]
23:01:14  *** Dred_furst` [] has quit [Quit: Leaving]
23:01:18  *** Rubix`` [~wrqwer@] has quit [Quit: Ping timeout: 540 seconds]
23:05:56  <Belugas> lol
23:06:17  <Belugas> i knew it would create a few reactions :D
23:12:33  *** Polygon [] has quit [Quit: Flieht, ihr Narren!]
23:15:39  <Belugas> so... back to my son
23:15:41  <Belugas> bye bye
23:16:10  *** welshdragon [~markjones@] has joined #openttd
23:24:35  *** Dred_furst [] has joined #openttd
23:32:55  *** Eddi|zuHause [] has quit []
23:33:22  *** Eddi|zuHause [] has joined #openttd
23:40:09  *** Chrill [~chrischri@] has quit []
23:40:57  *** Zuu [] has quit [Quit: Leaving]
23:50:06  *** Chris_Booth [] has quit [Ping timeout: 480 seconds]
23:52:36  *** KenjiE20 [~KenjiE20@] has quit [Ping timeout: 480 seconds]

Powered by YARRSTE version: svn-trunk